On Thu, 2015-07-09 at 12:10 +0100, Mark Brown wrote: > On Thu, Jul 09, 2015 at 09:48:13AM +0800, Koro Chen wrote: > > > Do you think I should use devm_request_threaded_irq(), and change > > free_irq to devm_free_irq in remove? Or I should keep the original > > request_thread_irq(), and just add a free_irq() during probe failed? > > I'd just keep request_threaded_irq() and use free_irq(). OK, thanks, I will send a new patch. And about the patch 2/2 regulator support, is there any problem I should also fix?
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/