Re: [PATCH V3 7/8] arm64: dts: qcom: ipq9574: add nodes to bring up q6

2025-01-09 Thread Konrad Dybcio
On 7.01.2025 11:16 AM, Gokul Sriram Palanisamy wrote: > From: Manikanta Mylavarapu > > Enable nodes required for q6 remoteproc bring up. > > Signed-off-by: Manikanta Mylavarapu > Signed-off-by: Gokul Sriram Palanisamy > --- The comments you got on patch 6 apply here and to patch 8 too Konrad

Re: [PATCH V3 6/8] arm64: dts: qcom: ipq5332: add nodes to bringup q6

2025-01-09 Thread Konrad Dybcio
On 7.01.2025 11:16 AM, Gokul Sriram Palanisamy wrote: > From: Manikanta Mylavarapu > > Enable nodes required for q6 remoteproc bring up. > > Signed-off-by: Manikanta Mylavarapu > Signed-off-by: Gokul Sriram Palanisamy > --- [...] > + q6v5_wcss: remoteproc@d10 { > +

Re: [PATCH 4/5] arm64: dts: qcom: qcm6490-fairphone-fp5: Prefix regulator-fixed label

2025-01-03 Thread Konrad Dybcio
On 3.01.2025 12:12 PM, Luca Weiss wrote: > Add the common vreg_ prefix to the labels of the regulator-fixed. Also > make sure the nodes are sorted alphabetically. > > Signed-off-by: Luca Weiss > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 5/5] arm64: dts: qcom: qcm6490-fairphone-fp5: Enable camera EEPROMs

2025-01-03 Thread Konrad Dybcio
s > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH] soc: qcom: pd_mapper: Add SM7225 compatible

2024-12-20 Thread Konrad Dybcio
On 20.12.2024 11:15 AM, Luca Weiss wrote: > On Fri Dec 20, 2024 at 10:39 AM CET, Konrad Dybcio wrote: >> On 20.12.2024 9:39 AM, Luca Weiss wrote: >>> The Qualcomm SM7225 is practically identical to SM6350, so add an entry >>> using that data. >>> >>&g

Re: [PATCH 2/2] clk: qcom: dispcc-sm6350: Add missing parent_map for a clock

2024-12-20 Thread Konrad Dybcio
ata as well to keep the matching parent_map and > parent_data together. > > Fixes: 837519775f1d ("clk: qcom: Add display clock controller driver for > SM6350") > Cc: > Signed-off-by: Luca Weiss > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 1/2] clk: qcom: gcc-sm6350: Add missing parent_map for two clocks

2024-12-20 Thread Konrad Dybcio
On 20.12.2024 11:21 AM, Luca Weiss wrote: > On Fri Dec 20, 2024 at 10:42 AM CET, Konrad Dybcio wrote: >> On 20.12.2024 10:03 AM, Luca Weiss wrote: >>> If a clk_rcg2 has a parent, it should also have parent_map defined, >> >> ^ >>

Re: [PATCH 2/2] clk: qcom: dispcc-sm6350: Add missing parent_map for a clock

2024-12-20 Thread Konrad Dybcio
On 20.12.2024 10:03 AM, Luca Weiss wrote: > If a clk_rcg2 has a parent, it should also have parent_map defined, > otherwise we'll get a NULL pointer dereference when calling clk_set_rate > like the following: Same as patch 1 Konrad

Re: [PATCH 1/2] clk: qcom: gcc-sm6350: Add missing parent_map for two clocks

2024-12-20 Thread Konrad Dybcio
On 20.12.2024 10:03 AM, Luca Weiss wrote: > If a clk_rcg2 has a parent, it should also have parent_map defined, ^ freq_tbl > otherwise we'll get a NULL pointer dereference when calling clk_set_rate > like the following: > > [3.388105] Call trac

Re: [PATCH] soc: qcom: pd_mapper: Add SM7225 compatible

2024-12-20 Thread Konrad Dybcio
On 20.12.2024 9:39 AM, Luca Weiss wrote: > The Qualcomm SM7225 is practically identical to SM6350, so add an entry > using that data. > > Signed-off-by: Luca Weiss > --- I think we should instead add the fallback compatible, like - enum: - asdf,asdf - const: qcom,sm7225 - const: qcom,sm63

Re: [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Drop extra qcom,msm-id value

2024-12-20 Thread Konrad Dybcio
ation. > --- It would be nice if you could start shifting that tooling to bootimgv2 slowly, and when it trickles down to appropriate places, switch it up upstream as well. Of course if that works for you. Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH] arm64: dts: qcom: sm6350: Fix uart1 interconnect path

2024-12-20 Thread Konrad Dybcio
35b887b ("arm64: dts: qcom: sm6350: add uart1 node") > Cc: sta...@vger.kernel.org > Signed-off-by: Luca Weiss > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH] arm64: dts: qcom: msm8916-samsung-serranove: Add display panel

2024-12-14 Thread Konrad Dybcio
t; to the panel > node to correct that. > > Signed-off-by: Stephan Gerhold > Co-developed-by: Jakob Hauser > Signed-off-by: Jakob Hauser > --- Reviewed-by: Konrad Dybcio Konrad

[PATCH] dt-bindings: remoteproc: Consolidate SC8180X and SM8150 PAS files

2024-11-16 Thread Konrad Dybcio
From: Konrad Dybcio SC8180X PAS bindings are plain wrong, resulting in false-positive dt checker errors. SC8180X's remoteprocs happen to be identical to SM8150's from the kernel point of view, so reuse that binding instead. Fixes: 4865ed136045 ("dt-bindings: remoteproc: qcom: p

Re: [PATCH 6/6] remoteproc: qcom: Enable map/unmap and SHM bridge support

2024-10-25 Thread Konrad Dybcio
On 4.10.2024 11:23 PM, Mukesh Ojha wrote: > For Qualcomm SoCs runnning with Qualcomm EL2 hypervisor(QHEE), IOMMU > translation for remote processors is managed by QHEE and if the same SoC > run under KVM, remoteproc carveout and devmem region should be IOMMU > mapped from Linux PAS driver before re

Re: [PATCH 5/6] remoteproc: qcom: Add support of SHM bridge to enable memory protection

2024-10-25 Thread Konrad Dybcio
On 4.10.2024 11:23 PM, Mukesh Ojha wrote: > Qualcomm SoCs running with the Qualcomm EL2 hypervisor(QHEE) have been > utilizing the Peripheral Authentication Service (PAS) from its TrustZone > (TZ) firmware to securely authenticate and reset via sequence of SMC > calls like qcom_scm_pas_init_image()

Re: [PATCH 3/6] remoteproc: qcom: Add helper function to support IOMMU devmem translation

2024-10-17 Thread Konrad Dybcio
On 10.10.2024 8:59 AM, neil.armstr...@linaro.org wrote: > Hi, > > On 07/10/2024 16:37, Mukesh Ojha wrote: >> On Mon, Oct 07, 2024 at 10:08:16AM +0200, neil.armstr...@linaro.org wrote: >>> On 04/10/2024 23:23, Mukesh Ojha wrote: From: Shiraz Hashim Qualcomm SoCs runnning with Qualco

Re: [PATCH] arm64: dts: qcom: qcm6490-fairphone-fp5: Add thermistor for UFS/RAM

2024-10-07 Thread Konrad Dybcio
one-fp5.dts >>>> @@ -207,6 +207,20 @@ active-config0 { >>>> }; >>>> }; >>>> >>>> + mem-thermal { >>>> + polling-delay-passive = <0>; This is now redundant - see Commit 488164006a28 ("thermal/of: Assume polling-delay(-passive) 0 when absent") with it removed Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 06/19] dt-bindings: power: rpmpd: Add QCS8300 power domains

2024-09-05 Thread Konrad Dybcio
On 5.09.2024 1:30 PM, Konrad Dybcio wrote: > On 4.09.2024 10:33 AM, Jingyi Wang wrote: >> From: Shazad Hussain >> >> Add compatible and constants for the power domains exposed by the RPMH >> in the Qualcomm QCS8300 platform. >> >> Signed-off-by: Shazad H

Re: [PATCH 06/19] dt-bindings: power: rpmpd: Add QCS8300 power domains

2024-09-05 Thread Konrad Dybcio
On 4.09.2024 10:33 AM, Jingyi Wang wrote: > From: Shazad Hussain > > Add compatible and constants for the power domains exposed by the RPMH > in the Qualcomm QCS8300 platform. > > Signed-off-by: Shazad Hussain > Signed-off-by: Tingguo Cheng > Signed-off-by: Jingyi Wang > --- > .../devicetree

Re: [PATCH v2 1/5] Revert "soc: qcom: smd-rpm: Match rpmsg channel instead of compatible"

2024-08-29 Thread Konrad Dybcio
t; Revert the commit bcabe1e09135 ("soc: qcom: smd-rpm: Match rpmsg channel > instead of compatible") > > Fixes: bcabe1e09135 ("soc: qcom: smd-rpm: Match rpmsg channel instead of > compatible") > Cc: sta...@vger.kernel.org > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 0/3] Add DisplayPort sound support for Fairphone 5 smartphone

2024-08-10 Thread Konrad Dybcio
On 9.08.2024 10:33 AM, Luca Weiss wrote: > Add the necessary sound card bits and some dts additions to enable sound > over DisplayPort-over-USB-C, e.g. to a connected TV or monitor. > > The UCM files can be found here: > https://gitlab.com/postmarketOS/pmaports/-/tree/master/device/testing/device-

Re: [PATCH v2 4/5] ARM: dts: qcom: add generic compat string to RPM glink channels

2024-07-30 Thread Konrad Dybcio
On 29.07.2024 9:52 PM, Dmitry Baryshkov wrote: > Add the generic qcom,smd-rpm compatible to RPM nodes to follow the > schema. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 5/5] arm64: dts: qcom: add generic compat string to RPM glink channels

2024-07-30 Thread Konrad Dybcio
On 29.07.2024 9:52 PM, Dmitry Baryshkov wrote: > Add the generic qcom,smd-rpm / qcom,glink-smd-rpm compatible to RPM > nodes to follow the schema. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 01/11] arm64: dts: qcom: sm6115-pro1x: Add Hall Switch and Camera Button

2024-07-29 Thread Konrad Dybcio
On 25.07.2024 3:42 AM, Dang Huynh wrote: > The Pro1X has a flip keyboard and a single-state camera button. > > Signed-off-by: Dang Huynh > --- [...] > > &tlmm { > gpio-reserved-ranges = <0 4>, <14 4>; > + > + hall_sensor_n: hall-sensor-n { These must end in -state to pass binding

Re: [PATCH v2 06/11] arm64: dts: qcom: sm6115-pro1x: Enable MDSS and GPU

2024-07-25 Thread Konrad Dybcio
On 25.07.2024 3:42 AM, Dang Huynh wrote: > Fxtec Pro1x uses the same display (BOE BF060Y8M-AJ0) as Pro1. > > Signed-off-by: Dang Huynh > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 05/11] arm64: dts: qcom: sm6115-pro1x: Enable SD card slot

2024-07-25 Thread Konrad Dybcio
On 25.07.2024 3:42 AM, Dang Huynh wrote: > Fxtec Pro1X has two card slots and allow either 2xSIM cards or > 1xSIM, 1xSD Card configuration. > > Signed-off-by: Dang Huynh > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 04/11] arm64: dts: qcom: sm6115-pro1x: Add Caps Lock LED

2024-07-25 Thread Konrad Dybcio
On 25.07.2024 3:42 AM, Dang Huynh wrote: > The Pro1X has a caps lock LED on the keyboard. > > Signed-off-by: Dang Huynh > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 11/11] arm64: dts: qcom: sm6115-pro1x: Enable ATH10K WLAN

2024-07-25 Thread Konrad Dybcio
0 > fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.3.2.4-00982-QCAHLSWMTPLZ-1 > > Signed-off-by: Dang Huynh > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH] arm64: dts: qcom: msm8916-samsung-fortuna: Add touch keys

2024-07-24 Thread Konrad Dybcio
message and keep a link to the previous one & a changelog under the --- line in this instance, don't bother as it's a simple change and it looks good now Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH] arm64: dts: qcom: msm8916-samsung-fortuna: Enable the touchkeys

2024-07-23 Thread Konrad Dybcio
On 23.07.2024 3:39 PM, Raymond Hackley wrote: >> Fixes? >> >> Konrad > > Hi Konrad, > > the issue is not reported or discussed on lkml, so there is no thread to fix? See the "In case your patch fixes a bug.." paragraph in: https://docs.kernel.org/process/submitting-patches.html > > Regards, >

Re: [PATCH] arm64: dts: qcom: msm8916-samsung-rossa: Add touchscreen

2024-07-23 Thread Konrad Dybcio
On 23.07.2024 3:15 PM, Raymond Hackley wrote: > Core Prime uses an Imagis IST3038 touchscreen that is connected to > blsp_i2c5. Add it to the device tree. > > Signed-off-by: Raymond Hackley > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH] arm64: dts: qcom: msm8916-samsung-fortuna: Enable the touchkeys

2024-07-23 Thread Konrad Dybcio
On 23.07.2024 3:12 PM, Raymond Hackley wrote: > The phone needs the touchkeys to be enabled so the sense lines of the > touch controller are mapped properly. Otherwise the touchscreen is not > mapped to the display properly. > > Signed-off-by: Raymond Hackley > --- Fixes? Konrad

Re: [PATCH v3 7/9] dt-bindings: interconnect: qcom: msm8939: Fix example

2024-07-23 Thread Konrad Dybcio
On 9.07.2024 12:22 PM, Adam Skladowski wrote: > For now example list snoc_mm as children of bimc which is obviously > not valid, drop bimc and move snoc_mm into snoc. > > Signed-off-by: Adam Skladowski > --- loool, thanks Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 11/12] arm64: dts: qcom: sm6115-pro1x: Enable remoteprocs

2024-07-22 Thread Konrad Dybcio
On 22.07.2024 9:10 AM, Dang Huynh wrote: > Enable [A,C]DSP and MPSS remote processor on this device. > > Signed-off-by: Dang Huynh > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 09/12] arm64: dts: qcom: sm6115-pro1x: Add PMI632 Type-C property

2024-07-22 Thread Konrad Dybcio
On 22.07.2024 9:10 AM, Dang Huynh wrote: > The USB-C port is used for powering external devices and transfer > data from/to them. > > Signed-off-by: Dang Huynh > --- Reviewed-by: Konrad Dybcio Konradqmpphy_out { > + remote-endpoint = <&pmi632_ss_in>; > +}; &

Re: [PATCH 07/12] arm64: dts: qcom: sm6115-pro1x: Hook up USB3 SS

2024-07-22 Thread Konrad Dybcio
On 22.07.2024 9:10 AM, Dang Huynh wrote: > The F(x)tec Pro1X supports USB 3.0 through it's USB-C port. > > Signed-off-by: Dang Huynh > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 06/12] arm64: dts: qcom: sm6115-pro1x: Enable MDSS and GPU

2024-07-22 Thread Konrad Dybcio
On 22.07.2024 11:17 AM, Dang Huynh wrote: >>> +&mdss_dsi0_phy { >>> + status = "okay"; >> >> No power supplies? >> >> Konrad > > Doesn't seem to be defined anywhere on downstream, may be hardware controlled. my downstream suggests L1b Konrad

Re: [PATCH 12/12] arm64: dts: qcom: sm6115-pro1x: Enable ATH10K WLAN

2024-07-22 Thread Konrad Dybcio
On 22.07.2024 9:10 AM, Dang Huynh wrote: > Enable onboard Wi-Fi on the F(x)tec Pro1X. > > For reference, HW/SW identifies as: > qmi chip_id 0x120 chip_family 0x4007 board_id 0xff soc_id 0x4067 > qmi fw_version 0x324103d6 fw_build_timestamp 2021-12-02 08:20 > fw_build_id QC_IMAGE_VERSION_STRING

Re: [PATCH 10/12] arm64: dts: qcom: sm6115-pro1x: Enable RGB LED

2024-07-22 Thread Konrad Dybcio
On 22.07.2024 9:10 AM, Dang Huynh wrote: > This device has an RGB LED. It is used for notifications. > > Signed-off-by: Dang Huynh > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 06/12] arm64: dts: qcom: sm6115-pro1x: Enable MDSS and GPU

2024-07-22 Thread Konrad Dybcio
On 22.07.2024 9:10 AM, Dang Huynh wrote: > Fxtec Pro1x uses the same display (BOE BF060Y8M-AJ0) as Pro1. > > Signed-off-by: Dang Huynh > --- [...] > + panel: panel@0 { > + compatible = "boe,bf060y8m-aj0"; > + reg = <0>; > + > + reset-gpios = <&tlmm 82 GP

Re: [PATCH 04/12] arm64: dts: qcom: sm6115-pro1x: Add Caps Lock LED

2024-07-22 Thread Konrad Dybcio
On 22.07.2024 9:10 AM, Dang Huynh wrote: > The Pro1X has a caps lock LED on the keyboard. > > Signed-off-by: Dang Huynh > --- > arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts

Re: [PATCH 03/12] arm64: dts: qcom: sm6115-pro1x: Add Goodix Touchscreen

2024-07-22 Thread Konrad Dybcio
On 22.07.2024 9:10 AM, Dang Huynh wrote: > The Fxtec Pro1X touchscreen uses Goodix GT9286 chip. > > Signed-off-by: Dang Huynh > --- > arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 49 > + > 1 file changed, 49 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/s

Re: [PATCH 02/12] arm64: dts: qcom: sm6115-pro1x: Add PCA9534 IO Expander

2024-07-22 Thread Konrad Dybcio
On 22.07.2024 9:10 AM, Dang Huynh wrote: > F(x)tec Pro1X comes with PCA9534 IO Expander, it is used for enabling > touch screen VDD/VDDIO and keyboard's caps lock LED. > > Signed-off-by: Dang Huynh > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 01/12] arm64: dts: qcom: sm6115-pro1x: Add Hall Switch and Camera Button

2024-07-22 Thread Konrad Dybcio
On 22.07.2024 9:10 AM, Dang Huynh wrote: > The Pro1X has a flip keyboard and a single-state camera button. > > Signed-off-by: Dang Huynh > --- > arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 33 > +++-- > 1 file changed, 31 insertions(+), 2 deletions(-) > > diff --git a

Re: [PATCH] arm64: dts: qcom: msm8916-samsung-grandmax: Add touchscreen

2024-07-15 Thread Konrad Dybcio
<1280>; > + > + vdd-supply = <®_vdd_tsp_a>; > + vddio-supply = <&pm8916_l6>; > + > + pinctrl-0 = <&ts_int_default>; > + pinctrl-names = "default"; > + > + linux,keycodes = ; > + }; > +}; > + > ®_motor_vdd { > gpio = <&tlmm 72 GPIO_ACTIVE_HIGH>; > }; > > ®_touch_key { > - status = "disabled"; > + status = "disabled"; /* Using Imagis touch key*/ key */ Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v4 3/5] arm64: dts: qcom: sdx75: update reserved memory regions for mpss

2024-07-09 Thread Konrad Dybcio
ither both the regions have to be used or only mpss_dsm_mem has > to be used. Also, reduce the size of mpssadsp_mem region. > > Signed-off-by: Naina Mehta > --- Thanks Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Name the regulators

2024-06-29 Thread Konrad Dybcio
> Signed-off-by: Luca Weiss > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 2/2] ARM: dts: qcom-msm8226-samsung-ms013g: Add initial device tree

2024-06-29 Thread Konrad Dybcio
= <330>; >> +}; > > This is the vibration motor? Use "vibrator" as node name then as per > https://github.com/devicetree-org/devicetree-specification/blob/main/source/chapter2-devicetree-basics.rst?plain=1#L299 With that: Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH V3 1/2] soc: qcom: smp2p: Use devname for interrupt descriptions

2024-06-29 Thread Konrad Dybcio
_set_irq_type(struct irq_data *irqd, > unsigned int type) > return 0; > } > > +static void smp2p_irq_print_chip(struct irq_data *irqd, struct seq_file *p) > +{ > + struct smp2p_entry *entry = irq_data_get_irq_chip_data(irqd); > + > + seq_printf(p, " %8s", dev_name(entry->smp2p->dev)); Not sure if the number is necessary but as you wish Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH] soc: qcom: smsm: Add missing mailbox dependency to Kconfig

2024-06-29 Thread Konrad Dybcio
smsm: Support using mailbox interface") > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202406180006.z397c67h-...@intel.com/ > Signed-off-by: Luca Weiss > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 2/3] arm64: dts: qcom: msm8916-lg-m216: Add initial device tree

2024-06-26 Thread Konrad Dybcio
eter > - Touchscreen > - Sound and modem > - Haptic > > Signed-off-by: Cristian Cozzolino > [Nikita: Minor cleanup] > Signed-off-by: Nikita Travkin > --- That touchscreen binding could use some YAMLing Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 3/3] arm64: dts: qcom: msm8916-lg-c50: add initial dts for LG Leon LTE

2024-06-26 Thread Konrad Dybcio
f-by: Anton Bambura > Signed-off-by: Nikita Travkin > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v3 3/5] arm64: dts: qcom: sdx75: update reserved memory regions for mpss

2024-06-26 Thread Konrad Dybcio
On 24.06.2024 1:21 PM, Naina Mehta wrote: > > > On 6/18/2024 7:08 PM, Konrad Dybcio wrote: >> >> >> On 6/18/24 15:13, Naina Mehta wrote: >>> Rename qdss@8880 memory region as qlink_logging memory region >>> and add qdss_mem memory region at addr

Re: [PATCH 7/7] ARM: dts: qcom: msm8226: Convert APCS usages to mbox interface

2024-06-22 Thread Konrad Dybcio
On 19.06.2024 11:02 PM, Luca Weiss wrote: > Since we now have the apcs set up as a mailbox provider, let's use the > interface for all drivers where possible. > > Signed-off-by: Luca Weiss > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 6/7] ARM: dts: qcom: msm8226: Hook up CPU cooling

2024-06-22 Thread Konrad Dybcio
On 19.06.2024 11:02 PM, Luca Weiss wrote: > Add cooling-maps for the CPU thermal zones so the driver can actually do > something when the CPU temperature rises too much. > > Signed-off-by: Luca Weiss > --- Very cool, thanks Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 5/7] ARM: dts: qcom: msm8226: Add CPU frequency scaling support

2024-06-22 Thread Konrad Dybcio
On 19.06.2024 11:02 PM, Luca Weiss wrote: > Add a node for the a7pll with its frequencies. With this we can use the > apcs-kpss-global driver for the apcs node and use the apcs to scale the > CPU frequency according to the opp-table. > > At the same time unfortunately we need to provide the gcc no

Re: [PATCH v2 3/3] ARM: dts: qcom: msm8974-sony-shinano: increase load on l21 for sdhc2

2024-06-22 Thread Konrad Dybcio
igned-off-by: Valeriy Klimin > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 2/3] ARM: dts: qcom: Add Sony Xperia Z3 Compact smartphone

2024-06-22 Thread Konrad Dybcio
On 21.06.2024 4:26 PM, Valeriy Klimin wrote: > Add the dts for the Z3 Compact. This is currently almost the same > as the plain Z3 as they share almost the same hardware and > nothing device-specific is currently supported. > > Signed-off-by: Valeriy Klimin > --- Reviewed

Re: [PATCH 0/5] Use mboxes in smsm node for all dtsi where possible

2024-06-19 Thread Konrad Dybcio
Weiss --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 2/2] arm64: dts: qcom: qcm6490-shift-otter: Name the regulators

2024-06-18 Thread Konrad Dybcio
--- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v3 3/5] arm64: dts: qcom: sdx75: update reserved memory regions for mpss

2024-06-18 Thread Konrad Dybcio
On 6/18/24 15:13, Naina Mehta wrote: Rename qdss@8880 memory region as qlink_logging memory region and add qdss_mem memory region at address of 0x8850. Split mpss_dsmharq_mem region into 2 separate regions and reduce the size of mpssadsp_mem region. Signed-off-by: Naina Mehta --- A

Re: [PATCH 1/2] arm64: dts: qcom: qcm6490-fairphone-fp5: Name the regulators

2024-06-18 Thread Konrad Dybcio
--- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 3/3] ARM: dts: qcom: msm8926-motorola-peregrine: Add framebuffer supplies

2024-06-18 Thread Konrad Dybcio
On 6/17/24 23:22, André Apitzsch via B4 Relay wrote: From: André Apitzsch Add regulators used by the framebuffer of Motorola Moto G 4G (2013). Signed-off-by: André Apitzsch --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 2/3] ARM: dts: qcom: msm8926-motorola-peregrine: Update temperature sensor

2024-06-18 Thread Konrad Dybcio
On 6/17/24 23:22, André Apitzsch via B4 Relay wrote: From: André Apitzsch Add alert interrupt for the temperature sensor of Motorola Moto G 4G (2013), although not used by the driver yet. Signed-off-by: André Apitzsch --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 1/3] ARM: dts: qcom: msm8926-motorola-peregrine: Add accelerometer, magnetometer, regulator

2024-06-18 Thread Konrad Dybcio
On 6/17/24 23:22, André Apitzsch via B4 Relay wrote: From: André Apitzsch Add the accelerometer, magnetometer and regulator that are present on the Motorola Moto G 4G (2013) device. Signed-off-by: André Apitzsch --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH] ARM: dts: qcom: msm8926-motorola-peregrine: Add accelerometer, magnetometer, regulator

2024-06-17 Thread Konrad Dybcio
On 6/16/24 16:15, André Apitzsch via B4 Relay wrote: From: André Apitzsch Add the accelerometer, magnetometer and regulator that are present on the Motorola Moto G 4G (2013) device. While at it, update framebuffer supplies and temperature sensor. That's a bit too much for a "while at it"

Re: [PATCH v2 3/5] arm64: dts: qcom: sdx75: add missing qlink_logging reserved memory for mpss

2024-06-17 Thread Konrad Dybcio
On 6/17/24 11:34, Naina Mehta wrote: The qlink_logging memory region is also used by the modem firmware, add it to reserved memory regions. Also split MPSS DSM region into 2 separate regions. Signed-off-by: Naina Mehta --- The commit message is very misleading.. You're not adding qlink_log

Re: [PATCH] ARM: dts: qcom: motorola-falcon: add accelerometer, magnetometer

2024-06-13 Thread Konrad Dybcio
On 6/13/24 19:18, Stanislav Jakubek wrote: On Thu, Jun 13, 2024 at 09:48:26AM +0200, Konrad Dybcio wrote: On 6/9/24 13:05, Stanislav Jakubek wrote: Add the accelerometer and magnetometer that are present on the Motorola Moto G (2013) device. Signed-off-by: Stanislav Jakubek

Re: [PATCH] ARM: dts: qcom: motorola-falcon: add accelerometer, magnetometer

2024-06-13 Thread Konrad Dybcio
On 6/9/24 13:05, Stanislav Jakubek wrote: Add the accelerometer and magnetometer that are present on the Motorola Moto G (2013) device. Signed-off-by: Stanislav Jakubek --- [...] +&blsp1_i2c2 { Consider setting a clock-frequency = <> With that: Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH] arm64: dts: qcom: qcm6490-fairphone-fp5: Use .mbn firmware for IPA

2024-06-06 Thread Konrad Dybcio
On 6.06.2024 11:09 AM, Luca Weiss wrote: > Specify the file name for the squashed/non-split firmware with the .mbn > extension instead of the split .mdt. The kernel can load both but the > squashed version is preferred in dts nowadays. > > Signed-off-by: Luca Weiss > --- R

Re: [PATCH 2/2] ARM: dts: qcom: Add initial support for HTC One (M8)

2024-06-04 Thread Konrad Dybcio
--- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v3 1/3] arm64: dts: qcom: pm7250b: Add node for PMIC VBUS booster

2024-05-31 Thread Konrad Dybcio
On 30.05.2024 5:05 PM, Luca Weiss wrote: > Add the required DTS node for the USB VBUS output regulator, which is > available on PM7250B. This will provide the VBUS source to connected > peripherals. > > Reviewed-by: Bryan O'Donoghue > Signed-off-by: Luca Weiss > ---

Re: [PATCH 1/5] dt-bindings: remoteproc: qcom,sm8550-pas: Document the SA8775p ADSP, CDSP and GPDSP

2024-05-29 Thread Konrad Dybcio
On 22.05.2024 3:08 PM, Bartosz Golaszewski wrote: > On Wed, May 22, 2024 at 3:06 PM wrote: >> >> On 22/05/2024 15:04, Bartosz Golaszewski wrote: >>> On Wed, May 22, 2024 at 2:42 PM wrote: On 22/05/2024 14:08, Bartosz Golaszewski wrote: > From: Tengfei Fan > > Document the c

Re: [PATCH 6/7] arm64: dts: qcom: msm8976: Use mboxes properties for APCS

2024-04-24 Thread Konrad Dybcio
On 4/24/24 18:23, Luca Weiss wrote: Instead of passing the syscon to the various nodes, use the mbox interface using the mboxes property. Signed-off-by: Luca Weiss --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 7/7] arm64: dts: qcom: msm8994: Use mboxes properties for APCS

2024-04-24 Thread Konrad Dybcio
On 4/24/24 18:24, Luca Weiss wrote: Instead of passing the syscon to the various nodes, use the mbox interface using the mboxes property. Signed-off-by: Luca Weiss --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 5/7] arm64: dts: qcom: msm8953: Use mboxes properties for APCS

2024-04-24 Thread Konrad Dybcio
On 4/24/24 18:23, Luca Weiss wrote: Instead of passing the syscon to the various nodes, use the mbox interface using the mboxes property. Signed-off-by: Luca Weiss --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 4/7] arm64: dts: qcom: msm8939: Use mboxes properties for APCS

2024-04-24 Thread Konrad Dybcio
On 4/24/24 18:23, Luca Weiss wrote: Instead of passing the syscon to the various nodes, use the mbox interface using the mboxes property. Signed-off-by: Luca Weiss --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 3/7] arm64: dts: qcom: msm8916: Use mboxes properties for APCS

2024-04-24 Thread Konrad Dybcio
On 4/24/24 18:23, Luca Weiss wrote: Instead of passing the syscon to the various nodes, use the mbox interface using the mboxes property. Signed-off-by: Luca Weiss --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 2/7] ARM: dts: qcom: msm8974: Use mboxes properties for APCS

2024-04-24 Thread Konrad Dybcio
On 4/24/24 18:23, Luca Weiss wrote: Instead of passing the syscon to the various nodes, use the mbox interface using the mboxes property. Signed-off-by: Luca Weiss --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH RFC 2/2] soc: qcom: smsm: Support using mailbox interface

2024-04-24 Thread Konrad Dybcio
syscon. Signed-off-by: Luca Weiss --- Looks good! Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v3 4/4] arm64: dts: qcom: msm8976: Add WCNSS node

2024-04-23 Thread Konrad Dybcio
On 4/13/24 19:03, Adam Skladowski wrote: Add node describing wireless connectivity subsystem. Signed-off-by: Adam Skladowski --- [...] + wcnss_wifi: wifi { + compatible = "qcom,wcnss-wlan"; + +

Re: [PATCH v3 3/4] arm64: dts: qcom: msm8976: Add Adreno GPU

2024-04-23 Thread Konrad Dybcio
On 4/13/24 19:03, Adam Skladowski wrote: Add Adreno GPU node. Signed-off-by: Adam Skladowski --- [...] + opp-2 { + opp-hz = /bits/ 64 <2>; + required-opps = <&rpmpd_o

Re: [PATCH v3 2/4] arm64: dts: qcom: msm8976: Add MDSS nodes

2024-04-23 Thread Konrad Dybcio
On 4/13/24 19:03, Adam Skladowski wrote: Add MDSS nodes to support displays on MSM8976 SoC. Signed-off-by: Adam Skladowski --- [...] + + mdp_opp_table: opp-table { + compatible = "operating-points-v2"; + +

Re: [PATCH v2 3/3] arm64: dts: qcom: sm7225-fairphone-fp4: Enable USB role switching

2024-04-23 Thread Konrad Dybcio
x27;t get messed with and we can charge the phone with at least some amount of power. Signed-off-by: Luca Weiss --- Reviewed-by: Konrad Dybcio nits: + usb-role-switch; this is a common property of the dwc3 host [...] vdda-phy-supply = <&vreg_l22a>;

Re: [PATCH 1/2] arm64: dts: qcom: pmi632: Add vibrator

2024-04-22 Thread Konrad Dybcio
On 4/18/24 12:03, Luca Weiss wrote: On Thu Apr 18, 2024 at 12:01 PM CEST, Konrad Dybcio wrote: On 18.04.2024 8:36 AM, Luca Weiss wrote: Add a node for the vibrator module found inside the PMI632. Signed-off-by: Luca Weiss --- Reviewed-by: Konrad Dybcio On a side note, this is a

Re: [PATCH v2 3/3] arm64: dts: msm8996: add fastrpc nodes

2024-04-18 Thread Konrad Dybcio
On 18.04.2024 8:44 AM, Dmitry Baryshkov wrote: > From: Srinivas Kandagatla > > The ADSP provides fastrpc/compute capabilities. Enable support for the > fastrpc on this DSP. > > Signed-off-by: Srinivas Kandagatla > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 1/2] arm64: dts: qcom: pmi632: Add vibrator

2024-04-18 Thread Konrad Dybcio
On 18.04.2024 8:36 AM, Luca Weiss wrote: > Add a node for the vibrator module found inside the PMI632. > > Signed-off-by: Luca Weiss > --- Reviewed-by: Konrad Dybcio On a side note, this is a totally configuration-free peripheral that doesn't do anything crazy until manuall

Re: [PATCH] rpmsg: qcom_glink_ssr: fix module autoloading

2024-04-10 Thread Konrad Dybcio
On 4/10/24 18:40, Krzysztof Kozlowski wrote: Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded based on the alias from of_device_id table. Signed-off-by: Krzysztof Kozlowski --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 1/2] dt-bindings: pinctrl: qcom,pmic-gpio: Allow gpio-hog nodes

2024-04-08 Thread Konrad Dybcio
On 4/8/24 18:39, Luca Weiss wrote: Allow specifying a GPIO hog, as already used on qcom-msm8974-lge-nexus5-hammerhead.dts. Signed-off-by: Luca Weiss --- .../devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 12 1 file changed, 12 insertions(+) diff --git a/Documenta

Re: [PATCH 1/1] clk: qcom: smd-rpm: Restore msm8976 num_clk

2024-04-02 Thread Konrad Dybcio
On 1.04.2024 7:16 PM, Adam Skladowski wrote: > During rework somehow msm8976 num_clk got removed, restore it. > > Fixes: d6edc31f3a68 ("clk: qcom: smd-rpm: Separate out interconnect bus > clocks") > Signed-off-by: Adam Skladowski > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 3/3] arm64: dts: msm8996: add fastrpc nodes

2024-04-02 Thread Konrad Dybcio
On 31.03.2024 11:10 PM, Dmitry Baryshkov wrote: > From: Srinivas Kandagatla > > The ADSP provides fastrpc/compute capabilities. Enable support for the > fastrpc on this DSP. > > Signed-off-by: Srinivas Kandagatla > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi

Re: [PATCH 2/3] arm64: dts: qcom: msm8996: add glink-edge nodes

2024-04-02 Thread Konrad Dybcio
0.remoteproc:glink-edge.glink_ssr.-1.-1 > 208.remoteproc:glink-edge.rpmsg_chrdev.0.0 > > adsp: > 930.remoteproc:glink-edge.LOOPBACK_CTL_LPASS.-1.-1 > 930.remoteproc:glink-edge.glink_ssr.-1.-1 > 930.remoteproc:glink-edge.rpmsg_chrdev.0.0 > > Signed-off-by: Dmitry Ba

Re: [PATCH RFT] arm64: dts: qcom: sm8350: Reenable crypto & cryptobam

2024-03-27 Thread Konrad Dybcio
On 16.02.2024 11:36 AM, Luca Weiss wrote: > On Mon Jan 8, 2024 at 11:45 PM CET, Dmitry Baryshkov wrote: >> On Mon, 8 Jan 2024 at 16:23, Luca Weiss wrote: >>> >>> On Mon Jan 8, 2024 at 3:18 PM CET, Konrad Dybcio wrote: >>>> On 8.01.2024 14:49, Luca Weiss wrot

Re: [PATCH v2 2/2] ARM: dts: qcom: Add support for Motorola Moto G (2013)

2024-03-27 Thread Konrad Dybcio
cumentation/devicetree/bindings/misc/hob_ram.txt > > Signed-off-by: Stanislav Jakubek > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 2/2] ARM: dts: qcom: Add support for Motorola Moto G (2013)

2024-03-26 Thread Konrad Dybcio
On 25.03.2024 9:25 PM, Stanislav Jakubek wrote: > On Mon, Mar 25, 2024 at 08:28:27PM +0100, Konrad Dybcio wrote: >> On 24.03.2024 3:04 PM, Stanislav Jakubek wrote: >>> Add a device tree for the Motorola Moto G (2013) smartphone based >>> on the Qualcomm MSM8226 SoC.

Re: [PATCH 2/2] ARM: dts: qcom: Add support for Motorola Moto G (2013)

2024-03-25 Thread Konrad Dybcio
On 24.03.2024 3:04 PM, Stanislav Jakubek wrote: > Add a device tree for the Motorola Moto G (2013) smartphone based > on the Qualcomm MSM8226 SoC. > > Initially supported features: > - Buttons (Volume Down/Up, Power) > - eMMC > - Hall Effect Sensor > - SimpleFB display > - TMP108 tempera

Re: [PATCH 4/5] arm64: dts: qcom: pm7250b: Add a TCPM description

2024-03-22 Thread Konrad Dybcio
ed-off-by: Luca Weiss > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 3/5] arm64: dts: qcom: pm7250b: Add node for PMIC VBUS booster

2024-03-22 Thread Konrad Dybcio
On 22.03.2024 09:01, Luca Weiss wrote: > Add the required DTS node for the USB VBUS output regulator, which is > available on PM7250B. This will provide the VBUS source to connected > peripherals. > > Signed-off-by: Luca Weiss > --- > arch/arm64/boot/dts/qcom/pm7250b.dtsi | 6 ++ > 1 file ch

Re: [PATCH 2/2] ARM: dts: qcom: msm8974: Add empty chosen node

2024-03-18 Thread Konrad Dybcio
27;t add it automatically or complain about its absence at this point.. perhaps it could be taught about the latter Reviewed-by: Konrad Dybcio Konrad

  1   2   3   4   5   6   7   8   >