On 4.09.2024 10:33 AM, Jingyi Wang wrote:
> From: Shazad Hussain <quic_shazh...@quicinc.com>
> 
> Add compatible and constants for the power domains exposed by the RPMH
> in the Qualcomm QCS8300 platform.
> 
> Signed-off-by: Shazad Hussain <quic_shazh...@quicinc.com>
> Signed-off-by: Tingguo Cheng <quic_tingg...@quicinc.com>
> Signed-off-by: Jingyi Wang <quic_jin...@quicinc.com>
> ---
>  .../devicetree/bindings/power/qcom,rpmpd.yaml         |  1 +
>  include/dt-bindings/power/qcom-rpmpd.h                | 19 
> +++++++++++++++++++
>  2 files changed, 20 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml 
> b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> index 929b7ef9c1bc..be1a9cb71a9b 100644
> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> @@ -32,6 +32,7 @@ properties:
>            - qcom,msm8998-rpmpd
>            - qcom,qcm2290-rpmpd
>            - qcom,qcs404-rpmpd
> +          - qcom,qcs8300-rpmhpd
>            - qcom,qdu1000-rpmhpd
>            - qcom,qm215-rpmpd
>            - qcom,sa8155p-rpmhpd
> diff --git a/include/dt-bindings/power/qcom-rpmpd.h 
> b/include/dt-bindings/power/qcom-rpmpd.h
> index 608087fb9a3d..7dd7b9ebc480 100644
> --- a/include/dt-bindings/power/qcom-rpmpd.h
> +++ b/include/dt-bindings/power/qcom-rpmpd.h
> @@ -4,6 +4,25 @@
>  #ifndef _DT_BINDINGS_POWER_QCOM_RPMPD_H
>  #define _DT_BINDINGS_POWER_QCOM_RPMPD_H
>  
> +/* QCS8300 Power Domain Indexes */
> +#define QCS8300_CX   0
> +#define QCS8300_CX_AO        1
> +#define QCS8300_DDR  2
> +#define QCS8300_EBI  3
> +#define QCS8300_GFX  4
> +#define QCS8300_LCX  5
> +#define QCS8300_LMX  6
> +#define QCS8300_MMCX 7
> +#define QCS8300_MMCX_AO      8
> +#define QCS8300_MSS  9
> +#define QCS8300_MX   10
> +#define QCS8300_MX_AO        11
> +#define QCS8300_MXC  12
> +#define QCS8300_MXC_AO       13
> +#define QCS8300_NSP0 14
> +#define QCS8300_NSP1 15
> +#define QCS8300_XO   16

Some time ago we moved RPM*h*pd to common defines.. we should
definitely do the same here. Please reuse the RPMPD_xxx definitions
from [1] and credit Rohit in the commit message, as he did some
processing on that to make sure they're ordered based on usage

Konrad

[1] 
https://lore.kernel.org/all/1688647793-20950-2-git-send-email-quic_rohia...@quicinc.com/

Reply via email to