Re: [PATCH] net: broadcom: fix a mistake about ioremap resource

2020-05-05 Thread Jonathan Richardson
On Tue, May 5, 2020 at 12:20 AM Markus Elfring wrote: > > > Commit d7a5502b0bb8b ("net: broadcom: convert to > > devm_platform_ioremap_resource_byname()") will broke this driver. > > idm_base and nicpm_base were optional, after this change, they are > > mandatory. it will probe fails with -22 when

Re: [PATCH v1 1/3] dt-bindings: Document Broadcom OTP controller driver

2016-10-31 Thread Jonathan Richardson
On 16-10-30 06:38 PM, Rob Herring wrote: > On Mon, Oct 24, 2016 at 12:12:02PM -0700, Jonathan Richardson wrote: >> From: Jonathan Richardson >> >> Reviewed-by: Ray Jui >> Tested-by: Jonathan Richardson >> Signed-off-by: Scott Branden >> Signed-

[PATCH v1 3/3] ARM: dts: Add node for Broadcom OTP controller driver

2016-10-24 Thread Jonathan Richardson
From: Jonathan Richardson Reviewed-by: Ray Jui Tested-by: Jonathan Richardson Signed-off-by: Scott Branden Signed-off-by: Oza Pawandeep Signed-off-by: Jonathan Richardson --- arch/arm/boot/dts/bcm-cygnus.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/bcm

[PATCH v1 2/3] nvmem: Add the Broadcom OTP controller driver

2016-10-24 Thread Jonathan Richardson
From: Jonathan Richardson Add support for 32 and 64-bit versions of Broadcom's On-Chip OTP controller. These controllers are used on SoC's such as Cygnus and Stingray. Reviewed-by: Ray Jui Tested-by: Jonathan Richardson Signed-off-by: Scott Branden Signed-off-by: Oza Pawandeep Sig

[PATCH v1 1/3] dt-bindings: Document Broadcom OTP controller driver

2016-10-24 Thread Jonathan Richardson
From: Jonathan Richardson Reviewed-by: Ray Jui Tested-by: Jonathan Richardson Signed-off-by: Scott Branden Signed-off-by: Oza Pawandeep Signed-off-by: Jonathan Richardson --- Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt | 17 + 1 file changed, 17 insertions

[PATCH v1 0/3] Add support for Broadcom OTP controller

2016-10-24 Thread Jonathan Richardson
This patch set adds support for Broadcom's OTP controller found on chips such as Cygnus and Stingray. A node has been added to the Cygnus dts. Jonathan Richardson (3): dt-bindings: Document Broadcom OTP controller driver nvmem: Add the Broadcom OTP controller driver ARM: dts: Add nod

Re: [PATCH] pwm: Avoid double mutex lock on pwm_enable

2015-11-23 Thread Jonathan Richardson
>> (warn_slowpath_common+0x80/0xb0) >>>>>>>>> [2.701836] [] (warn_slowpath_common) from [] >>>>>>>>> (warn_slowpath_fmt+0x30/0x40) >>>>>>>>> [2.701849] [] (warn_slowpath_fmt) from [] >>>>>>>>> (__mutex_lo

[PATCH v10 0/1] Fix bugs in kona pwm driver and pwm core

2015-10-16 Thread Jonathan Richardson
framework. Jonathan Richardson (1): pwm: core: Set enable state properly on failed call to enable drivers/pwm/core.c | 33 ++--- include/linux/pwm.h | 2 ++ 2 files changed, 28 insertions(+), 7 deletions(-) -- 1.9.1 -- To unsubscribe from this list: sen

[PATCH v10 1/1] pwm: core: Set enable state properly on failed call to enable

2015-10-16 Thread Jonathan Richardson
The pwm_enable function didn't clear the enabled bit if a call to a clients enable function returned an error. The result was that the state of the pwm core was wrong. Clearing the bit when enable returns an error ensures the state is properly set. Tested-by: Jonathan Richardson Review

Re: [PATCH v9 2/2] pwm: core: Set enable state properly on failed call to enable

2015-10-16 Thread Jonathan Richardson
On 15-08-17 07:31 AM, Thierry Reding wrote: > On Mon, Jun 15, 2015 at 04:22:27PM -0700, Jonathan Richardson wrote: >> On 15-06-15 02:21 PM, Jonathan Richardson wrote: >>> The pwm_enable function didn't clear the enabled bit if a call to a >>> clients enable functi

Re: [PATCH v9 1/2] pwm: kona: Modify settings application sequence

2015-07-02 Thread Jonathan Richardson
Hi Theirry, If there are no more comments can this patch be applied? Thanks, Jon On 15-06-15 02:21 PM, Jonathan Richardson wrote: > Update the driver so that settings are applied in accordance with the > most recent version of the hardware spec. The revised sequence clears > the tr

Re: [PATCH v9 2/2] pwm: core: Set enable state properly on failed call to enable

2015-06-15 Thread Jonathan Richardson
On 15-06-15 02:21 PM, Jonathan Richardson wrote: > The pwm_enable function didn't clear the enabled bit if a call to a > clients enable function returned an error. The result was that the state > of the pwm core was wrong. Clearing the bit when enable returns an error > ens

[PATCH v9 1/2] pwm: kona: Modify settings application sequence

2015-06-15 Thread Jonathan Richardson
was not properly reflected in the PWM output. Reviewed-by: Arun Ramamurthy Reviewed-by: Scott Branden Tested-by: Scott Branden Reviewed-by: Tim Kryger Signed-off-by: Jonathan Richardson --- drivers/pwm/pwm-bcm-kona.c | 47 +++- 1 file changed, 38

[PATCH v9 2/2] pwm: core: Set enable state properly on failed call to enable

2015-06-15 Thread Jonathan Richardson
The pwm_enable function didn't clear the enabled bit if a call to a clients enable function returned an error. The result was that the state of the pwm core was wrong. Clearing the bit when enable returns an error ensures the state is properly set. Tested-by: Jonathan Richardson Review

[PATCH v9 0/2] Fix bugs in kona pwm driver and pwm core

2015-06-15 Thread Jonathan Richardson
ity is set properly now when the pwm driver is registered with the pwm framework. Jonathan Richardson (2): pwm: kona: Modify settings application sequence pwm: core: Set enable state properly on failed call to enable drivers/pwm/core.c | 19 +++--- drivers/pwm/pwm-

Re: [PATCH v8 4/5] pwm: kona: Add debug info to config function

2015-06-12 Thread Jonathan Richardson
On 15-05-30 09:42 AM, Tim Kryger wrote: > On Tue, May 26, 2015 at 1:08 PM, Jonathan Richardson > wrote: >> Adds debugging info to config function where duty cycle and period >> are calculated and verified. >> >> Signed-off-by: Jonathan Richardson >> --- &

Re: [PATCH v8 3/5] pwm: kona: Fix incorrect config, disable, and polarity procedures

2015-06-12 Thread Jonathan Richardson
On 15-05-30 09:41 AM, Tim Kryger wrote: > On Tue, May 26, 2015 at 1:08 PM, Jonathan Richardson > wrote: >> The config procedure didn't follow the spec which periodically resulted >> in failing to enable the output signal. This happened one in ten or >> twenty att

Re: [PATCH v8 5/5] pwm: core: Set enable state properly on failed call to enable

2015-06-12 Thread Jonathan Richardson
On 15-06-12 02:49 AM, Thierry Reding wrote: > On Tue, May 26, 2015 at 01:08:20PM -0700, Jonathan Richardson wrote: >> The pwm_enable function didn't clear the enabled bit if a call to a >> clients enable function returned an error. The result was that the state >>

[PATCH v8 5/5] pwm: core: Set enable state properly on failed call to enable

2015-05-26 Thread Jonathan Richardson
The pwm_enable function didn't clear the enabled bit if a call to a clients enable function returned an error. The result was that the state of the pwm core was wrong. Clearing the bit when enable returns an error ensures the state is properly set. Tested-by: Jonathan Richardson Review

[PATCH v8 2/5] drivers: pwm: bcm-kona: Dont set polarity in probe

2015-05-26 Thread Jonathan Richardson
Signed-off-by: Scott Branden Signed-off-by: Tim Kryger Signed-off-by: Jonathan Richardson --- drivers/pwm/pwm-bcm-kona.c |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers/pwm/pwm-bcm-kona.c index 02bc048..32b3ec6 100644 --- a

[PATCH v8 1/5] drivers: pwm: core: Add pwmchip_add_inversed

2015-05-26 Thread Jonathan Richardson
Kryger Signed-off-by: Jonathan Richardson --- drivers/pwm/core.c | 36 include/linux/pwm.h |6 ++ 2 files changed, 34 insertions(+), 8 deletions(-) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index ba34c7d..224645f 100644 --- a/drivers/pwm

[PATCH v8 0/5] Fix bugs in kona pwm driver and pwm core

2015-05-26 Thread Jonathan Richardson
ed patch 2 that resolved difference between hardware default polarity and pwm framework default polarity. The default polarity is set properly now when the pwm driver is registered with the pwm framework. Arun Ramamurthy (1): drivers: pwm: bcm-kona: Dont set polarity in probe Jonathan Ric

[PATCH v8 3/5] pwm: kona: Fix incorrect config, disable, and polarity procedures

2015-05-26 Thread Jonathan Richardson
also follow the spec. The old procedures would result in no change in signal when called. Reviewed-by: Arun Ramamurthy Reviewed-by: Scott Branden Tested-by: Scott Branden Signed-off-by: Jonathan Richardson --- drivers/pwm/pwm-bcm-kona.c | 47 +++- 1

[PATCH v8 4/5] pwm: kona: Add debug info to config function

2015-05-26 Thread Jonathan Richardson
Adds debugging info to config function where duty cycle and period are calculated and verified. Signed-off-by: Jonathan Richardson --- drivers/pwm/pwm-bcm-kona.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers

Re: [PATCH v7 3/5] pwm: kona: Fix incorrect config, disable, and polarity procedures

2015-05-21 Thread Jonathan Richardson
On 15-05-17 09:53 PM, Tim Kryger wrote: > On Tue, May 12, 2015 at 4:28 PM, Jonathan Richardson > wrote: > >> The polarity procedure no longer applies the settings to change the >> output signal because it can't be called when the pwm is enabled anyway. >> The

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-21 Thread Jonathan Richardson
On 15-05-20 11:33 PM, Richard Cochran wrote: > On Wed, May 20, 2015 at 04:38:02PM -0700, Jonathan Richardson wrote: >> >> Richard, this design isn't going to work. We need to have both kernel >> and user space consumers. > > But you did not implement even a single

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-20 Thread Jonathan Richardson
On 15-05-14 04:30 AM, Richard Cochran wrote: > On Wed, May 13, 2015 at 04:25:49PM -0700, Jonathan Richardson wrote: >> On 15-05-13 01:27 PM, Richard Cochran wrote: >>> If the ISR is delivering batches of time stamps, then the interrupt >>> rate aught to be the highe

Re: [PATCH 2/2] spi: bcm-mspi: Add support for Broadcom MSPI driver.

2015-05-14 Thread Jonathan Richardson
On 15-05-14 12:08 PM, Mark Brown wrote: > On Thu, May 14, 2015 at 11:19:01AM -0700, Scott Branden wrote: >> On 15-05-14 03:31 AM, Mark Brown wrote: > >>> Chip vendors often say this sort of thing and then get surprised by what >>> their users choose to do, and even if it only ever gets used with f

Re: [PATCH 2/2] spi: bcm-mspi: Add support for Broadcom MSPI driver.

2015-05-14 Thread Jonathan Richardson
On 15-05-14 11:36 AM, Scott Branden wrote: > On 15-05-14 11:28 AM, Florian Fainelli wrote: >> On 14/05/15 11:19, Scott Branden wrote: >>> Hi Mark, >>> >>> On 15-05-14 03:31 AM, Mark Brown wrote: On Wed, May 13, 2015 at 05:19:06PM -0700, Scott Branden wrote: > The purpose of this mspi

Re: [PATCH 2/2] spi: bcm-mspi: Add support for Broadcom MSPI driver.

2015-05-13 Thread Jonathan Richardson
On 15-05-12 12:17 PM, Mark Brown wrote: > On Tue, May 12, 2015 at 10:38:13AM -0700, Jonathan Richardson wrote: > >> +/* Wait for interrupt indicating transfer is complete. */ >> +if (!wait_for_completion_timeout(&mspi->xfer_done, >> +msecs_to_

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-13 Thread Jonathan Richardson
On 15-05-13 01:27 PM, Richard Cochran wrote: > On Wed, May 13, 2015 at 12:50:02PM -0700, Jonathan Richardson wrote: >> ptp_clock_adjtime() casts it to an unsigned and returns an error: >> >>if ((unsigned long) ts.tv_nsec >= NSEC_PER_SEC) >>return -EINVAL;

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-13 Thread Jonathan Richardson
On 15-05-13 08:35 AM, Richard Cochran wrote: > On Fri, May 08, 2015 at 01:02:17PM -0700, Jonathan Richardson wrote: >> For the clock functions I think we can use the existing framework >> unchanged with one exception: ptp_clock_adjtime() doesn't allow negative >> time adj

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-13 Thread Jonathan Richardson
Richard, glad you retrieved our driver. Comments below. On 15-05-13 08:21 AM, Richard Cochran wrote: > On Fri, May 01, 2015 at 12:01:07PM -0700, Jonathan Richardson wrote: >> The DTE creates timestamps of hardware based events such as GPIO, I2S >> signals for audio, etc. It was a

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-13 Thread Jonathan Richardson
Richard, glad you retrieved our driver. Comments below. On 15-05-13 08:21 AM, Richard Cochran wrote: > On Fri, May 01, 2015 at 12:01:07PM -0700, Jonathan Richardson wrote: >> The DTE creates timestamps of hardware based events such as GPIO, I2S >> signals for audio, etc. It was a

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-12 Thread Jonathan Richardson
A bit more info is required here. > Get timestamp: This is a bit more complicated. Currently the PTP driver > does list management for timestamps from external timestamp channels. > Timestamps from all channels go into the same list. In our driver we > have a s/w FIFO for each client and it closel

[PATCH v7 3/5] pwm: kona: Fix incorrect config, disable, and polarity procedures

2015-05-12 Thread Jonathan Richardson
Signed-off-by: Jonathan Richardson --- drivers/pwm/pwm-bcm-kona.c | 47 +--- 1 file changed, 36 insertions(+), 11 deletions(-) diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers/pwm/pwm-bcm-kona.c index 32b3ec6..0654981 100644 --- a/drivers/pwm/pwm-b

[PATCH v7 2/5] drivers: pwm: bcm-kona: Dont set polarity in probe

2015-05-12 Thread Jonathan Richardson
Signed-off-by: Scott Branden Signed-off-by: Tim Kryger Signed-off-by: Jonathan Richardson --- drivers/pwm/pwm-bcm-kona.c |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers/pwm/pwm-bcm-kona.c index 02bc048..32b3ec6 100644 --- a

[PATCH v7 5/5] pwm: core: Set enable state properly on failed call to enable

2015-05-12 Thread Jonathan Richardson
The pwm_enable function didn't clear the enabled bit if a call to a clients enable function returned an error. The result was that the state of the pwm core was wrong. Clearing the bit when enable returns an error ensures the state is properly set. Tested-by: Jonathan Richardson Review

[PATCH v7 4/5] pwm: kona: Add debug info to config function

2015-05-12 Thread Jonathan Richardson
Adds debugging info to config function where duty cycle and period are calculated and verified. Signed-off-by: Jonathan Richardson --- drivers/pwm/pwm-bcm-kona.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers

[PATCH v7 1/5] drivers: pwm: core: Add pwmchip_add_inversed

2015-05-12 Thread Jonathan Richardson
Kryger Signed-off-by: Jonathan Richardson --- drivers/pwm/core.c | 36 include/linux/pwm.h |6 ++ 2 files changed, 34 insertions(+), 8 deletions(-) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index ba34c7d..224645f 100644 --- a/drivers/pwm

[PATCH v7 0/5] Fix bugs in kona pwm driver and pwm core

2015-05-12 Thread Jonathan Richardson
he default polarity is set properly now when the pwm driver is registered with the pwm framework. Arun Ramamurthy (1): drivers: pwm: bcm-kona: Dont set polarity in probe Jonathan Richardson (3): pwm: kona: Fix incorrect config, disable, and polarity procedures pwm: kona: Add debug info

[PATCH 0/2] Add Broadcom MSPI driver

2015-05-12 Thread Jonathan Richardson
This patchset adds support for Broadcoms MSPI SPI controller. It can be found on various SoC's such as Cygnus. Jonathan Richardson (2): ARM: dts: Add binding for Broadcom MSPI driver. spi: bcm-mspi: Add support for Broadcom MSPI driver. .../devicetree/bindings/spi/brcm,mspi-sp

[PATCH 1/2] ARM: dts: Add binding for Broadcom MSPI driver.

2015-05-12 Thread Jonathan Richardson
Signed-off-by: Jonathan Richardson --- .../devicetree/bindings/spi/brcm,mspi-spi.txt | 39 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/spi/brcm,mspi-spi.txt diff --git a/Documentation/devicetree/bindings/spi/brcm,mspi

[PATCH 2/2] spi: bcm-mspi: Add support for Broadcom MSPI driver.

2015-05-12 Thread Jonathan Richardson
The MSPI controller is a SPI controller found on various Broadcom SoC's such as Cygnus. Signed-off-by: Jonathan Richardson --- drivers/spi/Kconfig|5 + drivers/spi/Makefile |1 + drivers/spi/spi-bcm-mspi.c | 505 3

Re: [PATCH v6 3/4] pwm: kona: Fix incorrect config, disable, and polarity procedures

2015-05-11 Thread Jonathan Richardson
Tim, just one comment below. All other suggestions will be made for the next patch set. On 15-05-06 09:26 PM, Tim Kryger wrote: > On Fri, Apr 10, 2015 at 11:58 AM, Jonathan Richardson > wrote: > >> The polarity procedure no longer applies the settings to change the >> out

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-08 Thread Jonathan Richardson
On 15-05-01 12:40 PM, Arnd Bergmann wrote: > On Friday 01 May 2015 20:30:04 One Thousand Gnomes wrote: >> >>> channel control, unless I'm missing something. If people are flexible >>> with extending that I could propose something. Let me know which way you >>> prefer to go. Thanks. >> >> I would st

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-01 Thread Jonathan Richardson
Arnd, some more info is provided and also some questions before I can proceed. On 15-04-23 01:04 AM, Arnd Bergmann wrote: > On Wednesday 22 April 2015 16:22:03 Jonathan Richardson wrote: >> Reviewed-by: Scott Branden >> Tested-by: Scott Branden >> Signed-off-by: Jonatha

Re: [PATCH v6 0/4] Fix bugs in kona pwm driver and pwm core

2015-04-28 Thread Jonathan Richardson
could possibly make a new cygnus pwm driver, though it would be mostly the same as the existing kona driver. Or add a DT version to the existing driver that has the new modified behaviour - though I think this would be messy. Thanks. On 15-04-10 11:58 AM, Jonathan Richardson wrote: > This patchset

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-04-23 Thread Jonathan Richardson
Hi Arnd, Thanks for the initial feedback. I'll investigate your suggestions and get back to you if I have any questions before making some of the API changes you've suggested. On 15-04-23 01:04 AM, Arnd Bergmann wrote: > On Wednesday 22 April 2015 16:22:03 Jonathan Richardson wrote

[PATCH 1/2] misc: Add DT binding for cygnus Digital Timing Engine (DTE) driver.

2015-04-22 Thread Jonathan Richardson
Reviewed-by: Scott Branden Tested-by: Scott Branden Signed-off-by: Jonathan Richardson --- .../bindings/arm/bcm/brcm,cygnus-dte.txt | 24 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/bcm/brcm,cygnus-dte.txt diff

[PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-04-22 Thread Jonathan Richardson
Reviewed-by: Scott Branden Tested-by: Scott Branden Signed-off-by: Jonathan Richardson --- drivers/misc/Kconfig | 11 + drivers/misc/Makefile |1 + drivers/misc/bcm_cygnus_dte.c | 927 include/linux/bcm_cygnus_dte.h | 99

[PATCH 0/2] Add DTE driver for Cygnus

2015-04-22 Thread Jonathan Richardson
This patchset includes the Digital Timing Engine (DTE) driver for Cygnus SoC's. Jonathan Richardson (2): misc: Add DT binding for cygnus Digital Timing Engine (DTE) driver. misc: Add initial Digital Timing Engine (DTE) driver for cygnus .../bindings/arm/bcm/brcm,cygnus-dt

Re: [PATCH v2 4/5] spi: bcm-mspi: Make BCMA optional to support non-BCMA chips

2015-04-08 Thread Jonathan Richardson
Jonas, thanks for the review. Comments below. On 15-04-08 12:27 PM, Jonas Gorski wrote: > Hi, > > On Wed, Apr 8, 2015 at 8:04 PM, Jonathan Richardson > wrote: >> The Broadcom MSPI controller is used on various chips. The driver only >> supported BCM53xx chips with BCMA (

[PATCH v2 2/5] spi: bcm53xx: Refactor driver to make nonspecific to 53xx SoCs

2015-04-08 Thread Jonathan Richardson
The Broadcom MSPI controller is used on various SoCs. It is being renamed so that it can be extended and reused on other chips. The driver no longer depends on 53xx architecture. Signed-off-by: Jonathan Richardson --- drivers/spi/Kconfig|7 +- drivers/spi/Makefile |2

[PATCH v2 5/5] spi: bcm-mspi: Add support to set serial baud clock rate

2015-04-08 Thread Jonathan Richardson
The driver wasn't setting the SPBR (serial clock baud rate) which caused it to run at the slowest speed possible. The driver now calculates the SPBR based on the reference clock frequency resulting in much faster SPI transfers. Signed-off-by: Jonathan Richardson --- drivers/spi/spi-bcm-m

[PATCH v2 4/5] spi: bcm-mspi: Make BCMA optional to support non-BCMA chips

2015-04-08 Thread Jonathan Richardson
: Jonathan Richardson --- drivers/spi/Kconfig|5 + drivers/spi/Makefile |1 + drivers/spi/spi-bcm-mspi.c | 228 3 files changed, 171 insertions(+), 63 deletions(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index

[PATCH v2 0/5] Add MSPI support for Cygnus

2015-04-08 Thread Jonathan Richardson
into two patches to make it easier to review. One commit for the file rename, and one for the actual changes to rename variables, functions, etc. - Checked return value of clk_get_rate(). - ifdef indentation fix. Jonathan Richardson (5): ARM: dts: Add binding for Broadcom MSPI driver. spi

[PATCH v2 1/5] ARM: dts: Add binding for Broadcom MSPI driver.

2015-04-08 Thread Jonathan Richardson
Signed-off-by: Jonathan Richardson --- .../devicetree/bindings/spi/brcm,mspi-spi.txt | 36 1 file changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings/spi/brcm,mspi-spi.txt diff --git a/Documentation/devicetree/bindings/spi/brcm,mspi

[PATCH v2 3/5] spi: bcm-mspi: Refactor to make driver nonspecific to 53xx SoCs

2015-04-08 Thread Jonathan Richardson
Rename variables, structures, etc so that the naming matches the new driver name (bcm mspi) instead of the previous naming that was chip specific (53xx). Signed-off-by: Jonathan Richardson --- drivers/spi/spi-bcm-mspi.c | 200 ++-- drivers/spi/spi-bcm

Re: [PATCH 3/4] spi: bcm-mspi: Make BCMA optional to support non-BCMA chips

2015-04-06 Thread Jonathan Richardson
On 15-04-06 03:36 AM, Rafał Miłecki wrote: > On 3 April 2015 at 19:52, Florian Fainelli wrote: >> On 03/04/15 06:38, Andy Shevchenko wrote: >>> On Thu, Apr 2, 2015 at 10:23 PM, Jonathan Richardson >>> wrote: >>>> The Broadcom MSPI controller is

Re: [PATCH 2/4] spi: bcm53xx: Refactor to make driver nonspecific to 53xx SoCs

2015-04-06 Thread Jonathan Richardson
On 15-04-06 03:18 AM, Rafał Miłecki wrote: > On 3 April 2015 at 15:35, Andy Shevchenko wrote: >> On Thu, Apr 2, 2015 at 10:23 PM, Jonathan Richardson >> wrote: >>> The Broadcom MSPI controller is used on various SoCs. It is being >>> renamed so that it can be e

Re: [PATCH 4/4] spi: bcm-mspi: Add support to set serial baud clock rate

2015-04-06 Thread Jonathan Richardson
On 15-04-06 02:46 AM, Mark Brown wrote: > On Sat, Apr 04, 2015 at 12:12:59PM -0700, Florian Fainelli wrote: >> Le 02/04/2015 12:23, Jonathan Richardson a écrit : > >>> + /* Calculate SPBR if clock-frequency provided. */ >>> + if (of_property

Re: [PATCH 1/4] ARM: dts: Add binding for Broadcom MSPI driver.

2015-04-06 Thread Jonathan Richardson
On 15-04-04 12:17 PM, Florian Fainelli wrote: > Le 02/04/2015 12:23, Jonathan Richardson a écrit : >> >> Signed-off-by: Jonathan Richardson >> --- >> .../devicetree/bindings/spi/brcm,mspi-spi.txt | 38 >> >> 1 file changed,

Re: [PATCH 3/4] spi: bcm-mspi: Make BCMA optional to support non-BCMA chips

2015-04-06 Thread Jonathan Richardson
On 15-04-03 10:52 AM, Florian Fainelli wrote: > On 03/04/15 06:38, Andy Shevchenko wrote: >> On Thu, Apr 2, 2015 at 10:23 PM, Jonathan Richardson >> wrote: >>> The Broadcom MSPI controller is used on various chips. The driver only >>> supported BCM53xx chips wit

Re: [PATCH 2/4] spi: bcm53xx: Refactor to make driver nonspecific to 53xx SoCs

2015-04-06 Thread Jonathan Richardson
On 15-04-03 06:35 AM, Andy Shevchenko wrote: > On Thu, Apr 2, 2015 at 10:23 PM, Jonathan Richardson > wrote: >> The Broadcom MSPI controller is used on various SoCs. It is being >> renamed so that it can be extended and reused on other chips. It is >> renamed to bcm-mspi.

[PATCH 2/4] spi: bcm53xx: Refactor to make driver nonspecific to 53xx SoCs

2015-04-02 Thread Jonathan Richardson
The Broadcom MSPI controller is used on various SoCs. It is being renamed so that it can be extended and reused on other chips. It is renamed to bcm-mspi. Signed-off-by: Jonathan Richardson --- drivers/spi/Kconfig|7 +- drivers/spi/Makefile |2 +- drivers/spi/spi-bcm

[PATCH 1/4] ARM: dts: Add binding for Broadcom MSPI driver.

2015-04-02 Thread Jonathan Richardson
Signed-off-by: Jonathan Richardson --- .../devicetree/bindings/spi/brcm,mspi-spi.txt | 38 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings/spi/brcm,mspi-spi.txt diff --git a/Documentation/devicetree/bindings/spi/brcm,mspi

[PATCH 0/4] Add MSPI support for Cygnus

2015-04-02 Thread Jonathan Richardson
nonspecific supporting BCMA, and a new config is added to support non-BCMA chips. DT support is now mandatory to allow removal of a hardcoded SPI device. Support is also added to set the baud rate. The controller currently runs at the slowest speed possible. Jonathan Richardson (4): ARM: dts: Add

[PATCH 3/4] spi: bcm-mspi: Make BCMA optional to support non-BCMA chips

2015-04-02 Thread Jonathan Richardson
The Broadcom MSPI controller is used on various chips. The driver only supported BCM53xx chips with BCMA (an AMBA bus variant). The driver is refactored to make BCMA optional and provides a new config for non BCMA systems. Signed-off-by: Jonathan Richardson --- drivers/spi/Kconfig|5

[PATCH 4/4] spi: bcm-mspi: Add support to set serial baud clock rate

2015-04-02 Thread Jonathan Richardson
The driver wasn't setting the SPBR (serial clock baud rate) which caused it to run at the slowest speed possible. The driver now calculates the SPBR based on the reference clock frequency resulting in much faster SPI transfers. Signed-off-by: Jonathan Richardson --- drivers/spi/spi-bcm-m

Re: [PATCH v5 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-03-23 Thread Jonathan Richardson
On 15-03-21 09:24 PM, Dmitry Torokhov wrote: > Hi Jonathan, > > On Fri, Mar 20, 2015 at 05:57:25PM -0700, Jonathan Richardson wrote: >> +config TOUCHSCREEN_IPROC >> +tristate "IPROC touch panel driver support" > > I think this should depend on ARCH_BCM_I

[PATCH v5 2/2] Input: touchscreen-iproc: add device tree bindings

2015-03-20 Thread Jonathan Richardson
Documents the touchscreen device tree binding for Broadcom iProc family of SoCs. Reviewed-by: Scott Branden Tested-by: Scott Branden Signed-off-by: Jonathan Richardson --- .../input/touchscreen/brcm,iproc-touchscreen.txt | 76 1 file changed, 76 insertions(+) create

[PATCH v5 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-03-20 Thread Jonathan Richardson
Add initial version of the Broadcom touchscreen driver. Reviewed-by: Ray Jui Reviewed-by: Scott Branden Tested-by: Scott Branden Signed-off-by: Jonathan Richardson --- drivers/input/touchscreen/Kconfig | 11 + drivers/input/touchscreen/Makefile|1 + drivers/input

[PATCH v5 0/2] Add support for Broadcom iProc touchscreen

2015-03-20 Thread Jonathan Richardson
ented 180 degres. Changes from v1: - Add missing newlines to debug messages - Use BIT macro for defines - Fix logic in get_tsc_config to improve readability - Get rid of unnecessary remove() function Jonathan Richardson (2): Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

Re: [PATCH v4 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-03-12 Thread Jonathan Richardson
On 15-03-12 10:59 AM, Joe Perches wrote: > On Thu, 2015-03-12 at 10:45 -0700, Jonathan Richardson wrote: >> Add initial version of the Broadcom touchscreen driver. > > style trivia: > (any of which could be fixed/improved/ignored later) > >> diff --git a/drivers/input/

[PATCH v4 0/2] Add support for Broadcom iProc touchscreen

2015-03-12 Thread Jonathan Richardson
unnecessary remove() function Jonathan Richardson (2): Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver Input: touchscreen-iproc: add device tree bindings .../input/touchscreen/brcm,iproc-touchscreen.txt | 76 +++ drivers/input/touchscreen/Kconfig | 11 + drivers

[PATCH v4 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-03-12 Thread Jonathan Richardson
Add initial version of the Broadcom touchscreen driver. Reviewed-by: Ray Jui Reviewed-by: Scott Branden Tested-by: Scott Branden Signed-off-by: Jonathan Richardson --- drivers/input/touchscreen/Kconfig | 11 + drivers/input/touchscreen/Makefile|1 + drivers/input

[PATCH v4 2/2] Input: touchscreen-iproc: add device tree bindings

2015-03-12 Thread Jonathan Richardson
Documents the touchscreen device tree binding for Broadcom iProc family of SoCs. Reviewed-by: Scott Branden Tested-by: Scott Branden Signed-off-by: Jonathan Richardson --- .../input/touchscreen/brcm,iproc-touchscreen.txt | 76 1 file changed, 76 insertions(+) create

Re: [PATCH v3 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-03-11 Thread Jonathan Richardson
Hi Paul, Yes, I didn't notice that. I'll include it in the next patch. Thanks for the review. Jon On 15-03-11 02:46 AM, Paul Bolle wrote: > One nit is all I can report. > > On Tue, 2015-03-10 at 18:17 -0700, Jonathan Richardson wrote: >> --- a/drivers/input/touchscreen

[PATCH v3 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-03-10 Thread Jonathan Richardson
Add initial version of the Broadcom touchscreen driver. Reviewed-by: Ray Jui Reviewed-by: Scott Branden Tested-by: Scott Branden Signed-off-by: Jonathan Richardson --- drivers/input/touchscreen/Kconfig | 11 + drivers/input/touchscreen/Makefile|1 + drivers/input

[PATCH v3 2/2] Input: touchscreen-iproc: add device tree bindings

2015-03-10 Thread Jonathan Richardson
Documents the touchscreen device tree binding for Broadcom iProc family of SoCs. Reviewed-by: Scott Branden Tested-by: Scott Branden Signed-off-by: Jonathan Richardson --- .../input/touchscreen/brcm,iproc-touchscreen.txt | 76 1 file changed, 76 insertions(+) create

[PATCH v3 0/2] Add support for Broadcom iProc touchscreen

2015-03-10 Thread Jonathan Richardson
support for inverted-x/y at this time as our touchscreen is currently only oriented 180 degres. Changes from v1: - Add missing newlines to debug messages - Use BIT macro for defines - Fix logic in get_tsc_config to improve readability - Get rid of unnecessary remove() function Jonathan Richardson

Re: [PATCH v2 1/1] serial: 8250_dw: Fix get_mctrl behaviour

2015-03-09 Thread Jonathan Richardson
On 15-03-09 11:40 AM, Dmitry Torokhov wrote: > On Thu, Feb 26, 2015 at 4:35 PM, Jonathan Richardson > wrote: >> @@ -334,6 +342,30 @@ static int dw8250_probe_of(struct uart_port *p, >> if (id >= 0) >> p->line = id; >> >> + i

[PATCH RESEND 0/1] Enable Broadcom Cygnus BCM958305K

2015-03-02 Thread Jonathan Richardson
This patchset adds a DTS file to enable the BCM58305 Wireless Audio reference design based on Cygnus. It will be kept up to date as Cygnus drivers are accepted into the mainline. Jonathan Richardson (1): ARM: dts: Enable Broadcom Cygnus BCM958305K arch/arm/boot/dts/Makefile |3

[PATCH RESEND 1/1] ARM: dts: Enable Broadcom Cygnus BCM958305K

2015-03-02 Thread Jonathan Richardson
DT file to enable the Wireless Audio reference design based on the BCM58305. Reviewed-by: Ray Jui Reviewed-by: Scott Branden Tested-by: Scott Branden Signed-off-by: Jonathan Richardson --- arch/arm/boot/dts/Makefile |3 ++- arch/arm/boot/dts/bcm958305k.dts | 53

Re: [PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-03-02 Thread Jonathan Richardson
at 02:17:49PM -0800, Jonathan Richardson wrote: >> Add initial version of the Broadcom touchscreen driver. >> >> Reviewed-by: Ray Jui >> Reviewed-by: Scott Branden >> Tested-by: Scott Branden >> Signed-off-by: Jonathan Richardson >> --- >> drivers/input

Re: [PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-02-26 Thread Jonathan Richardson
Hi Dmitry, Thanks. I'll go through his patch and make the appropriate changes to our driver. Jon On 15-02-24 03:18 PM, Dmitry Torokhov wrote: > Jonathan, > > > On Wed, Feb 11, 2015 at 10:45:34AM -0800, Jonathan Richardson wrote: >> Pinging maintainers... Am I ok to go

[PATCH v2 1/1] serial: 8250_dw: Fix get_mctrl behaviour

2015-02-26 Thread Jonathan Richardson
. Reviewed-by: JD (Jiandong) Zheng Signed-off-by: Jonathan Richardson --- .../bindings/serial/snps-dw-apb-uart.txt | 16 ++ drivers/tty/serial/8250/8250_dw.c | 32 2 files changed, 48 insertions(+) diff --git a/Documentation/devicetree/bin

[PATCH v2 0/1] Synopsis 8250 serial port driver fix

2015-02-26 Thread Jonathan Richardson
Hi, This patchset fixes a bug in the Synopsis 8250 serial driver which causes the driver to hang. The bug occurs on simple 2 wire serial ports when modem control signalling has been enabled. It can be reproduced from user space by enabling modem control signals (stty -clocal), then opening a seria

Re: [PATCH 1/1] serial: 8250_dw: Fix get_mctrl behaviour

2015-02-25 Thread Jonathan Richardson
Hi Arnd, On 15-02-25 11:21 AM, Arnd Bergmann wrote: > On Wednesday 25 February 2015 11:04:16 Jonathan Richardson wrote: >> +- msr-override : array of strings to be used to override the individual >> + modem status signals for DCD, DSR, CTS, and RI. If the property is not >

[PATCH 1/1] serial: 8250_dw: Fix get_mctrl behaviour

2015-02-25 Thread Jonathan Richardson
g for the state to change. The new DT properties allow the driver to ignore the state of these pins on serial ports that don't support them, as recommended in the kernel documentation. Reviewed-by: JD (Jiandong) Zheng Reviewed-by: Jonathan Richardson Reviewed-by: Scott Branden Tested-by: S

[PATCH 0/1] Synopsis 8250 serial port driver fix

2015-02-25 Thread Jonathan Richardson
Hi, This patchset fixes a bug in the Synopsis 8250 serial driver which causes the driver to hang. The bug occurs on simple 2 wire serial ports when modem control signalling has been enabled. It can be reproduced from user space by enabling modem control signals (stty -clocal), then opening a seria

[PATCH 0/1] Enable Broadcom Cygnus BCM958305K

2015-02-24 Thread Jonathan Richardson
This patchset adds a DTS file to enable the BCM58305 Wireless Audio reference design based on Cygnus. It will be kept up to date as Cygnus drivers are accepted into the mainline. Jonathan Richardson (1): ARM: dts: Enable Broadcom Cygnus BCM958305K arch/arm/boot/dts/Makefile |3

[PATCH 1/1] ARM: dts: Enable Broadcom Cygnus BCM958305K

2015-02-24 Thread Jonathan Richardson
DT file to enable the Wireless Audio reference design based on the BCM58305. Reviewed-by: Ray Jui Reviewed-by: Scott Branden Tested-by: Scott Branden Signed-off-by: Jonathan Richardson --- arch/arm/boot/dts/Makefile |3 ++- arch/arm/boot/dts/bcm958305k.dts | 53

Re: [PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-02-11 Thread Jonathan Richardson
Pinging maintainers... Am I ok to go ahead with the current rotation implementation? I haven't heard anything further. Any feedback on naming conventions from DT people? Thanks! On 15-01-15 11:51 AM, Jonathan Richardson wrote: > Hi Dmitry, > > On 15-01-14 10:07 PM, Dmitry Torokho

Re: [PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-01-15 Thread Jonathan Richardson
Hi Dmitry, On 15-01-14 10:07 PM, Dmitry Torokhov wrote: > On Wed, Jan 14, 2015 at 09:44:39PM -0800, Scott Branden wrote: >> On 15-01-14 05:02 PM, Dmitry Torokhov wrote: >>> Hi Jonathan, >>> >>> On Fri, Dec 19, 2014 at 02:17:49PM -0800, Jonathan Richardson wro

Re: [PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-01-15 Thread Jonathan Richardson
On 15-01-14 05:08 PM, Florian Fainelli wrote: > On 19/12/14 15:03, Jonathan Richardson wrote: >> On 14-12-19 02:26 PM, Joe Perches wrote: >>> On Fri, 2014-12-19 at 14:17 -0800, Jonathan Richardson wrote: >>>> Add initial version of the Broadcom touchscre

[PATCH v5 1/2] pwm: kona: Fix incorrect config, disable, and polarity procedures

2015-01-07 Thread Jonathan Richardson
Signed-off-by: Jonathan Richardson --- drivers/pwm/pwm-bcm-kona.c | 75 +++- 1 file changed, 60 insertions(+), 15 deletions(-) diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers/pwm/pwm-bcm-kona.c index 32b3ec6..8a1dfba 100644 --- a/drivers/pwm/pwm-b

[PATCH v5 2/2] pwm: core: Set enable state properly on failed call to enable

2015-01-07 Thread Jonathan Richardson
The pwm_enable function didn't clear the enabled bit if a call to a clients enable function returned an error. The result was that the state of the pwm core was wrong. Clearing the bit when enable returns an error ensures the state is properly set. Tested-by: Jonathan Richardson Signed-o

[PATCH v5 0/2] Fix bugs in kona pwm driver and pwm core

2015-01-07 Thread Jonathan Richardson
arity. - Removed patch 2 that resolved difference between hardware default polarity and pwm framework default polarity. The default polarity is set properly now when the pwm driver is registered with the pwm framework. Jonathan Richardson (2): pwm: kona: Fix incorrect config, disable, and pol

  1   2   >