Re: [PATCH V3 00/20] Add CXL LSA 2.1 format support in nvdimm and cxl pmem

2025-09-17 Thread Jonathan Cameron
On Wed, 17 Sep 2025 19:10:56 +0530 Neeraj Kumar wrote: Hi, Not sure what difference between the two versions I'm seeing is. Patch 02 is missing in both of them. Jonathan

Re: [PATCH V3 01/20] nvdimm/label: Introduce NDD_REGION_LABELING flag to set region label

2025-09-17 Thread Jonathan Cameron
; Signed-off-by: Neeraj Kumar Reviewed-by: Jonathan Cameron

Re: [PATCH V3 06/20] nvdimm/region_label: Add region label update support

2025-09-17 Thread Jonathan Cameron
On Wed, 17 Sep 2025 19:11:02 +0530 Neeraj Kumar wrote: > Modified __pmem_label_update() to update region labels into LSA > I'm struggling to follow the use of the union for the two label types in much of this code. To me if feels like that should only be a thing at the init_labels() point on th

Re: [PATCH V3 04/20] nvdimm/label: Update mutex_lock() with guard(mutex)()

2025-09-17 Thread Jonathan Cameron
On Wed, 17 Sep 2025 18:59:24 +0530 Neeraj Kumar wrote: > Updated mutex_lock() with guard(mutex)() Say why. > > Signed-off-by: Neeraj Kumar > --- > drivers/nvdimm/label.c | 36 +--- > 1 file changed, 17 insertions(+), 19 deletions(-) > > diff --git a/drivers/nv

Re: [PATCH V3 05/20] nvdimm/namespace_label: Add namespace label changes as per CXL LSA v2.1

2025-09-17 Thread Jonathan Cameron
On Wed, 17 Sep 2025 19:11:01 +0530 Neeraj Kumar wrote: > CXL 3.2 Spec mentions CXL LSA 2.1 Namespace Labels at section 9.13.2.5 > Modified __pmem_label_update function using setter functions to update > namespace label as per CXL LSA 2.1 > > Signed-off-by: Neeraj Kumar Review

Re: [PATCH V3 03/20] nvdimm/label: Modify nd_label_base() signature

2025-09-17 Thread Jonathan Cameron
On Wed, 17 Sep 2025 18:59:23 +0530 Neeraj Kumar wrote: > nd_label_base() was being used after typecasting with 'unsigned long'. Thus > modified nd_label_base() to return 'unsigned long' instead of 'struct > nd_namespace_label *' > > Signed-off-by

Re: [PATCH v4 0/3] Marvell 88PM886 PMIC GPADC driver

2025-09-13 Thread Jonathan Cameron
On Thu, 11 Sep 2025 14:43:43 +0200 Duje Mihanović wrote: > This series adds a driver for the GPADC found on the Marvell 88PM886 > PMIC. The GPADC monitors various system voltages and is a prerequisite > for battery monitoring on boards using the PMIC. > > Signed-off-by: Duje Mihanović Applied p

Re: [PATCH V2 05/20] nvdimm/region_label: Add region label updation routine

2025-09-10 Thread Jonathan Cameron
On Thu, 4 Sep 2025 19:42:31 +0530 Neeraj Kumar wrote: > On 15/08/25 02:55PM, Dave Jiang wrote: > > > > > >On 7/30/25 5:11 AM, Neeraj Kumar wrote: > >> Added __pmem_region_label_update region label update routine to update > >> region label. > >> > >> Also used guard(mutex)(&nd_mapping->lock) in

Re: [PATCH 5/6] dax/hmem: Reintroduce Soft Reserved ranges back into the iomem tree

2025-09-10 Thread Jonathan Cameron
d-by: Alison Schofield > Signed-off-by: Alison Schofield > Signed-off-by: Smita Koralahalli A few trivial things inline. Not are important enough to need a change though. Reviewed-by: Jonathan Cameron > --- > drivers/dax/hmem/hmem.c | 38 ++ >

Re: [PATCH] remoteproc: mediatek: Use for_each_available_child_of_node_scoped()

2025-09-10 Thread Jonathan Cameron
On Mon, 8 Sep 2025 12:43:25 +0800 Fei Shao wrote: > Use scoped for_each_available_child_of_node_scoped() to remove manual > of_node_put() calls from early returns. There aren't any early returns here. This runs into some of the stuff that cleanup.h docs suggest we shouldn't do which is combini

Re: [PATCH v3 2/3] iio: adc: Add driver for Marvell 88PM886 PMIC ADC

2025-09-07 Thread Jonathan Cameron
On Fri, 5 Sep 2025 16:39:05 +0300 Andy Shevchenko wrote: > On Fri, Sep 5, 2025 at 2:01 PM Duje Mihanović wrote: > > > > Marvell's 88PM886 PMIC has a so-called General Purpose ADC used for > > monitoring various system voltages and temperatures. Add the relevant > > register definitions to the MF

Re: [PATCH v3 2/3] iio: adc: Add driver for Marvell 88PM886 PMIC ADC

2025-09-07 Thread Jonathan Cameron
On Fri, 5 Sep 2025 16:39:05 +0300 Andy Shevchenko wrote: > On Fri, Sep 5, 2025 at 2:01 PM Duje Mihanović wrote: > > > > Marvell's 88PM886 PMIC has a so-called General Purpose ADC used for > > monitoring various system voltages and temperatures. Add the relevant > > register definitions to the MF

Re: [PATCH v2 2/3] iio: adc: Add driver for Marvell 88PM886 PMIC ADC

2025-09-02 Thread Jonathan Cameron
On Sun, 31 Aug 2025 12:33:05 +0200 Duje Mihanović wrote: > Marvell's 88PM886 PMIC has a so-called General Purpose ADC used for > monitoring various system voltages and temperatures. Add the relevant > register definitions to the MFD header and a driver for the ADC. > > Signed-off-by: Duje Mihano

Re: [PATCH v2 2/3] iio: adc: Add driver for Marvell 88PM886 PMIC ADC

2025-09-01 Thread Jonathan Cameron
On Mon, 1 Sep 2025 15:43:08 +0300 Andy Shevchenko wrote: > On Sun, Aug 31, 2025 at 10:19:38PM +0200, Duje Mihanović wrote: > > On Sunday, 31 August 2025 21:24:54 Central European Summer Time Karel Balej > > wrote: > > > Duje Mihanović, 2025-08-31T12:33:05+02:00: > > ... > > > > > + i

Re: [PATCH 1/2] iio: adc: Add driver for Marvell 88PM886 PMIC ADC

2025-08-30 Thread Jonathan Cameron
On Sat, 30 Aug 2025 18:05:06 +0300 Andy Shevchenko wrote: > On Sat, Aug 30, 2025 at 4:07 PM Duje Mihanović wrote: > > On Saturday, 30 August 2025 06:41:58 Central European Summer Time Andy > > Shevchenko wrote: > > > On Sat, Aug 30, 2025 at 7:37 AM Andy Shevchenko > > > wrote: > > > > On Fr

Re: [PATCH 1/2] iio: adc: Add driver for Marvell 88PM886 PMIC ADC

2025-08-29 Thread Jonathan Cameron
On Fri, 29 Aug 2025 00:17:41 +0200 Duje Mihanović wrote: > Marvell's 88PM886 PMIC has a so-called General Purpose ADC used for > monitoring various system voltages and temperatures. Add the relevant > register definitions to the MFD header and a driver for the ADC. > > Signed-off-by: Duje Mihano

Re: [PATCH V2 12/20] nvdimm/namespace_label: Skip region label during namespace creation

2025-08-13 Thread Jonathan Cameron
On Wed, 30 Jul 2025 17:42:01 +0530 Neeraj Kumar wrote: > During namespace creation skip presence of region label if present. Confusing description. What does skipping presence mean? Reword. During namespace creation, skip any region labels found. > Also preserve region label into labels list

Re: [PATCH V2 11/20] nvdimm/region_label: Export routine to fetch region information

2025-08-13 Thread Jonathan Cameron
On Wed, 30 Jul 2025 17:42:00 +0530 Neeraj Kumar wrote: > cxl region information preserved from LSA need to be exported so as to > use by cxl driver for cxl region re-creation CXL region information preserved from the LAS needs to be exported for use by the CXL driver for CXL region re-creation.

Re: [PATCH V2 10/20] nvdimm/region_label: Preserve cxl region information from region label

2025-08-13 Thread Jonathan Cameron
On Wed, 30 Jul 2025 17:41:59 +0530 Neeraj Kumar wrote: > Preserve region information from region label during nvdimm_probe. This > preserved region information is used for creating cxl region to achieve > region persistency across reboot. > > Signed-off-by: Neeraj Kumar See below. > diff --gi

Re: [PATCH V2 09/20] nvdimm/namespace_label: Skip region label during ns label DPA reservation

2025-08-13 Thread Jonathan Cameron
On Wed, 30 Jul 2025 17:41:58 +0530 Neeraj Kumar wrote: > If Namespace label is present in LSA during nvdimm_probe then DPA > reservation is required. But this reservation is not required by region > label. Therefore if LSA scanning finds any region label, skip it. > > Signed-off-by: Neeraj Kumar

Re: [PATCH V2 08/20] nvdimm/label: Include region label in slot validation

2025-08-13 Thread Jonathan Cameron
f present. > > Also validate and calculate lsa v2.1 namespace label checksum LSA v2.1 ... > > Signed-off-by: Neeraj Kumar Otherwise LGTM Reviewed-by: Jonathan Cameron

Re: [PATCH V2 07/20] nvdimm/namespace_label: Update namespace init_labels and its region_uuid

2025-08-13 Thread Jonathan Cameron
On Wed, 30 Jul 2025 17:41:56 +0530 Neeraj Kumar wrote: > nd_mapping->labels maintains the list of labels present into LSA. > init_labels() prepares this list while adding new label into LSA > and updates nd_mapping->labels accordingly. During cxl region > creation nd_mapping->labels list and LSA

Re: [PATCH V2 06/20] nvdimm/region_label: Add region label deletion routine

2025-08-13 Thread Jonathan Cameron
On Wed, 30 Jul 2025 17:41:55 +0530 Neeraj Kumar wrote: > Added cxl v2.1 format region label deletion routine. This function is > used to delete region label from LSA > > Signed-off-by: Neeraj Kumar > --- > drivers/nvdimm/label.c | 77 ++--- > drivers/nvdimm

Re: [PATCH V2 05/20] nvdimm/region_label: Add region label updation routine

2025-08-13 Thread Jonathan Cameron
On Wed, 30 Jul 2025 17:41:54 +0530 Neeraj Kumar wrote: > Added __pmem_region_label_update region label update routine to update > region label. > > Also used guard(mutex)(&nd_mapping->lock) in place of mutex_lock() and > mutex_unlock() > > Signed-off-by: Neeraj Kumar A few comments inline, T

Re: [PATCH V2 04/20] nvdimm/label: CXL labels skip the need for 'interleave-set cookie'

2025-08-13 Thread Jonathan Cameron
so skip its usage for CXL LSA 2.1 format > > Signed-off-by: Neeraj Kumar Reviewed-by: Jonathan Cameron

Re: [PATCH V2 03/20] nvdimm/namespace_label: Add namespace label changes as per CXL LSA v2.1

2025-08-13 Thread Jonathan Cameron
On Wed, 30 Jul 2025 17:41:52 +0530 Neeraj Kumar wrote: > CXL 3.2 Spec mentions CXL LSA 2.1 Namespace Labels at section 9.13.2.5 > Modified __pmem_label_update function using setter functions to update > namespace label as per CXL LSA 2.1 > > Signed-off-by: Neeraj Kumar > diff --git a/drivers/n

Re: [PATCH V2 02/20] nvdimm/label: Prep patch to accommodate cxl lsa 2.1 support

2025-08-13 Thread Jonathan Cameron
On Wed, 30 Jul 2025 17:41:51 +0530 Neeraj Kumar wrote: > LSA 2.1 format introduces region label, which can also reside > into LSA along with only namespace label as per v1.1 and v1.2 > > As both namespace and region labels are of same size of 256 bytes. > Thus renamed "struct nd_namespace_label"

Re: [PATCH V2 01/20] nvdimm/label: Introduce NDD_CXL_LABEL flag to set cxl label format

2025-08-13 Thread Jonathan Cameron
On Wed, 30 Jul 2025 17:41:50 +0530 Neeraj Kumar wrote: > Prior to LSA 2.1 version, LSA contain only namespace labels. LSA 2.1 > introduced in CXL 2.0 Spec, which contain region label along with > namespace label. > > NDD_LABELING flag is used for namespace. Introduced NDD_CXL_LABEL > flag for re

Re: [RFC PATCH 02/20] nvdimm/label: Prep patch to accommodate cxl lsa 2.1 support

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:26 +0530 Neeraj Kumar wrote: > In order to accommodate cxl lsa 2.1 format region label, renamed > nd_namespace_label to nd_lsa_label. I would add some more information on why. I've no idea from this description whether the issue is a naming clash or a need for a broade

Re: [RFC PATCH 07/20] nvdimm/namespace_label: Update namespace init_labels and its region_uuid

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:31 +0530 Neeraj Kumar wrote: > nd_mapping->labels maintains the list of labels present into LSA. > init_labels function prepares this list while adding new label init_labels() prepares > into LSA and updates nd_mapping->labels accordingly. During cxl > region creation

Re: [RFC PATCH 06/20] nvdimm/region_label: Add region label deletion routine

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:30 +0530 Neeraj Kumar wrote: > Added cxl v2.1 format region label deletion routine. This function is > used to delete region label from LSA > > Signed-off-by: Neeraj Kumar > --- > drivers/nvdimm/label.c | 75 ++--- > drivers/nvdimm

Re: [RFC PATCH 20/20] cxl/pmem_region: Add cxl region label updation and deletion device attributes

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:44 +0530 Neeraj Kumar wrote: > Using these attributes region label is added/deleted into LSA. These > attributes are called from userspace (ndctl) after region creation. These need documentation. Documentation/ABI/testing/sysfs-bus-cxl is probably the right place. >

Re: [RFC PATCH 13/20] cxl/mem: Refactor cxl pmem region auto-assembling

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:37 +0530 Neeraj Kumar wrote: > In 84ec985944ef3, For cxl pmem region auto-assembly after endpoint port > probing, cxl_nvd presence was required. And for cxl region persistency, > region creation happens during nvdimm_probe which need the completion > of endpoint probe. >

Re: [RFC PATCH 00/20] Add CXL LSA 2.1 format support in nvdimm and cxl pmem

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:07:23 +0100 Jonathan Cameron wrote: > On Tue, 17 Jun 2025 18:09:24 +0530 > Neeraj Kumar wrote: > > Hi Neeraj, > > First a process thing. Looks like threading is broken in your patch set. > https://lore.kernel.org/linux-cxl/1931444790.41750165

Re: [RFC PATCH 18/20] cxl/pmem: Add support of cxl lsa 2.1 support in cxl pmem

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:42 +0530 Neeraj Kumar wrote: > Add support of cxl lsa 2.1 using NDD_CXL_LABEL flag. It also creates cxl > region based on region information parsed from LSA. > > Signed-off-by: Neeraj Kumar > --- > drivers/cxl/pmem.c | 59 ++

Re: [RFC PATCH 19/20] cxl/pmem_region: Prep patch to accommodate pmem_region attributes

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:43 +0530 Neeraj Kumar wrote: > Created a separate file core/pmem_region.c along with CONFIG_PMEM_REGION > Moved pmem_region related code from core/region.c to core/pmem_region.c > For region label update, need to create device attribute, which calls > nvdimm exported fun

Re: [RFC PATCH 15/20] cxl: Add a routine to find cxl root decoder on cxl bus

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:39 +0530 Neeraj Kumar wrote: > Add cxl_find_root_decoder to find root decoder on cxl bus. It is used to > find root decoder during region creation > > Signed-off-by: Neeraj Kumar > --- > drivers/cxl/core/port.c | 26 ++ > drivers/cxl/cxl.h

Re: [RFC PATCH 14/20] cxl/region: Add cxl pmem region creation routine for region persistency

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:38 +0530 Neeraj Kumar wrote: > Added exported cxl_create_pmem_region routine to create cxl pmem region For function names always add () after and drop 'function/routine' etc. Ends up shorter and easier to read. > from LSA parsed cxl region information. > Inspirition fo

Re: [RFC PATCH 12/20] nvdimm/namespace_label: Skip region label during namespace creation

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:36 +0530 Neeraj Kumar wrote: > During namespace creation skip presence of region label if present. > Also preserve region label into labels list if present. > > Signed-off-by: Neeraj Kumar > --- > drivers/nvdimm/namespace_devs.c | 48 +

Re: [RFC PATCH 08/20] nvdimm/label: Include region label in slot validation

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:32 +0530 Neeraj Kumar wrote: > slot validation routine validates label slot by calculating label > checksum. It was only validating namespace label. This changeset also > validates region label if present. > > Also validate and calculate lsa v2.1 namespace label checksu

Re: [RFC PATCH 05/20] nvdimm/region_label: Add region label updation routine

2025-06-23 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:29 +0530 Neeraj Kumar wrote: Add region label update routine > Added __pmem_region_label_update region label update routine to update > region label > > Signed-off-by: Neeraj Kumar A few trivial comments inline. Jonathan > --- > drivers/nvdimm/label.c |

Re: [RFC PATCH 01/20] nvdimm/label: Introduce NDD_CXL_LABEL flag to set cxl label format

2025-06-20 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:25 +0530 Neeraj Kumar wrote: > NDD_CXL_LABEL is introduced to set cxl LSA 2.1 label format > Accordingly updated label index version > > Signed-off-by: Neeraj Kumar A few local comments. I'll need to read on to figure out how this fits in generally. > --- > drivers/

Re: [RFC PATCH 00/20] Add CXL LSA 2.1 format support in nvdimm and cxl pmem

2025-06-17 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:24 +0530 Neeraj Kumar wrote: Hi Neeraj, First a process thing. Looks like threading is broken in your patch set. https://lore.kernel.org/linux-cxl/1931444790.41750165203442.JavaMail.epsvc@epcpadp1new/T/#u Lore had a go and seems to have figured out there is a thread for

Re: [PATCH v4 2/7] cxl/core: Remove CONFIG_CXL_SUSPEND and always build suspend.o

2025-06-10 Thread Jonathan Cameron
On Mon, 9 Jun 2025 16:25:49 -0700 "Koralahalli Channabasappa, Smita" wrote: > On 6/9/2025 4:02 AM, Jonathan Cameron wrote: > > On Tue, 3 Jun 2025 22:19:44 + > > Smita Koralahalli wrote: > > > >> In preparation for soft-reserved resource handli

Re: [PATCH v4 5/7] cxl/region: Introduce SOFT RESERVED resource removal on region teardown

2025-06-10 Thread Jonathan Cameron
Hi Smita, > >> +/* > >> + * normalize_resource > >> + * > >> + * The walk_iomem_res_desc() returns a copy of a resource, not a reference > >> + * to the actual resource in the iomem_resource tree. As a result, > >> + * __release_resource() which relies on pointer equality will fail. > > > > Pro

Re: [PATCH v4 7/7] cxl/dax: Defer DAX consumption of SOFT RESERVED resources until after CXL region creation

2025-06-09 Thread Jonathan Cameron
On Tue, 3 Jun 2025 22:19:49 + Smita Koralahalli wrote: > From: Nathan Fontenot > > The DAX HMEM driver currently consumes all SOFT RESERVED iomem resources > during initialization. This interferes with the CXL driver’s ability to > create regions and trim overlapping SOFT RESERVED ranges be

Re: [PATCH v4 5/7] cxl/region: Introduce SOFT RESERVED resource removal on region teardown

2025-06-09 Thread Jonathan Cameron
On Tue, 3 Jun 2025 22:19:47 + Smita Koralahalli wrote: > Reworked from a patch by Alison Schofield > > Previously, when CXL regions were created through autodiscovery and their > resources overlapped with SOFT RESERVED ranges, the soft reserved resource > remained in place after region tear

Re: [PATCH v4 2/7] cxl/core: Remove CONFIG_CXL_SUSPEND and always build suspend.o

2025-06-09 Thread Jonathan Cameron
On Tue, 3 Jun 2025 22:19:44 + Smita Koralahalli wrote: > In preparation for soft-reserved resource handling, make the suspend > infrastructure always available by removing the CONFIG_CXL_SUSPEND > Kconfig option. > > This ensures cxl_mem_active_inc()/dec() and cxl_mem_active() are > uncondit

Re: [PATCH v9 01/19] cxl/mbox: Flag support for Dynamic Capacity Devices (DCD)

2025-04-15 Thread Jonathan Cameron
On Sun, 13 Apr 2025 17:52:09 -0500 Ira Weiny wrote: > Per the CXL 3.1 specification software must check the Command Effects > Log (CEL) for dynamic capacity command support. > > Detect support for the DCD commands while reading the CEL, including: > > Get DC Config > Get DC Extent L

Re: [PATCH v9 00/19] DCD: Add support for Dynamic Capacity Devices (DCD)

2025-04-15 Thread Jonathan Cameron
On Mon, 14 Apr 2025 21:50:31 -0700 Dan Williams wrote: > Jonathan Cameron wrote: > [..] > > To me we don't need to answer the question of whether we fully understand > > requirements, or whether this support covers them, but rather to ask > > if anyone has requirem

Re: [PATCH v9 03/19] cxl/cdat: Gather DSMAS data for DCD partitions

2025-04-14 Thread Jonathan Cameron
On Sun, 13 Apr 2025 17:52:11 -0500 Ira Weiny wrote: > Additional DCD partition (AKA region) information is contained in the > DSMAS CDAT tables, including performance, read only, and shareable > attributes. > > Match DCD partitions with DSMAS tables and store the meta data. > > Signed-off-by: I

Re: [PATCH v9 00/19] DCD: Add support for Dynamic Capacity Devices (DCD)

2025-04-14 Thread Jonathan Cameron
On Sun, 13 Apr 2025 17:52:08 -0500 Ira Weiny wrote: > A git tree of this series can be found here: > > https://github.com/weiny2/linux-kernel/tree/dcd-v6-2025-04-13 > > This is now based on 6.15-rc2. Hi Ira, Firstly thanks for the update and your hard work driving this forwards. > > D

Re: [PATCH v9 16/19] cxl/region: Read existing extents on region creation

2025-04-14 Thread Jonathan Cameron
after the driver has loaded will surface through the normal notification > path while extents seen prior to the driver are read during driver load. > > Based on an original patch by Navneet Singh. > > Reviewed-by: Jonathan Cameron > Reviewed-by: Fan Ni > Signed-off-by: Ira

Re: [PATCH v9 12/19] cxl/extent: Process dynamic partition events and realize region extents

2025-04-14 Thread Jonathan Cameron
> of 0 are allowed. This defines existing DAX devices as having a 0 tag > which makes the most logical sense as a default. > > Process DCD events and create region devices. > > Based on an original patch by Navneet Singh. > > Reviewed-by: Dave Jiang > Reviewed-

Re: [PATCH v9 07/19] cxl/region: Add sparse DAX region support

2025-04-14 Thread Jonathan Cameron
ned-off-by: Ira Weiny > I'm not that familiar with the DAX parts but looks fine to me. Reviewed-by: Jonathan Cameron

Re: [PATCH v9 06/19] cxl/port: Add 'dynamic_ram_a' to endpoint decoder mode

2025-04-14 Thread Jonathan Cameron
On Sun, 13 Apr 2025 17:52:14 -0500 Ira Weiny wrote: > Endpoints can now support a single dynamic ram partition following the > persistent memory partition. > > Expand the mode to allow a decoder to point to the first dynamic ram > partition. > > Signed-off-by: Ira Weiny

Re: [PATCH v9 05/19] cxl/mem: Expose dynamic ram A partition in sysfs

2025-04-14 Thread Jonathan Cameron
On Sun, 13 Apr 2025 17:52:13 -0500 Ira Weiny wrote: > To properly configure CXL regions user space will need to know the > details of the dynamic ram partition. > > Expose the first dynamic ram partition through sysfs. > > Signed-off-by: Ira Weiny > LGTM Reviewed-by: Jonathan Cameron

Re: [PATCH v9 04/19] cxl/core: Enforce partition order/simplify partition calls

2025-04-14 Thread Jonathan Cameron
he preservation of the implied > partition order. > > Signed-off-by: Ira Weiny One trivial thing inline. To me this patch stands on it's own irrespective of the rest of the series. Maybe one to queue up early as a cleanup? Reviewed-by: Jonathan Cameron Jonathan > --- &

Re: [PATCH v9 02/19] cxl/mem: Read dynamic capacity configuration from the device

2025-04-14 Thread Jonathan Cameron
On Sun, 13 Apr 2025 17:52:10 -0500 Ira Weiny wrote: > Devices which optionally support Dynamic Capacity (DC) are configured > via mailbox commands. CXL 3.2 section 9.13.3 requires the host to issue > the Get DC Configuration command in order to properly configure DCDs. > Without the Get DC Confi

Re: [PATCH v3 1/4] kernel/resource: Provide mem region release for SOFT RESERVES

2025-04-04 Thread Jonathan Cameron
On Thu, 3 Apr 2025 13:33:12 -0500 Terry Bowman wrote: > From: Nathan Fontenot > > Add a release_Sam_region_adjustable() interface to allow for Who is Sam? (typo) > removing SOFT RESERVE memory resources. This extracts out the code > to remove a mem region into a common __release_mem_region_a

Re: [PATCH v2] DAX: warn when kmem regions are truncated for memory block alignment.

2025-04-04 Thread Jonathan Cameron
c-aligned but block-misaligned chunks. > > Suggested-by: David Hildenbrand > Suggested-by: Dan Williams > Signed-off-by: Gregory Price One trivial comment inline otherwise seems reasonable to me. Reviewed-by: Jonathan Cameron > --- > drivers/dax/kmem.c | 10 +

Re: [PATCH v3 4/4] cxl/dax: Delay consumption of SOFT RESERVE resources

2025-04-04 Thread Jonathan Cameron
On Thu, 3 Apr 2025 13:33:15 -0500 Terry Bowman wrote: > From: Nathan Fontenot > > The dax hmem device initialization will consume any iomem > SOFT RESERVE resources prior to CXL region creation. To allow > for the CXL driver to complete region creation and trim any > SOFT RESERVE resources befo

Re: [PATCH v3 3/4] dax/mum: Save the dax mum platform device pointer

2025-04-04 Thread Jonathan Cameron
On Thu, 3 Apr 2025 13:33:14 -0500 Terry Bowman wrote: > From: Nathan Fontenot mum? > > In order to handle registering hmem devices for SOFT RESERVE > resources after the dax hmem device initialization occurs > we need to save a reference to the dax hmem platform device > that will be used in

Re: [PATCH v3 2/4] cxl: Update Soft Reserved resources upon region creation

2025-04-04 Thread Jonathan Cameron
On Thu, 3 Apr 2025 13:33:13 -0500 Terry Bowman wrote: > From: Nathan Fontenot > > Update handling of SOFT RESERVE iomem resources that intersect with > CXL region resources to remove intersections from the SOFT RESERVE > resources. The current approach of leaving SOFT RESERVE resources as > is

Re: [PATCH 1/3] of: reserved_mem: Add functions to parse "memory-region"

2025-03-18 Thread Jonathan Cameron
On Mon, 17 Mar 2025 18:24:21 -0500 "Rob Herring (Arm)" wrote: > Drivers with "memory-region" properties currently have to do their own > parsing of "memory-region" properties. The result is all the drivers > have similar patterns of a call to parse "memory-region" and then get > the region's addr

Re: [PATCH v5 6/8] iio: light: stk3310: use dev_err_probe where possible

2025-02-11 Thread Jonathan Cameron
On Sun, 9 Feb 2025 16:47:44 +0200 Andy Shevchenko wrote: > On Sat, Feb 08, 2025 at 04:13:24PM -0500, Aren Moynihan wrote: > > Using dev_err_probe instead of dev_err and return makes the errors > > Use dev_err_probe() > dev_err() > > > easier to understand by including the error name, and save

Re: [PATCH v4 4/6] iio: light: stk3310: use dev_err_probe where possible

2024-11-23 Thread Jonathan Cameron
On Tue, 12 Nov 2024 18:11:37 -0500 Aren wrote: > On Tue, Nov 12, 2024 at 11:15:54AM +0100, Uwe Kleine-König wrote: > > Hello Andy, hello Aren, > > > > On Mon, Nov 11, 2024 at 11:44:51AM +0200, Andy Shevchenko wrote: > > > On Sun, Nov 10, 2024 at 04:34:30PM -0500, Aren wrote: > > > > On Sun,

Re: [PATCH v4 3/6] iio: light: stk3310: Implement vdd and leda supplies

2024-11-03 Thread Jonathan Cameron
On Sat, 2 Nov 2024 15:50:39 -0400 Aren Moynihan wrote: > The vdd and leda supplies must be powered on for the chip to function > and can be powered off during system suspend. > > This was originally based on a patch by Ondrej Jirman[1], but has been > rewritten since. > > 1: > https://codeber

Re: [PATCH v4 2/6] iio: light: stk3310: handle all remove logic with devm callbacks

2024-11-03 Thread Jonathan Cameron
Hi Aren, > @@ -624,7 +640,7 @@ static int stk3310_probe(struct i2c_client *client) > device_property_read_u32(&client->dev, "proximity-near-level", >&data->ps_near_level); > > - mutex_init(&data->lock); > + devm_mutex_init(&client->dev, &data->lock);

Re: [PATCH v3 3/6] iio: light: stk3310: Implement vdd and leda supplies

2024-10-28 Thread Jonathan Cameron
On Mon, 28 Oct 2024 12:37:14 -0400 Aren Moynihan wrote: > On Mon, Oct 28, 2024 at 04:38:37PM +0200, Andy Shevchenko wrote: > > On Mon, Oct 28, 2024 at 10:19:57AM -0400, Aren Moynihan wrote: > > > The vdd and leda supplies must be powered on for the chip to function > > > and can be powered off

Re: [PATCH v3 0/6] iio: light: stk3310: support powering off during suspend

2024-10-28 Thread Jonathan Cameron
On Mon, 28 Oct 2024 10:19:54 -0400 Aren Moynihan wrote: > In the Pine64 PinePhone, the stk3310 chip is powered by a regulator that is > disabled at system boot and can be shut off during suspend. To ensure that > the chip properly initializes, both after boot and suspend, we need to > manage this

Re: [PATCH v8 8/8] selftests/pcie_bwctrl: Create selftests

2024-10-17 Thread Jonathan Cameron
gt; PCIe Port. > > Signed-off-by: Ilpo Järvinen My bash is terrible, but as far as I can tell this looks reasonable. So with that in mind take this with a pinch of salt. Reviewed-by: Jonathan Cameron

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-26 Thread Jonathan Cameron
On Thu, 25 Jul 2024 14:50:50 +0100 David Woodhouse wrote: > On Thu, 2024-07-25 at 08:33 -0400, Michael S. Tsirkin wrote: > > On Thu, Jul 25, 2024 at 01:31:19PM +0100, David Woodhouse wrote: > > > On Thu, 2024-07-25 at 08:29 -0400, Michael S. Tsirkin wrote: > > > > On Thu, Jul 25, 2024 at 01:2

Re: [PATCH 17/17] mm: make range-to-target_node lookup facility a part of numa_memblks

2024-07-19 Thread Jonathan Cameron
lks are now part of the generic code, move these > functions from x86 to mm/numa_memblks.c and select > CONFIG_NUMA_KEEP_MEMINFO when CONFIG_NUMA_MEMBLKS=y for dax and cxl. > > Signed-off-by: Mike Rapoport (Microsoft) Reviewed-by: Jonathan Cameron Thanks. I'll poke around more next week. Have a good weekend. Jonathan

Re: [PATCH 12/17] mm: introduce numa_memblks

2024-07-19 Thread Jonathan Cameron
On Tue, 16 Jul 2024 14:13:41 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Move code dealing with numa_memblks from arch/x86 to mm/ and add Kconfig > options to let x86 select it in its Kconfig. > > This code will be later reused by arch_numa. > > No functional changes. >

Re: [PATCH 16/17] arch_numa: switch over to numa_memblks

2024-07-19 Thread Jonathan Cameron
On Tue, 16 Jul 2024 14:13:45 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Until now arch_numa was directly translating firmware NUMA information > to memblock. > > Using numa_memblks as an intermediate step has a few advantages: > * alignment with more battle tested x86 i

Re: [PATCH 15/17] mm: make numa_memblks more self-contained

2024-07-19 Thread Jonathan Cameron
On Tue, 16 Jul 2024 14:13:44 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Introduce numa_memblks_init() and move some code around to avoid several > global variables in numa_memblks. Hi Mike, Adding the effectively always on memblock_force_top_down deserves a comment on

Re: [PATCH 13/17] mm: move numa_distance and related code from x86 to numa_memblks

2024-07-19 Thread Jonathan Cameron
On Tue, 16 Jul 2024 14:13:42 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Move code dealing with numa_distance array from arch/x86 to > mm/numa_memblks.c It's not really numa memblock related. Is this the best place to put it? > > This code will be later reused by arch_

Re: [PATCH 11/17] x86/numa: numa_{add,remove}_cpu: make cpu parameter unsigned

2024-07-19 Thread Jonathan Cameron
numa emulation code with these architectures. > > Signed-off-by: Mike Rapoport (Microsoft) Makes sense for both reasons. FWIW given how simple it is. Maybe worth bringing a few more functions inline with this? Probably something for another day given we don't care about the inconsistency for this series. Reviewed-by: Jonathan Cameron

Re: [PATCH 10/17] x86/numa_emu: use a helper function to get MAX_DMA32_PFN

2024-07-19 Thread Jonathan Cameron
ort (Microsoft) Reviewed-by: Jonathan Cameron

Re: [PATCH 09/17] x86/numa_emu: split __apicid_to_node update to a helper function

2024-07-19 Thread Jonathan Cameron
t (Microsoft) Not the most intuitive of function names but I can't immediately think of a better one. Reviewed-by: Jonathan Cameron

Re: [PATCH 08/17] x86/numa_emu: simplify allocation of phys_dist

2024-07-19 Thread Jonathan Cameron
allocation. > > Replace memblock_phys_alloc_range() with memblock_alloc(). > > Signed-off-by: Mike Rapoport (Microsoft) Indeed seems to be after mapping physical memory, so this looks fine. Reviewed-by: Jonathan Cameron

Re: [PATCH 07/17] x86/numa: move FAKE_NODE_* defines to numa_emu

2024-07-19 Thread Jonathan Cameron
t; Signed-off-by: Mike Rapoport (Microsoft) Reviewed-by: Jonathan Cameron

Re: [PATCH 06/17] x86/numa: simplify numa_distance allocation

2024-07-19 Thread Jonathan Cameron
On Tue, 16 Jul 2024 14:13:35 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Allocation of numa_distance uses memblock_phys_alloc_range() to limit > allocation to be below the last mapped page. > > But NUMA initializaition runs after the direct map is populated and initiali

Re: [PATCH 05/17] arch, mm: pull out allocation of NODE_DATA to generic code

2024-07-19 Thread Jonathan Cameron
given that file already has mix and match of those and normal prints in single functions I assume this change is fine and we'll just see the prints a bit later. Reviewed-by: Jonathan Cameron

Re: [PATCH 05/17] arch, mm: pull out allocation of NODE_DATA to generic code

2024-07-19 Thread Jonathan Cameron
On Fri, 19 Jul 2024 17:07:35 +0200 David Hildenbrand wrote: > >>> - * Allocate node data. Try node-local memory and then any node. > >>> - * Never allocate in DMA zone. > >>> - */ > >>> - nd_pa = memblock_phys_alloc_try_nid(nd_size, SMP_CACHE_BYTES, nid); > >>> - if (!nd_pa) { > >>> -

Re: [PATCH 04/17] arch, mm: move definition of node_data to generic code

2024-07-19 Thread Jonathan Cameron
igned-off-by: Mike Rapoport (Microsoft) Reviewed-by: Jonathan Cameron

Re: [PATCH 03/17] MIPS: loongson64: rename __node_data to node_data

2024-07-19 Thread Jonathan Cameron
t; Signed-off-by: Mike Rapoport (Microsoft) FWIW rename looks fine Reviewed-by: Jonathan Cameron

Re: [PATCH 02/17] MIPS: sgi-ip27: make NODE_DATA() the same as on all other architectures

2024-07-19 Thread Jonathan Cameron
On Wed, 17 Jul 2024 16:32:59 +0200 David Hildenbrand wrote: > On 16.07.24 13:13, Mike Rapoport wrote: > > From: "Mike Rapoport (Microsoft)" > > > > sgi-ip27 is the only system that defines NODE_DATA() differently than > > the rest of NUMA machines. > > > > Add node_data array of struct pglist

Re: [PATCH 01/17] mm: move kernel/numa.c to mm/

2024-07-19 Thread Jonathan Cameron
are in arch/*/mm not arch/*/kernel so this makes it more consistent with that. Reviewed-by: Jonathan Cameron

Re: [PATCH 00/17] mm: introduce numa_memblks

2024-07-19 Thread Jonathan Cameron
On Tue, 16 Jul 2024 14:13:29 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Hi, > > Following the discussion about handling of CXL fixed memory windows on > arm64 [1] I decided to bite the bullet and move numa_memblks from x86 to > the generic code so they will be available

Re: [PATCH v2 2/6] iio: light: stk3310: Implement vdd supply and power it off during suspend

2024-04-28 Thread Jonathan Cameron
On Tue, 23 Apr 2024 18:33:05 -0400 Aren Moynihan wrote: > From: Ondrej Jirman > > VDD power input can be used to completely power off the chip during > system suspend. Do so if available. > > Signed-off-by: Ondrej Jirman > Signed-off-by: Aren Moynihan Suggestions inline. Key thing is take

Re: [PATCH v2 2/6] iio: light: stk3310: Implement vdd supply and power it off during suspend

2024-04-28 Thread Jonathan Cameron
On Wed, 24 Apr 2024 18:20:41 +0300 Andy Shevchenko wrote: > On Wed, Apr 24, 2024 at 3:59 PM Ondřej Jirman wrote: > > On Wed, Apr 24, 2024 at 02:16:06AM GMT, Andy Shevchenko wrote: > > > On Wed, Apr 24, 2024 at 1:41 AM Aren Moynihan > > > wrote: > > ... > > > > > ret = stk3310_ini

Re: [PATCH v2 2/6] iio: light: stk3310: Implement vdd supply and power it off during suspend

2024-04-28 Thread Jonathan Cameron
On Wed, 24 Apr 2024 02:16:06 +0300 Andy Shevchenko wrote: > On Wed, Apr 24, 2024 at 1:41 AM Aren Moynihan wrote: > > > > From: Ondrej Jirman > > > > VDD power input can be used to completely power off the chip during > > system suspend. Do so if available. > > ... > > > ret = stk331

Re: [PATCH 3/4] iio: light: stk3310: log error if reading the chip id fails

2024-04-20 Thread Jonathan Cameron
On Mon, 15 Apr 2024 18:05:54 +0300 Andy Shevchenko wrote: > On Sun, Apr 14, 2024 at 8:57 PM Aren Moynihan wrote: > > > > If the chip isn't powered, this call is likely to return an error. > > Without a log here the driver will silently fail to probe. Common errors > > are ENXIO (when the chip is

Re: [PATCH 1/4] dt-bindings: iio: light: stk33xx: add regulator for vdd supply

2024-04-20 Thread Jonathan Cameron
On Sun, 14 Apr 2024 13:57:13 -0400 Aren Moynihan wrote: > Signed-off-by: Aren Moynihan > --- > Documentation/devicetree/bindings/iio/light/stk33xx.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/iio/light/stk33xx.yaml > b/Documentation/devicetre

Re: [PATCH 2/4] iio: light: stk3310: Implement vdd supply and power it off during suspend

2024-04-20 Thread Jonathan Cameron
On Sun, 14 Apr 2024 13:57:14 -0400 Aren Moynihan wrote: > From: Ondrej Jirman > > VDD power input can be used to completely power off the chip during > system suspend. Do so if available. I'd make this non optional (relying on regulator framework providing us a stub for old DT etc) and pay the

Re: [PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-19 Thread Jonathan Cameron
type is created for storing all memory types that are > not initialized by device drivers and as a fallback. > > Signed-off-by: Ho-Ren (Jack) Chuang > Signed-off-by: Hao Xiang > Reviewed-by: "Huang, Ying" Reviewed-by: Jonathan Cameron

Re: [PATCH] dt-bindings: iio: imu: mpu6050: Improve i2c-gate disallow list

2024-04-13 Thread Jonathan Cameron
On Tue, 9 Apr 2024 08:36:08 +0200 Krzysztof Kozlowski wrote: > On 08/04/2024 18:34, Luca Weiss wrote: > > Before all supported sensors except for MPU{9150,9250,9255} were not > > allowed to use i2c-gate in the bindings which excluded quite a few > > supported sensors where this functionality is s

Re: [External] Re: [PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-10 Thread Jonathan Cameron
On Tue, 9 Apr 2024 12:02:31 -0700 "Ho-Ren (Jack) Chuang" wrote: > Hi Jonathan, > > On Tue, Apr 9, 2024 at 9:12 AM Jonathan Cameron > wrote: > > > > On Fri, 5 Apr 2024 15:43:47 -0700 > > "Ho-Ren (Jack) Chuang" wrote: > > > >

  1   2   3   4   5   6   7   8   9   10   >