On Wed, 30 Jul 2025 17:42:01 +0530 Neeraj Kumar <s.nee...@samsung.com> wrote:
> During namespace creation skip presence of region label if present. Confusing description. What does skipping presence mean? Reword. During namespace creation, skip any region labels found. > Also preserve region label into labels list if present. > > Signed-off-by: Neeraj Kumar <s.nee...@samsung.com> > --- > drivers/nvdimm/namespace_devs.c | 50 +++++++++++++++++++++++++++++---- > 1 file changed, 45 insertions(+), 5 deletions(-) > > diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c > index e5c2f78ca7dd..8edd26407939 100644 > --- a/drivers/nvdimm/namespace_devs.c > +++ b/drivers/nvdimm/namespace_devs.c > @@ -1985,6 +1985,10 @@ static struct device **scan_labels(struct nd_region > *nd_region) > if (!lsa_label) > continue; > > + /* skip region labels if present */ This is kind of obvious comment. I'd drop it. > + if (is_region_label(ndd, lsa_label)) > + continue; > + > nd_label = &lsa_label->ns_label; >
