Re: [RFT 25/25] ARM: dts: s5pv210: align DMA channels with dtschema

2020-09-07 Thread Jonathan Bakker
Ah, I figured out why the dma stopped working. In s5pv210-aries.dtsi the dma's for i2s0 are overriden to use pdma0 instead of pdma1. That also needs changing for this to work properly. Thanks, Jonathan On 2020-09-07 5:17 p.m., Jonathan Bakker wrote: > Initial testing on both an i900

Re: [RFT 25/25] ARM: dts: s5pv210: align DMA channels with dtschema

2020-09-07 Thread Jonathan Bakker
Initial testing on both an i9000 and an SGH-T959P are showing that the audio has stopped working with this. I'm not 100% convinced as I've had DMA issues in the past. However trying to play something just results in a hang after 1.5s while it works just fine without this patch. Thanks, Jonathan

Re: [PATCH 11/25] ARM: dts: s5pv210: add RTC 32 KHz clock in Aries family

2020-09-07 Thread Jonathan Bakker
Hi Krzysztof, On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote: > The S3C RTC requires 32768 Hz clock as input which is provided by PMIC. > However there is no such clock provider but rather a regulator driver > which registers the clock as a regulator. This is an old driver which > will not be

Re: [RFT 09/25] ARM: dts: s5pv210: fix number of I2S DAI cells

2020-09-07 Thread Jonathan Bakker
Sadly, this is causing issues for me. The machine driver is no longer probing correctly on the Galaxy S. The failing call in sound/soc/samsung/aries_wm8994.c is /* Set CPU of_node for BT DAI */ aries_dai[2].cpus->of_node = of_parse_phandle(cpu, "sound-dai

Re: [RFT 24/25] ARM: dts: s5pv210: align SPI GPIO node name with dtschema in Aries

2020-09-07 Thread Jonathan Bakker
Works for me on the Galaxy S. Tested-by: Jonathan Bakker Thanks, Jonathan On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote: > The device tree schema expects SPI controller to be named "spi", > otherwise dtbs_check complain with a warning like: > > spi-gpio-0: $n

Re: [RFT 08/25] ARM: dts: s5pv210: remove dedicated 'audio-subsystem' node

2020-09-07 Thread Jonathan Bakker
Audio still works for me on the Galaxy S. Tested-by: Jonathan Bakker Thanks, Jonathan On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote: > The 'audio-subsystem' node is an artificial creation, not representing > real hardware. The hardware is described by its nodes - AUDSS cl

Re: [RFT 07/25] ARM: dts: s5pv210: move PMU node out of clock controller

2020-09-07 Thread Jonathan Bakker
Works for me on the Galaxy S. Tested-by: Jonathan Bakker Thanks, Jonathan On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote: > The Power Management Unit (PMU) is a separate device which has little > common with clock controller. Moving it to one level up (from clock > controller chi

Re: [RFT 06/25] ARM: dts: s5pv210: move fixed clocks under root node

2020-09-07 Thread Jonathan Bakker
Works for me on the Galaxy S. Tested-by: Jonathan Bakker Thanks, Jonathan On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote: > The fixed clocks are kept under dedicated 'external-clocks' node, thus a > fake 'reg' was added. This is not correct with dtschema as fixe

Re: [RFT 05/25] ARM: dts: s5pv210: remove DMA controller bus node name to fix dtschema warnings

2020-09-07 Thread Jonathan Bakker
DMA still works for me on the Galaxy S. Tested-by: Jonathan Bakker Thanks, Jonathan On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote: > There is no need to keep DMA controller nodes under AMBA bus node. > Remove the "amba" node to fix dtschema warnings like: > > am

Re: [PATCH 03/25] dt-bindings: iio: adc: exynos-adc: do not require syscon on S5Pv210

2020-09-07 Thread Jonathan Bakker
Looking at this again, it appears that there is actually control for it at offset 0x6818 of pmu_syscon (0xe0108000) [1]. However, it defaults to enabled so it's not required for proper use of the block. Whether it should be present in the schema/DTS is up to you. Thanks, Jonathan [1] https://a

Re: [PATCH v2] power: supply: charger-manager: Fix info message in check_charging_duration()

2020-09-02 Thread Jonathan Bakker
On 2020-09-02 9:46 a.m., Colin Ian King wrote: > On 02/09/2020 17:43, Gustavo A. R. Silva wrote: >> On Wed, Sep 02, 2020 at 09:29:31AM -0700, Randy Dunlap wrote: >>> On 9/2/20 9:23 AM, Gustavo A. R. Silva wrote: A few months ago, commit e132fc6bb89b ("power: supply: charger-manager: M

[PATCH] ARM: dts: s5pv210: Enable audio on Aries boards

2020-09-01 Thread Jonathan Bakker
Both the galaxys and the fascinate4g have a wm8994 codec, but they differ slightly in their jack detection and micbias configuration. Signed-off-by: Jonathan Bakker --- arch/arm/boot/dts/s5pv210-aries.dtsi | 10 +++ arch/arm/boot/dts/s5pv210-fascinate4g.dts | 98

[PATCH v2 05/11] media: exynos4-is: Properly set JPEG options for parallel ports

2020-07-30 Thread Jonathan Bakker
Commit ee7160e57c98 ("[media] s5p-fimc: Add support for JPEG capture") added support for JPEG capture, but missed setting a register when the parallel port was used rather than the CSIS device. Signed-off-by: Jonathan Bakker Reviewed-by: Sylwester Nawrocki --- Changes from v1: -

[PATCH v2 08/11] media: exynos4-is: Remove inh_sensor_ctrls

2020-07-30 Thread Jonathan Bakker
This is a no-op as it is never set and is a remnant from non-DT days that can be safely removed. Signed-off-by: Jonathan Bakker Reviewed-by: Tomasz Figa Reviewed-by: Sylwester Nawrocki --- Changes from v1: - Added R-b tags --- drivers/media/platform/exynos4-is/fimc-capture.c | 13

[PATCH v2 06/11] media: exynos4-is: Use global num_sensors rather than local index

2020-07-30 Thread Jonathan Bakker
tiple sensors being connected to the same port. Signed-off-by: Jonathan Bakker --- Changes from v1: - New patch --- drivers/media/platform/exynos4-is/media-dev.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/

[PATCH v2 10/11] media: exynos4-is: Handle duplicate calls to vidioc_streamoff

2020-07-30 Thread Jonathan Bakker
dded a WARN for unbalanced calls to media_pipeline_stop. Signed-off-by: Jonathan Bakker --- Changes from v1: - re-worded commit message for a better description of the problem --- drivers/media/platform/exynos4-is/fimc-capture.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[PATCH v2 09/11] media: exynos4-is: Remove unused struct member input_index

2020-07-30 Thread Jonathan Bakker
This is no longer used since the conversion to DT Signed-off-by: Jonathan Bakker Reviewed-by: Tomasz Figa Reviewed-by: Sylwester Nawrocki --- Changes from v1: - Added R-b tags --- drivers/media/platform/exynos4-is/fimc-core.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media

[PATCH v2 07/11] media: exynos4-is: Add support for multiple sensors on one port

2020-07-30 Thread Jonathan Bakker
On some devices, there may be multiple camera sensors attached to the same port. Make sure we probe all of them, not just the first one. Signed-off-by: Jonathan Bakker --- Changes from v1: - Separated parsing each endpoint into separate func --- drivers/media/platform/exynos4-is/media-dev.c

[PATCH v2 11/11] dt-bindings: media: Correct samsung-fimc parallel port numbering

2020-07-30 Thread Jonathan Bakker
The parallel port nodes should be numbered 1 and 2, not 0 and 1 for A and B respectively. The driver has always implemented 1 and 2 and the in-tree Goni DTS uses 1 as port A as well. Update the documentation to match this behaviour. Signed-off-by: Jonathan Bakker --- Changes from v1: - New

[PATCH v2 02/11] media: exynos4-is: Request syscon only if ISP writeback is present

2020-07-30 Thread Jonathan Bakker
From: Tomasz Figa On FIMC variants which don't have writeback channel, there is no need to access system registers. This patch makes the driver request sysreg regmap conditionally depending on whether writeback is supported. Signed-off-by: Tomasz Figa Signed-off-by: Jonathan Bakker Rev

[PATCH v2 03/11] media: exynos4-is: Fix nullptr when no CSIS device present

2020-07-30 Thread Jonathan Bakker
ly to check if we are using the subdev API Signed-off-by: Jonathan Bakker Reviewed-by: Sylwester Nawrocki --- Changes from v1: - Added R-b tag --- drivers/media/platform/exynos4-is/media-dev.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/media/pla

[PATCH v2 04/11] media: exynos4-is: Correct missing entity function initialization

2020-07-30 Thread Jonathan Bakker
gs on boot. Signed-off-by: Jonathan Bakker --- Changes from v1: - Don't remove the function from the vfd entity as it is distinct from the sd entity - Re-word commit message for above change --- drivers/media/platform/exynos4-is/fimc-capture.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 00/11] media: exynos4-is: Improve support for s5pv210 and parallel ports

2020-07-30 Thread Jonathan Bakker
modifying driver Jonathan Bakker (10): media: exynos4-is: Remove static driver data for S5PV210 FIMC variants media: exynos4-is: Fix nullptr when no CSIS device present media: exynos4-is: Correct missing entity function initialization media: exynos4-is: Properly set JPEG options for parallel

[PATCH v2 01/11] media: exynos4-is: Remove static driver data for S5PV210 FIMC variants

2020-07-30 Thread Jonathan Bakker
The S5PV210 platform only supports device tree based booting where the FIMC variant data is parsed directly from the device tree, hence the now unused static data can be removed. Signed-off-by: Jonathan Bakker Reviewed-by: Tomasz Figa Reviewed-by: Sylwester Nawrocki --- Changes from v1

Re: [PATCH 10/11] media: exynos4-is: Prevent duplicate call to media_pipeline_stop

2020-07-24 Thread Jonathan Bakker
Hi Tomasz, On 2020-07-20 6:10 a.m., Tomasz Figa wrote: > On Sat, Jul 11, 2020 at 8:17 PM Jonathan Bakker wrote: >> >> Hi Tomasz, >> >> On 2020-07-07 11:44 a.m., Tomasz Figa wrote: >>> Hi Jonathan, >>> >>> On Sat, Apr 25, 2020 at 07:26:49PM

Re: [PATCH 05/11] media: exynos4-is: Improve support for sensors with multiple pads

2020-07-11 Thread Jonathan Bakker
Hi Tomasz, On 2020-07-07 11:13 a.m., Tomasz Figa wrote: > Hi Jonathan, > > On Sat, Apr 25, 2020 at 07:26:44PM -0700, Jonathan Bakker wrote: >> Commit 1c9f5bd7cb8a ("[media] s5p-fimc: Add support for sensors with >> multiple pads") caught the case where

Re: [PATCH 11/11] media: exynos4-is: Correct parallel port probing

2020-07-11 Thread Jonathan Bakker
Hi Sylwester, On 2020-07-08 9:15 a.m., Sylwester Nawrocki wrote: > Hi, > > On 26.04.2020 04:26, Jonathan Bakker wrote: >> According to the binding doc[1], port A should be reg = 0 >> and port B reg = 1. Unfortunately, the driver was treating 0 >> as invalid and 1 a

Re: [PATCH 10/11] media: exynos4-is: Prevent duplicate call to media_pipeline_stop

2020-07-11 Thread Jonathan Bakker
Hi Tomasz, On 2020-07-07 11:44 a.m., Tomasz Figa wrote: > Hi Jonathan, > > On Sat, Apr 25, 2020 at 07:26:49PM -0700, Jonathan Bakker wrote: >> media_pipeline_stop can be called from both release and streamoff, >> so make sure they're both protected under the streaming f

Re: [PATCH 07/11] media: exynos4-is: Add support for multiple sensors on one port

2020-07-11 Thread Jonathan Bakker
Hi Tomasz, On 2020-07-07 11:36 a.m., Tomasz Figa wrote: > On Sat, Apr 25, 2020 at 07:26:46PM -0700, Jonathan Bakker wrote: >> On some devices, there may be multiple camera sensors attached >> to the same port. Make sure we probe all of them, not just the >> first one

Re: [PATCH 06/11] media: exynos4-is: Properly set JPEG options when not using CSIS

2020-07-11 Thread Jonathan Bakker
Hi Sylwester and Tomasz, On 2020-07-08 8:45 a.m., Sylwester Nawrocki wrote: > Hi, > > On 07.07.2020 20:23, Tomasz Figa wrote: >> On Sat, Apr 25, 2020 at 07:26:45PM -0700, Jonathan Bakker wrote: >>> Commit ee7160e57c98 ("[media] s5p-fimc: Add support for JPEG capture

Re: [PATCH 04/11] media: exynos4-is: Correct missing entity function initialization

2020-07-11 Thread Jonathan Bakker
Hi Sylwester and Tomasz, On 2020-07-08 8:34 a.m., Sylwester Nawrocki wrote: > Hi, > > On 07.07.2020 20:09, Tomasz Figa wrote: >> On Sat, Apr 25, 2020 at 07:26:43PM -0700, Jonathan Bakker wrote: >>> Commit bae4500399c4 ("[media] exynos4-is: Add missing entity functi

Re: [PATCH 03/11] media: exynos4-is: Fix nullptr when no CSIS device present

2020-07-11 Thread Jonathan Bakker
Hi Sylwester and Tomasz, On 2020-07-08 8:11 a.m., Sylwester Nawrocki wrote: > Hi, > > On 07.07.2020 19:55, Tomasz Figa wrote: >> On Sat, Apr 25, 2020 at 07:26:42PM -0700, Jonathan Bakker wrote: >>> Not all devices use the CSIS device, some may use the FIMC directly in

Re: [PATCH 00/11] media: exynos4-is: Improve support for s5pv210 and parallel ports

2020-06-24 Thread Jonathan Bakker
Hi Tomasz, On 2020-06-24 4:58 a.m., Tomasz Figa wrote: > On Wed, Jun 24, 2020 at 1:54 PM Krzysztof Kozlowski wrote: >> >> On Wed, Jun 24, 2020 at 01:39:50PM +0200, Hans Verkuil wrote: >>> Can someone from Samsung or someone who knows this SoC take a look at this >>> series? >>> >>> This series l

[PATCH 2/3] dt-bindings: sound: Add bindings for Samsung Aries audio complex

2020-06-14 Thread Jonathan Bakker
FM and the modem is the master. Signed-off-by: Jonathan Bakker --- .../bindings/sound/samsung,aries-wm8994.yaml | 147 ++ 1 file changed, 147 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/samsung,aries-wm8994.yaml diff --git a/Documentation

[PATCH 1/3] dt-bindings: sound: Document wm8994 endpoints

2020-06-14 Thread Jonathan Bakker
The wm8994 exposes several inputs and outputs that can be used by machine drivers in their routing. Add them to the documention so they don't have been duplicated in any machine drivers bindings. Signed-off-by: Jonathan Bakker --- .../devicetree/bindings/sound/wm8994.txt

[PATCH 3/3] ASoC: samsung: Add driver for Aries boards

2020-06-14 Thread Jonathan Bakker
the headphone jack. There are two main variants, one with an FM radio and where the modem is the master and one without a radio and the modem is the slave. Signed-off-by: Jonathan Bakker --- sound/soc/samsung/Kconfig| 13 + sound/soc/samsung/Makefile | 2 + sound/soc/samsung

[PATCH 0/3] ASoC: samsung: Add machine driver for Aries boards

2020-06-14 Thread Jonathan Bakker
e AIF should be forced into mono mode. UCM2 config files are available at https://github.com/xc-racer99/aries-hw-files/tree/ucm2/usr/share/alsa/ucm2 Jonathan Bakker (3): dt-bindings: sound: Document wm8994 endpoints dt-bindings: sound: Add bindings for Samsung Aries audio complex ASoC: sams

[PATCH 3/5] ARM: dts: s5pv210: Add support for GP2A light sensor on Aries

2020-06-13 Thread Jonathan Bakker
Aries boards have a GP2A light/proximity sensor attached over i2c-gpio. As the chip outputs a current and the board has no current ADC, a current shunt resistor and a voltage ADC are used. Signed-off-by: Jonathan Bakker --- arch/arm/boot/dts/s5pv210-aries.dtsi | 50

[PATCH 5/5] ARM: dts: s5pv210: Correct BCM4329 bluetooth node

2020-06-13 Thread Jonathan Bakker
some rates didn't work, and the some pinctrl settings weren't explicitly set. Fix all of the above issues. While we're at it, update from the deprecated host-wakeup-gpios property to the host-wake interrupt. Signed-off-by: Jonathan Bakker --- arch/arm/boot/dts/s5p

[PATCH 0/5] ARM: dts: s5pv210: Improvements for Aries boards

2020-06-13 Thread Jonathan Bakker
definition also had some issues with it. There is one change to the common s5pv210 dtsi and that is that the gph3 bank was missing the interrupt-controller property. Jonathan Bakker (5): ARM: dts: s5pv210: Add interrupt-controller property to gph3 ARM: dts: s5pv210: Correct fuelgauge definition

[PATCH 2/5] ARM: dts: s5pv210: Correct fuelgauge definition on Aries

2020-06-13 Thread Jonathan Bakker
Correct the fuelgauge definition because only the fuelgauge on fascinate4g has interrupt support (and even then it was wrong). Also, assign the GPIO pinctrl so the interrupt is properly configured Signed-off-by: Jonathan Bakker --- arch/arm/boot/dts/s5pv210-aries.dtsi | 4 +--- arch/arm

[PATCH 1/5] ARM: dts: s5pv210: Add interrupt-controller property to gph3

2020-06-13 Thread Jonathan Bakker
The GPH3 pins on s5pv210 have interrupt support and had the interrupt-cells property but was missing the interrupt-controller property. Signed-off-by: Jonathan Bakker --- arch/arm/boot/dts/s5pv210-pinctrl.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/s5pv210

[PATCH 4/5] ARM: dts: s5pv210: Add BMA023 accelerometer support to Aries

2020-06-13 Thread Jonathan Bakker
Aries boards have a BMA023 accelerometer attached over i2c-gpio. Signed-off-by: Jonathan Bakker --- arch/arm/boot/dts/s5pv210-aries.dtsi | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi index

Re: [PATCH 3/3] power: supply: max17040: Set rcomp value

2020-05-29 Thread Jonathan Bakker
x17040 but does for the later max17043/max77836 where its only 8 bits)? Thanks and sorry for the issues, Jonathan On 2020-05-28 10:02 a.m., Sebastian Reichel wrote: > Hi, > > This patch does not even compile, how did you test it? > > -- Sebastian > > On Mon, May 04, 2020 at 03

Re: [PATCH 1/2] dt-bindings: iio: adc: Add binding for current-from-voltage

2020-05-28 Thread Jonathan Bakker
Hi Rob, On 2020-05-28 1:13 p.m., Rob Herring wrote: > On Fri, May 15, 2020 at 07:26:18PM -0700, Jonathan Bakker wrote: >> Some devices may require a current adc, but only have a voltage >> ADC onboard. In order to read the current, they have a resistor >> connected to the A

Re: [PATCH 2/2] regulator: max8998: Add charger regulator

2020-05-17 Thread Jonathan Bakker
lore.kernel.org/lkml/20110709030853.ga23...@opensource.wolfsonmicro.com/ On 2020-05-16 12:47 p.m., Jonathan Bakker wrote: > The max8998 has a current regulator for charging control. The > charger driver in drivers/power/supply/max8998_charger.c has a > comment in it stating that 'charger control is done b

[PATCH] power: supply: max8998_charger: Correct ONLINE and add STATUS props

2020-05-16 Thread Jonathan Bakker
. Signed-off-by: Jonathan Bakker --- drivers/power/supply/max8998_charger.c | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/drivers/power/supply/max8998_charger.c b/drivers/power/supply/max8998_charger.c index 9a926c7c0f22..c26023b19f26 100644 --- a

[PATCH 2/2] regulator: max8998: Add charger regulator

2020-05-16 Thread Jonathan Bakker
have been extracted from a downstream driver for the SGH-T959V. Signed-off-by: Jonathan Bakker --- drivers/regulator/max8998.c | 105 include/linux/mfd/max8998.h | 1 + 2 files changed, 106 insertions(+) diff --git a/drivers/regulator/max8998.c b/drivers

[PATCH 1/2] dt-bindings: mfd: max8998: Document charger regulator

2020-05-16 Thread Jonathan Bakker
max8998 has a current regulator for control of its charging current. Document it. Signed-off-by: Jonathan Bakker --- Documentation/devicetree/bindings/mfd/max8998.txt | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/max8998.txt b/Documentation

Re: [PATCH 0/2] iio: adc: Add a current from voltage driver

2020-05-16 Thread Jonathan Bakker
Oops, sorry about that, you're absolutely right. The current-sense-shunt part of iio-rescale is exactly what I was looking for. Thanks, Jonathan On 2020-05-15 11:28 p.m., Lars-Peter Clausen wrote: > On 5/16/20 4:26 AM, Jonathan Bakker wrote: >> In the discussion around adding the

[PATCH 1/2] dt-bindings: iio: adc: Add binding for current-from-voltage

2020-05-15 Thread Jonathan Bakker
Some devices may require a current adc, but only have a voltage ADC onboard. In order to read the current, they have a resistor connected to the ADC. Add bindings for this possibility. Signed-off-by: Jonathan Bakker --- .../iio/adc/linux,current-from-voltage.yaml | 47 +++ 1

[PATCH 2/2] iio: adc: Add current-from-voltage driver

2020-05-15 Thread Jonathan Bakker
Some devices may require a current adc, but only have a voltage ADC onboard. In order to read the current, they have a resistor connected to the ADC. Suggested-by: Jonathan Cameron Signed-off-by: Jonathan Bakker --- MAINTAINERS| 8 ++ drivers/iio/adc/Kconfig

[PATCH 0/2] iio: adc: Add a current from voltage driver

2020-05-15 Thread Jonathan Bakker
://lore.kernel.org/linux-iio/20200202150843.762c6897@archlinux/ Jonathan Bakker (2): dt-bindings: iio: adc: Add binding for current-from-voltage iio: adc: Add current-from-voltage driver .../iio/adc/linux,current-from-voltage.yaml | 47 +++ MAINTAINERS | 8

[PATCH 06/10] power: supply: charger-manager: Make decisions focussed on battery status

2020-05-14 Thread Jonathan Bakker
, cm_monitor() moves battery state diagram and does the optimal operation for current state. As a result, it reduces whole monitoring time almost in half. Signed-off-by: Jonghwa Lee Signed-off-by: Krzysztof Kozlowski Signed-off-by: Jonathan Bakker --- drivers/power/supply/charger-manager.c | 181

[PATCH 00/10] power: supply: Charger-manager improvements

2020-05-14 Thread Jonathan Bakker
og/drivers/power/charger-manager.c?h=tizen_5.0 Jonathan Bakker (4): power: supply: charger-manager: Always use POWER_SUPPLY_PROP_TEMP power: supply: charger-manager: Update extcon functions power: supply: charger-manager: Count cm-chargers property directly dt-bindings: power: supply: Clean

[PATCH 10/10] dt-bindings: power: supply: Cleanup charger-manager bindings

2020-05-14 Thread Jonathan Bakker
The bindings for charger-manager were very unclear and didn't specify allowable values in many cases. Clean these up to show what each value does and make sure all properties are documented here rather than using wildcards. Signed-off-by: Jonathan Bakker --- .../bindings/power/supply/ch

[PATCH 04/10] power: supply: charger-manager: Correct usage of CHARGE_NOW/FULL

2020-05-14 Thread Jonathan Bakker
From: Jonghwa Lee The POWER_SUPPLY_CHARGE_NOW/FULL property reflects battery's charges in uAh unit, but charger-manager has been used it wrongly as a status field. Signed-off-by: Jonghwa Lee Signed-off-by: Krzysztof Kozlowski Signed-off-by: Jonathan Bakker --- drivers/power/supply/ch

[PATCH 02/10] power: supply: charger-manager: Remove cm_notify_event function

2020-05-14 Thread Jonathan Bakker
-off-by: Jonghwa Lee Signed-off-by: Krzysztof Kozlowski Signed-off-by: Jonathan Bakker --- drivers/power/supply/charger-manager.c | 183 ++--- include/linux/power/charger-manager.h | 33 + 2 files changed, 16 insertions(+), 200 deletions(-) diff --git a/drivers/power

[PATCH 01/10] power: supply: charger-manager: Swap private uevent for power_supply_changed

2020-05-14 Thread Jonathan Bakker
: Jonathan Bakker --- drivers/power/supply/charger-manager.c | 91 -- 1 file changed, 11 insertions(+), 80 deletions(-) diff --git a/drivers/power/supply/charger-manager.c b/drivers/power/supply/charger-manager.c index a21e1a2673f8..330185b960a5 100644 --- a/drivers/power/supply

[PATCH 05/10] power: supply: charger-manager: Collect all power_supply_changed() calls

2020-05-14 Thread Jonathan Bakker
Signed-off-by: Krzysztof Kozlowski Signed-off-by: Jonathan Bakker --- drivers/power/supply/charger-manager.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/power/supply/charger-manager.c b/drivers/power/supply/charger-manager.c index 80d1699c938a

[PATCH 07/10] power: supply: charger-manager: Don't start charging in cable nofitication

2020-05-14 Thread Jonathan Bakker
more important that charging is enabled always in safe context. Signed-off-by: Jonghwa Lee Signed-off-by: Krzysztof Kozlowski Signed-off-by: Jonathan Bakker --- drivers/power/supply/charger-manager.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/power/s

[PATCH 09/10] power: supply: charger-manager: Count cm-chargers property directly

2020-05-14 Thread Jonathan Bakker
Rather than having a cm-chargers and a separate cm-num-chargers property, simply count the entries in cm-chargers. Signed-off-by: Jonathan Bakker --- drivers/power/supply/charger-manager.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/power/supply/charger

[PATCH 03/10] power: supply: charger-manager: Always use POWER_SUPPLY_PROP_TEMP

2020-05-14 Thread Jonathan Bakker
oth to use POWER_SUPPLY_PROP_TEMP. Signed-off-by: Jonathan Bakker --- drivers/power/supply/charger-manager.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/power/supply/charger-manager.c b/drivers/power/supply/charger-manager.c index 413f291fda5f..6a5ae1d0e

[PATCH 08/10] power: supply: charger-manager: Update extcon functions

2020-05-14 Thread Jonathan Bakker
the extcon cable names and their IDs is needed. In order to retain DT compatibility, TA and CHARGE-DOWNSTREAM are added as they were present up until commit 11eecf910bd8 ("extcon: Modify the id and name of external connector") Signed-off-by: Jonathan Bakker --- drivers/power/supply/ch

[PATCH v2 4/7] dt-bindings: iio: accel: Add required regulators to bma180

2020-05-14 Thread Jonathan Bakker
The bma180 and related chips should have two registers attached to them. The IIO driver currently uses them, document them here as well. Acked-by: Rob Herring Reviewed-by: Linus Walleij Signed-off-by: Jonathan Bakker --- Changes from v1 - Added A-b and R-b tags --- Documentation/devicetree

[PATCH v2 1/7] iio: accel: bma180: Prepare for different reset values

2020-05-14 Thread Jonathan Bakker
Some variants of the bma180 (eg bma023) have different reset values. In preparation for adding support for them, factor out the reset value into the chip specific data. Reviewed-by: Linus Walleij Signed-off-by: Jonathan Bakker --- Changes from v1 - Added R-b tag --- drivers/iio/accel/bma180.c

[PATCH v2 0/7] iio: accel: Add bma150 family support to bma180

2020-05-14 Thread Jonathan Bakker
were working. Changes from v1: -Added patches for bma150 and smb380 variants -Add R-b and A-b tags -Change so BMA180 and INPUT_BMA150 conflict rather than removing the i2c ids from the input driver when the iio driver is enabled Jonathan Bakker (7): iio: accel: bma180: Prepare for different

[PATCH v2 7/7] iio: accel: Add bma150/smb380 support to bma180

2020-05-14 Thread Jonathan Bakker
The bma150/smb380 are very similar to the bma023 but have a temperature channel as well. Signed-off-by: Jonathan Bakker --- drivers/iio/accel/Kconfig | 6 ++-- drivers/iio/accel/bma180.c | 71 +++--- 2 files changed, 70 insertions(+), 7 deletions(-) diff --git

[PATCH v2 2/7] iio: accel: Make bma180 conflict with input's bma150

2020-05-14 Thread Jonathan Bakker
The bma180 IIO driver is being extended for support for the chips support by input's bma150 driver (bma023, bma150, smb380). Don't allow both drivers to be enabled simultaneously as they're for the same hardware. Signed-off-by: Jonathan Bakker --- drivers/iio/accel/Kconfig

[PATCH v2 5/7] iio: accel: bma180: Add support for bma023

2020-05-14 Thread Jonathan Bakker
support is not added for it. Reviewed-by: Linus Walleij Signed-off-by: Jonathan Bakker --- Changes from v1 - Added R-b tag --- drivers/iio/accel/Kconfig | 6 +- drivers/iio/accel/bma180.c | 123 +++-- 2 files changed, 122 insertions(+), 7 deletions(-) diff

[PATCH v2 3/7] dt-bindings: iio: accel: Add bma150 family compatibles to bma180

2020-05-14 Thread Jonathan Bakker
The bma023, bma150, and smb380 are in the same family as the bma180 and support is being added to the bma180 IIO driver for them. Reviewed-by: Linus Walleij Signed-off-by: Jonathan Bakker --- Changes from v1 - Added bma150 and smb380 compatibles - Added R-b tag --- Documentation/devicetree

[PATCH v2 6/7] iio: accel: bma180: Rename center_temp to temp_offset

2020-05-14 Thread Jonathan Bakker
The bma180 driver is being extended to support the bma150. Its temperature channel is unsigned so the center_temp naming no longer makes. Signed-off-by: Jonathan Bakker --- drivers/iio/accel/bma180.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/iio

Re: [PATCH] tty: serial: samsung: Correct clock selection logic

2020-05-11 Thread Jonathan Bakker
Hi Krzysztof, On 2020-05-11 3:08 a.m., Krzysztof Kozlowski wrote: > On Fri, May 08, 2020 at 06:34:33PM -0700, Jonathan Bakker wrote: >> Some variants of the samsung tty driver can pick which clock >> to use for their baud rate generation. In the DT conversion, >> a default

Re: [PATCH 3/3] power: supply: max17040: Set rcomp value

2020-05-10 Thread Jonathan Bakker
Hi Sebastian, On 2020-05-10 1:08 p.m., Sebastian Reichel wrote: > Hi, > > On Mon, May 04, 2020 at 03:13:00PM -0700, Jonathan Bakker wrote: >> According to the datasheet (1), the rcomp parameter can >> vary based on the typical operating temperature and the >> batt

[PATCH v2] iio: light: gp2ap002: Take runtime PM reference on light read

2020-05-10 Thread Jonathan Bakker
: 97d642e23037 ("iio: light: Add a driver for Sharp GP2AP002x00F") Signed-off-by: Jonathan Bakker --- Changes from v1: - Add Fixes tag --- drivers/iio/light/gp2ap002.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/drivers/iio/light/gp2ap002.c b/d

[PATCH] drm/exynos: fimc: Add support for S5PV210 variant

2020-05-09 Thread Jonathan Bakker
x27;t even need to change the device id check. It has been tested with a modified libdrm's test from https://github.com/tobiasjakobi/libdrm/tree/ippv2 Signed-off-by: Jonathan Bakker --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 13 - 1 file changed, 12 insertions(+), 1 delet

Re: [PATCH] phy: samsung: s5pv210-usb2: Add delay after reset

2020-05-08 Thread Jonathan Bakker
Hi Kishon, Is there anything else you (or someone else) needs from me? I'd really appreciate getting USB working again on s5pv210 as without this patch it is entirely broken. Thanks, Jonathan On 2020-04-28 2:50 p.m., Jonathan Bakker wrote: > Hi Kishon, > > On 2020-04-27 5:4

[PATCH] iio: light: gp2ap002: Take runtime PM reference on light read

2020-05-08 Thread Jonathan Bakker
-off-by: Jonathan Bakker --- drivers/iio/light/gp2ap002.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/drivers/iio/light/gp2ap002.c b/drivers/iio/light/gp2ap002.c index b7ef16b28280..7a2679bdc987 100644 --- a/drivers/iio/light/gp2ap002.c +++ b/drivers/iio

[PATCH] tty: serial: samsung: Correct clock selection logic

2020-05-08 Thread Jonathan Bakker
n was implemented in such a way that only the default clock was ever actually compared. Fix this by iterating through all possible clocks, except when a specific clock has already been picked via clk_sel (which is only possible via board files). Signed-off-by: Jonathan Bakker --- drivers/tty/s

[PATCH] iio: adc: Add scaling support to exynos adc driver

2020-05-08 Thread Jonathan Bakker
for all mainline dts and cross referenced with the public Exynos4412 and S5PV210 datasheets. Signed-off-by: Jonathan Bakker --- drivers/iio/adc/exynos_adc.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc

Re: [PATCH 2/5] input: misc: bma150: Conditionally disable bma023 support

2020-05-08 Thread Jonathan Bakker
H Dmitry, On 2020-05-06 9:23 p.m., Dmitry Torokhov wrote: > On Wed, May 06, 2020 at 08:46:12PM -0700, Jonathan Bakker wrote: >> Hi Linus, >> >> On 2020-05-06 5:46 a.m., Linus Walleij wrote: >>> On Sun, May 3, 2020 at 7:22 PM Jonathan Bakker wrote: >>> >&

Re: [PATCH 0/5] iio: accel: Add bma023 support to bma180

2020-05-06 Thread Jonathan Bakker
Hi Linus, On 2020-05-06 5:47 a.m., Linus Walleij wrote: > On Sun, May 3, 2020 at 7:22 PM Jonathan Bakker wrote: > >> This patchset adds support for the bma023 three axis accelerometer >> to the bma180 IIO driver. The bma023 is found on several ~2010 >> phones, includin

Re: [PATCH 2/5] input: misc: bma150: Conditionally disable bma023 support

2020-05-06 Thread Jonathan Bakker
Hi Linus, On 2020-05-06 5:46 a.m., Linus Walleij wrote: > On Sun, May 3, 2020 at 7:22 PM Jonathan Bakker wrote: > >> The bma180 IIO driver has been extended for support for bma023. >> However, this could cause conflicts with this driver. Since some >> setups may dep

[PATCH 2/3] dt-bindings: power: supply: Document maxim,rcomp-value for max17040

2020-05-04 Thread Jonathan Bakker
The rcomp value is a device-specific value for configuration based on specific chemistries. There is no public documentation on how to tune it. Signed-off-by: Jonathan Bakker --- .../devicetree/bindings/power/supply/max17040_battery.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 1/3] power: supply: max17040: Correct voltage reading

2020-05-04 Thread Jonathan Bakker
-MAX17041.pdf Signed-off-by: Jonathan Bakker --- drivers/power/supply/max17040_battery.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/max17040_battery.c b/drivers/power/supply/max17040_battery.c index 8a1f0ee493aa..48aa44665e2f 100644 --- a/drivers/power

[PATCH 3/3] power: supply: max17040: Set rcomp value

2020-05-04 Thread Jonathan Bakker
According to the datasheet (1), the rcomp parameter can vary based on the typical operating temperature and the battery chemistry. If provided, make sure we set it after we reset the chip on boot. 1) https://datasheets.maximintegrated.com/en/ds/MAX17040-MAX17041.pdf Signed-off-by: Jonathan

[PATCH 0/3] power: supply: Improve max17040 support

2020-05-04 Thread Jonathan Bakker
This patchset does two things: 1) Corrects the voltage reading from the max17040, which was missing the shift and scaling. 2) Adds the ability to the set the rcomp, which is used to optimize performance for specific battery chemistries and/or workloads. Jonathan Bakker (3): power: supply

[PATCH 5/5] iio: accel: bma180: Add support for bma023

2020-05-03 Thread Jonathan Bakker
support is not added for it. Signed-off-by: Jonathan Bakker --- drivers/iio/accel/Kconfig | 6 +- drivers/iio/accel/bma180.c | 123 +++-- 2 files changed, 122 insertions(+), 7 deletions(-) diff --git a/drivers/iio/accel/Kconfig b/drivers/iio/accel/Kconfig index

[PATCH 3/5] dt-bindings: iio: accel: Add bma023 compatible to bma180

2020-05-03 Thread Jonathan Bakker
The bma023 is in the same family as the bma180 and support is being added to the bma180 IIO driver for it. Signed-off-by: Jonathan Bakker --- Documentation/devicetree/bindings/iio/accel/bma180.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree

[PATCH 1/5] iio: accel: bma180: Prepare for different reset values

2020-05-03 Thread Jonathan Bakker
Some variants of the bma180 (eg bma023) have different reset values. In preparation for adding support for them, factor out the reset value into the chip specific data. Signed-off-by: Jonathan Bakker --- drivers/iio/accel/bma180.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions

[PATCH 2/5] input: misc: bma150: Conditionally disable bma023 support

2020-05-03 Thread Jonathan Bakker
The bma180 IIO driver has been extended for support for bma023. However, this could cause conflicts with this driver. Since some setups may depend upon the evdev setup, disable support in this driver for the bma023 only when the IIO driver is being built. Signed-off-by: Jonathan Bakker

[PATCH 0/5] iio: accel: Add bma023 support to bma180

2020-05-03 Thread Jonathan Bakker
the dt binding doc was missing the regulators, so I've added those in. The patches have been tested on a GT-i9000. The interrupt pin is not connected on this board so the trigger was not tested. Jonathan Bakker (5): iio: accel: bma180: Prepare for different reset values input: misc: b

[PATCH 4/5] dt-bindings: iio: accel: Add required regulators to bma180

2020-05-03 Thread Jonathan Bakker
The bma180 and related chips should have two registers attached to them. The IIO driver currently uses them, document them here as well. Signed-off-by: Jonathan Bakker --- Documentation/devicetree/bindings/iio/accel/bma180.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation

[PATCH v2 03/18] ARM: dts: s5pv210: Add sleep GPIO configuration for galaxys

2020-05-01 Thread Jonathan Bakker
In order to minimize leakage current during sleep, set a config for sleep GPIOs. Signed-off-by: Jonathan Bakker --- Changes from v1 - Note where sleep GPIOs came from --- arch/arm/boot/dts/s5pv210-galaxys.dts | 241 ++ 1 file changed, 241 insertions(+) diff --git a

[PATCH v2 11/18] ARM: dts: s5pv210: Add si470x fmradio to galaxys

2020-05-01 Thread Jonathan Bakker
From: Paweł Chmiel Add support for the Silicon Labs si4709 fmradio, which can be found on Galaxy S GT-i9000 (but not most other aries variants). Signed-off-by: Paweł Chmiel Signed-off-by: Jonathan Bakker --- arch/arm/boot/dts/s5pv210-aries.dtsi | 2 +- arch/arm/boot/dts/s5pv210-galaxys.dts

[PATCH v2 06/18] ARM: dts: s5pv210: Add WM8994 support to aries boards

2020-05-01 Thread Jonathan Bakker
Aries boards have a Wolfson WM8994 sound card attached over gpio-i2c. There is currently no ASoC Machine Driver. Signed-off-by: Jonathan Bakker --- arch/arm/boot/dts/s5pv210-aries.dtsi | 65 ++- arch/arm/boot/dts/s5pv210-fascinate4g.dts | 6 +++ 2 files changed, 69

[PATCH v2 14/18] ARM: dts: s5pv210: Enable ADC on aries boards

2020-05-01 Thread Jonathan Bakker
On aries boards, the ADC is used for things such as jack detection and battery temperature monitoring. It is connected to ldo4 of max8998, so only enable that regulator when we are actually using the ADC. Signed-off-by: Jonathan Bakker --- Changes from v1 - Replace removed regulator-off-in

[PATCH v2 05/18] ARM: dts: s5pv210: Disable pulls on GPIO i2c adapters for aries

2020-05-01 Thread Jonathan Bakker
The bitbanged GPIO i2c adapters have external pull-ups attached so the internal pulls should be disabled for lower power usage. Signed-off-by: Jonathan Bakker --- arch/arm/boot/dts/s5pv210-aries.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts

[PATCH v2 13/18] ARM: dts: s5pv210: Add an ADC node

2020-05-01 Thread Jonathan Bakker
The exynos-adc driver now supports the S5PV210, so add the DT node so that devices can use it. Signed-off-by: Jonathan Bakker --- Changes from v1 - Adjust node name to match reg address --- arch/arm/boot/dts/s5pv210.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch

[PATCH v2 12/18] ARM: dts: s5pv210: Disable pull for vibrator ena GPIO on aries

2020-05-01 Thread Jonathan Bakker
The enable GPIO for the fixed vibrator regulator shouldn't be pulled in one direction or the other. Signed-off-by: Jonathan Bakker --- arch/arm/boot/dts/s5pv210-aries.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boo

  1   2   >