Re: [PATCH v3] remoteproc: imx_dsp_rproc: Add support of recovery and coredump process

2025-07-29 Thread Iuliana Prodan
On 7/29/2025 4:33 AM, Shengjiu Wang wrote: On Mon, Jul 28, 2025 at 11:09 PM Iuliana Prodan wrote: On 7/28/2025 5:14 PM, Mathieu Poirier wrote: On Mon, Jul 28, 2025 at 01:39:38PM +0300, Daniel Baluta wrote: On Tue, Jul 22, 2025 at 11:16 AM Shengjiu Wang wrote: When enabled FW recovery

Re: [PATCH v3] remoteproc: imx_dsp_rproc: Add support of recovery and coredump process

2025-07-28 Thread Iuliana Prodan
6.17-rc2 when I get back from vacation. Mathieu [1] https://github.com/zephyrproject-rtos/zephyr/tree/main/samples/subsys/ipc/openamp_rsc_tableFrom 47786070f1ffbd73f4ff0009e2dbddc79d607e86 Mon Sep 17 00:00:00 2001 From: Iuliana Prodan Date: Mon, 28 Jul 2025 15:21:24 +0300 Subject: [PATCH 4/4] ma

Re: [PATCH v2 1/2] remoteproc: imx_dsp_rproc: Add support of recovery process

2025-07-11 Thread Iuliana Prodan
Hello Mathieu, Shengjiu, On 7/10/2025 5:48 PM, Mathieu Poirier wrote: On Fri, Jul 04, 2025 at 01:25:28PM +0800, Shengjiu Wang wrote: When recovery is triggered, rproc_stop() is called first then rproc_start(), but there is no rproc_unprepare_device() and rproc_prepare_device() in the flow. As t

Re: [PATCH v2 0/4] of: Common "memory-region" parsing

2025-04-28 Thread Iuliana Prodan
On 4/28/2025 3:23 PM, Rob Herring wrote: On Fri, Apr 25, 2025 at 6:34 PM Iuliana Prodan wrote: Hello Mathieu, Rob, I've tested imx_dsp_rproc and it fails with: [ 39.743770] Unable to handle kernel paging request at virtual address ffea ... [ 39.805078] Hardware name

Re: [PATCH v2 0/4] of: Common "memory-region" parsing

2025-04-25 Thread Iuliana Prodan
Hello Mathieu, Rob, I've tested imx_dsp_rproc and it fails with: [   39.743770] Unable to handle kernel paging request at virtual address ffea ... [   39.805078] Hardware name: NXP i.MX8MPlus EVK board (DT) [   39.810390] pstate: 0005 (nzcv daif -PAN -UAO -TCO -DIT -SSBS BTYPE

[PATCH v5] remoteproc: imx_dsp_rproc: Add support for DSP-specific features

2025-04-16 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Some DSP firmware requires a FW_READY signal before proceeding, while others do not. Therefore, add support to handle i.MX DSP-specific features. Implement handle_rsc callback to handle resource table parsing and to process DSP-specific resource, to determine if waiting is

Re: [PATCH v4] remoteproc: imx_dsp_rproc: Add support for DSP-specific features

2025-04-15 Thread Iuliana Prodan
On 4/14/2025 6:41 PM, Mathieu Poirier wrote: On Thu, Apr 10, 2025 at 12:30:30AM +0300, Iuliana Prodan (OSS) wrote: From: Iuliana Prodan Some DSP firmware requires a FW_READY signal before proceeding, while others do not. Therefore, add support to handle i.MX DSP-specific features. Implement

[PATCH v4] remoteproc: imx_dsp_rproc: Add support for DSP-specific features

2025-04-09 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Some DSP firmware requires a FW_READY signal before proceeding, while others do not. Therefore, add support to handle i.MX DSP-specific features. Implement handle_rsc callback to handle resource table parsing and to process DSP-specific resource, to determine if waiting is

Re: [PATCH v3] remoteproc: imx_dsp_rproc: Add support for DSP-specific features

2025-04-08 Thread Iuliana Prodan
On 4/8/2025 4:46 PM, Mathieu Poirier wrote: On Tue, 8 Apr 2025 at 02:47, Iuliana Prodan wrote: Hello Mathieu, On 4/7/2025 7:17 PM, Mathieu Poirier wrote: Good morning, On Thu, Apr 03, 2025 at 01:01:24PM +0300, Iuliana Prodan (OSS) wrote: From: Iuliana Prodan Some DSP firmware requires a

Re: [PATCH v3] remoteproc: imx_dsp_rproc: Add support for DSP-specific features

2025-04-08 Thread Iuliana Prodan
Hello Mathieu, On 4/7/2025 7:17 PM, Mathieu Poirier wrote: Good morning, On Thu, Apr 03, 2025 at 01:01:24PM +0300, Iuliana Prodan (OSS) wrote: From: Iuliana Prodan Some DSP firmware requires a FW_READY signal before proceeding, while others do not. Therefore, add support to handle i.MX DSP

Re: [PATCH v3] remoteproc: imx_dsp_rproc: Add support for DSP-specific features

2025-04-07 Thread Iuliana Prodan
Hi Frank, On 4/3/2025 10:12 PM, Frank Li wrote: On Thu, Apr 03, 2025 at 01:01:24PM +0300, Iuliana Prodan (OSS) wrote: From: Iuliana Prodan subject: remoteproc: imx_dsp_rproc: add handle_rsc callback to handle DSP-specific features Some DSP firmware requires a FW_READY signal before

[PATCH v3] remoteproc: imx_dsp_rproc: Add support for DSP-specific features

2025-04-03 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Some DSP firmware requires a FW_READY signal before proceeding, while others do not. Therefore, add support to handle i.MX DSP-specific features. Implement handle_rsc callback to handle resource table parsing and to process DSP-specific resource, to determine if waiting is

[PATCH v2] remoteproc: imx_dsp_rproc: Add support for DSP-specific features

2025-03-18 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Some DSP firmware requires a FW_READY signal before proceeding, while others do not. Therefore, add support to handle i.MX DSP-specific features. Implement handle_rsc callback to handle resource table parsing and to process DSP-specific resource, to determine if waiting is

[PATCH] remoteproc: imx_dsp_rproc: conditionally wait for FW_READY

2025-03-05 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Some DSP firmware requires a FW_READY signal before proceeding, while others do not. Introduce imx_dsp_rproc_wait_fw_ready() to check the resource table and determine if waiting is needed. Use the WAIT_FW_READY flag (bit 1) to distinguish cases where waiting is required, as

Re: [PATCH 2/6] remoteproc: imx_rproc: use imx specific hook for find_loaded_rsc_table

2024-07-19 Thread Iuliana Prodan
table address specified in elf file or in device tree. But to reflect the fact that if people specific resource table address in device tree, it means people are aware and going to use it, not the address specified in elf file. Signed-off-by: Peng Fan Reviewed-by: Iuliana Prodan Thanks, Iulia

Re: [PATCH 4/6] remoteproc: imx_rproc: merge TCML/U

2024-07-18 Thread Iuliana Prodan
On 7/12/2024 11:34 AM, Peng Fan (OSS) wrote: From: Peng Fan Merge contiguous TCML/U regions into one to avoid load elf files which has large sections failure. Signed-off-by: Peng Fan --- Reviewed-by: Iuliana Prodan Thanks, Iulia drivers/remoteproc/imx_rproc.c | 18

Re: [PATCH 2/9] remoteproc: imx_rproc: Use devm_rproc_alloc() helper

2024-01-24 Thread Iuliana Prodan
On 1/23/2024 8:46 PM, Andrew Davis wrote: Use the device lifecycle managed allocation function. This helps prevent mistakes like freeing out of order in cleanup functions and forgetting to free on error paths. Signed-off-by: Andrew Davis Reviewed-by: Iuliana Prodan Thanks, Iulia

Re: [PATCH 1/9] remoteproc: imx_dsp_rproc: Use devm_rproc_alloc() helper

2024-01-24 Thread Iuliana Prodan
On 1/23/2024 8:46 PM, Andrew Davis wrote: Use the device lifecycle managed allocation function. This helps prevent mistakes like freeing out of order in cleanup functions and forgetting to free on error paths. Signed-off-by: Andrew Davis Reviewed-by: Iuliana Prodan Thanks, Iulia

Re: [PATCH v2 3/5] remoteproc: imx_rproc: Convert to dev_pm_domain_attach|detach_list()

2024-01-22 Thread Iuliana Prodan
On 1/5/2024 6:01 PM, Ulf Hansson wrote: Let's avoid the boilerplate code to manage the multiple PM domain case, by converting into using dev_pm_domain_attach|detach_list(). Cc: Mathieu Poirier Cc: Bjorn Andersson Cc: Shawn Guo Cc: Sascha Hauer Cc: Iuliana Prodan Cc: Daniel Balut

Re: [PATCH v2 2/5] remoteproc: imx_dsp_rproc: Convert to dev_pm_domain_attach|detach_list()

2024-01-22 Thread Iuliana Prodan
On 1/5/2024 6:01 PM, Ulf Hansson wrote: Let's avoid the boilerplate code to manage the multiple PM domain case, by converting into using dev_pm_domain_attach|detach_list(). Cc: Mathieu Poirier Cc: Bjorn Andersson Cc: Shawn Guo Cc: Sascha Hauer Cc: Iuliana Prodan Cc: Daniel Balut

[PATCH v4 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

2023-10-13 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Add the reserve-memory nodes used by DSP when the rpmsg feature is enabled. Signed-off-by: Iuliana Prodan --- arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 22 1 file changed, 22 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mp

[PATCH v4 1/2] remoteproc: imx_dsp_rproc: add mandatory find_loaded_rsc_table op

2023-10-13 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Add the .find_loaded_rsc_table operation for i.MX DSP. We need it for inter-process communication between DSP and main core. This callback is used to find the resource table (defined in remote processor linker script) where the address of the vrings along with the other

[PATCH v4 0/2] Rpmsg support for i.MX DSP with resource table

2023-10-13 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan These patches are needed in order to support rpmsg on DSP when a resource table is available. Changes since v3: - add reserve-memory nodes in imx8mp-evk.dts rather than .dtsi (patch 2/2) Changes since v2: - add newline between nodes in dtsi (patch 2/2) Changes since v1

Re: [PATCH v3 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

2023-10-13 Thread Iuliana Prodan
Hi Alexander, On 10/11/2023 8:37 AM, Alexander Stein wrote: Hi Iuliana, Am Dienstag, 10. Oktober 2023, 11:09:29 CEST schrieb Iuliana Prodan (OSS): From: Iuliana Prodan Add the reserve-memory nodes used by DSP when the rpmsg feature is enabled. Signed-off-by: Iuliana Prodan --- arch

[PATCH v3 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

2023-10-10 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Add the reserve-memory nodes used by DSP when the rpmsg feature is enabled. Signed-off-by: Iuliana Prodan --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch

[PATCH v3 1/2] remoteproc: imx_dsp_rproc: add mandatory find_loaded_rsc_table op

2023-10-10 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Add the .find_loaded_rsc_table operation for i.MX DSP. We need it for inter-process communication between DSP and main core. This callback is used to find the resource table (defined in remote processor linker script) where the address of the vrings along with the other

[PATCH v3 0/2] Rpmsg support for i.MX DSP with resource table

2023-10-10 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan These patches are needed in order to support rpmsg on DSP when a resource table is available. Changes since v2: - add newline between nodes in dtsi (patch 2/2) Changes since v1: - add missing bracket in dtsi (patch 2/2) Iuliana Prodan (2): remoteproc: imx_dsp_rproc

[PATCH v2 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

2023-09-12 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Add the reserve-memory nodes used by DSP when the rpmsg feature is enabled. Signed-off-by: Iuliana Prodan --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch

[PATCH v2 1/2] remoteproc: imx_dsp_rproc: add mandatory find_loaded_rsc_table op

2023-09-12 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Add the .find_loaded_rsc_table operation for i.MX DSP. We need it for inter-process communication between DSP and main core. This callback is used to find the resource table (defined in remote processor linker script) where the address of the vrings along with the other

[PATCH v2 0/2] Rpmsg support for i.MX DSP with resource table

2023-09-12 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan These patches are needed in order to support rpmsg on DSP when a resource table is available. Changes since v1: - add missing bracket in dtsi (patch 2/2) Iuliana Prodan (2): remoteproc: imx_dsp_rproc: add mandatory find_loaded_rsc_table op arm64: dts: imx8mp: add

Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

2023-09-12 Thread Iuliana Prodan
On 9/12/2023 2:30 PM, Marco Felsch wrote: Hi Iuliana, On 23-09-12, Iuliana Prodan (OSS) wrote: From: Iuliana Prodan Add the reserve-memory nodes used by DSP when the rpmsg feature is enabled. These can be later used in a dsp node, like: dsp: dsp@3b6e8000 { compatible = "fsl,i

Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

2023-09-12 Thread Iuliana Prodan
On 9/12/2023 12:36 PM, Krzysztof Kozlowski wrote: On 12/09/2023 10:49, Iuliana Prodan wrote: Should I test this on other tree(s)? You test the patch on the tree you send it. What is the point to test it on some old code, cherry-pick with bugs and then send? If you have cross-tree dependencies

Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

2023-09-12 Thread Iuliana Prodan
On 9/12/2023 11:26 AM, Krzysztof Kozlowski wrote: On 12/09/2023 10:13, Iuliana Prodan wrote: On 9/12/2023 10:07 AM, Krzysztof Kozlowski wrote: On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote: From: Iuliana Prodan Add the reserve-memory nodes used by DSP when the rpmsg feature is enabled

Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

2023-09-12 Thread Iuliana Prodan
On 9/12/2023 10:07 AM, Krzysztof Kozlowski wrote: On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote: From: Iuliana Prodan Add the reserve-memory nodes used by DSP when the rpmsg feature is enabled. These can be later used in a dsp node, like: dsp: dsp@3b6e8000 { compatible = "fsl,i

[PATCH 1/2] remoteproc: imx_dsp_rproc: add mandatory find_loaded_rsc_table op

2023-09-11 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Add the .find_loaded_rsc_table operation for i.MX DSP. We need it for inter-process communication between DSP and main core. This callback is used to find the resource table (defined in remote processor linker script) where the address of the vrings along with the other

[PATCH 0/2] Rpmsg support for i.MX DSP with resource table

2023-09-11 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan These patches are needed in order to support rpmsg on DSP when a resource table is available. Iuliana Prodan (2): remoteproc: imx_dsp_rproc: add mandatory find_loaded_rsc_table op arm64: dts: imx8mp: add reserve-memory nodes for DSP arch/arm64/boot/dts/freescale

[PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

2023-09-11 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Add the reserve-memory nodes used by DSP when the rpmsg feature is enabled. These can be later used in a dsp node, like: dsp: dsp@3b6e8000 { compatible = "fsl,imx8mp-dsp"; reg = <0x3b6e8000 0x88000>; mbox-names = "tx0", &quo

[PATCH 5/5] crypto: caam/qi2 - avoid allocating memory at crypto request runtime

2020-12-02 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Remove CRYPTO_ALG_ALLOCATES_MEMORY flag and allocate the memory needed by the driver, to fulfil a request, within the crypto request object. The extra size needed for base extended descriptor, hw descriptor commands and link tables is computed in frontend driver (caamalg_qi2

[PATCH 4/5] crypto: caam/qi - avoid allocating memory at crypto request runtime

2020-12-02 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Remove CRYPTO_ALG_ALLOCATES_MEMORY flag and allocate the memory needed by the driver, to fulfil a request, within the crypto request object. The extra size needed for base extended descriptor, hw descriptor commands and link tables is computed in frontend driver (caamalg_qi

[PATCH 3/5] crypto: caam/jr - avoid allocating memory at crypto request runtime fost hash

2020-12-02 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Remove CRYPTO_ALG_ALLOCATES_MEMORY flag and allocate the memory needed by the driver, to fulfil a request, within the crypto request object. The extra size needed for base extended descriptor and link tables is computed in frontend driver (caamhash) initialization and saved

[PATCH 2/5] crypto: caam/jr - avoid allocating memory at crypto request runtime for aead

2020-12-02 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Remove CRYPTO_ALG_ALLOCATES_MEMORY flag and allocate the memory needed by the driver, to fulfil a request, within the crypto request object. The extra size needed for base extended descriptor, hw descriptor commands and link tables is computed in frontend driver (caamalg

[PATCH 1/5] crypto: caam/jr - avoid allocating memory at crypto request runtime for skcipher

2020-12-02 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Remove CRYPTO_ALG_ALLOCATES_MEMORY flag and allocate the memory needed by the driver, to fulfil a request, within the crypto request object. The extra size needed for base extended descriptor and hw descriptor commands, link tables, IV is computed in frontend driver (caamalg

[PATCH 0/5] crypto: caam - avoid allocating memory at crypto request runtime

2020-12-02 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan This series removes CRYPTO_ALG_ALLOCATES_MEMORY flag and allocates the memory needed by the driver, to fulfil a request, within the crypto request object. The extra size needed for base extended descriptor, hw descriptor commands and link tables is added to the reqsize field

Re: [RFC PATCH 0/4] crypto: add CRYPTO_TFM_REQ_DMA flag

2020-11-26 Thread Iuliana Prodan
On 11/26/2020 7:12 PM, Ard Biesheuvel wrote: On Thu, 26 Nov 2020 at 17:00, Iuliana Prodan wrote: On 11/26/2020 9:09 AM, Ard Biesheuvel wrote: On Wed, 25 Nov 2020 at 22:39, Iuliana Prodan wrote: On 11/25/2020 11:16 PM, Ard Biesheuvel wrote: On Wed, 25 Nov 2020 at 22:14, Iuliana Prodan

Re: [RFC PATCH 0/4] crypto: add CRYPTO_TFM_REQ_DMA flag

2020-11-26 Thread Iuliana Prodan
On 11/26/2020 9:09 AM, Ard Biesheuvel wrote: On Wed, 25 Nov 2020 at 22:39, Iuliana Prodan wrote: On 11/25/2020 11:16 PM, Ard Biesheuvel wrote: On Wed, 25 Nov 2020 at 22:14, Iuliana Prodan (OSS) wrote: From: Iuliana Prodan Add the option to allocate the crypto request object plus any

Re: [RFC PATCH 0/4] crypto: add CRYPTO_TFM_REQ_DMA flag

2020-11-25 Thread Iuliana Prodan
On 11/25/2020 11:16 PM, Ard Biesheuvel wrote: On Wed, 25 Nov 2020 at 22:14, Iuliana Prodan (OSS) wrote: From: Iuliana Prodan Add the option to allocate the crypto request object plus any extra space needed by the driver into a DMA-able memory. Add CRYPTO_TFM_REQ_DMA flag to be used by

[RFC PATCH 4/4] crypto: caam - avoid allocating memory at crypto request runtime for aead

2020-11-25 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Remove CRYPTO_ALG_ALLOCATES_MEMORY flag and allocate the memory needed by the driver, to fulfil a request, within the crypto request object. The extra size needed for base extended descriptor, hw descriptor commands and link tables is computed in frontend driver (caamalg

[RFC PATCH 3/4] crypto: caam - avoid allocating memory at crypto request runtime for skcipher

2020-11-25 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Remove CRYPTO_ALG_ALLOCATES_MEMORY flag and allocate the memory needed by the driver, to fulfil a request, within the crypto request object. The extra size needed for base extended descriptor and hw descriptor commands, link tables, IV is computed in frontend driver (caamalg

[RFC PATCH 2/4] net: esp: check CRYPTO_TFM_REQ_DMA flag when allocating crypto request

2020-11-25 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Some crypto backends might require the requests' private contexts to be allocated in DMA-able memory. Signed-off-by: Horia Geanta --- net/ipv4/esp4.c | 7 ++- net/ipv6/esp6.c | 7 ++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/net/ipv4/e

[RFC PATCH 1/4] crypto: add CRYPTO_TFM_REQ_DMA flag

2020-11-25 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan The CRYPTO_TFM_REQ_DMA flag can be used by backend implementations to indicate to crypto API the need to allocate GFP_DMA memory for private contexts of the crypto requests. For public key encryption add the needed functions to set/get/clear flags. Signed-off-by: Horia

[RFC PATCH 0/4] crypto: add CRYPTO_TFM_REQ_DMA flag

2020-11-25 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Add the option to allocate the crypto request object plus any extra space needed by the driver into a DMA-able memory. Add CRYPTO_TFM_REQ_DMA flag to be used by backend implementations to indicate to crypto API the need to allocate GFP_DMA memory for private contexts of the

Re: [PATCH] crypto: caam - fix printing on xts fallback allocation error path

2020-11-02 Thread Iuliana Prodan
han 8B IV") Signed-off-by: Horia Geantă Reviewed-by: Iuliana Prodan --- drivers/crypto/caam/caamalg.c | 4 ++-- drivers/crypto/caam/caamalg_qi.c | 4 ++-- drivers/crypto/caam/caamalg_qi2.c | 3 ++- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/caam/ca

[PATCH v2] crypto: caam - enable crypto-engine retry mechanism

2020-10-26 Thread Iuliana Prodan
-engine). The callback for do_batch_requests is NULL, since CAAM doesn't support linked requests. Signed-off-by: Iuliana Prodan --- Changes since v1: - add comment for THRESHOLD define; - update max size for crypto-engine queue. drivers/crypto/caam/intern.h | 8 drivers/crypto/caam

Re: [PATCH] crypto: caam - enable crypto-engine retry mechanism

2020-10-26 Thread Iuliana Prodan
On 10/26/2020 5:36 PM, Horia Geantă wrote: On 10/21/2020 11:07 PM, Iuliana Prodan wrote: Use the new crypto_engine_alloc_init_and_set() function to initialize crypto-engine and enable retry mechanism. Set the maximum size for crypto-engine software queue based on Job Ring size (JOBR_DEPTH) and

[PATCH] crypto: caam - enable crypto-engine retry mechanism

2020-10-21 Thread Iuliana Prodan
-engine). The callback for do_batch_requests is NULL, since CAAM doesn't support linked requests. Signed-off-by: Iuliana Prodan --- drivers/crypto/caam/intern.h | 3 +++ drivers/crypto/caam/jr.c | 6 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/caam/int

Re: [PATCH v2 1/4] crypto: caam - Fix kerneldoc

2020-09-11 Thread Iuliana Prodan
e: 'struct caam_hash_ctx' drivers/crypto/caam/ctrl.c:449: warning: Function parameter or member 'ctrl' not described in 'caam_get_era' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Iuliana Prodan --- Changes since v1: 1. Fix more warnings --- drivers/crypto/caa

Re: [PATCH 1/4] crypto: caam - Fix kerneldoc

2020-09-03 Thread Iuliana Prodan
On 9/2/2020 6:05 PM, Krzysztof Kozlowski wrote: Fix kerneldoc warnings: drivers/crypto/caam/caamalg_qi2.c:73: warning: cannot understand function prototype: 'struct caam_ctx ' drivers/crypto/caam/caamalg_qi2.c:2962: warning: cannot understand function prototype: 'struct caam_hash_ctx '

Re: [PATCH 2/4] crypto: caam - Simplify with dev_err_probe()

2020-09-03 Thread Iuliana Prodan
On 9/2/2020 6:05 PM, Krzysztof Kozlowski wrote: Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Iuliana Prodan --- drivers/crypto/caam/caamalg_qi2.c | 3 +-- 1

[PATCH 2/2] crypto: caam - support tagged keys for skcipher algorithms

2020-07-12 Thread Iuliana Prodan
, e.g. using dmsetup: dmsetup -v create encrypted --table "0 $(blockdev --getsz /dev/mmcblk2p10) crypt capi:tk(cbc(aes))-plain :32:logon:seckey 0 /dev/mmcblk2p10 0 1 sector_size:512". Signed-off-by: Franck LENORMAND Signed-off-by: Iuliana Prodan --- drivers/cr

[PATCH 0/2] crypto: caam - add tagged keys functionality and tk transformations for skcipher

2020-07-12 Thread Iuliana Prodan
ations will know how to handle tagged keys, by loading the proper settings for KEY command. Iuliana Prodan (2): crypto: caam - add tag object functionality crypto: caam - support tagged keys for skcipher algorithms drivers/crypto/caam/Kconfig| 9 +++ drivers/crypto/caam/Makefile

[PATCH 1/2] crypto: caam - add tag object functionality

2020-07-12 Thread Iuliana Prodan
configuration or tag object data. This API expects that the object (the actual data) from a tag object to be a buffer (defined by address and size). Signed-off-by: Franck LENORMAND Signed-off-by: Iuliana Prodan --- drivers/crypto/caam/Kconfig | 9 +++ drivers/crypto/caam/Makefile

Re: [PATCH V3] soc: imx8m: Correct i.MX8MP UID fuse offset

2020-06-10 Thread Iuliana Prodan
Signed-off-by: Anson Huang Reviewed-by: Iuliana Prodan --- Changes since V2: - add one more fix tag for original patch before file name is changed. --- drivers/soc/imx/soc-imx8m.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/soc/imx/soc-imx8m.c b

Re: [PATCH V2] soc: imx8m: Correct i.MX8MP UID fuse offset

2020-06-10 Thread Iuliana Prodan
On 6/10/2020 10:57 AM, Anson Huang wrote: Subject: RE: [PATCH V2] soc: imx8m: Correct i.MX8MP UID fuse offset From: Anson Huang Sent: Wednesday, June 10, 2020 6:42 AM Correct i.MX8MP UID fuse offset according to fuse map: UID_LOW: 0x420 UID_HIGH: 0x430 Fixes: fc40200ebf82 ("soc: imx: i

Re: [PATCH] soc: imx8m: Correct i.MX8MP UID fuse offset

2020-06-09 Thread Iuliana Prodan
On 6/9/2020 4:15 PM, Anson Huang wrote: Correct i.MX8MP UID fuse offset according to fuse map: UID_LOW: 0x420 UID_HIGH: 0x430 Signed-off-by: Anson Huang If this patch corrects the imx8mp UID shouldn't have a Fixes tag? --- drivers/soc/imx/soc-imx8m.c | 8 ++-- 1 file changed, 6 i

[PATCH] crypto: engine - do not requeue in case of fatal error

2020-05-19 Thread Iuliana Prodan
st be pass back and forth between crypto-engine and hardware. Fixes: 6a89f492f8e5 ("crypto: engine - support for parallel requests based on retry mechanism") Signed-off-by: Iuliana Prodan --- crypto/crypto_engine.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff

[PATCH v6 1/3] crypto: algapi - create function to add request in front of queue

2020-04-28 Thread Iuliana Prodan
Add crypto_enqueue_request_head function that enqueues a request in front of queue. This will be used in crypto-engine, on error path. In case a request was not executed by hardware, enqueue it back in front of queue (to keep the order of requests). Signed-off-by: Iuliana Prodan --- crypto

[PATCH v6 3/3] crypto: engine - support for batch requests

2020-04-28 Thread Iuliana Prodan
multiple request. Signed-off-by: Iuliana Prodan --- crypto/crypto_engine.c | 27 ++- include/crypto/engine.h | 5 + 2 files changed, 31 insertions(+), 1 deletion(-) diff --git a/crypto/crypto_engine.c b/crypto/crypto_engine.c index ee19273..412149e 100644 --- a

[PATCH v6 2/3] crypto: engine - support for parallel requests based on retry mechanism

2020-04-28 Thread Iuliana Prodan
e freed, since it will be enqueued back into crypto-engine's queue. When all drivers, that use crypto-engine now, will be updated for retry mechanism, the retry_support variable can be removed. Signed-off-by: Iuliana Prodan --- crypto/crypto_engine.c | 146 +++

[PATCH v6 0/3] crypto: engine - support for parallel and batch requests

2020-04-28 Thread Iuliana Prodan
o-engine is used). - added a new patch with support for batch requests. Changes since V0 (RFC): - removed max_no_req and no_req, as the number of request that can be processed in parallel; - added a new callback, can_enqueue_more, to check whether the hardware can process a new request. Iulian

Re: [PATCH] crypto: caam - fix use after free issue in *_crypt_done

2020-04-28 Thread Iuliana Prodan
On 4/28/2020 8:14 AM, Zhenzhong Duan wrote: > In both aead_crypt_done and skcipher_crypt_done, edesc->bklog is > referenced after the structure pointed by edesc is freed. > > Fix them by moving kfree(edesc) to the end of function call. > > Signed-off-by: Zhenzhong Duan These issues were already

[PATCH v5 11/14] crypto: caam - free resources in case caam_rng registration failed

2019-07-31 Thread Iuliana Prodan
Check the return value of the hardware registration for caam_rng and free resources in case of failure. Fixes: e24f7c9e87d4 ("crypto: caam - hwrng support") Signed-off-by: Iuliana Prodan Reviewed-by: Horia Geanta --- drivers/crypto/caam/caamrng.c | 5 - 1 file changed, 4 insert

[PATCH v5 13/14] crypto: caam - unregister algorithm only if the registration succeeded

2019-07-31 Thread Iuliana Prodan
aries") Signed-off-by: Iuliana Prodan Reviewed-by: Horia Geanta --- drivers/crypto/caam/caampkc.c | 49 ++- 1 file changed, 30 insertions(+), 19 deletions(-) diff --git a/drivers/crypto/caam/caampkc.c b/drivers/crypto/caam/caampkc.c index e00a470..5b12

[PATCH v4 02/14] crypto: caam - fix return code in completion callbacks

2019-07-30 Thread Iuliana Prodan
Note: in most error cases caam/qi and caam/qi2 returned -EIO; align all caam drivers to return -EINVAL. While here, ratelimit prints triggered by fuzz testing, such that console is not flooded. Signed-off-by: Horia Geantă Signed-off-by: Iuliana Prodan --- drivers/crypto/caam/caamalg.

[PATCH v4 05/14] crypto: caam - check authsize

2019-07-30 Thread Iuliana Prodan
Check authsize to solve the extra tests that expect -EINVAL to be returned when the authentication tag size is not valid. Validated authsize for GCM, RFC4106 and RFC4543. Signed-off-by: Iuliana Prodan Reviewed-by: Horia Geanta --- drivers/crypto/caam/caamalg.c | 13 + drivers

Re: [PATCH] crypto: gcm - fix cacheline sharing

2019-05-30 Thread Iuliana Prodan
On 5/30/2019 1:16 AM, Ard Biesheuvel wrote: > On Wed, 29 May 2019 at 22:27, Eric Biggers wrote: >> >> On Wed, May 29, 2019 at 08:10:56PM +0300, Iuliana Prodan wrote: >>> The generic GCM driver should ensure that whatever it passes into >>> scatterlists is safe fo

[PATCH v2 1/2] crypto: caam - fix pkcs1pad(rsa-caam, sha256) failure because of invalid input

2019-05-15 Thread Iuliana Prodan
with zeros until the modulus size is reached. Signed-off-by: Iuliana Prodan --- Changes since V1: - remove not needed initialization of a variable; - free resources on error path. --- drivers/crypto/caam/caampkc.c | 84 +++ drivers/crypto/caam

[PATCH v2 2/2] crypto: caam - strip input without changing crypto request

2019-05-15 Thread Iuliana Prodan
fixup input pointer and length. Signed-off-by: Iuliana Prodan --- Changes since V1: - changed the commit message and summary. --- drivers/crypto/caam/caampkc.c | 39 ++- drivers/crypto/caam/caampkc.h | 7 ++- 2 files changed, 32 insertions(+), 14

[PATCH 1/2] crypto: caam - fix pkcs1pad(rsa-caam, sha256) failure because of invalid input

2019-05-14 Thread Iuliana Prodan
with zeros until the modulus size is reached. Signed-off-by: Iuliana Prodan --- drivers/crypto/caam/caampkc.c | 84 +++ drivers/crypto/caam/caampkc.h | 2 ++ 2 files changed, 71 insertions(+), 15 deletions(-) diff --git a/drivers/crypto/caam/caampkc.c b

[PATCH] crypto: caam - fix copy of next buffer for xcbc and cmac

2019-03-22 Thread Iuliana Prodan
is: { .tap= { 17, 15, 8 }, .psize = 40, .np = 3, .ksize = 16, } Cc: Fixes: 12b8567f6fa4 ("crypto: caam - add support for xcbc(aes)") Signed-off-by: Iuliana Prodan --- drivers/crypto/caam/caamhash.c | 13 ++--- 1 file changed, 6 ins

[PATCH 1/4] crypto: caam - use mapped_{src,dst}_nents for job descriptor

2019-02-08 Thread Iuliana Prodan
The mapped_{src,dst}_nents _returned_ from the dma_map_sg call (which could be less than src/dst_nents) have to be used to generate the aead, skcipher job descriptors. Signed-off-by: Iuliana Prodan --- drivers/crypto/caam/caamalg.c | 27 --- 1 file changed, 20 insertions

[PATCH 2/4] crypto: export arc4 defines

2019-02-08 Thread Iuliana Prodan
Some arc4 cipher algorithm defines show up in two places: crypto/arc4.c and drivers/crypto/bcm/cipher.h. Let's export them in a common header and update their users. Signed-off-by: Iuliana Prodan --- crypto/arc4.c | 5 + drivers/crypto/bcm/cipher.h | 4 +--- include/c

[PATCH 0/4] crypto: caam - add ecb mode support

2019-02-08 Thread Iuliana Prodan
header -update cbc des and 3des to check for weak keys Iuliana Prodan (4): crypto: caam - use mapped_{src,dst}_nents for job descriptor crypto: export arc4 defines crypto: caam - add ecb(*) support crypto: caam - weak key checking for cbc des, 3des crypto/arc4.c | 5

[PATCH 3/4] crypto: caam - add ecb(*) support

2019-02-08 Thread Iuliana Prodan
Add ecb mode support for aes, des, 3des and arc4 ciphers. ecb(*) reuses existing skcipher implementation, updating it with support for no IV. Signed-off-by: Iuliana Prodan --- drivers/crypto/caam/Kconfig| 1 + drivers/crypto/caam/caamalg.c | 190

[PATCH 4/4] crypto: caam - weak key checking for cbc des, 3des

2019-02-08 Thread Iuliana Prodan
Modify setkey callback for cbc des and 3des to check for weak keys. Signed-off-by: Iuliana Prodan --- drivers/crypto/caam/caamalg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/caam/caamalg.c b/drivers/crypto/caam/caamalg.c index 90d83ae..9eac509 100644