On 4/28/2025 3:23 PM, Rob Herring wrote:
On Fri, Apr 25, 2025 at 6:34 PM Iuliana Prodan <iuliana.pro...@nxp.com> wrote:
Hello Mathieu, Rob,
I've tested imx_dsp_rproc and it fails with:
[ 39.743770] Unable to handle kernel paging request at virtual address
ffffffffffffffea
...
[ 39.805078] Hardware name: NXP i.MX8MPlus EVK board (DT)
[ 39.810390] pstate: 00000005 (nzcv daif -PAN -UAO -TCO -DIT -SSBS
BTYPE=--)
[ 39.817353] pc : __pi_memset_generic+0x50/0x188
[ 39.821892] lr : imx_dsp_rproc_prepare+0x3a4/0xea4 [imx_dsp_rproc]
[ 39.828079] sp : ffff8000853dbb10
[ 39.831396] x29: ffff8000853dbb90 x28: 0000000092400000 x27:
ffff80007a36d3d8
[ 39.838540] x26: ffff0000d0a5e410 x25: ffff80007a36d3f0 x24:
0000000000000004
[ 39.845685] x23: ffff0000d5414880 x22: ffff0000d5e1dce8 x21:
0000000000000000
[ 39.852827] x20: ffff0000d5e1db98 x19: ffff0000d5414b80 x18:
00000000ffffffff
[ 39.859970] x17: 202c656c69687720 x16: 3e2074756f657672 x15:
ffff800081f8d050
[ 39.867114] x14: ffff0000db584680 x13: 0000000000000003 x12:
00007fffa3330000
[ 39.874257] x11: 0000000000000004 x10: 0000000000000ab0 x9 :
0000000000000000
[ 39.881400] x8 : ffffffffffffffea x7 : 0000000000000000 x6 :
000000000000003f
[ 39.888546] x5 : 0000000000000040 x4 : 0000000000000006 x3 :
0000000000000004
[ 39.895689] x2 : 0000000000008000 x1 : 0000000000000000 x0 :
ffffffffffffffea
[ 39.902837] Call trace:
[ 39.905284] __pi_memset_generic+0x50/0x188 (P)
[ 39.909821] rproc_boot+0x2c0/0x524
[ 39.913317] state_store+0x40/0x100
[ 39.916812] dev_attr_store+0x18/0x2c
[ 39.920478] sysfs_kf_write+0x7c/0x94
[ 39.924146] kernfs_fop_write_iter+0x120/0x1e8
[ 39.928598] vfs_write+0x244/0x37c
[ 39.932008] ksys_write+0x70/0x110
[ 39.935413] __arm64_sys_write+0x1c/0x28
[ 39.939342] invoke_syscall+0x48/0x104
[ 39.943094] el0_svc_common.constprop.0+0xc0/0xe0
[ 39.947805] do_el0_svc+0x1c/0x28
[ 39.951123] el0_svc+0x30/0xcc
[ 39.954188] el0t_64_sync_handler+0x10c/0x138
[ 39.958549] el0t_64_sync+0x198/0x19c
[ 39.962222] Code: d65f03c0 cb0803e4 f2400c84 54000080 (a9001d07)
[ 39.968317] ---[ end trace 0000000000000000 ]---
The problem seems to be when computing `cpu_addr =
devm_ioremap_resource_wc(dev, &res);`, in patch 4.
In `__devm_ioremap_resource` (see [1]), it's expecting the resource type
to be `IORESOURCE_MEM`, which is not the case here (at least the flags
are nowhere set for this).
Thanks for testing and diagnosing. IORESOURCE_MEM needs to be set. Can
you test with this change:
index f87915cce961..00c93585758f 100644
--- a/drivers/of/of_reserved_mem.c
+++ b/drivers/of/of_reserved_mem.c
@@ -771,6 +771,7 @@ int of_reserved_mem_region_to_resource(const
struct device_node *np,
return -EINVAL;
resource_set_range(res, rmem->base, rmem->size);
+ res->flags = IORESOURCE_MEM;
res->name = rmem->name;
return 0;
}
I've tested with this change, and is all good now. Iulia
