Guangshuo Li wrote:
> Hi Alison, Dave, and all,
>
> Thanks for the feedback. I’ve adopted your suggestions. Below is what I
> plan to take in v3.
I would just post v3. The review tags given on that version will be
picked up when the patch is merged if it is ok.
Thanks,
Ira
[snip]
er.kernel.org
> Signed-off-by: Guangshuo Li
Reviewed-by: Ira Weiny
[snip]
Dave Jiang wrote:
[snip]
> > @@ -998,9 +998,8 @@ static int init_labels(struct nd_mapping *nd_mapping,
> > int num_labels)
> > label_ent = kzalloc(sizeof(*label_ent), GFP_KERNEL);
> > if (!label_ent)
> > return -ENOMEM;
> > - mutex_lock(&nd_m
Neeraj Kumar wrote:
> CXL 3.2 Spec mentions CXL LSA 2.1 Namespace Labels at section 9.13.2.5
> Modified __pmem_label_update function using setter functions to update
> namespace label as per CXL LSA 2.1
Again I'm curious as to why?
Is it to be able to use the setter's later? I see a call to
nsl_
Neeraj Kumar wrote:
> Updated mutex_lock() with guard(mutex)()
You are missing the 'why' justification here.
The detail is that __pmem_label_update() is getting more complex and this
change helps to reduce the complexity later.
However...
[snip]
> @@ -998,9 +998,8 @@ static int init_labels(str
Neeraj Kumar wrote:
> nd_label_base() was being used after typecasting with 'unsigned long'. Thus
> modified nd_label_base() to return 'unsigned long' instead of 'struct
> nd_namespace_label *'
>
> Signed-off-by: Neeraj Kumar
Acked-by: Ira Weiny
Neeraj Kumar wrote:
> On 19/08/25 01:56PM, Ira Weiny wrote:
> >Neeraj Kumar wrote:
> >> nd_mapping->labels maintains the list of labels present into LSA.
> >> init_labels() prepares this list while adding new label into LSA
> >> and updates nd_mapping
Rafael J. Wysocki wrote:
> On Tue, Sep 2, 2025 at 1:46 PM Colin Ian King wrote:
> >
> > There appears to be a cut-n-paste error with the incorrect field
> > ndr_desc->numa_node being reported for the target node. Fix this by
> > using ndr_desc->target_node instead.
> >
> > Fixes: f060db99374e ("AC
Colin Ian King wrote:
> There appears to be a cut-n-paste error with the incorrect field
NIT: 'There __is__ a cut-n-paste error..." ;-)
Reviewed-by: Ira Weiny
> ndr_desc->numa_node being reported for the target node. Fix this by
> using ndr_desc->target_node instead.
+ Michal
Mike Rapoport wrote:
> From: "Mike Rapoport (Microsoft)"
>
> There are use cases, for example virtual machine hosts, that create
> "persistent" memory regions using memmap= option on x86 or dummy
> pmem-region device tree nodes on DT based systems.
>
> Both these options are inflexible
Sean Christopherson wrote:
> On Wed, Aug 20, 2025, Sagi Shahar wrote:
> > TDX require special handling for VM and VCPU initialization for various
> > reasons:
> > - Special ioctlss for creating VM and VCPU.
> > - TDX registers are inaccessible to KVM.
> > - TDX require special boot code trampoline
Sagi Shahar wrote:
> From: Isaku Yamahata
>
> Let kvm_init_vm_address_properties() initialize vm->arch.{s_bit, tag_mask}
> similar to SEV.
>
> TDX sets the shared bit based on the guest physical address width and
> currently supports 48 and 52 widths.
>
> Co-developed-by: Adrian Hunter
> Signe
Sagi Shahar wrote:
[snip]
> diff --git a/tools/testing/selftests/kvm/lib/x86/processor.c
> b/tools/testing/selftests/kvm/lib/x86/processor.c
> index b2a4b11ac8c0..1eae92957456 100644
> --- a/tools/testing/selftests/kvm/lib/x86/processor.c
> +++ b/tools/testing/selftests/kvm/lib/x86/processor.c
>
NIT:
Sagi Shahar wrote:
> Move kernel segment definitons to a separate file which can be included
^^
definitions
And in the subject.
Otherwise seems reasonable.
Reviewed-by: Ira Weiny
> from assembly files.
>
> Signed-off-by:
d-off-by: Sagi Shahar
Reviewed-by: Ira Weiny
> ---
> tools/testing/selftests/kvm/lib/kvm_util.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c
> b/tools/testing/selftests/kvm/lib/kvm_util.c
> index c3f5142b0a54..b4c8702ba4bd 1006
Sagi Shahar
Thanks! I've seen this as well and it fixes the warning for me as well.
It might be worth picking up separate from this series depending on what
the selftest folks say.
Tested-by: Ira Weiny
Reviewed-by: Ira Weiny
> ---
> tools/testing/selftests/kselftest_harness.h | 3 +
Neeraj Kumar wrote:
> CXL 3.2 Spec mentions CXL LSA 2.1 Namespace Labels at section 9.13.2.5
> Modified __pmem_label_update function using setter functions to update
> namespace label as per CXL LSA 2.1
>
> Signed-off-by: Neeraj Kumar
[snip]
>
> +static inline void nsl_set_type(struct nvdimm_
Neeraj Kumar wrote:
> nd_mapping->labels maintains the list of labels present into LSA.
> init_labels() prepares this list while adding new label into LSA
> and updates nd_mapping->labels accordingly. During cxl region
> creation nd_mapping->labels list and LSA was updated with one
> region label.
RE Subject: [PATCH V2 05/20] nvdimm/region_label: Add region label updation
routine
^^^
update
Neeraj Kumar wrote:
> Added __pmem_region_label_update region la
A 2.1 format
>
> Signed-off-by: Neeraj Kumar
Seems ok:
Acked-by: Ira Weiny
[snip]
Neeraj Kumar wrote:
> CXL 3.2 Spec mentions CXL LSA 2.1 Namespace Labels at section 9.13.2.5
> Modified __pmem_label_update function using setter functions to update
> namespace label as per CXL LSA 2.1
But why? And didn't we just remove nd_namespace_label in patch 2?
Why are we now defining acc
Neeraj Kumar wrote:
> LSA 2.1 format introduces region label, which can also reside
> into LSA along with only namespace label as per v1.1 and v1.2
>
> As both namespace and region labels are of same size of 256 bytes.
Soft-NAK
Having 2 data structures of the same size is not a reason to combine
Sagi Shahar wrote:
> From: Ackerley Tng
NIT: UPM?
Also for consistency with the next patch:
"KVM: selftests: TDX: Add TDX UPM selftests for explicit conversion"
>
> This tests the use of guest memory with explicit TDG.VP.VMCALL
> calls.
>
[snip]
> +
> +/*
> + * 0x8000 is arbitr
Sagi Shahar wrote:
> From: Yan Zhao
>
> Add a selftest to verify that adding flag KVM_MEM_LOG_DIRTY_PAGES to a
> !KVM_MEM_GUEST_MEMFD memslot does not produce host errors in TDX.
I'll pick on this patch for a general comment in for the series.
Most of the commit messages are light on the 'why'
Sean Christopherson wrote:
> On Thu, Aug 07, 2025, Sagi Shahar wrote:
> > From: Erdem Aktas
[snip]
> > +
> > +static void load_td_memory_region(struct kvm_vm *vm,
> > + struct userspace_mem_region *region)
> > +{
> > + const struct sparsebit *pages = region->protect
Sagi Shahar wrote:
> From: Ackerley Tng
>
> virt_map() enforces a private mapping for private memory. Introduce
> virt_map_shared() that creates a shared mapping for private as
> well as shared memory. This way, the TD does not have to remap its
> page tables at runtime.
>
> Signed-off-by: Acker
Sagi Shahar wrote:
> From: Ackerley Tng
>
> If guest memory is backed by restricted memfd
^^
guest_memfd?
I'm not sure what a restricted memfd is?
> + UPM is being used, hence encrypted memory region has to
Sagi Shahar wrote:
> On Mon, Jul 21, 2025 at 4:51 PM Ira Weiny wrote:
> >
> > On Fri, Jun 13, 2025 at 12:13:32PM -0700, Sagi Shahar wrote:
> > > From: Isaku Yamahata
> > >
> >
> > [snip]
> >
> > >
> > > diff --git a/tools/testi
Hey Linus, please pull from:
https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git/
tags/libnvdimm-for-6.17
... to get header file cleanups. Specifically use specific headers rather
than just kernel.h in libnvdimm.h to reduce header file usage.
The second patch is a fix to CXL bu
On Fri, Jun 13, 2025 at 12:13:32PM -0700, Sagi Shahar wrote:
> From: Isaku Yamahata
>
[snip]
>
> diff --git a/tools/testing/selftests/kvm/lib/x86/processor.c
> b/tools/testing/selftests/kvm/lib/x86/processor.c
> index d082d429e127..d9f4ecd6ffbc 100644
> --- a/tools/testing/selftests/kvm/lib/x
Neeraj Kumar wrote:
> NDD_CXL_LABEL is introduced to set cxl LSA 2.1 label format
> Accordingly updated label index version
I'm not following why CXL specific code needs to be in nvdimm?
I did not get a cover letter in this thread and looking at lore I don't
see one either:
https://lore.kernel.o
Neeraj Kumar wrote:
> In order to accommodate cxl lsa 2.1 format region label, renamed
> nd_namespace_label to nd_lsa_label.
This does not really make it clear why a name change is required.
Could you elaborate here?
Ira
>
> No functional change introduced.
>
> Signed-off-by: Neeraj Kumar
> -
ort headers alphabetically.
>
> [...]
Applied, thanks!
[1/1] libnvdimm: Don't use "proxy" headers
commit: 536f5941adde41c99a18a0ba03b457adc9702ab8
Best regards,
--
Ira Weiny
ort headers alphabetically.
>
> [...]
Applied, thanks!
[1/1] libnvdimm: Don't use "proxy" headers
commit: 536f5941adde41c99a18a0ba03b457adc9702ab8
Best regards,
--
Ira Weiny
Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
>
> Note that kernel.h is discouraged to be included as it's written
> at the top of that file.
>
> While doing that, sort headers alphabetically.
>
> Signed-off-by: Andy Shevchenko
> ---
> inc
Drew Fustini wrote:
> On Mon, Jun 09, 2025 at 08:32:41AM -0500, Rob Herring wrote:
> > On Fri, Jun 06, 2025 at 11:11:17AM -0700, Drew Fustini wrote:
> > > Convert the PMEM device tree binding from text to YAML. This will allow
> > > device trees with pmem-region nodes to pass dtbs_check.
> > >
> >
Drew Fustini wrote:
> On Mon, Jun 09, 2025 at 09:31:26AM -0500, Ira Weiny wrote:
> > Dan Williams wrote:
> > > [ add Ira ]
> > >
> > > Drew Fustini wrote:
> > > > Convert the PMEM device tree binding from text to YAML. This will allow
> > >
Dan Williams wrote:
> [ add Ira ]
>
> Drew Fustini wrote:
> > Convert the PMEM device tree binding from text to YAML. This will allow
> > device trees with pmem-region nodes to pass dtbs_check.
> >
> > Acked-by: Conor Dooley
> > Acked-by: Oliver O'Halloran
> > Signed-off-by: Drew Fustini
> > -
Fan Ni wrote:
> On Sun, Apr 13, 2025 at 05:52:10PM -0500, Ira Weiny wrote:
> > Devices which optionally support Dynamic Capacity (DC) are configured
> > via mailbox commands. CXL 3.2 section 9.13.3 requires the host to issue
> > the Get DC Configuration command in order to pr
Fan Ni wrote:
> On Mon, Apr 14, 2025 at 03:19:50PM +0100, Jonathan Cameron wrote:
> > On Sun, 13 Apr 2025 17:52:09 -0500
> > Ira Weiny wrote:
[snip]
> >
> > > +
> > > +static bool cxl_verify_dcd_cmds(struct cxl_memdev_state *mds, unsigned
> > >
Fan Ni wrote:
> On Sun, Apr 13, 2025 at 05:52:08PM -0500, Ira Weiny wrote:
> > A git tree of this series can be found here:
> >
> > https://github.com/weiny2/linux-kernel/tree/dcd-v6-2025-04-13
> >
> > This is now based on 6.15-rc2.
> >
> > Du
existing DAX devices as having a 0 tag
which makes the most logical sense as a default.
Process DCD events and create region devices.
Based on an original patch by Navneet Singh.
Reviewed-by: Dave Jiang
Reviewed-by: Li Ming
Reviewed-by: Jonathan Cameron
Signed-off-by: Ira Weiny
---
Chan
.
Simplify log processing by using the event log array index as the
handle. Add a lock to manage concurrency required when user space is
allowed to control DCD extents
Reviewed-by: Jonathan Cameron
Reviewed-by: Dave Jiang
Signed-off-by: Ira Weiny
---
Changes:
[iweiny: rebase to 6.15-rc1
neet Singh.
Reviewed-by: Jonathan Cameron
Reviewed-by: Fan Ni
Signed-off-by: Ira Weiny
---
Changes:
[0day: fix extent count in GetExtent input payload]
[iweiny: minor clean ups]
[iweiny: Adjust for partition arch]
---
drivers/cxl/core/core.h | 1 +
drivers/cxl/core/mbox
original patch by Navneet Singh.
Signed-off-by: Ira Weiny
---
Changes:
[iweiny: rebased]
[iweiny: remove tags]
[djbw: remove dcd_cmds bitmask from mds]
---
drivers/cxl/core/mbox.c | 44
drivers/cxl/cxlmem.h| 15 +++
2 files changed, 59
pport more than 1 DC partition
[1] https://github.com/weiny2/ndctl/tree/dcd-region3-2025-04-13
---
Changes in v9:
- djbw: pare down support to only a single DC parition
- djbw: adjust to the new core partition processing which aligns with
new type2 work.
- iweiny: address smaller comments from v
Device partitions have an implied order which is made more complex by
the addition of a dynamic partition.
Remove the ram special case information calls in favor of generic calls
with a check ahead of time to ensure the preservation of the implied
partition order.
Signed-off-by: Ira Weiny
/offset
/sys/bus/cxl/devices/dax_regionX/extentX.Y/length
/sys/bus/cxl/devices/dax_regionX/extentX.Y/tag
Based on an original patch by Navneet Singh.
Reviewed-by: Jonathan Cameron
Reviewed-by: Fan Ni
Tested-by: Fan Ni
Signed-off-by: Ira Weiny
---
Changes:
[iweiny: rebase]
[iweiny
: Fan Ni
Signed-off-by: Ira Weiny
---
Changes:
[djbw: s/region/partition/]
[iweiny: s/tag/uuid/]
---
drivers/cxl/core/mbox.c | 4 +++
drivers/cxl/core/trace.h | 65
2 files changed, 69 insertions(+)
diff --git a/drivers/cxl/core/mbox.c b/drivers
: Jonathan Cameron
Reviewed-by: Dave Jiang
Signed-off-by: Ira Weiny
---
Changes:
[iweiny: rebase]
[djbw: s/region/partition/]
[iweiny: s/tag/uuid/]
---
tools/testing/cxl/test/mem.c | 753 +++
1 file changed, 753 insertions(+)
diff --git a/tools/testing/cxl/test
decoder.
Return the endpoint decoder found to be used in subsequent DCD code.
Reviewed-by: Jonathan Cameron
Reviewed-by: Fan Ni
Reviewed-by: Dave Jiang
Reviewed-by: Li Ming
Reviewed-by: Alison Schofield
Signed-off-by: Ira Weiny
---
Changes:
[iweiny: rebase]
---
drivers/cxl/core/core.h
ce for
the dax ranges. Future patches will use the same algorithm with
individual extent resources as the parent.
Reviewed-by: Jonathan Cameron
Reviewed-by: Dave Jiang
Signed-off-by: Ira Weiny
---
drivers/dax/bus.c | 130 +-
1 file changed,
the DAX region resource tree
based on the extents lifetime. Return the status of remove
notifications to lower layers such that it can manage the hardware
appropriately.
Based on an original patch by Navneet Singh.
Reviewed-by: Jonathan Cameron
Signed-off-by: Ira Weiny
---
Changes:
[iweiny
devices on sparse
regions.
Interleaving is deferred for now. Add checks.
Based on an original patch by Navneet Singh.
Signed-off-by: Ira Weiny
---
Changes:
[iweiny: adjust to new partition mode and new singular dynamic ram
partition]
---
Documentation/ABI/testing/sysfs-bus-cxl | 22
.
Reviewed-by: Dave Jiang
Reviewed-by: Jonathan Cameron
Reviewed-by: Fan Ni
Reviewed-by: Li Ming
Link:
https://lore.kernel.org/all/663922b475e50_d54d729...@dwillia2-xfh.jf.intel.com.notmuch/
[1]
Suggested-by: Dan Williams
Signed-off-by: Ira Weiny
---
drivers/cxl/pci.c | 23 ---
1
meron
Reviewed-by: Dave Jiang
Reviewed-by: Li Ming
Reviewed-by: Fan Ni
Signed-off-by: Ira Weiny
---
drivers/cxl/cxlmem.h | 2 ++
drivers/cxl/pci.c| 73 ++--
2 files changed, 62 insertions(+), 13 deletions(-)
diff --git a/drivers/cxl/cxlmem.h b/dr
preparation for
separate DCD interrupts configuration.
Reviewed-by: Jonathan Cameron
Reviewed-by: Fan Ni
Reviewed-by: Dave Jiang
Reviewed-by: Li Ming
Signed-off-by: Ira Weiny
---
drivers/cxl/pci.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers
Endpoints can now support a single dynamic ram partition following the
persistent memory partition.
Expand the mode to allow a decoder to point to the first dynamic ram
partition.
Signed-off-by: Ira Weiny
---
Changes:
[iweiny: completely re-written]
---
Documentation/ABI/testing/sysfs-bus-cxl
To properly configure CXL regions user space will need to know the
details of the dynamic ram partition.
Expose the first dynamic ram partition through sysfs.
Signed-off-by: Ira Weiny
---
Changes:
[iweiny: Complete rewrite of the old patch.]
---
Documentation/ABI/testing/sysfs-bus-cxl | 24
Additional DCD partition (AKA region) information is contained in the
DSMAS CDAT tables, including performance, read only, and shareable
attributes.
Match DCD partitions with DSMAS tables and store the meta data.
Signed-off-by: Ira Weiny
---
Changes:
[iweiny: Adjust for new perf/partition
on an original patch by Navneet Singh.
Signed-off-by: Ira Weiny
---
Changes:
[iweiny: rebase]
[iweiny: Update spec references to 3.2]
[djbw: Limit to 1 partition]
[djbw: Avoid inter-partition skipping]
[djbw: s/region/partition/]
[djbw: remove cxl_dc_region[partition]_info->name]
[iweiny: adjust t
.
Thanks,
Ira Weiny
---
The following changes since commit 7eb172143d5508b4da468ed59ee857c6e5e01da6:
Linux 6.14-rc5 (2025-03-02 11:48:20 -0800)
are available in the Git repository at:
g...@gitolite.kernel.org:pub/scm/linux/kernel/git/nvdimm/nvdimm.git
tags/libnvdimm-for-6.15
for you to
a multiple of max_xfer
> size */
> drivers/nvdimm/label.c: read_size = min(DIV_ROUND_UP(read_size, max_xfer) *
> max_xfer,
> drivers/nvdimm/label.c- config_size);
>
> Fix this by checking the config size parameter by extending an
> existing check.
>
> Signed-
arently nvdimm_get_config_data() was intended to check for this implicitly
but it is too late.
Anyway all this side tracked me a bit.
I assume this is a broken device which is in the real world? The fix looks
fine. But could you re-spin with a clean up of the commit message and I'll
queue it up.
Reviewed-by: Ira Weiny
[snip]
linux@ wrote:
> From: "Dr. David Alan Gilbert"
>
> Hi,
> A couple of nvdimm dead coding patches; they just
> remove entirely unused functions.
>
> Signed-off-by: Dr. David Alan Gilbert
For the series.
I'll pick these up for 6.15.
Reviewed-by: Ira Weiny
Murad Masimov wrote:
>
>
> От: Dave Jiang
> Отправлено: 24 января 2025 г. 2:43
> Кому: Masimov Murad; Dan Williams
> Копия: Vishal Verma; Ira Weiny; Rafael J. Wysocki; Len Brown;
> nvd...@lists.linux.dev; linux-a...@vger.kernel
David Reaver wrote:
> kmap_atomic() is deprecated and should be replaced with kmap_local_page()
> [1][2]. kmap_local_page() is faster in kernels with HIGHMEM enabled, can
> take page faults, and allows preemption.
Thanks for taking these on! It is good to see some progress here.
>
> According t
Suraj Sonawane wrote:
> On 11/18/24 21:56, Suraj Sonawane wrote:
[snip]
> >
> > drivers/acpi/nfit/core.c | 7 ++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> > index 5429ec9ef..a5d47819b 100644
> > --- a/dr
Hi Linus, please pull from
git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git
tags/libnvdimm-for-6.13
Changes for the nvdimm tree.
Most represent minor cleanups and code removals. One patch fixes potential
NULL pointer arithmetic which was benign because the offset of the member
Suraj Sonawane wrote:
> Fix an issue detected by syzbot with KASAN:
>
> BUG: KASAN: vmalloc-out-of-bounds in cmd_to_func drivers/acpi/nfit/
> core.c:416 [inline]
> BUG: KASAN: vmalloc-out-of-bounds in acpi_nfit_ctl+0x20e8/0x24a0
> drivers/acpi/nfit/core.c:459
>
> The issue occurs in cmd_to_func w
Suraj Sonawane wrote:
> Fix an issue detected by syzbot with KASAN:
>
> BUG: KASAN: vmalloc-out-of-bounds in cmd_to_func drivers/acpi/nfit/
> core.c:416 [inline]
> BUG: KASAN: vmalloc-out-of-bounds in acpi_nfit_ctl+0x20e8/0x24a0
> drivers/acpi/nfit/core.c:459
>
> The issue occurs in cmd_to_func w
is empty, remove them.
>
> Fixes: 83762cb5c7c4 ("dax: Kill DEV_DAX_PMEM_COMPAT")
> Suggested-by: Vegard Nossum
> Signed-off-by: Harshit Mogalapalli
Marked for nvdimm-next
Thanks!
Reviewed-by: Ira Weiny
> ---
> drivers/dax/pmem/Makefile | 7 ---
> drivers/dax
Julia Lawall wrote:
> Reorganize kerneldoc parameter names to match the parameter
> order in the function header.
>
> Problems identified using Coccinelle.
>
> Signed-off-by: Julia Lawall
Acked-by: Ira Weiny
>
> ---
> drivers/nvdimm/dimm_devs.c |2 +-
>
Philip Chen wrote:
> Hi maintainers,
>
> Can anyone let me know if this patch makes sense?
> Any comment/feedback is appreciated.
> Thanks in advance!
I'm not an expert on virtio but the code looks ok on the surface. I've
discussed this with Dan a bit and virtio-pmem is not heavily tested.
Base
Rob Herring wrote:
> On Wed, Jul 31, 2024 at 2:14 PM Rob Herring (Arm) wrote:
> >
> > Use of_property_present() and of_property_read_bool() to test
> > property presence and read boolean properties rather than
> > of_(find|get)_property(). This is part of a larger effort to remove
> > callers of o
Philip Chen wrote:
> Hi,
>
> On Tue, Aug 20, 2024 at 1:01 PM Dave Jiang wrote:
> >
> >
> >
> > On 8/20/24 10:22 AM, Philip Chen wrote:
> > > If a pmem device is in a bad status, the driver side could wait for
> > > host ack forever in virtio_pmem_flush(), causing the system to hang.
> > >
> > > S
mespace_pmem() is the only user of
> select_pmem_id(), it's safe to remove the 'return -ENODEV' branch.
>
> Signed-off-by: Li Zhijian
Reviewed-by: Ira Weiny
> ---
> V2:
> new patch.
> It's found when I'm Reviewing/tracing the return values of
sync_device_register+0xe/0x50 [libnvdimm]
> [<00003f4c52a4>] async_run_entry_fn+0x2e/0x110
> [<e201f4b0>] process_one_work+0x1ee/0x600
> [<6d90d5a9>] worker_thread+0x183/0x350
>
> Cc: Dave Jiang
> Cc: Ira Weiny
> Fixes: 1b40e09a12
Philip Chen wrote:
> On Mon, Aug 19, 2024 at 2:56 PM Ira Weiny wrote:
> >
> > Philip Chen wrote:
> > > If a pmem device is in a bad status, the driver side could wait for
> > > host ack forever in virtio_pmem_flush(), causing the system to hang.
> >
> >
Philip Chen wrote:
> If a pmem device is in a bad status, the driver side could wait for
> host ack forever in virtio_pmem_flush(), causing the system to hang.
I assume this was supposed to be v2 and you resent this as a proper v2
with a change list from v1?
Ira
>
> Signed-off-by: Philip Chen
Ira Weiny wrote:
> Hi Linux, please pull from
^
Linus.
Apologies,
Ira
>
> https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git/
> tags/libnvdimm-fixes-6.11-rc4
>
> To get a fix for filesystem DAX.
>
> It has been in -next since August 1
Hi Linux, please pull from
https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git/
tags/libnvdimm-fixes-6.11-rc4
To get a fix for filesystem DAX.
It has been in -next since August 12th without any reported issues.
Thanks,
Ira Weiny
---
The following changes since commit
t; [<391c5a7d>] __device_attach+0xbe/0x1e0
> [<26dabec0>] bus_probe_device+0x94/0xb0
> [<c590d936>] device_add+0x656/0x870
> [<3d69bfaa>] nd_async_device_register+0xe/0x50 [libnvdimm]
> [<3f4c52a4>]
)
A series of patches to add MODULE_DESCRIPTIONS() to eliminate make W=1
warnings.
Erick Archer (1):
nvdimm/btt: use sizeof(*pointer) instead of sizeof(type)
Ira Weiny (1):
testing: nvdimm: Add MODULE_DESCRIPTION() macros
r than dynamically create it."
>
> That works too, want me to resubmit with this, or can I update it when I
> commit it to my tree?
In that case.
Reviewed-by: Ira Weiny
>
> thanks,
>
> greg "the changelog is the hardest part" k-h
drivers.
Suggested-by: Jeff Johnson
Signed-off-by: Ira Weiny
---
Jeff I'm not seeing a patch to cover these cases for the missing module
descriptions you have been sending out. If you have an outstanding
patch I missed could you point me to it? Otherwise I believe this
cleans up the nvdimm
Jeff Johnson wrote:
> Fix the 'make W=1' warnings:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/libnvdimm.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_pmem.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_btt.o
> WARNING: modpo
Li Zhijian wrote:
> Don't allocate devs again when it's valid pointer which has pionted to
> the memory allocated above with size (count + 2 * sizeof(dev)).
>
> A kmemleak reports:
> unreferenced object 0x88800dda1980 (size 16):
> comm "kworker/u10:5", pid 69, jiffies 4294671781
> hex dump
the current kernel interfaces such as
using const for struct device_type and changing the platform remove
callback signature.
Thank you,
Ira Weiny
---
The following changes since commit ed30a4a51bb196781c8058073ea720133a65596f:
Linux 6.9-rc5 (2024-04-21 12:35:54 -0700)
are available in the Git
Jonathan Cameron wrote:
> On Wed, 14 Feb 2024 17:33:18 -0500
> Steven Rostedt wrote:
>
> > On Wed, 14 Feb 2024 14:19:19 -0800
> > Ira Weiny wrote:
> >
> > > > > Jonathan Cameron wrote:
> > > > >
> > > > &g
Ira Weiny wrote:
> Jonathan Cameron wrote:
> > On Wed, 14 Feb 2024 10:23:10 -0500
> > Steven Rostedt wrote:
> >
> > > On Wed, 14 Feb 2024 12:11:53 +
> > > Jonathan Cameron wrote:
> > >
> > > > So I'm thinking this
Jonathan Cameron wrote:
> On Wed, 14 Feb 2024 10:23:10 -0500
> Steven Rostedt wrote:
>
> > On Wed, 14 Feb 2024 12:11:53 +
> > Jonathan Cameron wrote:
> >
> > > So I'm thinking this is a won't fix - wait for the printk rework to land
> > > and
> > > assume this will be resolved as well?
>
Jonathan Cameron wrote:
> On Wed, 14 Feb 2024 10:23:10 -0500
> Steven Rostedt wrote:
>
> > On Wed, 14 Feb 2024 12:11:53 +
> > Jonathan Cameron wrote:
> >
> > > So I'm thinking this is a won't fix - wait for the printk rework to land
> > > and
> > > assume this will be resolved as well?
>
Ira Weiny wrote:
> Jonathan Cameron wrote:
> > On Tue, 06 Feb 2024 14:15:32 -0800
> > Ira Weiny wrote:
> >
> >
[snip]
> >
> > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> > index 9ff8a439d674..7ee45f22f56f 100644
> > --- a/
Jonathan Cameron wrote:
> On Tue, 06 Feb 2024 14:15:32 -0800
> Ira Weiny wrote:
>
> > Smatch caught that cxl_cper_post_event() is called with a spinlock held
> > or preemption disabled.[1] The callback takes the device lock to
> > perform address translation and
Hi Linus, please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git
tags/libnvdimm-for-6.8
... to get updates to the nvdimm tree. They are a mix of bug fixes and updates
to interfaces used by nvdimm.
Updates to interfaces include:
Use the new scope based manag
Randy Dunlap wrote:
>
>
> On 12/21/23 14:32, Ira Weiny wrote:
> > Randy Dunlap wrote:
> >
> > [snip]
> >
> >> @@ -1656,8 +1664,10 @@ static int select_pmem_id(struct nd_regi
> >> /**
> >> * create_namespace_pmem - validate interle
Ira Weiny wrote:
> Randy Dunlap wrote:
[snip]
> > diff -- a/drivers/nvdimm/dimm_devs.c b/drivers/nvdimm/dimm_devs.c
> > --- a/drivers/nvdimm/dimm_devs.c
> > +++ b/drivers/nvdimm/dimm_devs.c
> > @@ -53,7 +53,10 @@ static int validate_dimm(struct nvdimm_d
> >
&g
t; + * @nd_mapping: container of dpa-resource-root + labels
> * @nd_label: target pmem namespace label to evaluate
> + *
> + * Returns: the created &struct device on success or -errno on error
NIT: should this be ERR_PTR(-errno) on error?
Generally good to me though.
Reviewed-by: Ira
dimm' description in
> 'nvdimm_allocated_dpa'
> dimm_devs.c:844: warning: No description found for return value of
> 'nvdimm_allocated_dpa'
>
> Signed-off-by: Randy Dunlap
> Cc: Dan Williams
> Cc: Vishal Verma
> Cc: Dave Jiang
> Cc: Ira Weiny
>
1 - 100 of 1041 matches
Mail list logo
