[PATCH net-next] rtlwifi: rtl8192de: Use DEFINE_SPINLOCK() for spinlock

2021-04-06 Thread Huang Guobin
From: Guobin Huang spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- .../realtek/rtlwifi/rtl8192de/sw.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions

[PATCH net-next] rfkill: use DEFINE_SPINLOCK() for spinlock

2021-04-06 Thread Huang Guobin
From: Guobin Huang spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- net/rfkill/input.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/rfkill/inp

[PATCH -next] drbd: use DEFINE_SPINLOCK() for spinlock

2021-04-06 Thread Huang Guobin
From: Guobin Huang spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- drivers/block/drbd/drbd_main.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/d

[PATCH -next] NFSD: Use DEFINE_SPINLOCK() for spinlock

2021-04-06 Thread Huang Guobin
From: Guobin Huang spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- fs/nfsd/nfssvc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/nfsd/nfssvc.c

[PATCH -next] PCI: Use DEFINE_SPINLOCK() for spinlock

2021-04-06 Thread Huang Guobin
From: Guobin Huang spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- drivers/pci/hotplug/cpqphp_nvram.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

[PATCH -next] crypto: ixp4xx -: use DEFINE_SPINLOCK() for spinlock

2021-04-06 Thread Huang Guobin
From: Guobin Huang spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- drivers/crypto/ixp4xx_crypto.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git

[PATCH -next] crypto: geode -: use DEFINE_SPINLOCK() for spinlock

2021-04-06 Thread Huang Guobin
From: Guobin Huang spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- drivers/crypto/geode-aes.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/driver

[PATCH -next] tty: n_gsm: use DEFINE_SPINLOCK() for spinlock

2021-04-06 Thread Huang Guobin
From: Guobin Huang spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- drivers/tty/n_gsm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/tty/n

[PATCH -next] gma500: Use DEFINE_SPINLOCK() for spinlock

2021-04-06 Thread Huang Guobin
From: Guobin Huang spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- drivers/gpu/drm/gma500/power.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dri

[PATCH -next] dlm: use DEFINE_SPINLOCK() for spinlock

2021-04-06 Thread Huang Guobin
From: Guobin Huang spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- fs/dlm/plock.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/dlm/plock.c b/fs

[PATCH net-next v2] net: mscc: ocelot: remove redundant dev_err call in vsc9959_mdio_bus_alloc()

2021-03-28 Thread Huang Guobin
From: Guobin Huang There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- drivers/net/dsa/ocelot/felix_vsc9959.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-

[PATCH net-next v2] net: stmmac: remove redundant dev_err call in qcom_ethqos_probe()

2021-03-28 Thread Huang Guobin
From: Guobin Huang There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- .../net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 1 - 1 file changed, 1 deletion(-) dif

[PATCH net-next v2] net: axienet: Remove redundant dev_err call in axienet_probe()

2021-03-28 Thread Huang Guobin
From: Guobin Huang There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 1 - 1 file changed, 1 deletion(-) diff -

[PATCH net-next v2] net: mdio: Remove redundant dev_err call in mdio_mux_iproc_probe()

2021-03-28 Thread Huang Guobin
From: Guobin Huang There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- drivers/net/mdio/mdio-mux-bcm-iproc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

[PATCH net-next v2] net: moxa: remove redundant dev_err call in moxart_mac_probe()

2021-03-27 Thread Huang Guobin
From: Guobin Huang There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- drivers/net/ethernet/moxa/moxart_ether.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dr

[PATCH net-next v2] net: lantiq: Remove redundant dev_err call in xrx200_probe()

2021-03-27 Thread Huang Guobin
From: Guobin Huang There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- drivers/net/ethernet/lantiq_xrx200.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

[PATCH net-next v2] net: netcp: fix PM reference leak in netcp_probe()

2021-03-27 Thread Huang Guobin
From: Guobin Huang pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Reported-by: Hulk Robot Signed-off-by: Guobin Huang -

[PATCH net-next v2] net: dsa: hellcreek: Remove redundant dev_err call in hellcreek_probe()

2021-03-27 Thread Huang Guobin
From: Guobin Huang There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- drivers/net/dsa/hirschmann/hellcreek.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deleti

[PATCH] nfsd: Fix error return code in nfsd_file_cache_init()

2020-11-25 Thread Huang Guobin
Fix to return PTR_ERR() error code from the error handling case instead of 0 in function nfsd_file_cache_init(), as done elsewhere in this function. Fixes: 65294c1f2c5e7("nfsd: add a new struct file caching facility to nfsd") Signed-off-by: Huang Guobin --- fs/nfsd/filecache.c | 1

[PATCH -next] apparmor: Fix several kernel-doc warnings

2020-09-17 Thread Huang Guobin
a_change_profile' security/apparmor/domain.c:136: warning: Excess function parameter 'start' description in 'label_compound_match' Rename profile to p. @onexec in 'aa_change_profile' and @start in 'label_compound_match' are not in use, Remove it. S

[PATCH -next] apparmor: Fix several kernel-doc warnings

2020-09-17 Thread Huang Guobin
a_change_profile' security/apparmor/domain.c:136: warning: Excess function parameter 'start' description in 'label_compound_match' Rename profile to p. @onexec in 'aa_change_profile' and @start in 'label_compound_match' are not in use, Remove it. S

[PATCH net] net: wilc1000: clean up resource in error path of init mon interface

2020-09-17 Thread Huang Guobin
wfi_mon' static variable") Reported-by: Hulk Robot Signed-off-by: Huang Guobin --- drivers/net/wireless/microchip/wilc1000/mon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/microchip/wilc1000/mon.c b/drivers/net/wireless/microchip/wilc1000

[PATCH net-next] tipc: Use is_broadcast_ether_addr() instead of memcmp()

2020-08-02 Thread Huang Guobin
Using is_broadcast_ether_addr() instead of directly use memcmp() to determine if the ethernet address is broadcast address. spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by: Huang Guobin --- net/tipc/eth_media.c | 4 +--- 1 file changed, 1

[PATCH v2] lib: Verify array index is correct before using it

2020-07-28 Thread Huang Guobin
This code reads from the array before verifying that "c" is a valid index. Move test array offset code before use to fix it. Fixes: 2da572c959dd ("lib: add software 842 compression/decompression") Signed-off-by: Huang Guobin --- lib/842/842_compress.c | 9 +++-- 1 file c

[PATCH v2] lib: Verify array index is correct before using it

2020-07-26 Thread Huang Guobin
This code reads from the array before verifying that "c" is a valid index. Move test array offset code before use to fix it. Fixes: 2da572c959dd ("lib: add software 842 compression/decompression") Signed-off-by: Huang Guobin --- lib/842/842_compress.c | 9 +++-- 1 file c

[PATCH] lib: Verify array index is correct before using it

2020-07-23 Thread Huang Guobin
This code reads from the array before verifying that "c" is a valid index. Move test array offset code before use to fix it. Fixes: 2da572c959dd ("lib: add software 842 compression/decompression") Signed-off-by: Huang Guobin --- lib/842/842_compress.c | 7 +-- 1 file c

[PATCH] net: ag71xx: add missed clk_disable_unprepare in error path of probe

2020-07-19 Thread Huang Guobin
The ag71xx_mdio_probe() forgets to call clk_disable_unprepare() when of_reset_control_get_exclusive() failed. Add the missed call to fix it. Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver") Reported-by: Hulk Robot Signed-off-by: Huang Guobin --- drivers/net/ethernet/athero