From: Guobin Huang <huangguob...@huawei.com>

spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().

Reported-by: Hulk Robot <hul...@huawei.com>
Signed-off-by: Guobin Huang <huangguob...@huawei.com>
---
 drivers/crypto/ixp4xx_crypto.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/crypto/ixp4xx_crypto.c b/drivers/crypto/ixp4xx_crypto.c
index 8b0f17fc09fb..0616e369522e 100644
--- a/drivers/crypto/ixp4xx_crypto.c
+++ b/drivers/crypto/ixp4xx_crypto.c
@@ -265,7 +265,7 @@ static int setup_crypt_desc(void)
        return 0;
 }
 
-static spinlock_t desc_lock;
+static DEFINE_SPINLOCK(desc_lock);
 static struct crypt_ctl *get_crypt_desc(void)
 {
        int i;
@@ -293,7 +293,7 @@ static struct crypt_ctl *get_crypt_desc(void)
        }
 }
 
-static spinlock_t emerg_lock;
+static DEFINE_SPINLOCK(emerg_lock);
 static struct crypt_ctl *get_crypt_desc_emerg(void)
 {
        int i;
@@ -1379,9 +1379,6 @@ static int __init ixp_module_init(void)
        if (IS_ERR(pdev))
                return PTR_ERR(pdev);
 
-       spin_lock_init(&desc_lock);
-       spin_lock_init(&emerg_lock);
-
        err = init_ixp_crypto(&pdev->dev);
        if (err) {
                platform_device_unregister(pdev);

Reply via email to