Re: [PATCH v5] char: misc: add test cases

2025-07-30 Thread Geert Uytterhoeven
tristate "Perform selftest on IDA functions" > > config TEST_MISC_MINOR > - tristate "miscdevice KUnit test" if !KUNIT_ALL_TESTS > - depends on KUNIT > + bool "miscdevice KUnit test" if !KUNIT_ALL_TESTS > + depends on KUNIT=y

Re: [PATCH resend] rtc: Rename lib_test to rtc_lib_test

2025-07-01 Thread Geert Uytterhoeven
Hi Alex. On Mon, 30 Jun 2025 at 15:54, Alexandre Belloni wrote: > On 30/06/2025 09:47:54+0200, Geert Uytterhoeven wrote: > > When compiling the RTC library functions test as a module, the module > > has the non-descriptive name "lib_test.ko". Fix this by adding the

[PATCH v2] rtc: Rename lib_test to test_rtc_lib

2025-07-01 Thread Geert Uytterhoeven
When compiling the RTC library functions test as a module, the module has the non-descriptive name "lib_test.ko". Fix this by renaming it to "test_rtc_lib.ko". Signed-off-by: Geert Uytterhoeven --- v2: - s/rtc_lib_test/test_rtc_lib/. --- drivers/rtc/Makefile

[PATCH resend] rtc: Rename lib_test to rtc_lib_test

2025-06-30 Thread Geert Uytterhoeven
When compiling the RTC library functions test as a module, the module has the non-descriptive name "lib_test.ko". Fix this by adding the subsystem's name as a prefix. Signed-off-by: Geert Uytterhoeven --- drivers/rtc/Makefile | 2 +- drivers/

Re: [PATCH] char: misc: make miscdevice unit test built-in only

2025-05-05 Thread Geert Uytterhoeven
Hi Thadeu, CC kunit On Mon, 5 May 2025 at 14:13, Thadeu Lima de Souza Cascardo wrote: > On Mon, May 05, 2025 at 09:21:15AM +0200, Geert Uytterhoeven wrote: > > On Wed, 30 Apr 2025 at 18:53, Thadeu Lima de Souza Cascardo > > wrote: > > > Since it uses __init symbol

Re: [PATCH] lib: Ensure prime numbers tests are included in KUnit test runs

2025-04-22 Thread Geert Uytterhoeven
_BUILD=y > > CONFIG_AUDIT=y > > +CONFIG_PRIME_NUMBERS=y > + > CONFIG_SECURITY=y > CONFIG_SECURITY_APPARMOR=y > CONFIG_SECURITY_LANDLOCK=y Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond

[PATCH v2] lib: PRIME_NUMBERS_KUNIT_TEST should not select PRIME_NUMBERS

2025-04-14 Thread Geert Uytterhoeven
/selftests/lib/config for the latter use case. Fixes: 313b38a6ecb46db4 ("lib/prime_numbers: convert self-test to KUnit") Signed-off-by: Geert Uytterhoeven Acked-by: Tamir Duberstein --- v2: - Add Acked-by, - Resurrect CONFIG_PRIME_NUMBERS=m in tools/testing/selftests/lib/config

Re: [PATCH] lib: PRIME_NUMBERS_KUNIT_TEST should not select PRIME_NUMBERS

2025-04-14 Thread Geert Uytterhoeven
On Mon, 14 Apr 2025 at 10:50, Geert Uytterhoeven wrote: > Enabling a (modular) test should not silently enable additional kernel > functionality, as that may increase the attack vector of a product. > > Fix this by making PRIME_NUMBERS_KUNIT_TEST depend on PRIME_NUMBERS > instead

[PATCH] lib: PRIME_NUMBERS_KUNIT_TEST should not select PRIME_NUMBERS

2025-04-14 Thread Geert Uytterhoeven
nvert self-test to KUnit") Signed-off-by: Geert Uytterhoeven --- lib/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 4060a89866626c0a..51722f5d041970aa 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -3326

Re: [PATCH/RFC] kunit/rtc: Add real support for very slow tests

2025-03-28 Thread Geert Uytterhoeven
k these are all good > changes, even if there's more we can do to better scale to slower > hardware. > > On Fri, 28 Mar 2025 at 00:07, Geert Uytterhoeven wrote: > > 2. Increase timeout by ten; ideally this should only be done for very > > slow tests, but I

[PATCH/RFC] kunit/rtc: Add real support for very slow tests

2025-03-27 Thread Geert Uytterhoeven
test_date_range_1000.speed: slow ok 1 rtc_time64_to_tm_test_date_range_1000 # rtc_time64_to_tm_test_date_range_16.speed: very_slow ok 2 rtc_time64_to_tm_test_date_range_16 # rtc_lib_test_cases: pass:2 fail:0 skip:0 total:2 # Totals: pass:2 fail:0 skip:0 total:2 ok 1 rtc_lib_

[PATCH] rtc: Rename lib_test to rtc_lib_test

2025-03-27 Thread Geert Uytterhoeven
When compiling the RTC library functions test as a module, the module has the non-descriptive name "lib_test.ko". Fix this by adding the subsystem's name as a prefix. Signed-off-by: Geert Uytterhoeven --- drivers/rtc/Makefile | 2 +- drivers/

[PATCH] kunit: Spelling s/slowm/slow/

2025-03-27 Thread Geert Uytterhoeven
Fix a misspelling of "slow". Signed-off-by: Geert Uytterhoeven --- include/kunit/test.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/kunit/test.h b/include/kunit/test.h index 58dbab60f8530588..9b773406e01f3c43 100644 --- a/include/kunit/test.h +++ b/inc

Re: [PATCH v2] openrisc: Add cacheinfo support

2025-03-17 Thread Geert Uytterhoeven
> > > > +struct cache_desc { > > + u32 size; > > + u32 sets; > > + u32 block_size; > > + u32 ways; > > Considering the changes below to add cache available checks, maybe we > want to add a field here, such as `bool present`. Or a flags field

Re: [PATCH v2 1/2] get_maintainer: add --substatus for reporting subsystem status

2025-02-12 Thread Geert Uytterhoeven
5fcb88a8aa26831f9dba9faf15 Mon Sep 17 00:00:00 2001 > From: Vlastimil Babka > Date: Tue, 11 Feb 2025 16:16:11 +0100 > Subject: [PATCH] get_maintainer: add --substatus for reporting subsystem > status - fix > > The automatically enabled --substatus can break existing scripts t

Re: [PATCH v2 1/2] get_maintainer: add --substatus for reporting subsystem status

2025-02-11 Thread Geert Uytterhoeven
Hi Vlastimil, On Tue, 11 Feb 2025 at 17:09, Vlastimil Babka wrote: > On 2/11/25 16:19, Geert Uytterhoeven wrote: > > On Tue, 11 Feb 2025 at 15:58, Vlastimil Babka wrote: > >> On 2/11/25 11:48, Geert Uytterhoeven wrote: > >> I've tried to do that in v1 in the for

Re: [PATCH v2 1/2] get_maintainer: add --substatus for reporting subsystem status

2025-02-11 Thread Geert Uytterhoeven
Hi Uwe, On Tue, 11 Feb 2025 at 16:09, Uwe Kleine-König wrote: > On Tue, Feb 11, 2025 at 11:48:13AM +0100, Geert Uytterhoeven wrote: > > On Tue, 11 Feb 2025 at 11:32, Uwe Kleine-König > > wrote: > > > On Mon, Feb 03, 2025 at 12:13:16PM +0100, Vlastimil Babka wrote: >

Re: [PATCH v2 1/2] get_maintainer: add --substatus for reporting subsystem status

2025-02-11 Thread Geert Uytterhoeven
Hi Vlastimil, On Tue, 11 Feb 2025 at 15:58, Vlastimil Babka wrote: > On 2/11/25 11:48, Geert Uytterhoeven wrote: > > On Tue, 11 Feb 2025 at 11:32, Uwe Kleine-König > > wrote: > >> On Mon, Feb 03, 2025 at 12:13:16PM +0100, Vlastimil Babka wrote: > >> > The su

Re: [PATCH v2 1/2] get_maintainer: add --substatus for reporting subsystem status

2025-02-11 Thread Geert Uytterhoeven
us: Supported \ --cc "ARM/ASPEED MACHINE SUPPORT status: Supported \ --cc "MELEXIS MLX90614 DRIVER status: Supported \ --cc "ARM/NUVOTON MA35 ARCHITECTURE status: Supported \ --cc "ARM/RISC-V/RENESAS ARCHITECTURE status: Supported \ Iff this extra output is good to have, why not

Re: [PATCH v5 2/2] scanf: break kunit into test cases

2025-02-10 Thread Geert Uytterhoeven
oid *check_data, const > char *string, Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

Re: [PATCH v2 1/2] printf: convert self-test to KUnit

2025-02-10 Thread Geert Uytterhoeven
8k patch. Fine for me! Alternatively, you could just drop them. I do refresh the m68k defconfigs after every kernel release, but these updates only go upstream one cycle later. In this case that doesn't matter at all. Gr{oetje,eeting}s, Geert -- Geert Uyt

Re: [PATCH 0/3] bitmap: convert self-test to KUnit

2025-02-09 Thread Geert Uytterhoeven
t enabling KUNIT in config and/or re-compiling the whole kernel? > Please teach me, if so > > Unless you give me a way to build and run the test in true > production environment, I'm not going with KUNITs. Sorry. FTR, this is why I've been advocating for making all tests modul

Re: [PATCH 2/3] bitmap: convert self-test to KUnit

2025-02-09 Thread Geert Uytterhoeven
1 - > arch/m68k/configs/sun3x_defconfig | 1 - Acked-by: Geert Uytterhoeven # m68k Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself

Re: [PATCH 1/2] printf: convert self-test to KUnit

2025-02-05 Thread Geert Uytterhoeven
arch/m68k/configs/sun3_defconfig | 1 - > arch/m68k/configs/sun3x_defconfig | 1 - Acked-by: Geert Uytterhoeven # m68k Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal c

Re: [PATCH] scanf: convert self-test to KUnit

2025-02-03 Thread Geert Uytterhoeven
> arch/m68k/configs/multi_defconfig| 1 - > arch/m68k/configs/mvme147_defconfig | 1 - > arch/m68k/configs/mvme16x_defconfig | 1 - > arch/m68k/configs/q40_defconfig | 1 - > arch/m68k/configs/sun3_defconfig | 1 - > arch/m68k/configs/sun3x_defcon

Re: [PATCH] scanf: convert self-test to KUnit

2025-02-03 Thread Geert Uytterhoeven
ally like having all tests available as modules. Fortunately all of these will be gone, once all tests have been converted to kunit, and have a "default KUNIT_ALL_TESTS" line... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32

[PATCH] firmware: cs_dsp: FW_CS_DSP_KUNIT_TEST should not select REGMAP

2025-01-25 Thread Geert Uytterhoeven
mware: cs_dsp: Add KUnit testing of bin file download") Signed-off-by: Geert Uytterhoeven --- See also commits 70a640c0efa76674 ("regmap: REGMAP_KUNIT should not select REGMAP") and 47ee108a113c72e ("regmap: Provide user selectable option to enable regmap"). BTW, what&

[PATCH v2 resend] selftests: timers: clocksource-switch: Adapt progress to kselftest framework

2024-12-12 Thread Geert Uytterhoeven
ned-off-by: Geert Uytterhoeven Reviewed-by: Thomas Gleixner --- v2: - Add Reviewed-by. When just running the test, the output looks like: # Validating clocksource arch_sys_counter TAP version 13 1..12 ok 1 CLOCK_REALTIME ... # Validating clocksource ffca.timer T

[PATCH] selftests: find_symbol: Actually use load_mod() parameter

2024-11-28 Thread Geert Uytterhoeven
The parameter passed to load_mod() is stored in $MOD, but never used. Obviously it was intended to be used instead of the hardcoded "test_kallsyms_b" module name. Fixes: 84b4a51fce4ccc66 ("selftests: add new kallsyms selftests") Signed-off-by: Geert Uytterhoeven --- too

Re: [PATCH v3] selftests: add new kallsyms selftests

2024-11-28 Thread Geert Uytterhoeven
owever, I didn't notice any extra-ordinary build times. Also, when running the test manually on ARAnyM, everything runs in the blink of an eye. I didn't use the script, but ran all commands manually. I tried insmodding a/b/c/d, c/a/b, a/c/d/b. Is this expected? Thanks! $ wc -l lib/tests/module/test_

Re: [RFC] module: Strict per-modname namespaces

2024-11-08 Thread Geert Uytterhoeven
SCSI maintainers don't like. [1] "[PATCH] scsi: core: Make scsi_lib KUnit tests modular for real" https://lore.kernel.org/all/48ca5e827ca420bbdbabb1643e2179dc95c9e0b7.1710849638.git.ge...@linux-m68k.org/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoev

Re: [PATCH 1/6] lib: math: Move kunit tests into tests/ subdir

2024-11-06 Thread Geert Uytterhoeven
Hi Andrew, On Wed, Nov 6, 2024 at 10:17 PM Andrew Morton wrote: > On Wed, 6 Nov 2024 09:33:55 +0100 Geert Uytterhoeven > wrote: > > > This conflicts with "[PATCH] m68k: defconfig: Update defconfigs for > > > v6.12-rc1"[1]. Of course the proper way forw

Re: [PATCH 1/6] lib: math: Move kunit tests into tests/ subdir

2024-11-06 Thread Geert Uytterhoeven
Hi all, On Fri, Oct 11, 2024 at 10:59 AM Geert Uytterhoeven wrote: > On Fri, Oct 11, 2024 at 9:31 AM David Gow wrote: > > From: Luis Felipe Hernandez > > > > This patch is a follow-up task from a discussion stemming from point 3 > > in a recent patch introducing the

Re: [PATCH 1/6] lib: math: Move kunit tests into tests/ subdir

2024-10-11 Thread Geert Uytterhoeven
gt; @@ -2993,7 +2993,7 @@ config TEST_OBJPOOL > > If unsure, say N. > > -config INT_POW_TEST > +config INT_POW_KUNIT_TEST > tristate "Integer exponentiation (int_pow) test" if !KUNIT_ALL_TESTS > depends on KUNIT > default KUNIT_ALL_TESTS [

Re: [PATCH -fixes] riscv: patch: Flush the icache right after patching to avoid illegal insns

2024-07-09 Thread Geert Uytterhoeven
insns, len); > > - if (!ret) > - flush_icache_range((uintptr_t) tp, (uintptr_t) tp + len); > - > return ret; > } > NOKPROBE_SYMBOL(patch_text_nosync); patch_text_nosync() is now identical to patch_insn_write(), and both functions are called from

Re: [PATCH] [v5] kallsyms: rework symbol lookup return codes

2024-05-28 Thread Geert Uytterhoeven
c: In function ‘__sprint_symbol.constprop’: kernel/kallsyms.c:492:17: warning: ‘strcpy’ source argument is the same as destination [-Werror=restrict] 492 | strcpy(buffer, name); | ^~~~ I am seeing with shmobile_defconfig and gcc version 11.4.0 (U

Re: [PATCH v1 1/1] Input: gpio-keys - expose wakeup keys in sysfs

2024-05-13 Thread Geert Uytterhoeven
his is indeed a useful feature. Reviewed-by: Geert Uytterhoeven Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call mysel

Re: [PATCH] openrisc: Add support for more module relocations

2024-04-11 Thread Geert Uytterhoeven
ine R_OR1K_NONE0 and add definitions for backwards compatibility? #define R_OR32_NONER_OR1K_NONE Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technic

Re: [PATCH 0/4] apply page shift to PFN instead of VA in pfn_to_virt

2024-02-01 Thread Geert Uytterhoeven
e? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.

Re: [PATCH] dt-bindings: correct white-spaces in examples

2023-11-27 Thread Geert Uytterhoeven
On Fri, Nov 24, 2023 at 10:21 AM Krzysztof Kozlowski wrote: > Use only one and exactly one space around '=' in DTS example. > > Signed-off-by: Krzysztof Kozlowski > .../bindings/pinctrl/renesas,rzg2l-pinctrl.yaml | 6 +++--- Reviewed-by: Geert Uytterh

Re: [PATCH v2] locking/atomic: sh: Use generic_cmpxchg_local for arch_cmpxchg_local()

2023-10-26 Thread Geert Uytterhoeven
st robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202310241310.ir5uukog-...@intel.com/ > Signed-off-by: Masami Hiramatsu (Google) Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- g

Re: [PATCH] locking/atomic: sh: Use generic_cmpxchg_local for arch_cmpxchg_local()

2023-10-25 Thread Geert Uytterhoeven
/atomic-arch-fallback.h:392:16: note: in expansion of macro ‘raw_cmpxchg_local’ 392 | ___r = raw_cmpxchg_local((_ptr), ___o, (_new)); \ |^ ./include/linux/atomic/atomic-instrumented.h:4980:9: note: in expansion of macro ‘raw_try_cmpxchg_local’ 4980 |

[PATCH] neighbor: tracing: Move pin6 inside CONFIG_IPV6=y section

2023-10-16 Thread Geert Uytterhoeven
CONFIG_IPV6. Fixes: fc651001d2c5ca4f ("neighbor: Add tracepoint to __neigh_create") Signed-off-by: Geert Uytterhoeven --- No changes in generated code. include/trace/events/neigh.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/trace/events/neigh.h b/inc

Re: [PATCH v2 7/9] sched: define TIF_ALLOW_RESCHED

2023-10-06 Thread Geert Uytterhoeven
en: although openrisc does not select ARCH_NO_PREEMPT, it does not call preempt_schedule_irq() or select GENERIC_ENTRY? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical

Re: [PATCH v2 2/2] powerpc: Replace GPL 2.0+ README.legal boilerplate with SPDX

2023-09-18 Thread Geert Uytterhoeven
Hi Michael, On Tue, Sep 19, 2023 at 4:13 AM Michael Ellerman wrote: > Geert Uytterhoeven writes: > > Upstream Linux never had a "README.legal" file, but it was present > > in early source releases of Linux/m68k. It contained a simple copyright > > notice and a li

[PATCH v2 2/2] powerpc: Replace GPL 2.0+ README.legal boilerplate with SPDX

2023-09-18 Thread Geert Uytterhoeven
Get rid of the references to non-existent files by replacing the boilerplate with SPDX license identifiers. Signed-off-by: Geert Uytterhoeven --- v2: - s/existant/existent/. --- arch/powerpc/kernel/ptrace/ptrace.c | 5 + arch/powerpc/kernel/signal.c| 5 + arch/powerpc/kernel/

[PATCH v2 0/2] m68k/powerpc: Kill references to non-existent README.legal

2023-09-18 Thread Geert Uytterhoeven
sx-11.mit.edu/Oct-07-1996/680x0/v0.9/linux-0.9.tar.gz [2] "[PATCH 0/2] m68k/powerpc: Kill references to non-existent README.legal https://lore.kernel.org/r/cover.1694095086.git.ge...@linux-m68k.org Geert Uytterhoeven (2): m68k: Replace GPL 2.0+ README.legal boilerplate with SPDX powerp

[PATCH v2 1/2] m68k: Replace GPL 2.0+ README.legal boilerplate with SPDX

2023-09-18 Thread Geert Uytterhoeven
Get rid of the references to non-existent files by replacing the boilerplate with SPDX license identifiers. Signed-off-by: Geert Uytterhoeven Acked-by: Greg Ungerer --- v2: - Add Acked-by, - s/existant/existent/. --- arch/m68k/68000/entry.S | 7 ++- arch/m68k/bvme6000/config.c | 5 +--

Re: [PATCH] um,ethertap: refactor deprecated strncpy

2023-09-12 Thread Geert Uytterhoeven
rgs = nosetup_args; > > --- > base-commit: 2dde18cd1d8fac735875f2e4987f11817cc0bc2c > change-id: > 20230911-strncpy-arch-um-os-linux-drivers-ethertap_user-c-859160d13f59 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia3

Re: Build regressions/improvements in v5.19-rc1

2022-06-06 Thread Geert Uytterhoeven
On Mon, 6 Jun 2022, Geert Uytterhoeven wrote: Below is the list of build error/warning regressions/improvements in v5.19-rc1[1] compared to v5.18[2]. Summarized: - build errors: +9/-10 [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/f2906aa863381afb0015a9eb7fefad885d4e5a56/ (all

Re: [PATCH 1/2] mm: Fix struct page layout on 32-bit systems

2021-04-20 Thread Geert Uytterhoeven
dr(struct page *page, dma_addr_t addr) > +{ > + page->dma_addr[0] = addr; > + if (sizeof(dma_addr_t) > sizeof(unsigned long)) > + page->dma_addr[1] = addr >> 16 >> 16; ... but we do have upper_32_bits() for a 32-bi

Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI

2021-04-19 Thread Geert Uytterhoeven
Hi Andy, On Mon, Apr 19, 2021 at 4:14 PM Andy Shevchenko wrote: > On Mon, Apr 19, 2021 at 4:58 PM Andy Shevchenko > wrote: > > On Mon, Apr 19, 2021 at 4:54 PM Geert Uytterhoeven > > wrote: > > > > > In any case it's not true. We have the platform drivers

Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI

2021-04-19 Thread Geert Uytterhoeven
Hi Andy, On Mon, Apr 19, 2021 at 3:58 PM Andy Shevchenko wrote: > On Mon, Apr 19, 2021 at 4:54 PM Geert Uytterhoeven > wrote: > > On Mon, Apr 19, 2021 at 3:35 PM Andy Shevchenko > > wrote: > > > On Mon, Apr 19, 2021 at 4:02 PM Geert Uytterhoeven > > > wr

Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI

2021-04-19 Thread Geert Uytterhoeven
Hi Andy, On Mon, Apr 19, 2021 at 3:35 PM Andy Shevchenko wrote: > On Mon, Apr 19, 2021 at 4:02 PM Geert Uytterhoeven > wrote: > > On Thu, Apr 15, 2021 at 10:50 AM Andy Shevchenko > > wrote: > > > On Thu, Apr 15, 2021 at 3:43 AM Geert Uytterhoeven > > > wr

Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI

2021-04-19 Thread Geert Uytterhoeven
Hi Andy, On Thu, Apr 15, 2021 at 10:50 AM Andy Shevchenko wrote: > On Thu, Apr 15, 2021 at 3:43 AM Geert Uytterhoeven > wrote: > > On Wed, Apr 14, 2021 at 9:14 PM Andy Shevchenko > > wrote: > > > On Wed, Apr 14, 2021 at 08:55:21PM +0200, Geert Uytterhoeven wrote: &

Re: [PATCH V3 5/5] arm64: dts: renesas: beacon kits: Setup AVB refclk

2021-04-19 Thread Geert Uytterhoeven
Hi Adam, On Sat, Apr 17, 2021 at 3:54 PM Adam Ford wrote: > On Thu, Mar 4, 2021 at 2:04 AM Geert Uytterhoeven > wrote: > > On Wed, Feb 24, 2021 at 12:52 PM Adam Ford wrote: > > > The AVB refererence clock assumes an external clock that runs > > > > reference

Re: [PATCH V3 3/5] arm64: dts: renesas: Add fck to etheravb-rcar-gen3 clock-names list

2021-04-19 Thread Geert Uytterhoeven
On Wed, Feb 24, 2021 at 12:52 PM Adam Ford wrote: > The bindings have been updated to support two clocks, but the > original clock now requires the name fck. Add a clock-names > list in the device tree with fck in it. > > Signed-off-by: Adam Ford > Reviewed-by: Geert Uytterho

Build regressions/improvements in v5.12-rc8

2021-04-19 Thread Geert Uytterhoeven
et/bridge/br_vlan.c: warning: 'br_vlan_fill_vids' uses dynamic stack allocation: => 1672:1 + /kisskb/src/net/bridge/netfilter/ebtables.c: warning: 'compat_copy_everything_to_user' uses dynamic stack allocation: => 1791:1 + modpost: WARNING: modpost: Symbol info of v

Re: [RFC v1 PATCH 3/3] driver: update all the code that use soc_device_match

2021-04-19 Thread Geert Uytterhoeven
me drivers may be used on multiple platforms, some of them registering an SoC device, some of them not registering an SoC device. So there is no way to know the difference between "SoC device not registered, intentionally", and "SoC device not yet registered". soc_device_match()

Re: [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match returning -EPROBE_DEFER

2021-04-19 Thread Geert Uytterhoeven
c_bus_type.p && !early_soc_dev_attr) > + return ERR_PTR(-EPROBE_DEFER); > + > while (!ret) { > if (!(matches->machine || matches->family || > matches->revision || matches->soc_id)) Gr{oetje,eeting}s,

Re: [PATCH V2] mm: Define default value for FIRST_USER_ADDRESS

2021-04-19 Thread Geert Uytterhoeven
gt; makes it much cleaner with reduced code. > > The default FIRST_USER_ADDRESS here would be skipped in > when the given platform overrides its value via . > Signed-off-by: Anshuman Khandual > arch/m68k/include/asm/pgtable_mm.h | 1 - Acked-by: Geert Uytte

Re: [PATCH] net: ethernet: ravb: Fix release of refclk

2021-04-19 Thread Geert Uytterhoeven
lk") > Signed-off-by: Adam Ford Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I&#x

Re: [PATCH v2 5/6] kunit: mptcp: adhear to KUNIT formatting standard

2021-04-19 Thread Geert Uytterhoeven
est config patch when all other parts have entered mainline. Note that I would have made the same changes myself anyway, on -rc1 defconfig refresh. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In perso

Re: [PATCH v4 4/7] arm64: dts: renesas: r8a77970: Add csi40 port@0

2021-04-15 Thread Geert Uytterhoeven
t; > + > > port@1 { > > #address-cells = <1>; > > #size-cells = <0>; \ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.o

Re: [PATCH bpf-next v3 3/6] bpf: Add a bpf_snprintf helper

2021-04-15 Thread Geert Uytterhoeven
Hi Andrii, On Thu, Apr 15, 2021 at 12:58 AM Andrii Nakryiko wrote: > On Wed, Apr 14, 2021 at 11:30 AM Florent Revest wrote: > > On Wed, Apr 14, 2021 at 8:02 PM Geert Uytterhoeven > > wrote: > > > On Wed, Apr 14, 2021 at 9:41 AM Andrii Nakryiko > > > wrote:

Re: [PATCH] m68k: Remove unneeded semicolon

2021-04-15 Thread Geert Uytterhoeven
On Thu, Apr 15, 2021 at 5:15 AM Wan Jiabing wrote: > Fix the following coccicheck warning: > > ./arch/m68k/include/asm/sun3xflop.h:109:2-3: Unneeded semicolon > > Signed-off-by: Wan Jiabing Reviewed-by: Geert Uytterhoeven i.e. will queue in the m68k for-v5.14 branch. Gr

Re: [PATCH v3 1/5] dt-bindings: media: max9286: Define 'maxim,gpio-poc'

2021-04-15 Thread Geert Uytterhoeven
; > I would have written poc-gpio to match the order of the GPIO bindings > > syntax. > > > > That's what I had :) but then the property gets matched against the > gpio schema and I get complains because it expects a phandle as first > argument... Maybe ther

Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI

2021-04-14 Thread Geert Uytterhoeven
Hi Andy, On Wed, Apr 14, 2021 at 9:14 PM Andy Shevchenko wrote: > On Wed, Apr 14, 2021 at 08:55:21PM +0200, Geert Uytterhoeven wrote: > > On Wed, Apr 14, 2021 at 8:18 PM Andy Shevchenko > > wrote: > > > On Wed, Apr 14, 2021 at 08:06:18PM +0200, Geert Uytterhoeven wrote

Re: [PATCH 4/5] sh: Get rid of oprofile leftovers

2021-04-14 Thread Geert Uytterhoeven
On Wed, Apr 14, 2021 at 3:53 PM Marc Zyngier wrote: > perf_pmu_name() and perf_num_counters() are unused. Drop them. > > Signed-off-by: Marc Zyngier Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Lin

Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI

2021-04-14 Thread Geert Uytterhoeven
Hi Andy, On Wed, Apr 14, 2021 at 8:18 PM Andy Shevchenko wrote: > On Wed, Apr 14, 2021 at 08:06:18PM +0200, Geert Uytterhoeven wrote: > > On Wed, Apr 14, 2021 at 11:24 AM Yicong Yang > > wrote: > > > On 2021/4/13 20:26, Geert Uytterhoeven wrote: > > > > The

Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI

2021-04-14 Thread Geert Uytterhoeven
Hi Yicong, On Wed, Apr 14, 2021 at 11:24 AM Yicong Yang wrote: > On 2021/4/13 20:26, Geert Uytterhoeven wrote: > > The HiSilicon Kunpeng I2C controller is only present on HiSilicon > > Kunpeng SoCs, and its driver relies on ACPI to probe for its presence. > > Hence add depe

Re: [PATCH bpf-next v3 3/6] bpf: Add a bpf_snprintf helper

2021-04-14 Thread Geert Uytterhoeven
* and map_direct_value_addr is set. > > +*/ > > + fmt_map_off = fmt_reg->off + fmt_reg->var_off.value; > > + err = fmt_map->ops->map_direct_value_addr(fmt_map, &fmt_addr, > > + fmt_map_of

Re: [PATCH V4 2/2] net: ethernet: ravb: Enable optional refclk

2021-04-14 Thread Geert Uytterhoeven
Hi Adam, On Wed, Apr 14, 2021 at 3:08 PM Adam Ford wrote: > On Tue, Apr 13, 2021 at 2:33 AM Geert Uytterhoeven > wrote: > > On Mon, Apr 12, 2021 at 3:27 PM Adam Ford wrote: > > > For devices that use a programmable clock for the AVB reference clock, > > > the

Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI

2021-04-13 Thread Geert Uytterhoeven
Hi Andy, On Tue, Apr 13, 2021 at 4:41 PM Andy Shevchenko wrote: > On Tue, Apr 13, 2021 at 02:48:15PM +0200, Geert Uytterhoeven wrote: > > On Tue, Apr 13, 2021 at 2:37 PM Andy Shevchenko > > wrote: > > > On Tue, Apr 13, 2021 at 02:26:15PM +0200, Geert Uytterhoeven wrot

Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI

2021-04-13 Thread Geert Uytterhoeven
Hi Andy, On Tue, Apr 13, 2021 at 2:37 PM Andy Shevchenko wrote: > On Tue, Apr 13, 2021 at 02:26:15PM +0200, Geert Uytterhoeven wrote: > > The HiSilicon Kunpeng I2C controller is only present on HiSilicon > > Kunpeng SoCs, and its driver relies on ACPI to probe for its presence

[PATCH] spi: SPI_HISI_KUNPENG should depend on ARCH_HISI

2021-04-13 Thread Geert Uytterhoeven
r for Kunpeng SoCs") Signed-off-by: Geert Uytterhoeven --- drivers/spi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 1ffcad19c0562a39..7d438ad343598bb8 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig

[PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI

2021-04-13 Thread Geert Uytterhoeven
support. Fixes: d62fbdb99a85730a ("i2c: add support for HiSilicon I2C controller") Signed-off-by: Geert Uytterhoeven --- drivers/i2c/busses/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index b5b4e0

[PATCH] irqchip: APPLE_AIC should depend on ARCH_APPLE

2021-04-13 Thread Geert Uytterhoeven
("irqchip/apple-aic: Add support for the Apple Interrupt Controller") Signed-off-by: Geert Uytterhoeven --- drivers/irqchip/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index d3a14f304ec80caa..b165b3

Re: [PATCH V4 2/2] net: ethernet: ravb: Enable optional refclk

2021-04-13 Thread Geert Uytterhoeven
dev); > out_release: > + clk_disable_unprepare(priv->refclk); > free_netdev(ndev); > > pm_runtime_put(&pdev->dev); Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Li

Re: New 'make dtbs_check W=1' warnings

2021-04-12 Thread Geert Uytterhoeven
our pull requests for soc. > renesas/r8a774a1-beacon-rzg2m-kit.dt.yaml: csi2@feaa: ports: > 'port@0' is a required property [...] I've replied to these as a response to your PR reply, see https://lore.kernel.org/linux-renesas-soc/camuhmdwhlnxgbsjp7vkudx-ynr9rskfke5ge5q_taru6hp

Build regressions/improvements in v5.12-rc7

2021-04-12 Thread Geert Uytterhoeven
kb/src/net/bridge/br_vlan.c: warning: 'br_vlan_fill_vids' uses dynamic stack allocation: => 1672:1 + /kisskb/src/net/bridge/netfilter/ebtables.c: warning: 'compat_copy_everything_to_user' uses dynamic stack allocation: => 1767:1 + modpost: WARNING: modpost: Symbol info of

Re: [PATCH v2 1/1] serial: sh-sci: Respect deferred probe when getting IRQ

2021-04-12 Thread Geert Uytterhoeven
< ARRAY_SIZE(sci_port->irqs); ++i) { > > + sci_port->irqs[i] = platform_get_irq_optional(dev, i); > > + if (sci_port->irqs[i] < 0) > > + return sci_port->irqs[i]; > > + if (sci_port->irqs[i] =

Re: [PATCH] clk: renesas: rcar-usb2-clock-sel: Fix error handling in rcar_usb2_clock_sel_probe

2021-04-12 Thread Geert Uytterhoeven
ster: > + clk_hw_unregister(&priv->hw); The error path can be simplified by replacing the call to clk_register() by a call to devm_clk_register(), to match the style of the other initialization steps. > +pm_put: > + pm_runtime_put(dev); > + pm_runtime_disab

Re: [PATCH] kbuild: use ?= to assign CROSS_COMPILE by arch-Makefile

2021-04-12 Thread Geert Uytterhoeven
8k") no longer pick up the cross-compiler, but fall back to the native compiler, thus breaking the build. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversatio

Re: [PATCH] arch/m68k/kernel/sys_m68k: Add missing mmap_read_lock() to sys_cacheflush()

2021-04-12 Thread Geert Uytterhoeven
On Wed, Apr 7, 2021 at 10:00 PM Liam Howlett wrote: > When the superuser flushes the entire cache, the mmap_read_lock() is not > taken, but mmap_read_unlock() is called. Add the missing > mmap_read_lock() call. > > Signed-off-by: Liam R. Howlett Reviewed-by: Geert Uytterhoeven

Re: [PATCH 12/20] kbuild: m68k: use common install script

2021-04-07 Thread Geert Uytterhoeven
e the m68k-only version of the install script. > > Cc: Geert Uytterhoeven > Cc: linux-m...@lists.linux-m68k.org > Signed-off-by: Greg Kroah-Hartman Thanks for your patch! Acked-by: Geert Uytterhoeven I guess it would "work" with the version number, too. Gr{oetje,eet

Re: [PATCH 00/20] kbuild: unify the install.sh script usage

2021-04-07 Thread Geert Uytterhoeven
? With separate or appended DTB? Even on x86, the script will bail out with "Cannot find LILO." if you're using Grub. Anyway, having less of them is good. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@l

Re: [PATCH 4/9] sh: intc: Drop the use of irq_create_identity_mapping()

2021-04-06 Thread Geert Uytterhoeven
domain, irq)) > + continue; > > intc_irq_xlate_set(irq, vect->enum_id, d); > intc_register_irq(desc, d, vect->enum_id, irq); Otherwise this seems to work fine on real hardware (landisk) and qemu (rts7751r2d). I did verify that t

Re: [PATCH] media: VIDEO_IMX8_JPEG should depend on ARCH_MXC and not default to m

2021-04-06 Thread Geert Uytterhoeven
Hoi Hans, On Tue, Apr 6, 2021 at 11:24 AM Hans Verkuil wrote: > On 31/03/2021 10:17, Geert Uytterhoeven wrote: > > The i.MX8 QXP/QM integrated JPEG encoder/decoder is only present on > > Freescale/NXP i.MX8 QXP and QM SoCs. Hence add a dependency on > > ARCH_MXC, to pr

[PATCH v2] media: VIDEO_IMX8_JPEG should depend on ARCH_MXC and not default to m

2021-04-06 Thread Geert Uytterhoeven
t;default y" if CONFIG_MODULES is not enabled), as merely enabling CONFIG_COMPILE_TEST should not enable additional code. Fixes: 2db16c6ed72ce644 ("media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder") Signed-off-by: Geert Uytterhoeven --- v2: - Really drop the "default m&quo

Re: [PATCH v3 3/5] RISC-V: Improve init_resources

2021-04-06 Thread Geert Uytterhoeven
Hi Nick, On Tue, Apr 6, 2021 at 10:11 AM Nick Kossifidis wrote: > Hello Geert, > Στις 2021-04-06 10:19, Geert Uytterhoeven έγραψε: > > On Mon, Apr 5, 2021 at 10:57 AM Nick Kossifidis > > wrote: > >> * Kernel region is always present and we know where it is, no >

Re: [PATCH] m68k: mvme147, mvme16x: Don't wipe PCC timer config bits

2021-04-06 Thread Geert Uytterhoeven
"m68k: mvme16x: Handle timer counter overflow") > Reported-and-tested-by: Michael Pavone > Signed-off-by: Finn Thain Thanks, applying, and queueing in the m68k for-v5.13 branch. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linu

Re: [PATCH v3 3/5] RISC-V: Improve init_resources

2021-04-06 Thread Geert Uytterhoeven
region when called, so increase the > number of pre-allocated regions by one to be on the safe side > (reported and patched by Geert Uytterhoeven) > > Signed-off-by: Geert Uytterhoeven Where does this SoB come from? > Signed-off-by: Nick Kossifidis > --- a/arch/riscv/kernel/

Build regressions/improvements in v5.12-rc6

2021-04-05 Thread Geert Uytterhoeven
br_vlan.c: warning: 'br_vlan_fill_vids' uses dynamic stack allocation: => 1672:1 + /kisskb/src/net/bridge/netfilter/ebtables.c: warning: 'compat_copy_everything_to_user' uses dynamic stack allocation: => 1767:1 + modpost: WARNING: modpost: Symbol info of vmlinux is m

[PATCH] dt-bindings: fpga: fpga-region: Convert to sugar syntax

2021-04-02 Thread Geert Uytterhoeven
Using overlay sugar syntax makes the DTS files easier to read (and write). While at it, fix two build issues: - "/dts-v1/" and "/plugin/" must be separate statements. - Add a missing closing curly brace. Signed-off-by: Geert Uytterhoeven --- .../devicetree/bindings/

Re: [PATCH] zero-fill colormap in drivers/video/fbdev/core/fbcmap.c

2021-04-01 Thread Geert Uytterhoeven
ak bug reported by syzbot at: > https://syzkaller.appspot.com/bug?id=741578659feabd108ad9e06696f0c1f2e69c4b6e > > Reported-by: syzbot+47fa9c9c648b76530...@syzkaller.appspotmail.com > Signed-off-by: Phillip Potter Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH 2/3] tracing: Use pr_crit() instead of long fancy messages

2021-04-01 Thread Geert Uytterhoeven
Hi Steven, On Wed, Mar 31, 2021 at 3:40 PM Steven Rostedt wrote: > On Wed, 31 Mar 2021 11:31:03 +0200 > Geert Uytterhoeven wrote: > > > This reduces kernel size by ca. 0.5 KiB. > > If you are worried about size, disable tracing and it will go away > entirely. 0.5KiB

Re: [PATCH 2/2] m68k: remove meaningless EXTRA_LDFLAGS

2021-03-31 Thread Geert Uytterhoeven
Reviewed-by: Geert Uytterhoeven i.e. will queue in the m68k for-v5.13 branch. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker.

Re: [PATCH 1/2] m68k: remove meaningless $(OS_OBJS)

2021-03-31 Thread Geert Uytterhoeven
On Wed, Mar 31, 2021 at 4:44 PM Masahiro Yamada wrote: > 'git grep OS_OBJS' hits only this line. $(OS_OBJS) is just empty. Indeed. All other users were removed in 2002. > Signed-off-by: Masahiro Yamada Reviewed-by: Geert Uytterhoeven i.e. will queue in the m68k for-v5.13 b

[PATCH 0/3] Use pr_crit() instead of long fancy messages

2021-03-31 Thread Geert Uytterhoeven
rting level of such messages from KERN_WARNING to KERN_CRIT, and removes irrelevant text and graphics. It was made against linux-next, but applies to v5.12-rc5 with an offset for the last patch. Each of these patches reduces kernel size by ca. 0.5 KiB. Thanks for your comments! Geert Uytterhoev

  1   2   3   4   5   6   7   8   9   10   >