Hi Patrick,
On Wed, Aug 5, 2020 at 9:57 PM Patrick Riphagen wrote:
>
> The device added has an FTDI chip inside.
> The device is used to connect Xsens USB Motion Trackers.
>
> Signed-off-by: Patrick Riphagen
Now you've dropped the backport to stable. Just put
Cc: sta...@vger.kernel.org
just b
Almost there on the subject. Stuff between brackets is removed by git,
so you should rather use something like
[PATCH v2] staging: lirc: Clean up zilog error codes
On Wed, Jul 12, 2017 at 9:17 PM, Yves Lemée wrote:
> According the coding style guidelines, the ENOSYS error code must be returned
>
On Fri, Jun 30, 2017 at 8:39 PM, Mark Rogers wrote:
> Thank you for your feedback. I guess when making this patch I had the
> preferred coding style in mind, but didn't ask myself if making the code
> conform to it would truly improve readability.
>
> I agree with all of your comments. Do you thin
On Tue, Jul 11, 2017 at 7:57 PM, Yves Lemée wrote:
> According the coding style guidelines, the ENOSYS error code must be returned
> in case of a non existent system call. This code has been replaced with
> the ENOTTY error code indicating, a missing functionality.
>
> Signed-off-by: Yves Lemée
Hi,
Again, your subject is too generic.
On Wed, Jul 12, 2017 at 6:51 AM, Joseph Wright wrote:
> Declare private function static to fix sparse warning:
>
> ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
> was not declared. Should it be static?
>
> Signed-off-by: Joseph Wri
Hi,
please consider changing your subject to something like
staging: android/ion: declare two functions
Perhaps you can make it more on-topic. It's more useful than "fix
sparse warning"
On Wed, Jul 12, 2017 at 6:51 AM, Joseph Wright wrote:
> Declare functions to fix sparse warnings:
>
> ion_ca
On Mon, Jul 10, 2017 at 9:09 AM, AndyS wrote:
> Subject: [PATCH] Staging:ks7010:ks_wlan_net.c: unneeded type casting removed
[PATCH] staging: ks7010: remove unneeded type casting
> removed undesired type casting. Warning was raised by checkpatch.pl
> This patch is for eudyptula challenge
>
> Sig
On Mon, Jul 10, 2017 at 6:46 AM, Viresh Kumar wrote:
> Hi Mitchell,
>
> On 09-07-17, 20:25, Mitchell Tasman wrote:
>> Adjust formatting of various statements to keep line length within
>> the 80 column limit preferred by the Linux kernel coding style.
>
> We try to follow that most of the time, bu
Hi,
On Thu, Jul 6, 2017 at 3:49 AM, yash007 wrote:
> From: Yash Omer
Instead of resending the same thing every time, could you instead fix
your commit message and send a v2?
Also, where's patch 1 of 2?
>
> ---
> drivers/staging/dgnc/dgnc_neo.c | 10 +-
> 1 file changed, 5 insertions(
On Thu, Jul 6, 2017 at 9:13 AM, Jaya Durga wrote:
> Subject: Staging: lustre :lustre: include :lustre_compat.h: Prefer using the
> BIT macro
Don't overdo it ;-).
Subject: staging: lustre: lustre_compat.h: Prefer using the BIT macro
> Replace all instances of (1 << 27) with BIT(27) to fix
> che
On Thu, Jul 6, 2017 at 3:22 AM, yash007 wrote:
> From: Yash Omer
Your commit message is completely broken. Please fix it. See
Documentation/process/submitting-patches.rst chapter 14.
>
> ---
> drivers/staging/dgnc/dgnc_neo.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
On Fri, Jun 30, 2017 at 4:00 PM, Rik van Riel wrote:
> On Fri, 2017-06-30 at 06:10 -0700, tip-bot for Gustavo A. R. Silva
> wrote:
>
>> +++ b/kernel/sched/cputime.c
>> @@ -615,19 +615,13 @@ static void cputime_adjust(struct task_cputime
>> *curr,
>>* userspace. Once a task gets some ticks,
On Fri, Jun 30, 2017 at 6:52 AM, Mark Rogers wrote:
> Trivial style changes. There are still 3 "line over 80 characters"
> checkpatch.pl warnings, but I think they are best left alone as
> breaking the first two warning lines could hurt readability. The third
> warning is a message that should not
On Fri, Jun 30, 2017 at 6:42 AM, Gustavo A. R. Silva
wrote:
> Propagate the return values of platform_get_irq and
> devm_request_irq on failure.
>
> Signed-off-by: Gustavo A. R. Silva
> ---
> drivers/clocksource/em_sti.c | 9 +
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff -
On Thu, Jun 29, 2017 at 7:03 PM, Brian Masney wrote:
> tsl2x7x_i2c_read() would call i2c_smbus_write_byte() and
> i2c_smbus_read_byte(). These two i2c functions can be replaced with a
> single call to i2c_smbus_read_byte_data(). This patch removes the
> tsl2x7x_i2c_read() function and replaces all
On Tue, Jun 27, 2017 at 9:27 AM, Gilad Ben-Yossef wrote:
> Align block comments according to coding style.
>
> Signed-off-by: Gilad Ben-Yossef
> ---
> drivers/staging/ccree/cc_hw_queue_defs.h | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/ccree/c
On Thu, Jun 29, 2017 at 12:25 PM, Jaya Durga wrote:
> Fix checkpatch.pl issue
> WARNING: Use of volatile is usually wrong:
> see Documentation/process/volatile-considered-harmful.rst
Now I've only had a very quick look at the code using this. Could you
elaborate on why just removing the volatile
On Thu, Jun 29, 2017 at 1:30 PM, Mike Looijmans wrote:
> On 29-06-17 13:18, Frans Klaver wrote:
>>
>> On Thu, Jun 29, 2017 at 12:45 PM, Mike Looijmans
>> wrote:
>>>
>>> The LTC2741 and LTC2473 are single voltage monitoring chips. The LTC2473
>>>
On Thu, Jun 29, 2017 at 12:45 PM, Mike Looijmans
wrote:
> The LTC2741 and LTC2473 are single voltage monitoring chips. The LTC2473
> is similar to the LTC2471 but outputs a signed differential value.
>
> Datasheet:
> http://cds.linear.com/docs/en/datasheet/24713fb.pdf
>
> Signed-off-by: Mike Loo
On 29 June 2017 01:57:19 CEST, "Gustavo A. R. Silva"
wrote:
--- a/kernel/sched/cputime.c
+++ b/kernel/sched/cputime.c
@@ -637,9 +637,10 @@ static void cputime_adjust(struct task_cputime
>*curr,
*= (rtime_i+1 - rtime_i) + utime_i
*
On Wed, Jun 28, 2017 at 5:25 PM, John Garry wrote:
> From: Xiaofei Tan
>
> Currently we allocate 3 sets of DMA memories from separate
> pools for each slot. This is inefficient in terms of memory usage
> (buffers are less than 1 page in size, so we lose due to alignment),
> and also time spend in
Hi,
On Wed, Jun 28, 2017 at 2:50 PM, Simo Koskinen wrote:
> Fixed following warnings found by checkpatch.pl script:
>
> WARNING: Prefer using '"%s...", __func__' to using '',
> this function's name, in a string
>
> Signed-off-by: Simo Koskinen
> ---
> drivers/staging/rts5208/rtsx.c |
Hi,
On Wed, Jun 28, 2017 at 4:49 AM, Quytelda Kahja wrote:
> Replace the literal function name "visorbus_create_instance" with the format
> specifier "%s" so it can be dynamically filled by the __func__ macro.
On a general note, I think the actual change or effect is more import
to mention in th
On Wed, Jun 28, 2017 at 7:35 AM, Frans Klaver wrote:
> On Wed, Jun 28, 2017 at 1:03 AM, Gustavo A. R. Silva
> wrote:
>>
>> Hello everybody,
>>
>> While looking into Coverity ID 1371643 I ran into the following piece of
>> code at kernel/sched/cputime.c:568:
&g
On Wed, Jun 28, 2017 at 1:03 AM, Gustavo A. R. Silva
wrote:
>
> Hello everybody,
>
> While looking into Coverity ID 1371643 I ran into the following piece of
> code at kernel/sched/cputime.c:568:
>
> 568/*
> 569 * Adjust tick based cputime random precision against scheduler runtime
> 570 * account
quot;lightnvm: merge gennvm with core")
> Signed-off-by: Rakesh Pandit
Reviewed-by: Frans Klaver
> ---
>
> V3: Propagate return value from nvm_reserve_luns instead of hard-coding
> (Frans)
> V2: return error code directly instead of using ret variable (Frans)
>
> dr
On Tue, Jun 27, 2017 at 1:23 PM, Rakesh Pandit wrote:
> On Tue, Jun 27, 2017 at 01:01:22PM +0200, Frans Klaver wrote:
>> On Tue, Jun 27, 2017 at 12:43 PM, Rakesh Pandit wrote:
>> > While creating new device with NVM_DEV_CREATE if LUNs are already
>> > allocated ioctl
On Tue, Jun 27, 2017 at 12:43 PM, Rakesh Pandit wrote:
> While creating new device with NVM_DEV_CREATE if LUNs are already
> allocated ioctl would return -ENOMEM which is wrong. This patch
> propagates -EBUSY from nvm_reserve_luns which is correct response.
>
> Fixes: ade69e243 ("lightnvm: merge
On Tue, Jun 27, 2017 at 9:48 AM, Jaya Durga wrote:
> Fix checkpatch.pl warning of the form "CHECK" Macro argument 'x'
> may be better as '(x)' to avoid precedence issues.
>
> Signed-off-by: Jaya Durga
> ---
> drivers/staging/rtl8712/osdep_intf.h | 5 -
> 1 file changed, 4 insertions(+), 1 de
On Tue, Jun 27, 2017 at 10:39 AM, Matias Bjørling wrote:
> From: Rakesh Pandit
>
> While creating new device with NVM_DEV_CREATE if LUNs are already
> allocated ioctl would return -ENOMEM which is wrong. This patch
> propagates -EBUSY from nvm_reserve_luns which is correct response.
>
> Fixes: a
On Fri, Jun 23, 2017 at 07:37:28PM -0400, Julia Lawall wrote:
>
>
> On Sat, 24 Jun 2017, Frans Klaver wrote:
>
> > Hm. For some reason the great mail filtering scheme decided to push
> > this past my inbox :-/
> >
> > On Sat, Jun 17, 2017 at 12:44 AM, Joe P
Hi,
On Mon, Jun 26, 2017 at 2:20 PM, Corentin Labbe
wrote:
> The Security System have a PRNG, this patch add support for it via
> crypto_rng.
s,have,has,
s,add,adds,
>
> Signed-off-by: Corentin Labbe
> ---
>
> Changes since v3 (note: the v3 miss changes and version tag sorry)
> - Replaced all
On Mon, Jun 26, 2017 at 11:12 AM, Simo Koskinen wrote:
> On Fri, Jun 23, 2017 at 5:59 PM, Joe Perches wrote:
>> On Fri, 2017-06-23 at 15:55 +0200, Simo Koskinen wrote:
>>> Fixed some issues reported by checkpatch.pl script.
>> []
>>> diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/r
On Mon, Jun 26, 2017 at 11:11 AM, Geert Uytterhoeven
wrote:
> On Mon, Jun 26, 2017 at 7:45 AM, AbdAllah-MEZITI
> wrote:
>> This patch
>> - will always take the lock
>
> Why?
>
> "The current code only takes the lock if multiple instances are in use.
> This is error-prone, and confuses static ana
On Sat, Jun 24, 2017 at 1:37 AM, Julia Lawall wrote:
>
>
> On Sat, 24 Jun 2017, Frans Klaver wrote:
>
>> Hm. For some reason the great mail filtering scheme decided to push
>> this past my inbox :-/
>>
>> On Sat, Jun 17, 2017 at 12:44 AM, Joe Perches wrote:
&g
There's no version number. Which one is the correct one?
On Mon, Jun 26, 2017 at 7:45 AM, AbdAllah-MEZITI
wrote:
> This patch
> - will always take the lock
> - fix the sparse warning:
> drivers/staging/sm750fb/sm750.c:159:13: warning: context imbalance in
> 'lynxfb_ops_fillrect' - different lock
On Sun, Jun 25, 2017 at 11:39 PM, AbdAllah-MEZITI
wrote:
> Subject: [PATCH] staging: sm750fb: always take the lock
When sending a new version of your patch, include a version number:
Subject: [PATCH V2] staging: ...
Frans
On 25 June 2017 21:10:36 CEST, AbdAllah-MEZITI
wrote:
>This patch fixes the following sparce warnings: different lock contexts
>for basic block.
>
>drivers/staging/sm750fb//sm750.c:159:13: warning: context imbalance in
>'lynxfb_ops_fillrect' - different lock contexts for basic block
>drivers/st
On Fri, Jun 16, 2017 at 12:05 PM, Jaya Durga wrote:
> when building with make C=1 CF=-D__CHECK_ENDIAN__
>
> drivers/staging/wlan-ng/hfa384x_usb.c:3383:36: warning: cast to restricted
> __le16
>
> fixed by using the le16_to_cpus function.
>
> Signed-off-by: Jaya Durga
> ---
> drivers/staging/wla
Hm. For some reason the great mail filtering scheme decided to push
this past my inbox :-/
On Sat, Jun 17, 2017 at 12:44 AM, Joe Perches wrote:
> On Fri, 2017-06-16 at 19:45 +0200, Frans Klaver wrote:
>> The header field in struct pd_message is declared as an __le16 type. The
>&
benefit we don't get fishy results on big endian systems anymore.
Signed-off-by: Frans Klaver
---
drivers/staging/typec/fusb302/fusb302.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/typec/fusb302/fusb302.c
b/drivers/staging/typec/fusb302/
worked on the patch and modified commit message as per the
> recommendations from Frans Klaver and Greg K-H.
>
> - Patch was tested and built on next-20170609 and staging-testing.
> ---
> drivers/staging/wlan-ng/hfa384x.h| 18 +-
> drivers/staging/wla
On Mon, Jun 12, 2017 at 7:15 PM, wrote:
> From: Suniel Mahesh
>
> The following type mismatch warnings reported by sparse
> have been amended:
> warning: cast to restricted __le16
> warning: incorrect type in assignment (different base types)
Why not change the type of the struct fields to __le
adds value to the patch, as it's just for a personal
goal.
It is also custom to reply _below_ the (part of the) message you're
responding to by the way ;-).
Cheers,
Frans
> On 27/03/17 15:05, Frans Klaver wrote:
>> On Mon, Mar 27, 2017 at 1:52 PM, aviyae wrote:
>>> Fro
On Mon, Mar 27, 2017 at 1:52 PM, aviyae wrote:
> From: Aviya Erenfeld
>
> staging: goldfish: Fix style issues in macros
>
> Fix coding style issues in macros:
> 1. Add parenthesis around macros argument
> 2. Avoid arguments reuse in macros
>
> (For the eudyptula challenge)
How is that relevant?
On Thu, Mar 23, 2017 at 1:22 PM, Colin King wrote:
> From: Colin Ian King
>
> info is being checked to see if it is a null pointer, however, vpgu is
> dereferencing info before this check, leading to a potential null
> pointer dereference. If info is null, then the error message being
> printed
It appears that our coding style prefers that logical continuations
have the operator at the end of the line. Fix that.
While at it, stick the 'if' after 'else' where it belongs.
Signed-off-by: Frans Klaver
---
drivers/staging/wlan-ng/prism2mgmt.c | 11 +--
1 file c
On Tue, Aug 23, 2016 at 10:03 AM, Frans Klaver wrote:
> On Tue, Aug 23, 2016 at 9:05 AM, David Miller wrote:
>> From: Frans Klaver
>> Date: Tue, 23 Aug 2016 09:03:20 +0200
>>
>>> On Tue, Aug 23, 2016 at 1:30 AM, David Miller wrote:
>>>> From: Mikko Ra
On Tue, Aug 23, 2016 at 9:05 AM, David Miller wrote:
> From: Frans Klaver
> Date: Tue, 23 Aug 2016 09:03:20 +0200
>
>> On Tue, Aug 23, 2016 at 1:30 AM, David Miller wrote:
>>> From: Mikko Rapeli
>>> Date: Mon, 22 Aug 2016 20:32:44 +0200
>>>
>>&g
On Tue, Aug 23, 2016 at 1:30 AM, David Miller wrote:
> From: Mikko Rapeli
> Date: Mon, 22 Aug 2016 20:32:44 +0200
>
>> Fixes userspace compiler error:
>>
>> error: ‘IFNAMSIZ’ undeclared here (not in a function)
>>
>> Suggested by Frans Klaver
On Wed, Aug 17, 2016 at 3:53 PM, Heikki Krogerus
wrote:
> Hi,
>
> On Wed, Aug 17, 2016 at 03:14:03PM +0200, Frans Klaver wrote:
>> On Wed, Aug 17, 2016 at 12:34 PM, Heikki Krogerus
>> > +static const char * const typec_partner_types[] = {
>> > + [TYPE
On Wed, Aug 17, 2016 at 12:34 PM, Heikki Krogerus
wrote:
> The purpose of USB Type-C connector class is to provide
> unified interface for the user space to get the status and
> basic information about USB Type-C connectors on a system,
> control over data role swapping, and when the port supports
On Tue, Dec 29, 2015 at 3:06 PM, Sebastian Frias wrote:
> On 12/29/2015 02:49 PM, Frans Klaver wrote:
>>
>> On Tue, Dec 29, 2015 at 2:15 PM, Sebastian Frias wrote:
>>>
>>> Hi,
>>>
>>> We are wondering what is the recommended way of adding suppo
On Tue, Dec 29, 2015 at 2:15 PM, Sebastian Frias wrote:
> Hi,
>
> We are wondering what is the recommended way of adding support for a
> framebuffer driver on the Linux kernel.
> Below you can find a patch with a proposed solution.
That's not really a solution to add a driver to the kernel. You'd
On Thu, Dec 10, 2015 at 12:19 AM, Brian Norris
wrote:
> On Fri, Dec 04, 2015 at 09:42:06AM +0100, Heiko Schocher wrote:
>> It seems to me add_mtd_device() gets only called for the mtd partitions
>> parsed from the cmdline ...
>
> That's true, when CONFIG_MTD_PARTITIONED_MASTER=n. (I'm really think
On Fri, Dec 4, 2015 at 7:48 AM, Heiko Schocher wrote:
> Hello Frans,
>
> I just tried current mainline kernel:
> commit 2255702db4014d1c69d6037ed7bdad2d2e271985
> Merge: 9e5d25e c86576e
> Author: Linus Torvalds
> Date: Mon Nov 30 16:06:44 2015 -0800
>
> Merge tag 'mn10300-for-linus-v4.4-rc4
On Thu, Nov 12, 2015 at 9:53 AM, Uwe Kleine-König
wrote:
> CC += devicet...@vger.kernel.org, gregkh
You added linux@pengutronix instead of devicetree.
>
> On Thu, Nov 12, 2015 at 09:36:55AM +0100, Frans Klaver wrote:
>> On Thu, Nov 12, 2015 at 9:26 AM, Uwe Kleine-König
>>
On Thu, Nov 12, 2015 at 9:26 AM, Uwe Kleine-König
wrote:
> On Thu, Nov 12, 2015 at 09:03:11AM +0100, Frans Klaver wrote:
>> Hi,
>>
>> On Thu, Nov 12, 2015 at 8:46 AM, LABBE Corentin
>> wrote:
>> > of_match_device could return NULL, and so cause a NULL point
Hi,
On Thu, Nov 12, 2015 at 8:46 AM, LABBE Corentin
wrote:
> of_match_device could return NULL, and so cause a NULL pointer
> dereference later.
Did you actually run into this? It seems to me that this driver is
only probed if and only if we have a match and that therefore
of_match_device will a
Hi,
On Thu, Oct 15, 2015 at 7:56 AM, Mikko Rapeli wrote:
> And include linux/hdlc/ioctl.h from linux/if.h.
That appears to have already been the case before this patch. You just
add a comment behind the include statement.
> diff --git a/include/uapi/linux/if.h b/include/uapi/linux/if.h
> index
On Tue, Oct 13, 2015 at 7:37 PM, Brian Norris
wrote:
> On Wed, Jun 10, 2015 at 10:38:19PM +0200, Frans Klaver wrote:
>> Fix a bug where mtd parent device symlinks aren't shown in sysfs.
>>
>> Signed-off-by: Frans Klaver
>
> This is one of the patches that didn
On Tue, Sep 1, 2015 at 5:46 PM, Tony Lindgren wrote:
> * Frans Klaver [150828 03:14]:
>> From: Frans Klaver
>>
>> Fix the warning:
>> arch/arm/mach-omap2/vc.c:302:47: warning: logical ‘or’ of collectively
>> exhaustive tests is always true [-Wlogical-op]
>&g
From: Frans Klaver
Fix the warning:
arch/arm/mach-omap2/vc.c:302:47: warning: logical ‘or’ of collectively
exhaustive tests is always true [-Wlogical-op]
As we're toggling both CLKREQ and OFFMODE, we should also be checking
OFFMODE.
Signed-off-by: Frans Klaver
---
arch/arm/mach-omap2
On Thu, Aug 20, 2015 at 10:59 AM, yalin wang wrote:
> the copy_to_user() here expect can fix the fault on both kernel and
> user address, this is not true on other platforms except x86,
> change to user copy_in_user() so that can detect the page fault,
> work as expected.
Could you rephrase this
On Wed, Aug 19, 2015 at 12:00 PM, Sudip Mukherjee
wrote:
> On Tue, Aug 18, 2015 at 01:31:00PM -0300, Fabio Estevam wrote:
>> On Tue, Aug 18, 2015 at 12:18 PM, Sudip Mukherjee
>> wrote:
>> > According to the kernel coding style the NULL check should not be
>> > written as [variable] == NULL or [va
On Fri, Aug 14, 2015 at 11:42 AM, Adrian Remonda
wrote:
> This patch fixes the warning generated by sparse: "Using plain integer
> as NULL pointer" by replacing the offending 0 with NULL.
>
> Signed-off-by: Adrian Remonda
> ---
> v6: styling. Change the NULL test to comply with the Kernel coding
On Wed, Aug 12, 2015 at 1:19 PM, Pali Rohár wrote:
> On Wednesday 12 August 2015 11:12:49 Shah, Yash (Y.) wrote:
>> From: Yash Shah
>>
>> Fix line over 80 characters warning as detected by checkpatch.pl
>>
>> Signed-off-by: Yash Shah
>> ---
>> drivers/staging/media/bcm2048/radio-bcm2048.c | 3 +
On Mon, Aug 10, 2015 at 2:50 PM, Gwenn Bourree wrote:
> In order to prepare the submission of other functional
> patches, the checkpatch script has been applied and the
> reported issues have been solved.
Which warnings? Explain why these changes are an improvement. Just the
fact that checkpatch
On Fri, Jul 24, 2015 at 2:26 PM, Sebastian Reichel wrote:
> Hi,
>
> Thanks for the cleanup patch.
> I have a couple of comments inlined.
>
>> Subject: Re: [PATCH] power_supply: Adjust devm usage
>
> Please make this "power_supply: bq24735: ...".
>
> On Fri, Jul 24, 2015 at 05:28:13PM +0530, Vaisha
Hi,
On Fri, Jul 24, 2015 at 1:58 PM, Vaishali Thakkar
wrote:
> Use devm_kasprintf instead of kasprintf. Also, remove various
> gotos by direct returns and drop unneeded label err_free_name.
If there's to be a respin, reword this so that it becomes clearer that
removing the various gotos and the
Hi,
On Thu, Jul 23, 2015 at 8:20 AM, Incarnation P. Lee
wrote:
> drivers/staging/lustre/lustre/obdclass/cl_page.c
It is custom that you write slightly more introductory text here. Just
a file name is pointless.
The subject should probably contain [PATCH 0/5]. This would be
automatically fixed f
On Thu, Jul 23, 2015 at 8:21 AM, Noam Camus wrote:
> From: Peter Hurley [mailto:pe...@hurleysoftware.com]
> Sent: Wednesday, July 22, 2015 3:21 PM
>
>>>On 07/22/2015 05:34 AM, Noam Camus wrote:
>>> From: Noam Camus
>>>
>>> Add support for OF option "no-loopback-test"
>
>> Changes to devicetree ne
On 20 July 2015 21:42:39 CEST, Luis de Bethencourt
wrote:
>On Mon, Jul 20, 2015 at 09:54:56PM +0300, Dan Carpenter wrote:
>> On Mon, Jul 20, 2015 at 06:35:42PM +0200, Luis de Bethencourt wrote:
>> > Remove explicit true/false comparisons to bool variables.
>> >
>> > Signed-off-by: Luis de Bethen
Hi,
On Thu, Jul 16, 2015 at 8:17 AM, Incarnation P. Lee
wrote:
> Signed-off-by: Li Pan (Incarnation P. Lee)
>
> Fix one file coding sytle issue on linux-next-20150708, including macro
> aligned, missing blank lines after variable declarnation and brace missing
> in one line if structure.
Oh
On Wed, Jul 8, 2015 at 7:45 AM, Christophe JAILLET
wrote:
> Le 07/07/2015 19:04, Khalid Aziz a écrit :
>>
>> On 07/07/2015 02:45 AM, Frans Klaver wrote:
>>>
>>> On Tue, Jul 7, 2015 at 7:39 AM, Christophe JAILLET
>>> wrote:
>>>>
>>>
On Tue, Jul 7, 2015 at 1:53 PM, SF Markus Elfring
wrote:
>> I think that as far as these kernel mailing lists are concerned,
>> the date of the update suggestion is the date on which you submitted the
>> patch,
>> rather than the date you originally committed it to your local tree.
>
> I imagine
Can't seem to find the original, so here's a reply to the ack mail.
On Tue, Jul 7, 2015 at 10:49 AM, Sumit Saxena
wrote:
> -Original Message-
> From: Nicholas Krause [mailto:xerofo...@gmail.com]
> Sent: Monday, July 06, 2015 9:43 PM
> To: kashyap.de...@avagotech.com
> Cc: sumit.sax...@ava
On Tue, Jul 7, 2015 at 7:39 AM, Christophe JAILLET
wrote:
> Stop comparing the strings as soon as we know that they don't match.
>
> Signed-off-by: Christophe JAILLET
> ---
> drivers/scsi/FlashPoint.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/FlashP
On Tue, Jul 7, 2015 at 9:54 AM, SF Markus Elfring
wrote:
>> No need to try and preserve it.
>
> I find that it might occasionally help to share and keep the record
> on timestamps about the evolution for an original update suggestion.
I think that as far as these kernel mailing lists are concern
On Tue, Jul 7, 2015 at 8:21 AM, SF Markus Elfring
wrote:
>>> From: Markus Elfring
>>> Date: Sat, 27 Jun 2015 15:56:57 +0200
>>
>> Why is this in the body of the email?
>
> Does the canonical patch format support to preserve
> specific details about a shown commit by specification
> of fields like
Subject suggestion: "staging: android: uapi: remove unnecessary typedef"
That makes it immediately clear what the issue is.
On Wed, Jul 1, 2015 at 3:47 PM, Sohny Thomas wrote:
>
> As per checkpatch.pl remove unnecessary typedef
> Here ion_user_handle_t was used only in the header .
>
> Signed-o
On Wed, Jul 1, 2015 at 3:46 PM, Sohny Thomas wrote:
>
> - Fixed 80 char limit exceeding line
> and a newline after declarations as per checkpatch.pl
>
> Signed-of-by: Sohny Thomas
You can remove the dash, and fix the -off- typo (hint: use 'git commit
-s' for automating it). Maybe hint towards
On Wed, Jul 1, 2015 at 3:44 PM, Sohny Thomas wrote:
>
> - removed non-existent issue from TODO file
> kuid_t or uid_t not present in staging/android
>
> Signed-of-by: Sohny Thomas
s,-of-,-off-,
You can remove the leading dash (-). Could you elaborate on why this
issue is non existent?
Thanks,
On Wed, Jul 1, 2015 at 2:22 PM, Sohny Thomas wrote:
>
>
> On Wednesday 01 July 2015 05:37 PM, Frans Klaver wrote:
>> On Wed, Jul 1, 2015 at 1:56 PM, Sohny Thomas wrote:
>>> - removed non-existant issue from TODO file
>>
>> s,existant,existent,
> Thanks
On Wed, Jul 1, 2015 at 1:56 PM, Sohny Thomas wrote:
> - removed non-existant issue from TODO file
s,existant,existent,
> kuid_t or uid_t not present in staging/android
> - fixed 80 char limit exceeding line
> - a newline after decelartions as per checkpatch.pl
> - fixed an unnecessary typedef as
On Wed, Jul 1, 2015 at 8:25 AM, Pan Xinhui wrote:
> hello, Frans
> thanks for your reply :)
>
> On 2015年07月01日 14:17, Frans Klaver wrote:
>>
>> On Wed, Jul 1, 2015 at 6:15 AM, Pan Xinhui wrote:
>>>
>>>
>>> In __bitmap_parselist we can
On Wed, Jul 1, 2015 at 6:15 AM, Pan Xinhui wrote:
>
> In __bitmap_parselist we can accept whitespaces on head or tail
> during every parsing procedure.
> If input has valid ranges, there is no reason to reject the user.
>
> fixes are:
> 1) if input ends with ',', bit 0 might be set unexpectedly.
>
On Mon, Jun 29, 2015 at 10:18 PM, Ravi Teja Darbha wrote:
>
> Fix line over 80 characters warning.
>
> Signed-off-by: Ravi Teja Darbha
> ---
> drivers/staging/rtl8712/rtl8712_recv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl8712_recv.
On Tue, Jun 23, 2015 at 5:02 PM, Jeff Chua wrote:
> On Mon, Jun 22, 2015 at 11:36 PM, Greg Kroah-Hartman
> wrote:
>> On Mon, Jun 22, 2015 at 03:25:29PM +0800, Jeff Chua wrote:
>>>
>>> There's no need to wait for disk spin-up for USB SSD devices. This patch
>>> allow the SSD to skip waiting disk s
On Tue, Jun 23, 2015 at 3:59 PM, Luis de Bethencourt
wrote:
> On Tue, Jun 23, 2015 at 03:37:20PM +0200, Frans Klaver wrote:
>> On Tue, Jun 23, 2015 at 3:21 PM, Luis de Bethencourt
>> wrote:
>>
>> >> > if (dm_digtable.dig_algorithm_switch) {
>&
On Tue, Jun 23, 2015 at 3:44 PM, Dmitry Kalinkin
wrote:
>
>> On 23 Jun 2015, at 16:21, Frans Klaver wrote:
>>
>> You left one in the function declarations (vme_user_write).
>
> If you mean forward declarations, they are already gone in Greg’s tree:
> https://git.ke
On Tue, Jun 23, 2015 at 3:21 PM, Luis de Bethencourt
wrote:
>> > if (dm_digtable.dig_algorithm_switch) {
>> > @@ -3062,7 +3062,8 @@ static void dm_dynamic_txpower(struct net_device
>> > *dev)
>> > priv->bDynamicTxLowPower = false;
>> > } else {
>>
On Tue, Jun 23, 2015 at 2:42 PM, Dmitry Kalinkin
wrote:
> Signed-off-by: Dmitry Kalinkin
You left one in the function declarations (vme_user_write).
> ---
> drivers/staging/vme/devices/vme_user.c | 33 +
> 1 file changed, 17 insertions(+), 16 deletions(-)
>
> di
On Tue, Jun 23, 2015 at 2:52 PM, Luis de Bethencourt
wrote:
> Remove explicit true/false comparations to bool variables.
>
> Signed-off-by: Luis de Bethencourt
> ---
> drivers/staging/rtl8192u/r8192U_core.c | 7 ---
> drivers/staging/rtl8192u/r8192U_dm.c | 21 +++--
> 2 fi
On Tue, Jun 23, 2015 at 2:52 PM, Luis de Bethencourt
wrote:
> Remove explicit true/false comparations to bool variables.
>
> Signed-off-by: Luis de Bethencourt
> ---
> drivers/staging/rtl8192u/r8192U_core.c | 7 ---
> drivers/staging/rtl8192u/r8192U_dm.c | 21 +++--
> 2 fi
lse, rather than NULL. It's not a pointer (here).
>>
>>
>>> And also in funciton init_prb_bdqc there is no usage of tx_ring.
>>
>>s,funciton,function,
>
> Thanks for feedback , please check below changelog if it looks ok,
> Then i will share updated patch:-
ring.
s,funciton,function,
> Thus removing tx_ring from init_prb_bdqc.
>
> Signed-off-by: Maninder Singh
> Suggested-by: Frans Klaver
> ---
> net/packet/af_packet.c | 14 +-
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/net/packet/af_pa
On Fri, Jun 19, 2015 at 12:31 PM, Krzysztof Hałasa wrote:
> Frans Klaver writes:
>
>>> #define REG8_1(a0) ((const u16[8]){a0, a0 + 1, a0 + 2, a0 + 3})
>>>
>>> vs
>>>
>>> #define REG8_1(a0) ((const u16[8]) {a0, a0 + 1, a0 + 2, a0 + 3})
Hi,
On Fri, Jun 19, 2015 at 10:35 AM, Krzysztof Hałasa wrote:
> Hi,
>
> a simple question: which style is preferred?
>
> #define REG8_1(a0) ((const u16[8]){a0, a0 + 1, a0 + 2, a0 + 3})
>
> vs
>
> #define REG8_1(a0) ((const u16[8]) {a0, a0 + 1, a0 + 2, a0 + 3})
> ^^
On Thu, Jun 18, 2015 at 1:54 PM, Guenter Roeck wrote:
> On 06/17/2015 11:53 PM, Frans Klaver wrote:
>>
>> On Thu, Jun 18, 2015 at 3:04 AM, Stephen Boyd
>> wrote:
>>>
>>> On 10/06/2014 10:28 PM, Guenter Roeck wrote:
>>>>
>>>> Various
1 - 100 of 500 matches
Mail list logo
