On Fri, Jul 24, 2015 at 2:26 PM, Sebastian Reichel <s...@kernel.org> wrote: > Hi, > > Thanks for the cleanup patch. > I have a couple of comments inlined. > >> Subject: Re: [PATCH] power_supply: Adjust devm usage > > Please make this "power_supply: bq24735: ...". > > On Fri, Jul 24, 2015 at 05:28:13PM +0530, Vaishali Thakkar wrote: >> Use devm_kasprintf instead of kasprintf. Also, remove various >> gotos by direct returns and drop unneeded label err_free_name. > > Please also use devm_power_supply_unregister() instead > of power_supply_unregister() to further simplify the driver.
Sounds like a separate patch. Frans -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/