Indeed, Miklos, changing layers dynamically is VERY tricky. Unionfs supports
that, but a good amount of its code all over is dedicated to handling dynamic
layer changes. I advise you to avoid supporting this feature for a while, if
ever: get a small, functional, working overlayfs first.
I per
I tend to agree with Al's and Linus's POV regarding whiteouts. There are three
general techniques to implementing whiteouts:
1. namespace: special file names, hard/symlinks, or special "hidden" dot files.
2. extended attributes.
3. DT_WHT dirent flags.
(there's actually a 4th method I've tried be
In message <[EMAIL PROTECTED]>, Christoph Hellwig writes:
> On Sun, Feb 17, 2008 at 10:18:42AM +0200, Adrian Bunk wrote:
> > This patch makes the needlessly global vfs_ioctl() static.
>
> I think the point was toa eventually export it for stackable filesystem
> use. But until they start using it
In message <[EMAIL PROTECTED]>, Hugh Dickins writes:
> Hi Erez,
>
> Aside from the occasional "unionfs: new lower inode mtime" messages
> on directories (which I've got into the habit of ignoring now), the
> only problem I'm still suffering with unionfs over tmpfs (not tested
> any other fs's bel
Ensure that we lock the branch configuration of parent and child dentries in
operations which need it, and in the right order.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/commonfops.c | 31 +---
fs/unionfs/dentry.c | 26 +-
error incurred when getting the root inode
instead of EINVAL.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/main.c | 11 +--
fs/unionfs/super.c | 19 +++
Dentry branch configuration "info node" lock should extend to calls to
copy_attr_times.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/commonfops.c | 14 --
1 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/fs/unionfs/commonfop
From: Andrew Morton <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/inode.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/unionfs/inode.c b/fs/unionfs/ino
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/dentry.c | 13 -
1 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c
index a956b94..f8f65e1 100644
--- a/fs/unionfs/dentry.c
+++ b/fs/unionfs/dentry.c
@@ -410,15 +
This is not strictly necessary, but it helps quiet a gcc-4.2 warning (a good
optimizer may optimize this initialization away).
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
Signed-off-by: Josef 'Jeff' Sipek <[EMAIL PROTECTED]>
---
fs/unionfs/inode.c |2 +-
1 files chang
To be used by rest of revalidation code, as well a callers who already
locked the child and parent dentry branch-configurations.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/dentry.c | 87 +++---
fs/unionfs/union.h |3 ++
2
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/subr.c |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/fs/unionfs/subr.c b/fs/unionfs/subr.c
index 68a6280..1a40f63 100644
--- a/fs/unionfs/subr.c
+++ b/fs/unionfs/subr.c
@@ -247,8 +247,14 @
lunck <[EMAIL PROTECTED]>
Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]>
Acked-by: Christoph Hellwig <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/main.c |2 +-
fs/unionfs/supe
Remove unnecessary calls to update branch m/ctimes, and use them only when
needed. Update branch vfsmounts after operations that could cause a copyup.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/commonfops.c |9 +++--
fs/unionfs/copyup.c |3 ++-
fs/u
This reduces text size by about 6k.
Cc: Hugh Dickins <[EMAIL PROTECTED]>
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/fanout.h | 50 --
fs/unionfs/subr.c | 50 ++
Remove unionfs's versions thereof.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/main.c | 10 +-
fs/unionfs/super.c| 27 ++-
include/linux/namei.h | 12
3 files changed, 19 insertions(+), 30 deletions(-)
diff
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/dentry.c | 55 --
1 files changed, 35 insertions(+), 20 deletions(-)
diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c
index cd15243..afa2120 100644
--- a/fs/unionfs/dentry.c
ROTECTED]>
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/lookup.c | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/fs/unionfs/lookup.c b/fs/unionfs/lookup.c
index b9ee072..755158e 100644
--- a/fs/unionfs/lookup.c
+++ b/fs/unionfs/lookup.c
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/inode.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c
index 8d939dc..6377533 100644
--- a/fs/unionfs/inode.c
+++ b/fs/unionfs/inode.c
@@ -820,7 +820,11 @@
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
Documentation/filesystems/unionfs/concepts.txt | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/Documentation/filesystems/unionfs/concepts.txt
b/Documentation/filesystems/unionfs/concepts.txt
index b
This prevents the lower super_block from being destroyed too early, when a
lower file system is being unmounted with MNT_FORCE or MNT_DETACH.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/main.c |3 +++
fs/unionfs/super.c | 14 ++
fs/unionfs/union.h |2
Morton (1):
Unionfs: embed a struct path into struct nameidata instead of nd dentrymnt
David Howells (1):
Unionfs: stop using iget() and read_inode()
Erez Zadok (14):
Unionfs: grab lower super_block references
Unionfs: ensure consistent lower inodes types
Unionfs: documen
* [fs] Error 2
The following small patch fixes it for me.
Cheers,
Erez.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
index 02223e2..a57b024 100644
--- a/fs/sysfs/file.c
+++ b/fs/sysfs/file.c
@@ -329,9 +329,11 @@ static int sysfs_open_file
Using mmotm-2008-02-15-11-03, I get
$ make ARCH=i386
HOSTCC scripts/kconfig/conf.o
HOSTCC scripts/kconfig/kxgettext.o
HOSTCC scripts/kconfig/zconf.tab.o
HOSTLD scripts/kconfig/conf
scripts/kconfig/conf -s arch/x86/Kconfig
arch/x86/Kconfig:24: unknown option "HEAD"
arch/x86/Kconfig:30:
In message <[EMAIL PROTECTED]>, Sam Ravnborg writes:
> On Thu, Feb 14, 2008 at 03:54:04PM -0500, Erez Zadok wrote:
> > Using: v2.6.25-rc1-120-ge760e71
> >
> > In a normal compilation, I might this message:
> >
> > ...
> > MODPOST vmlinux.o
>
e, passing CONFIG_DEBUG_SECTION_MISMATCH=y on the
command line, but I can't turn on the option in my .config. That's because
the option depends on "UNDEFINED". (Was that an attempt to "hide" the
option? Why?) The following small patch allows me to set the option in my
.config.
Ch
In message <[EMAIL PROTECTED]>, Christoph Hellwig writes:
> - remove non-standard in/out markers
> - use tabs for formatting
>
>
> Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]>
>
> Index: linux-2.6/fs/ioctl.c
> ===
> --- li
In message <[EMAIL PROTECTED]>, Al Viro writes:
> On Sat, Jan 26, 2008 at 12:08:30AM -0500, Erez Zadok wrote:
[concerns about lower directories moving around...]
> You are thinking about non-interesting case. _Files_ are not much
> of a problem. Directory tree is. The real pr
In message <[EMAIL PROTECTED]>, Hugh Dickins writes:
> Hi Erez,
>
> Aside from the occasional "unionfs: new lower inode mtime" messages
> on directories (which I've got into the habit of ignoring now), the
> only problem I'm still suffering with unionfs over tmpfs (not tested
> any other fs's belo
In message <[EMAIL PROTECTED]>, Al Viro writes:
> After grep for locking-related things:
>
> * lock_parent(): who said that you won't get dentry moved
> before managing to grab i_mutex on parent? While we are at it,
> who said that you won't get dentry moved between fetching d_parent
> and
CC: Mike Halcrow <[EMAIL PROTECTED]>
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/rename.c | 16 +++-
1 files changed, 15 insertions(+), 1 deletions(-)
diff --git a/fs/unionfs/rename.c b/fs/unionfs/rename.c
index 9306a2b..5ab13f9 100644
--- a/fs/unio
This old code was to fix a bug which has long since been fixed in our
copyup_permission and unionfs_d_iput.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/copyup.c | 13 -
1 files changed, 0 insertions(+), 13 deletions(-)
diff --git a/fs/unionfs/copyup.c b/fs/u
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/copyup.c |3 +--
fs/unionfs/union.h |4 ++--
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/unionfs/copyup.c b/fs/unionfs/copyup.c
index 8663224..9beac01 100644
--- a/fs/unionfs/copyup.c
+++ b/fs/u
Cleanup code in ->create, ->symlink, and ->mknod: refactor common code into
helper functions. Also, this allows writing to multiple branches again,
which was broken by an earlier patch.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs
/kernel/git/ezk/unionfs.git
to receive the following:
Erez Zadok (4):
Unionfs: use first writable branch (fix/cleanup)
Unionfs: remove unnecessary call to d_iput
Unionfs: d_parent related locking fixes
Unionfs: lock_rename related locking fixes
copyup.c | 16 --
In message <[EMAIL PROTECTED]>, Miklos Szeredi writes:
> From: Miklos Szeredi <[EMAIL PROTECTED]>
>
> This series addresses the problem of showing mount options in
> /proc/mounts.
>
> Several filesystems which use mount options, have not implemented a
> .show_options superblock operation. Severa
In message <[EMAIL PROTECTED]>, Jan Engelhardt writes:
>
> On Jan 23 2008 10:29, Matt Helsley wrote:
> >
> >For executables on the stackable MVFS filesystem the current procfs
> >methods for implementing a task's exe symlink do not point to the
> >correct file and applications relying on the symli
In message <[EMAIL PROTECTED]>, =?utf-8?B?SsO2cm4=?= Engel writes:
[...]
> Patch didn't compile due to function ordering. Here is an updated version.
Joern/Peter, I've tested this updated patch with v2.6.24-rc8-74-ga7da60f.
It worked fine for me.
Thanks,
Erez.
> Acked-and-tested-by: Joern Engel
In message <[EMAIL PROTECTED]>, Al Viro writes:
> After grep for locking-related things:
[...]
Thanks. I'll start looking at these issues asap.
Erez.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at h
In message <[EMAIL PROTECTED]>, Michael Halcrow writes:
> On Thu, Jan 10, 2008 at 10:57:46AM -0500, Erez Zadok wrote:
[...]
> Would the inclusion of Unionfs in mainline really slow down or damage
> the union mount effort? If not, then I think the pragmatic approach
> would be to
[I recommend we direct future discussions in this thread to the unionfs
ML. -ezk]
In message <[EMAIL PROTECTED]>, Paul Albrecht writes:
[...]
> I'm not sure we're talking about the same problem. What I do is union
> mount a write enabled file system like tmpfs over a read only file
> system like s
In message <[EMAIL PROTECTED]>, Paul Albrecht writes:
> Hi,
>
> I have a question about how unionfs handles file deletion when a write
> enabled file system is union mounted over a read only file system. For
> example, I do something like the following:
>
> mount -t unionfs -o dirs=/cow=rw:/rofs=
In message <[EMAIL PROTECTED]>, Christoph Hellwig writes:
> On Thu, Jan 10, 2008 at 09:59:19AM -0500, Erez Zadok wrote:
> >
> > Dear Linus, Al, Christoph, and Andrew,
> >
> > As per your request, I'm posting for review the unionfs code (and related
&g
Includes read_inode, delete_inode, put_super, statfs, remount_fs (which
supports branch-management ops), clear_inode, alloc_inode, destroy_inode,
write_inode, umount_begin, and show_options.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/super.c
Includes lower nameidata support routines.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/lookup.c | 652 +++
1 files changed, 652 insertions(+), 0 deletions(-)
create mode 100644 fs/unionfs/lookup.c
diff --git a/fs/u
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/union.h | 602
1 files changed, 602 insertions(+), 0 deletions(-)
create mode 100644 fs/unionfs/union.h
diff --git a/fs/unionfs/union.h b/fs/unionfs/union.h
new file mode
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/xattr.c | 153
1 files changed, 153 insertions(+), 0 deletions(-)
create mode 100644 fs/unionfs/xattr.c
diff --git a/fs/unionfs/xattr.c b/fs/unionfs/xattr.c
new file mode
Includes open, ioctl, and flush operations.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/commonfops.c | 835 +++
1 files changed, 835 insertions(+), 0 deletions(-)
create mode 100644 fs/unionfs/commonfops.c
diff --git a/fs/u
Includes d_release methods and cache-coherency support for dentries.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/dentry.c | 548 +++
1 files changed, 548 insertions(+), 0 deletions(-)
create mode 100644 fs/unionfs/dentry.c
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/dirfops.c | 290 ++
1 files changed, 290 insertions(+), 0 deletions(-)
create mode 100644 fs/unionfs/dirfops.c
diff --git a/fs/unionfs/dirfops.c b/fs/unionfs/dirfops.c
new fil
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
include/linux/union_fs.h | 24
1 files changed, 24 insertions(+), 0 deletions(-)
create mode 100644 include/linux/union_fs.h
diff --git a/include/linux/union_fs.h b/include/linux/union_fs.h
new file mode 100644
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/debug.c | 533
1 files changed, 533 insertions(+), 0 deletions(-)
create mode 100644 fs/unionfs/debug.c
diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c
new file mode
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/rename.c | 531 +++
1 files changed, 531 insertions(+), 0 deletions(-)
create mode 100644 fs/unionfs/rename.c
diff --git a/fs/unionfs/rename.c b/fs/unionfs/rename.c
new file mode
Includes read_super and module-linkage routines.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/main.c | 794 +
1 files changed, 794 insertions(+), 0 deletions(-)
create mode 100644 fs/unionfs/main.c
diff --git a/fs/u
Needed to release the resources of the lower nameidata structures that we
create and pass to lower file systems (e.g., when calling vfs_create).
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/namei.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/namei.
Includes whiteout handling for directories.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/dirhelper.c | 267
1 files changed, 267 insertions(+), 0 deletions(-)
create mode 100644 fs/unionfs/dirhelper.c
diff --git a/fs/u
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
include/linux/magic.h |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/linux/magic.h b/include/linux/magic.h
index 1fa0c2c..67043ed 100644
--- a/include/linux/magic.h
+++ b/include/linux/magic.h
@@ -35,6
Includes create, lookup, link, symlink, mkdir, mknod, readlink, follow_link,
put_link, permission, and setattr.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/inode.c | 1174
1 files changed, 1174 insertions(+), 0 del
Includes writepage, writepages, readpage, prepare_write, and commit_write.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/mmap.c | 343 +
1 files changed, 343 insertions(+), 0 deletions(-)
create mode 100644 fs/unionfs/
Mostly related to whiteouts.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/subr.c | 242 +
1 files changed, 242 insertions(+), 0 deletions(-)
create mode 100644 fs/unionfs/subr.c
diff --git a/fs/unionfs/subr.c b/fs/u
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/fanout.h | 366 +++
1 files changed, 366 insertions(+), 0 deletions(-)
create mode 100644 fs/unionfs/fanout.h
diff --git a/fs/unionfs/fanout.h b/fs/unionfs/fanout.h
new file mode
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/sioq.c | 119 +
fs/unionfs/sioq.h | 92 +
2 files changed, 211 insertions(+), 0 deletions(-)
create mode 100644 fs/unionfs/sioq.c
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/Makefile | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
create mode 100644 fs/unionfs/Makefile
diff --git a/fs/unionfs/Makefile b/fs/unionfs/Makefile
new file mode 100644
index 000..17ca4a7
--- /de
Includes read, write, mmap, fsync, and fasync.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/file.c | 184 +
1 files changed, 184 insertions(+), 0 deletions(-)
create mode 100644 fs/unionfs/file.c
diff --git a/fs/u
Includes duplicate name elimination and whiteout-handling code.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/rdstate.c | 285 ++
1 files changed, 285 insertions(+), 0 deletions(-)
create mode 100644 fs/unionfs/rdstate.c
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/Kconfig | 53 +
1 files changed, 41 insertions(+), 12 deletions(-)
diff --git a/fs/Kconfig b/fs/Kconfig
index 487236c..55a78b7 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -1041,6 +1
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/Makefile |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/Makefile b/fs/Makefile
index 500cf15..e202288 100644
--- a/fs/Makefile
+++ b/fs/Makefile
@@ -118,3 +118,4 @@ obj-$(CONFIG_HPPFS) += hppfs
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/unlink.c | 251 +++
1 files changed, 251 insertions(+), 0 deletions(-)
create mode 100644 fs/unionfs/unlink.c
diff --git a/fs/unionfs/unlink.c b/fs/unionfs/unlink.c
new file mode
Includes index files, MAINTAINERS, and documentation on general concepts,
usage, issues, and renaming operations.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
Documentation/filesystems/00-INDEX |2 +
Documentation/filesystems/unionfs/00-INDEX | 10 +
Documen
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/copyup.c | 899 +++
1 files changed, 899 insertions(+), 0 deletions(-)
create mode 100644 fs/unionfs/copyup.c
diff --git a/fs/unionfs/copyup.c b/fs/unionfs/copyup.c
new file mode
Note: this will become obsolete once similar patches, now in -mm, make it to
mainline.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
include/linux/namei.h | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/include/linux/namei.h b/include/linux/namei.h
Acked-by: Mike Halcrow <[EMAIL PROTECTED]>
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/ecryptfs/dentry.c |2 +-
fs/ecryptfs/inode.c |6 +++---
fs/ecryptfs/main.c |2 +-
fs/stack.c | 38 --
i
a merge could be that we'd have more
than one stackable f/s in the kernel (i.e., ecryptfs and unionfs); this
would allow us to slowly and gradually generalize the VFS so it can better
support stackable file systems.
Lastly, shortlog and diffstats:
Erez Zadok (29):
Unionfs: documentation
CC: Joe Perches <[EMAIL PROTECTED]>
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/debug.c | 51 +--
1 files changed, 25 insertions(+), 26 deletions(-)
diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c
index 5f1d
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/dentry.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c
index d969640..cd15243 100644
--- a/fs/unionfs/dentry.c
+++ b/fs/unionfs/dentry.c
@@ -507,9 +507,10 @@
Ensure we have lower inodes in prepare/commit_write.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/mmap.c | 26 +-
1 files changed, 21 insertions(+), 5 deletions(-)
diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c
index a0e654b..ad770ac 100644
--
Add necessary locking to dentry/inode branch-configuration, so we get
consistent values during branch-management actions. In d_revalidate_chain,
->permission, and ->create, also lock parent dentry.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/commonfops.c |
to receive the following:
Erez Zadok (4):
Unionfs: merged several printk KERN_CONT together into one pr_debug
Unionfs: mmap fixes
Unionfs: branch-management related locking fixes
Unionfs: ensure we have lower dentries in d_iput
commonfops.c |6 ++
debu
n
as a maintainer. Perhaps an update?
If you get a patch, I'd love to test it.
> On Sun, 6 January 2008 02:17:32 -0500, Erez Zadok wrote:
[...]
> > In lieu of a better fix, is this patch acceptable?
>
> Not for me. I don't mind if you keep such a hack until a proper
> solut
lieu of a better fix, is this patch acceptable?
Thanks,
Erez.
--
block2mtd: defer mutex initialization to avoid a lockdep warning
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
diff --git a/drivers/mtd/devices/block2mtd.c b/drivers/mtd/devices/block2mtd.c
index be4b994..2c6d3e7 100644
--- a/dr
In message <[EMAIL PROTECTED]>, Joe Perches writes:
> On Thu, 2008-01-03 at 00:57 -0500, Erez Zadok wrote:
> I think printks should be single statements and
> KERN_CONT should be used as sparingly as possible.
[...]
KERN_CONT is documented as not being SMP safe, but I figured it w
Lock parent dentries during revalidation.
Reduce total number of lockdep classes used.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/dentry.c | 13 -
fs/unionfs/fanout.h |3 ++-
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/fs/unionfs/dent
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/unlink.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/unionfs/unlink.c b/fs/unionfs/unlink.c
index a1c82b6..1e370a1 100644
--- a/fs/unionfs/unlink.c
+++ b/fs/unionfs/unlink.c
@@ -79,7 +79,7 @@ stat
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/debug.c | 50 ++
1 files changed, 26 insertions(+), 24 deletions(-)
diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c
index c2b8b58..5f1d887 100644
--- a/fs/unionfs/debug.c
++
back-ported
unionfs code.
Please pull from the 'master' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/ezk/unionfs.git
to receive the following:
Erez Zadok (3):
Unionfs: use printk KERN_CONT for debugging messages
Unionfs: locking fixes
Unionfs: use VFS helper
In message <[EMAIL PROTECTED]>, Hugh Dickins writes:
> Here's a few patches to unionfs, which together with the tmpfs
> patches I just posted, get that combination working better.
>
> fs/stack.c |6 +++
> fs/unionfs/inode.c | 83 +--
> fs/unio
i_size_read() takes 'const struct inode *' already, as of 2.6.20.
CC: Mike Halcrow <[EMAIL PROTECTED]>
Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]>
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/stack.c |2 +-
1 files changed, 1 insertions(+), 1 d
CC: Michael Tokarev <[EMAIL PROTECTED]>
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
Documentation/filesystems/unionfs/concepts.txt | 20 +---
Documentation/filesystems/unionfs/issues.txt |2 +-
Documentation/filesystems/unionfs/usage.txt| 13
;t even use i_size_read or
i_size_write to access the inode's size.
CC: Mike Halcrow <[EMAIL PROTECTED]>
Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]>
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/stack.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
d
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/inode.c |7 ---
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c
index 7ec9c1b..3df9b19 100644
--- a/fs/unionfs/inode.c
+++ b/fs/unionfs/inode.c
@@ -32,13 +32,6 @@ stat
-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/inode.c | 210 +++
1 files changed, 95 insertions(+), 115 deletions(-)
diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c
index 8076d0b..78cdfa2 100644
--- a/fs/unionfs/inode.c
+++ b/fs/u
This was intended to protect the inode during branch management, but that is
now done through our superblock rwsem.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/dentry.c | 13 -
1 files changed, 0 insertions(+), 13 deletions(-)
diff --git a/fs/unionfs/dentry.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/inode.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c
index df6138a..740d364 100644
--- a/fs/unionfs/inode.c
+++ b/fs/unionfs/inode.c
@@ -158,9 +158,9
Lockdep fixes. Support locking order/classes (e.g., parent -> child ->
whiteout). Remove locking from create_parents: it's enough to just dget the
dentries in question. Move parent locking to from lookup_backend to caller,
unionfs_lookup.
Signed-off-by: Erez Zadok <[EMAIL PROTE
Lockdep complained, because we eventually call vfs_unlink which'd grab the
necessary locks.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/dirhelper.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/fs/unionfs/dirhelper.c b/fs/unionfs/dirhel
upper level first when expanding, in the case when
the upper level's s_maxbytes is more limiting than the lower level's.
Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]>
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/inode.c | 97 ++-
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/unlink.c | 11 +--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/fs/unionfs/unlink.c b/fs/unionfs/unlink.c
index 1e81494..a1c82b6 100644
--- a/fs/unionfs/unlink.c
+++ b/fs/unionfs/unlink.c
@@ -91,7
This is needed to drop lower objects early enough, under certain conditions,
so the lower objects don't stay behind until umount(). [LTP testing]
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/dentry.c | 42 ++
1 files
To avoid too much code nesting.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/rename.c | 83 --
1 files changed, 40 insertions(+), 43 deletions(-)
diff --git a/fs/unionfs/rename.c b/fs/unionfs/rename.c
index 824c285..1
Parent dentries may not be locked and may change, so don't check them. But
do check parent inodes if they are passed to the method. Also, ensure the
checks are done only if no error occurred.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/commonfops.c |1 -
fs/uni
1 - 100 of 405 matches
Mail list logo