RE: [PATCH] iio:st_pressure:initial lps22hh sensor support

2019-01-14 Thread Denis CIOCCA
Acked-by: Denis Ciocca -Original Message- From: linux-iio-ow...@vger.kernel.org On Behalf Of Mario Tesi Sent: Monday, January 14, 2019 9:24 AM To: ji...@kernel.org Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Mario TESI Subject: [PATCH] iio:st_pressure:initial

RE: [PATCH] iio: st_sensors: Fix the sleep time for sampling

2018-11-19 Thread Denis CIOCCA
Hi Jian, Not clear to me why should be + instead of *. ODR is expressed in Hz, so (1/Hz) = period in seconds (1 sample sampling time) [s] 1000 * (1/Hz) = period in milliseconds (1 sample sampling time) [ms] n * 1000 * (1/Hz) = n times period in milliseconds (n times sample sampling time) [ms]

Re: [RFC] iio: st: Add lsm9ds0 support for gyro accel and magny

2016-04-19 Thread Denis Ciocca
Hi Leonard, On |19 Apr 16 @ 12:53|, Crestez Dan Leonard wrote: > On 04/19/2016 08:10 AM, Lucas De Marchi wrote: > > On Mon, Apr 18, 2016 at 4:51 PM, Jonathan Cameron wrote: > >> On 18/04/16 11:25, Crestez Dan Leonard wrote: > >>> On 04/18/2016 09:07 AM, Denis Cioc

Re: [RFC] iio: st: Add lsm9ds0 support for gyro accel and magn

2016-04-18 Thread Denis Ciocca
Hi Lucas, yup. Just need to add the lsm9ds0_gyro entry in the same table of l3gd20. Thanks, Denis On |19 Apr 16 @ 07:10|, Lucas De Marchi wrote: > On Mon, Apr 18, 2016 at 4:51 PM, Jonathan Cameron wrote: > > On 18/04/16 11:25, Crestez Dan Leonard wrote: > >> On 04/18/20

Re: [RFC] iio: st: Add lsm9ds0 support for gyro accel and magny

2016-04-17 Thread Denis Ciocca
Hi Leonard and Jonathan, basically the patch can not work. Current ST infrastructure needs to use one i2c slave per driver (accel or magn or gyro). All sensors currently supported (including lsm303agr) have one i2c address per sensor type (for example in lsm303agr, accel has one i2c address, mag

Re: [PATCH] iio: st_magn: always define ST_MAGN_TRIGGER_SET_STATE

2016-03-29 Thread Denis Ciocca
Hi Arnd, yup, my fault. Thanks. Acked-by: Denis Ciocca On |29 Mar 16 @ 22:27|, Arnd Bergmann wrote: > When CONFIG_IIO_TRIGGER is enabled but CONFIG_IIO_BUFFER is > not, we get a build error in the st_magn driver: > > drivers/iio/magnetometer/st_magn_core.c:5

Re: [PATCH] iio:st_sensors: Fix oops when probing SPI devices

2015-04-22 Thread Denis Ciocca
Hi Alban, after several months I'm finally back. I already did this patch, but I had no time to submit. Thanks to your support it is ok for me! We need to propagate also the patch to fix previous kernel versions... Acked-by: Denis Ciocca Denis On 04/20/2015 07:57 PM, Alban Bedel

Re: [PATCH 32/38] iio: accel-core: st: Move LSM303DLH into correct group

2013-09-16 Thread Denis CIOCCA
>> I've tried with real device...Unfortunately, you are right for name on >> the package... >> So, are you using the LSM303DLHC? > According to my datasheet [1], I have the LSM303DLH. > > [1] > http://www.calao-systems.com/repository/pub/EMBEDDED%20COMPUTERS/SKY-S9500-ULP-XXX/C12-SDK/SCH-00103-B11

Re: [PATCH 38/38] iio: magn-core: st: Provide support for the LSM303DLH

2013-09-16 Thread Denis CIOCCA
Hi Lee, > The driver mentions that the first group of sensors have a WAI of > 0x3c: #define ST_MAGN_1_WAI_EXP 0x3c And when I print out the WAI read > from the device: Requested device: lsm303dlh_magn - read WAI: 0x3c I > guess I could have been lied to again by the board's datasheet again > a

Re: [PATCH 32/38] iio: accel-core: st: Move LSM303DLH into correct group

2013-09-16 Thread Denis CIOCCA
Hi Lee, > That's what the datasheet for the board says. Perhaps it's that that's > incorrect? Annoyingly, instead of printing the device name on the > package, ST put some non-Googleable nonsense is there instead > (probably the serial number). Nevertheless, I'll revert the patch and > work so

Re: [PATCH 38/38] iio: magn-core: st: Provide support for the LSM303DLH

2013-09-16 Thread Denis CIOCCA
Hi Lee, > index 12e7e79..b2e2917 100644 > --- a/drivers/iio/magnetometer/st_magn_core.c > +++ b/drivers/iio/magnetometer/st_magn_core.c > @@ -151,7 +151,8 @@ static const struct st_sensors st_magn_sensors[] = { > .wai = ST_MAGN_1_WAI_EXP, > .sensors_supported = { >

Re: [PATCH 14/38] iio: accel: st: Append _accel to accelerator sensor device names

2013-09-16 Thread Denis CIOCCA
Hi Lars, > On 09/14/2013 02:27 PM, Jonathan Cameron wrote: >> On 09/14/13 13:14, Jonathan Cameron wrote: >>> On 09/10/13 13:49, Lee Jones wrote: Some of ST's sensors are appended with their sensor type and some are not. For consistency we're extending the same naming convention throu

Re: [PATCH 32/38] iio: accel-core: st: Move LSM303DLH into correct group

2013-09-16 Thread Denis CIOCCA
Hi Lee, >> On 09/10/13 13:49, Lee Jones wrote: >>> The LSM303DLH's WAI (WhoAmI) is 0x33, meaning it should be enabled by >>> Accel Sensor group one. For the device to probe without error, we'll >>> need to ensure it's registered with the correct WAI. >>> >>> Signed-off-by: Lee Jones >> You clearly

Re: [PATCH 06/11] iio: pressure-core: st: Expand and rename LPS331AP's channel descriptor

2013-09-05 Thread Denis CIOCCA
Lee, I got your point. For me is ok... Denis > On Thu, 05 Sep 2013, Denis CIOCCA wrote: > >>>>> Due to the MACRO used, the task of reading, understanding and maintaining >>>>> the LPS331AP's channel descriptor is substantially difficult. This patch >&

Re: [PATCH 06/11] iio: pressure-core: st: Expand and rename LPS331AP's channel descriptor

2013-09-05 Thread Denis CIOCCA
>>> Due to the MACRO used, the task of reading, understanding and maintaining >>> the LPS331AP's channel descriptor is substantially difficult. This patch >>> is based on the view that it's better to have easy to read, maintainable >>> code than to save a few lines here and there. For that reason

Re: [PATCH 05/11] iio: pressure-core: st: Describe LPS331AP defines by name

2013-09-04 Thread Denis CIOCCA
Hi Lee, > They're currently named *_1_*, for 'Sensor 1', but the code will be much > more readable if we use the naming convention *_LPS331AP_* instead. You are right, but the reason is to maintain the same structure of the other sensors drivers (like accel, gyro and magn). Often some sensors can

Re: [PATCH 08/11] iio: pressure-core: st: Allow for number of channels to vary

2013-09-04 Thread Denis CIOCCA
Acked-by: Denis Ciocca > At the moment the number of channels specified is dictated by the first > sensor supported by the driver. As we add support for more sensors this > is likely to vary. Instead of using the ARRAY_SIZE() of the LPS331AP's > channel specifier we'll use a

Re: [PATCH 07/11] iio: sensors-core: st: Allow full-scale to be an optional feature

2013-09-04 Thread Denis CIOCCA
Acked-by: Denis Ciocca > Some chips either don't support it or fail to provide adequate documentation, > so sometimes it's impossible to enable the feature even if it is supported. > > Signed-off-by: Lee Jones > --- > drivers/iio/common/st_sensors/st_sensors_core.c

Re: [PATCH 06/11] iio: pressure-core: st: Expand and rename LPS331AP's channel descriptor

2013-09-04 Thread Denis CIOCCA
> Due to the MACRO used, the task of reading, understanding and maintaining > the LPS331AP's channel descriptor is substantially difficult. This patch > is based on the view that it's better to have easy to read, maintainable > code than to save a few lines here and there. For that reason we're > e

Re: [PATCH] iio: STMicroelectronics: remove three useless selects

2013-05-14 Thread Denis CIOCCA
Hi Paul, Acked-by: Denis Ciocca Thanks, Denis On Tuesday, May 14, 2013 11:05:50 AM Paul Bolle wrote: > Drivers for STMicroelectronics accelerometers, gyroscopes, and > magnetometers were added in v3.9. They all have a (similar) select > statement in their Kconfig files for a non