Re: [PATCH -next] fs: dlm: fix missing unlock on error in accept_from_sock()

On Sat, Mar 27, 2021 at 04:37:04PM +0800, Yang Yingliang wrote: > Add the missing unlock before return from accept_from_sock() > in the error handling case. Thanks, applied to the next branch. Dave > Fixes: 6cde210a9758 ("fs: dlm: add helper for init connection") > Reported-by: Hulk Robot > Sign

[GIT PULL] dlm updates for 5.11

Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-5.11 This set includes more low level communication layer cleanups. The main change is the listening socket is no longer handled as a special case of node connection sockets. The

[GIT PULL] dlm updates for 5.10

Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-5.10 This set continues the ongoing rework of the low level communication layer in the dlm. The focus here is on improvements to connection handling, and reworking the receiving

[GIT PULL] dlm updates for 5.9

Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-5.9 This set includes a some improvements to the dlm networking layer: improving the ability to trace dlm messages for debugging, and improved handling of bad messages or disrupte

[GIT PULL] dlm updates for 5.8

Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-5.8 This set includes a couple minor cleanups, and dropping the interruptible from a wait_event that waits for an event from the userspace cluster management. Thanks, Dave Arnd

Re: [PATCH 1/4] sctp: add sctp_sock_set_nodelay

On Fri, May 29, 2020 at 02:09:40PM +0200, Christoph Hellwig wrote: > Add a helper to directly set the SCTP_NODELAY sockopt from kernel space > without going through a fake uaccess. Ack, they look fine to me, thanks. Dave

Re: is it ok to always pull in sctp for dlm, was: Re: [PATCH 27/33] sctp: export sctp_setsockopt_bindx

On Thu, May 14, 2020 at 12:40:40PM +0200, Christoph Hellwig wrote: > On Wed, May 13, 2020 at 03:00:58PM -0300, Marcelo Ricardo Leitner wrote: > > On Wed, May 13, 2020 at 08:26:42AM +0200, Christoph Hellwig wrote: > > > And call it directly from dlm instead of going through kernel_setsockopt. > > >

[GIT PULL] dlm updates for 5.3 (second try)

Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-5.3 This set removes some unnecessary debugfs error handling, and checks that lowcomms workqueues are not NULL before destroying. (Dropped the commits related to incorrect wait_e

Re: [GIT PULL] dlm updates for 5.3

On Wed, Jul 10, 2019 at 09:05:21PM -0700, Linus Torvalds wrote: > If wait_event_interruptible() returns -ERESTARTSYS, it means that we > have a signal pending. > > And if we have a signal pending, then you can't go back and call > wait_event_interruptible() in a loop, because the signal will > *co

[GIT PULL] dlm updates for 5.3

Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-5.3 Apart from a couple trivial fixes, the more notable fix makes the dlm continuing waiting for a user space result if a signal interrupts the wait event. Thanks, Dave David

[GIT PULL] dlm updates for 4.21

. Thanks, Dave Bob Peterson (1): dlm: Don't swamp the CPU with callbacks queued during recovery David Teigland (2): dlm: fix missing idr_destroy for recover_idr dlm: fix invalid cluster name warning Denis V. Lunev (1): dlm: fix possible call to kfree() for non-initia

[GIT PULL] dlm updates for 4.18

Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.18 These three commits fix and clean up the flags dlm was using on its SCTP sockets. The result improves the performance and fixes some bad connection delays. Thanks, Dave Ga

Re: [PATCH] dlm: prompt the user SCTP is experimental

On Thu, Mar 22, 2018 at 10:27:56PM -0600, Gang He wrote: > Hello David, > > Do you agree to add this prompt to the user? > Since sometimes customers attempted to setup SCTP protocol with two rings, > but they could not get the expected result, then it maybe bring some concerns > to the customer

[GIT PULL] dlm updates for 4.15

, starting, and stopping. Thanks, Dave Bob Peterson (3): DLM: Eliminate CF_CONNECT_PENDING flag DLM: Eliminate CF_WRITE_PENDING flag DLM: Fix saving of NULL callbacks David Teigland (1): dlm: remove dlm_send_rcom_lookup_dump Guoqing Jiang (1): dlm: recheck

Re: [BUG] fs/dlm: A possible sleep-in-atomic bug in dlm_master_lookup

On Sat, Oct 07, 2017 at 03:26:11AM +0100, Al Viro wrote: > On Sat, Oct 07, 2017 at 09:59:41AM +0800, Jia-Ju Bai wrote: > > According to fs/dlm/lock.c, the kernel may sleep under a spinlock, > > and the function call path is: > > dlm_master_lookup (acquire the spinlock) > > dlm_send_rcom_lookup_du

Re: linux-next: Signed-off-by missing for commits in the dlm tree

On Tue, Sep 19, 2017 at 07:49:19AM +1000, Stephen Rothwell wrote: > Hi David, > > Commits > > bcc976a145c9 ("DLM: Eliminate CF_CONNECT_PENDING flag") > c071b28b2bd5 ("DLM: Eliminate CF_WRITE_PENDING flag") > 782551aac851 ("DLM: Fix saving of NULL callbacks") > > are missing a Signed-off-by

[GIT PULL] dlm updates for 4.14

Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.14 This set includes a bunch of minor code cleanups that have accumulated, probably from code analyzers people like to run. There is one nice fix that avoids some socket leaks

[GIT PULL] dlm fixes for 4.10

Hi Linus, Please pull dlm fixes from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.10 This set fixes error reporting for dlm sockets, removes the unbound property on the dlm callback workqueue to improve performance, and includes a couple trivial changes. Thank

[GIT PULL] dlm fixes for 4.9

Hi Linus, Please pull dlm fixes from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.9 This includes a bug fix for a bad memory access during workqueue cleanup, which can happen while shutting down the dlm networking layer. (This was found and fixed in the past w

[GIT PULL] dlm fixes for 4.8

Hi Linus, Please pull dlm fixes from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.8-fixes This fixes a bug introduced by recent debugfs cleanup. Thanks, Dave Eric Ren (1): dlm: fix malfunction of dlm_tool caused by debugfs changes fs/dlm/debug_fs.c |

[GIT PULL] dlm updates for 4.8

Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.8 This set includes two trivial changes, one to use kmemdup and another to control the log level of recovery messages. Thanks, Dave Amitoj Kaur Chawla (1): dlm: Use kmem

[GIT PULL] dlm fixes for 4.6

Hi Linus, Please pull dlm fixes from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.6-fixes This fixes a bug from the configfs cleanup. Thanks, Dave Andrew Price (1): dlm: config: Fix ENOMEM failures in make_cluster() fs/dlm/config.c | 3 +-- 1 file ch

[GIT PULL] dlm updates for 4.6

Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.6 Previous changes introduced the use of socket error reporting for dlm sockets. This set includes two fixes in how the socket error callbacks are used. Thanks, Dave Bob Pete

[GIT PULL] dlm updates for 4.4

Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.4 This includes one simple fix to make posix locks interruptible by signals in cases where a signal handler is used. Thanks, Dave Eric Ren (1): dlm: make posix locks int

[GIT PULL] dlm updates for 4.3

also included. The other notable fix is for a long standing regression in the behavior of lock value blocks for user space locks. Thanks, Dave Bob Peterson (1): dlm: print error from kernel_sendpage David Teigland (1): dlm: fix lvb copy for user locks Marcelo Ricardo Leitner (6

Re: [PATCH 0/8] watchdog: Add support for keepalives triggered by infrastructure

On Wed, Aug 05, 2015 at 12:01:38PM -0700, Guenter Roeck wrote: > I think I can understand why Wim was reluctant to accept your patch; > I must admit I don't understand your use case either. Very breifly, sanlock is a shared storage based lease manager, and the expiration of a lease is tied to the

Re: [PATCH 0/8] watchdog: Add support for keepalives triggered by infrastructure

On Wed, Aug 05, 2015 at 10:41:51AM -0700, Guenter Roeck wrote: > Not really. The heartbeats will be generated such that the watchdog expires > no later that . I > discussed > this already with Uwe; he had the same concern. This isn't in the current > version of the patch set, but it will be in the

Re: [PATCH 0/8] watchdog: Add support for keepalives triggered by infrastructure

On Mon, Aug 03, 2015 at 07:13:26PM -0700, Guenter Roeck wrote: > - Some watchdogs have a very short maximum timeout, in the range of just a few > seconds. Such low timeouts are difficult if not impossible to support from > user space. Drivers supporting such watchdog hardware need to implement

Re: clustered MD

When a node fails, its dirty areas get special treatment from other nodes using the area_resyncing() function. Should the suspend_list be created before any reads or writes from the file system are processed by md? It seems to me that gfs journal recovery could read/write to dirty regions (from t

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

On Thu, Jun 11, 2015 at 05:47:28PM +0800, Guoqing Jiang wrote: > Do you consider take the following clean up? If yes, I will send a > formal patch, otherwise pls ignore it. On first glance, the old and new code do not appear to do the same thing, so let's leave it as it is. > - to_nodeid =

Re: clustered MD

On Wed, Jun 10, 2015 at 04:07:44PM -0500, David Teigland wrote: > > Also a slightly less adversarial tone would make me feel more > > comfortable, though maybe I'm misreading your intent. > > You're probably misreading "concerned". > > The initial resp

Re: clustered MD

On Thu, Jun 11, 2015 at 06:31:31AM +1000, Neil Brown wrote: > What is your interest in this? I'm always happy for open discussion and > varied input, but it would help to know to what extent you are a stake > holder? Using the dlm correctly is non-trivial and should be reviewed. If the dlm is mis

Re: clustered MD

On Wed, Jun 10, 2015 at 12:05:33PM -0500, David Teigland wrote: > Separate bitmaps for each node sounds like a much better design than the > cmirror design which used a single shared bitmap (I argued for using a > single bitmap when cmirror was being designed.) Sorry misspoke, I argue

Re: clustered MD

On Wed, Jun 10, 2015 at 11:23:25AM -0500, Goldwyn Rodrigues wrote: > To start with, the goal of (basic) MD RAID1 is to keep the two > mirrored device consistent _all_ of the time. In case of a device > failure, it should degrade the array pointing to the failed device, > so it can be (hot)removed/r

Re: clustered MD

On Wed, Jun 10, 2015 at 10:27:27AM -0500, Goldwyn Rodrigues wrote: > I thought I answered that: > To use a software RAID1 across multiple nodes of a cluster. Let me > explain in more words.. > > In a cluster with multiple nodes with a shared storage, such as a > SAN. The shared device becomes a si

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

On Wed, Jun 10, 2015 at 11:10:44AM +0800, Guoqing Jiang wrote: > The remove_from_waiters could only be invoked after failed to > create_message, right? > Since send_message always returns 0, this patch doesn't touch anything > about the failure > path, and it also doesn't change the original seman

Re: clustered MD

On Tue, Jun 09, 2015 at 10:33:08PM -0500, Goldwyn Rodrigues wrote: > >>>some real world utility to warrant the potential maintenance effort. > >> > >>We do have a valid real world utility. It is to provide > >>high-availability of RAID1 storage over the cluster. The > >>distributed locking is requ

Re: clustered MD

On Tue, Jun 09, 2015 at 03:08:11PM -0500, Goldwyn Rodrigues wrote: > Hi David, > > On 06/09/2015 02:45 PM, David Teigland wrote: > >On Tue, Jun 09, 2015 at 02:26:25PM -0500, Goldwyn Rodrigues wrote: > >>On 06/09/2015 01:22 PM, David Teigland wrote: > >>&g

Re: clustered MD

On Tue, Jun 09, 2015 at 02:26:25PM -0500, Goldwyn Rodrigues wrote: > On 06/09/2015 01:22 PM, David Teigland wrote: > >I've just noticed the existence of clustered MD for the first time. > >It is a major new user of the dlm, and I have some doubts about it. > >When did

clustered MD

I've just noticed the existence of clustered MD for the first time. It is a major new user of the dlm, and I have some doubts about it. When did this appear on the mailing list for review? Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to m

[GIT PULL] dlm updates for 3.19

Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.19 This set includes one feature, which allows locks that have been orphaned to be reacquired. Thanks, Dave David Teigland (1): dlm: adopt orphan locks fs/dlm/lock.c

Re: [RFA][PATCH 5/8] dlm: Remove seq_printf() return checks and use seq_has_overflowed()

On Tue, Nov 04, 2014 at 08:08:52AM -0500, Steven Rostedt wrote: > On Wed, 29 Oct 2014 17:56:07 -0400 > Steven Rostedt wrote: > > > From: Joe Perches > > > > [ REQUEST FOR ACKS ] > > Can any of the DLM maintainers give me an Acked-by for this? Looks ok, Dave -- To unsubscribe from this list:

[GIT PULL] dlm updates for 3.18

(v2: add cc lkml) Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.18 This includes a single commit fixing a missing endian conversion. Thanks, Dave Neale Ferguson (1): dlm: fix missing endian conversion of rcom_status

Re: [PATCH 9/9] fs: dlm: lockd: Convert int result to unsigned char type

On Wed, Jul 23, 2014 at 02:11:39PM -0400, Jeff Layton wrote: > On Sun, 20 Jul 2014 11:23:43 -0700 > Joe Perches wrote: > > > op->info.rv is an s32, but it's only used as a u8. > > > > I don't understand this patch. info.rv is s32 (and I assume that "rv" > stands for "return value"). What I don'

Re: [Cluster-devel] [RFC PATCH] dlm: Remove unused conf from lm_grant

On Tue, Jul 01, 2014 at 01:16:32PM -0400, Bob Peterson wrote: > - Original Message - > > On Tue, Jul 01, 2014 at 10:43:13AM -0400, Jeff Layton wrote: > > > On Tue, 01 Jul 2014 06:20:10 -0700 > > > Joe Perches wrote: > > > > > > > While doing a bit of adding argument names to fs.h, > > > >

Re: [RFC PATCH] dlm: Remove unused conf from lm_grant

On Tue, Jul 01, 2014 at 10:43:13AM -0400, Jeff Layton wrote: > On Tue, 01 Jul 2014 06:20:10 -0700 > Joe Perches wrote: > > > While doing a bit of adding argument names to fs.h, > > I looked at lm_grant and it seems the 2nd argument > > is always NULL. > > > > How about removing it? > > > > This

[GIT PULL] dlm updates for 3.16

Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.16 This set includes one small fix related to resending SCTP messages. Thanks, Dave Lidong Zhong (1): dlm: keep listening connection alive with sctp mode fs/dlm/lowcomm

[GIT PULL] dlm updates for 3.15

free warning David Teigland (1): dlm: use INFO for recovery messages Rashika Kheria (1): fs: Include appropriate header file in dlm/ast.c fs/dlm/ast.c | 3 ++- fs/dlm/dir.c | 4 ++-- fs/dlm/dlm_internal.h | 2 ++ fs/dlm/lock.c | 7 --- fs/dlm

[GIT PULL] dlm updates for 3.14

Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.14 This set includes a single change to speed up recovery times when using SCTP connections. Thanks, Dave Dongmao Zhang (1): dlm: set zero linger time on sctp socket fs

[GIT PULL] dlm updates for 3.13

Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.13 This set includes a single fix to resolve to a race that could cause lockspace shutdown to incorrectly return -EBUSY. Thanks, Dave Bart Van Assche (1): dlm: Avoid that

[GIT PULL] dlm updates for 3.12

l the unnecessary and wrong device_close()->recalc_sigpending() Let me know if you'd like me to send a resolved patch. Thanks, Dave David Teigland (1): dlm: remove signal blocking Tejun Heo (1): dlm: WQ_NON_REENTRANT is meaningless and going away fs/dlm/ast.c | 5 +

Re: linux-next: manual merge of the dlm tree with Linus' tree

On Fri, Aug 16, 2013 at 11:40:50AM +1000, Stephen Rothwell wrote: > Hi David, > > Today's linux-next merge of the dlm tree got a conflict in fs/dlm/user.c > between commit 201d3dfa4da1 ("dlm: kill the unnecessary and wrong > device_close()->recalc_sigpending()") from Linus' tree and commit > c6ca7

Re: [PATCH 1/1] dlm: kill the unnecessary and wrong device_close()->recalc_sigpending()

ent something like signals_stop/start for such a use-case. I can't remember why that signal code exists, or if I ever knew; it was there when the code was added seven years ago. I agree that if there's something we cannot interrupt, we should use uninterruptible, but I don't see any

[GIT PULL] dlm updates for 3.11

David Teigland (1): dlm: log an error for unmanaged lockspaces Mike Christie (6): dlm: clear correct init bit during sctp setup dlm: set sctp assoc id during setup dlm: clear correct bit during sctp init failure handling dlm: try other IPs when sctp init assoc fails

Re: [PATCH 03/10] idr: Rewrite ida

On Wed, Jun 19, 2013 at 04:38:36PM -0700, Kent Overstreet wrote: > On Wed, Jun 19, 2013 at 10:40:22AM +0100, Steven Whitehouse wrote: > > Millions of IDs is something that is fairly normal for DLM, since there > > will be two DLM locks per cached inode with GFS2 and people tend to use > > it on pre

Re: linux-next: Tree for May 8 (dlm)

On Thu, May 09, 2013 at 09:47:45AM +1000, Stephen Rothwell wrote: > [Just forwarding to David ...] > > On Wed, 08 May 2013 11:04:45 -0700 Randy Dunlap wrote: > > > > on x86_64: > > > > when CONFIG_GFS2_FS_LOCKING_DLM=y and CONFIG_DLM=m: > > > > fs/built-in.o: In function `gfs2_lock': > > file.c

[GIT PULL] dlm updates for 3.10

activity, even when no posix locks had been used. This patch copies the nfs approach, and skips the full posix unlock if there is no plock found during the vfs unlock phase. Signed-off-by: David Teigland --- fs/dlm/plock.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions

Re: [RFC PATCH] watchdog: Add hook for kicking in kdump path

On Wed, Apr 10, 2013 at 09:40:39AM -0400, Don Zickus wrote: > However, we still have the problem that if the machine panics and we want > to jump into the kdump kernel, we need to 'kick' the watchdog one more > time. This provides us a sane sync point for determining how long we have > to load the

Re: GFS2: Pull request (fixes)

On Fri, Apr 05, 2013 at 11:34:45AM +0100, Steven Whitehouse wrote: > Please consider pulling the following changes, There's some mixup here that should be cleared up first. > David Teigland (2): > GFS2: Fix unlock of fcntl locks during withdrawn state > >

Re: [PATCH 67/77] dlm: convert to idr_alloc()

On Mon, Mar 11, 2013 at 01:28:18PM -0700, Tejun Heo wrote: > Ah, right, in preloaded section, the allocation is expected to fail > before falling back to the preload buffer and I forgot to add > __GFP_NOWARN to the first try. Something like the following should > make it go away. Can you please t

Re: [PATCH 67/77] dlm: convert to idr_alloc()

On Wed, Feb 06, 2013 at 11:40:39AM -0800, Tejun Heo wrote: > static int create_lkb(struct dlm_ls *ls, struct dlm_lkb **lkb_ret) > { > struct dlm_lkb *lkb; > - int rv, id; > + int rv; > > lkb = dlm_allocate_lkb(ls); > if (!lkb) > @@ -1199,19 +1199,13 @@ static int creat

[GIT PULL] dlm updates for 3.9

: David Teigland --- fs/dlm/dlm_internal.h | 3 +++ fs/dlm/lock.c | 15 +++ 2 files changed, 18 insertions(+) diff --git a/fs/dlm/dlm_internal.h b/fs/dlm/dlm_internal.h index 77c0f70..e7665c3 100644 --- a/fs/dlm/dlm_internal.h +++ b/fs/dlm/dlm_internal.h @@ -96,10 +96,13 @@ do

Re: [PATCH] idr: fix a subtle bug in idr_get_next()

; > id += slot_distance. > > > > Signed-off-by: Tejun Heo > > Reported-by: David Teigland > > Cc: KAMEZAWA Hiroyuki > > David, can you please test whether the patch makes the skipped > deletion bug go away? Yes, I've tested, and it works fine now. Thanks, Da

Re: [GIT PULL] Revert "dlm: check the maximum size of a request from user"

On Mon, Feb 04, 2013 at 12:06:55PM -0500, David Teigland wrote: > Please pull the following fix from branch: > > git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git for-linus > > This reverts commit 2b75bc9121e54e22537207b47b71373bcb0be41c. Hi Linus, You can

Re: [GIT PULL] Revert "dlm: check the maximum size of a request from user"

the bogus size, which could lead to OOM. Reported-by: Sasha Levin Signed-off-by: David Teigland --- fs/dlm/user.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/fs/dlm/user.c b/fs/dlm/user.c index eb4ed9b..911649a 100644 --- a/fs/dlm/user.c +++ b/fs/dlm/user.c @@ -503,6 +503,13 @@ static

[GIT PULL] Revert "dlm: check the maximum size of a request from user"

a case where this breaks userland (clvmd) when maximum resource name lengths are used. I am still sorting out exactly which combinations of kernel and userland libs are a problem. Reported-by: Jana Saout CC: Sasha Levin Signed-off-by: David Teigland --- fs/dlm/user.c | 7 --- 1 file

Re: [PATCH 10/14] dlm: don't use idr_remove_all()

On Thu, Jan 31, 2013 at 04:18:41PM -0800, Tejun Heo wrote: > It looks a bit weird to me that ls->ls_recover_list_count is also > incremented by recover_list_add(). The two code paths don't seem to > be interlocke at least upon my very shallow glance. Is it that only > either the list or idr is in

Re: [PATCH 10/14] dlm: don't use idr_remove_all()

On Tue, Jan 29, 2013 at 10:13:17AM -0500, David Teigland wrote: > On Mon, Jan 28, 2013 at 10:57:23AM -0500, David Teigland wrote: > > On Fri, Jan 25, 2013 at 05:31:08PM -0800, Tejun Heo wrote: > > > idr_destroy() can destroy idr by itself and idr_remove_all() is bein

Re: [PATCH 10/14] dlm: don't use idr_remove_all()

On Mon, Jan 28, 2013 at 10:57:23AM -0500, David Teigland wrote: > On Fri, Jan 25, 2013 at 05:31:08PM -0800, Tejun Heo wrote: > > idr_destroy() can destroy idr by itself and idr_remove_all() is being > > deprecated. > > > > The conversion isn't completely tr

Re: [PATCH 10/14] dlm: don't use idr_remove_all()

e use of > idr_remove_all() w/o idr_destroy(). Replace it with idr_remove() call > inside idr_for_each_entry() loop. It goes on top so that it matches > the operation order in recover_idr_del(). > > Only compile tested. > > Signed-off-by: Tejun Heo > Cc: Christine

Re: [PATCH 09/14] dlm: use idr_for_each_entry() in recover_idr_clear() error path

emove_all(). > > Only compile tested. > > Signed-off-by: Tejun Heo > Cc: Christine Caulfield > Cc: David Teigland > Cc: cluster-de...@redhat.com > --- > This patch depends on an earlier idr patch and I think it would be > best to route these together through -mm

[GIT PULL] dlm updates for 3.8

Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.8 This set fixes some conditions in which value blocks are invalidated, and includes two trivial cleanups. Thanks, Dave David Teigland (1): dlm: fix lvb invalidation

Re: [PATCH v7 10/16] dlm: use new hashtable implementation

On Mon, Oct 29, 2012 at 12:07:10PM -0400, Mathieu Desnoyers wrote: > I'm fine with turning a direct + modulo mapping into a dispersed hash as > long as there are no underlying assumptions about sequentiality of value > accesses. > > If the access pattern would happen to be typically sequential, th

[GIT PULL] dlm updates for 3.7

both access configfs data simultaneously. The second reworks some code to get around a long standing, but intentional, unlock balance warning. The userland daemon no longer takes a lock that is later released from the kernel. The other commits are minor fixes and changes. Thanks, Dave David

Re: [PATCH] dlm: check the maximum size of a request from user

On Sun, Sep 09, 2012 at 04:16:58PM +0200, Sasha Levin wrote: > device_write only checks whether the request size is big enough, but it > doesn't > check if the size is too big. > > At that point, it also tries to allocate as much memory as the user has > requested > even if it's too much. This c

Re: [PATCH] dlm: cleanup send_to_sock routine

On Mon, Aug 13, 2012 at 02:29:55PM +0800, Ying Xue wrote: > But I have submitted another patch: > https://lkml.org/lkml/2012/8/9/668 Yes I got it, to see all the patches I've pushed out, check here: http://git.kernel.org/gitweb.cgi?p=linux/kernel/git/teigland/linux-dlm.git;a=shortlog;h=refs/heads

Re: [PATCH] dlm: convert add_sock routine return value type to void

On Fri, Aug 10, 2012 at 02:58:42PM +0800, Ying Xue wrote: > Since add_sock() always returns a success code - 0, its return > value type should be changed from integer to void. Thanks, I've pushed those to my next branch. Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

[GIT PULL] dlm updates for 3.6

through a hash bucket. The other commits include minor fixes and changes. Thanks, Dave David Teigland (6): dlm: use rsbtbl as resource directory dlm: use idr instead of list for recovered rsbs dlm: fix race between remove and lookup dlm: use wait_event_timeout dlm: fix

[PATCH 2/6] dlm: use idr instead of list for recovered rsbs

When a large number of resources are being recovered, a linear search of the recover_list takes a long time. Use an idr in place of a list. Signed-off-by: David Teigland --- fs/dlm/dlm_internal.h |3 ++ fs/dlm/lockspace.c|3 ++ fs/dlm/rcom.c |2 +- fs/dlm/recover.c

[PATCH 3/6] dlm: fix race between remove and lookup

has been sent. A lookup checks if this in-progress remove matches the name it is looking up. Signed-off-by: David Teigland --- fs/dlm/dlm_internal.h | 13 fs/dlm/lock.c | 181 +++-- fs/dlm/lockspace.c| 21 +- 3 files changed

[PATCH 4/6] dlm: use wait_event_timeout

Use wait_event_timeout to avoid using a timer directly. Signed-off-by: David Teigland --- fs/dlm/recover.c | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/fs/dlm/recover.c b/fs/dlm/recover.c index ff6f276..12702cc 100644 --- a/fs/dlm

[PATCH 5/6] dlm: fix conversion deadlock from recovery

The process of rebuilding locks on a new master during recovery could re-order the locks on the convert queue, creating an "in place" conversion deadlock that would not be resolved. Fix this by not considering queue order when granting conversions after recovery. Signed-off-by: Davi

[PATCH 6/6] dlm: fix missing dir remove

r. Signed-off-by: David Teigland --- fs/dlm/lock.c | 70 +++-- 1 file changed, 68 insertions(+), 2 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index 04e3f15..b569507 100644 --- a/fs/dlm/lock.c +++ b/fs/dlm/lock.c @@ -4000,12 +4000,70

[PATCH 0/6] dlm patches for 3.6

patch is made possible by the dirtbl removal, and fixes a long standing race between resource removal and lookup by reworking how removal is done. At the same time it improves the shrink function efficiency by avoiding repeated searches through hash buckets. David Teigland (6): dlm: use

[GIT PULL] dlm fixes for 2.6.25-rc2

insertions(+), 2 deletions(-) commit d7c2feaf88df39124e278b9e775b245b057ac99e Author: David Teigland <[EMAIL PROTECTED]> Date: Thu Feb 21 15:27:09 2008 -0600 dlm: update git tree in MAINTAINERS Signed-off-by: David Teigland <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b

Re: linux-next: Tree for Feb 19

On Wed, Feb 20, 2008 at 10:03:29AM +1100, Stephen Rothwell wrote: > Hi David, > > On Tue, 19 Feb 2008 14:04:50 -0600 David Teigland <[EMAIL PROTECTED]> wrote: > > > > dlm (distributed lock manager) tree: > > > > git://git.kernel.org/pub/scm/linux/kerne

Re: linux-next: Tree for Feb 19

On Tue, Feb 19, 2008 at 06:38:25PM +1100, Stephen Rothwell wrote: > We are up to 26 trees, more are welcome (even if they are currently empty). dlm (distributed lock manager) tree: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/dlm.git next Dave -- To unsubscribe from this list: send t

Re: [2.6 patch] make dlm_print_rsb() static

On Wed, Feb 13, 2008 at 11:29:38PM +0200, Adrian Bunk wrote: > dlm_print_rsb() can now become static. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Thanks, added to dlm.git. Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PR

Re: [PATCH] dlm: match signedness between dlm_config_info and cluster_set

On Wed, Feb 13, 2008 at 04:54:29PM -0800, Harvey Harrison wrote: > cluster_set is only called from the macro CLUSTER_ATTR which defines > read/write > access functions. Make the signedness match to avoid sparse warnings every > time > CLUSTER_ATTR is used (lines 149-159) all of the form: > > fs

Re: [PATCH 2/2] [RESENDING] fs/ocfs2: get rid of unnecessary initialization

On Mon, Feb 18, 2008 at 11:30:30AM -0800, Mark Fasheh wrote: > On Mon, Feb 11, 2008 at 06:08:31PM +0900, Joonwoo Park wrote: > > default_groups was allocated with kcalloc, so initialize to NULL > > is unnecessary. > > NACK - this isn't a performance critical section of code and that line makes > t

[GIT PULL] dlm updates for 2.6.25 (batch 2)

dlm: receive_rcom_lock_args() overflow check dlm: make find_rsb() fail gracefully when namelen is too large dlm: fix overflows when copying from ->m_extra to lvb dlm: fix dlm_dir_lookup() handling of too long names dlm: dlm/user.c input validation fixes David Teigland (2):

[PATCH 16/16] dlm: add __init and __exit marks to init and exit functions

From: Denis Cheng <[EMAIL PROTECTED]> it moves 365 bytes from .text to .init.text, and 30 bytes from .text to .exit.text, saves memory. Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/config.c|2 +- fs/dlm/

[PATCH 15/16] dlm: eliminate astparam type casting

Put lkb_astparam in a union with a dlm_user_args pointer to eliminate a lot of type casting. Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/debug_fs.c |6 ++ fs/dlm/dlm_internal.h |5 - fs/dlm/lock.c | 14 ++ fs/dlm/memory.c

[PATCH 14/16] dlm: proper types for asts and basts

Use proper types for ast and bast functions, and use consistent type for ast param. Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/ast.c |9 +++ fs/dlm/dlm_internal.h | 14 +--- fs/dlm/lock.c

[PATCH 12/16] dlm: fix dlm_dir_lookup() handling of too long names

From: Al Viro <[EMAIL PROTECTED]> ... those can happen and BUG() from DLM_ASSERT() in allocate_direntry() is not a good way to handle them. Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/dir.c |3 +++ 1 files cha

[PATCH 11/16] dlm: fix overflows when copying from ->m_extra to lvb

From: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/lock.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index 6d98cf9..5b82187 1

[PATCH 09/16] dlm: receive_rcom_lock_args() overflow check

From: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/lock.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index 6c605fc..0593dd8 1

[PATCH 10/16] dlm: make find_rsb() fail gracefully when namelen is too large

tually oops before that while calculating hash of up to 64Kb worth of data - with data actually being 64 _bytes_ in kmalloc()'ed struct. Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/lock.c |6 +- 1 files chan

[PATCH 05/16] dlm: use proper type for ->ls_recover_buf

From: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/dir.c |2 +- fs/dlm/dlm_internal.h |2 +- fs/dlm/rcom.c | 11 ++- fs/dlm/recover.c |4 ++-- 4

[PATCH 01/16] dlm: use proper C for dlm/requestqueue stuff (and fix alignment bug)

t alignment. Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/lock.c |2 +- fs/dlm/requestqueue.c | 12 ++-- fs/dlm/requestqueue.h |2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/fs/dlm

  1   2   3   >