[RFI]: SPARC - use of in-local-out register sets with hardware strands (threads)

2015-02-21 Thread David Horner
I assume each core has a shared set of registers in the circular buffer of these register, and that each strand allocates from that pool. Can you tell me how to find the number of registers in the pool for a given machine (I'm currently interested in the T4-2)? If you can send some good urls my w

Re: [PATCH v5 3/4] zram: zram memory size limitation

2014-08-27 Thread David Horner
On Wed, Aug 27, 2014 at 12:29 PM, Dan Streetman wrote: > On Wed, Aug 27, 2014 at 11:35 AM, David Horner wrote: >> On Wed, Aug 27, 2014 at 11:14 AM, Dan Streetman wrote: >>> On Wed, Aug 27, 2014 at 10:44 AM, David Horner wrote: >>>> On Wed, Aug 27, 2014 at

Re: [PATCH v5 3/4] zram: zram memory size limitation

2014-08-27 Thread David Horner
On Wed, Aug 27, 2014 at 11:14 AM, Dan Streetman wrote: > On Wed, Aug 27, 2014 at 10:44 AM, David Horner wrote: >> On Wed, Aug 27, 2014 at 10:03 AM, Dan Streetman wrote: >>> On Tue, Aug 26, 2014 at 10:51 PM, Minchan Kim wrote: >>>> Hey Joonsoo, >>>> >

Re: [PATCH v5 3/4] zram: zram memory size limitation

2014-08-27 Thread David Horner
On Wed, Aug 27, 2014 at 10:03 AM, Dan Streetman wrote: > On Tue, Aug 26, 2014 at 10:51 PM, Minchan Kim wrote: >> Hey Joonsoo, >> >> On Wed, Aug 27, 2014 at 10:26:11AM +0900, Joonsoo Kim wrote: >>> Hello, Minchan and David. >>> >>> On Tue, Aug

Re: [PATCH v5 3/4] zram: zram memory size limitation

2014-08-26 Thread David Horner
On Tue, Aug 26, 2014 at 3:55 AM, Minchan Kim wrote: > Hey Joonsoo, > > On Tue, Aug 26, 2014 at 04:37:30PM +0900, Joonsoo Kim wrote: >> On Mon, Aug 25, 2014 at 09:05:55AM +0900, Minchan Kim wrote: >> > @@ -513,6 +540,14 @@ static int zram_bvec_write(struct zram *zram, struct >> > bio_vec *bvec, u3

Re: [PATCH v4 3/4] zram: zram memory size limitation

2014-08-25 Thread David Horner
On Tue, Aug 26, 2014 at 12:39 AM, Minchan Kim wrote: > Hi Dan and David, > > On Mon, Aug 25, 2014 at 09:54:57PM -0400, David Horner wrote: >> On Mon, Aug 25, 2014 at 2:12 PM, Dan Streetman wrote: >> > On Mon, Aug 25, 2014 at 4:22 AM, David Horner wrote: >> >&

Re: [PATCH v4 3/4] zram: zram memory size limitation

2014-08-25 Thread David Horner
On Mon, Aug 25, 2014 at 2:12 PM, Dan Streetman wrote: > On Mon, Aug 25, 2014 at 4:22 AM, David Horner wrote: >> On Mon, Aug 25, 2014 at 12:37 AM, Minchan Kim wrote: >>> On Sun, Aug 24, 2014 at 11:40:50PM -0400, David Horner wrote: >>>> On Sun, Aug 24, 2014

Re: [PATCH v4 3/4] zram: zram memory size limitation

2014-08-25 Thread David Horner
On Mon, Aug 25, 2014 at 2:12 PM, Dan Streetman wrote: > On Mon, Aug 25, 2014 at 4:22 AM, David Horner wrote: >> On Mon, Aug 25, 2014 at 12:37 AM, Minchan Kim wrote: >>> On Sun, Aug 24, 2014 at 11:40:50PM -0400, David Horner wrote: >>>> On Sun, Aug 24, 2014

Re: [PATCH v4 3/4] zram: zram memory size limitation

2014-08-25 Thread David Horner
On Mon, Aug 25, 2014 at 12:37 AM, Minchan Kim wrote: > On Sun, Aug 24, 2014 at 11:40:50PM -0400, David Horner wrote: >> On Sun, Aug 24, 2014 at 7:56 PM, Minchan Kim wrote: >> > Hello David, >> > >> > On Fri, Aug 22, 2014 at 06:55:38AM -0400, David Horner wrote

Re: [PATCH v5 2/4] zsmalloc: change return value unit of zs_get_total_size_bytes

2014-08-24 Thread David Horner
ry overhead > (ie, change page unit with byte unit) in zsmalloc. > > Since return type is pages, "zs_get_total_pages" is better than > "zs_get_total_size_bytes". > > Reviewed-by: Dan Streetman Reviewed-by: David Horner > Signed-off-by: Minchan Kim > -

Re: [PATCH v5 4/4] zram: report maximum used memory

2014-08-24 Thread David Horner
easily via reading the knob and reset > it via "echo 0 > /sys/block/zram0/mem_used_max". > > Reviewed-by: Dan Streetman Reviewed-by: David Horner > Signed-off-by: Minchan Kim > --- > Documentation/ABI/testing/sysfs-block-zram | 10 + > Docum

Re: [PATCH v4 3/4] zram: zram memory size limitation

2014-08-24 Thread David Horner
On Sun, Aug 24, 2014 at 7:56 PM, Minchan Kim wrote: > Hello David, > > On Fri, Aug 22, 2014 at 06:55:38AM -0400, David Horner wrote: >> On Thu, Aug 21, 2014 at 8:42 PM, Minchan Kim wrote: >> > Since zram has no control feature to limit memory usage, >> > it ma

Re: [PATCH v4 3/4] zram: zram memory size limitation

2014-08-22 Thread David Horner
On Thu, Aug 21, 2014 at 8:42 PM, Minchan Kim wrote: > Since zram has no control feature to limit memory usage, > it makes hard to manage system memrory. > > This patch adds new knob "mem_limit" via sysfs to set up the > a limit so that zram could fail allocation once it reaches > the limit. > > In

Re: [PATCH v3 4/4] zram: report maximum used memory

2014-08-20 Thread David Horner
On Wed, Aug 20, 2014 at 10:41 PM, Minchan Kim wrote: > On Wed, Aug 20, 2014 at 10:20:07PM -0400, David Horner wrote: >> On Wed, Aug 20, 2014 at 8:27 PM, Minchan Kim wrote: >> > Normally, zram user could get maximum memory usage zram consumed >> > via polling m

Re: [PATCH v3 4/4] zram: report maximum used memory

2014-08-20 Thread David Horner
On Wed, Aug 20, 2014 at 8:27 PM, Minchan Kim wrote: > Normally, zram user could get maximum memory usage zram consumed > via polling mem_used_total with sysfs in userspace. > > But it has a critical problem because user can miss peak memory > usage during update inverval of polling. For avoiding t

Re: [PATCH v2 4/4] zram: report maximum used memory

2014-08-20 Thread David Horner
ed, Aug 20, 2014 at 3:53 AM, Minchan Kim wrote: > On Wed, Aug 20, 2014 at 03:38:27AM -0400, David Horner wrote: >> On Wed, Aug 20, 2014 at 2:53 AM, Minchan Kim wrote: >> > On Wed, Aug 20, 2014 at 02:26:50AM -0400, David Horner wrote: >> >> On Tue, Aug 19, 2014 at 3:54

Re: [PATCH v2 4/4] zram: report maximum used memory

2014-08-20 Thread David Horner
On Wed, Aug 20, 2014 at 2:53 AM, Minchan Kim wrote: > On Wed, Aug 20, 2014 at 02:26:50AM -0400, David Horner wrote: >> On Tue, Aug 19, 2014 at 3:54 AM, Minchan Kim wrote: >> > Normally, zram user could get maximum memory usage zram consumed >> > via polling mem_used_to

Re: [PATCH v2 4/4] zram: report maximum used memory

2014-08-19 Thread David Horner
On Tue, Aug 19, 2014 at 3:54 AM, Minchan Kim wrote: > Normally, zram user could get maximum memory usage zram consumed > via polling mem_used_total with sysfs in userspace. > > But it has a critical problem because user can miss peak memory > usage during update inverval of polling. For avoiding t

Re: [PATCH 3/3] zram: add mem_used_max via sysfs

2014-08-14 Thread David Horner
On Thu, Aug 14, 2014 at 3:11 PM, Dan Streetman wrote: > On Thu, Aug 14, 2014 at 12:23 PM, David Horner wrote: >> On Thu, Aug 14, 2014 at 11:32 AM, David Horner wrote: >>> On Thu, Aug 14, 2014 at 11:09 AM, Dan Streetman wrote: >>>> On Wed, Aug 13, 2014

Re: [PATCH 3/3] zram: add mem_used_max via sysfs

2014-08-14 Thread David Horner
On Thu, Aug 14, 2014 at 11:32 AM, David Horner wrote: > On Thu, Aug 14, 2014 at 11:09 AM, Dan Streetman wrote: >> On Wed, Aug 13, 2014 at 9:12 PM, Minchan Kim wrote: >>> - if (zram->limit_bytes && >>> - zs_get_total_size_bytes(me

Re: [PATCH 3/3] zram: add mem_used_max via sysfs

2014-08-14 Thread David Horner
On Thu, Aug 14, 2014 at 11:09 AM, Dan Streetman wrote: > On Wed, Aug 13, 2014 at 9:12 PM, Minchan Kim wrote: >> - if (zram->limit_bytes && >> - zs_get_total_size_bytes(meta->mem_pool) > zram->limit_bytes) >> { >> + total_bytes = zs_get_total_size_bytes(meta->mem_pool);

Re: [PATCH 3/3] zram: add mem_used_max via sysfs

2014-08-14 Thread David Horner
The introduction of a reset can cause the stale zero value to be retained in the show. Instead reset to current value. On Wed, Aug 13, 2014 at 9:12 PM, Minchan Kim wrote: > Normally, zram user can get maximum memory zsmalloc consumed via > polling mem_used_total with sysfs in userspace. > > But i

Re: [RFC 2/3] zsmalloc/zram: add zs_get_max_size_bytes and use it in zram

2014-08-07 Thread David Horner
[2/3] But why isn't mem_used_max writable? (save tearing down and rebuilding device to reset max) static DEVICE_ATTR(mem_used_max, S_IRUGO, mem_used_max_show, NULL); static DEVICE_ATTR(mem_used_max, S_IRUGO | S_IWUSR, mem_used_max_show, NULL); with a check in the store() that the new v

[KORG] re: [PATCH] cfq-iosched: tighten allow merge criteria - error in final return value ?

2006-12-29 Thread DAVID HORNER
I noticed a probable error in commit 719d34027e1a186e46a3952e8a24bf91ecc33837 > > - if (cfqq != RQ_CFQQ(rq)) > - return 0; > + > + if (cfqq == RQ_CFQQ(rq)) > + return 1; > > return 1; > } Either the final return value should be 0 (zero) or the if statement is redundant. (I lack