On Thu, Aug 14, 2014 at 11:09 AM, Dan Streetman <[email protected]> wrote: > On Wed, Aug 13, 2014 at 9:12 PM, Minchan Kim <[email protected]> wrote: >> - if (zram->limit_bytes && >> - zs_get_total_size_bytes(meta->mem_pool) > zram->limit_bytes) >> { >> + total_bytes = zs_get_total_size_bytes(meta->mem_pool); >> + if (zram->limit_bytes && total_bytes > zram->limit_bytes) { > > do you need to take the init_lock to read limit_bytes here? It could > be getting changed between these checks...
There is no real danger in freeing with an error. It is more timing than a race. The max calculation is still ok because committed allocations are added atomically. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
