On Tue, Jun 14, 2016 at 08:37:14PM +0300, Andy Shevchenko wrote:
> On Tue, 2016-06-14 at 10:26 -0700, David Cohen wrote:
>
> > > Yes. Will rename in this way, re-test and re-send.
> >
> > I'm curious about that. What pmu prefix would stand for?
>
>
On Tue, Jun 14, 2016 at 10:26:21AM -0700, David Cohen wrote:
> Hi,
>
> On Tue, Jun 14, 2016 at 07:07:14PM +0300, Andy Shevchenko wrote:
> > On Tue, 2016-06-14 at 17:58 +0200, Ingo Molnar wrote:
> > > * Andy Shevchenko wrote:
> > >
> > > > On Tue,
Hi,
On Tue, Jun 14, 2016 at 07:07:14PM +0300, Andy Shevchenko wrote:
> On Tue, 2016-06-14 at 17:58 +0200, Ingo Molnar wrote:
> > * Andy Shevchenko wrote:
> >
> > > On Tue, 2016-06-14 at 17:29 +0200, Ingo Molnar wrote:
> > >
> > > > * Andy Shevchenko wrote:
> > > >
> > > > > On Tue, 2016-06-14
Hi Heikki,
On Wed, Dec 02, 2015 at 12:27:10PM +0200, Heikki Krogerus wrote:
> Hi David,
>
>
>
> > > +void intel_usb_mux_unregister(struct intel_usb_mux *mux)
> > > +{
> >
> > There are still 2 pending comments for this unregister function:
> >
> > 1) How about a protection against unbalanced
Hi Felipe,
On Tue, Dec 01, 2015 at 02:34:34PM -0600, Felipe Balbi wrote:
[snip]
> > +EXPORT_SYMBOL_GPL(intel_usb_mux_register);
> > +
> > +void intel_usb_mux_unregister(struct intel_usb_mux *mux)
> > +{
> > + extcon_unregister_notifier(&mux->edev, EXTCON_USB_HOST, &mux->nb);
> > + extcon_dev
Hi Heikki,
Follow my comments below.
On Tue, Dec 01, 2015 at 03:32:37PM +0200, Heikki Krogerus wrote:
> Several Intel PCHs and SOCs have an internal mux that is
> used to share one USB port between USB Device Controller and
> xHCI. The mux is normally handled by System FW/BIOS, but not
> always.
Adding WDIOF_MAGICCLOSE to Intel MID watchdog driver. Once the watchdog
is opened, it makes sense to disable watchdog only if it was gracefully
released.
Signed-off-by: David Cohen
---
drivers/watchdog/intel-mid_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
Hi Sudip,
On Fri, Sep 04, 2015 at 05:12:23PM +0530, Sudip Mukherjee wrote:
> We were checking if dev->regs is NULL but it was done after
> dereferencing it. Lets reset the controller and iounmap dev->regs only
> if it is not NULL.
> free_irq() does not need dev->regs, so unmaping it before freeing
Hi,
On Tue, May 26, 2015 at 07:37:02PM -0700, Greg Kroah-Hartman wrote:
> On Wed, May 27, 2015 at 09:45:37AM +0800, Lu Baolu wrote:
> > Phy drivers and the ulpi interface providers depend on the
> > registration of the ulpi bus. Ulpi registers the bus in
> > module_init(). This could cause unnece
Hi Greg,
On Tue, May 26, 2015 at 07:41:18PM -0700, Greg KH wrote:
> On Tue, May 26, 2015 at 10:54:01AM -0700, David Cohen wrote:
> > Hi,
> >
> > On Mon, May 25, 2015 at 07:00:13PM +0200, Bjørn Mork wrote:
> > > Greg KH writes:
> > >
> > > > I
Hi,
On Mon, May 25, 2015 at 07:00:13PM +0200, Bjørn Mork wrote:
> Greg KH writes:
>
> > If there are other bus drivers that do this, I'll go fix them up,
> > pointers to those files would be appreciated.
>
> git grep -E 'if .*\.p\W' found a couple of interesting candidates you
> might want to c
On Fri, May 22, 2015 at 03:50:47PM +0800, Lu, Baolu wrote:
>
>
> On 05/22/2015 02:46 PM, Lu, Baolu wrote:
> >
> >
> >On 05/22/2015 11:11 AM, David Cohen wrote:
> >>On Thu, May 21, 2015 at 08:09:54PM -0700, David Cohen wrote:
> >>>Hi,
> >>
Hi,
On Fri, May 22, 2015 at 07:29:15PM +0800, Lu Baolu wrote:
> Phy drivers and the ulpi interface providers depend on the
> registeration of the ulpi bus. Ulpi registers the bus in
> module_init(). This could result in a load order issue, i.e.
It's still not an issue :(
I'd say "unnecessary pro
On Thu, May 21, 2015 at 08:09:54PM -0700, David Cohen wrote:
> Hi,
>
> On Fri, May 22, 2015 at 10:07:05AM +0800, Lu Baolu wrote:
> > Many drivers and modules depend on ULPI bus registeration to
> > register ULPI interfaces and drivers. It's more appropriate
&
Hi,
On Fri, May 22, 2015 at 10:07:05AM +0800, Lu Baolu wrote:
> Many drivers and modules depend on ULPI bus registeration to
> register ULPI interfaces and drivers. It's more appropriate
> to register ULPI bus in subsys_initcall instead of module_init.
>
> Kernel panic has been reported with some
herwise it may trigger BUG() on driver_register().
I wonder if it would be nice to have a macro for that checking :)
Anyway,
Reviewed-by: David Cohen
> drv->driver.bus = &ulpi_bus;
>
> return driver_register(&drv->driver);
> --
> 1.7.10.4
>
--
On Sat, Apr 25, 2015 at 10:47:42AM -0500, Felipe Balbi wrote:
> Hi,
Hi Felipe,
>
> On Fri, Apr 24, 2015 at 01:56:25PM -0700, David Cohen wrote:
> > > > > > When going into bus suspend/resume we _must_
> > > > > > call gadget driver's ->sus
On Fri, Apr 24, 2015 at 02:48:27PM -0500, Felipe Balbi wrote:
> Hi,
Hi Felipe,
>
> On Thu, Apr 23, 2015 at 03:37:48PM -0700, David Cohen wrote:
> > On Fri, Apr 17, 2015 at 02:43:27PM -0500, Felipe Balbi wrote:
> > > On Fri, Apr 17, 2015 at 11:41:56AM -0700, David C
Hi Greg,
On Fri, Apr 17, 2015 at 09:42:57PM +0200, Greg KH wrote:
> On Fri, Apr 17, 2015 at 11:41:56AM -0700, David Cohen wrote:
> > From: Felipe Balbi
> >
> > When going into bus suspend/resume we _must_
> > call gadget driver's ->suspend/->resume
Hi Felipe,
On Fri, Apr 17, 2015 at 02:43:27PM -0500, Felipe Balbi wrote:
> On Fri, Apr 17, 2015 at 11:41:56AM -0700, David Cohen wrote:
> > From: Felipe Balbi
>
> missing the required:
>
> [ Upstream commit bc5ba2e0b829c9397f96df1191c7d2319ebc36d9 ]
>
> >
&
From: Felipe Balbi
When going into bus suspend/resume we _must_
call gadget driver's ->suspend/->resume callbacks
accordingly. This patch implements that very feature
which has been missing forever.
Cc: # 3.14
Signed-off-by: Felipe Balbi
Signed-off-by: David Cohen
---
Hi,
Thi
Some gpio controllers are capable of programming its pins' active-low
state. Let's add this new gpio_chip function for such cases and use it
in gpiolib.
When set_active_low() is implemented, we no longer need to do soft flips
on values from non-raw get functions.
Signed-off-by: D
On Wed, Mar 18, 2015 at 10:12:13AM -0700, David Cohen wrote:
> Hi,
>
> On Wed, Mar 18, 2015 at 02:40:21PM +0200, Heikki Krogerus wrote:
> >
> > Major changes since v1:
> > - calling dwc3_phy_setup earlier and registering the ULPI interface there.
> > - new p
Hi,
On Wed, Mar 18, 2015 at 02:40:21PM +0200, Heikki Krogerus wrote:
>
> Major changes since v1:
> - calling dwc3_phy_setup earlier and registering the ULPI interface there.
> - new property to dwc3 for selecting the interface in case of UTMI+ and ULPI
> as
> suggested by Felipe
> - dwc3 soft
Hi Heikki,
On Wed, Mar 18, 2015 at 02:40:30PM +0200, Heikki Krogerus wrote:
> On some BYT platforms the USB2 PHY needs to be put into
> operational mode by the controller driver with GPIOs
> controlling the PHYs reset and cs signals.
>
> Signed-off-by: Heikki Krogerus
> ---
> drivers/usb/dwc3/d
On Wed, Mar 18, 2015 at 05:46:44PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 3/18/2015 3:40 PM, Heikki Krogerus wrote:
>
> >ULPI PHYs need to be bound to their controllers with a
> >lookup. This adds helpers that the ULPI drivers can use to
> >do both, the registration of the PHY and the look
On Mon, Mar 16, 2015 at 09:46:00AM -0700, David Cohen wrote:
> Adding Mika to CC list.
Grrr :(
Adding for real now.
>
> Br, David
>
> On Mon, Mar 09, 2015 at 12:10:51PM -0700, David Cohen wrote:
> > Hi Linus,
> >
> > On Mon, Mar 09, 2015 at 11:16:08AM -0500,
Adding Mika to CC list.
Br, David
On Mon, Mar 09, 2015 at 12:10:51PM -0700, David Cohen wrote:
> Hi Linus,
>
> On Mon, Mar 09, 2015 at 11:16:08AM -0500, Felipe Balbi wrote:
> > On Sat, Mar 07, 2015 at 09:06:22PM +0100, Linus Walleij wrote:
> > > On Fri, Feb 20, 2015
Hi Linus,
On Mon, Mar 09, 2015 at 11:16:08AM -0500, Felipe Balbi wrote:
> On Sat, Mar 07, 2015 at 09:06:22PM +0100, Linus Walleij wrote:
> > On Fri, Feb 20, 2015 at 8:17 PM, David Cohen
> > wrote:
> > > On Fri, Feb 20, 2015 at 10:53:44AM +0100, Linus Walleij wrote:
>
On Wed, Feb 25, 2015 at 10:34:45AM +0900, Alexandre Courbot wrote:
> On Wed, Feb 25, 2015 at 5:34 AM, David Cohen
> wrote:
> > Hi,
> >
> >> If we decide to go ahead with the solution proposed by this patch for
> >> practical reasons (which are good reasons in
Hi,
> If we decide to go ahead with the solution proposed by this patch for
> practical reasons (which are good reasons indeed), I still have one
> problem with its current form.
>
> As the discussion highlighted, this is an ACPI problem, so I'd very
> much like it to be confined to the ACPI GPIO
Hi,
[snip]
> Felipe suggested to "divide to conquer" instead of having a single
> extcon driver to handle all these functions:
>
> - The mux functions would be controlled by a possible new pinctrl-gpio
> driver (Linus, your input here would be nice :)
> - The VBUS would be a fixed regulator
> -
On Fri, Feb 20, 2015 at 02:00:26PM -0600, Felipe Balbi wrote:
> On Fri, Feb 20, 2015 at 11:59:27AM -0800, David Cohen wrote:
> > On Fri, Feb 20, 2015 at 01:36:06PM -0600, Felipe Balbi wrote:
> > > On Fri, Feb 20, 2015 at 11:17:00AM -0800, David Cohen wrote:
> >
On Fri, Feb 20, 2015 at 01:36:06PM -0600, Felipe Balbi wrote:
> On Fri, Feb 20, 2015 at 11:17:00AM -0800, David Cohen wrote:
> > Hi Linus and Robert,
> >
> > CC'ing Heikki as it involves a RFC from him.
> >
> > On Fri, Feb 20, 2015 at 10:53:44AM +0100, Lin
On Fri, Feb 20, 2015 at 08:10:34PM +0100, Paul Bolle wrote:
> On Fri, 2015-02-20 at 11:02 -0800, David Cohen wrote:
> > On Thu, Feb 19, 2015 at 11:39:06PM +0100, Paul Bolle wrote:
> > > On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote:
> > > > As always, comments
On Fri, Feb 20, 2015 at 01:09:00PM -0600, Felipe Balbi wrote:
> On Fri, Feb 20, 2015 at 11:02:26AM -0800, David Cohen wrote:
> > Hi,
> >
> > On Thu, Feb 19, 2015 at 11:39:06PM +0100, Paul Bolle wrote:
> > > On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote:
&
Hi Linus and Robert,
CC'ing Heikki as it involves a RFC from him.
On Fri, Feb 20, 2015 at 10:53:44AM +0100, Linus Walleij wrote:
> On Fri, Feb 20, 2015 at 7:41 AM, Robert Baldyga wrote:
> > Hi David,
> >
> > On 02/19/2015 08:59 PM, David Cohen wrote:
> >> S
Hi,
On Thu, Feb 19, 2015 at 11:39:06PM +0100, Paul Bolle wrote:
> On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote:
> > As always, comments are welcome.
>
> Are nits welcome too?
>
> > +MODULE_LICENSE("GPLv2");
>
> You probably meant
> MODULE
O level is high, by standard, the OTG port is
configured for device role by not sourcing VBUS and switching D+/- to
device controller.
Signed-off-by: David Cohen
---
Hi,
Since splitting this driver into smaller pieces would result in ugly fixes WRT
ACPI, I'm resending the same approa
Hi,
On Wed, Feb 18, 2015 at 12:17:06PM +0200, Mika Westerberg wrote:
> On Tue, Feb 17, 2015 at 11:35:23AM -0800, David Cohen wrote:
> > Hi,
> >
> > Adding Mika.
> >
> > On Tue, Feb 17, 2015 at 01:25:00PM -0600, Felipe Balbi wrote:
> > > Hi,
> > &
Hi,
Adding Mika.
On Tue, Feb 17, 2015 at 01:25:00PM -0600, Felipe Balbi wrote:
> Hi,
>
> On Tue, Feb 17, 2015 at 11:18:44AM -0800, David Cohen wrote:
> > > > > > (3) Platform has 2 USB controllers connected to same port: one for
> > > > > > de
Hi Linus,
Thanks for reviewing.
On Thu, Jan 08, 2015 at 08:23:03PM +0100, Linus Walleij wrote:
> On Mon, Dec 22, 2014 at 11:43 PM, David Cohen
> wrote:
>
> > Some platforms have an USB OTG port fully (or partially) controlled by
> > GPIOs:
> >
> > (1) USB
Hi Felipe and Linus,
On Thu, Dec 25, 2014 at 10:49:29PM -0600, Felipe Balbi wrote:
> Hi,
>
> On Wed, Dec 24, 2014 at 02:43:27PM -0800, David Cohen wrote:
> > Hi Felipe,
> >
> > Thanks replying.
> >
> > On Tue, Dec 23, 2014 at 06:29:04PM -0600, Felipe Bal
On Fri, Feb 13, 2015 at 04:03:57PM -0600, Felipe Balbi wrote:
> On Fri, Feb 13, 2015 at 02:02:11PM -0800, David Cohen wrote:
> > Hi Felipe,
> >
> > [snip]
> >
> > > diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
> > > index 8d
Hi Heikki,
On Fri, Feb 13, 2015 at 03:16:40PM +0200, Heikki Krogerus wrote:
> On Thu, Feb 12, 2015 at 05:41:30PM -0800, David Cohen wrote:
> > On Thu, Feb 12, 2015 at 02:12:14PM +0200, Heikki Krogerus wrote:
> > > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc
Hi Felipe,
[snip]
> diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
> index 8d95056..53902ea 100644
> --- a/drivers/usb/dwc3/dwc3-pci.c
> +++ b/drivers/usb/dwc3/dwc3-pci.c
> @@ -21,6 +21,7 @@
> #include
> #include
> #include
> +#include
>
> #include "platform_data
On Thu, Feb 12, 2015 at 05:41:30PM -0800, David Cohen wrote:
> On Thu, Feb 12, 2015 at 02:12:14PM +0200, Heikki Krogerus wrote:
> > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> > > > index a8c9062..66cbf38 100644
> > > > --- a/driver
Hi Heikki,
Sorry I am starting a new branch on this thread.
I need to go back to another topic on this same patch.
On Fri, Jan 23, 2015 at 05:12:58PM +0200, Heikki Krogerus wrote:
> TUSB1210 ULPI PHY has vendor specific register for eye
> diagram tuning. On some platforms the system firmware has
On Thu, Feb 12, 2015 at 02:12:14PM +0200, Heikki Krogerus wrote:
> > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> > > index a8c9062..66cbf38 100644
> > > --- a/drivers/usb/dwc3/core.c
> > > +++ b/drivers/usb/dwc3/core.c
> > > @@ -879,6 +879,10 @@ static int dwc3_probe(struct p
On Thu, Feb 12, 2015 at 12:45:53PM -0600, Felipe Balbi wrote:
> Hi,
>
> On Thu, Feb 12, 2015 at 10:41:37AM -0800, David Cohen wrote:
> > Hi Felipe, et al,
> >
> > Is there any on going discussion regarding to USB phy for type C connectors?
> >
> > We&#x
Hi Felipe, et al,
Is there any on going discussion regarding to USB phy for type C connectors?
We'd like to know the community's preferable direction for handling
(still unsupported) cases like USB3.1 PD, Accessories and Alternate
modes as a new layer or an extension of current USB phy layer.
Co
On Wed, Feb 11, 2015 at 03:12:55PM +0200, Heikki Krogerus wrote:
> Hi David,
Hi Heikki,
>
> > > > > In order for phy to be functional, it does not depend only on toggling
> > > > > GPIOs. It depends on DWC3 going to reset state, then phy executes
> > > > > power
> > > > > on sequence, then DWC3
Hi Heikki,
On Fri, Jan 23, 2015 at 05:12:56PM +0200, Heikki Krogerus wrote:
> Registers DWC3's ULPI interface with the ULPI bus when it's
> available.
>
> Signed-off-by: Heikki Krogerus
> ---
> drivers/usb/dwc3/Kconfig | 7 +++
> drivers/usb/dwc3/Makefile | 4 ++
> drivers/usb/dwc3/core.c
On Tue, Feb 10, 2015 at 11:05:31AM -0800, David Cohen wrote:
> On Mon, Feb 02, 2015 at 02:59:59PM +0200, Heikki Krogerus wrote:
> > > > > > You can't really compare a bus like i2c, which can't enumerate
> > > > > > devices
> > > >
On Mon, Feb 02, 2015 at 02:59:59PM +0200, Heikki Krogerus wrote:
> > > > > You can't really compare a bus like i2c, which can't enumerate devices
> > > > > natively, to ULPI which can.
> > > >
> > > > why not ? The BIOS might not need to use the PHY (or USB) at all, it can
> > > > very well decide
On Tue, Feb 03, 2015 at 01:37:39PM +0200, Heikki Krogerus wrote:
> Hi David, Felipe,
Hi Heikki,
>
> > > > > why would you have dwc3 mess around with the PHY's gpios ? Doesn't
> > > > > look
> > > > > very good.
> > > >
> > > > ..but unfortunately we can't use the bus without it :(. We depend o
On Fri, Jan 30, 2015 at 10:14:12AM -0600, Felipe Balbi wrote:
> On Fri, Jan 30, 2015 at 11:29:56AM +0200, Heikki Krogerus wrote:
> > Hi,
> >
> > > > You can't really compare a bus like i2c, which can't enumerate devices
> > > > natively, to ULPI which can.
> > >
> > > why not ? The BIOS might not
On Fri, Jan 30, 2015 at 11:29:56AM +0200, Heikki Krogerus wrote:
> Hi,
>
> > > You can't really compare a bus like i2c, which can't enumerate devices
> > > natively, to ULPI which can.
> >
> > why not ? The BIOS might not need to use the PHY (or USB) at all, it can
> > very well decide to never t
On Fri, Jan 30, 2015 at 02:18:42PM +0200, Heikki Krogerus wrote:
> Hi,
>
> > > > What exactly are we breaking here? The USB on BYT-CR does not work yet
> > > > with the mainline kernel, or does it? To enable it, I already
> > > > suggested the BYT quirk (attached again).
> >
> > It used to work w
On Thu, Jan 29, 2015 at 10:25:38AM -0800, David Cohen wrote:
> On Thu, Jan 29, 2015 at 10:04:16AM -0800, David Cohen wrote:
> > On Thu, Jan 29, 2015 at 10:20:49AM -0600, Felipe Balbi wrote:
> > > On Thu, Jan 29, 2015 at 04:30:53PM +0200, Heikki Krogerus wrote:
> > >
On Thu, Jan 29, 2015 at 10:04:16AM -0800, David Cohen wrote:
> On Thu, Jan 29, 2015 at 10:20:49AM -0600, Felipe Balbi wrote:
> > On Thu, Jan 29, 2015 at 04:30:53PM +0200, Heikki Krogerus wrote:
> > > > Also, I was chatting in private with David and, apparently, there's a
On Thu, Jan 29, 2015 at 10:20:49AM -0600, Felipe Balbi wrote:
> On Thu, Jan 29, 2015 at 04:30:53PM +0200, Heikki Krogerus wrote:
> > > Also, I was chatting in private with David and, apparently, there's a
> > > way to request for eye diagram data from BIOS straight. That's more
> > > in-line with w
Hi Heikki, Felipe,
On Thu, Jan 29, 2015 at 10:20:23AM -0600, Felipe Balbi wrote:
> Hi
>
> On Thu, Jan 29, 2015 at 04:14:12PM +0200, Heikki Krogerus wrote:
> > > > > > > Can you share how tusb1210 is connected on the platform you're
> > > > > > > using as
> > > > > > > test for this patch? I don'
On Wed, Jan 28, 2015 at 04:20:25PM +0200, Heikki Krogerus wrote:
> Hi,
>
> > > > Can you share how tusb1210 is connected on the platform you're using as
> > > > test for this patch? I don't think this driver would work reliably with
> > > > this device:
> > > > http://liliputing.com/2014/11/trekst
On Tue, Jan 27, 2015 at 11:28:56AM +0200, Heikki Krogerus wrote:
> On Mon, Jan 26, 2015 at 11:23:37AM -0800, David Cohen wrote:
> > On Mon, Jan 26, 2015 at 02:55:03PM +0200, Heikki Krogerus wrote:
> > > On Sat, Jan 24, 2015 at 03:58:11PM -0800, David Cohen wrote:
>
Hi Heikki,
On Mon, Jan 26, 2015 at 02:55:03PM +0200, Heikki Krogerus wrote:
> Hi David,
>
> On Sat, Jan 24, 2015 at 03:58:11PM -0800, David Cohen wrote:
> > > +static int tusb1210_power_on(struct phy *phy)
> > > +{
> > > + struct
Hi Heikki,
On Fri, Jan 23, 2015 at 05:12:58PM +0200, Heikki Krogerus wrote:
> TUSB1210 ULPI PHY has vendor specific register for eye
> diagram tuning. On some platforms the system firmware has
> set optimized value to it. In order to not loose the
> optimized value, the driver stores it during pro
On Wed, Dec 24, 2014 at 11:08:52AM +0800, Peter Chen wrote:
> On Tue, Dec 23, 2014 at 11:40:23AM -0800, David Cohen wrote:
> > Hi Peter,
> >
> > Thanks for the review.
> >
> > On Tue, Dec 23, 2014 at 09:25:18AM +0800, Peter Chen wrote:
> > > On Mon, Dec
Hi Felipe,
Thanks replying.
On Tue, Dec 23, 2014 at 06:29:04PM -0600, Felipe Balbi wrote:
> Hi,
>
> On Mon, Dec 22, 2014 at 02:43:37PM -0800, David Cohen wrote:
> > Some platforms have an USB OTG port fully (or partially) controlled by
> > GPIOs:
> >
> > (1
ted or USB cable
> > was unplugged, which indicates that we don't need to stay longer in
> > FFS_DEACTIVATED state
> > - unmounting of the FunctionFS instance causes the function to be closed.
> >
> > Signed-off-by: Robert Baldyga
>
> David, can you
On Tue, Dec 23, 2014 at 11:09:44PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 12/23/2014 10:57 PM, David Cohen wrote:
>
> >>>Some platforms have an USB OTG port fully (or partially) controlled by
> >>>GPIOs:
>
> >>>(1) USB ID is connected di
Hi Sergei,
On Tue, Dec 23, 2014 at 04:10:44PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 12/23/2014 1:43 AM, David Cohen wrote:
>
> >Some platforms have an USB OTG port fully (or partially) controlled by
> >GPIOs:
>
> >(1) USB ID is connected directly to G
Hi Peter,
Thanks for the review.
On Tue, Dec 23, 2014 at 09:25:18AM +0800, Peter Chen wrote:
> On Mon, Dec 22, 2014 at 02:43:37PM -0800, David Cohen wrote:
> > Some platforms have an USB OTG port fully (or partially) controlled by
> > GPIOs:
> >
> > (1) USB ID is
switched between phys
by GPIO.
As per initial version, this driver has the duty to control whether
USB-Host cable is plugged in or not:
- If yes, OTG port is configured for host role
- If no, by standard, the OTG port is configured for device role
Signed-off-by: David Cohen
---
Hi,
Some
On Tue, Nov 04, 2014 at 09:34:24PM +0200, Mika Westerberg wrote:
> On Tue, Nov 04, 2014 at 11:11:16AM -0800, David Cohen wrote:
> > > It is not implicit at all.
> > >
> > > The user of the GPIO in ACPI DSDT table says something like:
> > >
>
On Tue, Nov 04, 2014 at 08:57:02PM +0200, Mika Westerberg wrote:
> On Tue, Nov 04, 2014 at 10:05:26AM -0800, David Cohen wrote:
> > On Tue, Nov 04, 2014 at 09:59:36AM +0200, Mika Westerberg wrote:
> > > On Mon, Nov 03, 2014 at 02:19:03PM -0800, David Cohen wrot
On Tue, Nov 04, 2014 at 09:59:36AM +0200, Mika Westerberg wrote:
> On Mon, Nov 03, 2014 at 02:19:03PM -0800, David Cohen wrote:
> > Hi Mika,
> >
> > Thanks for your feedbacks :)
> >
> > On Mon, Nov 03, 2014 at 08:42:47PM +0200, Mika Westerberg wrote:
> &g
v 03, 2014 at 05:27:43PM +0200, Mika Westerberg wrote:
> > > > On Mon, Nov 03, 2014 at 09:00:48AM -0600, Felipe Balbi wrote:
> > > > > On Mon, Nov 03, 2014 at 11:24:02AM +0200, Mika Westerberg wrote:
> > > > > > On Fri, Oct 31, 2014 at 11:45:09AM -0700, D
On Fri, Oct 31, 2014 at 09:23:39AM -0700, David Cohen wrote:
> On Fri, Oct 31, 2014 at 08:20:05AM -0500, Felipe Balbi wrote:
> > Hi,
> >
> > On Fri, Oct 31, 2014 at 09:12:16AM +0100, Linus Walleij wrote:
> > > On Tue, Oct 28, 2014 at 3:42 PM, Felipe Balbi wrote:
&
On Fri, Oct 31, 2014 at 08:20:05AM -0500, Felipe Balbi wrote:
> Hi,
>
> On Fri, Oct 31, 2014 at 09:12:16AM +0100, Linus Walleij wrote:
> > On Tue, Oct 28, 2014 at 3:42 PM, Felipe Balbi wrote:
> > > On Tue, Oct 28, 2014 at 11:15:20AM +0100, Linus Walleij wrote:
> > >> On Mon, Oct 13, 2014 at 9:36
On Tue, Oct 28, 2014 at 04:10:26PM +0100, Linus Walleij wrote:
> On Fri, Oct 17, 2014 at 3:53 AM, David Cohen
> wrote:
> > On Thu, Oct 16, 2014 at 11:01:23AM +0300, Mika Westerberg wrote:
>
> >> In an ideal world, yes. However, the reality has shown that BIOS/FW gets
>
On Mon, Oct 20, 2014 at 10:15:17AM -0600, Bjorn Helgaas wrote:
> On Thu, Oct 16, 2014 at 7:41 PM, David Cohen
> wrote:
> > Hi Bjorn and Sathya,
> >
> > On Thu, Oct 16, 2014 at 05:42:11PM -0700, sathyanarayanan kuppuswamy wrote:
> >> Hi Bjorn,
> >>
> &
On Thu, Oct 16, 2014 at 11:01:23AM +0300, Mika Westerberg wrote:
> On Wed, Oct 15, 2014 at 09:55:42AM -0700, David Cohen wrote:
> > Hi Mika,
> >
> > Thanks for your feedback. See below my reply.
> >
> > On Wed, Oct 15, 2014 at 10:08:12AM +0300, Mika Westerberg
entation, so they do not need to be marked "weak".
> >>
> >>Remove the "weak" attribute from their declarations.
> >>
> >>Signed-off-by: Bjorn Helgaas
> >>CC: David Cohen
> >>CC: Kuppuswamy Sathyanarayanan
> >>CC: x...@
On Wed, Oct 15, 2014 at 10:57:00PM +0100, Ian Abbott wrote:
> On 15/10/14 22:25, David Cohen wrote:
> >ii_pci20kc uses io memory which makes it not compilable on architectures
> >without HAS_IOMEM such as UML:
> >
> > CC drivers/net/wireless/ti/wl1251/main.
clocksource Renesas CMT, MTU2 and TMU use io memory which make them not
compilable on architectures without HAS_IOMEM such as UML.
Signed-off-by: David Cohen
---
drivers/clocksource/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/clocksource/Kconfig b
p'
Signed-off-by: David Cohen
---
drivers/net/can/m_can/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/can/m_can/Kconfig b/drivers/net/can/m_can/Kconfig
index fca5482c09ac..04f20dd39007 100644
--- a/drivers/net/can/m_can/Kconfig
+++ b/drivers/net/can/m_can/Kconf
clps711x uses io memory which makes it not compilable on architectures
without HAS_IOMEM such as UML:
drivers/built-in.o: In function `clps711x_pwm_probe':
pwm-clps711x.c:(.text+0x2848): undefined reference to
`devm_ioremap_resource'
Signed-off-by: David Cohen
---
drivers/pwm/Kconfig
rivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_detach’:
drivers/staging/comedi/drivers/ii_pci20kc.c:512:3: error: implicit
declaration of function ‘iounmap’
[-Werror=implicit-function-declaration]
iounmap(dev->mmio);
^
Signed-off-by: David Cohen
---
drivers/staging/comedi/Kc
On Wed, Oct 15, 2014 at 12:06:10PM -0500, Felipe Balbi wrote:
> On Wed, Oct 15, 2014 at 10:01:45AM -0700, David Cohen wrote:
> > On Wed, Oct 15, 2014 at 09:57:18AM -0700, David Cohen wrote:
> > > On Wed, Oct 15, 2014 at 12:00:22AM -0500, Felipe Balbi wrote:
> > > > Hi
On Wed, Oct 15, 2014 at 09:57:18AM -0700, David Cohen wrote:
> On Wed, Oct 15, 2014 at 12:00:22AM -0500, Felipe Balbi wrote:
> > Hi,
> >
> > On Tue, Oct 14, 2014 at 01:15:05PM -0700, David Cohen wrote:
> > > ERRATIC_ERROR interrupt is an event that needs more attent
On Wed, Oct 15, 2014 at 12:00:22AM -0500, Felipe Balbi wrote:
> Hi,
>
> On Tue, Oct 14, 2014 at 01:15:05PM -0700, David Cohen wrote:
> > ERRATIC_ERROR interrupt is an event that needs more attention from
> > developers than currently implemented, since this indicates a seriou
Hi Mika,
Thanks for your feedback. See below my reply.
On Wed, Oct 15, 2014 at 10:08:12AM +0300, Mika Westerberg wrote:
> On Tue, Oct 14, 2014 at 10:45:35AM -0700, David Cohen wrote:
> > Hi Mathias,
> >
> > On Tue, Oct 14, 2014 at 01:35:43PM +0300, Mathias Nyman wrote:
>
On Tue, Oct 14, 2014 at 07:08:43PM -0400, Sasha Levin wrote:
> On 10/14/2014 04:29 PM, David Cohen wrote:
> >> + VM_BUG_ON(PageTail(page));
> >> > +VM_BUG_ON(PageHead(page) && compound_order(page) != order);
> > It may be too severe. AFAIU we'
UG_ON(PageTail(page));
> + VM_BUG_ON(PageHead(page) && compound_order(page) != order);
It may be too severe. AFAIU we're not talking about a fatal error.
How about VM_WARN_ON()?
Br, David Cohen
> +
> trace_mm_page_free(page, order);
> kmemcheck_free_shadow(
y.
Signed-off-by: David Cohen
---
drivers/usb/dwc3/gadget.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 3818b26bfc05..132e761d62e4 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -2484
Hi Mathias,
On Tue, Oct 14, 2014 at 01:35:43PM +0300, Mathias Nyman wrote:
> On 13.10.2014 22:17, David Cohen wrote:
> > Even though GPIO module on Intel Bay Trail is able to control pin
> > functionality, it's unlikely Linux kernel driver will ever support it
> > since
Even if a gpio pin is set to output, we still need to set INPUT_EN
functionality (by clearing INPUT_EN bit) to be able to read the pin's
level.
E.g. without this change, we'll always read low level state from sysfs.
Cc: # v3.14+
Cc: Mathias Nyman
Signed-off-by: David Cohen
---
tch adds module_exit().
>
> Signed-off-by: Felipe Balbi
This is a quite trivial patch, so not sure you need an Ack from somebody
that has the actual hw. In case you do:
Acked-by: David Cohen
> ---
> drivers/pinctrl/pinctrl-baytrail.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 de
On Mon, Oct 13, 2014 at 02:36:18PM -0500, Felipe Balbi wrote:
> On Mon, Oct 13, 2014 at 02:26:32PM -0500, Felipe Balbi wrote:
> > Hi,
> >
> > On Mon, Oct 13, 2014 at 12:24:04PM -0700, David Cohen wrote:
> > > On Mon, Oct 13, 2014 at 02:14:05PM -0500, Felipe Balbi
1 - 100 of 521 matches
Mail list logo
