Re: [PATCH 016/141] nfsd: Fix fall-through warnings for Clang

2021-04-20 Thread Chuck Lever III
> On Apr 20, 2021, at 4:28 PM, Gustavo A. R. Silva > wrote: > > Hi all, > > Friendly ping: who can take this, please? Hum. I thought this was going through another tree. I can take it for the second v5.13 NFSD PR. > Thanks > -- > Gustavo > > On 11/23/20 16:46, Gustavo A. R. Silva wrote:

Re: [PATCH] nfsd: remove unused function

2021-04-15 Thread Chuck Lever III
> On Apr 15, 2021, at 4:38 AM, Jiapeng Chong > wrote: > > Fix the following clang warning: > > fs/nfsd/nfs4state.c:6276:1: warning: unused function 'end_offset' > [-Wunused-function]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Thanks for your patch. It's been added to th

Re: [PATCH rdma-next 00/10] Enable relaxed ordering for ULPs

2021-04-09 Thread Chuck Lever III
> On Apr 9, 2021, at 10:26 AM, Tom Talpey wrote: > > On 4/6/2021 7:49 AM, Jason Gunthorpe wrote: >> On Mon, Apr 05, 2021 at 11:42:31PM +0000, Chuck Lever III wrote: >> >>> We need to get a better idea what correctness testing has been done, >>> a

Re: [PATCH -next] NFSD: Use DEFINE_SPINLOCK() for spinlock

2021-04-06 Thread Chuck Lever III
Hello- > On Apr 6, 2021, at 8:08 AM, Huang Guobin wrote: > > From: Guobin Huang > > spinlock can be initialized automatically with DEFINE_SPINLOCK() > rather than explicitly calling spin_lock_init(). > > Reported-by: Hulk Robot > Signed-off-by: Guobin Huang This change has been pushed to t

Re: [PATCH] sunrpc: Remove unused function ip_map_lookup

2021-04-06 Thread Chuck Lever III
Hello- > On Apr 5, 2021, at 11:46 PM, Jiapeng Chong > wrote: > > Fix the following clang warnings: > > net/sunrpc/svcauth_unix.c:306:30: warning: unused function > 'ip_map_lookup' [-Wunused-function]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong This has been pushed to the f

Re: [PATCH -next] NFSD: Use DEFINE_SPINLOCK() for spinlock

2021-04-06 Thread Chuck Lever III
> On Apr 6, 2021, at 8:08 AM, Huang Guobin wrote: > > From: Guobin Huang > > spinlock can be initialized automatically with DEFINE_SPINLOCK() > rather than explicitly calling spin_lock_init(). > > Reported-by: Hulk Robot > Signed-off-by: Guobin Huang This same patch was sent last July, w

Re: [PATCH rdma-next 00/10] Enable relaxed ordering for ULPs

2021-04-05 Thread Chuck Lever III
> On Apr 5, 2021, at 4:07 PM, Jason Gunthorpe wrote: > > On Mon, Apr 05, 2021 at 03:41:15PM +0200, Christoph Hellwig wrote: >> On Mon, Apr 05, 2021 at 08:23:54AM +0300, Leon Romanovsky wrote: >>> From: Leon Romanovsky >>> From Avihai, >>> >>> Relaxed Ordering is a PCIe mechanism that r

Re: [PATCH 2/2] SUNRPC: Refresh rq_pages using a bulk page allocator

2021-03-23 Thread Chuck Lever III
> On Mar 23, 2021, at 3:56 PM, Mel Gorman wrote: > > On Tue, Mar 23, 2021 at 11:10:05AM -0400, Chuck Lever wrote: >> Reduce the rate at which nfsd threads hammer on the page allocator. >> This improves throughput scalability by enabling the threads to run >> more independently of each other. >

Re: [PATCH 0/3 v5] Introduce a bulk order-0 page allocator

2021-03-23 Thread Chuck Lever III
> On Mar 23, 2021, at 10:45 AM, Mel Gorman wrote: > > On Tue, Mar 23, 2021 at 12:08:51PM +0100, Jesper Dangaard Brouer wrote: My results show that, because svc_alloc_arg() ends up calling __alloc_pages_bulk() twice in this case, it ends up being twice as expensive as the l

Re: [PATCH 0/3 v5] Introduce a bulk order-0 page allocator

2021-03-22 Thread Chuck Lever III
> On Mar 22, 2021, at 3:49 PM, Mel Gorman wrote: > > On Mon, Mar 22, 2021 at 06:25:03PM +0000, Chuck Lever III wrote: >> >> >>> On Mar 22, 2021, at 5:18 AM, Mel Gorman wrote: >>> >>> This series is based on top of Matthew Wilcox's se

Re: [PATCH 0/3 v5] Introduce a bulk order-0 page allocator

2021-03-22 Thread Chuck Lever III
> On Mar 22, 2021, at 5:18 AM, Mel Gorman wrote: > > This series is based on top of Matthew Wilcox's series "Rationalise > __alloc_pages wrapper" and does not apply to 5.12-rc2. If you want to > test and are not using Andrew's tree as a baseline, I suggest using the > following git tree > > g

Re: [PATCH] SUNRPC: Output oversized frag reclen as ASCII if printable

2021-03-22 Thread Chuck Lever III
> On Mar 19, 2021, at 6:08 PM, J. Bruce Fields wrote: > > On Fri, Mar 19, 2021 at 02:58:14PM +0000, Chuck Lever III wrote: >> Hi Chris- >> >>> On Mar 19, 2021, at 10:54 AM, Chris Down wrote: >>> >>> The reclen is taken directly from the firs

Re: [PATCH] SUNRPC: Output oversized frag reclen as ASCII if printable

2021-03-19 Thread Chuck Lever III
Hi Chris- > On Mar 19, 2021, at 10:54 AM, Chris Down wrote: > > The reclen is taken directly from the first four bytes of the message > with the highest bit stripped, which makes it ripe for protocol mixups. > For example, if someone tries to send a HTTP GET request to us, we'll > interpret it a

Re: [PATCH 2/5] mm/page_alloc: Add a bulk page allocator

2021-03-14 Thread Chuck Lever III
> On Mar 14, 2021, at 8:52 AM, Mel Gorman wrote: > > On Sat, Mar 13, 2021 at 07:33:43PM +, Matthew Wilcox wrote: >> On Sat, Mar 13, 2021 at 04:56:31PM +0000, Chuck Lever III wrote: >>> IME lists are indeed less CPU-efficient, but I wonder if that >>> exp

Re: [PATCH 2/5] mm/page_alloc: Add a bulk page allocator

2021-03-13 Thread Chuck Lever III
> On Mar 13, 2021, at 11:39 AM, Matthew Wilcox wrote: > > On Sat, Mar 13, 2021 at 01:16:48PM +, Mel Gorman wrote: >>> I'm not claiming the pagevec is definitely a win, but it's very >>> unclear which tradeoff is actually going to lead to better performance. >>> Hopefully Jesper or Chuck ca

Re: [PATCH 5/7] SUNRPC: Refresh rq_pages using a bulk page allocator

2021-03-12 Thread Chuck Lever III
Mel, I can send you a tidied and tested update to this patch, or you can drop the two NFSD patches and I can submit them via the NFSD tree when alloc_pages_bulk() is merged. > On Mar 12, 2021, at 1:44 PM, Alexander Duyck > wrote: > > On Fri, Mar 12, 2021 at 7:43 AM Mel Gorman > wrote: >> >>

Re: [PATCH v25 17/25] LSM: Use lsmcontext in security_inode_getsecctx

2021-03-12 Thread Chuck Lever III
Hi Casey- > On Mar 9, 2021, at 9:42 AM, Casey Schaufler wrote: > > Change the security_inode_getsecctx() interface to fill > a lsmcontext structure instead of data and length pointers. > This provides the information about which LSM created the > context so that security_release_secctx() can use

Re: [PATCH 3/5] SUNRPC: Refresh rq_pages using a bulk page allocator

2021-03-11 Thread Chuck Lever III
> On Mar 11, 2021, at 6:49 AM, Mel Gorman wrote: > > From: Chuck Lever > > Reduce the rate at which nfsd threads hammer on the page allocator. > This improve throughput scalability by enabling the threads to run > more independently of each other. Mel, if you should repost this series: ^imp