Re: [PATCH] kconfig: split menu.c out of parser.y

2021-04-15 Thread Boris Kolpackov
Masahiro Yamada writes: > --- /dev/null > +++ b/scripts/kconfig/internal.h > @@ -0,0 +1,9 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +#ifndef INTERNAL_H > +#define INTERNAL_H > + > +struct menu; > + > +extern struct menu *current_menu, *current_entry; > + > +#endif /* INTERNAL_H */ Mayb

[PATCH] xen: Remove support for PV ACPI cpu/memory hotplug

2021-04-13 Thread Boris Ostrovsky
is of no interest to anyone and therefore should be removed. Signed-off-by: Boris Ostrovsky --- drivers/xen/Kconfig | 31 --- drivers/xen/Makefile | 3 - drivers/xen/pcpu.c| 35 --- drivers/xen/xen-acpi-cpuhotplug.c | 446

Re: [PATCH-next] fs/btrfs: Fix uninitialized variable

2021-04-13 Thread Boris Burkov
On Tue, Apr 13, 2021 at 02:06:04PM +0100, Khaled ROMDHANI wrote: > The variable zone is not initialized. It > may causes a failed assertion. > > Addresses-Coverity: ("Uninitialized variables") > > Signed-off-by: Khaled ROMDHANI Reviewed-by: Boris Burkov > ---

Re: [PATCH] xen/evtchn: Change irq_info lock to raw_spinlock_t

2021-04-07 Thread Boris Ostrovsky
m spinlock_t > to raw_spinlock_t > > Cc: sta...@vger.kernel.org > Fixes: 25da4618af24 ("xen/events: don't unmask an event channel > when an eoi is pending") > > Signed-off-by: Luca Fancellu Applied to for-linus-5.12b -boris

Re: linux-next: Fixes tag needs some work in the xen-tip tree

2021-04-06 Thread Boris Ostrovsky
oblem(s): > > - Subject has leading but no trailing parentheses > - Subject has leading but no trailing quotes > > Please do not split Fixes tags over more than one line. Also, please > keep all the commit message tags together at the end of te commit message. Thanks, fixed. -boris

Re: [PATCH v10 3/4] mtd: rawnand: Add support for secure regions in NAND memory

2021-04-02 Thread Boris Brezillon
On Thu, 1 Apr 2021 21:46:22 +0530 Manivannan Sadhasivam wrote: > On Thu, Apr 01, 2021 at 05:54:21PM +0200, Boris Brezillon wrote: > > On Thu, 1 Apr 2021 20:49:54 +0530 > > Manivannan Sadhasivam wrote: > > > > > @@ -565,6 +608,11 @@ static int nand_bl

Re: [PATCH v8 3/3] mtd: rawnand: Add support for secure regions in NAND memory

2021-04-01 Thread Boris Brezillon
On Thu, 1 Apr 2021 15:48:12 +0530 Manivannan Sadhasivam wrote: > static int nand_isbad_bbm(struct nand_chip *chip, loff_t ofs) > { > + struct mtd_info *mtd = nand_to_mtd(chip); > + int last_page = ((mtd->erasesize - mtd->writesize) >> > +chip->page_shift) & c

Re: [PATCH v10 3/4] mtd: rawnand: Add support for secure regions in NAND memory

2021-04-01 Thread Boris Brezillon
On Thu, 1 Apr 2021 20:49:54 +0530 Manivannan Sadhasivam wrote: > @@ -565,6 +608,11 @@ static int nand_block_isreserved(struct mtd_info *mtd, > loff_t ofs) > > if (!chip->bbt) > return 0; > + > + /* Check if the region is secured */ > + if (nand_region_is_secured(ch

Re: [PATCH v3 05/25] x86/sgx: Introduce virtual EPC for use by KVM guests

2021-03-31 Thread Boris Petkov
On March 31, 2021 8:51:38 AM GMT+02:00, Kai Huang wrote: >How about adding explanation to Documentation/x86/sgx.rst? Sure, and then we should point users at it. The thing is also indexed by search engines so hopefully people will find it. Thx. -- Sent from a small device: formatting sux and b

Re: [PATCH v3 05/25] x86/sgx: Introduce virtual EPC for use by KVM guests

2021-03-30 Thread Boris Petkov
On March 31, 2021 3:10:32 AM GMT+02:00, Kai Huang wrote: > The admin will be aware of >such EPC >allocation disjoint situation, and deploy host enclaves/KVM SGX guests >accordingly. The admin will be aware because... 1) he's following our discussion? 2) he'll read the commit messages and hope

Re: [PATCH v2 0/2] xen/x86: alternative fix for XSA-369

2021-03-25 Thread Boris Ostrovsky
On 3/24/21 7:09 PM, Boris Ostrovsky wrote: > On 3/24/21 8:24 AM, Roger Pau Monne wrote: >> Hello, >> >> This is a proposal for an alternative fix for XSA-369 that instead of >> special casing XEN_UNPOPULATED_ALLOC to size the p2m relies on making >> XEN_BALLOON_M

Re: [PATCH v2 0/2] xen/x86: alternative fix for XSA-369

2021-03-24 Thread Boris Ostrovsky
PLUG > Revert "xen: fix p2m size in dom0 for disabled memory hotplug case" > > arch/x86/include/asm/xen/page.h | 12 > arch/x86/xen/p2m.c | 7 ++- > arch/x86/xen/setup.c| 16 ++-- > drivers/xen/Kconfig

Re: [PATCH 2/2] Revert "xen: fix p2m size in dom0 for disabled memory hotplug case"

2021-03-22 Thread Boris Ostrovsky
ks out-of-date in light of deprecated support for 32-bit PV. So I think we don't need to revert this part (except for the macro name). -boris

Re: [PATCH v7 3/3] mtd: rawnand: Add support for secure regions in NAND memory

2021-03-19 Thread Boris Brezillon
On Fri, 19 Mar 2021 20:30:10 +0530 Manivannan Sadhasivam wrote: > @@ -2737,6 +2783,11 @@ static int nand_read_page_swecc(struct nand_chip > *chip, uint8_t *buf, > uint8_t *ecc_code = chip->ecc.code_buf; > unsigned int max_bitflips = 0; > > + /* Check if the region is secured */

Re: [PATCH v7 3/3] mtd: rawnand: Add support for secure regions in NAND memory

2021-03-19 Thread Boris Brezillon
On Fri, 19 Mar 2021 20:30:10 +0530 Manivannan Sadhasivam wrote: > On a typical end product, a vendor may choose to secure some regions in > the NAND memory which are supposed to stay intact between FW upgrades. > The access to those regions will be blocked by a secure element like > Trustzone. So

Re: [PATCH] xen/evtchn: replace if (cond) BUG() with BUG_ON()

2021-03-17 Thread Boris Ostrovsky
, &close) != 0); Is it actually worth doing a BUG() here at all? Seems to me WARN_ON_ONCE() should be sufficient. -boris > del_evtchn(u, evtchn); > return rc; > }

Re: [PATCH v5 3/3] mtd: rawnand: Add support for secure regions in NAND memory

2021-03-17 Thread Boris Brezillon
On Wed, 17 Mar 2021 19:22:49 +0530 Manivannan Sadhasivam wrote: > On Wed, Mar 17, 2021 at 02:14:49PM +0100, Boris Brezillon wrote: > > On Wed, 17 Mar 2021 17:55:13 +0530 > > Manivannan Sadhasivam wrote: > > > > > On a typical end product, a vendor may ch

Re: [PATCH v5 3/3] mtd: rawnand: Add support for secure regions in NAND memory

2021-03-17 Thread Boris Brezillon
On Wed, 17 Mar 2021 17:55:13 +0530 Manivannan Sadhasivam wrote: > On a typical end product, a vendor may choose to secure some regions in > the NAND memory which are supposed to stay intact between FW upgrades. > The access to those regions will be blocked by a secure element like > Trustzone. So

Re: [PATCH 07/13] kconfig: move conf_set_all_new_symbols() to conf.c

2021-03-15 Thread Boris Kolpackov
Masahiro Yamada writes: > This function is only used in conf.c. Move it there together with the > randomize_choice_values() helper. > > [...] > > diff --git a/scripts/kconfig/lkc.h b/scripts/kconfig/lkc.h > index f946ab49ef50..d0d5acecb530 100644 > --- a/scripts/kconfig/lkc.h > +++ b/scripts/kcon

Re: [PATCH v4 0/3] xen/events: bug fixes and some diagnostic aids

2021-03-11 Thread Boris Ostrovsky
On 3/6/21 11:18 AM, Juergen Gross wrote: > Those are fixes for XSA-332. > > The rest of the V3 patches have been applied already. There is one > additional fix in patch 2 which addresses network outages when a guest > is doing reboot loops. > > Juergen Gross (3): > xen/events: reset affinity of

Re: linux-next: Fixes tag needs some work in the xen-tip tree

2021-03-10 Thread Boris Ostrovsky
EOI evtchn > framework") > > has these problem(s): > > - Subject does not match target commit subject > Just use > git log -1 --format='Fixes: %h ("%s")' Sigh... Missed this again. Updated to    Fixes: 54c9de89895e ("xen/events: add a new "late EOI" evtchn framework") -boris

Re: [PATCH v4 2/3] dt-bindings: mtd: Add a property to declare secure regions in NAND chips

2021-03-08 Thread Boris Brezillon
On Mon, 8 Mar 2021 19:01:34 +0530 Manivannan Sadhasivam wrote: > On Mon, Mar 08, 2021 at 10:10:59AM +0100, Boris Brezillon wrote: > > On Mon, 8 Mar 2021 11:14:46 +0530 > > Manivannan Sadhasivam wrote: > > > > > On a typical end product, a vendor may ch

Re: [PATCH v4 2/3] xen/events: don't unmask an event channel when an eoi is pending

2021-03-08 Thread Boris Ostrovsky
EOI evtchn framework") > Reported-by: Julien Grall > Signed-off-by: Juergen Gross > Reviewed-by: Julien Grall > --- > V2: > - introduce a lock around masking/unmasking > - merge patch 3 into this one (Jan Beulich) > V4: > - don't set eoi masking flag in lat

Re: [PATCH v5 02/12] x86/paravirt: switch time pvops functions to use static_call()

2021-03-08 Thread Boris Ostrovsky
; #include > @@ -175,7 +176,7 @@ void __init xen_time_setup_guest(void) > xen_runstate_remote = !HYPERVISOR_vm_assist(VMASST_CMD_enable, > VMASST_TYPE_runstate_update_flag); > > - pv_ops.time.steal_clock = xen_steal_clock; > + static_call_update(pv_steal_clock,

Re: [PATCH v4 2/3] dt-bindings: mtd: Add a property to declare secure regions in NAND chips

2021-03-08 Thread Boris Brezillon
On Mon, 8 Mar 2021 11:14:46 +0530 Manivannan Sadhasivam wrote: > On a typical end product, a vendor may choose to secure some regions in > the NAND memory which are supposed to stay intact between FW upgrades. > The access to those regions will be blocked by a secure element like > Trustzone. So

Re: [PATCH v4 3/3] mtd: rawnand: qcom: Add support for secure regions in NAND memory

2021-03-08 Thread Boris Brezillon
On Mon, 8 Mar 2021 11:14:47 +0530 Manivannan Sadhasivam wrote: > On a typical end product, a vendor may choose to secure some regions in > the NAND memory which are supposed to stay intact between FW upgrades. > The access to those regions will be blocked by a secure element like > Trustzone. So

Re: [PATCH 02/25] x86/cpufeatures: Add SGX1 and SGX2 sub-features

2021-03-02 Thread Boris Petkov
On March 2, 2021 5:02:13 PM GMT+01:00, Sean Christopherson wrote: >The KVM use case is to query /proc/cpuinfo to see if sgx2 can be >enabled in a >guest. You mean before the guest ia created? I sure hope there's a better way to query HV-supported features than grepping /proc/cpuinfo... >The co

Re: [PATCH v1] xen: ACPI: Get rid of ACPICA message printing

2021-03-01 Thread Boris Ostrovsky
On 3/1/21 9:11 AM, Rafael J. Wysocki wrote: > On Sun, Feb 28, 2021 at 2:49 AM Boris Ostrovsky > wrote: >> >> On 2/24/21 1:47 PM, Rafael J. Wysocki wrote: >>> From: Rafael J. Wysocki >>> >>> The ACPI_DEBUG_PRINT() macro is used in a few pla

Re: [PATCH v1] xen: ACPI: Get rid of ACPICA message printing

2021-02-27 Thread Boris Ostrovsky
the question is whether we want to keep these files. Obviously noone cares about this functionality. -boris

Re: [PATCH v1] xen: ACPI: Get rid of ACPICA message printing

2021-02-25 Thread Boris Ostrovsky
at code. > > Signed-off-by: Rafael J. Wysocki Reviewed-by: Boris Ostrovsky

Re: [PATCH] xen: Replace lkml.org links with lore

2021-02-23 Thread Boris Ostrovsky
On 2/10/21 6:46 PM, Kees Cook wrote: > As started by commit 05a5f51ca566 ("Documentation: Replace lkml.org > links with lore"), replace lkml.org links with lore to better use a > single source that's more likely to stay available long-term. > > Signed-off-by: K

Re: [PATCH v3 0/8] xen/events: bug fixes and some diagnostic aids

2021-02-23 Thread Boris Ostrovsky
nd settings > xen/evtchn: use smp barriers for user event ring > xen/evtchn: use READ/WRITE_ONCE() for accessing ring indices > I am going to pick up the last 3 patches since Ross appears to be having some issues with #2 (and 4 and 5 went in via netdev tree) -boris

Re: linux-next: Fixes tag needs some work in the xen-tip tree

2021-02-22 Thread Boris Ostrovsky
EOI evtchn > framework") > > has these problem(s): > > - Subject does not match target commit subject > Just use > git log -1 --format='Fixes: %h ("%s")' Yes, it lost quotes:    Fixes: 54c9de89895e ("xen/events: add a new "late EOI" evtchn framework") Thanks. -boris

Re: [PATCH v3 8/8] xen/evtchn: use READ/WRITE_ONCE() for accessing ring indices

2021-02-20 Thread Boris Ostrovsky
On 2/19/21 10:40 AM, Juergen Gross wrote: > For avoiding read- and write-tearing by the compiler use READ_ONCE() > and WRITE_ONCE() for accessing the ring indices in evtchn.c. > > Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky

Re: [PATCH RFC v1 5/6] xen-swiotlb: convert variables to arrays

2021-02-19 Thread Boris Ostrovsky
could kill >>> off most of swiotlb-xen instead of maintaining all this code duplication? >> So I looked at this a bit more. >> >> For x86 with XENFEAT_auto_translated_physmap (how common is that?) > Juergen, Boris please correct me if I am wrong, but that > XENF

Re: [PATCH v2 6/8] xen/events: add per-xenbus device event statistics and settings

2021-02-15 Thread Boris Ostrovsky
being rogue on purpose. > > Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky

Re: [PATCH v2 3/8] xen/events: avoid handling the same event on two cpus at the same time

2021-02-15 Thread Boris Ostrovsky
rq()/lateeoi_mask_ack_dynirq(), after we've masked the channel? Then it will be consistent with how how other chips do it, especially with the new helper. -boris > do_unmask(info, EVT_MASK_REASON_EOI_PENDING); > } >

Re: [PATCH v1 2/3] kconfig: Ask user if string needs to be changed when dependency changed

2021-02-15 Thread Boris Kolpackov
Mickaël Salaün writes: > Content of string configuration may depend on related kernel > configurations. Modify oldconfig and syncconfig to inform users about > possible required configuration update and give them the opportunity to > update it: > * if dependencies of this string has changed (e.g

Re: [PATCH 5/7] xen/events: add per-xenbus device event statistics and settings

2021-02-08 Thread Boris Ostrovsky
s(+), 2 deletions(-) This needs Documentation/ABI update. -boris

Re: [PATCH 4/7] xen/events: link interdomain events to associated xenbus device

2021-02-08 Thread Boris Ostrovsky
inter to the xenbus device as a > parameter instead of the domain id of the other side. > > While at it remove the stale prototype of bind_evtchn_to_irq_lateeoi(). > > Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky

Re: [PATCH] mtd: rawnand: Do not check for bad block if bbt is unavailable

2021-02-04 Thread Boris Brezillon
On Thu, 4 Feb 2021 10:04:08 +0100 Miquel Raynal wrote: > Hi Boris, > > Boris Brezillon wrote on Thu, 4 Feb > 2021 09:59:45 +0100: > > > On Thu, 4 Feb 2021 14:22:21 +0530 > > Manivannan Sadhasivam wrote: > > > > > On Thu, Feb 04, 202

Re: [PATCH] mtd: rawnand: Do not check for bad block if bbt is unavailable

2021-02-04 Thread Boris Brezillon
On Thu, 4 Feb 2021 14:22:21 +0530 Manivannan Sadhasivam wrote: > On Thu, Feb 04, 2021 at 09:13:36AM +0100, Miquel Raynal wrote: > > Hi Manivannan, > > > > Manivannan Sadhasivam wrote on Wed, > > 03 Feb 2021 17:11:31 +0530: > > > > > On 3 Feb

Re: [PATCH] mtd: rawnand: Do not check for bad block if bbt is unavailable

2021-02-03 Thread Boris Brezillon
On Wed, 03 Feb 2021 16:22:42 +0530 Manivannan Sadhasivam wrote: > On 3 February 2021 3:49:14 PM IST, Boris Brezillon > wrote: > >On Wed, 03 Feb 2021 15:42:02 +0530 > >Manivannan Sadhasivam wrote: > > > >> >> > >> >> I got more informat

Re: [PATCH] mtd: rawnand: Do not check for bad block if bbt is unavailable

2021-02-03 Thread Boris Brezillon
On Wed, 03 Feb 2021 15:42:02 +0530 Manivannan Sadhasivam wrote: > >> > >> I got more information from the vendor, Telit. The access to the 3rd > >partition is protected by Trustzone and any access in non privileged > >mode (where Linux kernel runs) causes kernel panic and the device > >reboots

Re: Problems starting Xen domU after latest stable update

2021-01-28 Thread Boris Ostrovsky
> problem. Well, this commit upstream and it's cherry-picked variants > on linux-5.4.y and linux-5.10.y. You most likely need 5f46400f7a6a4fad635d5a79e2aa5a04a30ffea1. It hit Linus tree a few hours ago. -boris

Re: [PATCH AUTOSEL 5.10 26/45] x86/xen: Fix xen_hvm_smp_init() when vector callback not available

2021-01-19 Thread Boris Ostrovsky
On 1/19/21 8:25 PM, Sasha Levin wrote: > From: David Woodhouse > > [ Upstream commit 3d7746bea92530e8695258a3cf3ddec7a135edd6 ] Sasha, you will also want https://lore.kernel.org/lkml/20210115191123.27572-1-rdun...@infradead.org/, it is sitting in Xen staging tree. -boris

Kconfig support in build2

2021-01-19 Thread Boris Kolpackov
Just a short note if anyone is looking for a build system with an out-of-the-box Kconfig support: https://build2.org/blog/build2-kconfig.xhtml As part of this effort we've also written a Kconfig language guide, finding the official documentation to be more of a reference: https://build2.org/lib

Re: [PATCH 15/21] x86/xen/pvh: Convert indirect jump to retpoline

2021-01-14 Thread boris . ostrovsky
On 1/14/21 2:40 PM, Josh Poimboeuf wrote: > It's kernel policy to not have (unannotated) indirect jumps because of > Spectre v2. This one's probably harmless, but better safe than sorry. > Convert it to a retpoline. > > Cc: Boris Ostrovsky > Cc: Juergen Gross >

Re: [PATCH 14/21] x86/xen: Support objtool vmlinux.o validation in xen-head.S

2021-01-14 Thread boris . ostrovsky
ge don't matter, since it > gets mapped to the hypervisor. Make it more palatable to objtool by > making each hypervisor function a true empty function, with nops and a > return. > > Cc: Boris Ostrovsky > Cc: Juergen Gross > Signed-off-by: Josh Poimboeuf Reviewed-by: Boris Ostrovsky

Re: [PATCH 13/21] x86/xen: Support objtool validation in xen-asm.S

2021-01-14 Thread boris . ostrovsky
On 1/14/21 2:40 PM, Josh Poimboeuf wrote: > The OBJECT_FILES_NON_STANDARD annotation is used to tell objtool to > ignore a file. File-level ignores won't work when validating vmlinux.o. > > Tweak the ELF metadata and unwind hints to allow objtool to follow the > code. >

Re: [PATCH] xen/privcmd: allow fetching resource sizes

2021-01-11 Thread boris . ostrovsky
a vma but I am not sure it will do what we want.) -boris

Re: [PATCH] media: rkvdec: silence ktest bot build warning

2021-01-07 Thread Boris Brezillon
; > vim +/of_rkvdec_match +967 drivers/staging/media/rkvdec/rkvdec.c > > > >966 > > > 967 static const struct of_device_id of_rkvdec_match[] = { > >968 { .compatible = "rockchip,rk3399-vdec" }, > >969

Re: [RFC][PATCH 6/6] x86/mce: Dont use noinstr for now

2021-01-06 Thread Boris Petkov
On January 6, 2021 3:36:25 PM GMT+01:00, Peter Zijlstra wrote: >Instead of using noinstr, kill instrumentation for all of mce/. This >switches MCE over to a best-effort but non-validated mode. Doing >better will require a significant investment of time and effort. Another thing that we could do

Re: linux-next: error while fetching the i3c-fixes tree

2021-01-03 Thread Boris Brezillon
se the fixes branch much and kept the master one around. Sorry for the inconvenience. Regards, Boris

Re: [PATCH] kconfig: drop filename and line number prefix from warning/error-if macros

2020-12-21 Thread Boris Kolpackov
[Copying some of my comments from another reply.] Masahiro Yamada writes: > When I implemented the Kconfig macro language, I took the GNU Make > behavior as a reference in general, but I did not follow the message > format of $(error ...) to avoid that annoyance. > > So, the following code in K

[GIT PULL] i3c: Changes for 5.11

2020-12-18 Thread Boris Brezillon
Hello Linus, Here the I3C PR for 5.11. This should be my last PR (I resigned from my maintainer position). Alexandre Belloni (maintainer of the RTC subsystem) kindly proposed to take over, so he should send the I3C PRs from now on. Regards, Boris The following changes since commit

Re: [PATCH 2/2] Add SMB 2 support for getting and setting SACLs

2020-12-18 Thread Boris Protopopov
No objections on my part as far as adding 'if (info & SACL_SECINFO) return'. I had originally those flags sent from the caller, but that was confusing at the top level (e.g. in cifsacl.c), so I have opted to passing only "extra" flags ("additional" was already taken). - ... > > --- a/

Re: [PATCH v4 6/9] spi: tegra210-quad: Add support for hardware dummy cycles transfer

2020-12-18 Thread Boris Brezillon
On Thu, 17 Dec 2020 12:28:44 -0800 Sowjanya Komatineni wrote: > Tegra Quad SPI controller hardware supports sending dummy bytes based > on programmed dummy clock cycles after the actual transfer bytes. > > This patch adds this support of hardware dummy bytes transfer and > skips transfer of dumm

Re: [PATCH v4 5/9] spi: spi-mem: Mark dummy transfers by setting dummy_data bit

2020-12-18 Thread Boris Brezillon
On Fri, 18 Dec 2020 14:51:08 +0530 Pratyush Yadav wrote: > Hi Sowjanya, > > On 17/12/20 12:28PM, Sowjanya Komatineni wrote: > > This patch marks dummy transfer by setting dummy_data bit to 1. > > > > Controllers supporting dummy transfer by hardware use this bit field > > to skip software trans

[PATCH 2/2] Add SMB 2 support for getting and setting SACLs

2020-12-17 Thread Boris Protopopov
Fix passing of the additional security info via version operations. Force new open when getting SACL and avoid reuse of files that were previously open without sufficient privileges to access SACLs. Signed-off-by: Boris Protopopov --- After further testing, I found that the security info was

Re: [PATCH v2] xen/xenbus: make xs_talkv() interruptible

2020-12-15 Thread boris . ostrovsky
On 12/15/20 6:10 AM, Juergen Gross wrote: > In case a process waits for any Xenstore action in the xenbus driver > it should be interruptible by signals. > > Signed-off-by: Juergen Gross > --- > V2: > - don't special case SIGKILL as libxenstore is handling -EINTR

Re: [PATCH v3 5/9] spi: spi-mem: Allow masters to transfer dummy cycles directly by hardware

2020-12-13 Thread Boris Brezillon
On Sun, 13 Dec 2020 10:54:26 +0100 Boris Brezillon wrote: > On Sat, 12 Dec 2020 09:28:50 -0800 > Sowjanya Komatineni wrote: > > > On 12/12/20 2:57 AM, Boris Brezillon wrote: > > > On Fri, 11 Dec 2020 13:15:59 -0800 > > > Sowjanya Komatineni wrote: > &

Re: [PATCH v3 6/9] spi: tegra210-quad: Add support for hardware dummy cycles

2020-12-13 Thread Boris Brezillon
On Fri, 11 Dec 2020 13:16:00 -0800 Sowjanya Komatineni wrote: > Tegra Quad SPI controller hardware supports sending dummy cycles > after address bytes. > > This patch adds this support. > > Signed-off-by: Sowjanya Komatineni > --- > drivers/spi/spi-tegra210-quad.c | 22 +-

Re: [PATCH v3 5/9] spi: spi-mem: Allow masters to transfer dummy cycles directly by hardware

2020-12-13 Thread Boris Brezillon
On Sat, 12 Dec 2020 09:28:50 -0800 Sowjanya Komatineni wrote: > On 12/12/20 2:57 AM, Boris Brezillon wrote: > > On Fri, 11 Dec 2020 13:15:59 -0800 > > Sowjanya Komatineni wrote: > > > >> This patch adds a flag SPI_MASTER_USES_HW_DUMMY_CYCLES for the controllers

Re: [PATCH v3 5/9] spi: spi-mem: Allow masters to transfer dummy cycles directly by hardware

2020-12-12 Thread Boris Brezillon
On Fri, 11 Dec 2020 13:15:59 -0800 Sowjanya Komatineni wrote: > This patch adds a flag SPI_MASTER_USES_HW_DUMMY_CYCLES for the controllers > that support transfer of dummy cycles by the hardware directly. Hm, not sure this is a good idea. I mean, if we expect regular SPI devices to use this feat

Re: [patch 27/30] xen/events: Only force affinity mask for percpu interrupts

2020-12-11 Thread boris . ostrovsky
he affinity mask and Xen-specific data (e.g. info->cpu and then protocol-specific data in event channel code). Even if they are re-synchronized later, at startup time (for SMP). I don't see anything that would cause a problem right now but I worry that this inconsistency may come up at some point. -boris > That's right, but not limited to ARM. The same problem exists on x86 UP. > So yes, the call makes sense, but the changelog is not really useful. > Let me add a comment to this. > > Thanks, > > tglx >

Re: [patch 24/30] xen/events: Remove unused bind_evtchn_to_irq_lateeoi()

2020-12-10 Thread boris . ostrovsky
On 12/10/20 2:26 PM, Thomas Gleixner wrote: > Signed-off-by: Thomas Gleixner > Cc: Boris Ostrovsky > Cc: Juergen Gross > Cc: Stefano Stabellini > Cc: xen-de...@lists.xenproject.org > --- > drivers/xen/events/events_base.c |6 -- > 1 file changed, 6 deletions(

Re: [patch 27/30] xen/events: Only force affinity mask for percpu interrupts

2020-12-10 Thread boris . ostrovsky
to CPU0 at the XEN > level and leave the affinity mask alone. At startup of the interrupt > affinity will be assigned out of the affinity mask and the XEN binding will > be updated. If that's the case then I wonder whether we need this call at all and instead bind at startup time

Re: [PATCH] xen/xenbus: make xs_talkv() interruptible for SIGKILL

2020-12-09 Thread boris . ostrovsky
On 12/9/20 5:11 AM, Juergen Gross wrote: > In case a process waits for any Xenstore action in the xenbus driver > it should be interruptible via SIGKILL. > > Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky

Re: [PATCH 2/2] xen: don't use page->lru for ZONE_DEVICE memory

2020-12-07 Thread boris . ostrovsky
e or next_allocated_page? Either way Reviewed-by: Boris Ostrovsky

Re: [PATCH 1/2] xen: add helpers for caching grant mapping pages

2020-12-07 Thread boris . ostrovsky
On 12/7/20 8:30 AM, Juergen Gross wrote: > Instead of having similar helpers in multiple backend drivers use > common helpers for caching pages allocated via gnttab_alloc_pages(). > > Make use of those helpers in blkback and scsiback. > > Signed-off-by: Juergen Gross

Re: [PATCH] Add support for getting and setting SACLs

2020-12-07 Thread Boris Protopopov
HI, Pavel, yes, thanks for the pointer, will include in the future. Boris. On Mon, Dec 7, 2020 at 2:05 PM Pavel Shilovsky wrote: > > Hi Boris, > > Are you talking about this patch "[PATCH] Extend cifs acl utilities to > handle SACLs"? > > Just for the future, I

Re: [PATCH] Add support for getting and setting SACLs

2020-12-07 Thread Boris Protopopov
e code changes in question. I will look at contributing to the fsxtesting-cifs code, but I think the setcifsacl/getcifsact patch that enables easy access to the descriptor components is a pre-requisite for such contributions. Thanks! On Wed, Dec 2, 2020 at 5:43 AM Shyam Prasad N wrote: > &

Re: [PATCH] Add support for getting and setting SACLs

2020-12-01 Thread Boris Protopopov
Hello, I am checking in to see if anyone had a chance to take a look at this patch. I would appreciate any feedback. Thanks! On Tue, Oct 27, 2020 at 5:01 PM Boris Protopopov via samba-technical wrote: > > Add SYSTEM_SECURITY access flag and use with smb2 when opening > files for gettin

Re: kconfig as a git subtree on Linux

2020-11-26 Thread Boris Kolpackov
Luis Chamberlain writes: > I'd like to propose we discuss the possibility of taking kconfig and > making it a git subtree under the Linux kernel. This would allow > other projects outside of the Linux kernel to be able to update their > own copy / fork of kconfig in a jiffie *very* easily. I am

Re: [PATCH 058/141] xen-blkfront: Fix fall-through warnings for Clang

2020-11-20 Thread boris . ostrovsky
tialising: > case XenbusStateInitialised: > case XenbusStateReconfiguring: Reviewed-by Boris Ostrovsky (for patch 138 as well) Although I thought using 'fallthrough' attribute was the more common approach. -boris

Re: linux-next: build warning after merge of the nand tree

2020-11-20 Thread Boris Brezillon
On Fri, 20 Nov 2020 12:23:59 +0100 Miquel Raynal wrote: > Hi Serge, > > Stephen Rothwell wrote on Fri, 20 Nov 2020 > 11:39:29 +1100: > > > Hi all, > > > > After merging the nand tree, today's linux-next build (x86_64 > > allmodconfig) produced this warning: > > > > drivers/mtd/maps/physmap-b

Re: [PATCH v2] x86/xen: don't unbind uninitialized lock_kicker_irq

2020-11-09 Thread boris . ostrovsky
n_hvm_smp_prepare_cpus(), and more importantly xen_init_lock_cpu(), is >> not called, so the lock_kicker_irq is not initialized for the secondary >> CPUs. Let's fix this by exiting early in xen_uninit_lock_cpu() if the >> irq is not set to avoid the warning from above for each secondary CPU. >> >> Signed-off-by: Brian Masney > > Reviewed-by: Juergen Gross Applied to for-linus-5.10b. -boris

Re: [PATCH] x86/xen: fix warning when running with nosmt mitigations

2020-11-06 Thread boris . ostrovsky
about the general approach before posting > a v2. This looks good. I'd shorten the comment though: your commit message already describes the scenario. And change the subject to something like "Don't unbind uninitialized lock_kicker_irq". -boris

Re: [PATCH v6] mtd: spinand: micron: add support for MT29F2G01AAAED

2020-11-06 Thread Boris Brezillon
On Fri, 6 Nov 2020 22:28:38 +0800 Thirumalesha Narasimhappa wrote: > The MT29F2G01AAAED is a single die, 2Gb Micron SPI NAND Flash with 4-bit > ECC > > Signed-off-by: Thirumalesha Narasimhappa > --- > > v6: Reverted the SPINAND_OP_VARIANTS() as they were in v4 for > MT29F2G01AAAED device > >

Re: [v3 4/4] spi: aspeed: Add ASPEED FMC/SPI memory controller driver

2020-11-06 Thread Boris Brezillon
+Tudor and Vignesh On Fri, 6 Nov 2020 10:21:06 + Chin-Ting Kuo wrote: > Hi Boris, > > Thanks for your comments and suggestions. > > > -Original Message----- > > From: Boris Brezillon > > Sent: Friday, November 6, 2020 5:06 PM > > To: Chin-Tin

Re: [v3 4/4] spi: aspeed: Add ASPEED FMC/SPI memory controller driver

2020-11-06 Thread Boris Brezillon
On Fri, 6 Nov 2020 08:58:23 + Chin-Ting Kuo wrote: > Hi Boris, > > Thanks for your quick reply. > > > -Original Message----- > > From: Boris Brezillon > > Sent: Thursday, November 5, 2020 11:12 PM > > To: Cédric Le Goater ; robh...@kernel.org > &

Re: [v3 4/4] spi: aspeed: Add ASPEED FMC/SPI memory controller driver

2020-11-05 Thread Boris Brezillon
ddress the direct mapping points to, you should be able to adjust the window at runtime and make it point where you requested. Note that dirmap_{read,write}() are allowed to return less data than requested thus simplifying the case where a specific access requires a window adjustment in the middle of an read/write operation. Regards, Boris

Re: [PATCH v5] mtd: spinand: micron: add support for MT29F2G01AAAED

2020-11-05 Thread Boris Brezillon
On Tue, 3 Nov 2020 23:18:54 +0800 Thirumalesha N wrote: > Hi Boris, > > On Tue, Nov 3, 2020 at 11:03 PM Boris Brezillon < > boris.brezil...@collabora.com> wrote: > > > On Tue, 3 Nov 2020 22:59:01 +0800 > > Thirumalesha Narasimhappa wrote: > > > &

Re: [PATCH v5] mtd: spinand: micron: add support for MT29F2G01AAAED

2020-11-03 Thread Boris Brezillon
On Tue, 3 Nov 2020 22:59:01 +0800 Thirumalesha Narasimhappa wrote: > The MT29F2G01AAAED is a single die, 2Gb Micron SPI NAND Flash with 4-bit > ECC > > Signed-off-by: Thirumalesha Narasimhappa > --- > > v5: As per the review comments, the changes were reverted to the v2, > except the MT29F2G0

Re: [PATCH] drm/panfrost: Fix module unload

2020-11-03 Thread Boris Brezillon
ned-off-by: Steven Price Queued to drm-misc-fixes. Thanks, Boris > --- > drivers/gpu/drm/panfrost/panfrost_drv.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c > b/drivers/gpu/drm/panfrost/panfrost_drv.

Re: linux-next: build warning after merge of the drm-misc tree

2020-11-02 Thread Boris Brezillon
panfrost: Don't corrupt the queue mutex on open/close") > Thanks for this report. I posted a patch [1] to fix that yesterday, and I plan to apply it soon. Regards, Boris [1]https://patchwork.kernel.org/project/dri-devel/patch/20201101173817.831769-1-boris.brezil...@collabora.com/

Re: [PATCH] drm/panfrost: Don't corrupt the queue mutex on open/close

2020-10-30 Thread Boris Brezillon
the drm node. > > Move the initialisation/destruction to panfrost_job_{init,fini} where it > belongs. > Queued to drm-misc-next. Thanks, Boris > Fixes: 1a11a88cfd9a ("drm/panfrost: Fix job timeout handling") > Signed-off-by: Steven Price > Reviewed-by: Boris B

Re: [PATCH 3/3] kconfig: qconf: convert to Qt5 new signal/slot connection syntax

2020-10-29 Thread Boris Kolpackov
-time. > > Commit d85de3399f97 ("kconfig: qconf: fix signal connection to invalid > slots") fixed wrong slots. > > This change makes it possible to catch such mistakes easily. > > Signed-off-by: Masahiro Yamada Tested-by: Boris Kolpackov

Re: [PATCH 2/5] mtd: rawnand: qcom: Add initial support for qspi nand

2020-10-29 Thread Boris Brezillon
ver so the ECC logic can be shared between the SPI controller and raw NAND controller drivers 3/ convert the raw NAND driver to the exec_op() interface (none of this hack would have been possible if the driver was using the new API) Regards, Boris

Re: [PATCH 0/5] mtd: rawnand: qcom: Add support for QSPI nand

2020-10-29 Thread Boris Brezillon
On Thu, 29 Oct 2020 08:53:44 +0100 Miquel Raynal wrote: > Hello, > > mda...@codeaurora.org wrote on Wed, 28 Oct 2020 23:54:23 +0530: > > > On 2020-10-28 15:18, Miquel Raynal wrote: > > > Hello, > > > > > > Md Sadre Alam wrote on Sat, 10 Oct 2020 > > > 11:01:37 +0530: > > > > > >> QPIC

Re: Kernel 5.9 IOMMU groups regression/change

2020-10-29 Thread Boris V.
On Tue, Oct 27, 2020 at 08:31:09PM +0100, Boris V. wrote: On 25/10/2020 20:45, Boris V. wrote: With upgrade to kernel 5.9 my VMs stopped working, because some devices can't be passed through. This is caused by different IOMMU groups and devices being in the same group. For ex. with kerne

[PATCH] Add support for getting and setting SACLs

2020-10-27 Thread Boris Protopopov
Add SYSTEM_SECURITY access flag and use with smb2 when opening files for getting/setting SACLs. Add "system.cifs_ntsd_full" extended attribute to allow user-space access to the functionality. Avoid multiple server calls when setting owner, DACL, and SACL. Signed-off-by: Boris Protopopo

Re: [PATCH v2 0/5] xen: event handling cleanup

2020-10-23 Thread boris . ostrovsky
> drivers/xen/events/events_internal.h | 70 ++ > include/xen/events.h | 8 -- > 8 files changed, 102 insertions(+), 114 deletions(-) > Applied to for-linus-5.10b. -boris

[GIT PULL] i3c: Changes for 5.10

2020-10-17 Thread Boris Brezillon
Hello Linus, I'm a bit late, but here is the I3C PR for 5.10. Regards, Boris The following changes since commit 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5: Linux 5.9-rc1 (2020-08-16 13:04:57 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/gi

Re: [PATCH 2/2] xen: Kconfig: nest Xen guest options

2020-10-15 Thread boris . ostrovsky
amp;& X86_64 >> Why is X86_64 needed here? >> 512G support was implemented using a direct-mapped P2M, and is rather > beyond the virtual address capabilities of 32bit. > Yes, my point was that XEN_PV already depends on X86_64. -boris

Re: [PATCH 2/2] xen: Kconfig: nest Xen guest options

2020-10-15 Thread boris . ostrovsky
On 10/14/20 1:53 PM, Jason Andryuk wrote: > +config XEN_512GB > + bool "Limit Xen pv-domain memory to 512GB" > + depends on XEN_PV && X86_64 Why is X86_64 needed here? -boris

Re: [PATCH v6 09/11] mm/memremap_pages: convert to 'struct range'

2020-10-08 Thread boris . ostrovsky
gt; https://lkml.kernel.org/r/159643103173.4062302.768998885691711532.st...@dwillia2-desk3.amr.corp.intel.com > Link: https://lkml.kernel.org/r/20200926121402.GA7467@kadam > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Vishal Verma > Cc: Vivek G

Re: [PATCH] i3c: master: Fix error return in cdns_i3c_master_probe()

2020-10-07 Thread Boris Brezillon
On Fri, 11 Sep 2020 11:33:50 +0800 Jing Xiangfeng wrote: > Fix to return negative error code -ENOMEM from the error handling > case instead of 0. > > Signed-off-by: Jing Xiangfeng Queued to i3c/next. Thanks, Boris > --- > drivers/i3c/master/i3c-master-cdns.c | 4 +++- &g

Re: [PATCH v3 01/11] xen/manage: keep track of the on-going suspend mode

2020-10-01 Thread boris . ostrovsky
ed by the > booting kernel. But since the hibernation kernel may have different physical > addresses for VCPU info and if mismatch happens, it may cause issues with > resume. > During hibernation, the VCPU info register hypercall is not invoked again. I still don't think that's the cause but it's certainly worth having a look. -boris

  1   2   3   4   5   6   7   8   9   10   >