On Tue, 3 Nov 2020 23:18:54 +0800
Thirumalesha N <nthirumales...@gmail.com> wrote:
> Hi Boris,
>
> On Tue, Nov 3, 2020 at 11:03 PM Boris Brezillon <
> boris.brezil...@collabora.com> wrote:
>
> > On Tue, 3 Nov 2020 22:59:01 +0800
> > Thirumalesha Narasimhappa <nthirumales...@gmail.com> wrote:
> >
> > > The MT29F2G01AAAED is a single die, 2Gb Micron SPI NAND Flash with 4-bit
> > > ECC
> > >
> > > Signed-off-by: Thirumalesha Narasimhappa <nthirumales...@gmail.com>
> > > ---
> > >
> > > v5: As per the review comments, the changes were reverted to the v2,
> > > except the MT29F2G01AAAED device related (including the review comments)
> >
> > I don't think that's what Miquel suggested, especially not for the
> > {write,update,write}_cache_variants helpers.
> >
>
>
> I was a bit confused with the multiple levels of comments with the previous
> patch and I renamed *{write,update,write}_cache_var**iants* to *micron_4_**
> to avoid function redefinition.
> Please can you direct me with this patch, what needs to be modified/renamed
> ?
Keep the SPINAND_OP_VARIANTS() as they were in v4 and use the micron_4_
prefix for ECC related stuff.
