Re: [PATCH] RDMA/siw: Fix missing check in siw_get_hdr

2021-02-26 Thread Bernard Metzler
-"Dinghao Liu" wrote: - >To: dinghao@zju.edu.cn, k...@umn.edu >From: "Dinghao Liu" >Date: 02/26/2021 08:56AM >Cc: "Bernard Metzler" , "Doug Ledford" >, "Jason Gunthorpe" , >linux-r...@vger.kernel.org, linux-kerne

Re: [PATCH RFC PKS/PMEM 10/58] drivers/rdma: Utilize new kmap_thread()

2020-10-10 Thread Bernard Metzler
>Cc: "Ira Weiny" , "Mike Marciniszyn" >, "Dennis Dalessandro" >, "Doug Ledford" , >"Jason Gunthorpe" , "Faisal Latif" >, "Shiraz Saleem" , >"Bernard Metzler" , x...@kernel.org, "Dave Hansen"

Re: Re: Re: Re: Re: Re: [PATCH] RDMA/siw: Fix compiler warnings on 32-bit due to u64/pointer abuse

2019-08-19 Thread Bernard Metzler
-"Jason Gunthorpe" wrote: ----- >To: "Bernard Metzler" >From: "Jason Gunthorpe" >Date: 08/19/2019 08:00PM >Cc: "Geert Uytterhoeven" , "Doug Ledford" >, linux-r...@vger.kernel.org, >linux-kernel@vger.kernel.org >

RE: Re: Re: Re: Re: [PATCH] RDMA/siw: Fix compiler warnings on 32-bit due to u64/pointer abuse

2019-08-19 Thread Bernard Metzler
-"Jason Gunthorpe" wrote: ----- >To: "Bernard Metzler" >From: "Jason Gunthorpe" >Date: 08/19/2019 06:35PM >Cc: "Geert Uytterhoeven" , "Doug Ledford" >, linux-r...@vger.kernel.org, >linux-kernel@vger.kernel.org >

Re: Re: [PATCH] RDMA/siw: Fix compiler warnings on 32-bit due to u64/pointer abuse

2019-08-19 Thread Bernard Metzler
--- Bernard Metzler, PhD Tech. Leader High Performance I/O, Principal Research Staff IBM Zurich Research Laboratory Saeumerstrasse 4 CH-8803 Rueschlikon, Switzerland +41 44 724 8605 -"Geert Uytterhoeven" wrote: - >To: "Joe Perches" >From: "Geert Uytt

Re: Re: Re: Re: Re: [PATCH] RDMA/siw: Fix compiler warnings on 32-bit due to u64/pointer abuse

2019-08-19 Thread Bernard Metzler
-"Jason Gunthorpe" wrote: ----- >To: "Bernard Metzler" >From: "Jason Gunthorpe" >Date: 08/19/2019 06:05PM >Cc: "Geert Uytterhoeven" , "Doug Ledford" >, linux-r...@vger.kernel.org, >linux-kernel@vger.kernel.org >Subject:

Re: Re: Re: Re: [PATCH] RDMA/siw: Fix compiler warnings on 32-bit due to u64/pointer abuse

2019-08-19 Thread Bernard Metzler
-"Jason Gunthorpe" wrote: ----- >To: "Bernard Metzler" >From: "Jason Gunthorpe" >Date: 08/19/2019 05:07PM >Cc: "Geert Uytterhoeven" , "Doug Ledford" >, linux-r...@vger.kernel.org, >linux-kernel@vger.kernel.org >Subject

RE: Re: Re: [PATCH] RDMA/siw: Fix compiler warnings on 32-bit due to u64/pointer abuse

2019-08-19 Thread Bernard Metzler
-"Jason Gunthorpe" wrote: ----- >To: "Bernard Metzler" >From: "Jason Gunthorpe" >Date: 08/19/2019 04:19PM >Cc: "Geert Uytterhoeven" , "Doug Ledford" >, linux-r...@vger.kernel.org, >linux-kernel@vger.kernel.org >Subject

Re: Re: Re: [PATCH] RDMA/siw: Fix compiler warnings on 32-bit due to u64/pointer abuse

2019-08-19 Thread Bernard Metzler
-"Jason Gunthorpe" wrote: ----- >To: "Bernard Metzler" >From: "Jason Gunthorpe" >Date: 08/19/2019 03:52PM >Cc: "Geert Uytterhoeven" , "Doug Ledford" >, linux-r...@vger.kernel.org, >linux-kernel@vger.kernel.org >Subject

Re: Re: [PATCH] RDMA/siw: Fix compiler warnings on 32-bit due to u64/pointer abuse

2019-08-19 Thread Bernard Metzler
-"Jason Gunthorpe" wrote: - >To: "Geert Uytterhoeven" >From: "Jason Gunthorpe" >Date: 08/19/2019 02:25PM >Cc: "Bernard Metzler" , "Doug Ledford" >, linux-r...@vger.kernel.org, >linux-kernel@vger.kernel.org >Subject

Re: [PATCH] rdma: siw: remove unused variable

2019-07-26 Thread Bernard Metzler
t;- > put_user_pages_dirty_lock(chunk->plist, num_pages, dirty); > } > >-- >2.20.1 > > If we can cut down siw_free_plist() to just calling put_user_pages_dirty_lock(), we shall better call it directly and not obfuscate that by another function. Reviewed-by: Bernard Metzler

Re: [PATCH -next] infiniband: siw: remove set but not used variables 'rv'

2019-07-20 Thread Bernard Metzler
aitq, !cep->in_use); > if (signal_pending(current)) > flush_signals(current); > goto retry; >-- >2.7.4 > > Mao, many thanks for finding that. So, yes, 'rv' shall be removed. Reviewed-by: Bernard Metzler

Re: Re: Re: Re: Re: Re: [PATCH] rdma/siw: avoid smp_store_mb() on a u64

2019-07-12 Thread Bernard Metzler
-"Jason Gunthorpe" wrote: ----- >To: "Bernard Metzler" >From: "Jason Gunthorpe" >Date: 07/12/2019 07:45PM >Cc: "Arnd Bergmann" , "Doug Ledford" >, "Peter Zijlstra" , >linux-r...@vger.kernel.org, linux-kernel@vg

Re: Re: Re: Re: Re: [PATCH] rdma/siw: avoid smp_store_mb() on a u64

2019-07-12 Thread Bernard Metzler
-"Jason Gunthorpe" wrote: ----- >To: "Bernard Metzler" >From: "Jason Gunthorpe" >Date: 07/12/2019 05:33PM >Cc: "Arnd Bergmann" , "Doug Ledford" >, "Peter Zijlstra" , >linux-r...@vger.kernel.org, linux-kerne

Re: Re: Re: Re: [PATCH] rdma/siw: avoid smp_store_mb() on a u64

2019-07-12 Thread Bernard Metzler
-"Jason Gunthorpe" wrote: ----- >To: "Bernard Metzler" >From: "Jason Gunthorpe" >Date: 07/12/2019 04:43PM >Cc: "Arnd Bergmann" , "Doug Ledford" >, "Peter Zijlstra" , >linux-r...@vger.kernel.org, linux-k

Re: Re: Re: [PATCH] rdma/siw: avoid smp_store_mb() on a u64

2019-07-12 Thread Bernard Metzler
-"Jason Gunthorpe" wrote: ----- >To: "Bernard Metzler" >From: "Jason Gunthorpe" >Date: 07/12/2019 03:53PM >Cc: "Arnd Bergmann" , "Doug Ledford" >, "Peter Zijlstra" , >linux-r...@vger.kernel.org, linux-kernel@vge

Re: Re: Re: [PATCH] rdma/siw: avoid smp_store_mb() on a u64

2019-07-12 Thread Bernard Metzler
-"Peter Zijlstra" wrote: ----- >To: "Bernard Metzler" >From: "Peter Zijlstra" >Date: 07/12/2019 03:19PM >Cc: "Jason Gunthorpe" , "Arnd Bergmann" >, "Doug Ledford" , >linux-r...@vger.kernel.org, linux-kernel@vge

Re: Re: [PATCH] rdma/siw: avoid smp_store_mb() on a u64

2019-07-12 Thread Bernard Metzler
-"Jason Gunthorpe" wrote: ----- >To: "Bernard Metzler" >From: "Jason Gunthorpe" >Date: 07/12/2019 02:03PM >Cc: "Arnd Bergmann" , "Doug Ledford" >, "Peter Zijlstra" , >linux-r...@vger.kernel.org, linux-kernel@vger

Re: Re: [PATCH] rdma/siw: avoid smp_store_mb() on a u64

2019-07-12 Thread Bernard Metzler
-"Jason Gunthorpe" wrote: ----- >To: "Bernard Metzler" >From: "Jason Gunthorpe" >Date: 07/12/2019 02:03PM >Cc: "Arnd Bergmann" , "Doug Ledford" >, "Peter Zijlstra" , >linux-r...@vger.kernel.org, linux-kernel@vger

Re: [PATCH] rdma/siw: fix enum type mismatch warnings

2019-07-12 Thread Bernard Metzler
-"Arnd Bergmann" wrote: ----- >To: "Bernard Metzler" , "Doug Ledford" >, "Jason Gunthorpe" >From: "Arnd Bergmann" >Date: 07/12/2019 10:53AM >Cc: "Arnd Bergmann" , "Jason Gunthorpe" >, linux-r...@vger.k

Re: [PATCH] rdma/siw: select CONFIG_DMA_VIRT_OPS

2019-07-12 Thread Bernard Metzler
Hi Arnd, this got already fixed. Many thanks! Bernard. -"Arnd Bergmann" wrote: ----- >To: "Bernard Metzler" , "Doug Ledford" >, "Jason Gunthorpe" >From: "Arnd Bergmann" >Date: 07/12/2019 10:53AM >Cc: "Arnd Berg

Re: [PATCH] rdma/siw: avoid smp_store_mb() on a u64

2019-07-12 Thread Bernard Metzler
-"Arnd Bergmann" wrote: ----- >To: "Bernard Metzler" , "Doug Ledford" >, "Jason Gunthorpe" >From: "Arnd Bergmann" >Date: 07/12/2019 10:52AM >Cc: "Arnd Bergmann" , "Peter Zijlstra" >, "Jason Gunth

Re: [PATCH] RDMA/siw: Mark expected switch fall-throughs

2019-07-11 Thread Bernard Metzler
-"Gustavo A. R. Silva" wrote: ----- >To: "Bernard Metzler" , "Doug Ledford" >, "Jason Gunthorpe" >From: "Gustavo A. R. Silva" >Date: 07/11/2019 06:12PM >Cc: linux-r...@vger.kernel.org, linux-kernel@vger.kernel.org, &g

Re: Re: Re: linux-next: build failure after merge of the net-next tree

2019-07-11 Thread Bernard Metzler
-"Jason Gunthorpe" wrote: ----- >To: "Bernard Metzler" >From: "Jason Gunthorpe" >Date: 07/11/2019 01:53PM >Cc: "Leon Romanovsky" , "Stephen Rothwell" >, "Doug Ledford" , "David >Miller" , "Network

Re: [PATCH -next] rdma/siw: remove set but not used variable 's'

2019-07-11 Thread Bernard Metzler
-"YueHaibing" wrote: - >To: , , >From: "YueHaibing" >Date: 07/11/2019 09:13AM >Cc: , , >"YueHaibing" >Subject: [EXTERNAL] [PATCH -next] rdma/siw: remove set but not used >variable 's' > >Fixes gcc '-Wunused-but-set-variable' warning: > >drivers/infiniband/sw/siw/siw_cm.c: In function >

Re: Re: linux-next: build failure after merge of the net-next tree

2019-07-11 Thread Bernard Metzler
-"Jason Gunthorpe" wrote: - >To: "Leon Romanovsky" , "Bernard Metzler" > >From: "Jason Gunthorpe" >Date: 07/10/2019 07:52PM >Cc: "Stephen Rothwell" , "Doug Ledford" >, "David Miller" , >"

Re: [PATCH] rdma/siw: Use proper enumerated type in map_cqe_status

2019-07-11 Thread Bernard Metzler
-"Nathan Chancellor" wrote: ----- >To: "Bernard Metzler" , "Doug Ledford" >, "Jason Gunthorpe" >From: "Nathan Chancellor" >Date: 07/10/2019 07:48PM >Cc: linux-r...@vger.kernel.org, linux-kernel@vger.kernel.org, >clang-bui

Re: Re: [PATCH] RDMA/siw: Print error code while kthread_create failed

2019-07-10 Thread Bernard Metzler
a warning if we cannot start any thread. Also stopping those threads is not worth spamming the console. I just forgot to remove after Leon's comment. Would it be possible to apply the following? Thanks a lot! Bernard. >From e4ca3d4dec86bb5731f8e3cb0cdd01e84b315d80 Mon Sep 17 00:00:00 2001

Re: Re: linux-next: build failure after merge of the net-next tree

2019-07-09 Thread Bernard Metzler
-"Leon Romanovsky" wrote: - >To: "Stephen Rothwell" >From: "Leon Romanovsky" >Date: 07/09/2019 08:43AM >Cc: "Doug Ledford" , "Jason Gunthorpe" >, "David Miller" , >"Networking" , "Linux Nex

Re: Re: Re: linux-next: build failure after merge of the rdma tree

2019-07-08 Thread Bernard Metzler
-"Jason Gunthorpe" wrote: ----- >To: "Bernard Metzler" >From: "Jason Gunthorpe" >Date: 07/08/2019 04:56PM >Cc: "Stephen Rothwell" , "Doug Ledford" >, "Linux Next Mailing List" >, "Linux Kernel Mailing Lis

Re: Re: linux-next: build failure after merge of the rdma tree

2019-07-08 Thread Bernard Metzler
-"Jason Gunthorpe" wrote: - >To: "Stephen Rothwell" , "Bernard Metzler" > >From: "Jason Gunthorpe" >Date: 07/08/2019 04:09PM >Cc: "Doug Ledford" , "Linux Next Mailing List" >, "Linux Kernel Mailing List&