Re: [PATCH 3.14 73/92] dm crypt: fix deadlock when async crypto algorithm returns -EBUSY

2015-05-04 Thread Ben Collins
> On May 4, 2015, at 5:32 PM, Rabin Vincent wrote: > > On Sat, May 02, 2015 at 09:03:28PM +0200, Greg Kroah-Hartman wrote: >> 3.14-stable review patch. If anyone has any objections, please let me know. >> >> ---------- >> &g

Re: [PATCH] net: Add support for handling queueing in hardware

2013-03-22 Thread Ben Collins
On Mar 22, 2013, at 12:16 PM, David Miller wrote: > From: Ben Collins > Date: Fri, 22 Mar 2013 12:14:44 -0400 > >> I'm sorry, I thought we were working on open source projects >> here. If the code isn't encumbered by patents, legal issues or >> technical

Re: [PATCH] net: Add support for handling queueing in hardware

2013-03-22 Thread Ben Collins
On Mar 22, 2013, at 11:59 AM, David Miller wrote: > From: Ben Collins > Date: Fri, 22 Mar 2013 11:53:54 -0400 > >> Also, if there's a patch that makes my hardware work, but I can't >> use it because (even though it's open source licensed) the author >>

Re: [PATCH] net: Add support for handling queueing in hardware

2013-03-22 Thread Ben Collins
On Mar 22, 2013, at 11:41 AM, David Miller wrote: > From: Ben Collins > Date: Fri, 22 Mar 2013 11:39:20 -0400 > >> If your company had hardware going to production, you'd want it >> supported in mainline too, I suspect. > > But never against the wishes of t

Re: [PATCH] net: Add support for handling queueing in hardware

2013-03-22 Thread Ben Collins
On Mar 22, 2013, at 11:17 AM, David Miller wrote: > From: Ben Collins > Date: Fri, 22 Mar 2013 10:43:44 -0400 > >> "For us" is a loose term, when it's more that we are attempting to >> upstream code so our system is supported by a mainline kernel >>

Re: [PATCH] net: Add support for handling queueing in hardware

2013-03-22 Thread Ben Collins
the queueing code if >> the feature is enabled on a given device, which breaks QDisc >> support on dpaa_eth, and also coopts the FCOE feature bit. >> >> Signed-off-by: Andy Fleming >> Signed-off-by: Ben Collins >> Cc: net...@vger.kernel.org >>

Re: [PATCH] net: Add support for handling queueing in hardware

2013-03-22 Thread Ben Collins
On Mar 22, 2013, at 10:33 AM, David Miller wrote: > From: Fleming Andy-AFLEMING > Date: Fri, 22 Mar 2013 14:31:50 + > >> It would appear one of our customers is attempting to upstream our >> code for us. We are aware that this current solution is unacceptable >> (which is why we have not su

Re: [PATCH] phy: Add XGMII phy interface type

2013-03-22 Thread Ben Collins
On Mar 22, 2013, at 10:27 AM, David Miller wrote: > From: Ben Collins > Date: Fri, 22 Mar 2013 10:22:05 -0400 > >> It's code that I've manually stripped down as a subset of a larger >> code base for Freescale's DPAA driver. I've only tested it on our &

Re: [PATCH] phy: Add XGMII phy interface type

2013-03-22 Thread Ben Collins
On Mar 22, 2013, at 10:19 AM, David Miller wrote: > From: Ben Collins > Date: Fri, 22 Mar 2013 10:17:35 -0400 > >> On Mar 22, 2013, at 10:12 AM, David Miller wrote: >> >>> From: Ben Collins >>> Date: Mon, 18 Mar 2013 19:53:42 -0400 >>> >

Re: [PATCH] phy: Add XGMII phy interface type

2013-03-22 Thread Ben Collins
On Mar 22, 2013, at 10:12 AM, David Miller wrote: > From: Ben Collins > Date: Mon, 18 Mar 2013 19:53:42 -0400 > >> Used by systems based on certain Freescale SoCs (specifically the >> Servergy CTS-1000 system). >> >> Signed-off-by: Ben Collins > > You

Re: [PATCH] phy: Add support for VSC8234

2013-03-22 Thread Ben Collins
On Mar 22, 2013, at 10:13 AM, David Miller wrote: > From: Andy Fleming > Date: Sun, 16 Oct 2011 01:49:49 -0500 > >> No functional changes other than to recognize this PHYID. >> >> Signed-off-by: Andy Fleming >> Signed-off-by: Kumar Gala >> Signed-

[PATCH] phy: Add XGMII phy interface type

2013-03-22 Thread Ben Collins
Used by systems based on certain Freescale SoCs (specifically the Servergy CTS-1000 system). Signed-off-by: Ben Collins Cc: net...@vger.kernel.org --- include/linux/phy.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/phy.h b/include/linux/phy.h index 33999ad..5a94ec7 100644

[PATCH] sgy-cts-1000: New DTS file for Servergy CTS-1000 systems

2013-03-22 Thread Ben Collins
This isn't specifically needed in order to build the kernel. It's stored in flash with firmware. However, keep it in the kernel for reference (and to have an example for fsl_dpa device tree usage). Signed-off-by: Ben Collins Cc: linuxppc-...@lists.ozlabs.org --- arch/powerpc/boot/d

[PATCH] of_mdio: Remove flags argument from of_phy_connect

2013-03-22 Thread Ben Collins
of_phy_connect() only required a flags argument in order to pass it down to to phy_connect(). Since that argument was removed, it is of no use in this function either (confirmed by checking all callers in kernel tree as well). Signed-off-by: Ben Collins Cc: Grant Likely Cc: Rob Herring Cc

[PATCH] sgy-cts1000: Remove __dev* attributes

2013-03-18 Thread Ben Collins
Somehow the driver snuck in with these still in it. Signed-off-by: Ben Collins --- arch/powerpc/platforms/85xx/sgy_cts1000.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/85xx/sgy_cts1000.c b/arch/powerpc/platforms/85xx/sgy_cts1000.c index

[PATCH] USB: ehci-fsl: Return valid error in ehci_fsl_setup_phy

2012-10-19 Thread Ben Collins
ehci_fsl_setup_phy is supposed to return an int, but had a void return value in the case of controller_ver being invalid. Signed-off-by: Ben Collins Cc: Shengzhou Liu --- drivers/usb/host/ehci-fsl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci

Re: [SPARC64] Export symbols for sunvnet and sunvdc to be built modular

2007-12-04 Thread Ben Collins
On Tue, 2007-12-04 at 00:23 -0800, David Miller wrote: > From: Ben Collins <[EMAIL PROTECTED]> > Date: Thu, 29 Nov 2007 17:02:10 -0500 > > > Fixes this build failure: > > > > ERROR: "vio_driver_init" [drivers/net/sunvnet.ko] undefined! > >

[SPARC64] Export symbols for sunvnet and sunvdc to be built modular

2007-11-29 Thread Ben Collins
Fixes this build failure: ERROR: "vio_driver_init" [drivers/net/sunvnet.ko] undefined! ERROR: "vio_driver_init" [drivers/block/sunvdc.ko] undefined! ERROR: "ldc_map_sg" [drivers/block/sunvdc.ko] undefined! Signed-off-by: Ben Collins <[EMAIL PROTECTED]&g

Re: regression: fireware causes oops during system

2007-09-11 Thread Ben Collins
On Tue, 2007-09-11 at 21:00 +0200, Pavel Machek wrote: > Hi! > > I noticed empty suspend stopped working around 2.6.23-rc4, and it is > still present in 2.6.23-rc6. To reproduce > > swapoff -a > echo disk > /sys/power/state > echo disk > /sys/power/state > > Unsetting > > CONFIG_IEEE1394=y >

Re: Regression in 2.6.22, clock problems on Turion with 32-bit kernel

2007-08-03 Thread Ben Collins
On Fri, 2007-08-03 at 11:50 -0400, Cal Peake wrote: > On Fri, 3 Aug 2007, Ben Collins wrote: > > > > > On Fri, 2007-08-03 at 08:30 -0700, Arjan van de Ven wrote: > > > > I've tried every combination of boot param revolving around clocksource > > > &

Re: ACPI on Averatec 2370

2007-08-03 Thread Ben Collins
On Thu, 2007-08-02 at 14:07 -0700, Linus Torvalds wrote: > > On Thu, 2 Aug 2007, Cal Peake wrote: > > > > Figured I should have sent that right after I hit the send key... > > > > processor : 0 > > vendor_id : AuthenticAMD > > cpu family : 15 > > model : 72 > > model name : A

Re: Regression in 2.6.22, clock problems on Turion with 32-bit kernel

2007-08-03 Thread Ben Collins
On Fri, 2007-08-03 at 08:30 -0700, Arjan van de Ven wrote: > > I've tried every combination of boot param revolving around clocksource > > and interrupts. The only thing that gets me booting is nolapic, but then > > again, that knocks me down to a single cpu. > > hummm I wonder how nolapic k

Regression in 2.6.22, clock problems on Turion with 32-bit kernel

2007-08-03 Thread Ben Collins
Tim and I have both experienced this problem. With 2.6.20 things worked perfectly fine on these systems. The two machines are a Dell 1501 Turion X2 and Dell 1521 Turion X2. With 2.6.22 the kernel hangs shortly after starting up, but after several minutes, you can get activity by tapping keyboard (

Re: [PATCH] ieee1394: forgotten dereference...

2007-07-15 Thread Ben Collins
On Sun, 2007-07-15 at 20:59 +0100, Al Viro wrote: > Going through the string and waiting for _pointer_ to become '\0' > is not what the authors meant... > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> > --- > drivers/ieee1394/nodemgr.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [2/3] 2.6.22-rc3: known regressions with patches

2007-05-29 Thread Ben Collins
On Tue, 2007-05-29 at 14:53 +0200, Michal Piotrowski wrote: > Subject: OOPS triggered by ip(8) deconfiguring a network interface > References : http://bugzilla.kernel.org/show_bug.cgi?id=8491 > Submitter : Ben Collins <[EMAIL PROTECTED]> > Patch : http://marc.info

Re: [PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper

2007-05-25 Thread Ben Collins
On Fri, 2007-05-25 at 16:28 -0700, H. Peter Anvin wrote: > Jesse Barnes wrote: > > > > But how often do you have to debug bootloader or compressed boot code? In > > fact, most debug output like this isn't very useful after some initial > > debugging, so we usually take it out. I'm not sure why

Re: [PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper

2007-05-25 Thread Ben Collins
On Fri, 2007-05-25 at 13:33 +0200, Andi Kleen wrote: > Ben Collins <[EMAIL PROTECTED]> writes: > > Why? Because there's no other way to make the kernel totally quiet. We've been patching this out so that the boot sequence has that "clean look". Other tha

Re: [PATCH 4/6] RTC: Ratelimit "lost interrupts" message

2007-05-24 Thread Ben Collins
On Thu, 2007-05-24 at 13:48 -0700, Andrew Morton wrote: > On Wed, 23 May 2007 18:23:06 -0400 > Ben Collins <[EMAIL PROTECTED]> wrote: > > > Signed-off-by: Ben Collins <[EMAIL PROTECTED]> > > --- > > drivers/char/rtc.c |3 ++- > > 1 files changed,

Re: [PATCH 3/6] HCIUSB: Initialize the Broadcom USB Bluetooth device in Dell laptops.

2007-05-24 Thread Ben Collins
On Thu, 2007-05-24 at 19:02 +0200, Marcel Holtmann wrote: > Hi Ben, > > > CC: Marcel Holtmann <[EMAIL PROTECTED]> > > CC: Maxim Krasnyansky <[EMAIL PROTECTED]> > > Signed-off-by: Tim Gardner <[EMAIL PROTECTED]> > > Signed-off-by: Phillip lougher &l

Re: [PATCH 6/6] UNUSUAL_DEV: Sync up some reported devices from Ubuntu

2007-05-23 Thread Ben Collins
On Wed, 2007-05-23 at 20:59 -0700, Phil Dibowitz wrote: > Ben Collins wrote: > > Various unusual dev entries accumulated from Ubuntu bug reports. > > > > CC: Phil Dibowitz <[EMAIL PROTECTED]> > > NACK. Two fixes I'd like to see fixed. > > > +/*

[PATCH 2/6] PM: Do not require dev spew to get PM_DEBUG

2007-05-23 Thread Ben Collins
In order to enable things like PM_TRACE, you're required to enable PM_DEBUG, which sends a large spew of messages on boot, and often times can overflow dmesg buffer. Create new PM_VERBOSE and shift that to be the option that enables drivers/base/power's messages. Signed-off-by: B

[PATCH 5/6] SUNHME: Workaround ancient hang on U1's

2007-05-23 Thread Ben Collins
more than 5 years, can we get this out of my tree please? :) CC: David S. Miller <[EMAIL PROTECTED]> Signed-off-by: Ben Collins <[EMAIL PROTECTED]> --- drivers/net/sunhme.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/sunhme.c b/drivers/net/su

Re: [PATCH 5/6] SUNHME: Workaround ancient hang on U1's

2007-05-23 Thread Ben Collins
On Wed, 2007-05-23 at 17:17 -0700, David Miller wrote: > From: Ben Collins <[EMAIL PROTECTED]> > Date: Wed, 23 May 2007 18:30:46 -0400 > > > This work around has been in use by almost any distribution trying to > > support sparc64 since at least 2002. Without it, sunh

[PATCH 3/6] HCIUSB: Initialize the Broadcom USB Bluetooth device in Dell laptops.

2007-05-23 Thread Ben Collins
CC: Marcel Holtmann <[EMAIL PROTECTED]> CC: Maxim Krasnyansky <[EMAIL PROTECTED]> Signed-off-by: Tim Gardner <[EMAIL PROTECTED]> Signed-off-by: Phillip lougher <[EMAIL PROTECTED]> Signed-off-by: Ben Collins <[EMAIL PROTECTED]> --- drivers/bluetooth/hci_usb.c

[PATCH 4/6] RTC: Ratelimit "lost interrupts" message

2007-05-23 Thread Ben Collins
Signed-off-by: Ben Collins <[EMAIL PROTECTED]> --- drivers/char/rtc.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/char/rtc.c b/drivers/char/rtc.c index 20380a2..22cf7aa 100644 --- a/drivers/char/rtc.c +++ b/drivers/char/rtc.c @@ -1159,7 +1159,8 @@

[PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper

2007-05-23 Thread Ben Collins
Signed-off-by: Ben Collins <[EMAIL PROTECTED]> --- arch/i386/Kconfig.debug|6 ++ arch/i386/boot/compressed/misc.c |8 +--- arch/x86_64/Kconfig.debug |6 ++ arch/x86_64/boot/compressed/misc.c |8 +--- 4 files changed, 22 insertions

[PATCH 6/6] UNUSUAL_DEV: Sync up some reported devices from Ubuntu

2007-05-23 Thread Ben Collins
Various unusual dev entries accumulated from Ubuntu bug reports. CC: Phil Dibowitz <[EMAIL PROTECTED]> CC: Alan Stern <[EMAIL PROTECTED]> CC: [EMAIL PROTECTED] Signed-off-by: Ben Collins <[EMAIL PROTECTED]> --- drivers/usb/storage/unusual_devs.h | 21 +++-- 1

[PATCH 0/6] Patch sync from Ubuntu tree

2007-05-23 Thread Ben Collins
Patch set to sync up some Ubuntu patches. Git tree: git://kernel.ubuntu.com/bcollins/ubuntu-for-upstream - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [PATCH/REDIFF] Cleanup libata HPA support

2007-05-18 Thread Ben Collins
On Fri, 2007-05-18 at 11:06 -0400, Ben Collins wrote: > (Rediffed against latest git) Added error check for ata_dev_read_id (Thanks tj) Also, since hpa is disabled by default, print the native size, even when HPA isn't asked for (so users and developers can know that it may need to

[PATCH/REDIFF] Cleanup libata HPA support

2007-05-18 Thread Ben Collins
e McMartin <[EMAIL PROTECTED]> CC: [EMAIL PROTECTED] CC: [EMAIL PROTECTED] CC: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Ben Collins <[EMAIL PROTECTED]> libata-core.c | 134 -- 1 file changed, 93 insertions(+), 41

Re: [linux-usb-devel] [PATCH] Remove duplicate ID in ipaq driver

2007-05-17 Thread Ben Collins
On Thu, 2007-05-17 at 05:43 -0700, Greg KH wrote: > On Wed, May 16, 2007 at 05:36:48PM -0400, Ben Collins wrote: > > On Wed, 2007-05-16 at 13:59 -0700, Roland Dreier wrote: > > > > /* The first entry is a placeholder for the insmod-specified > > > > devic

Re: [PATCH] Remove duplicate ID in ipaq driver

2007-05-16 Thread Ben Collins
On Wed, 2007-05-16 at 13:59 -0700, Roland Dreier wrote: > > /* The first entry is a placeholder for the insmod-specified device */ > > - { USB_DEVICE(0x049F, 0x0003) }, > > Is it obvious why this patch is correct? Especially given the > comment just before the line you delete, and the code

[PATCH] Remove duplicate ID in ipaq driver

2007-05-16 Thread Ben Collins
Cc: Ganesh Varadarajan <[EMAIL PROTECTED]> Cc: [EMAIL PROTECTED] Signed-off-by: Ben Collins <[EMAIL PROTECTED]> diff --git a/drivers/usb/serial/ipaq.c b/drivers/usb/serial/ipaq.c index 4df0ec7..7c85be4 100644 --- a/drivers/usb/serial/ipaq.c +++ b/drivers/usb/serial/ipaq.c @@

[PATCH] Remove duplicate IDs from option card driver

2007-05-16 Thread Ben Collins
Cc: Matthias Urlichs <[EMAIL PROTECTED]> Cc: [EMAIL PROTECTED] Signed-off-by: Ben Collins <[EMAIL PROTECTED]> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 8c3f55b..89f067d 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -

[PATCH] Avoid zero size allocation in cache_k8_northbridges()

2007-05-16 Thread Ben Collins
kmalloc for flush_words resulted in zero size allocation when no k8_northbridges existed. Short circuit the code path for this case. Also remove uneeded zeroing of num_k8_northbridges just after checking if it is zero. Signed-off-by: Ben Collins <[EMAIL PROTECTED]> diff --git a/arch/

Re: [PATCH] Cleanup libata HPA support

2007-05-09 Thread Ben Collins
On Wed, 2007-05-09 at 17:27 -0600, Robert Hancock wrote: > Ben Collins wrote: > > On Tue, 2007-05-08 at 08:46 -0600, Robert Hancock wrote: > >> Ben Collins wrote: > >>> The original HPA patch that Kyle worked on has gone into current git > >>> without som

Re: [PATCH] Cleanup libata HPA support

2007-05-08 Thread Ben Collins
On Tue, 2007-05-08 at 08:46 -0600, Robert Hancock wrote: > Ben Collins wrote: > > The original HPA patch that Kyle worked on has gone into current git > > without some fixes that we worked through late in the Ubuntu feisty > > release. Here's the main copy of the notes

Re: [PATCH] Cleanup libata HPA support

2007-05-08 Thread Ben Collins
On Tue, 2007-05-08 at 09:44 -0400, Mark Lord wrote: > Ben Collins wrote: > .. > > static u64 ata_tf_to_lba48(struct ata_taskfile *tf) > > { > > - u64 sectors = 0; > > + u64 sectors; > > + u32 high, low; > > > > - sectors |= ((u64)(tf-&g

[PATCH] Cleanup libata HPA support

2007-05-08 Thread Ben Collins
libata-dev). We've not had any reports of further problems. Signed-off-by: Ben Collins <[EMAIL PROTECTED]> CC: Kyle McMartin <[EMAIL PROTECTED]> CC: [EMAIL PROTECTED] CC: [EMAIL PROTECTED] diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index ca67484..253b969 1006

Re: Kernel 2.6.20+ and rt2500/rt2570 problem

2007-04-21 Thread Ben Collins
On Sat, 2007-04-21 at 16:18 +0200, Wiktor Wandachowicz wrote: > Recently I tried newer releases of Linux distributions, specifically > Sabayon Linux 3.3 and Ubuntu 7.04. Both suffer from problems with > rt2500/rt2570 modules not being able to associate with access points. > There are numerous probl

Re: [PATCH] ieee1394: update MAINTAINERS database

2007-04-20 Thread Ben Collins
On Fri, 2007-04-20 at 23:21 +0200, Stefan Richter wrote: > - update Ben's address > - replace Ben's contact by mine as raw1394's 2nd contact > - eth1394's and pcilynx's maintenance doesn't really differ from that > of other parts of the stack like video1394 > > Signed-off-by: Stefan Richte

Re: [RFC] [PATCH] Allow overriding module parameters from kernel command_line

2007-04-18 Thread Ben Collins
On Wed, 2007-04-18 at 11:55 -0400, Kyle McMartin wrote: > With the move to initramfs and heavily modular configs, which include > loading storage drivers from early userspace, it's becoming harder > to provide users with a way of overriding module parameters at boot. > > Currently, users would hav

Re: Resume from S2R fails after dpm_resume()

2007-03-02 Thread Ben Collins
On Fri, 2007-03-02 at 15:39 +0100, Pavel Machek wrote: > On Fri 2007-03-02 07:25:49, Tim Gardner wrote: > > Pavel Machek wrote: > > > Hi! > > > > > >> I instrumented 2.6.21-rc1 base/power/resume.c device_resume() with > > >> TRACE_RESUME(0) as the last statement in the function. Sure enough it > >

Re: p4-clockmod N60 errata workaround.

2007-02-15 Thread Ben Collins
On Thu, 2007-02-15 at 10:37 -0600, Oscar Pearce wrote: > On 10/28/06, Dave Jones <[EMAIL PROTECTED]> wrote: > Ben, > For the best part of a year since that N60 errata workaround > went in, I've had floods of complaints from users of that > driver > about this

Re: [FYI] Vendor interest in Unionfs

2007-01-11 Thread Ben Collins
On Tue, 2007-01-09 at 13:33 +0200, Indrek Kruusa wrote: > >> Is there vendor interest in unionfs? > > > MANY live cds seem to use it > > > I'd like to add that also in embedded area (flash storage) the UnionFS > helps in some cases. I'll chime in as well. Ubuntu uses unionfs extensively for

Re: 2.6.20-rc2: known unfixed regressions

2006-12-29 Thread Ben Collins
of you caused a breakage or I'm considering you in any other way possibly > involved with one or more of these issues. > > Due to the huge amount of recipients, please trim the Cc when answering. > Subject: i386: Oops in __find_get_block() > References : http://lkml.org/lkm

Re: [PATCH 2.6.20-git] sata_svw: Check for errors from ata_device_add()

2006-12-19 Thread Ben Collins
On Tue, 2006-12-19 at 17:59 -0500, Ben Collins wrote: > Without this patch, G5 oopses on boot. I've had this in Ubuntu since > 2.6.17, but I forgot it was in there. Still required with 2.6.20. > > Signed-off-by: Ben Collins <[EMAIL PROTECTED]> Ignore this patch for now, Be

[PATCH 2.6.20-git] sata_svw: Check for errors from ata_device_add()

2006-12-19 Thread Ben Collins
Without this patch, G5 oopses on boot. I've had this in Ubuntu since 2.6.17, but I forgot it was in there. Still required with 2.6.20. Signed-off-by: Ben Collins <[EMAIL PROTECTED]> diff --git a/drivers/ata/sata_svw.c b/drivers/ata/sata_svw.c index d89c959..85911b4 100644 --- a/

OOPS: 2.6.20-rc1 in __find_get_block()

2006-12-16 Thread Ben Collins
This occurred on a X40 (amd64 running x86 kernel) after a few minutes of uptime. Cc'd Daniel, since he originally reported the bug. Kernel is SMP, voluntary-preempt. [ 287.328000] invalid opcode: [#1] [ 287.328000] SMP [ 287.328000] CPU:0 [ 287.328000] EIP:0060:[__find_get_block

Re: GPL only modules [was Re: [GIT PATCH] more Driver core patches for 2.6.19]

2006-12-14 Thread Ben Collins
On Thu, 2006-12-14 at 20:29 +0100, Michael Buesch wrote: > On Thursday 14 December 2006 15:12, Ben Collins wrote: > > You can't talk about drivers that don't exist for Linux. Things like > > bcm43xx aren't effected by this new restriction for GPL-only drivers. > &g

Re: GPL only modules [was Re: [GIT PATCH] more Driver core patches for 2.6.19]

2006-12-14 Thread Ben Collins
On Thu, 2006-12-14 at 18:21 +0100, Jan Engelhardt wrote: > On Dec 14 2006 08:46, Ben Collins wrote: > >I have to agree with your your whole statement. The gradual changes to > >lock down kernel modules to a particular license(s) tends to mirror the > >slow lock down of conten

Re: GPL only modules [was Re: [GIT PATCH] more Driver core patches for 2.6.19]

2006-12-14 Thread Ben Collins
On Thu, 2006-12-14 at 15:10 +, James Courtier-Dutton wrote: > Ben Collins wrote: > > > > Here's the list of proprietary drivers that are in Ubuntu's restricted > > modules package: > > > > madwifi (closed hal implementation, being rep

Re: [PATCH 2.6.20-rc1] ib_verbs: Use explicit if-else statements to avoid errors with do-while macros

2006-12-14 Thread Ben Collins
On Wed, 2006-12-13 at 23:45 -0800, Roland Dreier wrote: > > IOW, do ; while(0) / do { } while (0) is not a proper way to do a macro > > that imitates a function returning void. > > > > Objections? > > None from me, although the ternary ? : is a pretty odd way to write > > if (blah) >

Re: GPL only modules [was Re: [GIT PATCH] more Driver core patches for 2.6.19]

2006-12-14 Thread Ben Collins
On Wed, 2006-12-13 at 21:39 -0800, Martin J. Bligh wrote: > The Ubuntu feisty fawn mess was a dangerous warning bell of where we're > going. If we don't stand up at some point, and ban binary drivers, we > will, I fear, end up with an unsustainable ecosystem for Linux when > binary drivers become p

Re: GPL only modules [was Re: [GIT PATCH] more Driver core patches for 2.6.19]

2006-12-14 Thread Ben Collins
> So go get it merged in the Ubuntu, (Open)SuSE and RHEL and Fedora trees > first. This is not something where we use my tree as a way to get it to > other trees. This is something where the push had better come from the > other direction. I can probably speak for Ubuntu in saying we wont incl

[PATCH 2.6.20-rc1] ib_verbs: Use explicit if-else statements to avoid errors with do-while macros

2006-12-13 Thread Ben Collins
At least on PPC, the "op ? op : dma" construct causes a compile failure because the dma_* is a do{}while(0) macro. This turns all of them into proper if/else to avoid this problem. Signed-off-by: Ben Collins <[EMAIL PROTECTED]> diff --git a/include/rdma/ib_verbs.h b/include

Re: [PATCH] PCI legacy resource fix

2006-12-09 Thread Ben Collins
On Sat, 2006-12-09 at 13:14 +, Alan wrote: > On Sat, 09 Dec 2006 03:12:11 -0500 > Ben Collins <[EMAIL PROTECTED]> wrote: > > My controller is in legacy mode, however, it never gets to here because > > of this call, just before this block of code: > > > >

Re: [PATCH] PCI legacy resource fix

2006-12-09 Thread Ben Collins
On Sat, 2006-12-09 at 02:46 +, Alan wrote: > > Checking the patch, my problem is that the old way, all BAR's were being > > set at start = end = flags = 0. The patch makes it set all the BAR's to > > Yes the old quirk used to blank the resources as the values on the chip > are undefined and ra

Re: [PATCH] PCI legacy resource fix

2006-12-08 Thread Ben Collins
On Sat, 2006-12-09 at 01:25 +, Ralf Baechle wrote: > On Fri, Dec 08, 2006 at 07:46:18PM -0500, Ben Collins wrote: > > > On Wed, 2006-12-06 at 13:41 +, Ralf Baechle wrote: > > > Since commit 368c73d4f689dae0807d0a2aa74c61fd2b9b075f the kernel will try > > > t

Re: [PATCH] PCI legacy resource fix

2006-12-08 Thread Ben Collins
On Wed, 2006-12-06 at 13:41 +, Ralf Baechle wrote: > Since commit 368c73d4f689dae0807d0a2aa74c61fd2b9b075f the kernel will try > to update the non-writeable BAR registers 0..3 of PIIX4 IDE adapters if > pci_assign_unassigned_resources() is used to do full resource assignment > of the bus. This

Re: [PATCH 0/3] New firewire stack

2006-12-06 Thread Ben Collins
On Wed, 2006-12-06 at 09:56 +0100, Stefan Richter wrote: > (Adding Cc: linux1394-devel) > > Ben Collins wrote at linux-kernel: > > On Tue, 2006-12-05 at 18:21 -0500, Kristian Høgsberg wrote: > >> Alexey Dobriyan wrote: > >>> On Tue, Dec 05, 2006 at 12:22

Re: [PATCH 0/3] New firewire stack

2006-12-05 Thread Ben Collins
On Tue, 2006-12-05 at 18:21 -0500, Kristian Høgsberg wrote: > Alexey Dobriyan wrote: > > On Tue, Dec 05, 2006 at 12:22:29AM -0500, Kristian Høgsberg wrote: > >> I'm announcing an alternative firewire stack that I've been working on > >> the last few weeks. > > > > Is mainline firewire so hopeless

[PATCH] Export current_is_keventd() for libphy

2006-12-02 Thread Ben Collins
Fixes this problem when libphy is compiled as module: WARNING: "current_is_keventd" [drivers/net/phy/libphy.ko] undefined! diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 17c2f03..1cf226b 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -608,6 +608,7 @@ int current_is_kevent

Re: [RFC] Include ACPI DSDT from INITRD patch into mainline

2006-12-01 Thread Ben Collins
On Fri, 2006-12-01 at 22:49 +0100, Arjan van de Ven wrote: > On Fri, 2006-12-01 at 16:01 -0500, Ben Collins wrote: > > On Fri, 2006-12-01 at 20:45 +0100, Arjan van de Ven wrote: > > > On Fri, 2006-12-01 at 14:35 -0500, Ben Collins wrote: > > > > What about the point

Re: [RFC] Include ACPI DSDT from INITRD patch into mainline

2006-12-01 Thread Ben Collins
On Fri, 2006-12-01 at 20:45 +0100, Arjan van de Ven wrote: > On Fri, 2006-12-01 at 14:35 -0500, Ben Collins wrote: > > What about the point that userspace (udev, and such) is not available > > when DSDT loading needs to occur? Init hasn't even started at that > > point

Re: [RFC] Include ACPI DSDT from INITRD patch into mainline

2006-12-01 Thread Ben Collins
On Fri, 2006-12-01 at 19:53 +, Alan wrote: > > > The whole approach of using filp_open() not the firmware interface > > > is horribly ugly and does not belong mainstream. > > > > What about the point that userspace (udev, and such) is not available > > when DSDT loading needs to occur? Init h

Re: [PATCH 2/4] [APIC] Allow disabling of UP APIC/IO-APIC by default, with command line option to turn it on.

2006-12-01 Thread Ben Collins
On Fri, 2006-12-01 at 09:39 +0100, Ingo Molnar wrote: > * Ben Collins <[EMAIL PROTECTED]> wrote: > that should be "ioapic", not "apic". The CPU has a piece of silicon > called the "local APIC" - enabled via the 'lapic' option, and disabled

Re: [RFC] Include ACPI DSDT from INITRD patch into mainline

2006-12-01 Thread Ben Collins
On Fri, 2006-12-01 at 18:56 +, Alan wrote: > On Fri, 01 Dec 2006 13:36:19 -0500 > Ben Collins <[EMAIL PROTECTED]> wrote: > > > I'd be willing to bet that most distros have this patch in their kernel. > > One of those things we can't really live without.

[RFC] Include ACPI DSDT from INITRD patch into mainline

2006-12-01 Thread Ben Collins
I'd be willing to bet that most distros have this patch in their kernel. One of those things we can't really live without. What I haven't understood is why it isn't included in the mainline kernel yet. There's enough kernel hackers out there using this that I doubt it will get stale or broken for

Re: [PATCH 1/4] [x86] Add command line option to enable/disable hyper-threading.

2006-12-01 Thread Ben Collins
On Fri, 2006-12-01 at 17:10 +0100, Arjan van de Ven wrote: > > I'm just basing this on the history of the patch, which preceeds me, so > > if this is incorrect, please don't blame me for misinformation :) > > > > The original patch claims that hyper-threading opens the user up to some > > sort of

Re: [PATCH 1/4] [x86] Add command line option to enable/disable hyper-threading.

2006-12-01 Thread Ben Collins
On Fri, 2006-12-01 at 15:32 +0100, Arjan van de Ven wrote: > > > > The idea is that we want our users to be able to use hyper-threading, > > but we don't want it on by default. > > Hi, > > can I ask why not? I'm just basing this on the history of the patch, which preceeds me, so if this is inco

Re: [PATCH 1/4] [x86] Add command line option to enable/disable hyper-threading.

2006-12-01 Thread Ben Collins
On Fri, 2006-12-01 at 13:29 +, Pavel Machek wrote: > Hi! > > > This patch adds a config option to allow disabling hyper-threading by > > default, and a kernel command line option to changes this default at > > boot time. > > > +config X86_HT_DISABLE > > + bool "Disable Hyper-Threading by de

Re: [PATCH 4/4] [HVCS] Select HVC_CONSOLE if HVCS is enabled.

2006-11-30 Thread Ben Collins
On Thu, 2006-11-30 at 13:32 +0100, Roman Zippel wrote: > Hi, > > On Wed, 29 Nov 2006, Ben Collins wrote: > > > If HVC_CONSOLE provides symbols that HVCS requires. > > > > Signed-off-by: Ben Collins <[EMAIL PROTECTED]> > > --- > > drivers/char/Kco

[PATCH 3/4] [ATM] Add CPPFLAGS to byteorder.h check.

2006-11-29 Thread Ben Collins
O= builds produced errors in the shell command because of unfound headers. Signed-off-by: Ben Collins <[EMAIL PROTECTED]> --- drivers/atm/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/atm/Makefile b/drivers/atm/Makefile index b5077ce..1b16f81

[PATCH 2/4] [APIC] Allow disabling of UP APIC/IO-APIC by default, with command line option to turn it on.

2006-11-29 Thread Ben Collins
Signed-off-by: Ben Collins <[EMAIL PROTECTED]> --- arch/i386/Kconfig | 13 + arch/i386/kernel/apic.c| 13 +++-- arch/i386/kernel/io_apic.c | 10 +- include/asm-i386/apic.h|6 ++ include/asm-i386/io_apic.h |5 + 5 files chang

[PATCH 4/4] [HVCS] Select HVC_CONSOLE if HVCS is enabled.

2006-11-29 Thread Ben Collins
If HVC_CONSOLE provides symbols that HVCS requires. Signed-off-by: Ben Collins <[EMAIL PROTECTED]> --- drivers/char/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig index 2af12fc..c94ecdc 100644 --- a/driver

Ubuntu patch sync for 2.6.20

2006-11-29 Thread Ben Collins
This is a set of patches from the Ubuntu tree that seemed suitable for upstream sync. [PATCH 1/4] [x86] Add command line option to enable/disable hyper-threading. [PATCH 2/4] [APIC] Allow disabling of UP APIC/IO-APIC by default, with command line option to turn it on. [PATCH 3/4] [ATM] Add CPPF

Ubuntu patch sync for 2.6.20

2006-11-29 Thread Ben Collins
This is a set of patches from the Ubuntu tree that seemed suitable for upstream sync. [PATCH 1/4] [x86] Add command line option to enable/disable hyper-threading. [PATCH 2/4] [APIC] Allow disabling of UP APIC/IO-APIC by default, with command line option to turn it on. [PATCH 3/4] [ATM] Add CPPF

[PATCH 1/4] [x86] Add command line option to enable/disable hyper-threading.

2006-11-29 Thread Ben Collins
This patch adds a config option to allow disabling hyper-threading by default, and a kernel command line option to changes this default at boot time. Signed-off-by: Ben Collins <[EMAIL PROTECTED]> --- Documentation/kernel-parameters.txt |3 +++ arch/i386/Kconfig

Ubuntu patch sync for 2.6.20

2006-11-29 Thread Ben Collins
This is a set of patches from the Ubuntu tree that seemed suitable for upstream sync. [PATCH 1/4] [x86] Add command line option to enable/disable hyper-threading. [PATCH 2/4] [APIC] Allow disabling of UP APIC/IO-APIC by default, with command line option to turn it on. [PATCH 3/4] [ATM] Add CPPF

Re: [PATCH] late spinlock initialization in ieee1394/ohci

2005-08-26 Thread Ben Collins
Thanks Al. I'll commit this to our tree. Linus, feel free to apply this to your tree. Signed-off-by: Ben Collins <[EMAIL PROTECTED]> On Thu, Aug 25, 2005 at 11:13:14PM +0100, Al Viro wrote: > spinlock used in irq handler should be initialized before registering > irq, even if

Re: alternative [PATCH] 1/2) drivers/ieee1394/: schedule unused EXPORT_SYMBOL's for removal

2005-07-09 Thread Ben Collins
Applied, but I set the default to "N". No reason to prolong doing it, since it doesn't break anything in the kernel or in our tree. It's an easy pointer to the option for anyone inquiring about the change. On Sat, Jul 09, 2005 at 12:32:33PM +0200, Stefan Richter wrote:

Re: [2.6 patch] drivers/ieee1394/: schedule unused EXPORT_SYMBOL's for removal

2005-07-09 Thread Ben Collins
On Sat, Jul 09, 2005 at 08:55:57PM +0200, Adrian Bunk wrote: > On Sat, Jul 09, 2005 at 03:50:35AM -0400, Ben Collins wrote: > > > Can we, instead of removing these, wrap then in a "Export full API" config > > option? I've already got several reports from external

Re: alternative [PATCH] 1/2) drivers/ieee1394/: schedule unused EXPORT_SYMBOL's for removal

2005-07-09 Thread Ben Collins
Now that I can live with. If everyone else is ok with it, I'll apply it to our tree for when I sync to Linus. On Sat, Jul 09, 2005 at 12:32:33PM +0200, Stefan Richter wrote: > Ben Collins wrote: > > Can we, instead of removing these, wrap then in a "Export full API"

Re: [2.6 patch] drivers/ieee1394/: schedule unused EXPORT_SYMBOL's for removal

2005-07-09 Thread Ben Collins
Can we, instead of removing these, wrap then in a "Export full API" config option? I've already got several reports from external projects that are using most of these exported symbols, and I'd hate to make it harder on them to use our drivers (for internal projects or otherwise). On Sat, Jul 09,

Re: OHCI driver dies on Mac Mini at boot

2005-03-14 Thread Ben Collins
lete. > [ 74.998266] EXT3-fs: mounted filesystem with ordered data mode. > [ 75.007984] VFS: Mounted root (ext3 filesystem) readonly. > [ 75.017680] Freeing unused kernel memory: 176k init 4k chrp 8k prep > [ 75.229947] usb 3-1: new low speed USB device using ohci_hcd and address

Re: asm/unistd.h

2001-04-05 Thread Ben Collins
0), you would get this: if (blah == 2) do { printf("arg is %s\n", blah); do_something_useful(blah); } while (0); Which is exactly what you want. -- -------===-=-==-=-

Re: Another rsync over ssh hang (repeatable, with 2.4.1 on both ends)

2001-03-02 Thread Ben Collins
be honest). So no, this is not a 2.2.x interaction bug. -- ---===-=-======-=====---==-=-- / Ben Collins -- ...on that fantastic voyage... -- Debian GNU/Linux \ ` [EMAIL

Re: Bug in large files ext2 in 2.4.0-test11 ?

2000-11-20 Thread Ben Collins
nce there will be no difference between dists. On top of that, let's take this off the l-k list, since it has no bearing here. -- ---===-=-==-=---=--------=-=-- / Ben Collins -- ...on that fantastic voyage... -- Debian GNU/Linux \ ` [EMA

Re: Bug in large files ext2 in 2.4.0-test11 ?

2000-11-20 Thread Ben Collins
On Mon, Nov 20, 2000 at 07:32:39PM +, Petr Vandrovec wrote: > On 20 Nov 00 at 13:19, Ben Collins wrote: > > > > Does kernel 2.4.x compile and run well for all of our supported archs? > > AFAIK yes. At least on all Debian archs. So, sparc, ultrasparc, i386 (with pcmcia

  1   2   >