Re: getting allwinner SoC support upstream (was Re: Uploading linux (3.9.4-1))

2013-06-05 Thread Bastian Blank
On Wed, Jun 05, 2013 at 08:46:30PM +0100, Luke Kenneth Casson Leighton wrote: > to begin to describe the problem in getting allwinner soc source code > upstream is this: not only do we have the usual "let's get it out the > door as fast as possible" learning curve of a very young, very new and > b

Re: [patch 07/13] Initialize per cpu lowcores on cpu hotplug.

2008-02-20 Thread Bastian Blank
On Wed, Feb 20, 2008 at 10:45:52AM +0100, Heiko Carstens wrote: > - copy_page(lowcore, &S390_lowcore); > + memcpy(lowcore, &S390_lowcore, 512); Okay > memset((void *)lowcore + 512, 0, sizeof(*lowcore) - 512); Not completely okay. void pointer are not allowed in arithmetic. gcc hand

Re: [patch 07/13] Initialize per cpu lowcores on cpu hotplug.

2008-02-19 Thread Bastian Blank
On Tue, Feb 19, 2008 at 03:40:54PM +0100, Martin Schwidefsky wrote: > + /* > + * Only need to copy the first 512 bytes from address 0. But since > + * the compiler emits a warning if src == NULL for memcpy use copy_page > + * instead. Copies more than needed but this code is not

Re: [PATCH] splice: fix user pointer access in get_iovec_page_array()

2008-02-10 Thread Bastian Blank
On Sun, Feb 10, 2008 at 04:47:57PM +0200, Pekka J Enberg wrote: > From: Bastian Blank <[EMAIL PROTECTED]> > > The commit 8811930dc74a503415b35c4a79d14fb0b408a361 ("splice: missing user > pointer access verification") added access_ok() to copy_from_user_mmap_sem() >

Re: [PATCH] kernel 2.6.24.1 still vulnerable to the vmsplice local root exploit

2008-02-10 Thread Bastian Blank
On Sun, Feb 10, 2008 at 12:39:05PM +, Niki Denev wrote: > This patch is against 2.6.24.1 which has already the fix to vmsplice_to_user > With it i can't exploit the hole, and it is returns "invalid address" This is the vmsplice_to_pipe path and I have many reports that it is not fixed. Bastia

Re: [PATCH] kernel 2.6.24.1 still vulnerable to the vmsplice local root exploit

2008-02-10 Thread Bastian Blank
On Sun, Feb 10, 2008 at 04:40:53AM -0500, Niki Denev wrote: > this fixed the problem for me (kernel 2.6.24.1) : > It appears that the initial patch checked the input to vmsplice_to_user, > but the exploit used vmsplice_to_pipe which remained open to the attack. This patch is broken. It opens the o

Re: [PATCH] Remove old definition of setup_per_cpu_areas

2008-02-01 Thread Bastian Blank
On Fri, Feb 01, 2008 at 09:16:15PM +0100, Bastian Blank wrote: > Remove old definition of setup_per_cpu_areas. This was completely wrong. Lets try it again. Adopt x86 percpu changes for powerpc and ia64. dd5af90a7f3d79e04b7eace9a98644dbf2038f4d replaced the config varia

Re: [PATCH] Fix ext4 bitops

2008-02-01 Thread Bastian Blank
On Fri, Feb 01, 2008 at 12:22:57PM -0800, Andrew Morton wrote: > On Fri, 1 Feb 2008 21:02:08 +0100 > Bastian Blank <[EMAIL PROTECTED]> wrote: > > > Fix ext4 bitops. > > This is incomplete. Please tell us what was "fixed". > > If it was a build error

[PATCH] Fix ext4 bitops

2008-02-01 Thread Bastian Blank
Fix ext4 bitops. Signed-off-by: Bastian Blank <[EMAIL PROTECTED]> diff --git a/include/asm-powerpc/bitops.h b/include/asm-powerpc/bitops.h index 220d9a7..d0980df 100644 --- a/include/asm-powerpc/bitops.h +++ b/include/asm-powerpc/bitops.h @@ -363,6 +363,8 @@ unsigne

[PATCH] Fix ext4 bitops

2008-02-01 Thread Bastian Blank
Fix ext4 bitops. Signed-off-by: Bastian Blank <[EMAIL PROTECTED]> diff --git a/include/asm-s390/bitops.h b/include/asm-s390/bitops.h index dba6fec..47844fc 100644 --- a/include/asm-s390/bitops.h +++ b/include/asm-s390/bitops.h @@ -762,6 +762,8 @@ static inline int sched_find_first_bit(un

[PATCH] Remove old definition of setup_per_cpu_areas

2008-02-01 Thread Bastian Blank
Remove old definition of setup_per_cpu_areas. The definition is done depending on the new config variable HAVE_SETUP_PER_CPU_AREA. Signed-off-by: Bastian Blank <[EMAIL PROTECTED]> diff --git a/include/asm-powerpc/percpu.h b/include/asm-powerpc/percpu.h index cc1cbf6..f309d34 100644

Re: [PATCH 7/24] consolidate msr.h

2007-11-19 Thread Bastian Blank
On Fri, Nov 09, 2007 at 04:42:48PM -0200, Glauber de Oliveira Costa wrote: > - wrmsrl(MSR_CSTAR, ia32_cstar_target); > + wrmsrl(MSR_CSTAR, (u64)ia32_cstar_target); Hmm, why do you add explicit casts? The compiler should convert that correctly on its own. > +static inline void wrmsrl(unsig

Re: [patch 3/6] sclp: call sclp_init() from start_kernel().

2007-11-16 Thread Bastian Blank
On Fri, Nov 16, 2007 at 03:29:45PM +0100, Martin Schwidefsky wrote: > #else > static inline void acpi_early_init(void) { } > #endif > +#ifdef CONFIG_S390 > +extern int sclp_init(void); > +#else > +static inline int sclp_init(void) {return 0;} > +#endif > #ifndef CONFIG_DEBUG_RODATA > static in

Re: [patch 5/6] Move psw_set_key.

2007-06-19 Thread Bastian Blank
On Tue, Jun 19, 2007 at 10:45:21AM +0200, Martin Schwidefsky wrote: > Move psw_set_key() from ptrace.h to processor.h which is a more > suitable place for it. In addition the moves makes the function > invisible to user space. Hmm, this does not really describe the changes. Bastian -- Violence

Re: [Xen-devel] [patch 19/28]xen: Add early printk support via hvc console

2007-05-12 Thread Bastian Blank
On Thu, May 10, 2007 at 05:07:02PM -0700, Jeremy Fitzhardinge wrote: > +#ifdef CONFIG_XEN xenboot_console is only available with CONFIG_HVC_XEN. > + } else if (!strncmp(buf, "xen", 3)) { > + early_console = &xenboot_console; > +#endif - To unsubscribe from this list: send the line

[PATCH] Allow reading tainted flag as user

2007-04-22 Thread Bastian Blank
The commit 34f5a39899f3f3e815da64f48ddb72942d86c366 restricted reading of the tainted value. The attached patch changes this back to a write-only check and restores the read behaviour of older versions. Signed-off-by: Bastian Blank <[EMAIL PROTECTED]> -- The joys of love made her human a

Re: [PATCH] Allow reading tainted flag as user

2007-04-22 Thread Bastian Blank
On Sun, Apr 22, 2007 at 01:50:45AM -0700, Andrew Morton wrote: > On Sun, 22 Apr 2007 10:39:41 +0200 Bastian Blank <[EMAIL PROTECTED]> wrote: > > > The commit 34f5a39899f3f3e815da64f48ddb72942d86c366 restricted reading > > of the tainted value. The attached patch changes

Re: [Patch 1/2] add for_each_substring() and match_substring()

2007-03-08 Thread Bastian Blank
On Tue, Mar 06, 2007 at 08:19:23PM +0100, Martin Peschke wrote: > +char *match_to(const char *cs, const char *ct) > +{ > + char *delim = strpbrk(cs, ct); > + if (delim) > + return delim; > + else if (*cs != '\0') > + return (char *)(cs + strlen(cs)); This disall

ibmvstgt/aio broken with 2.6.20-rc6 powerpc

2007-01-28 Thread Bastian Blank
Hi folks I'm not really sure if this is a ibmvstgt or a generic aio problem. I tried ibmvstgt on my openpower and the kernel shows the following warning several times: | Jan 28 15:11:15 waldi kernel: Badness at arch/powerpc/mm/slb.c:95 | Jan 28 15:11:15 waldi kernel: Call Trace: | Jan 28 15:11:15

[PATCH] kbuild: Don't ignore localversion files if the path includes a ~

2007-01-10 Thread Bastian Blank
Hi Kai, Sam The following patch fixes the problem that localversion files where ignored if the tree lives in a path which contains a ~. It changes the test to apply to the filename only. Debian allows versions which contains ~ in it. The upstream part of the version is in the directory name of th

[PATCH] s390 - fix posix types

2006-12-02 Thread Bastian Blank
Hi folks The attached patch remove the usage of __ptr_t from include/asm-s390/posix_types.h. Bastian -- Landru! Guide us! -- A Beta 3-oid, "The Return of the Archons", stardate 3157.4 diff --git a/include/asm-s390/posix_types.h b/include/asm-s390/posix_types.h index b94c988..878

[RFC] device types for s390 network devices

2005-02-01 Thread Bastian Blank
The s390 network devices specifies device types which does not match the reality. ctc === This device is currently specified as ARPHRD_SLIP. If I see it correctly, SLIP is an IP-only transport. ctc is more, the link level header contains the ethernet protocoll type, so it is some sort of pointopo