Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-08-11 Thread Andreas Werner
On Thu, Aug 11, 2016 at 10:45:00AM +0200, Oliver Hartkopp wrote: > On 08/11/2016 09:14 AM, Andreas Werner wrote: > >On Wed, Aug 10, 2016 at 10:28:45PM +0200, Oliver Hartkopp wrote: > > >>Just check 'git grep IFF_ECHO'. Even grcan.c and janz-ican3.c have IFF_ECHO

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-08-11 Thread Andreas Werner
On Wed, Aug 10, 2016 at 10:28:45PM +0200, Oliver Hartkopp wrote: > Hi Andreas, > > On 08/09/2016 08:10 AM, Andreas Werner wrote: > >On Mon, Aug 08, 2016 at 04:35:34PM +0200, Wolfgang Grandegger wrote: > > >>>>>>You specify here one echo_skb but

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-08-08 Thread Andreas Werner
On Mon, Aug 08, 2016 at 08:23:55PM -0700, Benjamin Poirier wrote: > On 2016/08/08 09:26, Andreas Werner wrote: > [...] > > > > + > > > > + if (cf->can_dlc > 0) > > > > + data[0] = be32_to_cpup((__be32 *)

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-08-08 Thread Andreas Werner
On Mon, Aug 08, 2016 at 04:35:34PM +0200, Wolfgang Grandegger wrote: > Am 08.08.2016 um 16:05 schrieb Andreas Werner: > >On Mon, Aug 08, 2016 at 02:28:39PM +0200, Wolfgang Grandegger wrote: > >>Hello, > >> > >>Am 08.08.2016 um 13:39 schrieb Andreas Werner: >

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-08-08 Thread Andreas Werner
On Mon, Aug 08, 2016 at 03:06:33PM +0200, Kurt Van Dijck wrote: > > --- Original message --- > > Date: Mon, 8 Aug 2016 14:28:39 +0200 > > From: Wolfgang Grandegger > > > [...] > > >>>+ > > >>>+if (!(cf->can_id & CAN_RTR_FLAG)) { > > >>>+writel(data[0], &cf_buf->data

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-08-08 Thread Andreas Werner
On Mon, Aug 08, 2016 at 02:28:39PM +0200, Wolfgang Grandegger wrote: > Hello, > > Am 08.08.2016 um 13:39 schrieb Andreas Werner: > >On Mon, Aug 08, 2016 at 11:27:25AM +0200, Wolfgang Grandegger wrote: > >>Hello Andreas, > >> > >>a first quick review..

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-08-08 Thread Andreas Werner
On Mon, Aug 08, 2016 at 11:27:25AM +0200, Wolfgang Grandegger wrote: > Hello Andreas, > > a first quick review > > Am 26.07.2016 um 11:16 schrieb Andreas Werner: > >This CAN Controller is found on MEN Chameleon FPGAs. > > > >The driver/device supports the C

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-08-08 Thread Andreas Werner
On Sun, Aug 07, 2016 at 08:58:14PM -0700, Benjamin Poirier wrote: > On 2016/07/26 11:16, Andreas Werner wrote: > [...] > > + > > + /* Lock for CTL_BTR register access. > > +* This register combines bittiming bits > > +* and the operation mode bits. > >

[PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-07-26 Thread Andreas Werner
parameters to configure the buffer level interrupt for RX/TX as well as a RX timeout interrupt. With this configuration options, the driver/device provides flexibility for different types of usecases. Signed-off-by: Andreas Werner --- drivers/net/can/Kconfig| 10 + drivers/net/can/Makefile

Re: [PATCH] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-07-15 Thread Andreas Werner
ides flexibility for different types of usecases. > > Signed-off-by: Andreas Werner > --- > drivers/net/can/Kconfig| 10 + > drivers/net/can/Makefile | 1 + > drivers/net/can/men_z192_can.c | 990 > + > 3 files ch

[PATCH] mcb: Added bar descriptor support for non PCI bus MCB carrier

2016-06-28 Thread Andreas Werner
: Andreas Werner --- drivers/mcb/mcb-internal.h | 9 drivers/mcb/mcb-parse.c| 125 - 2 files changed, 120 insertions(+), 14 deletions(-) diff --git a/drivers/mcb/mcb-internal.h b/drivers/mcb/mcb-internal.h index 5254e02..d6e6933 100644 --- a

[PATCH] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-06-28 Thread Andreas Werner
parameters to configure the buffer level interrupt for RX/TX as well as a RX timeout interrupt. With this configuration options, the driver/device provides flexibility for different types of usecases. Signed-off-by: Andreas Werner --- drivers/net/can/Kconfig| 10 + drivers/net/can/Makefile

[PATCH] mcb: Added support for LPC or non PCI based MCB carrier

2016-06-24 Thread Andreas Werner
Add support for MCB bases FPGAs connected to the LPC or non PCI Bus. This driver currently supports the SC24 board. The FPGA is connected to the LPC bus and is identified using the BIOS DMI string. Signed-off-by: Andreas Werner --- drivers/mcb/Kconfig | 9 +++ drivers/mcb/Makefile | 1

[PATCH 2/2] mcb: Delete num_cells variable which is not required

2016-04-20 Thread Andreas Werner
The num_cells variable is only used in the dev_dbg print, but we can directly use the ret variable which also includes the same value. Signed-off-by: Andreas Werner --- drivers/mcb/mcb-pci.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mcb/mcb-pci.c b/drivers

[PATCH 1/2] mcb: Replace ioremap and request_region with the devm version

2016-04-20 Thread Andreas Werner
Replaced ioremap with devm_ioremap and request_mem_region with devm_request_mem_region. This makes the code much more cleaner. Signed-off-by: Andreas Werner --- drivers/mcb/mcb-pci.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/drivers/mcb/mcb-pci.c b

[PATCH 0/2] make use of devm function in the mcb-pci driver

2016-04-20 Thread Andreas Werner
The first patch replace the ioremap an request_mem_region function with the corresponding devm function to have a more cleaner code and a better error handling. The sencoder patch just delete a unused variable. Andreas Werner (2): mcb: Replace ioremap and request_region with the devm version

[PATCH] mcb: Fixed bar number assignment for the gdd

2016-04-19 Thread Andreas Werner
The bar number is found in reg2 within the gdd. Therefore we need to change the assigment from reg1 to reg2 which is the correct location. Signed-off-by: Andreas Werner --- drivers/mcb/mcb-parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mcb/mcb-parse.c b

Re: [PATCH v2 2/2] mcb: export bus information via sysfs

2016-04-08 Thread Andreas Werner
e tested this on the MEN SC24 with a MCB FPGA. Reviewed-by: Andreas Werner Tested-by: Andreas Werner

Re: [PATCH v2 1/2] mcb: Correctly initialize the bus's device

2016-04-08 Thread Andreas Werner
on the MEN SC24 AMD Board with a MCB FPGA. Reviewed-by: Andreas Werner Tested-by: Andreas Werner

Re: [PATCH 09/20] mfd: menf21bmc: Use devm_mfd_add_devices() for mfd_device registration

2016-04-05 Thread Andreas Werner
On Tue, Apr 05, 2016 at 05:18:21PM +0530, Laxman Dewangan wrote: > Use devm_mfd_add_devices() for mfd devices registration and get > rid of .remove callback to remove mfd devices. This is done > by managed device framework. > > Signed-off-by: Laxman Dewangan > CC: Andreas Wer

[PATCH v2] gpio: add driver for MEN 16Z127 GPIO controller

2016-02-29 Thread Andreas Werner
The 16Z127 is a 32bit GPIO controller on a MCB FPGA. Every single line can be configured as input and output. Push pull and open drain are supported as well as setting a debounce value for the input lines. Signed-off-by: Andreas Werner --- drivers/gpio/Kconfig| 7 ++ drivers/gpio

[PATCH v2] introduce MEN 16Z127 GPIO controller driver

2016-02-29 Thread Andreas Werner
This patch adds the MEN 16Z127 GPIO Controller driver, which is 32bit wide and located within a MCB FPGA. changes in v2: - ported driver to use the generic MMIO library - added open drain support - added debounce support Andreas Werner (1): gpio: add driver for MEN

Re: [PATCH] spi/spi-fsl-espi.c: Add spi cs polarity support

2016-01-06 Thread Andreas Werner
Hi, any comments for this patches? Regards Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 0/4] remove auto exit of production and added sysfs interface

2016-01-06 Thread Andreas Werner
Regards Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [lm-sensors] LM90 driver and ti tmp461 detection

2015-12-18 Thread Andreas Werner
On Thu, Dec 17, 2015 at 06:57:51AM -0800, Guenter Roeck wrote: > On Thu, Dec 17, 2015 at 12:48:08PM +0100, Jean Delvare wrote: > > Hi Andreas, > > > > On Tue, 15 Dec 2015 16:11:24 +0100, Andreas Werner wrote: > > > here is the register dump of the tmp461. > &g

Re: [lm-sensors] LM90 driver and ti tmp461 detection

2015-12-17 Thread Andreas Werner
On Thu, Dec 17, 2015 at 12:48:08PM +0100, Jean Delvare wrote: > Hi Andreas, > > On Tue, 15 Dec 2015 16:11:24 +0100, Andreas Werner wrote: > > here is the register dump of the tmp461. > > Thanks. > > > It seemse that we really cannot detect if it is a tmp461 or a

[PATCH 4/4] doc/ABI: add documentation for the additional sysfs status information

2015-12-16 Thread Andreas Werner
Signed-off-by: Andreas Werner --- .../ABI/testing/sysfs-bus-i2c-devices-menf21bmc| 26 ++ 1 file changed, 26 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-bus-i2c-devices-menf21bmc b/Documentation/ABI/testing/sysfs-bus-i2c-devices-menf21bmc index 28d1fa2

[PATCH 3/4] mfd/menf21bmc.c: add additional sysfs entries for BMC status information

2015-12-16 Thread Andreas Werner
This patch adds additional sysfs entries to provide status information to the userland. The following informations are now provided: - Get operation hours counter - Get board slot address - Get powercycle counter - Set/get Hw Variant Signed-off-by: Andreas Werner

[PATCH 1/4] mfd/menf21bmc: remove auto exiting of production mode and add sysfs interface

2015-12-16 Thread Andreas Werner
mechanism and add a sysfs interface to manually exiting the production e.g. during the EOL test of the board. Signed-off-by: Andreas Werner --- drivers/mfd/menf21bmc.c | 65 + 1 file changed, 44 insertions(+), 21 deletions(-) diff --git a/drive

[PATCH 2/4] doc/ABI: added sysfs description for the menf21bmc MFD driver

2015-12-16 Thread Andreas Werner
This patch add the description of the "mode" sysfs interface for the menf21bmc MFD driver. Signed-off-by: Andreas Werner --- Documentation/ABI/testing/sysfs-bus-i2c-devices-menf21bmc | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 Documentation/ABI/testing

[PATCH 0/4] remove auto exit of production and added sysfs interface

2015-12-16 Thread Andreas Werner
This patch set introduces new sysfs entries for BMC status information as well as the ABI documention. The mfd core driver now does not exit the production mode automatically. The new sysfs entry allows the userland to exit the production mode if required. Andreas Werner (4): mfd/menf21bmc

Re: [lm-sensors] LM90 driver and ti tmp461 detection

2015-12-15 Thread Andreas Werner
On Sat, Dec 12, 2015 at 11:08:42AM +0100, Jean Delvare wrote: > Hallo Andreas, > > On Thu, 10 Dec 2015 18:12:31 +0100, Andreas Werner wrote: > > thanks for the register dump :-) > > Can you please share the register dump of your TMP461 with us? > > Thanks, > -- &g

Re: [lm-sensors] LM90 driver and ti tmp461 detection

2015-12-12 Thread Andreas Werner
>Hallo Andreas, > > On Thu, 10 Dec 2015 18:12:31 +0100, Andreas Werner wrote: >> thanks for the register dump > > Can you please share the register dump of your TMP461 with us? > Hi, yes for sure. Currently i have just a evaluation board my CPU without this sensor, but

Re: LM90 driver and ti tmp461 detection

2015-12-10 Thread Andreas Werner
... >On Thu, Dec 10, 2015 at 09:49:43AM -0800, Guenter Roeck wrote: > > > >I have a DT based board yes, but i have also planed to submit my changes > >and also wanted to implement the autodetection of the chip. > > > >I have also planned (or need) to implement the "n-Factor Correction" for the > >C

Re: LM90 driver and ti tmp461 detection

2015-12-10 Thread Andreas Werner
... > On Thu, Dec 10, 2015 at 09:43:53AM -0800, Guenter Roeck wrote: > > > >There is one difference. The temperature ranges differ: > > > >TMP451: > >Standard Mode: 0 to +127 > >Extended Mode: -64 to +191 > > > >TMP461: > >Standard Mode: -40 to +127 > >Extended Mode: -64 to +191 > > > >Therefore th

Re: LM90 driver and ti tmp461 detection

2015-12-10 Thread Andreas Werner
On Thu, Dec 10, 2015 at 08:41:57AM -0800, Guenter Roeck wrote: > On 12/10/2015 04:08 AM, Andreas Werner wrote: > >Hi, > >i have a temperature sensor device named "TI TMP461" which is quite the > >same than the tmp451 which is already included in the lm90 driver

LM90 driver and ti tmp461 detection

2015-12-10 Thread Andreas Werner
Hi, i have a temperature sensor device named "TI TMP461" which is quite the same than the tmp451 which is already included in the lm90 driver. I just want to add the tmp461 to the driver but currently i have no way to differ between the tmp461 and tmp451. The main different is that the tmp461 add

Re: [v2 0/2] ata/libata-eh.c: introduce ATA_FLAG_NO_LOG_PAGE

2015-12-07 Thread Andreas Werner
On Mon, Dec 07, 2015 at 10:26:30AM -0500, Tejun Heo wrote: > On Fri, Dec 04, 2015 at 06:12:24PM +0100, Andreas Werner wrote: > > This patchset add a new ata port flag ATA_FLAG_NO_LOG_PAGE to be able > > to blacklist ports/controller which e.g. locks up on a log page read. > &

[PATCH] spi/spi-fsl-espi.c: Add spi cs polarity support

2015-12-06 Thread Andreas Werner
Add CS polarity flag to be able to set the CS polarity via the DT property spi-cs-high. Signed-off-by: Andreas Werner --- drivers/spi/spi-fsl-espi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-fsl-espi.c b/drivers/spi/spi-fsl-espi.c index c27124a

[v2 2/2] ata/sata_fsl.c: add ATA_FLAG_NO_LOG_PAGE to blacklist the controller for log page reads

2015-12-04 Thread Andreas Werner
: exception Emask 0x50 SAct 0x0 SErr 0x800 action 0x6 frozen t4 [ 13.359281] ata1: SError: { HostInt } [ 13.361644] ata1: hard resetting link Signed-off-by: Andreas Werner --- drivers/ata/sata_fsl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/ata/sata_fsl.c b

[v2 1/2] libata-eh.c: Introduce new ata port flag for controller which lockup on read log page

2015-12-04 Thread Andreas Werner
Some controller lockup on a ata_read_log_page. Add new ata port flag ATA_FLAG_NO_LOG_PAGE which can used to blacklist a controller. If this flag is set, any attempt to read a log page returns an error without actually issuing the command. Signed-off-by: Andreas Werner --- drivers/ata/libata

[v2 0/2] ata/libata-eh.c: introduce ATA_FLAG_NO_LOG_PAGE

2015-12-04 Thread Andreas Werner
test robot Andreas Werner (2): libata-eh.c: Introduce new ata port flag for controller which lockup on read log page ata/sata_fsl.c: add ATA_FLAG_NO_LOG_PAGE to blacklist the controller for log page reads drivers/ata/libata-eh.c | 9 + drivers/ata/sata_fsl.c | 3 ++- include

Re:# libata: introduce ATA_FLAG_NO_LOG_PAGE

2015-12-04 Thread Andreas Werner
Hi, argh sorry send the wrong patches from a broken tree. Will send a v2 Regards Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the

[PATCH 2/2] ata/sata_fsl.c: add ATA_FLAG_NO_LOG_PAGE to blacklist the controller for log page reads

2015-12-04 Thread Andreas Werner
: exception Emask 0x50 SAct 0x0 SErr 0x800 action 0x6 frozen t4 [ 13.359281] ata1: SError: { HostInt } [ 13.361644] ata1: hard resetting link Signed-off-by: Andreas Werner --- drivers/ata/sata_fsl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/ata/sata_fsl.c b

[PATCH 1/2] libata-eh.c: Introduce new ata port flag for controller which lockup on read log page

2015-12-04 Thread Andreas Werner
Some controller lockup on a ata_read_log_page. Add new ata port flag ATA_FLAG_NO_LOG_PAGE which can used to blacklist a controller. If this flag is set, any attempt to read a log page returns an error without actually issuing the command. Signed-off-by: Andreas Werner --- drivers/ata/libata

[PATCH 0/2] libata: introduce ATA_FLAG_NO_LOG_PAGE

2015-12-04 Thread Andreas Werner
device failed during initialisation if the SATA device includes the devslp feature. With this patchset, we blacklist the fsl sata controller and return a error on any attempt to read a log page. This allows us to access the mSATA. Andreas Werner (2): libata-eh.c: Introduce new ata port flag for

Re: libata-core: devslp fails on ATP mSATA

2015-12-03 Thread Andreas Werner
On Thu, Dec 03, 2015 at 10:15:49AM -0500, Tejun Heo wrote: > Hello, > > On Thu, Dec 03, 2015 at 10:33:55AM +0100, Andreas Werner wrote: > > All the other "flag" fields in the structs are used and/or reserved > > and it seems to be no good place for such flags.

Re: libata-core: devslp fails on ATP mSATA

2015-12-03 Thread Andreas Werner
On Wed, Dec 02, 2015 at 11:47:53AM -0500, Tejun Heo wrote: > Hello, Andreas. > > On Wed, Dec 02, 2015 at 10:33:10AM +0100, Andreas Werner wrote: > > Blacklisting the controller would be a solution yes, but I just > > wanna wait the answer from the FAE to be sure we real

Re: libata-core: devslp fails on ATP mSATA

2015-12-02 Thread Andreas Werner
On Tue, Dec 01, 2015 at 02:04:10PM -0500, Tejun Heo wrote: > On Tue, Dec 01, 2015 at 11:17:15AM -0500, Tejun Heo wrote: > > So, I suppose this is a fallout from 9faa643855df ("libata: use > > READ_LOG_DMA_EXT"). The description just says "we should try use it" > > but is there any benefit from usi

Re: libata-core: devslp fails on ATP mSATA

2015-12-01 Thread Andreas Werner
Hi, first sorry for the bad email format, but the IT decided to add my Email signature as HTML on the Exchange Server, this is why lkml rejected the email. Therefore I will switch to my private address. I do not think that the commit you mention is the root cause for this problem, because it is

Re: [PATCH] gpio: Add driver for MEN 16Z127 GPIO controller

2015-10-08 Thread Andreas Werner
Yet another thing. if i will implement the open drain support, does it really makes sense to go with the generic gpio lib? I need to replace the direction_input and direction_outpu functions because if the userland set an open drain pin to input i need to set the pin to High-Z (driver "1") inste

Re: [PATCH] gpio: Add driver for MEN 16Z127 GPIO controller

2015-10-08 Thread Andreas Werner
Hi, i have an additional question regarding the Open Drain setting. The register is currently impelemented as a read/write register which means the pin mode is configurable by software to Push Pull or Open Drain. There is also the possiblity (normal way) that the HW (FPGA) configures each pin to

Re: [PATCH] gpio: Add driver for MEN 16Z127 GPIO controller

2015-10-06 Thread Andreas Werner
On Tue, Oct 06, 2015 at 09:35:51AM +0200, Linus Walleij wrote: > On Mon, Oct 5, 2015 at 8:09 PM, Andreas Werner wrote: > > > The 16Z127 is a GPIO controller on a MCB FPGA and has 32 > > configurable GPIOs. > > The GPIOs can be configured as inputs and outputs > &

[PATCH] gpio: Add driver for MEN 16Z127 GPIO controller

2015-10-05 Thread Andreas Werner
The 16Z127 is a GPIO controller on a MCB FPGA and has 32 configurable GPIOs. The GPIOs can be configured as inputs and outputs Signed-off-by: Andreas Werner --- drivers/gpio/Kconfig| 6 ++ drivers/gpio/Makefile | 1 + drivers/gpio/gpio-menz127.c | 186

[PATCH] tty: serial: men_z135_uart.c: use mcb memory region size instead of hardcoded one

2015-10-05 Thread Andreas Werner
resources. This function also takes care of the memory region naming allocated by the driver for each of the instances. Signed-off-by: Andreas Werner --- drivers/tty/serial/men_z135_uart.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/tty/serial

regmap: regmap-debugfs.c crash if max_register is not set

2015-05-31 Thread Andreas Werner
Hi, i am currently working on a driver using regmap. The test system i my Mac Book Air using the i2c-stub driver for the first tests. The Kernel is the Arch Linux Kernel 4.0.2-1-ARCH. First thing after setting up all the ranges was to check the debugfs. After i did a cat on the ranges debugfs ent

Re: regmap different register size

2015-05-26 Thread Andreas Werner
On Tue, May 26, 2015 at 02:00:39PM -0500, Felipe Balbi wrote: > Hi, > > On Tue, May 26, 2015 at 08:54:25PM +0200, Andreas Werner wrote: > > i have a question regarding regmap usage. > > > > I have a i2c multifunction device which does have a register and value &g

regmap different register size

2015-05-26 Thread Andreas Werner
Hi, i have a question regarding regmap usage. I have a i2c multifunction device which does have a register and value width of 8bits except the revision register. The revision can only be read by a i2c block transfer. Does it makes sense to read the Revision once by the i2c API and let the rest

Re: Window watchdog driver design

2015-05-15 Thread Andreas Werner
On Thu, May 14, 2015 at 11:14:19PM -0700, Guenter Roeck wrote: > On 05/14/2015 10:43 PM, Andreas Werner wrote: > >On Thu, May 14, 2015 at 05:52:38PM -0700, Guenter Roeck wrote: > >>On 05/14/2015 07:09 AM, Andreas Werner wrote: > >>>On Thu, May 14, 2015 at 06:30:0

Re: Window watchdog driver design

2015-05-15 Thread Andreas Werner
On Thu, May 14, 2015 at 11:14:19PM -0700, Guenter Roeck wrote: > On 05/14/2015 10:43 PM, Andreas Werner wrote: > >On Thu, May 14, 2015 at 05:52:38PM -0700, Guenter Roeck wrote: > >>On 05/14/2015 07:09 AM, Andreas Werner wrote: > >>>On Thu, May 14, 2015 at 06:30:0

Re: Window watchdog driver design

2015-05-14 Thread Andreas Werner
On Thu, May 14, 2015 at 05:52:38PM -0700, Guenter Roeck wrote: > On 05/14/2015 07:09 AM, Andreas Werner wrote: > >On Thu, May 14, 2015 at 06:30:05AM -0700, Guenter Roeck wrote: > >>On 05/14/2015 04:56 AM, Andreas Werner wrote: > >>>Hi, > >>>in the nex

Re: Window watchdog driver design

2015-05-14 Thread Andreas Werner
On Thu, May 14, 2015 at 06:30:05AM -0700, Guenter Roeck wrote: > On 05/14/2015 04:56 AM, Andreas Werner wrote: > >Hi, > >in the next few weeks I need to write a driver for a window wachtdog > >implemented in a CPLD. I have some questions about the design > >of the drive

Window watchdog driver design

2015-05-14 Thread Andreas Werner
Hi, in the next few weeks I need to write a driver for a window wachtdog implemented in a CPLD. I have some questions about the design of the driver and the best way to write this driver to also be able to submit it. The triggering and configuration of the Watchdog is done by several GPIOs which a

Re: [PATCH 1/2] drivers/misc/eeprom/men_eeprod: Introduce MEN Board Information EEPROM driver

2014-10-20 Thread Andreas Werner
On Mon, Oct 20, 2014 at 05:11:41PM +0800, Greg KH wrote: > On Mon, Oct 20, 2014 at 10:33:45AM +0200, Andreas Werner wrote: > > On Thu, Oct 16, 2014 at 01:44:02PM +0200, Andreas Werner wrote: > > > On Thu, Oct 16, 2014 at 11:59:10AM +0200, Wolfram Sang wrote: > > > >

Re: [PATCH 1/2] drivers/misc/eeprom/men_eeprod: Introduce MEN Board Information EEPROM driver

2014-10-20 Thread Andreas Werner
On Mon, Oct 20, 2014 at 10:24:22AM +0200, Wolfram Sang wrote: > * PGP Signed by an unknown key > > > Here it gets frustrating. It seems you have no idea what an OS is for, > > not even after I tried to describe it :( > I am pretty sure that i know what an OS is for. > Sorry, that might have bee

Re: [PATCH 1/2] drivers/misc/eeprom/men_eeprod: Introduce MEN Board Information EEPROM driver

2014-10-20 Thread Andreas Werner
On Thu, Oct 16, 2014 at 01:44:02PM +0200, Andreas Werner wrote: > On Thu, Oct 16, 2014 at 11:59:10AM +0200, Wolfram Sang wrote: > > * PGP Signed by an unknown key > > > > > > > I do not want to parse the things in userspace because this EEPROM data > > > ar

Re: [PATCH 1/2] drivers/misc/eeprom/men_eeprod: Introduce MEN Board Information EEPROM driver

2014-10-16 Thread Andreas Werner
On Thu, Oct 16, 2014 at 11:59:10AM +0200, Wolfram Sang wrote: > * PGP Signed by an unknown key > > > > I do not want to parse the things in userspace because this EEPROM data > > are related to the hardware and i want to give our customer the easiest way > > to access the data without installing

Re: [PATCH 1/2] drivers/misc/eeprom/men_eeprod: Introduce MEN Board Information EEPROM driver

2014-10-16 Thread Andreas Werner
On Thu, Oct 16, 2014 at 10:58:35AM +0200, Wolfram Sang wrote: > * PGP Signed by an unknown key > > On Thu, Oct 16, 2014 at 10:15:08AM +0200, Andreas Werner wrote: > > Added driver to support the MEN Board Information EEPROM. > > The driver exports the production informati

Re: [PATCH 1/2] drivers/misc/eeprom/men_eeprod: Introduce MEN Board Information EEPROM driver

2014-10-16 Thread Andreas Werner
On Thu, Oct 16, 2014 at 10:44:12AM +0200, Greg KH wrote: > On Thu, Oct 16, 2014 at 10:15:08AM +0200, Andreas Werner wrote: > > +struct eeprom_data { > > + uint8_t eeprod_id; > > Please use the "real" kernel types, "u8" here, and "u32" in o

[PATCH 1/2] drivers/misc/eeprom/men_eeprod: Introduce MEN Board Information EEPROM driver

2014-10-16 Thread Andreas Werner
Added driver to support the MEN Board Information EEPROM. The driver exports the production information as read only sysfs entries, as well as a user section which is read/write accessible. Tested on PPC QorIQ and Intel Atom E680. Tested-by: Johannes Thumshirn Signed-off-by: Andreas Werner

[PATCH 0/2] Introduce MEN Board Information EEPROM driver

2014-10-16 Thread Andreas Werner
as well as a user section for read-write access. There is also a ABI documentation for sysfs description included. Andreas Werner (2): drivers/misc/eeprom/men_eeprod: Introduce MEN Board Information EEPROM driver Documentation/ABI/testing/men_eeprod: Added sysfs description for

[PATCH 2/2] Documentation/ABI/testing/men_eeprod: Added sysfs description for men_eeprod

2014-10-16 Thread Andreas Werner
This patch adds the description for the men_eeprod. men_eeprod is a driver for the MEN Board Information EEPROM which exports the data using sysfs entries. Signed-off-by: Andreas Werner --- .../ABI/testing/sysfs-bus-i2c-devices-men_eeprod | 69 ++ 1 file changed, 69

Re: [PATCH v6 0/4] Introduce MEN 14F021P00 BMC driver series

2014-09-25 Thread Andreas Werner
On Wed, Sep 24, 2014 at 07:41:43PM +0100, Lee Jones wrote: > On Wed, 24 Sep 2014, Guenter Roeck wrote: > > > On Wed, Sep 24, 2014 at 09:33:32AM -0700, Bryan Wu wrote: > > > On Wed, Sep 24, 2014 at 9:18 AM, Lee Jones wrote: > > > > On Wed, 24 Sep 2014, Guenter Roeck wrote: > > > > > > > >> On Wed,

Re: eeprom Board Information EEPROM

2014-09-20 Thread Andreas Werner
On Tue, Sep 16, 2014 at 01:14:36PM +0530, kavitha bk wrote: > On Mon, Sep 15, 2014 at 10:52 PM, Andreas Werner wrote: > > > On Thu, Sep 04, 2014 at 09:59:53PM +0530, kavitha bk wrote: > > > On Wed, Sep 3, 2014 at 8:04 PM, Andreas Werner > > wrote: > > >

Re: [PATCH] MAINTAINERS: Adds Andreas Werner to maintainers list for MEN F21BMC

2014-09-16 Thread Andreas Werner
On Mon, Sep 15, 2014 at 11:42:19PM +0100, Lee Jones wrote: > On Mon, 15 Sep 2014, Andreas Werner wrote: > > > Added maintainer for the following MEN F21BMC drivers: > > - menf21bmc (MFD) > > - menf21bmc_wdt (Watchdog) > > - menf21bmc_hwmon (HWMON)

[PATCH] MAINTAINERS: Adds Andreas Werner to maintainers list for MEN F21BMC

2014-09-14 Thread Andreas Werner
Added maintainer for the following MEN F21BMC drivers: - menf21bmc (MFD) - menf21bmc_wdt (Watchdog) - menf21bmc_hwmon (HWMON) - leds-menf21bmc (LED) Signed-off-by: Andreas Werner --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a

Re: eeprom Board Information EEPROM

2014-09-02 Thread Andreas Werner
On Mon, Sep 01, 2014 at 01:52:10PM +0530, kavitha bk wrote: > On Sat, Aug 30, 2014 at 2:26 AM, Andreas Werner wrote: > > > I have a question regarding a driver for a Board Information EEPROM. > > > > I want to give our customer easy access to our Board Information EEPROM

eeprom Board Information EEPROM

2014-08-29 Thread Andreas Werner
I have a question regarding a driver for a Board Information EEPROM. I want to give our customer easy access to our Board Information EEPROM which is an 256byte I2C eeprom. There is a defined structure of information at the beginning of the eeprom which includes board name, serialnumber, producti

Re: [PATCH v6 3/4] drivers/leds/leds-menf21bmc: introduce MEN 14F021P00 BMC LED driver

2014-08-29 Thread Andreas Werner
On Fri, Aug 29, 2014 at 07:59:15AM +0100, Lee Jones wrote: > On Thu, 28 Aug 2014, Bryan Wu wrote: > > > On Wed, Aug 27, 2014 at 10:52 AM, Andreas Werner > > wrote: > > > Added driver to support the 14F021P00 BMC LEDs. > > > The BMC is a Board Management

Re: [PATCH v6 4/4] drivers/hwmon/menf21bmc_hwmon: introduce MEN14F021P00 BMC HWMON driver

2014-08-28 Thread Andreas Werner
On Wed, Aug 27, 2014 at 11:38:43AM -0700, Guenter Roeck wrote: > On Wed, Aug 27, 2014 at 07:53:06PM +0200, Andreas Werner wrote: > > Added driver to support the 14F021P00 BMC Hardware Monitoring. > > The BMC is a Board Management Controller including monitoring of the >

[PATCH v6 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver

2014-08-27 Thread Andreas Werner
communication to the device. The MFD driver currently supports the following features: - Watchdog - LEDs - Hwmon (voltage monitoring) Signed-off-by: Andreas Werner --- drivers/mfd/Kconfig | 15 ++ drivers/mfd/Makefile| 1 + drivers/mfd/menf21bmc.c | 132

[PATCH v6 3/4] drivers/leds/leds-menf21bmc: introduce MEN 14F021P00 BMC LED driver

2014-08-27 Thread Andreas Werner
Added driver to support the 14F021P00 BMC LEDs. The BMC is a Board Management Controller including four LEDs which can be switched on and off. Signed-off-by: Andreas Werner --- drivers/leds/Kconfig | 9 +++ drivers/leds/Makefile | 1 + drivers/leds/leds-menf21bmc.c | 131

[PATCH v6 2/4] drivers/watchdog/menf21bmc_wdt: introduce MEN 14F021P00 BMC Watchdog driver

2014-08-27 Thread Andreas Werner
Added driver to support the 14F021P00 BMC Watchdog. The BMC is a Board Management Controller including watchdog functionality. Signed-off-by: Andreas Werner --- drivers/watchdog/Kconfig | 10 ++ drivers/watchdog/Makefile| 1 + drivers/watchdog/menf21bmc_wdt.c | 203

[PATCH v6 4/4] drivers/hwmon/menf21bmc_hwmon: introduce MEN14F021P00 BMC HWMON driver

2014-08-27 Thread Andreas Werner
Added driver to support the 14F021P00 BMC Hardware Monitoring. The BMC is a Board Management Controller including monitoring of the board voltages. Signed-off-by: Andreas Werner --- Documentation/hwmon/menf21bmc | 50 + drivers/hwmon/Kconfig | 10 ++ drivers/hwmon/Makefile

[PATCH v6 0/4] Introduce MEN 14F021P00 BMC driver series

2014-08-27 Thread Andreas Werner
ror. - moved "leave production mode" from Watchdog driver to mfd core. - fixed some return values in the watchdog driver to return the original error value instead of -EIO. Andreas Werner (4): drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver

Re: [PATCH v5 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver

2014-08-27 Thread Andreas Werner
On Wed, Aug 27, 2014 at 12:01:42PM +0100, Lee Jones wrote: > On Wed, 27 Aug 2014, Andreas Werner wrote: > > On Wed, Aug 27, 2014 at 08:26:33AM +0100, Lee Jones wrote: > > > On Tue, 26 Aug 2014, Andreas Werner wrote: > > > > The MEN 14F021P00 Board Management Cont

Re: [PATCH v5 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver

2014-08-27 Thread Andreas Werner
On Wed, Aug 27, 2014 at 08:26:33AM +0100, Lee Jones wrote: > On Tue, 26 Aug 2014, Andreas Werner wrote: > > The MEN 14F021P00 Board Management Controller provides an > > I2C interface to the host to access the feature implemented in the BMC. > > The BMC is a PIC Microntrol

Re: [PATCH v5 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver

2014-08-27 Thread Andreas Werner
On Wed, Aug 27, 2014 at 08:26:33AM +0100, Lee Jones wrote: > On Tue, 26 Aug 2014, Andreas Werner wrote: > > The MEN 14F021P00 Board Management Controller provides an > > I2C interface to the host to access the feature implemented in the BMC. > > The BMC is a PIC Microntrol

Re: [PATCH v5 4/4] drivers/hwmon/menf21bmc_hwmon: introduce MEN14F021P00 BMC HWMON driver

2014-08-27 Thread Andreas Werner
On Tue, Aug 26, 2014 at 10:15:41AM -0700, Guenter Roeck wrote: > On Tue, Aug 26, 2014 at 07:46:53PM +0200, Andreas Werner wrote: > > Added driver to support the 14F021P00 BMC Hardware Monitoring. > > The BMC is a Board Management Controller including monitoring of the >

[PATCH v5 0/4] Introduce MEN 14F021P00 BMC driver series

2014-08-26 Thread Andreas Werner
o return both, value and error. - moved "leave production mode" from Watchdog driver to mfd core. - fixed some return values in the watchdog driver to return the original error value instead of -EIO. Andreas Werner (4): drivers/mfd/menf21bmc: introd

[PATCH v5 4/4] drivers/hwmon/menf21bmc_hwmon: introduce MEN14F021P00 BMC HWMON driver

2014-08-26 Thread Andreas Werner
Added driver to support the 14F021P00 BMC Hardware Monitoring. The BMC is a Board Management Controller including monitoring of the board voltages. Signed-off-by: Andreas Werner --- Documentation/hwmon/menf21bmc | 49 + drivers/hwmon/Kconfig | 7 ++ drivers/hwmon/Makefile

[PATCH v5 3/4] drivers/leds/leds-menf21bmc: introduce MEN 14F021P00 BMC LED driver

2014-08-26 Thread Andreas Werner
Added driver to support the 14F021P00 BMC LEDs. The BMC is a Board Management Controller including four LEDs which can be switched on and off. Signed-off-by: Andreas Werner --- drivers/leds/Kconfig | 6 ++ drivers/leds/Makefile | 1 + drivers/leds/leds-menf21bmc.c | 131

[PATCH v5 2/4] drivers/watchdog/menf21bmc_wdt: introduce MEN 14F021P00 BMC Watchdog driver

2014-08-26 Thread Andreas Werner
Added driver to support the 14F021P00 BMC Watchdog. The BMC is a Board Management Controller including watchdog functionality. Signed-off-by: Andreas Werner Reviewed-by: Guenter Roeck --- drivers/watchdog/Kconfig | 7 ++ drivers/watchdog/Makefile| 1 + drivers/watchdog

[PATCH v5 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver

2014-08-26 Thread Andreas Werner
communication to the device. The MFD driver currently supports the following features: - Watchdog - LEDs - Hwmon (voltage monitoring) Signed-off-by: Andreas Werner Acked-by: Lee Jones --- drivers/mfd/Kconfig | 12 + drivers/mfd/Makefile| 1 + drivers/mfd/menf21bmc.c

Re: [PATCH v4 4/4] drivers/hwmon/menf21bmc_hwmon: introduce MEN14F021P00 BMC HWMON driver

2014-08-22 Thread Andreas Werner
On Thu, Aug 21, 2014 at 11:45:01AM -0700, Guenter Roeck wrote: > On Wed, Aug 13, 2014 at 10:40:37AM +0200, Andreas Werner wrote: > > Added driver to support the 14F021P00 BMC Hardware Monitoring. > > The BMC is a Board Management Controller including monitoring of the >

Re: [PATCH v4 4/4] drivers/hwmon/menf21bmc_hwmon: introduce MEN14F021P00 BMC HWMON driver

2014-08-22 Thread Andreas Werner
On Thu, Aug 21, 2014 at 11:37:52AM -0700, Guenter Roeck wrote: > On Wed, Aug 13, 2014 at 10:40:37AM +0200, Andreas Werner wrote: > > Added driver to support the 14F021P00 BMC Hardware Monitoring. > > The BMC is a Board Management Controller including monitoring of the >

Re: [PATCH v4 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver

2014-08-21 Thread Andreas Werner
On Thu, Aug 21, 2014 at 12:30:46PM +0100, Lee Jones wrote: > On Wed, 13 Aug 2014, Andreas Werner wrote: > > The MEN 14F021P00 Board Management Controller provides an > > I2C interface to the host to access the feature implemented in the BMC. > > The BMC is a PIC Microntrol

[PATCH v4 2/4] drivers/watchdog/menf21bmc_wdt: introduce MEN 14F021P00 BMC Watchdog driver

2014-08-13 Thread Andreas Werner
Added driver to support the 14F021P00 BMC Watchdog. The BMC is a Board Management Controller including watchdog functionality. Signed-off-by: Andreas Werner --- drivers/watchdog/Kconfig | 7 ++ drivers/watchdog/Makefile| 1 + drivers/watchdog/menf21bmc_wdt.c | 203

[PATCH v4 4/4] drivers/hwmon/menf21bmc_hwmon: introduce MEN14F021P00 BMC HWMON driver

2014-08-13 Thread Andreas Werner
Added driver to support the 14F021P00 BMC Hardware Monitoring. The BMC is a Board Management Controller including monitoring of the board voltages. Signed-off-by: Andreas Werner --- drivers/hwmon/Kconfig | 7 ++ drivers/hwmon/Makefile | 1 + drivers/hwmon

[PATCH v4 3/4] drivers/leds/leds-menf21bmc: introduce MEN 14F021P00 BMC LED driver

2014-08-13 Thread Andreas Werner
Added driver to support the 14F021P00 BMC LEDs. The BMC is a Board Management Controller including four LEDs which can be switched on and off. Signed-off-by: Andreas Werner --- drivers/leds/Kconfig | 6 ++ drivers/leds/Makefile | 1 + drivers/leds/leds-menf21bmc.c | 131

  1   2   >