Re: [RFC PATCH] extcon: Fix sleeping in atomic context after connecting USB cable

2014-09-28 Thread 함명주
> > Kernel built with extcon and charger-manager. > > After connecting the USB cable sleeping function was called from atomic > context: > [ 63.328648] BUG: sleeping function called from invalid context at > kernel/locking/mutex.c:586 [] > [ 63.388743] Workqueue: events max14577_muic_irq_

Re: [PATCH] extcon: sm5502: Drop useless include

2014-09-16 Thread 함명주
> Don't include when the driver does not use anything > from this header file. > > Signed-off-by: Jean Delvare > Cc: Chanwoo Choi > Cc: MyungJoo Ham Acked-by: MyungJoo Ham Chanwoo, please review/merge the patch when you return. Cheers, MyungJoo > --- > drivers/extcon/extcon-sm5502.c |

Re: Re: [PATCH 0/5] Add dt support for extcon gpio driver

2014-09-16 Thread 함명주
> Hi Chanwoo, > > Could you please look into this series? Hi, Chanwoo has been on a vacation since last week. I think he will be out of office (and out of the work email) until this week. I will not be generally available this week as well. Cheers, MyungJoo. > > On 09/09/2014 09:44 AM, Georg

Re: RE: [PATCH 1/2] PM / devfreq: Export helper functions for drivers

2014-08-12 Thread 함명주
; drivers/devfreq/devfreq.c |3 +++ > 1 file changed, 3 insertions(+) -- MyungJoo Ham (함명주), PHD Frontier CS Lab, Software Center Samsung Electronics Cell: +82-10-6714-2858N떑꿩�r툤y鉉싕b쾊Ф푤v�^�)頻{.n�+돴쪐{콗喩zX㎍썳變}찠꼿쟺�&j:+v돣�쳭喩zZ+€�+zf"톒쉱�~넮녬i鎬z�췿ⅱ�?솳鈺�&�)刪f뷌^j푹y쬶끷@A첺뛴 0띠h��뭝

Re: [PATCH v4] PM / devfreq: Add possible_frequencies device attribute

2014-07-20 Thread 함명주
Ham I'll rebase and merge into devfreq-next when I get back (I can only access the Internet via mobile phones until Wed this week.) I'll move this sysfs entry to .../stat along with stat sysfs and make it conditional (appears only when stat is available) Cheers, MyungJoo. -- MyungJ

Re: [PATCH 1/2] PM / devfreq: Export helper functions for drivers

2014-07-20 Thread 함명주
is there any reason not to use EXPORT_SYMBOL_GPL ? Cheers, MyungJoo. -- MyungJoo Ham (함명주), PHD Frontier CS Lab, Software Center Samsung Electronics Cell: +82-10-6714-2858

Re: Re: [PATCH] PM / devfreq: Use freq_table for available_frequencies

2014-04-14 Thread 함명주
> On 04/14/2014 06:36 PM, 함명주 wrote: > >> MyungJoo/Kyungmin, > >> > >> Bump. Can we accept this patch please? > >> > >> -Saravana > > > > Nack. > > > > Please note that freq_table is also an optional value, which may >

Re: Re: [PATCH] PM / devfreq: Use freq_table for available_frequencies

2014-04-14 Thread 함명주
> MyungJoo/Kyungmin, > > Bump. Can we accept this patch please? > > -Saravana Nack. Please note that freq_table is also an optional value, which may be null. Besides, please be aware that your code is under rcu_read_lock(). Cheers, MyungJoo. ps. I'll send a related patch (avoid accessing nu

Re: Re: [PATCHv4 0/5] devfreq: exynos: Fix minor issue and code clean to remove legacy method

2014-03-27 Thread 함명주
On Mon, Mar 24, 2014 at 10:36 AM, Chanwoo Choi wrote: > Hi Tomasz, > > On 03/22/2014 11:52 PM, Tomasz Figa wrote: >> Hi, >> >> [fixing mistyped addresses of me and Bartlomiej] >> >> On 20.03.2014 03:59, Chanwoo Choi wrote: >>> This patchset use SIMPLE_DEV_PM_OPS macro intead of legacy method and

Re: [PATCH 0/4] devfreq: exynos: generalize PPMU code

2014-03-27 Thread 함명주
On Sat, Mar 22, 2014 at 2:31 AM, Bartlomiej Zolnierkiewicz wrote: > Hi, > > This patch series generalizes PPMU support for Exynos devfreq > drivers. > > It is based on top of "devfreq: exynos: Fix minor issue and code > clean to remove legacy method" patch series from Chanwoo Choi > (https://lk

Re: Re: [PATCH] PM / devfreq: Fix out of bounds access of transition table array

2014-02-25 Thread 함명주
> On 02/23/2014 11:15 PM, Saravana Kannan wrote: > > The previous_freq value for a device could be an invalid frequency that > > results in a error value being returned from devfreq_get_freq_level(). > > Check for an error value before using that to index into the transition > > table. > > > > Not

Re: Re: [RESEND][PATCH 1/3] PM / devfreq: exynos4_bus: Fix missing mutex_unlock if opp_find_freq_floor fails

2013-04-12 Thread 함명주
> On Friday, April 12, 2013 01:54:18 PM Axel Lin wrote: > > We need to call mutex_unlock() in the error path. > > > > Signed-off-by: Axel Lin > > All three patches applied to linux-pm.git/linux-next. > > Exynos maintainers, if you have any objections, please holler. > > Thanks, > Rafael This

Re: Re: [linux-next PATCH] PM / devfreq: documentation cleanups for devfreq header

2012-10-30 Thread 함명주
> On Tuesday, October 30, 2012 08:09:09 AM MyungJoo Ham wrote: [] > > > > Acked-by: MyungJoo Ham > > > > Applying to git://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git > > for-rafael, which is based on rafael's linux-pm.git / linux-next. > > > > http://git.kernel.org/?p=linux/kernel

Re: [PATCH 1/3] devfreq: core updates to support devices which can idle

2012-09-10 Thread 함명주
> Prepare devfreq core framework to support devices which > can idle. When device idleness is detected perhaps through > runtime-pm, need some mechanism to suspend devfreq load > monitoring and resume back when device is online. Present > code continues monitoring unless device is removed from > de

Re: [PATCH] PM/devfreq: Use devm_* functions in exynos4_bus.c

2012-08-29 Thread 함명주
> devm_* functions are device managed functions and make cleanup code > simpler and smaller. > devm_kzalloc and devm_regulator_get functions are used. > > Signed-off-by: Sachin Kamat > --- Signed-off-by: MyungJoo Ham Applied to http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs

Re: [PATCH] Extcon: Minor change in the declaration of cable_names

2012-08-19 Thread 함명주
> From: anish kumar > > Instead of "const char **supported_cable" it is better to have > it as "const char *const *supported_cable". > > Signed-off-by: anish kumar Could you please elaborate on why it's better? (Is this fixing the using the standard naming issue Mark mentioned before?) Chee

Re: [PATCH] extcon: fixing typos

2012-08-09 Thread 함명주
> Signed-off-by: Peter Meerwald The three "typo" patches: Signed-off-by: MyungJoo Ham I will apply the patches as soon as the branch is cleared up (will be using http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/extcon-for-next until I get a decent repository somewhere)

Re: Re: [PATCH] PM QoS: Add a metric : Bus Throughput.

2012-08-09 Thread 함명주
> + Myungjoo Ham, > > It used at devfreq. Mr. Ham can you explain it in detail? > > Thank you, > Kyungmin Park > , > On 8/9/12, Rafael J. Wysocki wrote: > > On Wednesday, August 08, 2012, Jonghwa Lee wrote: > >> Bus throughput metric is added to PM QoS in order to control the > >> frequency of m

Re: [PATCH] Extcon: adc_jack: adc-jack driver to support 3.5 pi or simliar devices

2012-08-05 Thread 함명주
> From: anish kumar > > External connector devices that decides connection information based on > ADC values may use adc-jack device driver. The user simply needs to > provide a table of adc range and connection states. Then, extcon > framework will automatically notify others. > > Signed-off-by

Re: Gethering power management/policy hw drivers under drivers/power/? (Re: [RFC][PATCH v3 1/3] runtime interpreted power sequences)

2012-07-29 Thread 함명주
> On Mon, Jul 30, 2012 at 10:51:42AM +0900, Alex Courbot wrote: > [...] > > On the other hand I have just noticed that the apparently unrelated > > Adaptive Voltage Scaling driver just appeared in drivers/power/avs. > > So if Anton and David are ok with this, maybe I could put the power > > sequenc