> On 02/23/2014 11:15 PM, Saravana Kannan wrote:
> > The previous_freq value for a device could be an invalid frequency that
> > results in a error value being returned from devfreq_get_freq_level().
> > Check for an error value before using that to index into the transition
> > table.
> >
> > Not doing this check will result in memory corruption when previous_freq is
> > not a valid frequency.
> >
> > Signed-off-by: Saravana Kannan <skan...@codeaurora.org>
>
> MyungJoo/Kyungmin,
>
> Would either of you have some time to respond to this?
>
> Thanks,
> Saravana
Dear Saravana,
> > + prev_lev = devfreq_get_freq_level(devfreq, devfreq->previous_freq);
> > + if (prev_lev < 0)
> > + return 0;
If devfreq_get_freq_level returned error, please return that error
to the caller. You are retuning 0 in that case.
Plus, do you think we are going to change profile->freq_table in run-time?
(by accidently? or intentionally?)
Cheers,
MyungJoo.
>
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
>
>
>
>
>
>
>
N떑꿩�r툤y鉉싕b쾊Ф푤v�^�)頻{.n�+돴쪐{콗喩zX㎍썳變}찠꼿쟺�&j:+v돣�쳭喩zZ+�+zf＂톒쉱�~넮녬i鎬z� 췿ⅱ�?솳鈺�&�)刪f뷌^j푹y쬶끷@A첺뛴
0띠h��뭝
