Re: [PATCH v2] net: Fix uninit character pointer and return values

2025-10-02 Thread Sidharth Seela
On Mon, Sep 29, 2025 at 11:28 PM Willem de Bruijn wrote: > > Reminder: use the net prefix: [PATCH net v2] Oh I thought you meant me to change the subsytem in the subject. Changing. > My previous response accidentally left a state comment. The main > feedback still held: > This default case calls

[PATCH v6 2/7] vduse: add v1 API definition

2025-10-02 Thread Eugenio Pérez
This allows the kernel to detect whether the userspace VDUSE device supports the VQ group and ASID features. VDUSE devices that don't set the V1 API will not receive the new messages, and vdpa device will be created with only one vq group and asid. The next patches implement the new feature incre

[PATCH] vdpa/mlx5: Fix incorrect error code reporting in query_virtqueues

2025-10-02 Thread Alok Tiwari
When query_virtqueues() fails, the error log prints the variable err instead of cmd->err. Since err may still be zero at this point, the log message can misleadingly report a success value 0 even though the command actually failed. Even worse, once err is set to the first failure, subsequent logs

Re: [PATCH RFC 0/3] arm64/gcs: Allow reuse of user managed shadow stacks

2025-10-02 Thread Deepak Gupta
On Fri, Sep 26, 2025 at 05:09:08PM +0100, Mark Brown wrote: On Fri, Sep 26, 2025 at 03:46:26PM +, Edgecombe, Rick P wrote: On Fri, 2025-09-26 at 01:44 +0100, Mark Brown wrote: > I agree it seems clearly better from a security point of view to have > writable shadow stacks than none at all

linux-6.17/tools/testing/selftests/landlock/fs_test.c:5631: Test for pointer < 0 ?

2025-10-02 Thread David Binderman
Hello there, Static analyser cppcheck says: linux-6.17/tools/testing/selftests/landlock/fs_test.c:5631:23: style: A pointer can not be negative so it is either pointless or an error to check if it is. [pointerLessThanZero] Source code is     if (log_match_cursor < 0)         return (long long

Re: [PATCH v5 3/6] vduse: add vq group support

2025-10-02 Thread Eugenio Perez Martin
On Fri, Sep 26, 2025 at 5:27 PM Michael S. Tsirkin wrote: > > On Fri, Sep 26, 2025 at 12:14:29PM +0200, Eugenio Pérez wrote: > > @@ -1859,6 +1894,7 @@ static int vduse_create_dev(struct vduse_dev_config > > *config, > > dev->device_features = config->features; > > dev->device_id = con

Re: [PATCH v15 0/5] Enable automatic SVN updates for SGX enclaves

2025-10-02 Thread Nataliia Bondarevska
On Mon, Sep 29, 2025 at 1:50 PM Dave Hansen wrote: > > On 9/29/25 13:33, Nataliia Bondarevska wrote: > >> Could someone please spend a few minutes to explain what this tag means? > > My apologies; I've clarified the details of the testing below. > > > > The verification was performed on a SPR mach

RE: [PATCH v15 0/5] Enable automatic SVN updates for SGX enclaves

2025-10-02 Thread Reshetova, Elena
> On Fri, Sep 5, 2025 at 12:37 PM Dave Hansen wrote: > > > > On 8/18/25 00:11, Elena Reshetova wrote: > > > Testing > > > --- > > > > > > Tested on EMR machine using kernel 6.17.0_rc1 & sgx selftests. > > > Also tested on a Kaby Lake machine without EUPDATESVN support. > > > If Google folks

Re: [PATCH 1/6] dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali ADSP

2025-10-02 Thread Dmitry Baryshkov
On Tue, Sep 30, 2025 at 10:12:27AM +0800, Jingyi Wang wrote: > > > On 9/29/2025 8:22 PM, Dmitry Baryshkov wrote: > > On Mon, Sep 29, 2025 at 06:11:23PM +0800, Jingyi Wang wrote: > >> > >> > >> On 9/29/2025 5:39 PM, Dmitry Baryshkov wrote: > >>> On Mon, Sep 29, 2025 at 02:06:11PM +0800, Jingyi Wan

[PATCH net v4] selftest:net: Fix uninit return values

2025-10-02 Thread Sidharth Seela
Fix functions that return undefined values. These issues were caught by running clang using LLVM=1 option. Clang warnings are as follows: ovpn-cli.c:1587:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] 1587 | if (!sock) {

Re: [PATCH v15 0/5] Enable automatic SVN updates for SGX enclaves

2025-10-02 Thread Nataliia Bondarevska
On Mon, Sep 29, 2025 at 10:35 AM Dave Hansen wrote: > > On 9/29/25 10:12, Nataliia Bondarevska wrote: > > Tested-by: Nataliia Bondarevska > > First, thanks for testing this. > > But I'd really, really appreciate if these tags (top posted and without > any context trimmed no less) came with at _le

Re: [PATCH 2/6] dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali CDSP

2025-10-02 Thread Dmitry Baryshkov
On Mon, Sep 29, 2025 at 02:20:54PM +0800, Jingyi Wang wrote: > > > On 9/25/2025 9:48 AM, Krzysztof Kozłowski wrote: > > On Thu, 25 Sept 2025 at 08:37, Jingyi Wang > > wrote: > >> > >> Add remote processor PAS loader for Kaanapali CDSP processor, compatible > >> with earlier SM8550 with minor di

Re: [PATCH bpf-next v4 04/15] selftests/bpf: test_xsk: fix memory leak in testapp_stats_rx_dropped()

2025-10-02 Thread Bastien Curutchet
On 9/27/25 1:19 PM, Alexei Starovoitov wrote: On Fri, Sep 26, 2025 at 12:47 PM Maciej Fijalkowski wrote: On Fri, Sep 26, 2025 at 08:39:28AM +0200, Bastien Curutchet wrote: Hi Maciej, On 9/25/25 3:32 PM, Maciej Fijalkowski wrote: On Wed, Sep 24, 2025 at 04:49:39PM +0200, Bastien Curutchet (e

Re: [PATCH 5/6] remoteproc: qcom: pas: Add late attach support for subsystems

2025-10-02 Thread Jingyi Wang
On 9/25/2025 1:56 PM, Zhongqiu Han wrote: > On 9/25/2025 7:37 AM, Jingyi Wang wrote: >> From: Gokul krishna Krishnakumar >> >> Subsystems can be brought out of reset by entities such as >> bootloaders. Before attaching such subsystems, it is important to >> check the state of the subsystem. Thi

[PATCH v3 03/11] arm64: dts: qcom: sdm845-lg-judyln: Add battery and charger

2025-10-02 Thread Paul Sajna
From: Christopher Brown Values based on lineageos kernel https://github.com/LineageOS/android_kernel_lge_sdm845/blob/lineage-22.2/arch/arm64/boot/dts/lge/sdm845-battery/LGE_BLT39_LGC_3000mAh.dtsi Signed-off-by: Christopher Brown Signed-off-by: Paul Sajna --- arch/arm64/boot/dts/qcom/sdm845-l

Re: [PATCH] selftests/bpf: Add -Wsign-compare C compilation flag

2025-10-02 Thread Eduard Zingerman
On Wed, 2025-09-24 at 17:23 +0100, Mehdi Ben Hadj Khelifa wrote: > -Change all the source files and the corresponding headers > to having matching sign comparisons. > > Signed-off-by: Mehdi Ben Hadj Khelifa > --- > As suggested by the TODO, -Wsign-compare was added to the C compilation > flags f

Re: [PATCH] selftests/bpf: Add -Wsign-compare C compilation flag

2025-10-02 Thread David Laight
On Mon, 29 Sep 2025 17:03:29 +0100 Mehdi Ben Hadj Khelifa wrote: > On 9/26/25 12:45 PM, David Laight wrote: > > On Wed, 24 Sep 2025 17:23:49 +0100 > > Mehdi Ben Hadj Khelifa wrote: > > > >> -Change all the source files and the corresponding headers > >> to having matching sign comparisons.

Re: [PATCH v3 07/11] arm64: dts: qcom: sdm845-lg-{common, judyln}: Add wifi node

2025-10-02 Thread Paul Sajna
October 2, 2025 at 9:37 AM, "Konrad Dybcio" mailto:konrad.dyb...@oss.qualcomm.com?to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote: > > On 10/2/25 6:51 AM, Paul Sajna wrote: > > > > > October 1, 2025 at 9:14 AM, "Konrad Dybcio" > mailto:konrad.dyb...@oss.qualcomm.com

[PATCH v2 02/21] rcu: Re-implement RCU Tasks Trace in terms of SRCU-fast

2025-10-02 Thread Paul E. McKenney
This commit saves more than 500 lines of RCU code by re-implementing RCU Tasks Trace in terms of SRCU-fast. Follow-up work will remove more code that does not cause problems by its presence, but that is no longer required. This variant places smp_mb() in rcu_read_{,un}lock_trace(), which will be

Re: [PATCH v2 0/6] remoteproc: imx_rproc: Use device managed API to clean up the driver

2025-10-02 Thread Mathieu Poirier
On Wed, 24 Sept 2025 at 09:35, Peng Fan wrote: > > Hi Mathieu, Bjorn > > On Tue, Sep 23, 2025 at 01:16:32PM +0800, Peng Fan wrote: > >This is the 2nd series to cleanup the driver. > > > >--- > >Changes in v2: > >- Address a build warning in patch 4/6 > >- Add R-b from Frank and Daniel > >- Link to

Re: [PATCH v5 3/6] vduse: add vq group support

2025-10-02 Thread Michael S. Tsirkin
On Mon, Sep 29, 2025 at 10:52:45AM +0200, Eugenio Perez Martin wrote: > On Mon, Sep 29, 2025 at 9:55 AM Michael S. Tsirkin wrote: > > > > On Mon, Sep 29, 2025 at 07:55:59AM +0200, Eugenio Perez Martin wrote: > > > On Fri, Sep 26, 2025 at 5:27 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On

Re: [PATCH v7 8/8] kbuild: vmlinux.unstripped should always depend on .vmlinux.export.o

2025-10-02 Thread ChaosEsque Team
Alexey Gladkov. RUKKIIEEE (Rus) On Mon, Aug 18, 2025 at 1:00 PM Alexey Gladkov wrote: > > Since .vmlinux.export.c is used to add generated by modpost modaliases > for builtin modules the .vmlinux.export.o is no longer optional and > should always be created. The generation of this file is

[GIT PULL] RCU changes for v6.18

2025-10-02 Thread Paul E. McKenney
Hello, Linus, Please pull this RCU update into the v6.18 merge window: git://git.kernel.org/pub/scm/linux/kernel/git/rcu/linux tags/rcu.2025.09.26a # HEAD: 1d289fc5691c7a970a285bc53292bac9e37c89a6: Merge branch 'torture.2025.08.14a' into HEAD (2025-09-23 02:10:51 -0700)

Re: [PATCH bpf-next v2 2/3] selftests/bpf: skip recursive functions for kprobe_multi

2025-10-02 Thread ChaosEsque Team
Indeed, it is so long. Sir Dong, of Meng. On Tue, Aug 26, 2025 at 4:05 AM Menglong Dong wrote: > > Some functions is recursive for the kprobe_multi and impact the benchmark > results. So just skip them. > > Signed-off-by: Menglong Dong > --- > v2: > - introduce trace_blacklist instead of copy-pa

[PATCH net v6 4/4] selftest: netcons: add test for netconsole over bonded interfaces

2025-10-02 Thread Breno Leitao
This patch adds a selftest that verifies netconsole functionality over bonded network interfaces using netdevsim. It sets up two bonded interfaces acting as transmit (TX) and receive (RX) ends, placed in separate network namespaces. The test sends kernel log messages and verifies that they are prop

Re: [PATCH v2 08/21] rcu: Add noinstr-fast rcu_read_{,un}lock_tasks_trace() APIs

2025-10-02 Thread Alexei Starovoitov
On Thu, Oct 2, 2025 at 6:38 AM Paul E. McKenney wrote: > > On Wed, Oct 01, 2025 at 06:37:33PM -0700, Alexei Starovoitov wrote: > > On Wed, Oct 1, 2025 at 7:48 AM Paul E. McKenney wrote: > > > > > > +static inline struct srcu_ctr __percpu *rcu_read_lock_tasks_trace(void) > > > +{ > > > + str

Re: [PATCH v2 02/21] rcu: Re-implement RCU Tasks Trace in terms of SRCU-fast

2025-10-02 Thread Frederic Weisbecker
Le Wed, Oct 01, 2025 at 07:48:13AM -0700, Paul E. McKenney a écrit : > This commit saves more than 500 lines of RCU code by re-implementing > RCU Tasks Trace in terms of SRCU-fast. Follow-up work will remove > more code that does not cause problems by its presence, but that is no > longer required

[PATCH net v6 0/4] net: netpoll: fix memory leak and add comprehensive selftests

2025-10-02 Thread Breno Leitao
Fix a memory leak in netpoll and introduce netconsole selftests that expose the issue when running with kmemleak detection enabled. This patchset includes a selftest for netpoll with multiple concurrent users (netconsole + bonding), which simulates the scenario from test[1] that originally demonst

[RFC PATCH] remoteproc: core: full attach detach during recovery

2025-10-02 Thread Tanmay Shah
Current recovery operation does only virtio device reset, but do not free and re-allocate all the resources. As third-party is booting the remote processor during attach-detach, it is better to free and re-allocate resoruces as resource table state might be unknown to linux when remote processor bo

[PATCH net v6 3/4] selftest: netcons: create a torture test

2025-10-02 Thread Breno Leitao
Create a netconsole test that puts a lot of pressure on the netconsole list manipulation. Do it by creating dynamic targets and deleting targets while messages are being sent. Also put interface down while the messages are being sent, as creating parallel targets. The code launches three backgroun

[PATCH net v6 2/4] selftest: netcons: refactor target creation

2025-10-02 Thread Breno Leitao
Extract the netconsole target creation from create_dynamic_target(), by moving it from create_dynamic_target() into a new helper function. This enables other tests to use the creation of netconsole targets with arbitrary parameters and no sleep. The new helper will be utilized by forthcoming tortu

[GIT PULL] rpmsg updates for v6.18

2025-10-02 Thread Bjorn Andersson
The following changes since commit c17b750b3ad9f45f2b6f7e6f7f4679844244f0b9: Linux 6.17-rc2 (2025-08-17 15:22:10 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux.git tags/rpmsg-v6.18 for you to fetch changes up to 09390ed9af3

[PATCH 1/1] dax: add PROBE_PREFER_ASYNCHRONOUS to the pmem driver

2025-10-02 Thread Michal Clapinski
Comments in linux/device/driver.h say that the goal is to do async probing on all devices. The current behavior unnecessarily slows down the boot by synchronous probing dax_pmem devices, so let's change that. Signed-off-by: Michal Clapinski --- drivers/dax/pmem.c | 1 + 1 file changed, 1 inserti

[GIT PULL] remoteproc updates for v6.18

2025-10-02 Thread Bjorn Andersson
The following changes since commit c17b750b3ad9f45f2b6f7e6f7f4679844244f0b9: Linux 6.17-rc2 (2025-08-17 15:22:10 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux.git tags/rproc-v6.18 for you to fetch changes up to d41e075b077

Re: [PATCH v2 08/21] rcu: Add noinstr-fast rcu_read_{,un}lock_tasks_trace() APIs

2025-10-02 Thread Paul E. McKenney
On Wed, Oct 01, 2025 at 06:37:33PM -0700, Alexei Starovoitov wrote: > On Wed, Oct 1, 2025 at 7:48 AM Paul E. McKenney wrote: > > > > +static inline struct srcu_ctr __percpu *rcu_read_lock_tasks_trace(void) > > +{ > > + struct srcu_ctr __percpu *ret = > > __srcu_read_lock_fast(&rcu_tasks_tra

[RFC 1/2] vduse: support feature provisioning

2025-10-02 Thread Eugenio Pérez
This patch implements features provisioning for vduse devices. This allows the device provisioner to clear the features exposed by the userland device, so the driver never see them. The intended use case is to provision more than one different device with the same feature set, allowing live migra

[RFC 2/2] vduse: allow to specify device-specific features if it's multiclass

2025-10-02 Thread Eugenio Pérez
Even if the device supports more than one class, there are ways to solve the ambiguity of which device are we creating. In the VDUSE case it is the name, for example. RFC: I fon't understand 100% the motivation of this limitation, as the backend should be the one filtering out the invalid feature

[RFC 0/2] support vduse feature provisioning in vdpa netlink command

2025-10-02 Thread Eugenio Pérez
This series implements features provisioning for vduse devices. This allows the device provisioner to clear the features exposed by the userland device, so the driver never see them. The intended use case is to provision more than one different device with the same feature set, allowing live migr

[PATCH 0/6] Further bringup of SHIFTphone 8

2025-10-02 Thread Luca Weiss
Add some cleanups and fixes to shift-otter, and enable flash LED, RGB LED and Venus. Signed-off-by: Luca Weiss --- Alexander Martinz (4): arm64: dts: qcom: qcm6490-shift-otter: Fix sorting and indentation arm64: dts: qcom: qcm6490-shift-otter: Remove thermal zone polling delays

Re: [PATCH v3 07/11] arm64: dts: qcom: sdm845-lg-{common, judyln}: Add wifi node

2025-10-02 Thread Konrad Dybcio
On 10/2/25 6:51 AM, Paul Sajna wrote: > October 1, 2025 at 9:14 AM, "Konrad Dybcio" mailto:konrad.dyb...@oss.qualcomm.com?to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > > wrote > > >> >> As the dt-checker points out, there is no such property >> >> If your wi-fi works regar

Re: [PATCH v 2/2] selftests: riscv: Add test for the Vector ptrace interface

2025-10-02 Thread Charlie Jenkins
On Thu, Oct 02, 2025 at 12:53:13AM -0500, Andy Chiu wrote: > Hi Yong-Xuan, > > I found some issues which deserve a re-roll: > > On Wed, Oct 1, 2025 at 6:15 AM Yong-Xuan Wang > wrote: > > > > Add a test case that does some basic verification of the Vector ptrace > > interface. This forks a child

Re: [PATCH RESENT v4 4/6] vdpa: validate device feature provisioning against supported class

2025-10-02 Thread Eugenio Perez Martin
On Thu, Oct 2, 2025 at 1:27 AM Si-Wei Liu wrote: > > Hi Eugenio, > > On 10/1/2025 6:26 AM, Eugenio Perez Martin wrote: > > On Tue, Feb 7, 2023 at 12:15 AM Si-Wei Liu wrote: > >> Today when device features are explicitly provisioned, the features > >> user supplied may contain device class specifi