On Tue, Sep 30, 2025 at 10:12:27AM +0800, Jingyi Wang wrote:
>
>
> On 9/29/2025 8:22 PM, Dmitry Baryshkov wrote:
> > On Mon, Sep 29, 2025 at 06:11:23PM +0800, Jingyi Wang wrote:
> >>
> >>
> >> On 9/29/2025 5:39 PM, Dmitry Baryshkov wrote:
> >>> On Mon, Sep 29, 2025 at 02:06:11PM +0800, Jingyi Wang wrote:
> >>>>
> >>>>
> >>>> On 9/25/2025 10:19 AM, Dmitry Baryshkov wrote:
> >>>>> On Wed, Sep 24, 2025 at 04:37:22PM -0700, Jingyi Wang wrote:
> >>>>>> Document compatible for Qualcomm Kaanapali SoC ADSP PAS which looks
> >>>>>> fully
> >>>>>> compatible with SM8750, which can fallback to SM8550 except for one
> >>>>>> more
> >>>>>> interrupt ("shutdown-ack").
> >>>>>>
> >>>>>> Signed-off-by: Jingyi Wang <jingyi.w...@oss.qualcomm.com>
> >>>>>> ---
> >>>>>> Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml | 6
> >>>>>> +++++-
> >>>>>> 1 file changed, 5 insertions(+), 1 deletion(-)
> >>>>>>
> >>>>>> diff --git
> >>>>>> a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> >>>>>> b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> >>>>>> index 2dd479cf4821..be9e2a0bc060 100644
> >>>>>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> >>>>>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> >>>>>> @@ -28,7 +28,9 @@ properties:
> >>>>>> - qcom,x1e80100-adsp-pas
> >>>>>> - qcom,x1e80100-cdsp-pas
> >>>>>> - items:
> >>>>>> - - const: qcom,sm8750-adsp-pas
> >>>>>> + - enum:
> >>>>>> + - qcom,kaanapali-adsp-pas
> >>>>>> + - qcom,sm8750-adsp-pas
> >>>>>> - const: qcom,sm8550-adsp-pas
> >>>>>> - items:
> >>>>>> - const: qcom,sm8750-cdsp-pas
> >>>>>> @@ -95,6 +97,7 @@ allOf:
> >>>>>> compatible:
> >>>>>> contains:
> >>>>>> enum:
> >>>>>> + - qcom,kaanapali-adsp-pas
> >>>>>
> >>>>> This one and the next entry are redundant. Do you see why?
> >>>>>
> >>>>
> >>>> This one describe the interrupt:
> >>>>
> >>>> - if:
> >>>> properties:
> >>>> compatible:
> >>>> contains:
> >>>
> >>>> enum:
> >>>> - qcom,kaanapali-adsp-pas
> >>>> - qcom,sm8750-adsp-pas
> >>>
> >>> It's still redundant. Don't you see it?
> >>>
> >>
> >> sorry I didn't get your point here, could you explain more?
> >
> > For you device you have two compat strings, kaanapali and sm8750. This
> > schema block is covered by 'if compat contains sm8750', so you don't
> > need to add kaanapali to the if-case. You already hit this check thanks
> > to the fallback compat.
> >
>
> Hi Dimitry,
>
> our device contains sm8550, not sm8750.
I should be reading the patches more carefully. I beg your pardon,
indeed, you were right.
--
With best wishes
Dmitry
