RE: [PATCH] virtio: document ENOSPC

2025-05-28 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Tuesday, May 27, 2025 7:57 PM > To: linux-kernel@vger.kernel.org > Cc: Parav Pandit ; Jason Wang ; > Xuan Zhuo ; Eugenio Pérez > ; virtualizat...@lists.linux.dev > Subject: [PATCH] virtio: document ENOSPC > > drivers handle ENOSPC specially since it's an erro

Re: [PATCH bpf-next 1/2] bpf: Add bpf_task_cwd_from_pid() kfunc

2025-05-28 Thread Alexei Starovoitov
On Wed, May 28, 2025 at 8:37 PM Rong Tao wrote: > > From: Rong Tao > > It is a bit troublesome to get cwd based on pid in bpf program, such as > bpftrace example [1]. > > This patch therefore adds a new bpf_task_cwd_from_pid() kfunc which > allows BPF programs to get cwd from a pid. > > [1] https

Re: [PATCH] virtio-mmio: Remove virtqueue list from mmio device

2025-05-28 Thread Jason Wang
On Wed, May 21, 2025 at 7:34 PM Viresh Kumar wrote: > > The MMIO transport implementation creates a list of virtqueues for a > virtio device, while the same is already available in the struct > virtio_device. > > Don't create a duplicate list, and use the other one instead. > > While at it, fix th

Re: [PATCH 1/3] virtio: Fix typo in register_virtio_device() doc comment

2025-05-28 Thread Jason Wang
On Wed, May 28, 2025 at 2:34 AM Alok Tiwari wrote: > > Corrected "suceess" to "success" in the function documentation > for clarity. > > Signed-off-by: Alok Tiwari > --- > drivers/virtio/virtio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio.c b/d

Re: [PATCH] virtio: document ENOSPC

2025-05-28 Thread Jason Wang
On Tue, May 27, 2025 at 10:27 PM Michael S. Tsirkin wrote: > > drivers handle ENOSPC specially since it's an error one can > get from a working VQ. Document the semantics. > > Reported-by: Parav Pandit > Signed-off-by: Michael S. Tsirkin > --- > drivers/virtio/virtio_ring.c | 4 > 1 file c

Re: [RFC PATCH net-next v2 1/2] virtio-net: support zerocopy multi buffer XDP in mergeable

2025-05-28 Thread Jason Wang
On Wed, May 28, 2025 at 12:19 AM Bui Quang Minh wrote: > > Currently, in zerocopy mode with mergeable receive buffer, virtio-net > does not support multi buffer but a single buffer only. This commit adds > support for multi mergeable receive buffer in the zerocopy XDP path by > utilizing XDP buffe

[PATCH bpf-next 2/2] selftests/bpf: Add selftests for bpf_task_cwd_from_pid()

2025-05-28 Thread Rong Tao
From: Rong Tao Add some selftest testcases that validate the expected behavior of the bpf_task_cwd_from_pid() kfunc that was added in the prior patch. Signed-off-by: Rong Tao --- .../selftests/bpf/prog_tests/task_kfunc.c | 3 ++ .../selftests/bpf/progs/task_kfunc_common.h | 1 + .../se

RE: [PATCH v2 3/3] remoteproc: imx_rproc: add power mode check for remote core attachment

2025-05-28 Thread Peng Fan
> Subject: Re: [PATCH v2 3/3] remoteproc: imx_rproc: add power mode > check for remote core attachment > > On Tue, May 27, 2025 at 10:45:25AM -0300, Hiago De Franco wrote: > > [...] > > > > > > > Thanks for the detailed analysis! > > > > > > This is a very similar issue as many other genpd provi

Re: [RFC PATCH net-next v2 2/2] selftests: net: add XDP socket tests for virtio-net

2025-05-28 Thread Bui Quang Minh
On 5/29/25 00:04, ALOK TIWARI wrote: On 27-05-2025 21:49, Bui Quang Minh wrote: +def main(): +    with NetDrvEpEnv(__file__, nsim_test=False) as cfg: +    cfg.bin_local = path.abspath(path.dirname(__file__) +    + "/../../../drivers/net/hw/xsk_receive") +    cfg

Re: [RFC PATCH net-next v2 1/2] virtio-net: support zerocopy multi buffer XDP in mergeable

2025-05-28 Thread Bui Quang Minh
On 5/28/25 23:44, ALOK TIWARI wrote: On 27-05-2025 21:49, Bui Quang Minh wrote: Currently, in zerocopy mode with mergeable receive buffer, virtio-net does not support multi buffer but a single buffer only. This commit adds support for multi mergeable receive buffer in the zerocopy XDP path by

[PATCH bpf-next 1/2] bpf: Add bpf_task_cwd_from_pid() kfunc

2025-05-28 Thread Rong Tao
From: Rong Tao It is a bit troublesome to get cwd based on pid in bpf program, such as bpftrace example [1]. This patch therefore adds a new bpf_task_cwd_from_pid() kfunc which allows BPF programs to get cwd from a pid. [1] https://github.com/bpftrace/bpftrace/issues/3314 Signed-off-by: Rong T

[PATCH bpf-next 0/2] Add kfunc for doing pid -> task cwd

2025-05-28 Thread Rong Tao
In some application like bpftrace [1], need to get the cwd from the pid. This patch provides a new kfunc that can get the cwd of the process from the pid. [1] https://github.com/bpftrace/bpftrace/issues/3314 Rong Tao (2): bpf: Add bpf_task_cwd_from_pid() kfunc selftests/bpf: Add selftests for

Re: [PATCH V2 00/19] virtio_ring in order support

2025-05-28 Thread Jason Wang
On Wed, May 28, 2025 at 8:51 PM Michael S. Tsirkin wrote: > > On Wed, May 28, 2025 at 02:42:15PM +0800, Jason Wang wrote: > > Hello all: > > > > This sereis tries to implement the VIRTIO_F_IN_ORDER to > > virtio_ring. This is done by introducing virtqueue ops so we can > > implement separate helpe

Re: [PATCH net-next] selftest: Add selftest for multicast address notifications

2025-05-28 Thread Yuyang Huang
Hi Simon >Other tests in this file seem to warn if the ip command is too old >to support the test. Perhaps we can achieve that here something like this >(completely untested!): Thanks for the advice. I will modify the test to make sure it skips on old iproute2 versions. I will send the patch afte

Re: [PATCH v4 1/2] livepatch, x86/module: Generalize late module relocation locking.

2025-05-28 Thread Dylan Hatch
Hi Petr, On Tue, May 27, 2025 at 7:46 AM Petr Mladek wrote: > > As this patch suggests, the "text_mutex" has been used to > sychronize apply_relocate_add() only on x86_64 so far. > > s390x seems to rely on "s390_kernel_write_lock" taken by: > > + apply_relocate_add() > + s390_kernel_write()

[PATCH] selftests: Add version file to kselftest installation dir

2025-05-28 Thread Tianyi Cui
As titled, adding version file to kselftest installation dir, so the user of the tarball can know which kernel version the tarball belongs to. Signed-off-by: Tianyi Cui <1997...@gmail.com> --- tools/testing/selftests/Makefile | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/testing

Re: [PATCH RFC v2 1/9] KVM: arm64: nv: selftests: Add support to run guest code in vEL2.

2025-05-28 Thread Itaru Kitayama
Hi Ganapatrao On Mon, May 12, 2025 at 03:52:43AM -0700, Ganapatrao Kulkarni wrote: > This patch adds required changes to vcpu init to run a guest code > in vEL2 context and also adds NV specific helper functions. > > Signed-off-by: Ganapatrao Kulkarni I'm interested in testing this, but is this

Re: [PATCH bpf-next v1 1/2] bpf,ktls: Fix data corruption when using bpf_msg_pop_data() in ktls

2025-05-28 Thread John Fastabend
On 2025-05-23 21:18:58, Jiayuan Chen wrote: > When sending plaintext data, we initially calculated the corresponding > ciphertext length. However, if we later reduced the plaintext data length > via socket policy, we failed to recalculate the ciphertext length. > > This results in transmitting buf

Re: [PATCH bpf-next v1 2/2] selftests/bpf: Add test to cover ktls with bpf_msg_pop_data

2025-05-28 Thread John Fastabend
On 2025-05-23 21:18:59, Jiayuan Chen wrote: > The selftest can reproduce an issue where using bpf_msg_pop_data() in > ktls causes errors on the receiving end. > > Signed-off-by: Jiayuan Chen > --- Yep LGTM thanks. Reviewed-by: John Fastabend

Re: [PATCH net-next] vsock/test: Cover more CIDs in transport_uaf test

2025-05-28 Thread Michal Luczaj
the reopening. > Thanks for asking! All right then, I gave RFC a try: https://lore.kernel.org/netdev/20250528-vsock-test-inc-cov-v2-0-8f655b40d...@rbox.co/ >>>>>>>> +static void test_stream_transport_uaf_client(const struct test_opts >>>>

[PATCH RFC net-next v2 0/3] vsock/test: Improve transport_uaf test

2025-05-28 Thread Michal Luczaj
Increase the coverage of a test implemented in commit 301a62dfb0d0 ("vsock/test: Add test for UAF due to socket unbinding"). Take this opportunity to factor out some utility code, drop a redundant sync between client and server, and introduce a /proc/kallsyms harvesting logic. Signed-off-by: Micha

[PATCH RFC net-next v2 3/3] vsock/test: Cover more CIDs in transport_uaf test

2025-05-28 Thread Michal Luczaj
Increase the coverage of test for UAF due to socket unbinding, and losing transport in general. It's a follow up to commit 301a62dfb0d0 ("vsock/test: Add test for UAF due to socket unbinding") and discussion in [1]. The idea remains the same: take an unconnected stream socket with a transport assi

[PATCH RFC net-next v2 2/3] vsock/test: Introduce get_transports()

2025-05-28 Thread Michal Luczaj
Return a bitmap of registered vsock transports. As guesstimated by grepping /proc/kallsyms (CONFIG_KALLSYMS=y) for known symbols of type `struct virtio_transport`. Suggested-by: Stefano Garzarella Signed-off-by: Michal Luczaj --- tools/testing/vsock/util.c | 60 +

[PATCH RFC net-next v2 1/3] vsock/test: Introduce vsock_bind_try() helper

2025-05-28 Thread Michal Luczaj
Create a socket and bind() it. If binding failed, gracefully return an error code while preserving `errno`. Base vsock_bind() on top of it. Suggested-by: Stefano Garzarella Signed-off-by: Michal Luczaj --- tools/testing/vsock/util.c | 24 +--- tools/testing/vsock/util.h |

[PATCH v1] selftests/mm: two fixes for the pfnmap test

2025-05-28 Thread David Hildenbrand
When unregistering the signal handler, we have to pass SIG_DFL, and blindly reading from PFN 0 and PFN 1 seems to be problematic on !x86 systems. In particularly, on arm64 tx2 machines where noting resides at these physical memory locations, we can generate RAS errors. Let's fix it by scanning /pr

Re: [PATCH v2] selftests/mm: add simple VM_PFNMAP tests based on mmap'ing /dev/mem

2025-05-28 Thread David Hildenbrand
On 28.05.25 20:23, Aishwarya wrote: Hi David, I applied the patch on next-20250515 and ran the test. The issue is no longer observed, and the test completed successfully. I can confirm that the patch resolves the problem. Tested-by: Aishwarya TCV Thanks a bunch for the fast re-test! -- Chee

Re: [PATCH RFC net-next v2] page_pool: import Jesper's page_pool benchmark

2025-05-28 Thread Mina Almasry
On Wed, May 28, 2025 at 2:28 AM Toke Høiland-Jørgensen wrote: > > Mina Almasry writes: > > > On Mon, May 26, 2025 at 5:51 AM Toke Høiland-Jørgensen > > wrote: > >> > Fast path results: > >> > no-softirq-page_pool01 Per elem: 11 cycles(tsc) 4.368 ns > >> > > >> > ptr_ring results: > >> > no-soft

Re: [PATCH v2] selftests/mm: add simple VM_PFNMAP tests based on mmap'ing /dev/mem

2025-05-28 Thread Aishwarya
Hi David, I applied the patch on next-20250515 and ran the test. The issue is no longer observed, and the test completed successfully. I can confirm that the patch resolves the problem. Tested-by: Aishwarya TCV Thanks, Aishwarya

Re: [RESEND PATCH v2] dt-bindings: pmem: Convert binding to YAML

2025-05-28 Thread Drew Fustini
On Wed, May 28, 2025 at 02:43:27PM +0100, Conor Dooley wrote: > On Tue, May 27, 2025 at 11:17:04PM -0700, Drew Fustini wrote: > > Convert the PMEM device tree binding from text to YAML. This will allow > > device trees with pmem-region nodes to pass dtbs_check. > > > > Signed-off-by: Drew Fustini

[PATCH v3] rust: kunit: use crate-level mapping for `c_void`

2025-05-28 Thread Jesung Yang
Remove `use core::ffi::c_void`, which shadows `kernel::ffi::c_void` brought in via `use crate::prelude::*`, to maintain consistency and centralize the abstraction. Since `kernel::ffi::c_void` is a straightforward re-export of `core::ffi::c_void`, both are functionally equivalent. However, using `k

Re: [PATCH v2 3/3] remoteproc: imx_rproc: add power mode check for remote core attachment

2025-05-28 Thread Hiago De Franco
On Tue, May 27, 2025 at 10:45:25AM -0300, Hiago De Franco wrote: [...] > > > > Thanks for the detailed analysis! > > > > This is a very similar issue as many other genpd providers are > > suffering from - and something that I have been working on recently to > > fix. > > > > A few days ago I p

Re: [PATCH RFC net-next v2] page_pool: import Jesper's page_pool benchmark

2025-05-28 Thread Toke Høiland-Jørgensen
Arnaldo Carvalho de Melo writes: > On Wed, May 28, 2025 at 11:28:54AM +0200, Toke Høiland-Jørgensen wrote: >> Mina Almasry writes: >> > On Mon, May 26, 2025 at 5:51 AM Toke Høiland-Jørgensen >> > wrote: >> >> Back when you posted the first RFC, Jesper and I chatted about ways to >> >> avoid th

Re: [RFC PATCH net-next v2 2/2] selftests: net: add XDP socket tests for virtio-net

2025-05-28 Thread ALOK TIWARI
On 27-05-2025 21:49, Bui Quang Minh wrote: +def main(): +with NetDrvEpEnv(__file__, nsim_test=False) as cfg: +cfg.bin_local = path.abspath(path.dirname(__file__) ++ "/../../../drivers/net/hw/xsk_receive") +cfg.bin_remote = cfg.remote.deploy(cfg.b

Re: [RFC PATCH net-next v2 1/2] virtio-net: support zerocopy multi buffer XDP in mergeable

2025-05-28 Thread ALOK TIWARI
On 27-05-2025 21:49, Bui Quang Minh wrote: Currently, in zerocopy mode with mergeable receive buffer, virtio-net does not support multi buffer but a single buffer only. This commit adds support for multi mergeable receive buffer in the zerocopy XDP path by utilizing XDP buffer with frags. Sig

Re: [PATCH v2] rust: kunit: use crate-level mapping for `c_void`

2025-05-28 Thread JS Y
On Thu, May 29, 2025 at 1:31 AM Miguel Ojeda wrote: > > I see this is based on rust-next -- if you rebase the patch on top of > the latest one, you will see the prelude there :) Thanks for the heads up! I'll rebase and send out v3 accordingly. Best regards, Jesung

Re: [PATCH v2] selftests/seccomp: Improve error logging in get_proc_stat()

2025-05-28 Thread Kees Cook
On Wed, May 28, 2025 at 06:38:39AM +0530, Sameeksha Sankpal wrote: > Use TH_LOG to report failure when reading /proc//stat in > get_proc_stat(), following kernel test framework conventions. > > Previously, printf() was used which is discouraged. printf wasn't used previous, that was in your v1. :

Re: [PATCH v2] rust: kunit: use crate-level mapping for `c_void`

2025-05-28 Thread Miguel Ojeda
On Wed, May 28, 2025 at 5:55 PM Jesung Yang wrote: > > So in sum, I believe it's reasonable to keep the diff unchanged... but > I'm happy to adjust if you'd prefer a different approach. I see this is based on rust-next -- if you rebase the patch on top of the latest one, you will see the prelude

Re: [QUESTION] problems report: rcu_read_unlock_special() called in irq_exit() causes dead loop

2025-05-28 Thread Joel Fernandes
On Wed, May 21, 2025 at 5:43 AM Xiongfeng Wang wrote: > > Hi RCU experts, > > When I ran syskaller in Linux 6.6 with CONFIG_PREEMPT_RCU enabled, I got > the following soft lockup. The Calltrace is too long. I put it in the end. > The issue can also be reproduced in the latest kernel. > > The issue

Re: [PATCH v3] media: add virtio-media driver

2025-05-28 Thread Ricardo Ribalda
Hi Alexandre On Sat, 12 Apr 2025 at 06:08, Alexandre Courbot wrote: > > Add the first version of the virtio-media driver. > > This driver acts roughly as a V4L2 relay between user-space and the > virtio virtual device on the host, so it is relatively simple, yet > unconventional. It doesn't use V

Re: [PATCH] rust: replace length checks with match

2025-05-28 Thread Tamir Duberstein
mir-Duberstein/rust-replace-length-checks-with-match/20250528-001121 > base: bfc3cd87559bc593bb32bb1482f9cae3308b6398 > patch link: > https://lore.kernel.org/r/20250527-idiomatic-match-slice-v1-1-34b0b1d1d58c%40gmail.com > patch subject: [PATCH] rust: replace length checks with match &

[PATCH bpf-next v1 2/2] bpf/selftests: Add test cases for retrieving classid

2025-05-28 Thread Jiayuan Chen
Covers all scenarios where classid can be retrieved with bpf. ./test_progs -a cgroup_get_classid 53/1cgroup_get_classid/get classid from tc:OK 53/2cgroup_get_classid/get classid from sysctl:OK 53/3cgroup_get_classid/get classid from cgroup dev:OK 53/4cgroup_get_classid/get classid

[PATCH bpf-next v1 1/2] bpf: Restrict usage scope of bpf_get_cgroup_classid

2025-05-28 Thread Jiayuan Chen
A previous commit expanded the usage scope of bpf_get_cgroup_classid() to all contexts (see Fixes tag), but this was inappropriate. First, syzkaller reported a bug [1]. Second, it uses skb as an argument, but its implementation varies across different bpf prog types. For example, in sock_filter an

Re: [PATCH] rust: replace length checks with match

2025-05-28 Thread kernel test robot
Hi Tamir, kernel test robot noticed the following build errors: [auto build test ERROR on bfc3cd87559bc593bb32bb1482f9cae3308b6398] url: https://github.com/intel-lab-lkp/linux/commits/Tamir-Duberstein/rust-replace-length-checks-with-match/20250528-001121 base

[PATCH v2] rust: kunit: use crate-level mapping for `c_void`

2025-05-28 Thread Jesung Yang
Use `kernel::ffi::c_void` instead of `core::ffi::c_void` for consistency and to centralize abstraction. Since `kernel::ffi::c_void` is a straightforward re-export of `core::ffi::c_void`, both are functionally equivalent. However, using `kernel::ffi::c_void` improves consistency across the kernel's

Re: [PATCH net-next] selftest: Add selftest for multicast address notifications

2025-05-28 Thread Simon Horman
On Tue, May 27, 2025 at 06:18:55PM +0900, Yuyang Huang wrote: > This commit adds a new kernel selftest to verify RTNLGRP_IPV4_MCADDR > and RTNLGRP_IPV6_MCADDR notifications. The test works by adding and > removing a dummy interface and then confirming that the system > correctly receives join and r

Re: [PATCH v2 49/62] kbuild,objtool: Defer objtool validation step for CONFIG_LIVEPATCH

2025-05-28 Thread Joe Lawrence
On 5/9/25 4:17 PM, Josh Poimboeuf wrote: > In preparation for the objtool klp diff subcommand, defer objtool > validation for CONFIG_LIVEPATCH until the final pre-link archive (e.g., > vmlinux.o, module-foo.o) is built. This will simplify the process of > generating livepatch modules. > > Delayed

Re: [PATCH v2 45/62] x86/extable: Define ELF section entry size for exception tables

2025-05-28 Thread Joe Lawrence
On 5/9/25 4:17 PM, Josh Poimboeuf wrote: > In preparation for the objtool klp diff subcommand, define the entry > size for the __ex_table section in its ELF header. This will allow > tooling to extract individual entries. > > Signed-off-by: Josh Poimboeuf > --- > arch/x86/include/asm/asm.h | 20

Re: [RFC PATCH v2 3/9] KVM: arm64: nv: selftests: Enable hypervisor timer tests to run in vEL2

2025-05-28 Thread Eric Auger
Hi Ganapatrao, On 5/12/25 12:52 PM, Ganapatrao Kulkarni wrote: > Adding required changes to enable and test HVTIMER and HPTIMER > in vEL2. In default case, PTIMER and VTIMER are validated and with > NV enabled (with argument "-g 1"), HPTIMER and HVTIMER are validated > by injecting respective time

Re: [PATCH RFC net-next v2] page_pool: import Jesper's page_pool benchmark

2025-05-28 Thread Arnaldo Carvalho de Melo
On Wed, May 28, 2025 at 11:28:54AM +0200, Toke Høiland-Jørgensen wrote: > Mina Almasry writes: > > On Mon, May 26, 2025 at 5:51 AM Toke Høiland-Jørgensen > > wrote: > >> Back when you posted the first RFC, Jesper and I chatted about ways to > >> avoid the ugly "load module and read the output fr

Re: [PATCH v2] selftests/mm: add simple VM_PFNMAP tests based on mmap'ing /dev/mem

2025-05-28 Thread Ryan Roberts
On 28/05/2025 13:40, David Hildenbrand wrote: > On 28.05.25 12:53, Ryan Roberts wrote: >> On 28/05/2025 11:48, David Hildenbrand wrote: >>> On 28.05.25 12:44, David Hildenbrand wrote: On 28.05.25 12:34, Ryan Roberts wrote: > Hi David, > > > On 09/05/2025 16:30, David Hildenbran

Re: [RESEND PATCH v2] dt-bindings: pmem: Convert binding to YAML

2025-05-28 Thread Conor Dooley
On Tue, May 27, 2025 at 11:17:04PM -0700, Drew Fustini wrote: > Convert the PMEM device tree binding from text to YAML. This will allow > device trees with pmem-region nodes to pass dtbs_check. > > Signed-off-by: Drew Fustini > --- > v2 resend: > - actually put v2 in the Subject > - add Conor's

Re: [RFC PATCH v2 1/9] KVM: arm64: nv: selftests: Add support to run guest code in vEL2.

2025-05-28 Thread Eric Auger
Hi, On 5/12/25 12:52 PM, Ganapatrao Kulkarni wrote: > This patch adds required changes to vcpu init to run a guest code > in vEL2 context and also adds NV specific helper functions. > > Signed-off-by: Ganapatrao Kulkarni > --- > tools/testing/selftests/kvm/Makefile.kvm | 2 + > .../kvm/in

Re: [RFC PATCH v2 0/9] KVM: Enable Nested Virt selftests

2025-05-28 Thread Eric Auger
Hi Ganapatrao, On 5/12/25 12:52 PM, Ganapatrao Kulkarni wrote: > This patch series makes the selftest work with NV enabled. The guest code > is run in vEL2 instead of EL1. We add a command line option to enable > testing of NV. The NV tests are disabled by default. For commodity, I would add in t

Re: [PATCH] virtio: document ENOSPC

2025-05-28 Thread Stefan Hajnoczi
On Tue, May 27, 2025 at 10:28 AM Michael S. Tsirkin wrote: > > drivers handle ENOSPC specially since it's an error one can > get from a working VQ. Document the semantics. > > Reported-by: Parav Pandit > Signed-off-by: Michael S. Tsirkin > --- > drivers/virtio/virtio_ring.c | 4 > 1 file c

Re: [PATCH V2 00/19] virtio_ring in order support

2025-05-28 Thread Michael S. Tsirkin
On Wed, May 28, 2025 at 02:42:15PM +0800, Jason Wang wrote: > Hello all: > > This sereis tries to implement the VIRTIO_F_IN_ORDER to > virtio_ring. This is done by introducing virtqueue ops so we can > implement separate helpers for different virtqueue layout/features > then the in-order were impl

Re: [PATCH v2] selftests/mm: add simple VM_PFNMAP tests based on mmap'ing /dev/mem

2025-05-28 Thread David Hildenbrand
On 28.05.25 12:53, Ryan Roberts wrote: On 28/05/2025 11:48, David Hildenbrand wrote: On 28.05.25 12:44, David Hildenbrand wrote: On 28.05.25 12:34, Ryan Roberts wrote: Hi David, On 09/05/2025 16:30, David Hildenbrand wrote: Let's test some basic functionality using /dev/mem. These tests wil

Re: [PATCH next] tools/testing: Check correct variable in open_procmap()

2025-05-28 Thread Lorenzo Stoakes
Thanks so much for catching this Dan! On Wed, May 28, 2025 at 11:13:45AM +0300, Dan Carpenter wrote: > Check if "procmap_out->fd" is negative instead of "procmap_out" (which > is a pointer). Ye gods, so sorry for such a clanger! Entirely my fault, though I may mutter a grumble about C type safety

Re: [PATCH v2] selftests/mm: add simple VM_PFNMAP tests based on mmap'ing /dev/mem

2025-05-28 Thread Ryan Roberts
On 28/05/2025 11:48, David Hildenbrand wrote: > On 28.05.25 12:44, David Hildenbrand wrote: >> On 28.05.25 12:34, Ryan Roberts wrote: >>> Hi David, >>> >>> >>> On 09/05/2025 16:30, David Hildenbrand wrote: Let's test some basic functionality using /dev/mem. These tests will implicitly cov

Re: [PATCH v2] selftests/mm: add simple VM_PFNMAP tests based on mmap'ing /dev/mem

2025-05-28 Thread David Hildenbrand
On 28.05.25 12:44, David Hildenbrand wrote: On 28.05.25 12:34, Ryan Roberts wrote: Hi David, On 09/05/2025 16:30, David Hildenbrand wrote: Let's test some basic functionality using /dev/mem. These tests will implicitly cover some PAT (Page Attribute Handling) handling on x86. These tests wil

Re: [PATCH v2] selftests/mm: add simple VM_PFNMAP tests based on mmap'ing /dev/mem

2025-05-28 Thread David Hildenbrand
On 28.05.25 12:53, Ryan Roberts wrote: On 28/05/2025 11:48, David Hildenbrand wrote: On 28.05.25 12:44, David Hildenbrand wrote: On 28.05.25 12:34, Ryan Roberts wrote: Hi David, On 09/05/2025 16:30, David Hildenbrand wrote: Let's test some basic functionality using /dev/mem. These tests wil

Re: [PATCH v3] media: add virtio-media driver

2025-05-28 Thread Alexandre Courbot
Hi Michael, On Wed, May 28, 2025 at 12:06 AM Michael S. Tsirkin wrote: > > On Tue, May 27, 2025 at 04:39:27PM +0200, Mauro Carvalho Chehab wrote: > > > It's up to you though. > > > I can keep it in next for now, so it gets some coverage by > > > tools scanning that tree. > > > > Sure, feel free t

Re: [PATCH v2] selftests/mm: add simple VM_PFNMAP tests based on mmap'ing /dev/mem

2025-05-28 Thread David Hildenbrand
On 28.05.25 12:34, Ryan Roberts wrote: Hi David, On 09/05/2025 16:30, David Hildenbrand wrote: Let's test some basic functionality using /dev/mem. These tests will implicitly cover some PAT (Page Attribute Handling) handling on x86. These tests will only run when /dev/mem access to the first

[PATCH V2 11/19] virtio_ring: switch to use vring_virtqueue for detach_unused_buf variants

2025-05-28 Thread Jason Wang
Those variants are used internally so let's switch to use vring_virtqueue as parameter to be consistent with other internal virtqueue helpers. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) di

Re: [PATCH v2] selftests/mm: add simple VM_PFNMAP tests based on mmap'ing /dev/mem

2025-05-28 Thread Ryan Roberts
Hi David, On 09/05/2025 16:30, David Hildenbrand wrote: > Let's test some basic functionality using /dev/mem. These tests will > implicitly cover some PAT (Page Attribute Handling) handling on x86. > > These tests will only run when /dev/mem access to the first two pages > in physical address sp

Re: [PATCH v2 32/62] objtool: Suppress section skipping warnings with --dryrun

2025-05-28 Thread Peter Zijlstra
On Mon, May 26, 2025 at 12:52:40PM +0200, Peter Zijlstra wrote: > On Fri, May 09, 2025 at 01:16:56PM -0700, Josh Poimboeuf wrote: > > It's common to use --dryrun on binaries that have already been > > processed. Don't print the section skipping warnings in that case. > > Ah, I rather like this wa

[PATCH V2 10/19] virtio_ring: switch to use vring_virtqueue for disable_cb variants

2025-05-28 Thread Jason Wang
Those variants are used internally so let's switch to use vring_virtqueue as parameter to be consistent with other internal virtqueue helpers. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-)

Re: [PATCH] rust: replace length checks with match

2025-05-28 Thread Alice Ryhl
On Tue, May 27, 2025 at 12:09:36PM -0400, Tamir Duberstein wrote: > Use a match expression with slice patterns instead of length checks and > indexing. The result is more idiomatic, which is a better example for > future Rust code authors. > > Signed-off-by: Tamir Duberstein Reviewed-by: Alice R

Re: [PATCH net-next] vsock/test: Cover more CIDs in transport_uaf test

2025-05-28 Thread Michal Luczaj
On 5/27/25 10:41, Stefano Garzarella wrote: > On Mon, May 26, 2025 at 10:44:05PM +0200, Michal Luczaj wrote: >> On 5/26/25 16:39, Stefano Garzarella wrote: >>> On Mon, May 26, 2025 at 02:51:18PM +0200, Michal Luczaj wrote: On 5/26/25 10:25, Stefano Garzarella wrote: > On Fri, May 23, 2025

Re: [PATCH RFC net-next v2] page_pool: import Jesper's page_pool benchmark

2025-05-28 Thread Toke Høiland-Jørgensen
Mina Almasry writes: > On Mon, May 26, 2025 at 5:51 AM Toke Høiland-Jørgensen > wrote: >> > Fast path results: >> > no-softirq-page_pool01 Per elem: 11 cycles(tsc) 4.368 ns >> > >> > ptr_ring results: >> > no-softirq-page_pool02 Per elem: 527 cycles(tsc) 195.187 ns >> > >> > slow path results:

Re: [PATCH net-next] vsock/test: Cover more CIDs in transport_uaf test

2025-05-28 Thread Stefano Garzarella
On Wed, May 28, 2025 at 10:58:28AM +0200, Michal Luczaj wrote: On 5/27/25 10:41, Stefano Garzarella wrote: On Mon, May 26, 2025 at 10:44:05PM +0200, Michal Luczaj wrote: On 5/26/25 16:39, Stefano Garzarella wrote: On Mon, May 26, 2025 at 02:51:18PM +0200, Michal Luczaj wrote: On 5/26/25 10:25

Re: [PATCH net-next v9] selftests/vsock: add initial vmtest.sh for vsock

2025-05-28 Thread Stefano Garzarella
On Tue, May 27, 2025 at 05:36:54PM -0700, Bobby Eshleman wrote: This commit introduces a new vmtest.sh runner for vsock. It uses virtme-ng/qemu to run tests in a VM. The tests validate G2H, H2G, and loopback. The testing tools from tools/testing/vsock/ are reused. Currently, only vsock_test is u

[PATCH next] tools/testing: Check correct variable in open_procmap()

2025-05-28 Thread Dan Carpenter
Check if "procmap_out->fd" is negative instead of "procmap_out" (which is a pointer). Fixes: bd23f293a0d5 ("tools/testing: add PROCMAP_QUERY helper functions in mm self tests") Signed-off-by: Dan Carpenter --- tools/testing/selftests/mm/vm_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

Re: [PATCH net-next] selftests/bpf: Fix bpf selftest build warning

2025-05-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by Paolo Abeni : On Tue, 27 May 2025 11:11:38 +0530 you wrote: > On linux-next, build for bpf selftest displays a warning: > > Warning: Kernel ABI header at 'tools/include/uapi/linux/if_xdp.h' > differs from latest version at 'include/u

Re: [PATCH 0/7] Rust KUnit `#[test]` support improvements

2025-05-28 Thread Miguel Ojeda
On Tue, May 27, 2025 at 2:10 AM Miguel Ojeda wrote: > > [ Used the `cfg_attr` from the TODO comment and clarified its comment > now that the stabilization is in beta and thus quite likely stable > in Rust 1.88.0. Simplified the `new_body` code by introducing a new > variable.

[PATCH V2 09/19] virtio_ring: use vring_virtqueue for enable_cb_delayed variants

2025-05-28 Thread Jason Wang
Those variants are used internally so let's switch to use vring_virtqueue as parameter to be consistent with other internal virtqueue helpers. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-)

[PATCH V2 01/19] virtio_ring: rename virtqueue_reinit_xxx to virtqueue_reset_xxx()

2025-05-28 Thread Jason Wang
To be consistent with virtqueue_reset(). Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index b784aab66867..afdd51fc3c9

Re: [PATCH net-next] selftests/bpf: Fix bpf selftest build warning

2025-05-28 Thread Daniel Borkmann
On 5/27/25 7:41 AM, Saket Kumar Bhaskar wrote: On linux-next, build for bpf selftest displays a warning: Warning: Kernel ABI header at 'tools/include/uapi/linux/if_xdp.h' differs from latest version at 'include/uapi/linux/if_xdp.h'. Commit 8066e388be48 ("net: add UAPI to the header guard in var

[GIT PULL] virtio, vhost: features, fixes

2025-05-28 Thread Michael S. Tsirkin
Hi Linus, There are several bugfixes I'm testing for post rc1 on top of this, but they are pretty minor. The following changes since commit a5806cd506af5a7c19bcd596e4708b5c464bfd21: Linux 6.15-rc7 (2025-05-18 13:57:29 -0700) are available in the Git repository at: https://git.kernel.org/pu

Re: [PATCH V2 00/19] virtio_ring in order support

2025-05-28 Thread Eugenio Perez Martin
On Wed, May 28, 2025 at 8:42 AM Jason Wang wrote: > > Hello all: > > This sereis tries to implement the VIRTIO_F_IN_ORDER to > virtio_ring. This is done by introducing virtqueue ops so we can > implement separate helpers for different virtqueue layout/features > then the in-order were implemented

Re: [PATCH] fs/dax: Fix "don't skip locked entries when scanning entries"

2025-05-28 Thread Alistair Popple
On Tue, May 27, 2025 at 02:46:28PM -0700, Dan Williams wrote: > Alistair Popple wrote: > > Commit 6be3e21d25ca ("fs/dax: don't skip locked entries when scanning > > entries") introduced a new function, wait_entry_unlocked_exclusive(), > > which waits for the current entry to become unlocked without

[PATCH V2 07/19] virtio: switch to use vring_virtqueue for virtqueue_add variants

2025-05-28 Thread Jason Wang
Those variants are used internally so let's switch to use vring_virtqueue as parameter to be consistent with other internal virtqueue helpers. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-)