Hi Simon
>Other tests in this file seem to warn if the ip command is too old
>to support the test. Perhaps we can achieve that here something like this
>(completely untested!):
Thanks for the advice. I will modify the test to make sure it skips on
old iproute2 versions. I will send the patch after net-next reopens.
Thanks,
Yuyang
On Thu, May 29, 2025 at 12:49 AM Simon Horman <ho...@kernel.org> wrote:
>
> On Tue, May 27, 2025 at 06:18:55PM +0900, Yuyang Huang wrote:
> > This commit adds a new kernel selftest to verify RTNLGRP_IPV4_MCADDR
> > and RTNLGRP_IPV6_MCADDR notifications. The test works by adding and
> > removing a dummy interface and then confirming that the system
> > correctly receives join and removal notifications for the 224.0.0.1
> > and ff02::1 multicast addresses.
> >
> > The test relies on the iproute2 version to be 6.13+.
> >
> > Tested by the following command:
> > $ vng -v --user root --cpus 16 -- \
> > make -C tools/testing/selftests TARGETS=net TEST_PROGS=rtnetlink.sh \
> > TEST_GEN_PROGS="" run_tests
> >
> > Cc: Maciej Żenczykowski <m...@google.com>
> > Cc: Lorenzo Colitti <lore...@google.com>
> > Signed-off-by: Yuyang Huang <yuyanghu...@google.com>
>
> ...
>
> > +kci_test_mcast_addr_notification()
> > +{
> > + local tmpfile
> > + local monitor_pid
> > + local match_result
> > +
> > + tmpfile=$(mktemp)
> > +
> > + ip monitor maddr > $tmpfile &
> > + monitor_pid=$!
>
> Hi Yuyang Huang,
>
> Other tests in this file seem to warn if the ip command is too old
> to support the test. Perhaps we can achieve that here something like this
> (completely untested!):
>
> if [ ! -e "/proc/$monitor_pid" ]; then
> end_test "SKIP: mcast addr notification: iproute2 too old"
> rm $tmpfile
> return $ksft_skip
> fi
>
> > + sleep 1
> > +
> > + run_cmd ip link add name test-dummy1 type dummy
> > + run_cmd ip link set test-dummy1 up
> > + run_cmd ip link del dev test-dummy1
> > + sleep 1
> > +
> > + match_result=$(grep -cE "test-dummy1.*(224.0.0.1|ff02::1)" $tmpfile)
> > +
> > + kill $monitor_pid
> > + rm $tmpfile
> > + # There should be 4 line matches as follows.
> > + # 13: test-dummy1 inet6 mcast ff02::1 scope global
> > + # 13: test-dummy1 inet mcast 224.0.0.1 scope global
> > + # Deleted 13: test-dummy1 inet mcast 224.0.0.1 scope global
> > + # Deleted 13: test-dummy1 inet6 mcast ff02::1 scope global
> > + if [ $match_result -ne 4 ];then
> > + end_test "FAIL: mcast addr notification"
> > + return 1
> > + fi
> > + end_test "PASS: mcast addr notification"
> > +}
> > +
>
> ...
>
> ## Form letter - net-next-closed
>
> The merge window for v6.16 has begun and therefore net-next is closed
> for new drivers, features, code refactoring and optimizations. We are
> currently accepting bug fixes only.
>
> Please repost when net-next reopens after June 8th.
>
> RFC patches sent for review only are obviously welcome at any time.
>
> pw-bot: deffer
