RE: [PATCH v2 2/2] x86/sgx: Implement EUPDATESVN and opportunistically call it during first EPC page alloc

2025-04-07 Thread Reshetova, Elena
> > On Tue, Apr 08, 2025 at 09:40:14AM +0300, Jarkko Sakkinen wrote: > > On Tue, Apr 08, 2025 at 12:06:32AM +, Huang, Kai wrote: > > > On Mon, 2025-04-07 at 08:23 +, Reshetova, Elena wrote: > > > > > On Fri, Apr 04, 2025 at 06:53:17AM +, Reshetova, Elena wrote: > > > > > > > On Wed, Ap

Re: [PATCH v2 2/2] x86/sgx: Implement EUPDATESVN and opportunistically call it during first EPC page alloc

2025-04-07 Thread Jarkko Sakkinen
On Tue, Apr 08, 2025 at 09:40:14AM +0300, Jarkko Sakkinen wrote: > On Tue, Apr 08, 2025 at 12:06:32AM +, Huang, Kai wrote: > > On Mon, 2025-04-07 at 08:23 +, Reshetova, Elena wrote: > > > > On Fri, Apr 04, 2025 at 06:53:17AM +, Reshetova, Elena wrote: > > > > > > On Wed, Apr 02, 2025 at

Re: [PATCH v2 2/2] x86/sgx: Implement EUPDATESVN and opportunistically call it during first EPC page alloc

2025-04-07 Thread Jarkko Sakkinen
On Tue, Apr 08, 2025 at 12:06:32AM +, Huang, Kai wrote: > On Mon, 2025-04-07 at 08:23 +, Reshetova, Elena wrote: > > > On Fri, Apr 04, 2025 at 06:53:17AM +, Reshetova, Elena wrote: > > > > > On Wed, Apr 02, 2025 at 01:11:25PM +, Reshetova, Elena wrote: > > > > > > > > current SGX ke

Re: [PATCH] selftest/mm: Make hugetlb_reparenting_test tolerant to async reparenting

2025-04-07 Thread Donet Tom
On 4/7/25 2:12 PM, Li Wang wrote: In cgroup v2, memory and hugetlb usage reparenting is asynchronous. This can cause test flakiness when immediately asserting usage after deleting a child cgroup. To address this, add a helper function `assert_with_retry()` that checks usage values with a timeou

Re: Re: [PATCH] selftests: mptcp: add comment for getaddrinfo

2025-04-07 Thread zhenwei pi
On 4/8/25 09:43, Geliang Tang wrote: Hi zhenwei, On Mon, 2025-04-07 at 16:51 +0800, zhenwei pi wrote: mptcp_connect.c is a startup tutorial of MPTCP programming, however there is a lack of ai_protocol(IPPROTO_MPTCP) usage. Add comment for getaddrinfo MPTCP support. Signed-off-by: zhenwei pi

Re: [PATCH] kbuild: Require pahole >v1.29 with GENDWARFKSYMS and BTF on X86

2025-04-07 Thread Sam James
Alan Maguire writes: > On 07/04/2025 09:25, Sam James wrote: >> [with regard to >> https://lore.kernel.org/linux-kbuild/20250320232757.2283956-2-samitolva...@google.com/] >> >> Would it be possible to have a new release with that fix, to avoid >> distros all having to cherrypick the fix commit?

Re: [PATCH] selftests: mptcp: add comment for getaddrinfo

2025-04-07 Thread Geliang Tang
Hi zhenwei, On Mon, 2025-04-07 at 16:51 +0800, zhenwei pi wrote: > mptcp_connect.c is a startup tutorial of MPTCP programming, however > there is a lack of ai_protocol(IPPROTO_MPTCP) usage. Add comment for > getaddrinfo MPTCP support. > > Signed-off-by: zhenwei pi > Signed-off-by: zhenwei pi >

Re: [PATCH] vhost/net: remove zerocopy support

2025-04-07 Thread Jon Kohler
> On Apr 6, 2025, at 7:14 PM, Jason Wang wrote: > > !---| > CAUTION: External Email > > |---! > > On Fri, Apr 4, 2025 at 10:24 PM Jon Kohler wrote: >> >> Commit 0

Re: [PATCH v2 2/2] x86/sgx: Implement EUPDATESVN and opportunistically call it during first EPC page alloc

2025-04-07 Thread Huang, Kai
On Mon, 2025-04-07 at 08:23 +, Reshetova, Elena wrote: > > On Fri, Apr 04, 2025 at 06:53:17AM +, Reshetova, Elena wrote: > > > > On Wed, Apr 02, 2025 at 01:11:25PM +, Reshetova, Elena wrote: > > > > > > > current SGX kernel code does not handle such errors in any other > > way > > > > >

Re: [PATCH] kbuild: Require pahole >v1.29 with GENDWARFKSYMS and BTF on X86

2025-04-07 Thread Sami Tolvanen
Hi Masahiro, On Sun, Apr 6, 2025 at 1:21 PM Masahiro Yamada wrote: > > On Fri, Mar 21, 2025 at 8:28 AM Sami Tolvanen wrote: > > > > With CONFIG_GENDWARFKSYMS, __gendwarfksyms_ptr variables are added > > to the kernel in EXPORT_SYMBOL() to ensure DWARF type information > > is available for export

[PATCH AUTOSEL 6.14 11/31] sound/virtio: Fix cancel_sync warnings on uninitialized work_structs

2025-04-07 Thread Sasha Levin
From: John Stultz [ Upstream commit 3c7df2e27346eb40a0e86230db1ccab195c97cfe ] Betty reported hitting the following warning: [8.709131][ T221] WARNING: CPU: 2 PID: 221 at kernel/workqueue.c:4182 ... [8.713282][ T221] Call trace: [8.713365][ T221] __flush_work+0x8d0/0x914 [8.

Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues

2025-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2025 at 08:47:05PM +0200, David Hildenbrand wrote: > > In my opinion, it makes the most sense to keep the spec as it is and > > change QEMU and the kernel to match, but obviously that's not trivial > > to do in a way that doesn't break existing devices and drivers. > > If only it w

[PATCH v17 08/15] PCI: endpoint: pci-ep-msi: Add MSI address/data pair mutable check

2025-04-07 Thread Frank Li
Some MSI controller change address/data pair when irq_set_affinity(). Current PCI endpoint can't support this type MSI controller. So add flag MSI_FLAG_MUTABLE in include/linux/msi.h and check it when allocate doorbell. Signed-off-by: Frank Li --- change from v14 to v16 - none change from v13 t

[PATCH v17 11/15] misc: pci_endpoint_test: Add doorbell test case

2025-04-07 Thread Frank Li
Add three registers: PCIE_ENDPOINT_TEST_DB_BAR, PCIE_ENDPOINT_TEST_DB_ADDR, and PCIE_ENDPOINT_TEST_DB_DATA. Trigger the doorbell by writing data from PCI_ENDPOINT_TEST_DB_DATA to the address provided by PCI_ENDPOINT_TEST_DB_OFFSET and wait for endpoint feedback. Add two command to COMMAND_ENABLE_

[PATCH v17 06/15] PCI: endpoint: Set ID and of_node for function driver

2025-04-07 Thread Frank Li
Set device ID as 'vfunc_no << 3 | func_no' and use 'device_set_of_node_from_dev()' to set 'of_node' the same as the EPC parent device. Currently, EPF 'of_node' is NULL, but many functions depend on 'of_node' settings, such as DMA, IOMMU, and MSI. At present, all DMA allocation functions use the EP

[PATCH net-next v25 23/23] testing/selftests: add test tool and scripts for ovpn module

2025-04-07 Thread Antonio Quartulli
The ovpn-cli tool can be compiled and used as selftest for the ovpn kernel module. [NOTE: it depends on libmedtls for decoding base64-encoded keys] ovpn-cli implements the netlink and RTNL APIs and can thus be integrated in any script for more automated testing. Along with the tool, a bunch of s

[PATCH net-next v25 20/23] ovpn: kill key and notify userspace in case of IV exhaustion

2025-04-07 Thread Antonio Quartulli
IV wrap-around is cryptographically dangerous for a number of ciphers, therefore kill the key and inform userspace (via netlink) should the IV space go exhausted. Userspace has two ways of deciding when the key has to be renewed before exhausting the IV space: 1) time based approach: after X se

[PATCH net-next v25 21/23] ovpn: notify userspace when a peer is deleted

2025-04-07 Thread Antonio Quartulli
Whenever a peer is deleted, send a notification to userspace so that it can react accordingly. This is most important when a peer is deleted due to ping timeout, because it all happens in kernelspace and thus userspace has no direct way to learn about it. Signed-off-by: Antonio Quartulli --- dr

[PATCH v17 10/15] PCI: endpoint: pci-epf-test: Add doorbell test support

2025-04-07 Thread Frank Li
Add three registers: doorbell_bar, doorbell_addr, and doorbell_data. Use pci_epf_alloc_doorbell() to allocate a doorbell address space. Enable the Root Complex (RC) side driver to trigger pci-epc-test's doorbell callback handler by writing doorbell_data to the mapped doorbell_bar's address space.

[PATCH net-next v25 19/23] ovpn: implement key add/get/del/swap via netlink

2025-04-07 Thread Antonio Quartulli
This change introduces the netlink commands needed to add, get, delete and swap keys for a specific peer. Userspace is expected to use these commands to create, inspect (non sensitive data only), destroy and rotate session keys for a specific peer. Signed-off-by: Antonio Quartulli --- drivers/n

[PATCH v17 14/15] pci: imx6: Add LUT setting for MSI/IOMMU in Endpoint mode

2025-04-07 Thread Frank Li
Support only one physical function, so call imx_pcie_add_lut_by_rid(0) to add a single LUT entry when operating in EP mode. Signed-off-by: Frank Li --- change from v14 to v16 - none change from v13 to v14 - new patch --- drivers/pci/controller/dwc/pci-imx6.c | 8 +++- 1 file changed, 7 inse

[PATCH v17 04/15] dt-bindings: PCI: pci-ep: Add support for iommu-map and msi-map

2025-04-07 Thread Frank Li
Document the use of (msi|iommu)-map for PCI Endpoint (EP) controllers, which can use MSI as a doorbell mechanism. Each EP controller can support up to 8 physical functions and 65,536 virtual functions. Define how to construct device IDs using function bits [2:0] and virtual function index bits [31

[PATCH v17 03/15] irqchip/gic-v3-its: Set IRQ_DOMAIN_FLAG_MSI_IMMUTABLE for ITS

2025-04-07 Thread Frank Li
Set the IRQ_DOMAIN_FLAG_MSI_IMMUTABLE flag for ITS, as it does not change the address/data pair after setup. Ensure compatibility with MSI users, such as PCIe Endpoint Doorbell, which require the address/data pair to remain unchanged. Enable PCIe endpoints to use ITS for triggering doorbells from

[PATCH v17 02/15] irqdomain: Add IRQ_DOMAIN_FLAG_MSI_IMMUTABLE and irq_domain_is_msi_immutable()

2025-04-07 Thread Frank Li
Add the flag IRQ_DOMAIN_FLAG_MSI_IMMUTABLE and the API function irq_domain_is_msi_immutable() to check if the MSI controller retains an immutable address/data pair during irq_set_affinity(). Ensure compatibility with MSI users like PCIe Endpoint Doorbell, which require the address/data pair to rem

[PATCH net-next v25 09/23] ovpn: implement packet processing

2025-04-07 Thread Antonio Quartulli
This change implements encryption/decryption and encapsulation/decapsulation of OpenVPN packets. Support for generic crypto state is added along with a wrapper for the AEAD crypto kernel API. Signed-off-by: Antonio Quartulli --- drivers/net/Kconfig| 4 + drivers/net/ovpn/Makefile

[PATCH net-next v25 05/23] ovpn: introduce the ovpn_peer object

2025-04-07 Thread Antonio Quartulli
An ovpn_peer object holds the whole status of a remote peer (regardless whether it is a server or a client). This includes status for crypto, tx/rx buffers, napi, etc. Only support for one peer is introduced (P2P mode). Multi peer support is introduced with a later patch. Along with the ovpn_pee

[PATCH net-next v25 08/23] ovpn: implement basic RX path (UDP)

2025-04-07 Thread Antonio Quartulli
Packets received over the socket are forwarded to the user device. Implementation is UDP only. TCP will be added by a later patch. Note: no decryption/decapsulation exists yet, packets are forwarded as they arrive without much processing. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/i

[PATCH net-next v25 02/23] ovpn: add basic netlink support

2025-04-07 Thread Antonio Quartulli
This commit introduces basic netlink support with family registration/unregistration functionalities and stub pre/post-doit. More importantly it introduces the YAML uAPI description along with its auto-generated files: - include/uapi/linux/ovpn.h - drivers/net/ovpn/netlink-gen.c - drivers/net/ovpn

[PATCH net-next v25 22/23] ovpn: add basic ethtool support

2025-04-07 Thread Antonio Quartulli
Implement support for basic ethtool functionality. Note that ovpn is a virtual device driver, therefore various ethtool APIs are just not meaningful and thus not implemented. Signed-off-by: Antonio Quartulli Reviewed-by: Andrew Lunn --- drivers/net/ovpn/main.c | 15 +++ 1 file chan

[PATCH net-next v25 17/23] ovpn: add support for updating local or remote UDP endpoint

2025-04-07 Thread Antonio Quartulli
In case of UDP links, the local or remote endpoint used to communicate with a given peer may change without a connection restart. Add support for learning the new address in case of change. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/io.c | 8 ++ drivers/net/ovpn/peer.c | 213

[PATCH net-next v25 01/23] net: introduce OpenVPN Data Channel Offload (ovpn)

2025-04-07 Thread Antonio Quartulli
OpenVPN is a userspace software existing since around 2005 that allows users to create secure tunnels. So far OpenVPN has implemented all operations in userspace, which implies several back and forth between kernel and user land in order to process packets (encapsulate/decapsulate, encrypt/decrypt

[PATCH net-next v25 16/23] ovpn: implement keepalive mechanism

2025-04-07 Thread Antonio Quartulli
OpenVPN supports configuring a periodic keepalive packet. message to allow the remote endpoint detect link failures. This change implements the keepalive sending and timer expiring logic. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/io.c | 78 - drivers/net/ovpn/

[PATCH net-next v25 14/23] ovpn: implement multi-peer support

2025-04-07 Thread Antonio Quartulli
With this change an ovpn instance will be able to stay connected to multiple remote endpoints. This functionality is strictly required when running ovpn on an OpenVPN server. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/main.c | 64 +-- drivers/net/ovpn/ovpnpriv.h | 1

[PATCH net-next v25 15/23] ovpn: implement peer lookup logic

2025-04-07 Thread Antonio Quartulli
In a multi-peer scenario there are a number of situations when a specific peer needs to be looked up. We may want to lookup a peer by: 1. its ID 2. its VPN destination IP 3. its transport IP/port couple For each of the above, there is a specific routing table referencing all peers for fast look u

[PATCH net-next v25 13/23] ovpn: add support for MSG_NOSIGNAL in tcp_sendmsg

2025-04-07 Thread Antonio Quartulli
Userspace may want to pass the MSG_NOSIGNAL flag to tcp_sendmsg() in order to avoid generating a SIGPIPE. To pass this flag down the TCP stack a new skb sending API accepting a flags argument is introduced. Cc: Eric Dumazet Cc: Paolo Abeni Signed-off-by: Antonio Quartulli --- drivers/net/ovpn

[PATCH net-next v25 03/23] ovpn: add basic interface creation/destruction/management routines

2025-04-07 Thread Antonio Quartulli
Add basic infrastructure for handling ovpn interfaces. Tested-by: Donald Hunter Signed-off-by: Antonio Quartulli --- Documentation/netlink/specs/rt_link.yaml | 16 ++ drivers/net/ovpn/Makefile| 1 + drivers/net/ovpn/io.c| 22 +++ drivers/net/ovpn/io.

[PATCH net-next v25 07/23] ovpn: implement basic TX path (UDP)

2025-04-07 Thread Antonio Quartulli
Packets sent over the ovpn interface are processed and transmitted to the connected peer, if any. Implementation is UDP only. TCP will be added by a later patch. Note: no crypto/encapsulation exists yet. Packets are just captured and sent. Signed-off-by: Antonio Quartulli --- drivers/net/Kconf

[PATCH net-next v25 00/23] Introducing OpenVPN Data Channel Offload

2025-04-07 Thread Antonio Quartulli
Notable changes since v24: * disable TCP disconnections of attached sockets (tcp_disconnect() returns -EBUSY) - similarly to kTLS. * used rcu_replace_pointer instead of rcu_dereference_protected+rcu_assign_pointer * dropped useless skb->ignore_df = 1 * dropped unneded EXPORT_SYMBOL_GPL(udpv6_pro

Re: [PATCH RESEND 0/4] media: i2c: imx214: Problem with CCS PLL calculator

2025-04-07 Thread André Apitzsch
Am Montag, dem 10.03.2025 um 23:35 +0100 schrieb André Apitzsch: > Hi Sakari, > > Am Montag, dem 10.03.2025 um 11:11 + schrieb Sakari Ailus: > > Hi André, > > > > On Sat, Mar 08, 2025 at 10:47:54PM +0100, André Apitzsch via B4 > > Relay > > wrote: > > > The imx214 driver currently supports on

[PATCH v3 4/12] rcutorture: Make torture.sh --do-rt use CONFIG_PREEMPT_RT

2025-04-07 Thread Paul E. McKenney
The torture.sh --do-rt command-line parameter is intended to mimic -rt kernels. Now that CONFIG_PREEMPT_RT is upstream, this commit makes this mimicking more precise. Note that testing of RCU priority boosting is disabled in favor of forward-progress testing of RCU callbacks. If it turns out to

[PATCH net 2/2] selftests: mptcp: validate MPJoin HMacFailure counters

2025-04-07 Thread Matthieu Baerts (NGI0)
The parent commit fixes an issue around these counters where one of them -- MPJoinAckHMacFailure -- was wrongly incremented in some cases. This makes sure the counter is always 0. It should be incremented only in case of corruption, or a wrong implementation, which should not be the case in these

[PATCH net 1/2] mptcp: only inc MPJoinAckHMacFailure for HMAC failures

2025-04-07 Thread Matthieu Baerts (NGI0)
Recently, during a debugging session using local MPTCP connections, I noticed MPJoinAckHMacFailure was not zero on the server side. The counter was in fact incremented when the PM rejected new subflows, because the 'subflow' limit was reached. The fix is easy, simply dissociating the two cases: on

[PATCH AUTOSEL 6.13 09/28] sound/virtio: Fix cancel_sync warnings on uninitialized work_structs

2025-04-07 Thread Sasha Levin
From: John Stultz [ Upstream commit 3c7df2e27346eb40a0e86230db1ccab195c97cfe ] Betty reported hitting the following warning: [8.709131][ T221] WARNING: CPU: 2 PID: 221 at kernel/workqueue.c:4182 ... [8.713282][ T221] Call trace: [8.713365][ T221] __flush_work+0x8d0/0x914 [8.

Re: [PATCH v2] selftests/x86/lam: fix resource leak in do_uring() and allocate_dsa_pasid()

2025-04-07 Thread Ingo Molnar
* Malaya Kumar Rout wrote: > @@ -1189,9 +1191,10 @@ void *allocate_dsa_pasid(void) > > wq = mmap(NULL, 0x1000, PROT_WRITE, > MAP_SHARED | MAP_POPULATE, fd, 0); > - if (wq == MAP_FAILED) > + if (wq == MAP_FAILED){ > + close(fd); >

Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues

2025-04-07 Thread Daniel Verkamp
On Mon, Apr 7, 2025 at 6:13 AM David Hildenbrand wrote: > > On 07.04.25 11:13, David Hildenbrand wrote: > > On 07.04.25 11:11, David Hildenbrand wrote: > >> On 07.04.25 10:58, Michael S. Tsirkin wrote: > >>> On Mon, Apr 07, 2025 at 10:54:00AM +0200, David Hildenbrand wrote: > On 07.04.25 10:4

[PATCH AUTOSEL 6.1 05/13] sound/virtio: Fix cancel_sync warnings on uninitialized work_structs

2025-04-07 Thread Sasha Levin
From: John Stultz [ Upstream commit 3c7df2e27346eb40a0e86230db1ccab195c97cfe ] Betty reported hitting the following warning: [8.709131][ T221] WARNING: CPU: 2 PID: 221 at kernel/workqueue.c:4182 ... [8.713282][ T221] Call trace: [8.713365][ T221] __flush_work+0x8d0/0x914 [8.

[PATCH AUTOSEL 6.6 05/15] sound/virtio: Fix cancel_sync warnings on uninitialized work_structs

2025-04-07 Thread Sasha Levin
From: John Stultz [ Upstream commit 3c7df2e27346eb40a0e86230db1ccab195c97cfe ] Betty reported hitting the following warning: [8.709131][ T221] WARNING: CPU: 2 PID: 221 at kernel/workqueue.c:4182 ... [8.713282][ T221] Call trace: [8.713365][ T221] __flush_work+0x8d0/0x914 [8.

[PATCH] dt-bindings: virtio: pci-iommu: Add ref to pci-device.yaml

2025-04-07 Thread Rob Herring (Arm)
The virtio pci-iommu is a PCI device, so it should have a reference to the pci-device.yaml schema. The pci-device.yaml schema defines the 'reg' format as a schema, so the text description for 'reg' can be dropped. Signed-off-by: Rob Herring (Arm) --- .../devicetree/bindings/virtio/pci-iommu.yaml

Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues

2025-04-07 Thread Halil Pasic
On Mon, 07 Apr 2025 15:28:13 +0200 Cornelia Huck wrote: > > Staring at the cross-vmm, including the adding+removing of features and > > queues that are not in the spec, I am wondering if (in a world with > > fixed virtqueues) > > > > 1) Feature bits must be reserved before used. > > > > 2) Queu

[PATCH v5 2/2] selftests: memcg: Increase error tolerance of child memory.current check in test_memcg_protection()

2025-04-07 Thread Waiman Long
The test_memcg_protection() function is used for the test_memcg_min and test_memcg_low sub-tests. This function generates a set of parent/child cgroups like: parent: memory.min/low = 50M child 0: memory.min/low = 75M, memory.current = 50M child 1: memory.min/low = 25M, memory.current = 50

[PATCH v5 0/2] memcg: Fix test_memcg_min/low test failures

2025-04-07 Thread Waiman Long
v5: - Use mem_cgroup_usage() as originally suggested by Johannes. v4: - Add "#ifdef CONFIG_MEMCG" directives around shrink_node_memcgs() to avoid compilation problem with !CONFIG_MEMCG configs. The test_memcontrol selftest consistently fails its test_memcg_low sub-test and sporadically fails

Re: [PATCH v3] remoteproc: imx_dsp_rproc: Add support for DSP-specific features

2025-04-07 Thread Mathieu Poirier
Good morning, On Thu, Apr 03, 2025 at 01:01:24PM +0300, Iuliana Prodan (OSS) wrote: > From: Iuliana Prodan > > Some DSP firmware requires a FW_READY signal before proceeding, while > others do not. > Therefore, add support to handle i.MX DSP-specific features. > > Implement handle_rsc callback

Re: [PATCH v8 5/8] vhost: Reintroduce kthread mode support in vhost

2025-04-07 Thread Mike Christie
On 3/28/25 5:02 AM, Cindy Lu wrote: > +static int vhost_kthread_worker_create(struct vhost_worker *worker, > +struct vhost_dev *dev, const char *name) > +{ > + struct task_struct *task; > + u32 id; > + int ret; > + > + task = kthread_create(vhost_

Re: [PATCH v3 0/6] KVM: guest_memfd: support for uffd minor

2025-04-07 Thread David Hildenbrand
On 07.04.25 17:14, Lorenzo Stoakes wrote: On Mon, Apr 07, 2025 at 04:46:48PM +0200, David Hildenbrand wrote: On 07.04.25 16:24, Liam R. Howlett wrote: * Nikita Kalyazin [250407 10:05]: ... All of this is extremely confusing because the onus of figuring out what the final code will look

Re: [PATCH v4 1/2] mm/vmscan: Skip memcg with !usage in shrink_node_memcgs()

2025-04-07 Thread Michal Koutný
Hi Waiman. On Sun, Apr 06, 2025 at 09:41:58PM -0400, Waiman Long wrote: ... > diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c > b/tools/testing/selftests/cgroup/test_memcontrol.c > index 16f5d74ae762..bab826b6b7b0 100644 > --- a/tools/testing/selftests/cgroup/test_memcontrol.c >

Re: [PATCH v3 0/6] KVM: guest_memfd: support for uffd minor

2025-04-07 Thread Lorenzo Stoakes
On Mon, Apr 07, 2025 at 04:46:48PM +0200, David Hildenbrand wrote: > On 07.04.25 16:24, Liam R. Howlett wrote: > > * Nikita Kalyazin [250407 10:05]: > > > > > > > ... > > > > > > > > > > All of this is extremely confusing because the onus of figuring out what > > > > the final code will look like

Re: [RESEND] virtiofs: add filesystem context source name check

2025-04-07 Thread Miklos Szeredi
On Mon, 7 Apr 2025 at 13:51, Xiangsheng Hou wrote: > > In certain scenarios, for example, during fuzz testing, the source > name may be NULL, which could lead to a kernel panic. Therefore, an > extra check for the source name should be added. > > Signed-off-by: Xiangsheng Hou Acked-by: Miklos Sz

Re: [PATCH] scripts/spdxcheck: Limit the scope of git.Repo

2025-04-07 Thread Duje Mihanović
On Tuesday, 25 February 2025 14:10:41 Central European Summer Time Ricardo Ribalda wrote: > If the git.Repo object's scope extends to the Python interpreter's > shutdown phase, its destructor may fail due to the interpreter's state. > > Exception ignored in: > Traceback (most recent call last):

Re: [PATCH v3 0/6] KVM: guest_memfd: support for uffd minor

2025-04-07 Thread Liam R. Howlett
* Nikita Kalyazin [250407 10:05]: > ... > > > > All of this is extremely confusing because the onus of figuring out what > > the final code will look like is put on the reviewer. As it is, we have > > issues with people not doing enough review of the code (due to limited > > time). One way t

Re: [PATCH v3 0/6] KVM: guest_memfd: support for uffd minor

2025-04-07 Thread David Hildenbrand
On 07.04.25 16:24, Liam R. Howlett wrote: * Nikita Kalyazin [250407 10:05]: ... All of this is extremely confusing because the onus of figuring out what the final code will look like is put on the reviewer. As it is, we have issues with people not doing enough review of the code (due to

Re: [PATCH v4 1/2] mm/vmscan: Skip memcg with !usage in shrink_node_memcgs()

2025-04-07 Thread Waiman Long
On 4/7/25 10:24 AM, Johannes Weiner wrote: On Sun, Apr 06, 2025 at 09:41:58PM -0400, Waiman Long wrote: The test_memcontrol selftest consistently fails its test_memcg_low sub-test due to the fact that two of its test child cgroups which have a memmory.low of 0 or an effective memory.low of 0 sti

[PATCH bpf-next v1 2/4] bpf, sockmap: fix duplicated data transmission

2025-04-07 Thread Jiayuan Chen
In the !ingress path under sk_psock_handle_skb(), when sending data to the remote under snd_buf limitations, partial skb data might be transmitted. Although we preserved the partial transmission state (offset/length), the state wasn't properly consumed during retries. This caused the retry path to

[PATCH bpf-next v1 4/4] selftest/bpf/benchs: Add benchmark for sockmap usage

2025-04-07 Thread Jiayuan Chen
Add TCP+sockmap-based benchmark. Since sockmap's own update and delete operations are generally less critical, the performance of the fast forwarding framework built upon it is the key aspect. Also with cgset/cgexec, we can observe the behavior of sockmap under memory pressure. The benchmark can

[PATCH bpf-next v1 1/4] bpf, sockmap: Fix data lost during EAGAIN retries

2025-04-07 Thread Jiayuan Chen
We call skb_bpf_redirect_clear() to clean _sk_redir before handling skb in backlog, but when sk_psock_handle_skb() return EAGAIN due to sk_rcvbuf limit, the redirect info in _sk_redir is not recovered. Fix skb redir loss during EAGAIN retries by restoring _sk_redir information using skb_bpf_set_re

[PATCH bpf-next v1 3/4] bpf, sockmap: Fix panic when calling skb_linearize

2025-04-07 Thread Jiayuan Chen
The panic can be reproduced by executing the command: ./bench sockmap -c 2 -p 1 -a --rx-verdict-ingress --rx-strp 10 Then a kernel panic was captured: ''' [ 657.460555] kernel BUG at net/core/skbuff.c:2178! [ 657.462680] Tainted: [W]=WARN [ 657.463287] Workqueue: events sk_psock_backlog ...

Re: [PATCH v4 1/2] mm/vmscan: Skip memcg with !usage in shrink_node_memcgs()

2025-04-07 Thread Johannes Weiner
On Sun, Apr 06, 2025 at 09:41:58PM -0400, Waiman Long wrote: > The test_memcontrol selftest consistently fails its test_memcg_low > sub-test due to the fact that two of its test child cgroups which > have a memmory.low of 0 or an effective memory.low of 0 still have low > events generated for them

Re: [PATCH v2 0/3] module: Make .static_call_sites read-only after init

2025-04-07 Thread Petr Pavlu
On 3/6/25 14:13, Petr Pavlu wrote: > Section .static_call_sites holds data structures that need to be sorted and > processed only at module load time. The section is never modified > afterwards. Make it therefore read-only after module initialization to > avoid any (non-)accidental modifications. >

Re: [PATCH v3 0/6] KVM: guest_memfd: support for uffd minor

2025-04-07 Thread Nikita Kalyazin
On 07/04/2025 14:40, Liam R. Howlett wrote: * Nikita Kalyazin [250407 07:04]: On 04/04/2025 18:12, Liam R. Howlett wrote: +To authors of v7 series referenced in [1] * Nikita Kalyazin [250404 11:44]: This series is built on top of the Fuad's v7 "mapping guest_memfd backed memory at the

Re: [PATCH v3 0/6] KVM: guest_memfd: support for uffd minor

2025-04-07 Thread Liam R. Howlett
* Nikita Kalyazin [250407 07:04]: > > > On 04/04/2025 18:12, Liam R. Howlett wrote: > > +To authors of v7 series referenced in [1] > > > > * Nikita Kalyazin [250404 11:44]: > > > This series is built on top of the Fuad's v7 "mapping guest_memfd backed > > > memory at the host" [1]. > > > > I

Re: [PATCH v9 08/26] remoteproc: k3-r5: Refactor sequential core power up/down operations

2025-04-07 Thread Andrew Davis
On 3/17/25 7:06 AM, Beleswar Padhi wrote: The existing implementation of the waiting mechanism in "k3_r5_cluster_rproc_init()" waits for the "released_from_reset" flag to be set as part of the firmware boot process in "k3_r5_rproc_start()". The "k3_r5_cluster_rproc_init()" function is invoked in

Re: [PATCH v9 05/26] remoteproc: k3-m4: Use k3_rproc_mem_data structure for memory info

2025-04-07 Thread Andrew Davis
On 3/17/25 7:06 AM, Beleswar Padhi wrote: The ti_k3_m4_remoteproc.c driver previously hardcoded device memory region addresses and names. Change this to use the k3_rproc_mem_data structure to store memory information. This aligns with DSP and R5 drivers, and can be refactored out later. Signed-o

Re: [PATCH v9 04/26] remoteproc: k3-{m4/dsp}: Align internal rproc data structure with R5

2025-04-07 Thread Andrew Davis
On 3/17/25 7:06 AM, Beleswar Padhi wrote: Introduce a void pointer in the k3_{m4/dsp}_rproc internal data structure which can be used to point to any private data needed by the driver. Currently, the M4/DSP drivers do not have any private data, so the pointer can be left pointing to NULL. Additio

Re: [PATCH v9 03/26] remoteproc: k3-r5: Use k3_r5_rproc_mem_data structure for memory info

2025-04-07 Thread Andrew Davis
On 3/17/25 7:05 AM, Beleswar Padhi wrote: The ti_k3_r5_remoteproc.c driver previously hardcoded device memory region addresses and names. Change this to use the k3_r5_rproc_mem_data structure to store memory information. This aligns with K3 DSP and M4 drivers, and can be refactored out later. Si

Re: [PATCH v9 02/26] remoteproc: k3-r5: Refactor Data Structures to Align with DSP and M4

2025-04-07 Thread Andrew Davis
On 3/17/25 7:05 AM, Beleswar Padhi wrote: Currently, struct members such as mem, num_mems, reset, tsp, ti_sci and ti_sci_id are part of the k3_r5_core structure. To align the rproc->priv data structure of the R5 remote processor with that of the DSP and M4, move the above members from k3_r5_core

Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues

2025-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2025 at 03:28:13PM +0200, Cornelia Huck wrote: > On Mon, Apr 07 2025, David Hildenbrand wrote: > > > On 07.04.25 15:12, Halil Pasic wrote: > >> On Mon, 7 Apr 2025 04:34:29 -0400 > >> "Michael S. Tsirkin" wrote: > >> > >>> On Mon, Apr 07, 2025 at 10:17:10AM +0200, David Hildenbra

Re: [PATCH v9 01/26] remoteproc: k3-r5: Re-order internal memory initialization function

2025-04-07 Thread Andrew Davis
On 3/17/25 7:05 AM, Beleswar Padhi wrote: The core's internal memory data structure will be refactored to be part of the k3_r5_rproc structure in a future commit. As a result, internal memory initialization will need to be performed inside k3_r5_cluster_rproc_init() after rproc_alloc(). Therefor

Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues

2025-04-07 Thread Cornelia Huck
On Mon, Apr 07 2025, David Hildenbrand wrote: > On 07.04.25 15:12, Halil Pasic wrote: >> On Mon, 7 Apr 2025 04:34:29 -0400 >> "Michael S. Tsirkin" wrote: >> >>> On Mon, Apr 07, 2025 at 10:17:10AM +0200, David Hildenbrand wrote: On 07.04.25 09:52, Michael S. Tsirkin wrote: > On Fri, Apr

Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues

2025-04-07 Thread Halil Pasic
On Mon, 7 Apr 2025 04:34:29 -0400 "Michael S. Tsirkin" wrote: > On Mon, Apr 07, 2025 at 10:17:10AM +0200, David Hildenbrand wrote: > > On 07.04.25 09:52, Michael S. Tsirkin wrote: > > > On Fri, Apr 04, 2025 at 05:39:10PM +0200, Halil Pasic wrote: > > > > > > > > > > Not perfect, but AFAIKS,

Re: [PATCH v9 06/26] remoteproc: k3-r5: Drop check performed in k3_r5_rproc_{mbox_callback/kick}

2025-04-07 Thread Andrew Davis
On 3/17/25 7:06 AM, Beleswar Padhi wrote: From: Siddharth Vadapalli Commit f3f11cfe8907 ("remoteproc: k3-r5: Acquire mailbox handle during probe routine") introduced a check in the "k3_r5_rproc_mbox_callback()" and "k3_r5_rproc_kick()" callbacks, causing them to exit if the remote core's state

Re: [RESEND] virtiofs: add filesystem context source name check

2025-04-07 Thread Christian Brauner
On Mon, 07 Apr 2025 19:50:49 +0800, Xiangsheng Hou wrote: > In certain scenarios, for example, during fuzz testing, the source > name may be NULL, which could lead to a kernel panic. Therefore, an > extra check for the source name should be added. > > Applied to the vfs.fixes branch of the vfs/v

Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues

2025-04-07 Thread David Hildenbrand
On 07.04.25 15:12, Halil Pasic wrote: On Mon, 7 Apr 2025 04:34:29 -0400 "Michael S. Tsirkin" wrote: On Mon, Apr 07, 2025 at 10:17:10AM +0200, David Hildenbrand wrote: On 07.04.25 09:52, Michael S. Tsirkin wrote: On Fri, Apr 04, 2025 at 05:39:10PM +0200, Halil Pasic wrote: Not perfect, but

Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues

2025-04-07 Thread David Hildenbrand
On 07.04.25 11:13, David Hildenbrand wrote: On 07.04.25 11:11, David Hildenbrand wrote: On 07.04.25 10:58, Michael S. Tsirkin wrote: On Mon, Apr 07, 2025 at 10:54:00AM +0200, David Hildenbrand wrote: On 07.04.25 10:49, Michael S. Tsirkin wrote: On Mon, Apr 07, 2025 at 10:44:21AM +0200, David

Re: [PATCH v9 00/26] Refactor TI K3 R5, DSP and M4 Remoteproc Drivers

2025-04-07 Thread Beleswar Prasad Padhi
On 17/03/25 17:35, Beleswar Padhi wrote: This series refactors a lot of functions & callbacks from ti_k3_dsp_remoteproc.c, ti_k3_r5_remoteproc.c and ti_k3_m4_remoteproc.c drivers. This is a consolidated and final series as part of the refactoring of K3 remoteproc drivers. Below is the breakdown

Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues

2025-04-07 Thread David Hildenbrand
On 07.04.25 10:17, David Hildenbrand wrote: On 07.04.25 09:52, Michael S. Tsirkin wrote: On Fri, Apr 04, 2025 at 05:39:10PM +0200, Halil Pasic wrote: Not perfect, but AFAIKS, not horrible. It is like it is. QEMU does queue exist if the corresponding feature is offered by the device, and that

Re: [PATCH 3/3] arm64: dts: qcom: sdm632-fairphone-fp3: Add AW8898 amplifier

2025-04-07 Thread Konrad Dybcio
On 4/6/25 3:03 PM, Luca Weiss wrote: > Add a node for the amplifier found on Fairphone 3, receiving sound via > I2S from the SoC and being connected to the speaker. > > Signed-off-by: Luca Weiss > --- Reviewed-by: Konrad Dybcio Konrad

[RESEND] virtiofs: add filesystem context source name check

2025-04-07 Thread Xiangsheng Hou
In certain scenarios, for example, during fuzz testing, the source name may be NULL, which could lead to a kernel panic. Therefore, an extra check for the source name should be added. Signed-off-by: Xiangsheng Hou --- fs/fuse/virtio_fs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/

[PATCH] selftests: mptcp: add comment for getaddrinfo

2025-04-07 Thread zhenwei pi
mptcp_connect.c is a startup tutorial of MPTCP programming, however there is a lack of ai_protocol(IPPROTO_MPTCP) usage. Add comment for getaddrinfo MPTCP support. Signed-off-by: zhenwei pi Signed-off-by: zhenwei pi --- tools/testing/selftests/net/mptcp/mptcp_connect.c | 12 1 file

Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues

2025-04-07 Thread David Hildenbrand
On 07.04.25 09:52, Michael S. Tsirkin wrote: On Fri, Apr 04, 2025 at 05:39:10PM +0200, Halil Pasic wrote: Not perfect, but AFAIKS, not horrible. It is like it is. QEMU does queue exist if the corresponding feature is offered by the device, and that is what we have to live with. I don't thin

Re: [PATCH v3] remoteproc: imx_dsp_rproc: Add support for DSP-specific features

2025-04-07 Thread Iuliana Prodan
Hi Frank, On 4/3/2025 10:12 PM, Frank Li wrote: On Thu, Apr 03, 2025 at 01:01:24PM +0300, Iuliana Prodan (OSS) wrote: From: Iuliana Prodan subject: remoteproc: imx_dsp_rproc: add handle_rsc callback to handle DSP-specific features Some DSP firmware requires a FW_READY signal before proceed

Re: [PATCH v3 0/6] KVM: guest_memfd: support for uffd minor

2025-04-07 Thread Nikita Kalyazin
On 04/04/2025 18:12, Liam R. Howlett wrote: +To authors of v7 series referenced in [1] * Nikita Kalyazin [250404 11:44]: This series is built on top of the Fuad's v7 "mapping guest_memfd backed memory at the host" [1]. I didn't see their addresses in the to/cc, so I added them to my respo

[PATCH v2 31/32] tools/nolibc: implement width padding in printf()

2025-04-07 Thread Thomas Weißschuh
printf can pad each argument to a certain width. Implement this for compatibility with the kselftest harness. Currently only padding with spaces is supported. Signed-off-by: Thomas Weißschuh Acked-by: Willy Tarreau --- tools/include/nolibc/stdio.h | 17 - tools/t

[PATCH RESEND] kunit: qemu_configs: SH: Respect kunit cmdline

2025-04-07 Thread Thomas Weißschuh
The default SH kunit configuration sets CONFIG_CMDLINE_OVERWRITE which completely disregards the cmdline passed from the bootloader/QEMU in favor of the builtin CONFIG_CMDLINE. However the kunit tool needs to pass arguments to the in-kernel kunit core, for filters and other runtime parameters. Ena

Re:[PATCH v2] selftests/bpf: close the file descriptor to avoid resource leaks

2025-04-07 Thread Malaya Kumar Rout
Static Analyis for bench_htab_mem.c with cppcheck:error tools/testing/selftests/bpf/benchs/bench_htab_mem.c:284:3: error: Resource leak: fd [resourceLeak] tools/testing/selftests/bpf/prog_tests/sk_assign.c:41:3: error: Resource leak: tc [resourceLeak] fix the issue by closing the file descriptor

Re: [PATCH 0/2] Some small preparations around CAMSS D-PHY / C-PHY support

2025-04-07 Thread Bryan O'Donoghue
On 17/03/2025 07:45, Luca Weiss wrote: On Wed Feb 26, 2025 at 3:47 PM CET, Bryan O'Donoghue wrote: On 26/02/2025 14:13, Luca Weiss wrote: Hi all, On Mon Dec 9, 2024 at 1:01 PM CET, Luca Weiss wrote: Since the hardware blocks on the SoCs generally support both D-PHY and C-PHY standards for cam

Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues

2025-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2025 at 11:11:34AM +0200, David Hildenbrand wrote: > On 07.04.25 10:58, Michael S. Tsirkin wrote: > > On Mon, Apr 07, 2025 at 10:54:00AM +0200, David Hildenbrand wrote: > > > On 07.04.25 10:49, Michael S. Tsirkin wrote: > > > > On Mon, Apr 07, 2025 at 10:44:21AM +0200, David Hildenb

[PATCH] rpmsg: Use strscpy() instead of strscpy_pad()

2025-04-07 Thread Thorsten Blum
kzalloc() already zero-initializes the destination buffer, making strscpy() sufficient for safely copying the name. The additional NUL- padding performed by strscpy_pad() is unnecessary. The size parameter is optional, and strscpy() automatically determines the size of the destination buffer using

Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues

2025-04-07 Thread David Hildenbrand
On 07.04.25 10:44, Michael S. Tsirkin wrote: Wow great job digging through all these hypervisors! There is more ... :( aloith: https://github.com/google/alioth/blob/main/alioth/src/virtio/dev/balloon.rs It uses the incremental vq index assignment like QEMU. impl VirtioMio for Balloon {

Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues

2025-04-07 Thread David Hildenbrand
On 07.04.25 10:58, Michael S. Tsirkin wrote: On Mon, Apr 07, 2025 at 10:54:00AM +0200, David Hildenbrand wrote: On 07.04.25 10:49, Michael S. Tsirkin wrote: On Mon, Apr 07, 2025 at 10:44:21AM +0200, David Hildenbrand wrote: Whoever adds new feat_X *must be aware* about all previous feature

Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues

2025-04-07 Thread David Hildenbrand
On 07.04.25 10:54, Michael S. Tsirkin wrote: On Mon, Apr 07, 2025 at 09:18:21AM +0200, David Hildenbrand wrote: Now I am beginning to think we should leave the spec alone and fix the drivers ... Ugh We could always say that starting with feature X, queue indexes are fixed again. E.g., VIR

Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues

2025-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2025 at 10:54:00AM +0200, David Hildenbrand wrote: > On 07.04.25 10:49, Michael S. Tsirkin wrote: > > On Mon, Apr 07, 2025 at 10:44:21AM +0200, David Hildenbrand wrote: > > > > > > > > > > > > > > > > > Whoever adds new feat_X *must be aware* about all previous features, > > > >

  1   2   >