Re: [PATCH 6.13 00/23] 6.13.10-rc1 review

2025-04-04 Thread Naresh Kamboju
On Thu, 3 Apr 2025 at 20:56, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 6.13.10 release. > There are 23 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Resp

Re: [REGRESSION] Massive virtio-net throughput drop in guest VM with Linux 6.8+

2025-04-04 Thread Markus Fohrer
Am Samstag, dem 05.04.2025 um 00:05 +0200 schrieb Ilya Maximets: > On 4/4/25 5:13 PM, Willem de Bruijn wrote: > > > Markus Fohrer wrote: > > > > > Am Freitag, dem 04.04.2025 um 10:52 +0200 schrieb Markus Fohrer: > > > > > > > Am Freitag, dem 04.04.2025 um 04:29 -0400 schrieb Michael S. Tsirkin:

Re: [PATCH] selftests/bpf: close the file descriptor to avoid resource leaks

2025-04-04 Thread malaya kumar rout
On Fri, Apr 4, 2025 at 9:22 PM Andrii Nakryiko wrote: > > On Sun, Mar 23, 2025 at 11:43 PM Malaya Kumar Rout > wrote: > > > > Static Analyis for bench_htab_mem.c with cppcheck:error > > tools/testing/selftests/bpf/benchs/bench_htab_mem.c:284:3: > > error: Resource leak: fd [resourceLeak] > > tool

Re: [RFC PATCH 13/39] KVM: guest_memfd: Make guest mem use guest mem inodes instead of anonymous inodes

2025-04-04 Thread Yan Zhao
Hi Ackerley, Not sure if below nits have been resolved in your latest code. I came across them and felt it's better to report them anyway. Apologies for any redundancy if you've already addressed them. On Tue, Sep 10, 2024 at 11:43:44PM +, Ackerley Tng wrote: > +static void kvm_gmem_init_mou

[PATCH 2/4] x86/sgx: Change counter sgx_nr_free_pages -> sgx_nr_used_pages

2025-04-04 Thread Elena Reshetova
sgx_nr_free_pages is an atomic that is used to keep track of free EPC pages and detect whenever page reclaiming should start. Since successful execution of ENCLS[EUPDATESVN] requires empty EPC and a fast way of checking for this, change this variable around to indicate number of used pages instead.

[PATCH v4 0/7] Input: synaptics-rmi4 - add quirks for third party touchscreen controllers

2025-04-04 Thread David Heidelberg via B4 Relay
With the growing popularity of running upstream Linux on mobile devices, we're beginning to run into more and more edgecases. The OnePlus 6 is a fairly well supported 2018 era smartphone, selling over a million units in it's first 22 days. With this level of popularity, it's almost inevitable that

Re: [PATCH v2 5/5] KVM: selftests: test userfaultfd minor for guest_memfd

2025-04-04 Thread James Houghton
On Wed, Apr 2, 2025 at 9:08 AM Nikita Kalyazin wrote: > > The test demonstrates that a minor userfaultfd event in guest_memfd can > be resolved via a memcpy followed by a UFFDIO_CONTINUE ioctl. > > Signed-off-by: Nikita Kalyazin > --- > .../testing/selftests/kvm/guest_memfd_test.c | 94

[PATCH net-next v24 05/23] ovpn: introduce the ovpn_peer object

2025-04-04 Thread Antonio Quartulli
An ovpn_peer object holds the whole status of a remote peer (regardless whether it is a server or a client). This includes status for crypto, tx/rx buffers, napi, etc. Only support for one peer is introduced (P2P mode). Multi peer support is introduced with a later patch. Along with the ovpn_pee

Re: [PATCH 05/10] cgroup/cpuset: Don't allow creation of local partition over a remote one

2025-04-04 Thread Michal Koutný
On Sun, Mar 30, 2025 at 05:52:43PM -0400, Waiman Long wrote: > Currently, we don't allow the creation of a remote partition underneath > another local or remote partition. However, it is currently possible to > create a new local partition with an existing remote partition underneath > it if top_

[PATCH v3 7/9] vhost-scsi: log control queue write descriptors

2025-04-04 Thread Dongli Zhang
Log write descriptors for the control queue, leveraging vhost_scsi_get_desc() and vhost_get_vq_desc() to retrieve the array of write descriptors to obtain the log buffer. For Task Management Requests, similar to the I/O queue, store the log buffer during the submission path and log it in the compl

[PATCH v2 06/12] rcutorture: Pull rcu_torture_updown() loop body into new function

2025-04-04 Thread Paul E. McKenney
This is strictly a code-movement commit, pulling that part of the rcu_torture_updown() function's loop body that processes one rcu_torture_one_read_state_updown structure into a new rcu_torture_updown_one() function. The checks for the end of the torture test and the current structure being in use

Re: [PATCH net-next v2 0/4] virtio_net: Fixes and improvements

2025-04-04 Thread Michael S. Tsirkin
On Fri, Mar 21, 2025 at 03:48:31PM +0900, Akihiko Odaki wrote: > Jason Wang recently proposed an improvement to struct > virtio_net_rss_config: > https://lore.kernel.org/r/CACGkMEud0Ki8p=z299q7b4qedonpydzbvqhhxcnvk_vo-kd...@mail.gmail.com > > This patch series implements it and also fixes a few mi

[PATCH] remoteproc: qcom_wcnss_iris: Add missing put_device() on error in probe

2025-04-04 Thread Dan Carpenter
The device_del() call matches with the device_add() but we also need to call put_device() to trigger the qcom_iris_release(). Fixes: 1fcef985c8bd ("remoteproc: qcom: wcnss: Fix race with iris probe") Signed-off-by: Dan Carpenter --- This patch is based on static analysis and has not been tested.

Re: [REGRESSION] Massive virtio-net throughput drop in guest VM with Linux 6.8+

2025-04-04 Thread Markus Fohrer
Am Freitag, dem 04.04.2025 um 04:29 -0400 schrieb Michael S. Tsirkin: > On Fri, Apr 04, 2025 at 10:16:55AM +0200, Markus Fohrer wrote: > > Am Donnerstag, dem 03.04.2025 um 09:04 -0400 schrieb Michael S. > > Tsirkin: > > > On Wed, Apr 02, 2025 at 11:12:07PM +0200, Markus Fohrer wrote: > > > > Hi, >

[PATCH net v3 3/3] ieee802154: Remove WARN_ON() in cfg802154_pernet_exit()

2025-04-04 Thread Ivan Abramov
There's no need to call WARN_ON() in cfg802154_pernet_exit(), since every point of failure in cfg802154_switch_netns() is covered with WARN_ON(), so remove it. Found by Linux Verification Center (linuxtesting.org) with Syzkaller. Fixes: 66e5c2672cd1 ("ieee802154: add netns support") Reviewed-by:

[PATCH 08/10] kunit: add module description for backtrace suppression test

2025-04-04 Thread Arnd Bergmann
From: Arnd Bergmann The module was added but has no description: WARNING: modpost: missing MODULE_DESCRIPTION() in lib/kunit/backtrace-suppression-test.o Fixes: ebf1c420422a ("kunit: add test cases for backtrace warning suppression") Signed-off-by: Arnd Bergmann --- lib/kunit/backtrace-suppr

[PATCH] selftests/futex: futex_waitv wouldblock test should fail

2025-04-04 Thread Edward Liaw
Testcase should fail if -EWOULDBLOCK is not returned when expected value differs from actual value from the waiter. Fixes: 9d57f7c79748920636f8293d2f01192d702fe390 ("selftests: futex: Test sys_futex_waitv() wouldblock") Signed-off-by: Edward Liaw --- .../testing/selftests/futex/functional/futex

Re: [REGRESSION] Massive virtio-net throughput drop in guest VM with Linux 6.8+

2025-04-04 Thread Ilya Maximets
On 4/4/25 5:13 PM, Willem de Bruijn wrote: > Markus Fohrer wrote: >> Am Freitag, dem 04.04.2025 um 10:52 +0200 schrieb Markus Fohrer: >>> Am Freitag, dem 04.04.2025 um 04:29 -0400 schrieb Michael S. Tsirkin: On Fri, Apr 04, 2025 at 10:16:55AM +0200, Markus Fohrer wrote: > Am Donnerstag, de

Re: [PATCH v16 04/15] dt-bindings: pci: pci-msi: Add support for PCI Endpoint msi-map

2025-04-04 Thread Rob Herring
On Fri, Apr 04, 2025 at 04:33:00PM -0400, Frank Li wrote: > On Fri, Apr 04, 2025 at 03:11:40PM -0500, Rob Herring wrote: > > On Fri, Apr 04, 2025 at 03:01:05PM -0400, Frank Li wrote: > > > Document the use of msi-map for PCI Endpoint (EP) controllers, which can > > > use MSI as a doorbell mechanism

[PATCH 2/3] clk: qcom: Add video clock controller driver for SM6350

2025-04-04 Thread Luca Weiss
From: Konrad Dybcio Add support for the video clock controller found on SM6350 based devices. Signed-off-by: Konrad Dybcio Co-developed-by: Luca Weiss Signed-off-by: Luca Weiss --- drivers/clk/qcom/Kconfig | 9 + drivers/clk/qcom/Makefile | 1 + drivers/clk/qcom/videocc-

[PATCH 0/7] irqbypass: Cleanups and a perf improvement

2025-04-04 Thread Sean Christopherson
The two primary goals of this series are to make the irqbypass concept easier to understand, and to address the terrible performance that can result from using a list to track connections. For the first goal, track the producer/consumer "tokens" as eventfd context pointers instead of opaque "void

[PATCH 5/7] irqbypass: Use paired consumer/producer to disconnect during unregister

2025-04-04 Thread Sean Christopherson
Use the paired consumer/producer information to disconnect IRQ bypass producers/consumers in O(1) time (ignoring the cost of __disconnect()). Signed-off-by: Sean Christopherson --- virt/lib/irqbypass.c | 50 +++- 1 file changed, 8 insertions(+), 42 deletio

[PATCH 7/7] irqbypass: Use xarray to track producers and consumers

2025-04-04 Thread Sean Christopherson
Track IRQ bypass produsers and consumers using an xarray to avoid the O(2n) insertion time associated with walking a list to check for duplicate entries, and to search for an partner. At low (tens or few hundreds) total producer/consumer counts, using a list is faster due to the need to allocate b

[PATCH 6/7] irqbypass: Use guard(mutex) in lieu of manual lock+unlock

2025-04-04 Thread Sean Christopherson
Use guard(mutex) to clean up irqbypass's error handling. Signed-off-by: Sean Christopherson --- virt/lib/irqbypass.c | 38 ++ 1 file changed, 10 insertions(+), 28 deletions(-) diff --git a/virt/lib/irqbypass.c b/virt/lib/irqbypass.c index 6d68a0f71dd9..261ef7

[PATCH 4/7] irqbypass: Explicitly track producer and consumer bindings

2025-04-04 Thread Sean Christopherson
Explicitly track IRQ bypass producer:consumer bindings. This will allow making removal an O(1) operation; searching through the list to find information that is trivially tracked (and useful for debug) is wasteful. Signed-off-by: Sean Christopherson --- include/linux/irqbypass.h | 5 + virt

[PATCH 3/7] irqbypass: Take ownership of producer/consumer token tracking

2025-04-04 Thread Sean Christopherson
Move ownership of IRQ bypass token tracking into irqbypass.ko, and explicitly require callers to pass an eventfd_ctx structure instead of a completely opaque token. Relying on producers and consumers to set the token appropriately is error prone, and hiding the fact that the token must be an event

[PATCH 2/7] irqbypass: Drop superfluous might_sleep() annotations

2025-04-04 Thread Sean Christopherson
Drop superfluous might_sleep() annotations from irqbypass, mutex_lock() provides all of the necessary tracking. Signed-off-by: Sean Christopherson --- virt/lib/irqbypass.c | 8 1 file changed, 8 deletions(-) diff --git a/virt/lib/irqbypass.c b/virt/lib/irqbypass.c index 080c706f3b01..2

[PATCH 1/7] irqbypass: Drop pointless and misleading THIS_MODULE get/put

2025-04-04 Thread Sean Christopherson
Drop irqbypass.ko's superfluous and misleading get/put calls on THIS_MODULE. A module taking a reference to itself is useless; no amount of checks will prevent doom and destruction if the caller hasn't already guaranteed the liveliness of the module (this goes for any module). E.g. if try_module_

Re: [PATCH] remoteproc: imx_rproc: Add mutex protection for workqueue

2025-04-04 Thread Peng Fan
On Mon, Mar 31, 2025 at 07:22:45PM +0800, Peng Fan (OSS) wrote: >From: Peng Fan > >Same as >commit 47e6ab07018e ("remoteproc: imx_dsp_rproc: Add mutex >protection for workqueue") and commit 35bdafda40cc ("remoteproc: >stm32_rproc: Add mutex protection for workqueue"), imx_rproc driver >also has si

Re: [PATCH v3 3/3] openrisc: Add cacheinfo support

2025-04-04 Thread kernel test robot
Hi Sahil, kernel test robot noticed the following build warnings: [auto build test WARNING on ea1413e5b53a8dd4fa7675edb23cdf828bbdce1e] url: https://github.com/intel-lab-lkp/linux/commits/Sahil-Siddiq/openrisc-Refactor-struct-cpuinfo_or1k-to-reduce-duplication/20250324-035738 base: ea1413e

Re: [PATCH net-next v24 08/23] ovpn: implement basic RX path (UDP)

2025-04-04 Thread Antonio Quartulli
On 01/04/2025 11:47, Sabrina Dubroca wrote: 2025-03-18, 02:40:43 +0100, Antonio Quartulli wrote: diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c index 024458ef163c9e24dfb37aea2690b2030f6a0fbc..b30175e34230d3dbf5d253838df894f0625c705c 100644 --- a/net/ipv6/udp.c +++ b/net/ipv6/udp.c @@ -1933,6 +19

Re: [PATCH v16 04/15] dt-bindings: pci: pci-msi: Add support for PCI Endpoint msi-map

2025-04-04 Thread Frank Li
On Fri, Apr 04, 2025 at 03:11:40PM -0500, Rob Herring wrote: > On Fri, Apr 04, 2025 at 03:01:05PM -0400, Frank Li wrote: > > Document the use of msi-map for PCI Endpoint (EP) controllers, which can > > use MSI as a doorbell mechanism. Each EP controller can support up to 8 > > physical functions an

[PATCH 0/4] Enable automatic SVN updates for SGX enclaves

2025-04-04 Thread Elena Reshetova
Background -- In case an SGX vulnerability is discovered and TCB recovery for SGX is triggered, Intel specifies a process that must be followed for a given vulnerability. Steps to mitigate can vary based on vulnerability type, affected components, etc. In some cases, a vulnerability can be

Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile

2025-04-04 Thread Stefan Metzmacher
Am 20.03.25 um 11:46 schrieb Pavel Begunkov: On 3/19/25 19:15, Stefan Metzmacher wrote: Am 19.03.25 um 19:37 schrieb Jens Axboe: On 3/19/25 11:45 AM, Joe Damato wrote: On Wed, Mar 19, 2025 at 11:20:50AM -0600, Jens Axboe wrote: ... My argument would be the same as for other features - if you

Re: [REGRESSION] Massive virtio-net throughput drop in guest VM with Linux 6.8+

2025-04-04 Thread Markus Fohrer
Am Freitag, dem 04.04.2025 um 11:13 -0400 schrieb Willem de Bruijn: > Markus Fohrer wrote: > > Am Freitag, dem 04.04.2025 um 10:52 +0200 schrieb Markus Fohrer: > > > Am Freitag, dem 04.04.2025 um 04:29 -0400 schrieb Michael S. > > > Tsirkin: > > > > On Fri, Apr 04, 2025 at 10:16:55AM +0200, Markus

Re: [PATCH v16 04/15] dt-bindings: pci: pci-msi: Add support for PCI Endpoint msi-map

2025-04-04 Thread Rob Herring
On Fri, Apr 04, 2025 at 03:01:05PM -0400, Frank Li wrote: > Document the use of msi-map for PCI Endpoint (EP) controllers, which can > use MSI as a doorbell mechanism. Each EP controller can support up to 8 > physical functions and 65,536 virtual functions. > > Define how to construct device IDs u

Re: [PATCH net-next v24 07/23] ovpn: implement basic TX path (UDP)

2025-04-04 Thread Antonio Quartulli
On 01/04/2025 15:49, Sabrina Dubroca wrote: 2025-03-18, 02:40:42 +0100, Antonio Quartulli wrote: +static int ovpn_udp_output(struct ovpn_peer *peer, struct dst_cache *cache, + struct sock *sk, struct sk_buff *skb) +{ + struct ovpn_bind *bind; + int ret; + +

Re: [PATCH v4 1/7] dt-bindings: input: syna,rmi4: Document syna,rmi4-s3706b-i2c

2025-04-04 Thread Krzysztof Kozlowski
On Wed, Apr 02, 2025 at 08:44:52PM +0200, David Heidelberg wrote: > Mostly irrelevant for authentic Synaptics touchscreens, but very important > for applying workarounds to cheap TS knockoffs. > > These knockoffs work well with the downstream driver, and since the user > has no way to distinguish

Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues

2025-04-04 Thread Cornelia Huck
On Wed, Apr 02 2025, David Hildenbrand wrote: > If we finds a vq without a name in our input array in > virtio_ccw_find_vqs(), we treat it as "non-existing" and set the vq pointer > to NULL; we will not call virtio_ccw_setup_vq() to allocate/setup a vq. > > Consequently, we create only a queue if

Re: [PATCH v2 1/2] memcg: Don't generate low/min events if either low/min or elow/emin is 0

2025-04-04 Thread Johannes Weiner
On Fri, Apr 04, 2025 at 02:55:35PM -0400, Waiman Long wrote: > On 4/4/25 2:13 PM, Johannes Weiner wrote: > > * Waiman points out that the weirdness is seeing low events without > >having a low configured. Eh, this isn't really true with recursive > >propagation; you may or may not have an e

Re: [REGRESSION] Massive virtio-net throughput drop in guest VM with Linux 6.8+

2025-04-04 Thread Markus Fohrer
Am Donnerstag, dem 03.04.2025 um 17:06 -0400 schrieb Michael S. Tsirkin: > On Thu, Apr 03, 2025 at 10:07:12PM +0200, Markus Fohrer wrote: > > Am Donnerstag, dem 03.04.2025 um 10:03 -0400 schrieb Michael S. > > Tsirkin: > > > On Thu, Apr 03, 2025 at 03:51:01PM +0200, Markus Fohrer wrote: > > > > Am

Re: [PATCH 2/3] ieee802154: Avoid calling WARN_ON() on -ENOMEM in cfg802154_switch_netns()

2025-04-04 Thread Ivan Abramov
On Thu, 27 Mar 2025 19:30:02 -0700, Kuniyuki Iwashima wrote: > From: Ivan Abramov > Date: Fri, 28 Mar 2025 04:04:26 +0300 >> It's pointless to call WARN_ON() in case of an allocation failure in >> dev_change_net_namespace() and device_rename(), since it only leads to >> useless splats caused by de

Re: [PATCH] arm64: dts: qcom: sm6350: add APR and some audio-related services

2025-04-04 Thread Dmitry Baryshkov
On Fri, Mar 21, 2025 at 09:12:57AM +0100, Luca Weiss wrote: > Add the APR node and its associated services required for audio on > the SM6350 SoC. > > Signed-off-by: Luca Weiss > --- > arch/arm64/boot/dts/qcom/sm6350.dtsi | 59 > > 1 file changed, 59 inserti

[PATCH v2 2/5] KVM: guest_memfd: add kvm_gmem_vma_is_gmem

2025-04-04 Thread Nikita Kalyazin
It will be used to distinguish the vma type in userfaultfd code. Signed-off-by: Nikita Kalyazin --- virt/kvm/guest_memfd.c | 5 + virt/kvm/kvm_mm.h | 1 + 2 files changed, 6 insertions(+) diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c index fbf89e643add..26b1734b9623 1006

Re: [PATCH V2] remoteproc: core: Clear table_sz when rproc_shutdown

2025-04-04 Thread Mathieu Poirier
On Sat, Mar 29, 2025 at 08:56:29PM +0800, Peng Fan wrote: > On Fri, Mar 28, 2025 at 08:14:41AM -0600, Mathieu Poirier wrote: > >On Fri, Mar 28, 2025 at 12:50:12PM +0800, Peng Fan wrote: > >> On Thu, Mar 27, 2025 at 11:46:33AM -0600, Mathieu Poirier wrote: > >> >Hi, > >> > > >> >On Wed, Mar 26, 2025

[PATCH] firmware: cs_dsp: Ensure cs_dsp_load[_coeff]() returns 0 on success

2025-04-04 Thread Richard Fitzgerald
Set ret = 0 on successful completion of the processing loop in cs_dsp_load() and cs_dsp_load_coeff() to ensure that the function returns 0 on success. All normal firmware files will have at least one data block, and processing this block will set ret == 0, from the result of either regmap_raw_writ

Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile

2025-04-04 Thread Stefan Metzmacher
Am 19.03.25 um 19:37 schrieb Jens Axboe: On 3/19/25 11:45 AM, Joe Damato wrote: On Wed, Mar 19, 2025 at 11:20:50AM -0600, Jens Axboe wrote: On 3/19/25 11:04 AM, Joe Damato wrote: On Wed, Mar 19, 2025 at 10:07:27AM -0600, Jens Axboe wrote: On 3/19/25 9:32 AM, Joe Damato wrote: On Wed, Mar 19,

Re: [RFC PATCH 1/2] time/timekeeping: Fix possible inconsistencies in _COARSE clockids

2025-04-04 Thread Thomas Gleixner
On Thu, Mar 20 2025 at 19:01, John Stultz wrote: > On Sun, Mar 16, 2025 at 9:56 PM Thomas Gleixner wrote: >> #define TK_CLEAR_NTP(1 << 0) >> #define TK_CLOCK_WAS_SET(1 << 1) >> >> So it clears NTP instead. Not really what you want either. :) > > Hey Thomas, >Sorry for the s

[PATCH v6 5/5] arm64: dts: Add dsp rproc related mem regions

2025-04-04 Thread Daniel Baluta
With imx8mp-evk board we are now configuring 'dsp' node for rproc usage, so add rproc specific memory regions. Also, enable dsp node because it is ready to be used. Reviewed-by: Ahmad Fatoum Reviewed-by: Iuliana Prodan Reviewed-by: Peng Fan Signed-off-by: Daniel Baluta --- arch/arm64/boot/dt

Re: [PATCH v2] vsock/virtio: Remove queued_replies pushback logic

2025-04-04 Thread Michael S. Tsirkin
On Wed, Apr 02, 2025 at 12:14:24PM -0400, Stefan Hajnoczi wrote: > On Tue, Apr 01, 2025 at 08:13:49PM +, Alexander Graf wrote: > > Ever since the introduction of the virtio vsock driver, it included > > pushback logic that blocks it from taking any new RX packets until the > > TX queue backlog

Re: [PATCH v2 1/2] time/timekeeping: Fix possible inconsistencies in _COARSE clockids

2025-04-04 Thread Miroslav Lichvar
On Thu, Mar 27, 2025 at 04:42:49PM +0100, Miroslav Lichvar wrote: > Maybe I could simply patch the kernel to force a small clock > multiplier to increase the rate at which the error accumulates. I tried that and it indeed makes the issue clearly visible. The COARSE fix makes the clock less stable.

[PATCH v3 4/6] KVM: guest_memfd: add support for userfaultfd minor

2025-04-04 Thread Nikita Kalyazin
Add support for sending a pagefault event if userfaultfd is registered. Only page minor event is currently supported. Signed-off-by: Nikita Kalyazin --- virt/kvm/guest_memfd.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c index fb

Re: [PATCH] compiler.h: Avoid the usage of __typeof_unqual__() when __GENKSYMS__ is defined

2025-04-04 Thread Masahiro Yamada
On Fri, Apr 4, 2025 at 11:37 PM Uros Bizjak wrote: > > On Fri, Apr 4, 2025 at 4:06 PM Masahiro Yamada wrote: > > > > > > Current version of genksyms doesn't know anything about > > > > > __typeof_unqual__() > > > > > operator. Avoid the usage of __typeof_unqual__() with genksyms to > > > > > p

Re: [REGRESSION] Massive virtio-net throughput drop in guest VM with Linux 6.8+

2025-04-04 Thread Willem de Bruijn
Markus Fohrer wrote: > Am Donnerstag, dem 03.04.2025 um 17:06 -0400 schrieb Michael S. > Tsirkin: > > On Thu, Apr 03, 2025 at 10:07:12PM +0200, Markus Fohrer wrote: > > > Am Donnerstag, dem 03.04.2025 um 10:03 -0400 schrieb Michael S. > > > Tsirkin: > > > > On Thu, Apr 03, 2025 at 03:51:01PM +0200,

[GIT PULL] virtio: features, fixes, cleanups

2025-04-04 Thread Michael S. Tsirkin
The following changes since commit d082ecbc71e9e0bf49883ee4afd435a77a5101b6: Linux 6.14-rc4 (2025-02-23 12:32:57 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to 9d8960672d63db4b3b04542

Re: [PATCH v6 0/4] Add virtio_rtc module

2025-04-04 Thread Lei Yang
On Tue, Mar 18, 2025 at 6:14 PM Peter Hilber wrote: > > On Tue, Mar 18, 2025 at 10:04:07AM +0800, Lei Yang wrote: > > QE tested this series of patches v6 with virtio-net regression tests, > > everything works fine. > > > > Tested-by: Lei Yang > > > > Hi Lei, > Hi Peter > thanks for the reply! Ho

Re: [PATCH bpf-next] selftests/bpf: Sanitize pointer prior fclose()

2025-04-04 Thread Jiri Olsa
On Tue, Mar 18, 2025 at 09:16:47AM +0100, Björn Töpel wrote: > From: Björn Töpel > > There are scenarios where env.{sub,}test_state->stdout_saved, can be > NULL, e.g. sometimes when the watchdog timeout kicks in, or if the > open_memstream syscall is not available. > > Avoid crashing test_progs

Re: [PATCH bpf-next v3 1/3] bpf, sockmap: avoid using sk_socket after free when sending

2025-04-04 Thread Jiayuan Chen
2025/3/20 07:02, "Cong Wang" wrote: > > On Mon, Mar 17, 2025 at 05:22:54PM +0800, Jiayuan Chen wrote: > > > > > The sk->sk_socket is not locked or referenced, and during the call to > > > > Hm? We should have a reference in socket map, whether directly or > > indirectly, right? When we add

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-04-04 Thread Michael S. Tsirkin
On Wed, Mar 19, 2025 at 06:13:08PM +0100, Halil Pasic wrote: > On Wed, 19 Mar 2025 11:00:06 -0400 > "Michael S. Tsirkin" wrote: > > > > > I was mistaken in my earlier reply - I had missed this > > > > virtio_console_resize definition in the spec.  So indeed there's a > > > > discrepancy in Linux

Re: [PATCH net-next v2] vsock/test: Add test for null ptr deref when transport changes

2025-04-04 Thread Stefano Garzarella
On Fri, Mar 14, 2025 at 10:27:33AM +0100, Luigi Leonardi wrote: Add a new test to ensure that when the transport changes a null pointer dereference does not occur[1]. I'd add something like this: "... does not occur. The bug was reported upstream [1] and fixed with commit 2cb7c756f605 ("vsock/

[PATCH v16 15/15] arm64: dts: imx95: Add msi-map for pci-ep device

2025-04-04 Thread Frank Li
Add msi-map for pci-ep device. Signed-off-by: Frank Li --- change from v14 to v16 - none change from v13 to v14 - new patch --- arch/arm64/boot/dts/freescale/imx95.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/freescale/imx95.dtsi b/arch/arm64/boot/dts/freescale/

[PATCH v16 13/15] pci: imx6: Add helper function imx_pcie_add_lut_by_rid()

2025-04-04 Thread Frank Li
Add helper function imx_pcie_add_lut_by_rid(), which will be used for Endpoint mode in the future. No functional change. Signed-off-by: Frank Li --- change from v14 to v16 - none change from v13 to v14 - new patch --- drivers/pci/controller/dwc/pci-imx6.c | 17 ++--- 1 file changed,

[PATCH v16 14/15] pci: imx6: Add LUT setting for MSI/IOMMU in Endpoint mode

2025-04-04 Thread Frank Li
Support only one physical function, so call imx_pcie_add_lut_by_rid(0) to add a single LUT entry when operating in EP mode. Signed-off-by: Frank Li --- change from v14 to v16 - none change from v13 to v14 - new patch --- drivers/pci/controller/dwc/pci-imx6.c | 8 +++- 1 file changed, 7 inse

Re: [PATCH v8 5/7] rust: str: add radix prefixed integer parsing functions

2025-04-04 Thread Andreas Hindborg
"Miguel Ojeda" writes: > On Thu, Feb 27, 2025 at 3:39 PM Andreas Hindborg > wrote: >> >> +// SAFETY: We checked that `val` will fit in `Self` >> above. >> +let val: Self = unsafe { >> val.try_into().unwrap_unchecked() }; > > This is wrong -- `val` can b

[PATCH v16 08/15] PCI: endpoint: pci-ep-msi: Add MSI address/data pair mutable check

2025-04-04 Thread Frank Li
Some MSI controller change address/data pair when irq_set_affinity(). Current PCI endpoint can't support this type MSI controller. So add flag MSI_FLAG_MUTABLE in include/linux/msi.h and check it when allocate doorbell. Signed-off-by: Frank Li --- change from v14 to v16 - none change from v13 t

[PATCH v16 12/15] selftests: pci_endpoint: Add doorbell test case

2025-04-04 Thread Frank Li
Add doorbell test case. Signed-off-by: Frank Li --- change from v14 to v16 - Add set IRQ type change from v13 to v14 - merge to selftests framework --- .../selftests/pci_endpoint/pci_endpoint_test.c | 28 ++ 1 file changed, 28 insertions(+) diff --git a/tools/testing/se

[PATCH 4/4] sysctl: Close test ctl_headers with a for loop

2025-04-04 Thread Joel Granados
As more tests are added, the exit function gets longer than it should be. Condense the un-register calls into a for loop to make it easier to add/remove tests. Signed-off-by: Joel Granados --- lib/test_sysctl.c | 65 +-- 1 file changed, 29 inse

[PATCH v16 11/15] misc: pci_endpoint_test: Add doorbell test case

2025-04-04 Thread Frank Li
Add three registers: PCIE_ENDPOINT_TEST_DB_BAR, PCIE_ENDPOINT_TEST_DB_ADDR, and PCIE_ENDPOINT_TEST_DB_DATA. Trigger the doorbell by writing data from PCI_ENDPOINT_TEST_DB_DATA to the address provided by PCI_ENDPOINT_TEST_DB_OFFSET and wait for endpoint feedback. Add two command to COMMAND_ENABLE_

[PATCH v3 1/2] arm64: Implement arch_stack_walk_reliable

2025-04-04 Thread Song Liu
With proper exception boundary detection, it is possible to implment arch_stack_walk_reliable without sframe. Note that, arch_stack_walk_reliable does not guarantee getting reliable stack in all scenarios. Instead, it can reliably detect when the stack trace is not reliable, which is enough to pro

[PATCH v16 10/15] PCI: endpoint: pci-epf-test: Add doorbell test support

2025-04-04 Thread Frank Li
Add three registers: doorbell_bar, doorbell_addr, and doorbell_data. Use pci_epf_alloc_doorbell() to allocate a doorbell address space. Enable the Root Complex (RC) side driver to trigger pci-epc-test's doorbell callback handler by writing doorbell_data to the mapped doorbell_bar's address space.

[PATCH v16 09/15] PCI: endpoint: Add pci_epf_align_inbound_addr() helper for address alignment

2025-04-04 Thread Frank Li
Introduce the helper function pci_epf_align_inbound_addr() to adjust addresses according to PCI BAR alignment requirements, converting addresses into base and offset values. Signed-off-by: Frank Li --- Change from v15 to v16 - none Change from v14 to v15 - change out address type to dma_addr_t t

[PATCH v16 07/15] PCI: endpoint: Add RC-to-EP doorbell support using platform MSI controller

2025-04-04 Thread Frank Li
Doorbell feature is implemented by mapping the EP's MSI interrupt controller message address to a dedicated BAR in the EPC core. It is the responsibility of the EPF driver to pass the actual message data to be written by the host to the doorbell BAR region through its own logic. Tested-by: Niklas

[PATCH v16 06/15] PCI: endpoint: Set ID and of_node for function driver

2025-04-04 Thread Frank Li
Set device ID as 'vfunc_no << 3 | func_no' and use 'device_set_of_node_from_dev()' to set 'of_node' the same as the EPC parent device. Currently, EPF 'of_node' is NULL, but many functions depend on 'of_node' settings, such as DMA, IOMMU, and MSI. At present, all DMA allocation functions use the EP

[PATCH v16 05/15] irqchip/gic-v3-its: Add support for device tree msi-map and msi-mask

2025-04-04 Thread Frank Li
Some platform devices create child devices dynamically and require the parent device's msi-map to map device IDs to actual sideband information. A typical use case is using ITS as a PCIe Endpoint Controller(EPC)'s doorbell function, where PCI hosts send TLP memory writes to the EP controller. The

Re: [PATCH v2 2/2] x86/sgx: Implement EUPDATESVN and opportunistically call it during first EPC page alloc

2025-04-04 Thread Jarkko Sakkinen
On Wed, Apr 02, 2025 at 01:11:25PM +, Reshetova, Elena wrote: > > > current SGX kernel code does not handle such errors in any other way > > > than notifying that operation failed for other ENCLS leaves. So, I don't > > > see why ENCLS[EUPDATESVN] should be different from existing behaviour? >

[PATCH v16 04/15] dt-bindings: pci: pci-msi: Add support for PCI Endpoint msi-map

2025-04-04 Thread Frank Li
Document the use of msi-map for PCI Endpoint (EP) controllers, which can use MSI as a doorbell mechanism. Each EP controller can support up to 8 physical functions and 65,536 virtual functions. Define how to construct device IDs using function bits [2:0] and virtual function index bits [31:3], ena

Re: [PATCH v4 2/3] openrisc: Introduce new utility functions to flush and invalidate caches

2025-04-04 Thread Sahil Siddiq
Hi, On 3/29/25 3:18 AM, Stafford Horne wrote: On Sat, Mar 29, 2025 at 01:56:31AM +0530, Sahil Siddiq wrote: [...] diff --git a/arch/openrisc/include/asm/cpuinfo.h b/arch/openrisc/include/asm/cpuinfo.h index 82f5d4c06314..e46afbfe9b5a 100644 --- a/arch/openrisc/include/asm/cpuinfo.h +++ b/arch/

Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile

2025-04-04 Thread Jens Axboe
On 3/19/25 5:22 PM, Joe Damato wrote: > Would you be open to the idea that sendfile could be extended to > generate error queue completions if the network socket has > SO_ZEROCOPY set? I thought I was quite clear on my view of SO_ZEROCOPY and its error queue usage, I guess I was not. No I don't th

Re: [PATCH v2 1/2] memcg: Don't generate low/min events if either low/min or elow/emin is 0

2025-04-04 Thread Waiman Long
On 4/4/25 2:13 PM, Johannes Weiner wrote: On Fri, Apr 04, 2025 at 01:25:33PM -0400, Waiman Long wrote: On 4/4/25 1:12 PM, Tejun Heo wrote: Hello, On Thu, Apr 03, 2025 at 09:24:34PM -0400, Waiman Long wrote: ... The simple and naive fix of changing the operator to ">", however, changes the mem

[PATCH v4 3/7] Input: synaptics-rmi4 - f12: use hardcoded values for aftermarket touch ICs

2025-04-04 Thread David Heidelberg via B4 Relay
From: Kaustabh Chakraborty Some replacement displays include third-party touch ICs which are devoid of register descriptors. Create a fake data register descriptor for such ICs and provide hardcoded default values. It isn't possible to reliably determine if the touch IC is original or not, so th

[PATCH v16 03/15] irqchip/gic-v3-its: Set IRQ_DOMAIN_FLAG_MSI_IMMUTABLE for ITS

2025-04-04 Thread Frank Li
Set the IRQ_DOMAIN_FLAG_MSI_IMMUTABLE flag for ITS, as it does not change the address/data pair after setup. Ensure compatibility with MSI users, such as PCIe Endpoint Doorbell, which require the address/data pair to remain unchanged. Enable PCIe endpoints to use ITS for triggering doorbells from

[PATCH v16 02/15] irqdomain: Add IRQ_DOMAIN_FLAG_MSI_IMMUTABLE and irq_domain_is_msi_immutable()

2025-04-04 Thread Frank Li
Add the flag IRQ_DOMAIN_FLAG_MSI_IMMUTABLE and the API function irq_domain_is_msi_immutable() to check if the MSI controller retains an immutable address/data pair during irq_set_affinity(). Ensure compatibility with MSI users like PCIe Endpoint Doorbell, which require the address/data pair to rem

[PATCH v16 00/15] PCI: EP: Add RC-to-EP doorbell with platform MSI controller

2025-04-04 Thread Frank Li
┌┐ ┌───┐ ┌┐ ││ │ │ ││ ││ │ PCI Endpoint │ │ PCI Host │ ││ │ │ │

[PATCH v16 01/15] platform-msi: Add msi_remove_device_irq_domain() in platform_device_msi_free_irqs_all()

2025-04-04 Thread Frank Li
platform_device_msi_init_and_alloc_irqs() performs two tasks: allocating the MSI domain for a platform device, and allocate a number of MSIs in that domain. platform_device_msi_free_irqs_all() only frees the MSIs, and leaves the MSI domain alive. Given that platform_device_msi_init_and_alloc_irqs

Re: [PATCH v2 1/2] memcg: Don't generate low/min events if either low/min or elow/emin is 0

2025-04-04 Thread Waiman Long
On 4/4/25 2:26 PM, Michal Koutný wrote: Hello Waiman. On Thu, Apr 03, 2025 at 09:24:34PM -0400, Waiman Long wrote: 1) memory.low is set to 0, but low events can still be triggered and so the cgroup may have a non-zero low event count. I doubt users are looking for that as they didn'

[PATCH v4 02/38] perf: Skip pmu_ctx based on event_type

2025-04-04 Thread Mingwei Zhang
From: Kan Liang To optimize the cgroup context switch, the perf_event_pmu_context iteration skips the PMUs without cgroup events. A bool cgroup was introduced to indicate the case. It can work, but this way is hard to extend for other cases, e.g. skipping non-passthrough PMUs. It doesn't make sen

Re: [PATCH v2] vsock/virtio: Remove queued_replies pushback logic

2025-04-04 Thread Simon Horman
On Tue, Apr 01, 2025 at 08:13:49PM +, Alexander Graf wrote: > Ever since the introduction of the virtio vsock driver, it included > pushback logic that blocks it from taking any new RX packets until the > TX queue backlog becomes shallower than the virtqueue size. > > This logic works fine whe

[PATCH v2] libnvdimm/labels: Fix divide error in nd_label_data_init()

2025-04-04 Thread Robert Richter
If a faulty CXL memory device returns a broken zero LSA size in its memory device information (Identify Memory Device (Opcode 4000h), CXL spec. 3.1, 8.2.9.9.1.1), a divide error occurs in the libnvdimm driver: Oops: divide error: [#1] PREEMPT SMP NOPTI RIP: 0010:nd_label_data_init+0x10e/0x8

[PATCH v4 21/38] KVM: x86/pmu/vmx: Save/load guest IA32_PERF_GLOBAL_CTRL with vm_exit/entry_ctrl

2025-04-04 Thread Mingwei Zhang
From: Dapeng Mi Intel processor (vmx) provides capability to save/load guest IA32_PERF_GLOBAL_CTRL at vm-exit/vm-entry by setting VM_EXIT_SAVE_IA32_PERF_GLOBAL_CTRL bit in VM-exit-ctrl or VM_ENTRY_LOAD_IA32_PERF_GLOBAL_CTRL bit in VM-entry-ctrl. Mediated vPMU leverages both capabilities to save/

Re: [PATCH net-next v2 0/7] selftests/net: Mixed select()+polling mode for TCP-AO tests

2025-04-04 Thread Dmitry Safonov
On Wed, 26 Mar 2025 at 20:00, Jakub Kicinski wrote: > > On Wed, 26 Mar 2025 19:48:16 + Dmitry Safonov wrote: > > Should I send the potential fix now for -net or wait until the merge > > window closes and send for -net-next? > > I reckon you can send it now, maybe other maintainers will disagre

[PATCH v2 12/12] torture: Add testing of RCU's Rust bindings to torture.sh

2025-04-04 Thread Paul E. McKenney
This commit adds a --do-rcu-rust parameter to torture.sh, which invokes a rust_doctests_kernel kunit run. Note that kunit wants a clean source tree, so this runs "make mrproper", which might come as a surprise to some users. Should there be a --mrproper parameter to torture.sh to make the user ex

[PATCH net v2 0/3] Avoid calling WARN_ON() on allocation failure in cfg802154_switch_netns()

2025-04-04 Thread Ivan Abramov
This series was inspired by Syzkaller report on warning in cfg802154_switch_netns(). WARNING: CPU: 0 PID: 5837 at net/ieee802154/core.c:258 cfg802154_switch_netns+0x3c7/0x3d0 net/ieee802154/core.c:258 Modules linked in: CPU: 0 UID: 0 PID: 5837 Comm: syz-executor125 Not tainted 6.13.0-rc6-syzkall

Re: [PATCH 1/1] virtio_console: fix missing byte order handling for cols and rows

2025-04-04 Thread Michael S. Tsirkin
On Wed, Apr 02, 2025 at 05:26:59PM +0200, Halil Pasic wrote: > On Sat, 22 Mar 2025 01:29:54 +0100 > Halil Pasic wrote: > > > As per virtio spec the fields cols and rows are specified as little > > endian. > [..] > > @Amit: Any feedback? > > > > > Fixes: 8345adbf96fc1 ("virtio: console: Accept

Re: [PATCH v3] remoteproc: imx_dsp_rproc: Add support for DSP-specific features

2025-04-04 Thread Frank Li
On Thu, Apr 03, 2025 at 01:01:24PM +0300, Iuliana Prodan (OSS) wrote: > From: Iuliana Prodan subject: remoteproc: imx_dsp_rproc: add handle_rsc callback to handle DSP-specific features > Some DSP firmware requires a FW_READY signal before proceeding, while > others do not. > Therefore, add supp

Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues

2025-04-04 Thread David Hildenbrand
On 04.04.25 06:36, Halil Pasic wrote: On Thu, 3 Apr 2025 16:28:31 +0200 David Hildenbrand wrote: Sorry I have to have a look at that discussion. Maybe it will answer some my questions. Yes, I think so. Let's fix it without affecting existing setups for now by properly ignoring the non-

[PATCH v3 0/4] Add managed SOFT RESERVE resource handling

2025-04-04 Thread Terry Bowman
Add the ability to manage SOFT RESERVE iomem resources prior to them being added to the iomem resource tree. This allows drivers, such as CXL, to remove any pieces of the SOFT RESERVE resource that intersect with created CXL regions. The current approach of leaving the SOFT RESERVE resources as is

Re: [PATCH v8 3/8] vhost: Add the cgroup related function

2025-04-04 Thread Stefano Garzarella
On Fri, Mar 28, 2025 at 06:02:47PM +0800, Cindy Lu wrote: Add back the previously removed cgroup function to support the kthread nit: Missing . at the end The biggest change for this part is in vhost_attach_cgroups() and vhost_attach_task_to_cgroups(). The old function was remove in nit: s

Re: [PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling it

2025-04-04 Thread Mark Brown
On Thu, Mar 20, 2025 at 04:21:16PM -0600, Nico Pache wrote: > On Thu, Mar 20, 2025 at 1:14 PM Mark Brown wrote: > > On Wed, Mar 19, 2025 at 05:05:39PM -0600, Nico Pache wrote: > > > config FW_CS_DSP_KUNIT_TEST > > > tristate "KUnit tests for Cirrus Logic cs_dsp" if !KUNIT_ALL_TESTS > > > -

Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues

2025-04-04 Thread Christian Borntraeger
Am 02.04.25 um 22:36 schrieb David Hildenbrand: [...]> Fixes: a229989d975e ("virtio: don't allocate vqs when names[i] = NULL") Reported-by: Chandra Merla Cc: Cc: Cornelia Huck Cc: Thomas Huth Cc: Halil Pasic Cc: Eric Farman Cc: Heiko Carstens Cc: Vasily Gorbik Cc: Alexander Gordeev Cc: C

Re: [REGRESSION] Massive virtio-net throughput drop in guest VM with Linux 6.8+

2025-04-04 Thread Michael S. Tsirkin
On Thu, Apr 03, 2025 at 11:24:43PM +0200, Markus Fohrer wrote: > Am Donnerstag, dem 03.04.2025 um 17:06 -0400 schrieb Michael S. > Tsirkin: > > On Thu, Apr 03, 2025 at 10:07:12PM +0200, Markus Fohrer wrote: > > > Am Donnerstag, dem 03.04.2025 um 10:03 -0400 schrieb Michael S. > > > Tsirkin: > > > >

  1   2   >