[PATCH 6/7] irqbypass: Use guard(mutex) in lieu of manual lock+unlock

[Sean Christopherson]

Use guard(mutex) to clean up irqbypass's error handling.

Signed-off-by: Sean Christopherson <sea...@google.com>
---
 virt/lib/irqbypass.c | 38 ++++++++++----------------------------
 1 file changed, 10 insertions(+), 28 deletions(-)

diff --git a/virt/lib/irqbypass.c b/virt/lib/irqbypass.c
index 6d68a0f71dd9..261ef77f6364 100644
--- a/virt/lib/irqbypass.c
+++ b/virt/lib/irqbypass.c
@@ -99,33 +99,25 @@ int irq_bypass_register_producer(struct irq_bypass_producer 
*producer,
        if (WARN_ON_ONCE(producer->token))
                return -EINVAL;
 
-       mutex_lock(&lock);
+       guard(mutex)(&lock);
 
        list_for_each_entry(tmp, &producers, node) {
-               if (tmp->token == eventfd) {
-                       ret = -EBUSY;
-                       goto out_err;
-               }
+               if (tmp->token == eventfd)
+                       return -EBUSY;
        }
 
        list_for_each_entry(consumer, &consumers, node) {
                if (consumer->token == eventfd) {
                        ret = __connect(producer, consumer);
                        if (ret)
-                               goto out_err;
+                               return ret;
                        break;
                }
        }
 
        producer->token = eventfd;
        list_add(&producer->node, &producers);
-
-       mutex_unlock(&lock);
-
        return 0;
-out_err:
-       mutex_unlock(&lock);
-       return ret;
 }
 EXPORT_SYMBOL_GPL(irq_bypass_register_producer);
 
@@ -141,14 +133,13 @@ void irq_bypass_unregister_producer(struct 
irq_bypass_producer *producer)
        if (!producer->token)
                return;
 
-       mutex_lock(&lock);
+       guard(mutex)(&lock);
 
        if (producer->consumer)
                __disconnect(producer, producer->consumer);
 
        producer->token = NULL;
        list_del(&producer->node);
-       mutex_unlock(&lock);
 }
 EXPORT_SYMBOL_GPL(irq_bypass_unregister_producer);
 
@@ -171,33 +162,25 @@ int irq_bypass_register_consumer(struct 
irq_bypass_consumer *consumer,
        if (!consumer->add_producer || !consumer->del_producer)
                return -EINVAL;
 
-       mutex_lock(&lock);
+       guard(mutex)(&lock);
 
        list_for_each_entry(tmp, &consumers, node) {
-               if (tmp->token == eventfd || tmp == consumer) {
-                       ret = -EBUSY;
-                       goto out_err;
-               }
+               if (tmp->token == eventfd || tmp == consumer)
+                       return -EBUSY;
        }
 
        list_for_each_entry(producer, &producers, node) {
                if (producer->token == eventfd) {
                        ret = __connect(producer, consumer);
                        if (ret)
-                               goto out_err;
+                               return ret;
                        break;
                }
        }
 
        consumer->token = eventfd;
        list_add(&consumer->node, &consumers);
-
-       mutex_unlock(&lock);
-
        return 0;
-out_err:
-       mutex_unlock(&lock);
-       return ret;
 }
 EXPORT_SYMBOL_GPL(irq_bypass_register_consumer);
 
@@ -213,13 +196,12 @@ void irq_bypass_unregister_consumer(struct 
irq_bypass_consumer *consumer)
        if (!consumer->token)
                return;
 
-       mutex_lock(&lock);
+       guard(mutex)(&lock);
 
        if (consumer->producer)
                __disconnect(consumer->producer, consumer);
 
        consumer->token = NULL;
        list_del(&consumer->node);
-       mutex_unlock(&lock);
 }
 EXPORT_SYMBOL_GPL(irq_bypass_unregister_consumer);
-- 
2.49.0.504.g3bcea36a83-goog