Re: [PATCH 16/19] dt-bindings: arm: qcom: document QCS8275/QCS8300 SoC and reference board

2024-09-04 Thread Krzysztof Kozlowski
On 05/09/2024 06:42, Jingyi Wang wrote: > > > On 9/4/2024 5:38 PM, Krzysztof Kozlowski wrote: >> On 04/09/2024 10:33, Jingyi Wang wrote: >>> Document the QCS8275/QCS8300 SoC and its reference board QCS8300 RIDE. >>> QCS8300 is an Industrial Safe SoC, while QCS8275 is the Industrial >>> Non-Safe v

Re: [PATCH 02/19] remoteproc: qcom: pas: Add QCS8300 remoteproc support

2024-09-04 Thread Krzysztof Kozlowski
On 05/09/2024 06:30, Jingyi Wang wrote: >>> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c >>> b/drivers/remoteproc/qcom_q6v5_pas.c >>> index ef82835e98a4..f92ccd4921b7 100644 >>> --- a/drivers/remoteproc/qcom_q6v5_pas.c >>> +++ b/drivers/remoteproc/qcom_q6v5_pas.c >>> @@ -1416,6 +1416,9 @@ stati

Re: [PATCH v6 1/2] selftests: Rename sigaltstack to generic signal

2024-09-04 Thread Dev Jain
On 9/4/24 22:35, Shuah Khan wrote: On 9/3/24 22:52, Dev Jain wrote: On 9/4/24 03:14, Shuah Khan wrote: On 8/30/24 10:29, Dev Jain wrote: On 8/27/24 17:16, Dev Jain wrote: On 8/27/24 17:14, Shuah Khan wrote: On 8/22/24 06:14, Dev Jain wrote: Rename sigaltstack to generic signal directory

Re: [PATCH 18/19] arm64: dts: qcom: add initial support for QCS8300 DTSI

2024-09-04 Thread Jingyi Wang
On 9/4/2024 5:41 PM, Krzysztof Kozlowski wrote: > On 04/09/2024 10:33, Jingyi Wang wrote: >> Add initial DTSI for QCS8300 SoC. >> >> This revision brings support for: >> - CPUs with cpu idle >> - interrupt-controller with PDC wakeup support >> - gcc >> - TLMM >> - interconnect >> - qup with uart

Re: [PATCH 17/19] arm64: defconfig: enable clock controller, interconnect and pinctrl for QCS8300

2024-09-04 Thread Jingyi Wang
On 9/4/2024 5:39 PM, Krzysztof Kozlowski wrote: > On 04/09/2024 10:33, Jingyi Wang wrote: >> Enable clock controller, interrconnect and pinctrl for QCS8300. > > NXP QCS8300? What is QCS8300? Which products use it? That's a defconfig > for entire kernel, not your Qualcomm one. > Will describe i

Re: [PATCH 16/19] dt-bindings: arm: qcom: document QCS8275/QCS8300 SoC and reference board

2024-09-04 Thread Jingyi Wang
On 9/4/2024 5:38 PM, Krzysztof Kozlowski wrote: > On 04/09/2024 10:33, Jingyi Wang wrote: >> Document the QCS8275/QCS8300 SoC and its reference board QCS8300 RIDE. >> QCS8300 is an Industrial Safe SoC, while QCS8275 is the Industrial >> Non-Safe version which can share the same SoC dtsi and boar

Re: [PATCH 05/19] phy: qcom-qmp-ufs: Add support for QCS8300

2024-09-04 Thread Jingyi Wang
On 9/4/2024 5:36 PM, Krzysztof Kozlowski wrote: > On 04/09/2024 10:33, Jingyi Wang wrote: >> From: Xin Liu >> >> Add QMP PHY support for QCS8300 which is compatible with SA8775P. >> >> Signed-off-by: Xin Liu >> Signed-off-by: Jingyi Wang >> --- >> drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 3

Re: [PATCH 02/19] remoteproc: qcom: pas: Add QCS8300 remoteproc support

2024-09-04 Thread Jingyi Wang
On 9/4/2024 5:36 PM, Krzysztof Kozlowski wrote: > On 04/09/2024 10:33, Jingyi Wang wrote: >> Add support for PIL loading on ADSP, CDSP and GPDSP on QCS8300 >> platform. >> >> Co-developed-by: Xin Liu >> Signed-off-by: Xin Liu >> Signed-off-by: Jingyi Wang >> --- >> drivers/remoteproc/qcom_q6

Re: [RFC 31/31] objtool, livepatch: Livepatch module generation

2024-09-04 Thread Josh Poimboeuf
On Wed, Sep 04, 2024 at 02:38:14PM -0700, Jeff Johnson wrote: > On 9/2/24 21:00, Josh Poimboeuf wrote: > ... > > diff --git a/scripts/livepatch/module.c b/scripts/livepatch/module.c > > new file mode 100644 > > index ..101cabf6b2f1 > > --- /dev/null > > +++ b/scripts/livepatch/module.c

Re: [RFC 00/31] objtool, livepatch: Livepatch module generation

2024-09-04 Thread Josh Poimboeuf
On Wed, Sep 04, 2024 at 01:59:51PM -0700, Josh Poimboeuf wrote: > On Wed, Sep 04, 2024 at 01:23:55PM -0700, Song Liu wrote: > > [ 7285.260195] livepatch: nothing to patch! This seems to be tripping up on an awful hack I had for silencing modpost warnings. Apparently it doesn't work with your conf

[PATCH] remoteproc:remove redundant dev_err message

2024-09-04 Thread Liu Jing
devm_ioremap_resource already contains error message, so remove the redundant dev_err message Signed-off-by: Liu Jing diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c index 9041a0e07fb2..289d5ce9f7af 100644 --- a/drivers/remoteproc/da8xx_remoteproc.c ++

Re: [PATCH v2 02/19] iommufd/viommu: Add IOMMUFD_OBJ_VIOMMU and IOMMU_VIOMMU_ALLOC ioctl

2024-09-04 Thread Nicolin Chen
On Wed, Sep 04, 2024 at 08:37:07PM -0300, Jason Gunthorpe wrote: > On Wed, Sep 04, 2024 at 10:29:26AM -0700, Nicolin Chen wrote: > > On Wed, Sep 04, 2024 at 01:26:21PM -0300, Jason Gunthorpe wrote: > > > On Sun, Sep 01, 2024 at 10:27:09PM -0700, Nicolin Chen wrote: > > > > On Sun, Sep 01, 2024 at 1

[PATCH] kunit: Fix missing kerneldoc comment

2024-09-04 Thread David Gow
Add a missing kerneldoc comment for the 'test' test context parameter, fixing the following warning: include/kunit/test.h:492: warning: Function parameter or struct member 'test' not described in 'kunit_kfree_const' Reported-by: Stephen Rothwell Closes: https://lore.kernel.org/lkml/202408271606

Re: [PATCH v2 01/19] tools: Add gendwarfksyms

2024-09-04 Thread Masahiro Yamada
On Fri, Aug 16, 2024 at 2:39 AM Sami Tolvanen wrote: > > Add a basic DWARF parser, which uses libdw to traverse the debugging > information in an object file and looks for functions and variables. > In follow-up patches, this will be expanded to produce symbol versions > for CONFIG_MODVERSIONS fro

Re: [PATCH v3 1/2] vdpa/mlx5: Set speed and duplex of vDPA devices to UNKNOWN

2024-09-04 Thread Jason Wang
On Wed, Sep 4, 2024 at 11:18 PM Carlos Bilbao wrote: > > From: Carlos Bilbao > > Initialize the speed and duplex fields in virtio_net_config to UNKNOWN. > This is needed because mlx5_vdpa vDPA devices currently do not support the > VIRTIO_NET_F_SPEED_DUPLEX feature which reports speed and duplex.

Re: [PATCH v3 2/2] vdpa: Remove ioctl VHOST_VDPA_SET_CONFIG per spec compliance

2024-09-04 Thread Jason Wang
On Wed, Sep 4, 2024 at 11:18 PM Carlos Bilbao wrote: > > From: Carlos Bilbao > > Remove invalid ioctl VHOST_VDPA_SET_CONFIG and all its implementations with > vdpa_config_ops->set_config(). This is needed per virtio spec requirements: > virtio-spec v1.3 Sec 5.1.4 states that "All of the device co

Re: [PATCH v2 2/2] vdpa: Remove ioctl VHOST_VDPA_SET_CONFIG per spec compliance

2024-09-04 Thread Jason Wang
On Thu, Sep 5, 2024 at 1:48 AM Dragos Tatulea wrote: > > > > On 04.09.24 08:34, Jason Wang wrote: > > On Wed, Sep 4, 2024 at 1:59 PM Dragos Tatulea wrote: > >> > >> > >> > >> On 04.09.24 05:38, Jason Wang wrote: > >>> On Wed, Sep 4, 2024 at 1:15 AM Carlos Bilbao > >>> wrote: > > From:

Re: BUG: WARNING in kvfree_rcu_bulk

2024-09-04 Thread Xingyu Li
Here is to set up the reproducing environment: https://github.com/TomAPU/Linux610BugReort We tested it, and it can reproduce. On Wed, Sep 4, 2024 at 10:52 AM Uladzislau Rezki wrote: > > Hello! > > > > > Here is the config file: > > https://gist.github.com/TomAPU/64f5db0fe976a3e94a6dd2b621887cdd >

[PATCH v2] selftests: futex: Fix missing free in main

2024-09-04 Thread zhangjiao2
From: zhang jiao By readind the code, I found there is no free() after asprintf(). Just free it. Signed-off-by: zhang jiao --- v1->v2: Set a flag to determine if test_name needs free. tools/testing/selftests/futex/functional/futex_requeue_pi.c | 4 1 file changed, 4 inser

Re: [PATCH 5/5] KVM: VMX: Always honor guest PAT on CPUs that support self-snoop

2024-09-04 Thread Sean Christopherson
On Wed, Sep 04, 2024, Yan Zhao wrote: > On Wed, Sep 04, 2024 at 10:28:02AM +0800, Yan Zhao wrote: > > On Tue, Sep 03, 2024 at 06:20:27PM +0200, Vitaly Kuznetsov wrote: > > > Sean Christopherson writes: > > > > > > > On Mon, Sep 02, 2024, Vitaly Kuznetsov wrote: > > > >> FWIW, I use QEMU-9.0 from

Re: [PATCH] mm/damon/tests/vaddr-kunit: don't use mas_lock for MM_MT_FLAGS-initialized maple tree

2024-09-04 Thread SeongJae Park
On Wed, 4 Sep 2024 12:56:33 -0700 Guenter Roeck wrote: > On 9/4/24 12:26, Liam R. Howlett wrote: > > * Guenter Roeck [240904 00:27]: > >> On 9/3/24 20:36, Liam R. Howlett wrote: > >>> * Guenter Roeck [240903 22:38]: > On 9/3/24 19:31, Liam R. Howlett wrote: > > * SeongJae Park [240903

Re: [PATCH v2] selftests: net: convert comma to semicolon

2024-09-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Wed, 4 Sep 2024 09:44:41 +0800 you wrote: > Replace comma between expressions with semicolons. > > Using a ',' in place of a ';' can have unintended side effects. > Although that is not the case here, it is seems

[PATCH 15/15] kbuild: use .init.rodata section unconditionally for cmd_wrap_S_dtb

2024-09-04 Thread Masahiro Yamada
Boot DTBs are now wrapped and compiled in scripts/Makefile.vmlinux. The cmd_wrap_S_dtb rule in scripts/Makefile.dtbs is now only used for generic purposes, so the .init.rodata section should be used unconditionally. Signed-off-by: Masahiro Yamada --- scripts/Makefile.dtbs | 4 +--- 1 file chan

[PATCH 14/15] kbuild: rename CONFIG_GENERIC_BUILTIN_DTB to CONFIG_BUILTIN_DTB

2024-09-04 Thread Masahiro Yamada
Now that all architectures have migrated to the generic built-in DTB support, the GENERIC_ prefix is no longer necessary. Signed-off-by: Masahiro Yamada --- Makefile | 2 +- arch/arc/Kconfig | 2 +- arch/loongarch/Kconfig | 1 - arch

[PATCH 13/15] microblaze: migrate to the generic rule for built-in DTB

2024-09-04 Thread Masahiro Yamada
Select GENERIC_BUILTIN_DTB to use the generic rule to support built-in DTB. MicroBlaze is the only architecture that embeds the boot DTB into its own section, __fdt_blob, and hard-codes the section size to 64kB. All other architectures that support embedded DTBs use the .dtb.init.rodata handled b

[PATCH 12/15] sh: migrate to the generic rule for built-in DTB

2024-09-04 Thread Masahiro Yamada
Select GENERIC_BUILTIN_DTB when built-in DTB support is enabled. To keep consistency across architectures, this commit also renames CONFIG_USE_BUILTIN_DTB to CONFIG_BUILTIN_DTB, and CONFIG_BUILTIN_DTB_SOURCE to CONFIG_BUILTIN_DTB_NAME. Signed-off-by: Masahiro Yamada --- arch/sh/Kbuild

[PATCH 11/15] nios2: migrate to the generic rule for built-in DTB

2024-09-04 Thread Masahiro Yamada
Select GENERIC_BUILTIN_DTB when built-in DTB support is enabled. To keep consistency across architectures, this commit also renames CONFIG_NIOS2_DTB_SOURCE_BOOL to CONFIG_BUILTIN_DTB, and CONFIG_NIOS2_DTB_SOURCE to CONFIG_BUILTIN_DTB_NAME. Signed-off-by: Masahiro Yamada --- arch/nios2/Kbuild

[PATCH 10/15] xtensa: migrate to the generic rule for built-in DTB

2024-09-04 Thread Masahiro Yamada
Select GENERIC_BUILTIN_DTB to use the generic rule to support built-in DTB. To keep consistency across architectures, this commit also renames CONFIG_BUILTIN_DTB_SOURCE to CONFIG_BUILTIN_DTB_NAME. Signed-off-by: Masahiro Yamada --- arch/xtensa/Kbuild | 2 +- arch/xtens

[PATCH 09/15] openrisc: migrate to the generic rule for built-in DTB

2024-09-04 Thread Masahiro Yamada
Select GENERIC_BUILTIN_DTB to use the generic rule to support built-in DTB. To keep consistency across architectures, this commit also renames CONFIG_OPENRISC_BUILTIN_DTB_NAME to CONFIG_BUILTIN_DTB_NAME. Signed-off-by: Masahiro Yamada --- arch/openrisc/Kbuild | 1 - arch/

[PATCH 08/15] ARC: migrate to the generic rule for built-in DTB

2024-09-04 Thread Masahiro Yamada
Select GENERIC_BUILTIN_DTB to use the generic rule to support built-in DTB. To keep consistency across architectures, this commit also renames CONFIG_ARC_BUILTIN_DTB_NAME to CONFIG_BUILTIN_DTB_NAME. Signed-off-by: Masahiro Yamada --- arch/arc/Kconfig | 7 --- arch

[PATCH 07/15] LoongArch: migrate to the generic rule for built-in DTB

2024-09-04 Thread Masahiro Yamada
Select GENERIC_BUILTIN_DTB when built-in DTB support is enabled. Signed-off-by: Masahiro Yamada --- arch/loongarch/Kbuild| 1 - arch/loongarch/Kconfig | 1 + arch/loongarch/boot/dts/Makefile | 2 -- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/loongar

[PATCH 06/15] riscv: migrate to the generic rule for built-in DTB

2024-09-04 Thread Masahiro Yamada
Select GENERIC_BUILTIN_DTB when built-in DTB support is enabled. To keep consistency across architectures, this commit also renames CONFIG_BUILTIN_DTB_SOURCE to CONFIG_BUILTIN_DTB_NAME. Signed-off-by: Masahiro Yamada --- arch/riscv/Kbuild | 1 - arch/riscv/Kconfig

[PATCH 05/15] MIPS: migrate to generic rule for built-in DTBs

2024-09-04 Thread Masahiro Yamada
Select GENERIC_BUILTIN_DTB and BUILTIN_DTB_ALL when built-in DTB support is enabled. DTBs compiled under arch/mips/boot/dts/ will be wrapped and compiled in scripts/Makefile.vmlinux. Signed-off-by: Masahiro Yamada --- arch/mips/Kconfig | 2 ++ arch/mips/Makefile

[PATCH 04/15] kbuild: add generic support for built-in boot DTBs

2024-09-04 Thread Masahiro Yamada
Some architectures embed boot DTBs in vmlinux. A potential issue for these architectures is a race condition during parallel builds because Kbuild descends into arch/*/boot/dts/ twice. One build thread is initiated by the 'dtbs' target, which is a prerequisite of the 'all' target in the top-level

[PATCH 03/15] kbuild: move non-boot builtin DTBs to .init.rodata section

2024-09-04 Thread Masahiro Yamada
Some architectures support embedding boot DTB(s) in vmlinux. These architectures, except MIPS and MicroBlaze, expect a single DTB in the .dtb.init.rodata section. MIPS embeds multiple DTBs in vmlinux. MicroBlaze embeds a DTB in its own __fdt_blob section instead of the .dtb.init.rodata section. Fo

[PATCH 02/15] kbuild: split device tree build rules into scripts/Makefile.dtbs

2024-09-04 Thread Masahiro Yamada
scripts/Makefile.lib is included not only from scripts/Makefile.build but also from scripts/Makefile.{modfinal,package,vmlinux,vmlinux_o}, where DT build rules are not required. Split the DT build rules out to scripts/Makefile.dtbs, and include it only when necessary. Signed-off-by: Masahiro Yama

[PATCH 01/15] kbuild: add intermediate targets for Flex/Bison in scripts/Makefile.host

2024-09-04 Thread Masahiro Yamada
Flex and Bison are used only for host programs. Move their intermediate target processing from scripts/Makefile.build to scripts/Makefile.host. Signed-off-by: Masahiro Yamada --- scripts/Makefile.build | 35 --- scripts/Makefile.host | 5 + 2 files changed,

[PATCH 00/15] kbuild: refactor DTB build rules, introduce a generic built-in boot DTB support

2024-09-04 Thread Masahiro Yamada
01 and 02 are kbuild cleanups. 03 and 04 parepare to wrap boot DTBs in scripts/Makefile.vmlinux. My plan is to 05-13 to each arch ML in the next cycle, but they are included in this patch set so that reviewers can understand what will happen in the future. Masahiro Yamada (15): kbuild: add

Re: [PATCH] selftests/net: do_setcpu function not need to have a return value

2024-09-04 Thread Jakub Kicinski
On Tue, 3 Sep 2024 17:51:11 +0800 Liu Jing wrote: > in the do_setcpu, this function does not need to have a return value, > which is meaningless This test is flaky: https://netdev.bots.linux.dev/contest.html?executor=vmksft-net-dbg&test=msg-zerocopy-sh Could you please try to figure out what the

Re: [PATCH v2 02/19] iommufd/viommu: Add IOMMUFD_OBJ_VIOMMU and IOMMU_VIOMMU_ALLOC ioctl

2024-09-04 Thread Jason Gunthorpe
On Wed, Sep 04, 2024 at 10:29:26AM -0700, Nicolin Chen wrote: > On Wed, Sep 04, 2024 at 01:26:21PM -0300, Jason Gunthorpe wrote: > > On Sun, Sep 01, 2024 at 10:27:09PM -0700, Nicolin Chen wrote: > > > On Sun, Sep 01, 2024 at 10:39:17AM +0800, Baolu Lu wrote: > > > > On 2024/8/28 0:59, Nicolin Chen

Re: [PATCH v2] kselftest: dt: Ignore nodes that have ancestors disabled

2024-09-04 Thread Rob Herring
On Mon, Jul 29, 2024 at 04:56:02PM -0400, Nícolas F. R. A. Prado wrote: > Filter out nodes that have one of its ancestors disabled as they aren't > expected to probe. > > This removes the following false-positive failures on the > sc7180-trogdor-lazor-limozeen-nots-r5 platform: > > /soc@0/geniqup

Re: [RFC 31/31] objtool, livepatch: Livepatch module generation

2024-09-04 Thread Jeff Johnson
On 9/2/24 21:00, Josh Poimboeuf wrote: ... > diff --git a/scripts/livepatch/module.c b/scripts/livepatch/module.c > new file mode 100644 > index ..101cabf6b2f1 > --- /dev/null > +++ b/scripts/livepatch/module.c > @@ -0,0 +1,120 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +/* >

Re: [RFC 00/31] objtool, livepatch: Livepatch module generation

2024-09-04 Thread Song Liu
On Wed, Sep 4, 2024 at 1:59 PM Josh Poimboeuf wrote: > > On Wed, Sep 04, 2024 at 01:23:55PM -0700, Song Liu wrote: > > Hi Josh, > > > > Thanks for the fix! The gcc kernel now compiles. > > > > I am now testing with the attached config file (where I disabled > > CONFIG_DEBUG_INFO_BTF), with the att

Re: [PATCH 5/6] selftests/resctrl: Do not compare performance counters and resctrl at low bandwidth

2024-09-04 Thread Reinette Chatre
Hi Ilpo, On 9/4/24 4:43 AM, Ilpo Järvinen wrote: On Fri, 30 Aug 2024, Reinette Chatre wrote: On 8/30/24 4:42 AM, Ilpo Järvinen wrote: On Thu, 29 Aug 2024, Reinette Chatre wrote: The MBA test incrementally throttles memory bandwidth, each time followed by a comparison between the memory bandw

Re: [PATCH 2/6] selftests/resctrl: Ensure measurements skip initialization of default benchmark

2024-09-04 Thread Reinette Chatre
Hi Ilpo, On 9/4/24 4:57 AM, Ilpo Järvinen wrote: On Fri, 30 Aug 2024, Reinette Chatre wrote: Thank you for taking a look. On 8/30/24 3:56 AM, Ilpo Järvinen wrote: On Thu, 29 Aug 2024, Reinette Chatre wrote: ... @@ -684,11 +622,13 @@ int resctrl_val(const struct resctrl_test *test,

Re: [RFC 00/31] objtool, livepatch: Livepatch module generation

2024-09-04 Thread Josh Poimboeuf
On Wed, Sep 04, 2024 at 01:23:55PM -0700, Song Liu wrote: > Hi Josh, > > Thanks for the fix! The gcc kernel now compiles. > > I am now testing with the attached config file (where I disabled > CONFIG_DEBUG_INFO_BTF), with the attached patch. Probably a good idea to disable BTF as I think it's ca

Re: [PATCH v2 02/19] gendwarfksyms: Add symbol list handling

2024-09-04 Thread Sami Tolvanen
On Sun, Sep 1, 2024 at 11:00 AM Masahiro Yamada wrote: > > On Fri, Aug 16, 2024 at 2:39 AM Sami Tolvanen wrote: > > > > /* > > - * Symbol processing > > + * Exported symbol processing > > */ > > static int process_subprogram(struct state *state, Dwarf_Die *die) > > { > > > I also tend to reg

Re: [PATCH v2 03/19] gendwarfksyms: Add address matching

2024-09-04 Thread Sami Tolvanen
Hi, On Sun, Sep 1, 2024 at 11:11 AM Masahiro Yamada wrote: > > On Fri, Aug 16, 2024 at 2:39 AM Sami Tolvanen wrote: > > > > +static int set_symbol_addr(struct symbol *sym, void *arg) > > +{ > > + struct symbol_addr *addr = arg; > > + > > + if (sym->addr.section == SHN_UNDEF) { > > +

Re: [PATCH v2 18/19] x86/asm-prototypes: Include

2024-09-04 Thread Sami Tolvanen
Hi Masahiro, On Sun, Sep 1, 2024 at 10:51 AM Masahiro Yamada wrote: > > On Fri, Aug 16, 2024 at 2:39 AM Sami Tolvanen wrote: > > > > refers to struct pt_regs, make sure it's visible. > > > > Signed-off-by: Sami Tolvanen > > > Then, why don't you include > from arch/x86/include/asm/ftrace.h >

Re: [PATCH net-next 0/3] selftests: mptcp: add time per subtests in TAP output

2024-09-04 Thread Matthieu Baerts
Hi Jakub, Thank you for your reply! On 04/09/2024 21:40, Jakub Kicinski wrote: > On Wed, 4 Sep 2024 18:15:09 +0200 Matthieu Baerts wrote: >>> Best I could come up with is: >>> >>> diff --git a/contest/remote/vmksft-p.py b/contest/remote/vmksft-p.py >>> index fe9e87abdb5c..a37245bd5b30 100755 >>>

Re: [PATCH] selftests: bpf: Replace sizeof(arr)/sizeof(arr[0]) with ARRAY_SIZE

2024-09-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko : On Tue, 3 Sep 2024 15:25:59 +0800 you wrote: > From: Feng Yang > > The ARRAY_SIZE macro is more compact and more formal in linux source. > > Signed-off-by: Feng Yang > --- > tools/testing/selftests/bpf/prog_test

Re: [PATCH v2] mm/damon/tests/vaddr-kunit: init maple tree without MT_FLAGS_LOCK_EXTERN

2024-09-04 Thread Guenter Roeck
On Wed, Sep 04, 2024 at 10:29:31AM -0700, SeongJae Park wrote: > damon_test_three_regions_in_vmas() initializes a maple tree with > MM_MT_FLAGS. The flags contains MT_FLAGS_LOCK_EXTERN, which means > mt_lock of the maple tree will not be used. And therefore the maple > tree initialization code sk

Re: [PATCH] mm/damon/tests/vaddr-kunit: don't use mas_lock for MM_MT_FLAGS-initialized maple tree

2024-09-04 Thread Guenter Roeck
On 9/4/24 12:26, Liam R. Howlett wrote: * Guenter Roeck [240904 00:27]: On 9/3/24 20:36, Liam R. Howlett wrote: * Guenter Roeck [240903 22:38]: On 9/3/24 19:31, Liam R. Howlett wrote: * SeongJae Park [240903 21:18]: On Tue, 3 Sep 2024 17:58:15 -0700 SeongJae Park wrote: On Tue, 3 Sep

Re: [PATCH bpf,v2,0/2] bpf: fix incorrect name check pass logic in btf_name_valid_section

2024-09-04 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf.git (master) by Alexei Starovoitov : On Sat, 31 Aug 2024 14:45:25 +0900 you wrote: > This patch was written to fix an issue where btf_name_valid_section() would > not properly check names with certain conditions and would throw an OOB vuln. > And selftest

Re: [PATCH net-next 0/3] selftests: mptcp: add time per subtests in TAP output

2024-09-04 Thread Jakub Kicinski
On Wed, 4 Sep 2024 18:15:09 +0200 Matthieu Baerts wrote: > > Best I could come up with is: > > > > diff --git a/contest/remote/vmksft-p.py b/contest/remote/vmksft-p.py > > index fe9e87abdb5c..a37245bd5b30 100755 > > --- a/contest/remote/vmksft-p.py > > +++ b/contest/remote/vmksft-p.py > > @@ -73,7

Re: [PATCH v2] mm/damon/tests/vaddr-kunit: init maple tree without MT_FLAGS_LOCK_EXTERN

2024-09-04 Thread Liam R. Howlett
* SeongJae Park [240904 14:53]: > On Wed, 4 Sep 2024 11:41:28 -0700 Guenter Roeck wrote: > > > On 9/4/24 10:29, SeongJae Park wrote: > > > damon_test_three_regions_in_vmas() initializes a maple tree with > > > MM_MT_FLAGS. The flags contains MT_FLAGS_LOCK_EXTERN, which means > > > mt_lock of th

Re: [PATCH] mm/damon/tests/vaddr-kunit: don't use mas_lock for MM_MT_FLAGS-initialized maple tree

2024-09-04 Thread Liam R. Howlett
* Guenter Roeck [240904 00:27]: > On 9/3/24 20:36, Liam R. Howlett wrote: > > * Guenter Roeck [240903 22:38]: > > > On 9/3/24 19:31, Liam R. Howlett wrote: > > > > * SeongJae Park [240903 21:18]: > > > > > On Tue, 3 Sep 2024 17:58:15 -0700 SeongJae Park > > > > > wrote: > > > > > > > > > > >

Re: [PATCH v2] mm/damon/tests/vaddr-kunit: init maple tree without MT_FLAGS_LOCK_EXTERN

2024-09-04 Thread SeongJae Park
On Wed, 4 Sep 2024 11:41:28 -0700 Guenter Roeck wrote: > On 9/4/24 10:29, SeongJae Park wrote: > > damon_test_three_regions_in_vmas() initializes a maple tree with > > MM_MT_FLAGS. The flags contains MT_FLAGS_LOCK_EXTERN, which means > > mt_lock of the maple tree will not be used. And therefore

Re: [PATCH v2] mm/damon/tests/vaddr-kunit: init maple tree without MT_FLAGS_LOCK_EXTERN

2024-09-04 Thread Guenter Roeck
On 9/4/24 10:29, SeongJae Park wrote: damon_test_three_regions_in_vmas() initializes a maple tree with MM_MT_FLAGS. The flags contains MT_FLAGS_LOCK_EXTERN, which means mt_lock of the maple tree will not be used. And therefore the maple tree initialization code skips initialization of the mt_lo

Re: [PATCH v5] remoteproc: xlnx: add sram support

2024-09-04 Thread Shah, Tanmay
Hi Mathieu, I agree with your assessment, and I agree with your proposal. I appreciate you fixing the patch before applying. My email client (Thunderbird) has some issues, hence sending email form different email client and so not formatted as expected. This will be fixed soon (before sending a

Re: [PATCH v4 2/2] livepatch: Add using attribute to klp_func for using function show

2024-09-04 Thread Josh Poimboeuf
On Wed, Sep 04, 2024 at 03:30:22PM +0800, zhang warden wrote: > > On Sep 4, 2024, at 15:14, Josh Poimboeuf wrote: > > If there are multiple people applying patches independently from each > > other (to the same function even!), you are playing with fire, as there > > could easily be implicit depen

Re: [PATCH bpf,v2,0/2] bpf: fix incorrect name check pass logic in btf_name_valid_section

2024-09-04 Thread Eduard Zingerman
On Sat, 2024-08-31 at 14:45 +0900, Jeongjun Park wrote: > This patch was written to fix an issue where btf_name_valid_section() would > not properly check names with certain conditions and would throw an OOB vuln. > And selftest was added to verify this patch. Acked-by: Eduard Zingerman [...]

Re: [PATCH] virtio_pmem: Add freeze/restore callbacks

2024-09-04 Thread Ira Weiny
Philip Chen wrote: > Hi maintainers, > > Can anyone let me know if this patch makes sense? > Any comment/feedback is appreciated. > Thanks in advance! I'm not an expert on virtio but the code looks ok on the surface. I've discussed this with Dan a bit and virtio-pmem is not heavily tested. Base

Re: BUG: WARNING in kvfree_rcu_bulk

2024-09-04 Thread Uladzislau Rezki
Hello! > > Here is the config file: > https://gist.github.com/TomAPU/64f5db0fe976a3e94a6dd2b621887cdd > Thank you. I was not able to boot my box using your config file. But i enabled all needed configs in to run your reproduce so it does not complain on below warnings: urezki@pc638:~$ sudo ./a.

Re: [PATCH v2 2/2] vdpa: Remove ioctl VHOST_VDPA_SET_CONFIG per spec compliance

2024-09-04 Thread Dragos Tatulea
On 04.09.24 08:34, Jason Wang wrote: > On Wed, Sep 4, 2024 at 1:59 PM Dragos Tatulea wrote: >> >> >> >> On 04.09.24 05:38, Jason Wang wrote: >>> On Wed, Sep 4, 2024 at 1:15 AM Carlos Bilbao >>> wrote: From: Carlos Bilbao Remove invalid ioctl VHOST_VDPA_SET_CONFIG and all i

Re: [PATCH net] selftests: net: enable bind tests

2024-09-04 Thread Kuniyuki Iwashima
From: Jamie Bainbridge Date: Wed, 4 Sep 2024 16:12:26 +1000 > bind_wildcard is compiled but not run, bind_timewait is not compiled. > > These two tests complete in a very short time, use the test harness > properly, and seem reasonable to enable. > > The author of the tests confirmed via email

Re: [PATCH] mm/damon/tests/vaddr-kunit: don't use mas_lock for MM_MT_FLAGS-initialized maple tree

2024-09-04 Thread SeongJae Park
On Tue, 3 Sep 2024 22:43:40 -0400 "Liam R. Howlett" wrote: > * Guenter Roeck [240903 21:54]: > > On 9/3/24 18:18, SeongJae Park wrote: > > > On Tue, 3 Sep 2024 17:58:15 -0700 SeongJae Park wrote: > > > > > > > On Tue, 3 Sep 2024 20:48:53 -0400 "Liam R. Howlett" > > > > wrote: > > > > > >

Re: [PATCH v2 02/19] iommufd/viommu: Add IOMMUFD_OBJ_VIOMMU and IOMMU_VIOMMU_ALLOC ioctl

2024-09-04 Thread Nicolin Chen
On Wed, Sep 04, 2024 at 01:26:21PM -0300, Jason Gunthorpe wrote: > On Sun, Sep 01, 2024 at 10:27:09PM -0700, Nicolin Chen wrote: > > On Sun, Sep 01, 2024 at 10:39:17AM +0800, Baolu Lu wrote: > > > On 2024/8/28 0:59, Nicolin Chen wrote: > > > > +int iommufd_viommu_alloc_ioctl(struct iommufd_ucmd *uc

[PATCH v2] mm/damon/tests/vaddr-kunit: init maple tree without MT_FLAGS_LOCK_EXTERN

2024-09-04 Thread SeongJae Park
damon_test_three_regions_in_vmas() initializes a maple tree with MM_MT_FLAGS. The flags contains MT_FLAGS_LOCK_EXTERN, which means mt_lock of the maple tree will not be used. And therefore the maple tree initialization code skips initialization of the mt_lock. However, __link_vmas(), which adds

Re: [PATCH v6 1/2] selftests: Rename sigaltstack to generic signal

2024-09-04 Thread Shuah Khan
On 9/3/24 22:52, Dev Jain wrote: On 9/4/24 03:14, Shuah Khan wrote: On 8/30/24 10:29, Dev Jain wrote: On 8/27/24 17:16, Dev Jain wrote: On 8/27/24 17:14, Shuah Khan wrote: On 8/22/24 06:14, Dev Jain wrote: Rename sigaltstack to generic signal directory, to allow adding more signal tests i

Re: [PATCH] mm/damon/tests/vaddr-kunit: don't use mas_lock for MM_MT_FLAGS-initialized maple tree

2024-09-04 Thread Guenter Roeck
On 9/3/24 20:36, Liam R. Howlett wrote: * Guenter Roeck [240903 22:38]: On 9/3/24 19:31, Liam R. Howlett wrote: * SeongJae Park [240903 21:18]: On Tue, 3 Sep 2024 17:58:15 -0700 SeongJae Park wrote: On Tue, 3 Sep 2024 20:48:53 -0400 "Liam R. Howlett" wrote: * SeongJae Park [240903 2

Re: [PATCH] selftests: futex: Fix missing free in main

2024-09-04 Thread Shuah Khan
On 9/3/24 20:55, zhangjiao2 wrote: From: zhang jiao Free string allocated by asprintf(). How did you find this problem? Include the details in the change log - The tool and output from the tool. Signed-off-by: zhang jiao --- tools/testing/selftests/futex/functional/futex_requeue_pi.c |

[PATCH rcu [12/11] srcu: Allow inlining of __srcu_read_{,un}lock_lite()

2024-09-04 Thread Paul E. McKenney
srcu: Allow inlining of __srcu_read_{,un}lock_lite() This commit moves __srcu_read_lock_lite() and __srcu_read_unlock_lite() into include/linux/srcu.h and marks them "static inline" so that they can be inlined into srcu_read_lock_lite() and srcu_read_unlock_lite(), respectively. They are not hand

Re: [PATCH v2] selftests/futex: Create test for robust list

2024-09-04 Thread Shuah Khan
On 9/3/24 07:40, André Almeida wrote: Create a test for the robust list mechanism. What does this test - can you elaborate on the testing details? It will help reviewers catch if any tests are missed or not - be able to review the patch. Include output from the test in the chane log. Signed

Re: [PATCH v2] selftests: net: convert comma to semicolon

2024-09-04 Thread Simon Horman
On Wed, Sep 04, 2024 at 09:44:41AM +0800, Chen Ni wrote: > Replace comma between expressions with semicolons. > > Using a ',' in place of a ';' can have unintended side effects. > Although that is not the case here, it is seems best to use ';' > unless ',' is intended. > > Found by inspection. >

Re: [RFC 28/31] x86/alternative: Create symbols for special section entries

2024-09-04 Thread Josh Poimboeuf
On Wed, Sep 04, 2024 at 02:39:18PM +0200, Borislav Petkov wrote: > On Tue, Sep 03, 2024 at 09:28:29PM -0700, Josh Poimboeuf wrote: > > Take a more generic approach: for the "array of structs" style sections, > > annotate each struct entry with a symbol containing the entry. This > > makes it easy

Re: [PATCH v2 02/19] iommufd/viommu: Add IOMMUFD_OBJ_VIOMMU and IOMMU_VIOMMU_ALLOC ioctl

2024-09-04 Thread Jason Gunthorpe
On Sun, Sep 01, 2024 at 10:27:09PM -0700, Nicolin Chen wrote: > On Sun, Sep 01, 2024 at 10:39:17AM +0800, Baolu Lu wrote: > > On 2024/8/28 0:59, Nicolin Chen wrote: > > > +int iommufd_viommu_alloc_ioctl(struct iommufd_ucmd *ucmd) > > > +{ > > > + struct iommu_viommu_alloc *cmd = ucmd->cmd; > >

Re: [PATCH v5] remoteproc: xlnx: add sram support

2024-09-04 Thread Mathieu Poirier
Good morning, On Fri, Aug 30, 2024 at 10:37:36AM -0700, Tanmay Shah wrote: > AMD-Xilinx zynqmp platform contains on-chip sram memory (OCM). > R5 cores can access OCM and access is faster than DDR memory but slower > than TCM memories available. Sram region can have optional multiple > power-domain

Re: [RFC 21/31] objtool: Fix x86 addend calcuation

2024-09-04 Thread Josh Poimboeuf
On Wed, Sep 04, 2024 at 05:24:21PM +0800, laokz wrote: > On Mon, 2024-09-02 at 21:00 -0700, Josh Poimboeuf wrote: > > +++ b/tools/objtool/arch/loongarch/decode.c > > @@ -20,9 +20,9 @@ unsigned long arch_jump_destination(struct > > instruction *insn) > > return insn->offset + (insn->immediat

Re: [PATCH net-next 3/3] selftests: lan743x: Add testcase to check throughput of lan743x

2024-09-04 Thread Brett Creeley
On 9/3/2024 3:15 PM, Mohan Prasad J wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Add testcase to check TCP throughput of lan743x network driver. Test uses iperf3 to do performance testing of the

Re: [PATCH net-next 0/3] selftests: mptcp: add time per subtests in TAP output

2024-09-04 Thread Matthieu Baerts
Hi Jakub, On 04/09/2024 01:22, Jakub Kicinski wrote: > On Mon, 02 Sep 2024 13:13:03 +0200 Matthieu Baerts (NGI0) wrote: >> Patches here add 'time=ms' in the diagnostic data of the TAP output, >> e.g. >> >> ok 1 - pm_netlink: defaults addr list # time=9ms > > Looking closer, this: > > # ok 3 -

Re: [RFC 28/31] x86/alternative: Create symbols for special section entries

2024-09-04 Thread Josh Poimboeuf
On Wed, Sep 04, 2024 at 10:08:42AM +0200, Peter Zijlstra wrote: > On Tue, Sep 03, 2024 at 09:28:29PM -0700, Josh Poimboeuf wrote: > > Take a more generic approach: for the "array of structs" style sections, > > annotate each struct entry with a symbol containing the entry. This > > makes it easy f

Re: [RFC 29/31] objtool: Calculate function checksums

2024-09-04 Thread Josh Poimboeuf
On Wed, Sep 04, 2024 at 09:54:33AM +0200, Peter Zijlstra wrote: > > +LIBXXHASH_FLAGS := $(shell $(HOSTPKG_CONFIG) libxxhash --cflags > > 2>/dev/null) > > +LIBXXHASH_LIBS := $(shell $(HOSTPKG_CONFIG) libxxhash --libs 2>/dev/null > > || echo -lxxhash) > > This was not installed on my system and I

Re: [PATCH] iommufd/selftest:fix a resource leak

2024-09-04 Thread Jason Gunthorpe
On Wed, Sep 04, 2024 at 04:08:06AM +0800, Liu Jing wrote: > If the file fails to open, not only return return1 but also close the file > descriptor,otherwise resource > leak will occur Why doesn't FIXURE_TEARDOWN do this? Jason

Re: [PATCH net-next 1/3] selftests: lan743x: Add testfile for lan743x network driver

2024-09-04 Thread Brett Creeley
On 9/3/2024 3:15 PM, Mohan Prasad J wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Add testfile for lan743x network driver. Testfile includes the verification of status of autonegotiation. Ksft mod

Re: [PATCH net-next 2/3] selftests: lan743x: Add testcase to check speed and duplex state of lan743x

2024-09-04 Thread Brett Creeley
On 9/3/2024 3:15 PM, Mohan Prasad J wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Add testcase for checking speed and duplex states for lan743x network driver. Testcase comprises of varying the ne

Re: [RFC 27/31] objtool: Fix weak symbol detection

2024-09-04 Thread Josh Poimboeuf
On Wed, Sep 04, 2024 at 09:42:54AM +0200, Peter Zijlstra wrote: > On Tue, Sep 03, 2024 at 08:55:13PM -0700, Josh Poimboeuf wrote: > > On Tue, Sep 03, 2024 at 10:26:45AM +0200, Peter Zijlstra wrote: > > > On Mon, Sep 02, 2024 at 09:00:10PM -0700, Josh Poimboeuf wrote: > > > > @@ -433,9 +433,13 @@ st

Re: [PATCH] um: kunit: resolve missing prototypes warning

2024-09-04 Thread Gabriele Monaco
First of all, thanks for the quick reply > I get that you have this on kunit on ARCH=um, but that makes it > neither > a kunit nor a um patch :) Well, yes I wasn't entirely sure how to put it, sure people from UM/KUnit know what this is about, but I agree perhaps the patch title can be a bit mi

Re: [PATCH net-next v17 02/14] mm: move the page fragment allocator from page_alloc into its own file

2024-09-04 Thread Alexander Duyck
On Mon, Sep 2, 2024 at 5:09 AM Yunsheng Lin wrote: > > Inspired by [1], move the page fragment allocator from page_alloc > into its own c file and header file, as we are about to make more > change for it to replace another page_frag implementation in > sock.c > > As this patchset is going to repl

Re: [PATCH] remoteproc:remove redundant dev_err message

2024-09-04 Thread Mathieu Poirier
Hi, There are several other instances such as these in the remoteproc subsystem. Please send another revision that is addressing them all. Thanks, Mathieu On Wed, Sep 04, 2024 at 10:09:49AM +0800, Liu Jing wrote: > devm_ioremap_resource already contains error message, so remove > the redundant d

[PATCH v3 2/2] vdpa: Remove ioctl VHOST_VDPA_SET_CONFIG per spec compliance

2024-09-04 Thread Carlos Bilbao
From: Carlos Bilbao Remove invalid ioctl VHOST_VDPA_SET_CONFIG and all its implementations with vdpa_config_ops->set_config(). This is needed per virtio spec requirements: virtio-spec v1.3 Sec 5.1.4 states that "All of the device configuration fields are read-only for the driver.". This excludes

[PATCH v3 0/2] Properly initialize speed/duplex and remove vDPA config updates

2024-09-04 Thread Carlos Bilbao
From: Carlos Bilbao Initialize speed and duplex for virtio_net_config to UNKNOWN (mlx5_vdpa vDPA devices currently do not support VIRTIO_NET_F_SPEED_DUPLEX). Remove ioctl VHOST_VDPA_SET_CONFIG and its related logic as it is not supported; see: https://docs.oasis-open.org/virtio/virtio/v1.3/virtio

[PATCH v3 1/2] vdpa/mlx5: Set speed and duplex of vDPA devices to UNKNOWN

2024-09-04 Thread Carlos Bilbao
From: Carlos Bilbao Initialize the speed and duplex fields in virtio_net_config to UNKNOWN. This is needed because mlx5_vdpa vDPA devices currently do not support the VIRTIO_NET_F_SPEED_DUPLEX feature which reports speed and duplex. Add needed helper cpu_to_mlx5vdpa32() to convert endianness of s

Re: [PATCH net-next v17 01/14] mm: page_frag: add a test module for page_frag

2024-09-04 Thread Alexander Duyck
On Mon, Sep 2, 2024 at 5:09 AM Yunsheng Lin wrote: > > The testing is done by ensuring that the fragment allocated > from a frag_frag_cache instance is pushed into a ptr_ring > instance in a kthread binded to a specified cpu, and a kthread > binded to a specified cpu will pop the fragment from the

[PATCH v2 0/2] Some enhancement for kvfree_rcu_mightsleep()

2024-09-04 Thread Uladzislau Rezki (Sony)
This is v2. This small change tends to improve even more the slow path of kvfree_rcu_mightsleep() API. It is hit when a low memory condition occurs which leads us into two options: a) check if a GP is already passed for freed object; b) if not, initialize and wait for completion of a new GP. T

[PATCH v2 1/2] rcu/kvfree: Use polled API in a slow path

2024-09-04 Thread Uladzislau Rezki (Sony)
For a single argument use a polled API to see if a GP is already passed. This allows to bypass an extra GP request in a slow path. Allocating a page or dynamic rcu_head might take some and still fail, in that scenario a GP which is requested on entry of kvfree_call_rcu() can be elapsed. Benefit fr

[PATCH v2 2/2] rcu/kvfree: Switch to expedited version in slow path

2024-09-04 Thread Uladzislau Rezki (Sony)
For a single argument and its slow path, switch to expedited version of synchronize_rcu(). This version is considered to be more faster, thus under a high memory pressure a slow path becoms more efficient. Note, latency-sensitive workloads should use rcutree.gp_normal=1, which will make that synch

[syzbot] [wpan?] KASAN: global-out-of-bounds Read in mac802154_header_create (2)

2024-09-04 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:1934261d8974 Merge tag 'input-for-v6.11-rc5' of git://git... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=12224d4398 kernel config: https://syzkaller.appspot.com/x/.config?x=62bf36773c1381f1 das

Re: next: rcu_preempt self-detected stall on CPU - queued_spin_lock_slowpath

2024-09-04 Thread Paul E. McKenney
On Wed, Sep 04, 2024 at 04:19:39PM +0200, Miklos Szeredi wrote: > On Wed, Sep 4, 2024 at 2:06 PM Naresh Kamboju > wrote: > > > > The following kernel rcu info generated while running the test case > > selftests: memfd: run_fuse_test.sh on qemu-arm64 running Linux > > next-20240902. The qemu-arm64

Re: next: rcu_preempt self-detected stall on CPU - queued_spin_lock_slowpath

2024-09-04 Thread Miklos Szeredi
On Wed, Sep 4, 2024 at 2:06 PM Naresh Kamboju wrote: > > The following kernel rcu info generated while running the test case > selftests: memfd: run_fuse_test.sh on qemu-arm64 running Linux > next-20240902. The qemu-arm64 did not recover. > > This build was created with kselftest merge configs. >

  1   2   >