Hi,
There are several other instances such as these in the remoteproc subsystem.
Please send another revision that is addressing them all.
Thanks,
Mathieu
On Wed, Sep 04, 2024 at 10:09:49AM +0800, Liu Jing wrote:
> devm_ioremap_resource already contains error message, so remove
> the redundant dev_err message
>
> Signed-off-by: Liu Jing <liuj...@cmss.chinamobile.com>
> diff --git a/drivers/remoteproc/st_slim_rproc.c
> b/drivers/remoteproc/st_slim_rproc.c
> index d17719384c16..a6e50f51c794 100644
> --- a/drivers/remoteproc/st_slim_rproc.c
> +++ b/drivers/remoteproc/st_slim_rproc.c
> @@ -251,7 +251,6 @@ struct st_slim_rproc *st_slim_rproc_alloc(struct
> platform_device *pdev,
>
> slim_rproc->mem[i].cpu_addr = devm_ioremap_resource(dev, res);
> if (IS_ERR(slim_rproc->mem[i].cpu_addr)) {
> - dev_err(&pdev->dev, "devm_ioremap_resource failed\n");
> err = PTR_ERR(slim_rproc->mem[i].cpu_addr);
> goto err;
> }
> @@ -262,7 +261,6 @@ struct st_slim_rproc *st_slim_rproc_alloc(struct
> platform_device *pdev,
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "slimcore");
> slim_rproc->slimcore = devm_ioremap_resource(dev, res);
> if (IS_ERR(slim_rproc->slimcore)) {
> - dev_err(&pdev->dev, "failed to ioremap slimcore IO\n");
> err = PTR_ERR(slim_rproc->slimcore);
> goto err;
> }
> @@ -270,7 +268,6 @@ struct st_slim_rproc *st_slim_rproc_alloc(struct
> platform_device *pdev,
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "peripherals");
> slim_rproc->peri = devm_ioremap_resource(dev, res);
> if (IS_ERR(slim_rproc->peri)) {
> - dev_err(&pdev->dev, "failed to ioremap peripherals IO\n");
> err = PTR_ERR(slim_rproc->peri);
> goto err;
> }
> --
> 2.33.0
>
>
>
