On 04/06/2024 3:42 pm, Qais Yousef wrote:
{rt, realtime, dl}_{task, prio}() functions return value is actually
Super-nit: s/functions/functions'/ ?
With that,
Reviewed-by: Metin Kaya
a bool. Convert their return type to reflect that.
Suggested-by: Steven Rostedt (Google)
Signed-off-by:
Hi Steven,
kernel test robot noticed the following build errors:
[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on linus/master v6.10-rc2 next-20240604]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use
On Tue, May 21, 2024 at 1:04 AM Petr Mladek wrote:
[...]
> >
> > Yes, but the information you get is limited compared to what is available
> > now. You would obtain the information that a patched function was called
> > but ftrace could also give you the context and more.
>
> Another motivation to
With CONFIG_LTO_CLANG, the compiler may postfix symbols with .llvm.
to avoid symbol duplication. scripts/kallsyms.c sorted the symbols
without these postfixes. The default symbol lookup also removes these
postfixes before comparing symbols.
On the other hand, livepatch need to look up symbols with
Hi Joe,
>
> Perhaps "responsibility" is a better description. This would introduce
> an attribute that someone's userspace utility is relying on. It should
> at least have a kselftest to ensure a random patch in 2027 doesn't break
> it.
I sent this patch to see the what the community thinks abo
On Wed, 5 Jun 2024 09:12:57 +0800
kernel test robot wrote:
> >> kernel/trace/ftrace.c:1961:13: error: conflicting types for
> >> 'ftrace_hash_rec_disable_modify'
> 1961 | static void ftrace_hash_rec_disable_modify(struct ftrace_ops *ops,
> | ^
>kernel/trace/ftrace.
:rpmsg_chrdev");
+MODULE_DESCRIPTION("RPMSG device interface");
MODULE_LICENSE("GPL v2");
---
base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
change-id: 20240604-md-drivers-rpmsg_char-02914d244ec9
Hi Steven,
kernel test robot noticed the following build errors:
[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on linus/master v6.10-rc2 next-20240604]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use
syzbot has bisected this issue to:
commit 6b0b708f12d18f9cccfb1c418bea59fcbff8798c
Author: Takashi Sakamoto
Date: Wed May 1 07:32:38 2024 +
firewire: core: add tracepoint event for handling bus reset
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=14969a1698
start com
On 27/05/2024 21:50, MarileneGarcia wrote:
Adding the description of the parameters addr and free_filters
of the function unregister_ftrace_direct.
Signed-off-by: MarileneGarcia
---
Hello,
These changes fix the following compiler warnings of the function
unregister_ftrace_direct.
The warnings
On 6/3/2024 2:37 AM, Caleb Connolly wrote:
Hi Deepak,
On 03/06/2024 09:36, Deepak Kumar Singh wrote:
There are certain usecases which require glink interrupt to be
wakeup capable. For example if handset is in sleep state and
usb charger is plugged in, dsp wakes up and sends glink interrupt
t
On Sat Jun 1, 2024 at 1:26 AM EEST, Haitao Huang wrote:
> With different cgroups, the script starts one or multiple concurrent SGX
> selftests (test_sgx), each to run the unclobbered_vdso_oversubscribed
> test case, which loads an enclave of EPC size equal to the EPC capacity
> available on the pla
Replace kfree_skb_reason with sk_skb_reason_drop and pass the receiving
socket to the tracepoint.
Reported-by: kernel test robot
Closes: https://lore.kernel.org/r/202406011859.aacus8gv-...@intel.com/
Signed-off-by: Yan Zhai
---
v2->v3: fixed uninitialized sk, added missing report tags.
---
net/
Replace kfree_skb_reason with sk_skb_reason_drop and pass the receiving
socket to the tracepoint.
Reported-by: kernel test robot
Closes: https://lore.kernel.org/r/202406011751.npvn0ssk-...@intel.com/
Signed-off-by: Yan Zhai
---
v2->v3: added missing report tags
---
net/ipv4/udp.c | 10 +
Replace kfree_skb_reason with sk_skb_reason_drop and pass the receiving
socket to the tracepoint.
Reported-by: kernel test robot
Closes: https://lore.kernel.org/r/202406011539.jhwbd7dx-...@intel.com/
Signed-off-by: Yan Zhai
---
v2->v3: added missing report tags
---
net/ipv4/syncookies.c | 2 +-
Replace kfree_skb_reason with sk_skb_reason_drop and pass the receiving
socket to the tracepoint.
Signed-off-by: Yan Zhai
---
net/ipv4/raw.c | 4 ++--
net/ipv6/raw.c | 8
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c
index 1a0953650356..4
Replace kfree_skb_reason with sk_skb_reason_drop and pass the receiving
socket to the tracepoint.
Signed-off-by: Yan Zhai
---
net/ipv4/ping.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c
index 823306487a82..619ddc087957 100644
--- a/net/ip
Long used destructors kfree_skb and kfree_skb_reason do not pass
receiving socket to packet drop tracepoints trace_kfree_skb.
This makes it hard to track packet drops of a certain netns (container)
or a socket (user application).
The naming of these destructors are also not consistent with most sk
skb does not include enough information to find out receiving
sockets/services and netns/containers on packet drops. In theory
skb->dev tells about netns, but it can get cleared/reused, e.g. by TCP
stack for OOO packet lookup. Similarly, skb->sk often identifies a local
sender, and tells nothing ab
We set up our production packet drop monitoring around the kfree_skb
tracepoint. While this tracepoint is extremely valuable for diagnosing
critical problems, it also has some limitation with drops on the local
receive path: this tracepoint can only inspect the dropped skb itself,
but such skb migh
From: "Steven Rostedt (Google)"
Describe what ftrace_hash_move() does and add some more comments to some
other functions to make it easier to understand.
Signed-off-by: Steven Rostedt (Google)
---
kernel/trace/ftrace.c | 24 +++-
1 file changed, 23 insertions(+), 1 deletion
From: "Steven Rostedt (Google)"
The parameters "filter_hash" and "inc" in the function
ftrace_hash_rec_update_modify() are boolean. Change them to be such.
Also add documentation to what the function does.
Signed-off-by: Steven Rostedt (Google)
---
kernel/trace/ftrace.c | 33 +
From: "Steven Rostedt (Google)"
The functions ftrace_hash_rec_disable() and ftrace_hash_rec_enable()
always has 1 passed to its "ftrace_hash" parameter. Remove the parameter
and pass in true to __ftrace_hash_rec_update().
Also add some comments to both those functions explaining what they do.
S
From: "Steven Rostedt (Google)"
The name "dup_hash()" is a misnomer as it does not duplicate the hash that
is passed in, but instead moves its entities from that hash to a newly
allocated one. Rename it to "__move_hash()" (using starting underscores as
it is an internal function), and add some co
While working on the function_graph multiple users code, I realized
that I was struggling with how the ftrace code worked. Being the
author of such code meant that it wasn't very intuitive. Namely, the
function names were not descriptive enough, or at least, they needed
comments.
This series moves
From: "Steven Rostedt (Google)"
The function __ftrace_hash_rec_update() parameter "filter_hash" is only
used for true or false (boolean), but is of type int. It already has an
"inc" parameter that is boolean. This is confusing, make "filter_hash"
boolean as well.
While at it, add some documentat
On Wed, 24 Apr 2024 18:23:53 +0200, Luca Weiss wrote:
> The first patch is for removing a bogus error warning I've noticed while
> developing this on msm8226 - there the patches are also coming later for
> this SoC since apcs is getting hooked up to cpufreq there also.
>
> Apart from usages from
On Mon, Jun 03, 2024 at 01:34:38PM -0700, Tanmay Shah wrote:
> It is possible that remote processor is already running before
> linux boot or remoteproc platform driver probe. Implement required
> remoteproc framework ops to provide resource table address and
> connect or disconnect with remote pro
Adding uprobe session test that verifies the cookie value is stored
properly when single uprobe-ed function is executed recursively.
Signed-off-by: Jiri Olsa
---
.../bpf/prog_tests/uprobe_multi_test.c| 57 +++
.../progs/uprobe_multi_session_recursive.c| 44 +++
Adding uprobe session test that verifies the cookie value
get properly propagated from entry to return program.
Signed-off-by: Jiri Olsa
---
.../bpf/prog_tests/uprobe_multi_test.c| 31
.../bpf/progs/uprobe_multi_session_cookie.c | 50 +++
2 files changed, 8
Adding uprobe session test to check that just single
session instance is allowed or single uprobe.
Signed-off-by: Jiri Olsa
---
.../bpf/prog_tests/uprobe_multi_test.c| 27 +++
1 file changed, 27 insertions(+)
diff --git a/tools/testing/selftests/bpf/prog_tests/uprobe_mul
Adding uprobe session test and testing that the entry program
return value controls execution of the return probe program.
Signed-off-by: Jiri Olsa
---
.../bpf/prog_tests/uprobe_multi_test.c| 38 ++
.../bpf/progs/uprobe_multi_session.c | 52 +++
2 fil
ARRAY_SIZE is used on multiple places, move its definition in
bpf_misc.h header.
Signed-off-by: Jiri Olsa
---
tools/testing/selftests/bpf/progs/bpf_misc.h | 2 ++
tools/testing/selftests/bpf/progs/iters.c| 2 --
tools/testing/selftests/bpf/progs/kprobe_multi_s
Adding uprobe session attach type name to attach_type_name,
so libbpf_bpf_attach_type_str returns proper string name for
BPF_TRACE_UPROBE_SESSION attach type.
Signed-off-by: Jiri Olsa
---
tools/lib/bpf/libbpf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/lib/bpf/libbpf.c b/tools/li
Adding support to attach program in uprobe session mode
with bpf_program__attach_uprobe_multi function.
Adding session bool to bpf_uprobe_multi_opts struct that allows
to load and attach the bpf program via uprobe session.
the attachment to create uprobe multi session.
Also adding new program loa
Placing bpf_session_run_ctx layer in between bpf_run_ctx and
bpf_uprobe_multi_run_ctx, so the session data can be retrieved
from uprobe_multi link.
Plus granting session kfuncs access to uprobe session programs.
Signed-off-by: Jiri Olsa
---
kernel/trace/bpf_trace.c | 26
Adding support to attach bpf program for entry and return probe
of the same function. This is common use case which at the moment
requires to create two uprobe multi links.
Adding new BPF_TRACE_UPROBE_SESSION attach type that instructs
kernel to attach single link program to both entry and exit pr
Adding new set of callbacks that are triggered on entry and return
uprobe execution for the attached function.
The session means that those callbacks are 'connected' in a way
that allows to:
- control execution of return callback from entry callback
- share data between entry and return callba
hi,
this patchset is adding support for session uprobe attachment
and using it through bpf link for bpf programs.
The session means that the uprobe consumer is executed on entry
and return of probed function with additional control:
- entry callback can control execution of the return callback
From: "Steven Rostedt (Google)"
The pid filtering test will set the pid filters and make sure that both
function and function_graph tracing honors the filters. But the
function_graph tracer test was failing because the PID was not being
filtered properly. That's because the funcgraph-proc option
On Tue, 4 Jun 2024 14:57:42 -0400
Steven Rostedt wrote:
> Bah, I just ran the test.d/ftrace/func-filter-pid.tc and it fails too. This
> did pass my other tests that do run ftracetests. Hmm, I just ran it on my
> test box that does the tests and it passes there. I wonder if there's some
> config o
On Tue, 4 Jun 2024 18:04:22 +0100
Mark Rutland wrote:
> > There may have been something arch specific that I'm unaware about. I'll
> > look at that deeper.
>
> It looks like e are lines in the trace that it doesn't expect:
>
> + cat trace
> + grep -v ^#
> + grep 970
>
On 2024-06-04 12:34, Steven Rostedt wrote:
On Tue, 4 Jun 2024 11:02:16 -0400
Mathieu Desnoyers wrote:
I see.
It looks like there are a few things we could improve there:
1) With your approach, modules need to be already loaded before
attaching an fprobe event to them. This effectively preven
On 6/4/24 18:37, Steven Rostedt wrote:
> On Tue, 4 Jun 2024 17:57:46 +0200
> Daniel Bristot de Oliveira wrote:
>
>> On 6/4/24 16:42, Qais Yousef wrote:
>>> - (wakeup_rt && !dl_task(p) && !rt_task(p)) ||
>>> + (wakeup_rt && !realtime_task(p)) ||
>>
>> I do not like bikeshedding, and
The C7xv-dsp on AM62A have 32KB L1 I-cache and a 64KB L1 D-cache. It
does not have an addressable l1dram . So, remove this optional sram
property from the bindings to fix device tree build warnings.
Signed-off-by: Hari Nagalla
---
Changes in v3:
*) Use allOf keyword with separate ifs for each var
On 6/4/24 12:17 AM, Beleswar Padhi wrote:
Acquire the mailbox handle during device probe and do not release handle
in stop/detach routine or error paths. This removes the redundant
requests for mbox handle later during rproc start/attach. This also
allows to defer remoteproc driver's probe if mai
On Tue, Jun 04, 2024 at 12:31:24PM -0400, Steven Rostedt wrote:
> On Tue, 4 Jun 2024 15:44:40 +0100
> Mark Rutland wrote:
>
> > Hi Steve, Masami,
> >
> > On Tue, Jun 04, 2024 at 08:18:50AM -0400, Steven Rostedt wrote:
> > >
> > > Masami,
> > >
> > > This series passed all my tests, are you com
On Tue, 4 Jun 2024 17:57:46 +0200
Daniel Bristot de Oliveira wrote:
> On 6/4/24 16:42, Qais Yousef wrote:
> > - (wakeup_rt && !dl_task(p) && !rt_task(p)) ||
> > + (wakeup_rt && !realtime_task(p)) ||
>
> I do not like bikeshedding, and no hard feelings...
>
> But rt is a shortened
On Tue, 4 Jun 2024 11:02:16 -0400
Mathieu Desnoyers wrote:
> I see.
>
> It looks like there are a few things we could improve there:
>
> 1) With your approach, modules need to be already loaded before
> attaching an fprobe event to them. This effectively prevents
> attaching to any module init
On Tue, 4 Jun 2024 15:44:40 +0100
Mark Rutland wrote:
> Hi Steve, Masami,
>
> On Tue, Jun 04, 2024 at 08:18:50AM -0400, Steven Rostedt wrote:
> >
> > Masami,
> >
> > This series passed all my tests, are you comfortable with me pushing
> > them to linux-next?
>
> As a heads-up (and not to bl
On Tue, 4 Jun 2024 15:42:28 +0100
Qais Yousef wrote:
> {rt, realtime, dl}_{task, prio}() functions return value is actually
> a bool. Convert their return type to reflect that.
>
> Suggested-by: Steven Rostedt (Google)
> Signed-off-by: Qais Yousef
> ---
> include/linux/sched/deadline.h | 8
On 6/4/24 16:42, Qais Yousef wrote:
> - (wakeup_rt && !dl_task(p) && !rt_task(p)) ||
> + (wakeup_rt && !realtime_task(p)) ||
I do not like bikeshedding, and no hard feelings...
But rt is a shortened version of realtime, and so it is making *it less*
clear that we also have DL here
Hi Tanmay,
On Mon, Jun 03, 2024 at 01:34:38PM -0700, Tanmay Shah wrote:
> It is possible that remote processor is already running before
> linux boot or remoteproc platform driver probe. Implement required
> remoteproc framework ops to provide resource table address and
> connect or disconnect wit
On Mon, 03 Jun 2024 02:28:55 -0400, Alexandre Messier wrote:
> Add an initial device tree to support the HTC One (M8) smartphone,
> aka "htc,m8".
>
> Signed-off-by: Alexandre Messier
> ---
> Alexandre Messier (2):
> dt-bindings: arm: qcom: add HTC One (M8)
> ARM: dts: qcom: Add init
On Mon, 3 Jun 2024 08:33:53 +0100
Metin Kaya wrote:
> On 01/06/2024 10:33 pm, Qais Yousef wrote:
> > {rt, realtime, dl}_{task, prio}() functions return value is actually
> > a bool. Convert their return type to reflect that.
> >
> > Suggested-by: Steven Rostedt (Google)
> > Signed-off-by: Qais
On Sat, 1 Jun 2024 17:22:55 +0900
"Masami Hiramatsu (Google)" wrote:
> From: Masami Hiramatsu (Google)
>
> Add a test case for tracepoint events on modules. This checks if it can add
> and remove the events correctly.
>
> Signed-off-by: Masami Hiramatsu (Google)
Reviewed-by: Steven Rostedt
On Tue, 4 Jun 2024 08:49:55 +0900
Masami Hiramatsu (Google) wrote:
> On Mon, 3 Jun 2024 15:50:55 -0400
> Mathieu Desnoyers wrote:
>
> > On 2024-06-01 04:22, Masami Hiramatsu (Google) wrote:
> > > From: Masami Hiramatsu (Google)
> > >
> > > Support raw tracepoint event on module by fprobe ev
On 2024-06-03 19:49, Masami Hiramatsu (Google) wrote:
On Mon, 3 Jun 2024 15:50:55 -0400
Mathieu Desnoyers wrote:
On 2024-06-01 04:22, Masami Hiramatsu (Google) wrote:
From: Masami Hiramatsu (Google)
Support raw tracepoint event on module by fprobe events.
Since it only uses for_each_kernel_
Hi,
We are pleased to announce the call for presentations for the
Confidential Computing microconference at the Linux Plumbers Conference,
happening in Vienna from September 18th to 20th.
In this microconference we want to discuss ongoing developments around Linux
support for memory encryption an
Hi,
We are pleased to announce that the Confidential Computing Microconference has
been accepted into this years Linux Plumbers Conference, happening from
September 18th to 20th in Vienna, Austria.
With this Call for Registration we want to encourage everyone interested in
this microconference to
{rt, realtime, dl}_{task, prio}() functions return value is actually
a bool. Convert their return type to reflect that.
Suggested-by: Steven Rostedt (Google)
Signed-off-by: Qais Yousef
---
include/linux/sched/deadline.h | 8 +++-
include/linux/sched/rt.h | 16 ++--
2 fil
Hi Steve, Masami,
On Tue, Jun 04, 2024 at 08:18:50AM -0400, Steven Rostedt wrote:
>
> Masami,
>
> This series passed all my tests, are you comfortable with me pushing
> them to linux-next?
As a heads-up (and not to block pushing this into next), I just gave
this a spin on arm64 atop v6.10-rc2,
rt_task() checks if a task has RT priority. But depends on your
dictionary, this could mean it belongs to RT class, or is a 'realtime'
task, which includes RT and DL classes.
Since this has caused some confusion already on discussion [1], it
seemed a clean up is due.
I define the usage of rt_task
Make rt_task() return true only for RT class and add new realtime_task() to
return true for RT and DL classes to avoid some confusion the old API can
cause.
No functional changes intended in patch 1. Patch 2 cleans up the return type as
suggested by Steve.
Changes since v4:
* Simplify re
On Tue, Jun 04, 2024 at 04:14:51PM +0800, zhang warden wrote:
>
>
> > On Jun 1, 2024, at 03:16, Joe Lawrence wrote:
> >
> > Adding these attributes to livepatch sysfs would be expedient and
> > probably easier for us to use, but imposes a recurring burden on us to
> > maintain and test (where i
On Tue, 4 Jun 2024 23:18:29 +0900
Masami Hiramatsu (Google) wrote:
> BTW, some these bootup tests can be ported on KUnit. Do you have a plan to
> use KUnit?
I haven't thought about that. If someone else wants to do it, I will
happily review it ;-)
-- Steve
On Tue, 4 Jun 2024 08:18:50 -0400
Steven Rostedt wrote:
>
> Masami,
>
> This series passed all my tests, are you comfortable with me pushing
> them to linux-next?
Yes, this series looks good to me too.
Reviewed-by: Masami Hiramatsu (Google)
for the series.
Thank you!
>
> -- Steve
>
>
>
On Tue, 4 Jun 2024 09:57:46 -0400
Steven Rostedt wrote:
> On Fri, 31 May 2024 23:20:47 +0900
> Masami Hiramatsu (Google) wrote:
>
> > The major conflict happens when the boot-time test cleans up the kprobe
> > events by
> >
> > dyn_events_release_all(&trace_kprobe_ops);
> >
> > And I remove
On Fri, 31 May 2024 23:20:47 +0900
Masami Hiramatsu (Google) wrote:
> The major conflict happens when the boot-time test cleans up the kprobe
> events by
>
> dyn_events_release_all(&trace_kprobe_ops);
>
> And I removed it by [3/3] patch in this series :) because it does not
> needed and not c
On 06/03/24 08:33, Metin Kaya wrote:
> On 01/06/2024 10:33 pm, Qais Yousef wrote:
> > {rt, realtime, dl}_{task, prio}() functions return value is actually
> > a bool. Convert their return type to reflect that.
> >
> > Suggested-by: Steven Rostedt (Google)
> > Signed-off-by: Qais Yousef
> > ---
Masami,
This series passed all my tests, are you comfortable with me pushing
them to linux-next?
-- Steve
On Mon, 03 Jun 2024 15:07:04 -0400
Steven Rostedt wrote:
> This is a continuation of the function graph multi user code.
> I wrote a proof of concept back in 2019 of this code[1] and
>
On 6/3/24 08:28, Alexandre Messier via B4 Relay wrote:
From: Alexandre Messier
Add initial device tree for the HTC One (M8) smartphone.
Initial support includes:
- eMMC
- Power button
- USB
- Vibrator
- Volume buttons (GPIO)
- Wi-Fi
Signed-off-by: Alexandre Messier
---
Revie
> My intention to introduce this attitude to sysfs is that user who what to see
> if this function is called can just need to show this function attribute in
> the livepatch sysfs interface.
>
Sorry bros,
There is a typo in my word : attitude -> attribute
Autocomplete make it wrong….lol..
> On May 31, 2024, at 22:06, Miroslav Benes wrote:
>
>> And for the unlikely branch, isn’t the complier will compile this branch
>> into a cold branch that will do no harm to the function performance?
>
> The test (cmp insn or something like that) still needs to be there. Since
> there is o
> On Jun 1, 2024, at 03:16, Joe Lawrence wrote:
>
> Adding these attributes to livepatch sysfs would be expedient and
> probably easier for us to use, but imposes a recurring burden on us to
> maintain and test (where is the documentation and kselftest for this new
> interface?). Or, we could
Hello Rob
On 6/3/24 16:35, Rob Herring wrote:
> On Tue, May 21, 2024 at 02:24:54PM +0200, Arnaud Pouliquen wrote:
>> Add the "st,proc-id" property allowing to identify the remote processor.
>> This ID is used to define an unique ID, common between Linux, U-boot and
>> OP-TEE to identify a coproces
76 matches
Mail list logo
