Re: [PATCH v16 14/15] mtd: spi-nor: spansion: add support for Cypress Semper flash

2020-11-06 Thread Vignesh Raghavendra
Hi, [...] On 10/5/20 9:01 PM, Pratyush Yadav wrote: > +static int spi_nor_cypress_octal_dtr_enable(struct spi_nor *nor, bool enable) > +{ > + struct spi_mem_op op; > + u8 *buf = nor->bouncebuf; > + int ret; > + > + if (enable) { > + /* Use 24 dummy cycles for memory ar

[PATCH] netfilter: conntrack: fix -Wformat

2020-11-06 Thread Nick Desaulniers
Clang is more aggressive about -Wformat warnings when the format flag specifies a type smaller than the parameter. Fixes 8 instances of: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat] Link: https://github.com/ClangBuiltLinux/linux/issues/378 Signed-off-

Re: [PATCH] KVM: PPC: Book3S: Assign boolean values to a bool variable

2020-11-06 Thread Greg Kurz
On Sat, 7 Nov 2020 14:26:22 +0800 xiakaixu1...@gmail.com wrote: > From: Kaixu Xia > > Fix the following coccinelle warnings: > > ./arch/powerpc/kvm/book3s_xics.c:476:3-15: WARNING: Assignment of 0/1 to bool > variable > ./arch/powerpc/kvm/book3s_xics.c:504:3-15: WARNING: Assignment of 0/1 to

[PATCH v3 bpf] trace: bpf: Fix passing zero to PTR_ERR()

2020-11-06 Thread Wang Qing
There is a bug when passing zero to PTR_ERR() and return. Fix smatch err. Signed-off-by: Wang Qing --- kernel/trace/bpf_trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c index 4517c8b..5113fd4 --- a/kernel/trace/bpf_tr

Re: [PATCH v4 1/4] dt-bindings: usb: add rk3328 dwc3 docs

2020-11-06 Thread Felipe Balbi
Hi, Lindsey Stanpoor writes: > On Wed, Sep 2, 2020 at 11:12 AM wrote: >> >> From: Cameron Nemo >> >> Document compatible for dwc3 on the Rockchip rk3328 platform. > > Hi all, > > Wanted to give this patch submission a gentle ping. > > Rob Herring acked the documentation changes, but I have not

[GIT PULL] RISC-V Fixes for 5.10-rc3

2020-11-06 Thread Palmer Dabbelt
The following changes since commit 3650b228f83adda7e5ee532e2b90429c03f7b9ec: Linux 5.10-rc1 (2020-10-25 15:14:11 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git tags/riscv-for-linus-5.10-rc3 for you to fetch changes up to c2c81bb

Re: [V2] trace: Fix passing zero to PTR_ERR()

2020-11-06 Thread Yonghong Song
On 11/6/20 10:34 PM, Wang Qing wrote: There is a bug when passing zero to PTR_ERR() and return. Fix smatch err. Signed-off-by: Wang Qing For clarity, the subject probably should be bpf: Fix passing zero to PTR_ERR() to indicate this is a bpf related fix. The tag should be something like

[PATCH] Kbuild: enable -Wfallthrough for clang

2020-11-06 Thread Nick Desaulniers
Partial revert of commit e2079e93f562 ("kbuild: Do not enable -Wimplicit-fallthrough for clang for now") This has been fixed up over time thanks to the addition of "fallthrough" pseudo-keyword in commit 294f69e662d1 ("compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use") L

[PATCH v7] mm/zswap: move to use crypto_acomp API for hardware acceleration

2020-11-06 Thread Barry Song
Right now, all new ZIP drivers are adapted to crypto_acomp APIs rather than legacy crypto_comp APIs. Tradiontal ZIP drivers like lz4,lzo etc have been also wrapped into acomp via scomp backend. But zswap.c is still using the old APIs. That means zswap won't be able to work on any new ZIP drivers in

[PATCH] net/mlx4: Assign boolean values to a bool variable

2020-11-06 Thread xiakaixu1987
From: Kaixu Xia Fix the following coccinelle warnings: ./drivers/net/ethernet/mellanox/mlx4/en_rx.c:687:1-17: WARNING: Assignment of 0/1 to bool variable Reported-by: Tosk Robot Signed-off-by: Kaixu Xia --- drivers/net/ethernet/mellanox/mlx4/en_rx.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] fork: fix copy_process(CLONE_PARENT) race with the exiting ->real_parent

2020-11-06 Thread Eddy Wu
current->group_leader->exit_signal may change during copy_process() if current->real_parent exits, move the assignment inside tasklist_lock to avoid the race. Signed-off-by: Eddy Wu --- kernel/fork.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/fork.c b/k

[V2] trace: Fix passing zero to PTR_ERR()

2020-11-06 Thread Wang Qing
There is a bug when passing zero to PTR_ERR() and return. Fix smatch err. Signed-off-by: Wang Qing --- kernel/trace/bpf_trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c index 4517c8b..5113fd4 --- a/kernel/trace/bpf_tr

[PATCH] scsi: ses: Fix crash caused by kfree an invalid pointer

2020-11-06 Thread Ding Hui
We can get a crash when disconnecting the iSCSI session, the call trace like this: [2a00fb70] kfree at 0830e224 [2a00fba0] ses_intf_remove at 01f200e4 [2a00fbd0] device_del at 086b6a98 [2a00fc50] device_unregister at 086b6d58

[PATCH net-next 06/11] net: hns3: add ethtool priv-flag for DIM

2020-11-06 Thread Huazhong Tan
Add a control private flag in ethtool for enable/disable DIM feature. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hnae3.h| 7 +++ drivers/net/ethernet/hisilicon/hns3/hns3_enet.c| 1 + drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 71 ++

[PATCH net-next 04/11] net: hns3: rename gl_adapt_enable in struct hns3_enet_coalesce

2020-11-06 Thread Huazhong Tan
Besides GL(Gap Limiting), QL(Quantity Limiting) can be modified dynamically when DIM is supported. So rename gl_adapt_enable as adapt_enable in struct hns3_enet_coalesce. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c| 12 ++-- drivers/net/ethernet/hi

[PATCH net-next 08/11] net: hns3: add a check for ethtool priv-flag interface

2020-11-06 Thread Huazhong Tan
Add a check for hns3_set_priv_flags() since if the capability is unsupported its private flags should not be modified as well. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hnae3.h| 1 + drivers/net/ethernet/hisilicon/hns3/hns3_enet.c| 1 + drivers/net/etherne

[PATCH net-next 10/11] net: hns3: add ethtool priv-flag for EQ/CQ

2020-11-06 Thread Huazhong Tan
Add a control private flag in ethtool for switching EQ/CQ mode. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hnae3.h| 2 ++ drivers/net/ethernet/hisilicon/hns3/hns3_enet.c| 19 -- drivers/net/ethernet/hisilicon/hns3/hns3_enet.h| 2 ++ driv

[PATCH net-next 01/11] net: hns3: add support for configuring interrupt quantity limiting

2020-11-06 Thread Huazhong Tan
QL(quantity limiting) means that hardware supports the interrupt coalesce based on the frame quantity. QL can be configured when int_ql_max in device's specification is non-zero, so add support to configure it. Also, rename two coalesce init function to fit their purpose. Signed-off-by: Huazhong

[PATCH net-next 00/11] net: hns3: updates for -next

2020-11-06 Thread Huazhong Tan
There are several updates relating to the interrupt coalesce for the HNS3 ethernet driver. #1 adds support for QL(quantity limiting, interrupt coalesce based on the frame quantity). #2 adds support for 1us unit GL(gap limiting, interrupt coalesce based on the gap time). #3 queries the maximu

[PATCH net-next 07/11] net: hns3: add hns3_state_init() to do state initialization

2020-11-06 Thread Huazhong Tan
To improve the readability and maintainability, add hns3_state_init() to initialize the state. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/h

[PATCH net-next 11/11] net: hns3: add debugfs support for interrupt coalesce

2020-11-06 Thread Huazhong Tan
Since user may need to check the current configuration of the interrupt coalesce, so add debugfs support for query this info, which includes DIM profile, coalesce configuration of both software and hardware. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 124

[PATCH net-next 09/11] net: hns3: add support for EQ/CQ mode configuration

2020-11-06 Thread Huazhong Tan
For device whose version is above V3(include V3), the GL can select EQ or CQ mode, so adds support for it. In CQ mode, the coalesced timer will restart upon new completion, while in EQ mode, the timer will not restart. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hnae3.h

[PATCH net-next 05/11] net: hns3: add support for dynamic interrupt moderation

2020-11-06 Thread Huazhong Tan
Add dynamic interrupt moderation support for the HNS3 driver. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/Kconfig | 1 + drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 87 - drivers/net/ethernet/hisilicon/hns3/hns3_enet.h | 4 ++ 3 files c

[PATCH net-next 03/11] net: hns3: add support for querying maximum value of GL

2020-11-06 Thread Huazhong Tan
For maintainability and compatibility, add support for querying the maximum value of GL. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hnae3.h | 1 + drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c| 1 + drivers/net/ethernet/hisilicon/hns3/hns3_en

[PATCH net-next 02/11] net: hns3: add support for 1us unit GL configuration

2020-11-06 Thread Huazhong Tan
For device whose version is above V3(include V3), the GL configuration can set as 1us unit, so adds support for configuring this field. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c| 26 ++ drivers/net/ethernet/hisilicon/hns3/hns3_enet.h

[PATCH] KVM: PPC: Book3S: Assign boolean values to a bool variable

2020-11-06 Thread xiakaixu1987
From: Kaixu Xia Fix the following coccinelle warnings: ./arch/powerpc/kvm/book3s_xics.c:476:3-15: WARNING: Assignment of 0/1 to bool variable ./arch/powerpc/kvm/book3s_xics.c:504:3-15: WARNING: Assignment of 0/1 to bool variable Reported-by: Tosk Robot Signed-off-by: Kaixu Xia --- arch/pow

Re: [PATCH v2 1/1] Fonts: Replace discarded const qualifier

2020-11-06 Thread Peilin Ye
Hi all, On Tue, Nov 03, 2020 at 10:55:23AM +, Lee Jones wrote: > Would you be kind enough to let us know when this lands in Mainline > please? We'll need to back-port it to start fixing up our Stable > kernels ASAP. Patch is in mainline now: 9522750c66c689b739e151fcdf895420dc81efc0 Fonts: R

Re: [PATCH v4] checkpatch: improve email parsing

2020-11-06 Thread Joe Perches
On Sat, 2020-11-07 at 10:11 +0530, Dwaipayan Ray wrote: > On Sat, Nov 7, 2020 at 3:34 AM Joe Perches wrote: > > > > On Sat, 2020-11-07 at 03:15 +0530, Dwaipayan Ray wrote: > > > checkpatch doesn't report warnings for many common mistakes > > > in emails. Some of which are trailing commas and inco

Re: [RFC] proc: get_wchan() stack unwind only makes sense for sleeping/non-self tasks

2020-11-06 Thread Andrew Morton
On Thu, 5 Nov 2020 15:11:32 -0800 Vineet Gupta wrote: > Most architectures currently check this in their get_wchan() implementation > (ARC doesn't hence this patch). However doing this in core code shows > the semantics better so move the check one level up (eventually remove > the boiler-plate

Re: [PATCH v6 2/2] fs: ext4: Modify inode-test.c to use KUnit parameterized testing feature

2020-11-06 Thread David Gow
On Sat, Nov 7, 2020 at 3:23 AM Arpitha Raghunandan <98.a...@gmail.com> wrote: > > Modify fs/ext4/inode-test.c to use the parameterized testing > feature of KUnit. > > Signed-off-by: Arpitha Raghunandan <98.a...@gmail.com> > --- This looks good to me. Thanks! Reviewed-by: David Gow -- David

Re: [PATCH v6 1/2] kunit: Support for Parameterized Testing

2020-11-06 Thread David Gow
On Sat, Nov 7, 2020 at 3:22 AM Arpitha Raghunandan <98.a...@gmail.com> wrote: > > Implementation of support for parameterized testing in KUnit. > This approach requires the creation of a test case using the > KUNIT_CASE_PARAM macro that accepts a generator function as input. > This generator functi

Re: [PATCH v4] checkpatch: improve email parsing

2020-11-06 Thread Dwaipayan Ray
On Sat, Nov 7, 2020 at 3:34 AM Joe Perches wrote: > > On Sat, 2020-11-07 at 03:15 +0530, Dwaipayan Ray wrote: > > checkpatch doesn't report warnings for many common mistakes > > in emails. Some of which are trailing commas and incorrect > > use of email comments. > > Assuming it all works, this lo

Re: [PATCH 1/3 v4] ftrace: Have the callbacks receive a struct ftrace_regs instead of pt_regs

2020-11-06 Thread Masami Hiramatsu
On Fri, 06 Nov 2020 16:42:35 -0500 Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > In preparation to have arguments of a function passed to callbacks attached > to functions as default, change the default callback prototype to receive a > struct ftrace_regs as the forth parameter in

Re: [PATCH] Documentation: kunit: provide guidance for testing many inputs

2020-11-06 Thread David Gow
On Tue, Nov 3, 2020 at 5:37 AM Daniel Latypov wrote: > > usage.rst goes into a detailed about faking out classes, but currently Nit: a detailed what? > lacks wording about how one might idiomatically test a range of inputs. > > Give an example of how one might test a hash function via macros/hel

Re: [PATCH v1] kunit: tool: unmark test_data as binary blobs

2020-11-06 Thread David Gow
On Fri, Nov 6, 2020 at 7:24 AM Brendan Higgins wrote: > > The tools/testing/kunit/test_data/ directory was marked as binary > because some of the test_data files cause checkpatch warnings. Fix this > by dropping the .gitattributes file. > > Fixes: afc63da64f1e ("kunit: kunit_parser: make parser mo

[PATCH 0/2] drivers/tty: delete break after return or goto

2020-11-06 Thread Bernard Zhao
Hi, Greg: This patch sereies delete code which never run: { case XXX: return XXX; break; //The break is meanless, so just delete it. case YYY: goto YYY; break; //The break is meanless, so just delete it. .. } Bernard Zhao (2): tty/serial: delete break after r

[PATCH 1/2] tty/serial: delete break after return

2020-11-06 Thread Bernard Zhao
Delete break after return, which will never run. Signed-off-by: Bernard Zhao --- drivers/tty/serial/imx.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 1731d9728865..09703079db7b 100644 --- a/drivers/tty/serial/imx.c +++ b/drive

[PATCH 2/2] drivers/tty: delete break after goto/return

2020-11-06 Thread Bernard Zhao
Delete break after goto/return, which will never run. Signed-off-by: Bernard Zhao --- drivers/tty/nozomi.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index d42b854cb7df..946cc16827aa 100644 --- a/drivers/tty/nozomi.c +++ b/drivers/tty/nozom

[V2] [PATCH] net/ethernet: update ret when ptp_clock is ERROR

2020-11-06 Thread Wang Qing
We always have to update the value of ret, otherwise the error value may be the previous one. And ptp_clock_register() never return NULL when PTP_1588_CLOCK enable, so we use IS_ERR here. Signed-off-by: Wang Qing --- drivers/net/ethernet/ti/am65-cpts.c | 5 ++--- 1 file changed, 2 insertions(+

[PATCH] pcp_clock: return EOPNOTSUPP if !CONFIG_PTP_1588_CLOCK

2020-11-06 Thread Wang Qing
pcp_clock_register() is checked with IS_ERR(), and will crash if !PTP, change return value to ERR_PTR(-EOPNOTSUPP) for the !CONFIG_PTP_1588_CLOCK and so question resolved. Signed-off-by: Wang Qing --- include/linux/ptp_clock_kernel.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [PATCH] MAINTAINERS: add missing file in ext4 entry

2020-11-06 Thread Theodore Y. Ts'o
On Fri, Oct 30, 2020 at 10:24:35AM +0800, Chao Yu wrote: > include/trace/events/ext4.h belongs to ext4 module, add the file path into > ext4 entry in MAINTAINERS. > > Signed-off-by: Chao Yu Thanks, applied. - Ted

[V2] drm: msm: adreno: use IS_ERR() instead of null pointer check

2020-11-06 Thread Wang Qing
a6xx_gmu_get_mmio() never return null in case of error, but ERR_PTR(), so we should use IS_ERR() instead of null pointer check and IS_ERR_OR_NULL(). Signed-off-by: Wang Qing --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drive

Re: [PATCH memory-model 5/8] tools/memory-model: Add a glossary of LKMM terms

2020-11-06 Thread Boqun Feng
On Fri, Nov 06, 2020 at 10:01:02AM -0800, Paul E. McKenney wrote: > On Fri, Nov 06, 2020 at 09:47:22AM +0800, Boqun Feng wrote: > > On Thu, Nov 05, 2020 at 02:00:14PM -0800, paul...@kernel.org wrote: > > > From: "Paul E. McKenney" > > > > > > Signed-off-by: Paul E. McKenney > > > --- > > > tool

Re: [RFC PATCH 14/15] PCI/P2PDMA: Introduce pci_mmap_p2pmem()

2020-11-06 Thread Logan Gunthorpe
On 2020-11-06 5:14 p.m., Jason Gunthorpe wrote: > On Fri, Nov 06, 2020 at 01:03:26PM -0700, Logan Gunthorpe wrote: >> I don't think a function like that will work for the p2pmem use case. In >> order to implement proper page freeing I expect I'll need a loop around >> the allocator and vm_insert

Re: [PATCH net-next v4 0/5] bonding: rename bond components

2020-11-06 Thread Jakub Kicinski
On Fri, 6 Nov 2020 15:04:31 -0500 Jarod Wilson wrote: > The bonding driver's use of master and slave, while largely understood > in technical circles, poses a barrier for inclusion to some potential > members of the development and user community, due to the historical > context of masters and sla

Re: [PATCH] ASoC: fsl_aud2htx: Remove dev_err() usage after platform_get_irq()

2020-11-06 Thread Nicolin Chen
On Sat, Nov 07, 2020 at 10:20:43AM +0800, Shengjiu Wang wrote: > platform_get_irq() would print error message internally, so dev_err() > after platform_get_irq() is not needed > > Signed-off-by: Shengjiu Wang Acked-by: Nicolin Chen

Re: [PATCH v4 1/4] dt-bindings: usb: add rk3328 dwc3 docs

2020-11-06 Thread Lindsey Stanpoor
On Wed, Sep 2, 2020 at 11:12 AM wrote: > > From: Cameron Nemo > > Document compatible for dwc3 on the Rockchip rk3328 platform. Hi all, Wanted to give this patch submission a gentle ping. Rob Herring acked the documentation changes, but I have not heard anything from the USB or Rockchip mainta

Re: [PATCH memory-model 5/8] tools/memory-model: Add a glossary of LKMM terms

2020-11-06 Thread Alan Stern
On Fri, Nov 06, 2020 at 01:04:13PM -0800, Paul E. McKenney wrote: > On Fri, Nov 06, 2020 at 03:40:08PM -0500, Alan Stern wrote: > > Is it really true that data dependencies are so easily destroyed? I > > would expect that a true "semantic" dependency (i.e., one where the > > value written really

[PATCH] ASoC: fsl_aud2htx: Remove dev_err() usage after platform_get_irq()

2020-11-06 Thread Shengjiu Wang
platform_get_irq() would print error message internally, so dev_err() after platform_get_irq() is not needed Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_aud2htx.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/sound/soc/fsl/fsl_aud2htx.c b/sound/soc/fsl/fsl_aud2ht

[PATCH RT 3/6] mm/memcontrol: Disable preemption in __mod_memcg_lruvec_state()

2020-11-06 Thread Steven Rostedt
5.4.74-rt42-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior The callers expect disabled preemption/interrupts while invoking __mod_memcg_lruvec_state(). This works mainline because a lock of somekind is acquired. Use

[PATCH RT 1/6] net: Properly annotate the try-lock for the seqlock

2020-11-06 Thread Steven Rostedt
5.4.74-rt42-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior In patch ("net/Qdisc: use a seqlock instead seqcount") the seqcount has been replaced with a seqlock to allow to reader to boost the preempted writer. Th

[PATCH RT 6/6] Linux 5.4.74-rt42-rc1

2020-11-06 Thread Steven Rostedt
5.4.74-rt42-rc1 stable review patch. If anyone has any objections, please let me know. -- From: "Steven Rostedt (VMware)" --- localversion-rt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/localversion-rt b/localversion-rt index 629e0b4384b8..31c892a05e4d 1

[PATCH RT 5/6] timers: Dont block on ->expiry_lock for TIMER_IRQSAFE

2020-11-06 Thread Steven Rostedt
5.4.74-rt42-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior PREEMPT_RT does not spin and wait until a running timer completes its callback but instead it blocks on a sleeping lock to prevent a deadlock. This blocking

[PATCH RT 4/6] ptrace: fix ptrace_unfreeze_traced() race with rt-lock

2020-11-06 Thread Steven Rostedt
5.4.74-rt42-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Oleg Nesterov The patch "ptrace: fix ptrace vs tasklist_lock race" changed ptrace_freeze_traced() to take task->saved_state into account, but ptrace_unfreeze_traced() has the same pro

[PATCH RT 0/6] Linux 5.4.74-rt42-rc1

2020-11-06 Thread Steven Rostedt
Dear RT Folks, This is the RT stable review cycle of patch 5.4.74-rt42-rc1. Please scream at me if I messed something up. Please test the patches too. The -rc release will be uploaded to kernel.org and will be deleted when the final release is out. This is just a review release (or release can

[PATCH RT 2/6] tcp: Remove superfluous BH-disable around listening_hash

2020-11-06 Thread Steven Rostedt
5.4.74-rt42-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior Commit 9652dc2eb9e40 ("tcp: relax listening_hash operations") removed the need to disable bottom half while acquiring listening_hash.lock. There are stil

Re: [PATCH] Revert "mm/vunmap: add cond_resched() in vunmap_pmd_range"

2020-11-06 Thread Andrew Morton
On Thu, 5 Nov 2020 09:02:49 -0800 Minchan Kim wrote: > This reverts commit e47110e90584a22e9980510b00d0dfad3a83354e. > > While I was doing zram testing, I found sometimes decompression failed > since the compression buffer was corrupted. With investigation, > I found below commit calls cond_res

Re: [PATCH RFC] driver core: Ensure DT devices always have fwnode set

2020-11-06 Thread Saravana Kannan
On Fri, Nov 6, 2020 at 11:23 AM Mark Brown wrote: > > On Fri, Nov 06, 2020 at 11:09:17AM -0800, Saravana Kannan wrote: > > > If you want to do this in "one common place", then I think the way to > > do this is have include/linux/of.h provide something like: > > > void of_set_device_of_node(dev, of

Re: [PATCH v2 bpf-next 1/5] bpf: add in-kernel split BTF support

2020-11-06 Thread Andrii Nakryiko
On Fri, Nov 6, 2020 at 5:28 PM Song Liu wrote: > > > > > On Nov 6, 2020, at 3:02 PM, Andrii Nakryiko wrote: > > > > Adjust in-kernel BTF implementation to support a split BTF mode of > > operation. > > Changes are mostly mirroring libbpf split BTF changes, with the exception of > > start_id bein

Re: [PATCH v4 06/17] PCI: add SIOV and IMS capability detection

2020-11-06 Thread Dan Williams
On Fri, Nov 6, 2020 at 4:12 PM Jason Gunthorpe wrote: > > On Fri, Nov 06, 2020 at 03:47:00PM -0800, Dan Williams wrote: [..] > The only sane way to implement this generically is for the VMM to > provide a hypercall to obtain a real *working* addr/data pair(s) and > then have the platform hand thos

Re: [PATCH] mm/memcontrol:rewrite mem_cgroup_page_lruvec()

2020-11-06 Thread Andrew Morton
On Wed, 4 Nov 2020 22:25:16 +0800 Hui Su wrote: > mem_cgroup_page_lruvec() in memcontrol.c and > mem_cgroup_lruvec() in memcontrol.h is very similar > except for the param(page and memcg) which also can be > convert to each other. > > So rewrite mem_cgroup_page_lruvec() with mem_cgroup_lruvec().

Re: [PATCH v2 bpf-next 1/5] bpf: add in-kernel split BTF support

2020-11-06 Thread Song Liu
> On Nov 6, 2020, at 3:02 PM, Andrii Nakryiko wrote: > > Adjust in-kernel BTF implementation to support a split BTF mode of operation. > Changes are mostly mirroring libbpf split BTF changes, with the exception of > start_id being 0 for in-kernel implementation due to simpler read-only mode. >

Re: [PATCH 4/9 next] fs/io_uring Don't use the return value from import_iovec().

2020-11-06 Thread Pavel Begunkov
On 15/09/2020 15:55, David Laight wrote: > > This is the only code that relies on import_iovec() returning > iter.count on success. > This allows a better interface to import_iovec(). Seems this got nowhere. I'll pick it and send with some other patches to Jens. > Signed-off-by: David Laight >

[PATCH v2] x86/xen: don't unbind uninitialized lock_kicker_irq

2020-11-06 Thread Brian Masney
When booting a hyperthreaded system with the kernel parameter 'mitigations=auto,nosmt', the following warning occurs: WARNING: CPU: 0 PID: 1 at drivers/xen/events/events_base.c:1112 unbind_from_irqhandler+0x4e/0x60 ... Hardware name: Xen HVM domU, BIOS 4.2.amazon 08/24/2006 ...

Re: [PATCH v4 2/5] arm64, numa: Change the numa init functions name to be generic

2020-11-06 Thread Atish Patra
On Fri, Nov 6, 2020 at 11:08 AM Catalin Marinas wrote: > > On Fri, Nov 06, 2020 at 09:33:14AM -0800, Atish Patra wrote: > > On Fri, Nov 6, 2020 at 9:14 AM Catalin Marinas > > wrote: > > > On Mon, Oct 05, 2020 at 05:17:49PM -0700, Atish Patra wrote: > > > > diff --git a/arch/arm64/kernel/acpi_num

Re: [PATCH v9 2/7] rcu/segcblist: Add counters to segcblist datastructure

2020-11-06 Thread Paul E. McKenney
On Fri, Nov 06, 2020 at 07:18:47PM -0500, Joel Fernandes wrote: > On Fri, Nov 06, 2020 at 07:01:57PM -0500, Joel Fernandes wrote: > > On Wed, Nov 04, 2020 at 09:01:33AM -0800, Paul E. McKenney wrote: > > > > > A casual reader might be forgiven for being confused by the combination > > > of "Return

Re: [Y2038][time namespaces] Question regarding CLOCK_REALTIME support plans in Linux time namespaces

2020-11-06 Thread Thomas Gleixner
On Thu, Nov 05 2020 at 12:25, Carlos O'Donell wrote: > On 10/30/20 9:38 PM, Thomas Gleixner wrote: > If kata grows up quickly perhaps this entire problem becomes solved, but until > then I continue to have a testing need for a distinct CLOCK_REALTIME in a > time namespace (and it need not be uncond

Re: [PATCH] x86/xen: fix warning when running with nosmt mitigations

2020-11-06 Thread boris . ostrovsky
On 11/5/20 7:47 PM, Brian Masney wrote: > On Thu, Nov 05, 2020 at 07:35:29PM -0500, Brian Masney wrote: >> diff --git a/arch/x86/xen/spinlock.c b/arch/x86/xen/spinlock.c >> index 799f4eba0a62..4a052459a08e 100644 >> --- a/arch/x86/xen/spinlock.c >> +++ b/arch/x86/xen/spinlock.c >> @@ -93,9 +93,24

Re: [PATCH] interconnect: qcom: msm8974: Prevent integer overflow in rate

2020-11-06 Thread Brian Masney
On Fri, Nov 06, 2020 at 04:48:47PM +0200, Georgi Djakov wrote: > When sync_state support got introduced recently, by default we try to > set the NoCs to run initially at maximum rate. But as these values are > aggregated, we may end with a really big clock rate value, which is > then converted from

RE: [PATCH v4 06/17] PCI: add SIOV and IMS capability detection

2020-11-06 Thread Thomas Gleixner
On Fri, Nov 06 2020 at 09:48, Kevin Tian wrote: >> From: Jason Gunthorpe >> On Wed, Nov 04, 2020 at 01:34:08PM +, Tian, Kevin wrote: >> The interrupt controller is responsible to create an addr/data pair >> for an interrupt message. It sets the message format and ensures it >> routes to the pr

Re: [PATCH v9 5/7] rcu/segcblist: Remove useless rcupdate.h include

2020-11-06 Thread Joel Fernandes
On Thu, Nov 05, 2020 at 06:28:10AM -0800, Paul E. McKenney wrote: > On Wed, Nov 04, 2020 at 07:48:23PM -0800, Paul E. McKenney wrote: > > On Tue, Nov 03, 2020 at 09:26:01AM -0500, Joel Fernandes (Google) wrote: > > > Signed-off-by: Joel Fernandes (Google) > > > > This one looks fine, but depends

Re: [PATCH v9 6/7] rcu/tree: segcblist: Remove redundant smp_mb()s

2020-11-06 Thread Joel Fernandes
On Wed, Nov 04, 2020 at 07:57:13PM -0800, Paul E. McKenney wrote: > On Tue, Nov 03, 2020 at 09:26:02AM -0500, Joel Fernandes (Google) wrote: > > This memory barrier is not needed as rcu_segcblist_add_len() already > > includes a memory barrier *before* and *after* the length of the list is > > upda

Re: [PATCH v22 12/23] LSM: Specify which LSM to display

2020-11-06 Thread Casey Schaufler
On 11/5/2020 1:22 AM, Greg KH wrote: > On Wed, Nov 04, 2020 at 03:41:03PM -0800, Casey Schaufler wrote: >> Create a new entry "display" in the procfs attr directory for >> controlling which LSM security information is displayed for a >> process. A process can only read or write its own display valu

Re: [PATCH v9 2/7] rcu/segcblist: Add counters to segcblist datastructure

2020-11-06 Thread Joel Fernandes
On Fri, Nov 06, 2020 at 07:01:57PM -0500, Joel Fernandes wrote: > On Wed, Nov 04, 2020 at 09:01:33AM -0800, Paul E. McKenney wrote: > > > A casual reader might be forgiven for being confused by the combination > > of "Return" in the above comment and the "void" function type below. > > So shouldn'

Re: [PATCH v8 17/18] scsi: megaraid_sas: Added support for shared host tagset for cpuhotplug

2020-11-06 Thread Qian Cai
On Sat, 2020-11-07 at 00:55 +0530, Sumit Saxena wrote: > I am able to hit the boot hang and similar kind of stack traces as > reported by Qian with shared .config on x86 machine. > In my case the system boots after a hang of 40-45 mins. Qian, is it > true for you as well ? I don't know. I had never

Re: [RFC PATCH 14/15] PCI/P2PDMA: Introduce pci_mmap_p2pmem()

2020-11-06 Thread Jason Gunthorpe
On Fri, Nov 06, 2020 at 01:03:26PM -0700, Logan Gunthorpe wrote: > I don't think a function like that will work for the p2pmem use case. In > order to implement proper page freeing I expect I'll need a loop around > the allocator and vm_insert_mixed()... Something roughly like: > > for (addr = vma

Re: [PATCH] mm/gup_benchmark: GUP_BENCHMARK depends on DEBUG_FS

2020-11-06 Thread John Hubbard
On 11/4/20 2:05 AM, Barry Song wrote: Without DEBUG_FS, all the code in gup_benchmark becomes meaningless. For sure kernel provides debugfs stub while DEBUG_FS is disabled, but the point here is that GUP_BENCHMARK can do nothing without DEBUG_FS. Cc: John Hubbard Cc: Ralph Campbell Inspired-by

Re: [PATCH v4 06/17] PCI: add SIOV and IMS capability detection

2020-11-06 Thread Jason Gunthorpe
On Fri, Nov 06, 2020 at 03:47:00PM -0800, Dan Williams wrote: > Also feel free to straighten me out (Jason or Ashok) if I've botched > the understanding of this. It is pretty simple when you get down to it. We have a new kernel API that Thomas added: pci_subdevice_msi_create_irq_domain() Thi

[PATCH v2] Make iwmmxt.S support Clang's integrated assembler

2020-11-06 Thread Jian Cai
This patch replaces 6 IWMMXT instructions Clang's integrated assembler does not support in iwmmxt.S using macros, while making sure GNU assembler still emit the same instructions. This should be easier than providing full IWMMXT support in Clang. "Intel Wireless MMX Technology - Developer Guide -

Re: [PATCH v9 4/7] rcu/trace: Add tracing for how segcb list changes

2020-11-06 Thread Joel Fernandes
On Wed, Nov 04, 2020 at 03:33:14PM +0100, Frederic Weisbecker wrote: > On Wed, Nov 04, 2020 at 06:08:07AM -0800, Paul E. McKenney wrote: > > On Tue, Nov 03, 2020 at 04:17:31PM +0100, Frederic Weisbecker wrote: > > > On Tue, Nov 03, 2020 at 09:26:00AM -0500, Joel Fernandes (Google) wrote: > > > > +/

Re: [PATCH v9 2/7] rcu/segcblist: Add counters to segcblist datastructure

2020-11-06 Thread Joel Fernandes
On Wed, Nov 04, 2020 at 09:01:33AM -0800, Paul E. McKenney wrote: > A casual reader might be forgiven for being confused by the combination > of "Return" in the above comment and the "void" function type below. > So shouldn't this comment be something like "Add the specified number > of callbacks

Re: [PATCH v5 6/7] IMA: add critical_data to the built-in policy rules

2020-11-06 Thread Lakshmi Ramasubramanian
On 11/6/20 7:37 AM, Lakshmi Ramasubramanian wrote: Hi Mimi, Hi Lakshmi, Tushar, This patch defines a new critical_data builtin policy.  Please update the Subject line. On Sun, 2020-11-01 at 14:26 -0800, Tushar Sugandhi wrote: From: Lakshmi Ramasubramanian The IMA hook to measure kernel c

Re: [GIT PULL] Kselftest fixes update for Linux 5.10-rc3

2020-11-06 Thread pr-tracker-bot
The pull request you sent on Fri, 6 Nov 2020 11:16:07 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest > tags/linux-kselftest-fixes-5.10-rc3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/03f0f5ad58479ba1374f10680fc836aa21abe8f9 Thank you!

[PATCH] include/linux/huge_mm.h: remove extern keyword

2020-11-06 Thread Ralph Campbell
The external function definitions don't need the "extern" keyword. Remove them so future changes don't copy the function definition style. Signed-off-by: Ralph Campbell --- This applies cleanly to linux-mm 5.10.0-rc2 and is for Andrew's tree. include/linux/huge_mm.h | 93 ++

Re: [GIT PULL] Ceph fix for 5.10-rc3

2020-11-06 Thread pr-tracker-bot
The pull request you sent on Fri, 6 Nov 2020 20:27:50 +0100: > https://github.com/ceph/ceph-client.git tags/ceph-for-5.10-rc3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/659caaf65dc9c7150aa3e80225ec6e66b25ab3ce Thank you! -- Deet-doot-dot, I am a bot. https://ko

Re: [PATCH v4 06/17] PCI: add SIOV and IMS capability detection

2020-11-06 Thread Dan Williams
On Fri, Nov 6, 2020 at 9:51 AM Jason Gunthorpe wrote: [..] > > This is true for IMS as well. But probably not implemented in the kernel as > > such. From a HW point of view (take idxd for instance) the facility is > > available to native OS as well. The early RFC supported this for native. > > I c

Re: [GIT PULL] SCSI fixes for 5.10-rc2

2020-11-06 Thread pr-tracker-bot
The pull request you sent on Fri, 06 Nov 2020 14:26:05 -0800: > git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/d4fc96832f0131c8f2fb067fb01c3007df6d4c9f Thank you! -- Deet-doot-dot, I am a bot. ht

Re: [PATCH 0/8] simplify ep_poll

2020-11-06 Thread Linus Torvalds
On Fri, Nov 6, 2020 at 3:17 PM Soheil Hassas Yeganeh wrote: > > The first patch in the series is a fix for the epoll race in > presence of timeouts, so that it can be cleanly backported to all > affected stable kernels. > > The rest of the patch series simplify the ep_poll() implementation. > Some

[PATCH 2/2] drm/nouveau/kms/nv50-: Fix clock checking algorithm in nv50_dp_mode_valid()

2020-11-06 Thread Lyude Paul
While I thought I had this correct (since it actually did reject modes like I expected during testing), Ville Syrjala from Intel pointed out that the logic here isn't correct. max_clock refers to the max data rate supported by the DP encoder. So, limiting it to the output of ds_clock (which refers

[PATCH V3 00/10] PKS: Add Protection Keys Supervisor (PKS) support V3

2020-11-06 Thread ira . weiny
From: Ira Weiny Changes from V2 [4] Rebased on tip-tree/core/entry From Thomas Gleixner Address bisectability Drop Patch: x86/entry: Move nmi entry/exit into common code From Greg KH Remove WARN_ON's

[PATCH 1/2] drm/nouveau/kms/nv50-: Get rid of bogus nouveau_conn_mode_valid()

2020-11-06 Thread Lyude Paul
Ville also pointed out that I got a lot of the logic here wrong as well, whoops. While I don't think anyone's likely using 3D output with nouveau, the next patch will make nouveau_conn_mode_valid() make a lot less sense. So, let's just get rid of it and open-code it like before, while taking care t

Re: [PATCH 2/3] vfio/virqfd: Drain events from eventfd in virqfd_wakeup()

2020-11-06 Thread Alex Williamson
On Tue, 27 Oct 2020 13:55:22 + David Woodhouse wrote: > From: David Woodhouse > > Don't allow the events to accumulate in the eventfd counter, drain them > as they are handled. > > Signed-off-by: David Woodhouse > --- Acked-by: Alex Williamson Paolo, I assume you'll add this to your qu

[PATCH V3 06/10] x86/entry: Preserve PKRS MSR across exceptions

2020-11-06 Thread ira . weiny
From: Ira Weiny The PKRS MSR is not managed by XSAVE. It is preserved through a context switch but this support leaves exception handling code open to memory accesses during exceptions. 2 possible places for preserving this state were considered, irqentry_state_t or pt_regs.[1] pt_regs was muc

[PATCH V3 09/10] x86/pks: Enable Protection Keys Supervisor (PKS)

2020-11-06 Thread ira . weiny
From: Fenghua Yu Protection Keys for Supervisor pages (PKS) enables fast, hardware thread specific, manipulation of permission restrictions on supervisor page mappings. It uses the same mechanism of Protection Keys as those on User mappings but applies that mechanism to supervisor mappings using

[PATCH V3 08/10] x86/pks: Add PKS kernel API

2020-11-06 Thread ira . weiny
From: Fenghua Yu PKS allows kernel users to define domains of page mappings which have additional protections beyond the paging protections. Add an API to allocate, use, and free a protection key which identifies such a domain. Export 5 new symbols pks_key_alloc(), pks_mknoaccess(), pks_mkread(

[PATCH V3 10/10] x86/pks: Add PKS test code

2020-11-06 Thread ira . weiny
From: Ira Weiny The core PKS functionality provides an interface for kernel users to reserve keys to their domains set up the page tables with those keys and control access to those domains when needed. Define test code which exercises the core functionality of PKS via a debugfs entry. Basic ch

[PATCH V3 05/10] x86/entry: Pass irqentry_state_t by reference

2020-11-06 Thread ira . weiny
From: Ira Weiny Currently struct irqentry_state_t only contains a single bool value which makes passing it by value is reasonable. However, future patches propose to add information to this struct, for example the PKRS register/thread state. Adding information to irqentry_state_t makes passing

[PATCH V3 07/10] x86/fault: Report the PKRS state on fault

2020-11-06 Thread ira . weiny
From: Ira Weiny When only user space pkeys are enabled faulting within the kernel was an unexpected condition which should never happen. Therefore a WARN_ON in the kernel fault handler would detect if it ever did. Now this is no longer the case if PKS is enabled and supported. Report a Pkey fa

[PATCH V3 03/10] x86/pks: Add PKS defines and Kconfig options

2020-11-06 Thread ira . weiny
From: Ira Weiny Protection Keys for Supervisor pages (PKS) enables fast, hardware thread specific, manipulation of permission restrictions on supervisor page mappings. It uses the same mechanism of Protection Keys as those on User mappings but applies that mechanism to supervisor mappings using

[PATCH V3 02/10] x86/fpu: Refactor arch_set_user_pkey_access() for PKS support

2020-11-06 Thread ira . weiny
From: Ira Weiny Define a helper, update_pkey_val(), which will be used to support both Protection Key User (PKU) and the new Protection Key for Supervisor (PKS) in subsequent patches. Co-developed-by: Peter Zijlstra Signed-off-by: Peter Zijlstra Signed-off-by: Ira Weiny --- Changes from RFC

  1   2   3   4   5   6   7   8   9   10   >