Re: [PATCH 4/5] bio: introduce BIO_FOLL_PIN flag

2020-08-22 Thread John Hubbard
On 8/22/20 11:25 PM, Christoph Hellwig wrote: On Fri, Aug 21, 2020 at 09:20:58PM -0700, John Hubbard wrote: Add a new BIO_FOLL_PIN flag to struct bio, whose "short int" flags field was full, thuse triggering an expansion of the field from 16, to 32 bits. This allows for a nice assertion in bio_r

[PATCH] ntb: intel: Fix memleak in intel_ntb_pci_probe

2020-08-22 Thread Dinghao Liu
The default error branch of a series of pdev_is_gen calls should free ndev just like what we've done in these calls. Signed-off-by: Dinghao Liu --- drivers/ntb/hw/intel/ntb_hw_gen1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ntb/hw/intel/ntb_hw_gen1.c b/drivers

Re: [PATCH] fs: Kill DCACHE_DONTCACHE dentry even if DCACHE_REFERENCED is set

2020-08-22 Thread Ira Weiny
On Fri, Aug 21, 2020 at 10:40:41AM -0700, 'Ira Weiny' wrote: > On Fri, Aug 21, 2020 at 09:59:53AM +0800, Hao Li wrote: > > Currently, DCACHE_REFERENCED prevents the dentry with DCACHE_DONTCACHE > > set from being killed, so the corresponding inode can't be evicted. If > > the DAX policy of an inode

Re: [PATCH AUTOSEL 5.8 55/62] RDMA/efa: Add EFA 0xefa1 PCI ID

2020-08-22 Thread Gal Pressman
On 21/08/2020 23:34, Sasha Levin wrote: > On Fri, Aug 21, 2020 at 05:19:52PM -0300, Jason Gunthorpe wrote: >> On Fri, Aug 21, 2020 at 03:53:22PM -0400, Sasha Levin wrote: >>> On Fri, Aug 21, 2020 at 04:40:36PM -0300, Jason Gunthorpe wrote: >>> > On Fri, Aug 21, 2020 at 12:14:16PM -0400, Sasha Levin

Re: [PATCH V2 2/3] vhost: vdpa: report iova range

2020-08-22 Thread Eli Cohen
On Fri, Aug 21, 2020 at 05:28:12AM -0400, Jason Wang wrote: > This patch introduces a new ioctl for vhost-vdpa device that can > report the iova range by the device. > > For device that implements get_iova_range() method, we fetch it from > the vDPA device. If device doesn't implement get_iova_ran

[PATCH] vme: ca91cx42: fix memleak in ca91cx42_dma_list_add

2020-08-22 Thread Dinghao Liu
When we encounter invalid data width or address space, entry should be freed just like what we've done in the previous error paths. Signed-off-by: Dinghao Liu --- drivers/vme/bridges/vme_ca91cx42.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/vme/bridges/vme

[PATCH] starfire: switch from 'pci_' to 'dma_' API

2020-08-22 Thread Christophe JAILLET
The wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_ with a correct flag. It has been compile tested. When memory is allocated in 'netdev_open()', GFP_ATOMIC must be used because it

Re: [PATCH 4/5] bio: introduce BIO_FOLL_PIN flag

2020-08-22 Thread Christoph Hellwig
On Fri, Aug 21, 2020 at 09:20:58PM -0700, John Hubbard wrote: > Add a new BIO_FOLL_PIN flag to struct bio, whose "short int" flags field > was full, thuse triggering an expansion of the field from 16, to 32 > bits. This allows for a nice assertion in bio_release_pages(), that the > bio page release

[PATCH] typhoon: switch from 'pci_' to 'dma_' API

2020-08-22 Thread Christophe JAILLET
The wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_ with a correct flag. It has been compile tested. When memory is allocated in 'typhoon_init_one()' GFP_KERNEL can be used because

Re: [PATCH] vdpa/mlx5: Avoid warnings about shifts on 32-bit platforms

2020-08-22 Thread Eli Cohen
On Fri, Aug 21, 2020 at 03:50:19PM -0700, Nathan Chancellor wrote: > Clang warns several times when building for 32-bit ARM along the lines > of: > > drivers/vdpa/mlx5/net/mlx5_vnet.c:1462:31: warning: shift count >= width > of type [-Wshift-count-overflow] > ndev->mvdev.mlx_featur

RE: [PATCH] arm64: dts: imx8mp: Update pinfunc header file

2020-08-22 Thread Anson Huang
Hi, Shawn > Subject: Re: [PATCH] arm64: dts: imx8mp: Update pinfunc header file > > On Fri, Aug 14, 2020 at 05:27:19PM +0800, Anson Huang wrote: > > Update some pins' name and adjust pin options to i.MX8MP pinfunc > > header file according to latest reference manual. > > > > Signed-off-by: Anson

[PATCH] perf: ftrace: Add filter support for option -F/--funcs

2020-08-22 Thread Changbin Du
Same as 'perf probe -F', this patch adds filter support for the ftrace subcommand option '-F, --funcs <[FILTER]>'. Here is an example that only lists functions which start with 'vfs_': $ sudo perf ftrace -F vfs_* vfs_fadvise vfs_fallocate vfs_truncate vfs_open vfs_setpos vfs_llseek vfs_readf vfs_w

Re: [PATCH V3 0/4] opp: general cleanups

2020-08-22 Thread Rajendra Nayak
On 8/20/2020 1:26 PM, Viresh Kumar wrote: Hi, Here is another version of the cleanups I sent earlier. Rajendra: Please see if these work fine now. I gave these a quick spin, and they don';t result in the crash I earlier observed Tested-by: Rajendra Nayak V3: - Dropped v2 1/4 as it is a

Re: Why KASAN doesn't detect this stack oob fault?

2020-08-22 Thread Willy Tarreau
On Sun, Aug 23, 2020 at 11:04:34AM +0800, richard clark wrote: > Hi guys, > > I ins a kmod with below code in a KASAN enabled kernel ( > 5.7.0, > CONFIG_KASAN=y > CONFIG_KASAN_GENERIC=y > CONFIG_KASAN_OUTLINE=y): > > static int kmod_init(void) > { > int i; > int arr[4]; > > for (i =

Re: [PATCH iproute2 v5 0/2] iplink: hsr: add support for creating PRP device

2020-08-22 Thread Stephen Hemminger
On Mon, 17 Aug 2020 17:17:35 -0400 Murali Karicheri wrote: > This series enhances the iproute2 iplink module to add support > for creating PRP device similar to HSR. The kernel part of this > is already merged to v5.9 master > > v4 - addressed comment from Stephen Hemminger >- Sending this w

[PATCH] lib: radix-tree: delete duplicated words

2020-08-22 Thread Randy Dunlap
Drop the repeated word "be". Signed-off-by: Randy Dunlap Cc: Andrew Morton Cc: Matthew Wilcox --- lib/radix-tree.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200730.orig/lib/radix-tree.c +++ linux-next-20200730/lib/radix-tree.c @@ -325,7 +325,7 @@ static __must_

[PATCH] lib: syscall: delete duplicated words

2020-08-22 Thread Randy Dunlap
Drop the repeated word "the". Signed-off-by: Randy Dunlap Cc: Andrew Morton Cc: Steven Rostedt --- lib/syscall.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200730.orig/lib/syscall.c +++ linux-next-20200730/lib/syscall.c @@ -44,7 +44,7 @@ static int collect_sysca

[PATCH] lib: dynamic_queue_limits: delete duplicated words + fix typo

2020-08-22 Thread Randy Dunlap
Drop the repeated word "the". Fix spelling of "excess". Signed-off-by: Randy Dunlap Cc: Andrew Morton Cc: "David S. Miller" Cc: Jakub Kicinski --- lib/dynamic_queue_limits.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-next-20200730.orig/lib/dynamic_queue_limits.c +

[PATCH] lib: pldmfw: delete duplicated words

2020-08-22 Thread Randy Dunlap
Drop the repeated word "header". Signed-off-by: Randy Dunlap Cc: Jacob Keller Cc: "David S. Miller" Cc: Jakub Kicinski --- lib/pldmfw/pldmfw.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200730.orig/lib/pldmfw/pldmfw.c +++ linux-next-20200730/lib/pldmfw/pldmfw.c

[PATCH] lib: earlycpio: delete duplicated words

2020-08-22 Thread Randy Dunlap
Drop the repeated word "the". Signed-off-by: Randy Dunlap Cc: Andrew Morton Cc: H. Peter Anvin --- lib/earlycpio.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200730.orig/lib/earlycpio.c +++ linux-next-20200730/lib/earlycpio.c @@ -42,7 +42,7 @@ enum cpio_fields {

[PATCH] lib: decompress_bunzip2: delete duplicated words

2020-08-22 Thread Randy Dunlap
Drop the repeated word "how". Signed-off-by: Randy Dunlap Cc: Andrew Morton Cc: Herbert Xu Cc: Lasse Collin --- lib/decompress_bunzip2.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200730.orig/lib/decompress_bunzip2.c +++ linux-next-20200730/lib/decompress_bunzi

[PATCH] lib: test_sysctl: delete duplicated words

2020-08-22 Thread Randy Dunlap
Drop the repeated word "the". Signed-off-by: Randy Dunlap Cc: Andrew Morton Cc: Shuah Khan Cc: Shuah Khan --- lib/test_sysctl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200730.orig/lib/test_sysctl.c +++ linux-next-20200730/lib/test_sysctl.c @@ -16,7 +16,7 @@

[PATCH] lib: libcrc32c: delete duplicated words

2020-08-22 Thread Randy Dunlap
Drop the repeated word "the". Signed-off-by: Randy Dunlap Cc: Clay Haapala Cc: Andrew Morton Cc: Herbert Xu --- lib/libcrc32c.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200730.orig/lib/libcrc32c.c +++ linux-next-20200730/lib/libcrc32c.c @@ -12,7 +12,7 @@ *

[PATCH] lib: bitmap: delete duplicated words

2020-08-22 Thread Randy Dunlap
Drop the repeated word "an". Signed-off-by: Randy Dunlap Cc: Andrew Morton --- lib/bitmap.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200730.orig/lib/bitmap.c +++ linux-next-20200730/lib/bitmap.c @@ -23,7 +23,7 @@ /** * DOC: bitmap introduction * - * bitmap

[PATCH] lib: devres: delete duplicated words

2020-08-22 Thread Randy Dunlap
Drop the repeated word "the". Signed-off-by: Randy Dunlap Cc: Andrew Morton Cc: Arnd Bergmann Cc: Greg Kroah-Hartman --- lib/devres.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200730.orig/lib/devres.c +++ linux-next-20200730/lib/devres.c @@ -217,7 +217,7 @@ vo

Re: [PATCH v3 2/2] ARM: dts: vfxxx: Add syscon compatible with OCOTP

2020-08-22 Thread Shawn Guo
On Fri, Aug 21, 2020 at 02:21:02PM -0700, Chris Healy wrote: > From: Chris Healy > > Add syscon compatibility with Vybrid OCOTP node. This is required to > access the UID. > > Fixes: fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP") > Cc: sta...@vger.kernel.org > Reviewed-by: Fa

Re: [PATCH v3 1/2] dt-bindings: nvmem: Add syscon to Vybrid OCOTP driver

2020-08-22 Thread Shawn Guo
On Fri, Aug 21, 2020 at 02:21:01PM -0700, Chris Healy wrote: > From: Chris Healy > > Add syscon compatibility with Vybrid OCOTP driver binding. This is > required to access the UID. > > Fixes: fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP") The bindings doc was not added by t

Why KASAN doesn't detect this stack oob fault?

2020-08-22 Thread richard clark
Hi guys, I ins a kmod with below code in a KASAN enabled kernel ( 5.7.0, CONFIG_KASAN=y CONFIG_KASAN_GENERIC=y CONFIG_KASAN_OUTLINE=y): static int kmod_init(void) { int i; int arr[4]; for (i = 0; i < 20; i++) { arr[i] = i; printk("arr[%d] = %d\n", i, arr[i]); }

[PATCH] rcu-tasks: Fix compilation warning with !CONFIG_TASKS_RCU and CONFIG_TINY_RCU

2020-08-22 Thread Laurent Pinchart
Commit 8344496e8b49 ("rcu-tasks: Conditionally compile show_rcu_tasks_gp_kthreads()") introduced conditional compilation of several functions, but forgot one occurrence of show_rcu_tasks_classic_gp_kthread() that causes the compiler to warn of an unused static function. Fix it. Fixes: 8344496e8b49

Re: [PATCH v6 1/3] arm64: dts: Add a device tree for the Librem 5 phone

2020-08-22 Thread Shawn Guo
On Fri, Aug 21, 2020 at 02:17:53PM +0200, Martin Kepplinger wrote: > From: "Angus Ainslie (Purism)" > > Add a devicetree description for the Librem 5 phone. 4 hardware revisions > have been available. Some revisions include changes that need different > software to be run. So far, r3 ("Dogwood")

Re: [PATCH v2 3/4] arm64: defconfig: re-sync DRM related defconfig bits

2020-08-22 Thread Shawn Guo
On Thu, Aug 20, 2020 at 10:50:58AM +0200, Guido Günther wrote: > This moves the CONFIG_DRM_SIMPLE_BRIDGE entry around making further > updates simpler. > > Signed-off-by: Guido Günther Patch #3 and #4 do not apply to my branch. Shawn

Re: [PATCH v2 2/4] arm64: dts: imx8mq-librem5-devkit: Enable the LCD panel

2020-08-22 Thread Shawn Guo
On Thu, Aug 20, 2020 at 10:50:57AM +0200, Guido Günther wrote: > Enable LCD panel output by adding nodes for the NWL DSI host controller, > the Rocktech panel and the eLCDIF display controller. > > Signed-off-by: Guido Günther > Reviewed-by: Fabio Estevam Applied, thanks.

Re: [PATCH 2/8] drm/lima: Unconditionally call dev_pm_opp_of_remove_table()

2020-08-22 Thread Qiang Yu
Looks good for me, patch is: Reviewed-by: Qiang Yu Regards, Qiang On Thu, Aug 20, 2020 at 6:44 PM Viresh Kumar wrote: > > dev_pm_opp_of_remove_table() doesn't report any errors when it fails to > find the OPP table with error -ENODEV (i.e. OPP table not present for > the device). And we can cal

Re: [PATCH v2 1/4] arm64: dts: imx8mq: Add NWL MIPI DSI controller

2020-08-22 Thread Shawn Guo
On Thu, Aug 20, 2020 at 10:50:56AM +0200, Guido Günther wrote: > Add a node for the Northwest Logic MIPI DSI IP core, "disabled" by > default. This also adds the necessary port to LCDIF. > > Signed-off-by: Guido Günther > Reviewed-by: Fabio Estevam Applied, thanks.

Re: [RFC PATCH 0/8] memcg: Enable fine-grained per process memory control

2020-08-22 Thread Waiman Long
On 8/18/20 6:17 AM, Chris Down wrote: pet...@infradead.org writes: But then how can it run-away like Waiman suggested? Probably because he's not running with that commit at all. We and others use this to prevent runaway allocation on a huge range of production and desktop use cases and it wo

[PATCH v2] ARM: dts: imx7d-zii-rmu2: fix rgmii phy-mode for ksz9031 phy

2020-08-22 Thread Chris Healy
From: Chris Healy Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY") the networking is broken on the imx7d-zii-rmu2 board. The end result is that network receive behaviour is marginal with lots of RX CRC errors experienced and NFS frequently failing. Quotin

[GIT] Networking

2020-08-22 Thread David Miller
Nothing earth shattering here, lots of small fixes (f.e. missing RCU protection, bad ref counting, missing memset(), etc.) all over the place: 1) Use get_file_rcu() in task_file iterator, from Yonghong Song. 2) There are two ways to set remote source MAC addresses in macvlan driver, but only

Re: [PATCH V3] ARM: dts: imx6q-logicpd: Fix broken PWM

2020-08-22 Thread Shawn Guo
On Wed, Aug 19, 2020 at 02:59:44PM -0500, Adam Ford wrote: > The DTC doesn't like the default PWM settings, because it's expecting > three cells. This patch reduces adds the extra entry of 0 to the PWM > reference. > > Fixes: fa28d8212ede ("ARM: dts: imx: default to #pwm-cells = <3> in the SoC

Re: IOPRIO_CLASS_RT without CAP_SYS_ADMIN?

2020-08-22 Thread Jens Axboe
On 8/22/20 7:58 PM, Bart Van Assche wrote: > On 2020-08-20 17:35, Khazhismel Kumykov wrote: >> It'd be nice to allow a process to send RT requests without granting >> it the wide capabilities of CAP_SYS_ADMIN, and we already have a >> capability which seems to almost fit this priority idea - >> CAP

Re: [PATCH] clk: imx: vf610: Add CRC clock

2020-08-22 Thread Shawn Guo
On Mon, Aug 17, 2020 at 05:12:54PM +0200, Krzysztof Kozlowski wrote: > Add the clock for CRC block allowing it to be enabled by consumers. > > Signed-off-by: Krzysztof Kozlowski Applied, thanks.

Re: [PATCH v2 4/4] arm64: dts: imx8mm-var-som-symphony: Add Variscite Symphony board with VAR-SOM-MX8MM

2020-08-22 Thread Shawn Guo
On Mon, Aug 17, 2020 at 09:01:20AM +0200, Krzysztof Kozlowski wrote: > Add a DTS for Variscite Symphony evaluation kit with VAR-SOM-MX8MM > System on Module. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. Remove duplicated "leds" node, > 2. Fix heartbeat to active low

Re: IOPRIO_CLASS_RT without CAP_SYS_ADMIN?

2020-08-22 Thread Bart Van Assche
On 2020-08-20 17:35, Khazhismel Kumykov wrote: > It'd be nice to allow a process to send RT requests without granting > it the wide capabilities of CAP_SYS_ADMIN, and we already have a > capability which seems to almost fit this priority idea - > CAP_SYS_NICE? Would this fit there? > > Being capab

Re: [PATCH v2 3/4] arm64: dts: imx8mm-var-som: Add Variscite VAR-SOM-MX8MM System on Module

2020-08-22 Thread Shawn Guo
On Mon, Aug 17, 2020 at 09:01:19AM +0200, Krzysztof Kozlowski wrote: > Add DTSI of Variscite VAR-SOM-MX8MM System on Module in a basic version, > delivered with Variscite Symphony Evaluation kit. This version comes > with: > - 2 GB of RAM, > - 16 GB eMMC, > - Gigabit Ethernet PHY, > - 802.11 a

[PATCH v5 1/4] drm/mediatek: Move tz_disabled from mtk_hdmi_phy to mtk_hdmi driver

2020-08-22 Thread Chun-Kuang Hu
From: CK Hu tz_disabled is used to control mtk_hdmi output signal, but this variable is stored in mtk_hdmi_phy and mtk_hdmi_phy does not use it. So move tz_disabled to mtk_hdmi where it's used. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_hdmi.c

[PATCH v5 0/4] Move Mediatek HDMI PHY driver from DRM folder to PHY folder

2020-08-22 Thread Chun-Kuang Hu
mtk_hdmi_phy is currently placed inside mediatek drm driver, but it's more suitable to place a phy driver into phy driver folder, so move mtk_hdmi_phy driver into phy driver folder. Changes in v5: - Fixup indent in Kconfig. - Refine config help message. - Refine Makefile. Changes in v4: - Rebase

[PATCH v5 4/4] MAINTAINERS: add files for Mediatek DRM drivers

2020-08-22 Thread Chun-Kuang Hu
Mediatek HDMI phy driver is moved from drivers/gpu/drm/mediatek to drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers' information. Signed-off-by: Chun-Kuang Hu Reviewed-by: Matthias Brugger --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/M

[PATCH v5 2/4] drm/mediatek: Separate mtk_hdmi_phy to an independent module

2020-08-22 Thread Chun-Kuang Hu
From: CK Hu mtk_hdmi_phy is a part of mtk_hdmi module, but phy driver should be an independent module rather than be part of drm module, so separate the phy driver to an independent module. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Kconfig| 9

[PATCH v5 3/4] phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder

2020-08-22 Thread Chun-Kuang Hu
From: CK Hu mtk_hdmi_phy is currently placed inside mediatek drm driver, but it's more suitable to place a phy driver into phy driver folder, so move mtk_hdmi_phy driver into phy driver folder. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Kconfig

Re: [PATCH RFC 2/2] ARM: dts: imx: add devicetree for Tolino Shine 2 HD

2020-08-22 Thread Shawn Guo
On Sat, Aug 15, 2020 at 09:33:36PM +0200, Andreas Kemnade wrote: > This adds a devicetree for the Tolino Shine 2 HD Ebook reader. It is based > on boards marked with "37NB-E60QF0+4A2". It is equipped with an i.MX6SL > SoC. > > Expected to work: > - Buttons > - Wifi > - Touchscreen > - LED > - uSD

Re: [PATCH] arm64: dts: imx8mp: Update pinfunc header file

2020-08-22 Thread Shawn Guo
On Fri, Aug 14, 2020 at 05:27:19PM +0800, Anson Huang wrote: > Update some pins' name and adjust pin options to i.MX8MP pinfunc > header file according to latest reference manual. > > Signed-off-by: Anson Huang Will this break any existing DTs? Shawn > --- > arch/arm64/boot/dts/freescale/imx8

[PATCH 1/2] media: uvcvideo: Ensure all probed info is returned to v4l2

2020-08-22 Thread Adam Goode
bFrameIndex and bFormatIndex can be negotiated by the camera during probing, resulting in the camera choosing a different format than expected. v4l2 can already accommodate such changes, but the code was not updating the proper fields. Without such a change, v4l2 would potentially interpret the pa

[PATCH 2/2] media: uvcvideo: Convey full ycbcr colorspace information to v4l2

2020-08-22 Thread Adam Goode
The Color Matching Descriptor has been present in USB cameras since the original version of UVC, but it has never been fully used in Linux. This change informs V4L2 of all of the critical colorspace parameters: colorspace (called "color primaries" in UVC), transfer function (called "transfer chara

Re: [PATCH] x86: work around clang IAS bug referencing __force_order

2020-08-22 Thread Arvind Sankar
On Sat, Aug 22, 2020 at 05:10:21PM -0700, Linus Torvalds wrote: > On Sat, Aug 22, 2020 at 4:11 PM Arvind Sankar wrote: > > > > Actually, is a memory clobber required for correctness? Memory accesses > > probably shouldn't be reordered across a CRn write. Is asm volatile > > enough to stop that or

Re: [RFC v7 00/19] lockdep: Support deadlock detection for recursive read locks

2020-08-22 Thread boqun . feng
On Fri, Aug 21, 2020 at 09:56:41PM +0200, Peter Zijlstra wrote: > On Fri, Aug 07, 2020 at 03:42:19PM +0800, Boqun Feng wrote: > > Hi Peter and Waiman, > > > > As promised, this is the updated version of my previous lockdep patchset > > for recursive read lock support. It's based on v5.8. Previous

[tip:x86/misc] BUILD SUCCESS c31feed8461fb8648075ba9b53d9e527d530972f

2020-08-22 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/misc branch HEAD: c31feed8461fb8648075ba9b53d9e527d530972f x86/msr: Make source of unrecognised MSR writes unambiguous elapsed time: 723m configs tested: 30 configs skipped: 47 The following configs have been built

[PATCH] Bluetooth: fix "list_add double add" in hci_conn_complete_evt

2020-08-22 Thread Coiby Xu
When two HCI_EV_CONN_COMPLETE event packets with status=0 of the same HCI connection are received, device_add would be called twice which leads to kobject_add being called twice. Thus duplicate (struct hci_conn *conn)->dev.kobj.entry would be inserted into (struct hci_conn *conn)->dev.kobj.kset->li

Re: [PATCH v33 5/6] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node

2020-08-22 Thread Shawn Guo
On Wed, Aug 12, 2020 at 02:50:19PM -0500, Dan Murphy wrote: > Add the reg property to each channel node. This update is > to accommodate the multicolor framework. In addition to the > accommodation this allows the LEDs to be placed on any channel > and allow designs to skip channels as opposed to

Re: [PATCH] usb: storage: initialize variable

2020-08-22 Thread Alan Stern
On Sat, Aug 22, 2020 at 02:18:39PM -0700, t...@redhat.com wrote: > From: Tom Rix > > clang static analysis reports this representative problem > > transport.c:495:15: warning: Assigned value is garbage or > undefined > length_left -= partial; >^ ~~~ > partial i

Re: [PATCH v3 09/10] gen_compile_commands: remove the warning about too few .cmd files

2020-08-22 Thread Nick Desaulniers
On Sat, Aug 22, 2020 at 7:56 AM Masahiro Yamada wrote: > > This warning was useful when users previously needed to manually > build the kernel and run this script. > > Now you can simply do 'make compile_commands.json', which updates > all the necessary build artifacts and automatically creates th

Re: [PATCH v3 07/10] gen_compile_commands: support *.o, *.a, modules.order in positional argument

2020-08-22 Thread Nick Desaulniers
On Sat, Aug 22, 2020 at 7:56 AM Masahiro Yamada wrote: > > This script currently searches the specified directory for .cmd files. > One drawback is it may contain stale .cmd files after you rebuild the > kernel several times without 'make clean'. > > This commit supports *.o, *.a, and modules.orde

Re: [PATCH] powerpc/pseries: Add pcibios_default_alignment implementation

2020-08-22 Thread Oliver O'Halloran
On Sat, Aug 22, 2020 at 6:51 AM Shawn Anastasio wrote: > > Implement pcibios_default_alignment for pseries so that > resources are page-aligned. The main benefit of this is being > able to map any resource from userspace via mechanisms like VFIO. Reviewed-by: Oliver O'Halloran That said, there'

Re: [RFC PATCH] pipe: make pipe_release() deferrable.

2020-08-22 Thread Tetsuo Handa
On 2020/08/23 1:30, Linus Torvalds wrote: > On Fri, Aug 21, 2020 at 9:35 PM Tetsuo Handa > wrote: >> >> Therefore, this patch tries to convert __pipe_lock() in pipe_release() to >> killable, by deferring to a workqueue context when __pipe_lock_killable() >> failed. > > I don't think this is an im

Re: Re:Re: [PATCH] powerpc: Fix a bug in __div64_32 if divisor is zero

2020-08-22 Thread Segher Boessenkool
On Sun, Aug 23, 2020 at 12:54:33AM +0800, Guohua Zhong wrote: > Yet, I have noticed that there is no checking of 'base' in these functions. > But I am not sure how to check is better.As we know that the result is > undefined when divisor is zero. It maybe good to print error and dump stack. > Let

Re: [PATCH] x86: work around clang IAS bug referencing __force_order

2020-08-22 Thread Linus Torvalds
On Sat, Aug 22, 2020 at 4:11 PM Arvind Sankar wrote: > > Actually, is a memory clobber required for correctness? Memory accesses > probably shouldn't be reordered across a CRn write. Is asm volatile > enough to stop that or do you need a memory clobber? You do need a memory clobber if you really

Re: [BUG RT] dump-capture kernel not executed for panic in interrupt context

2020-08-22 Thread Steven Rostedt
On Sat, 22 Aug 2020 14:32:52 +0200 pet...@infradead.org wrote: > On Fri, Aug 21, 2020 at 05:03:34PM -0400, Steven Rostedt wrote: > > > > Sigh. Is it too hard to make mutex_trylock() usable from interrupt > > > context? > > > > > > That's a question for Thomas and Peter Z. > > You should r

Re: [PATCH v2 0/6] Add initial support for ATC260x PMICs

2020-08-22 Thread Cristian Ciocaltea
Hi Mani, On Sat, Aug 22, 2020 at 06:43:43PM +0530, Manivannan Sadhasivam wrote: > Hi Cristi, > > Thanks for the series! I'll take a look soon but there is a quick comment > below. > > On Sat, Aug 22, 2020 at 01:26:53AM +0300, Cristian Ciocaltea wrote: > > I have just realized I had omitted the c

Re: [PATCH] x86: work around clang IAS bug referencing __force_order

2020-08-22 Thread Arvind Sankar
On Sat, Aug 22, 2020 at 02:08:27PM -0700, Linus Torvalds wrote: > However, in this case, can we just leave that old "__force_order" hack > alone, and to work around the clang thing, just make a dummy > definition of it anyway. > > Alternatively, just use the memory clobber. We use memory clobbers

Re: [PATCH v5 0/3] Add Actions Semi Owl family sirq support

2020-08-22 Thread Cristian Ciocaltea
Hi Mani, On Sat, Aug 22, 2020 at 06:47:12PM +0530, Manivannan Sadhasivam wrote: > Hi Cristi, > > On Wed, Aug 19, 2020 at 07:37:55PM +0300, Cristian Ciocaltea wrote: > > This patch series adds support for the external interrupt controller > > (SIRQ) found in the Actions Semi Owl family of SoC's (S

Re: [patch RFC 38/38] irqchip: Add IMS array driver - NOT FOR MERGING

2020-08-22 Thread Jason Gunthorpe
On Sat, Aug 22, 2020 at 03:34:45AM +0200, Thomas Gleixner wrote: > >> One question is whether the device can see partial updates to that > >> memory due to the async 'swap' of context from the device CPU. > > > > It is worse than just partial updates.. The device operation is much > > more like you

Re: [PATCH][next] carl9170: Use fallthrough pseudo-keyword

2020-08-22 Thread Christian Lamparter
On 2020-08-21 08:52, Gustavo A. R. Silva wrote: Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-of

Re: [GIT PULL] fallthrough pseudo-keyword macro conversions for 5.9-rc2

2020-08-22 Thread Gustavo A. R. Silva
Hi Joe, On 8/22/20 12:36, Joe Perches wrote: > On Thu, 2020-08-20 at 17:02 -0500, Gustavo A. R. Silva wrote: >> This treewide patch doesn't address ALL fall-through markings in all >> subsystems at once because I have previously sent out patches for some of >> such subsystems separately, and I w

[PATCH v1] PCI: pcie_bus_config can be set at build time

2020-08-22 Thread Jim Quinlan
The Kconfig is modified so that the pcie_bus_config setting can be done at build time in the same manner as the CONFIG_PCIEASPM_ choice. The pci_bus_config setting may still be overridden by the bootline param. Signed-off-by: Jim Quinlan --- drivers/pci/Kconfig | 40

Re: [tip: x86/urgent] x86/entry, selftests: Further improve user entry sanity checks

2020-08-22 Thread Andy Lutomirski
On Thu, Aug 20, 2020 at 3:24 AM wrote: > > On Sat, Jul 04, 2020 at 05:49:10PM -, tip-bot2 for Andy Lutomirski wrote: > > > diff --git a/arch/x86/entry/common.c b/arch/x86/entry/common.c > > index f392a8b..e83b3f1 100644 > > --- a/arch/x86/entry/common.c > > +++ b/arch/x86/entry/common.c > > @@

Re: [PATCH v2] mm: Track page table modifications in __apply_to_page_range()

2020-08-22 Thread Pavel Machek
Hi! > > > The __apply_to_page_range() function is also used to change and/or > > > allocate page-table pages in the vmalloc area of the address space. > > > Make sure these changes get synchronized to other page-tables in the > > > system by calling arch_sync_kernel_mappings() when necessary. > >

Re: [PATCH net-next] net: Remove unnecessary intermediate variables

2020-08-22 Thread Joe Perches
On Sat, 2020-08-22 at 14:07 -0700, David Miller wrote: > From: Joe Perches > Date: Sat, 22 Aug 2020 14:03:31 -0700 > > > The compiler didn't inline the code without it. > > Then the compiler had a good reason for doing so, The "good" word choice there is slightly dubious. Compilers make bad dec

[PATCH] usb: storage: initialize variable

2020-08-22 Thread trix
From: Tom Rix clang static analysis reports this representative problem transport.c:495:15: warning: Assigned value is garbage or undefined length_left -= partial; ^ ~~~ partial is set only when usb_stor_bulk_transfer_sglist() is successful. So initialize to pa

Re: [PATCH] x86: work around clang IAS bug referencing __force_order

2020-08-22 Thread Arvind Sankar
On Sat, Aug 22, 2020 at 08:17:32PM +0200, Miguel Ojeda wrote: > On Sat, Aug 22, 2020 at 11:52 AM Sedat Dilek wrote: > > > > I am asking myself who is using such ancient compilers? > > There are many users/companies using older versions of compilers, > kernels and everything. GCC <= 4.9 will still

[PATCH] media: tuner-simple: fix regression in simple_set_radio_freq

2020-08-22 Thread trix
From: Tom Rix clang static analysis reports this problem tuner-simple.c:714:13: warning: Assigned value is garbage or undefined buffer[1] = buffer[3]; ^ ~ In simple_set_radio_freq buffer[3] used to be done in-function with a switch of tuner type, now done by a

Re: [PATCH] x86: work around clang IAS bug referencing __force_order

2020-08-22 Thread Linus Torvalds
On Sat, Aug 22, 2020 at 11:17 AM Miguel Ojeda wrote: > > However, the important question is whether those users/companies care > about running the latest kernels. Many of those definitely do not want > to touch their kernel either. For those that do, there are several > longterms to pick from that

Re: [PATCH net-next] net: Remove unnecessary intermediate variables

2020-08-22 Thread David Miller
From: Joe Perches Date: Sat, 22 Aug 2020 14:03:31 -0700 > The compiler didn't inline the code without it. Then the compiler had a good reason for doing so, or it's a compiler bug that should be reported. I would reject any patch that added inline to a foo.c file, so unless you want to make sugg

Re: [PATCH net-next] net: Remove unnecessary intermediate variables

2020-08-22 Thread Joe Perches
On Sat, 2020-08-22 at 13:59 -0700, David Miller wrote: > From: Joe Perches > Date: Sat, 22 Aug 2020 13:39:28 -0700 > > > It _might_ be slightly faster to use inlines > > We are not using the inline directive in foo.c files and are letting > the compiler decide. > > Please don't give out advice

Re: [PATCH v2 2/2] net: socket: implement SO_DESCRIPTION

2020-08-22 Thread David Miller
From: Pascal Bouchareine Date: Sat, 22 Aug 2020 13:53:03 -0700 > On Sat, Aug 22, 2020 at 1:19 PM Pascal Bouchareine wrote: >> >> On Sat, Aug 22, 2020 at 12:59 PM Pascal Bouchareine wrote: >> >> > Would it make sense to also make UDIAG_SHOW_NAME use sk_description? >> > (And keep the existing ch

Re: [PATCH net-next] net: Remove unnecessary intermediate variables

2020-08-22 Thread David Miller
From: Joe Perches Date: Sat, 22 Aug 2020 13:39:28 -0700 > It _might_ be slightly faster to use inlines We are not using the inline directive in foo.c files and are letting the compiler decide. Please don't give out advice like this. Thank you.

Re: [PATCH v3] memory: brcmstb_dpfe: fix array index out of bounds

2020-08-22 Thread Krzysztof Kozlowski
On Sat, Aug 22, 2020 at 01:50:00PM -0700, Markus Mayer wrote: > We would overrun the error_text array if we hit a TIMEOUT condition, > because we were using the error code "ETIMEDOUT" (which is 110) as an > array index. > > We fix the problem by correcting the array index and by providing a > func

[PATCH v4 1/1] phy: tusb1210: use bitmasks to set VENDOR_SPECIFIC2

2020-08-22 Thread Liam Beguin
From: Liam Beguin Start by reading the content of the VENDOR_SPECIFIC2 register and update each bit field based on device properties when defined. The use of bit masks prevents fields from overriding each other and enables users to clear bits which are set by default, like datapolarity in this i

Re: [PATCH v2 2/2] net: socket: implement SO_DESCRIPTION

2020-08-22 Thread Pascal Bouchareine
On Sat, Aug 22, 2020 at 1:19 PM Pascal Bouchareine wrote: > > On Sat, Aug 22, 2020 at 12:59 PM Pascal Bouchareine wrote: > > > Would it make sense to also make UDIAG_SHOW_NAME use sk_description? > > (And keep the existing change - setsockopt + show_fd_info via > > /proc/.../fdinfo/..) > > > Ah,v

[PATCH v3] memory: brcmstb_dpfe: fix array index out of bounds

2020-08-22 Thread Markus Mayer
We would overrun the error_text array if we hit a TIMEOUT condition, because we were using the error code "ETIMEDOUT" (which is 110) as an array index. We fix the problem by correcting the array index and by providing a function to retrieve error messages rather than accessing the array directly.

Re: [PATCH v2] memory: brcmstb_dpfe: fix array index out of bounds

2020-08-22 Thread Florian Fainelli
On 8/22/2020 1:47 PM, Markus Mayer wrote: On Sat, 22 Aug 2020 at 13:21, Florian Fainelli wrote: On 8/22/2020 1:14 PM, Markus Mayer wrote: On Sat, 22 Aug 2020 at 09:46, Krzysztof Kozlowski wrote: On Sat, Aug 22, 2020 at 09:40:59AM -0700, Markus Mayer wrote: On Sat, 22 Aug 2020 at 04:56,

Re: [PATCH v2] memory: brcmstb_dpfe: fix array index out of bounds

2020-08-22 Thread Markus Mayer
On Sat, 22 Aug 2020 at 13:46, Krzysztof Kozlowski wrote: > > On Sat, Aug 22, 2020 at 01:21:47PM -0700, Florian Fainelli wrote: > > > > > > On 8/22/2020 1:14 PM, Markus Mayer wrote: > > > On Sat, 22 Aug 2020 at 09:46, Krzysztof Kozlowski wrote: > > > > > > > > On Sat, Aug 22, 2020 at 09:40:59AM -0

Re: [PATCH v2] memory: brcmstb_dpfe: fix array index out of bounds

2020-08-22 Thread Markus Mayer
On Sat, 22 Aug 2020 at 13:21, Florian Fainelli wrote: > > On 8/22/2020 1:14 PM, Markus Mayer wrote: > > On Sat, 22 Aug 2020 at 09:46, Krzysztof Kozlowski wrote: > >> > >> On Sat, Aug 22, 2020 at 09:40:59AM -0700, Markus Mayer wrote: > >>> On Sat, 22 Aug 2020 at 04:56, Krzysztof Kozlowski wrote:

Re: [PATCH v2] memory: brcmstb_dpfe: fix array index out of bounds

2020-08-22 Thread Krzysztof Kozlowski
On Sat, Aug 22, 2020 at 01:21:47PM -0700, Florian Fainelli wrote: > > > On 8/22/2020 1:14 PM, Markus Mayer wrote: > > On Sat, 22 Aug 2020 at 09:46, Krzysztof Kozlowski wrote: > > > > > > On Sat, Aug 22, 2020 at 09:40:59AM -0700, Markus Mayer wrote: > > > > On Sat, 22 Aug 2020 at 04:56, Krzyszto

Re: [PATCH net-next] net: Remove unnecessary intermediate variables

2020-08-22 Thread Joe Perches
On Sat, 2020-08-22 at 12:33 -0700, David Miller wrote: > From: Jianlin Lv > Date: Sat, 22 Aug 2020 10:04:31 +0800 > > > It is not necessary to use src/dst as an intermediate variable for > > assignment operation; Delete src/dst intermediate variables to avoid > > unnecessary variable declarations

net/ipv6/ndisc.c:1362 ndisc_router_discovery() warn: unsigned 'rtime' is never less than zero.

2020-08-22 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: c3d8f220d01220a5b253e422be407d068dc65511 commit: 19e16d220f0adbf899a652dfb1fde2e3a95153e9 neigh: support smaller retrans_time settting date: 5 months ago config: mips-randconfig-m031-20200823 (attached as

[PATCH] drivers: staging: comedi: fixed duplicate words from checkpatch

2020-08-22 Thread Ethan Edwards
Fixed various different checkpatch duplicate word warnings, the TODO file said to fix checkpatch warnings. My old email didn't CC the mailing lists, ignore the old one, sorry. Signed-off-by: Ethan Edwards --- drivers/staging/comedi/comedi.h | 4 ++-- drivers/staging/comedi/come

Re: [PATCH RFC 00/12] Core-sched v6+: kernel protection and hotplug fixes

2020-08-22 Thread Joel Fernandes
On Fri, Aug 14, 2020 at 11:19 PM Joel Fernandes (Google) wrote: > > Hello! > > This series is continuation of main core-sched v6 series [1] and adds support > for syscall and IRQ isolation from usermode processes and guests. It is key to > safely entering kernel mode in an HT while the other HT is

Re: [PATCH v2] memory: brcmstb_dpfe: fix array index out of bounds

2020-08-22 Thread Florian Fainelli
On 8/22/2020 1:14 PM, Markus Mayer wrote: On Sat, 22 Aug 2020 at 09:46, Krzysztof Kozlowski wrote: On Sat, Aug 22, 2020 at 09:40:59AM -0700, Markus Mayer wrote: On Sat, 22 Aug 2020 at 04:56, Krzysztof Kozlowski wrote: On Fri, Aug 21, 2020 at 09:52:21AM -0700, Markus Mayer wrote: We wou

Re: [PATCH v2 2/2] net: socket: implement SO_DESCRIPTION

2020-08-22 Thread Pascal Bouchareine
On Sat, Aug 22, 2020 at 12:59 PM Pascal Bouchareine wrote: > Would it make sense to also make UDIAG_SHOW_NAME use sk_description? > (And keep the existing change - setsockopt + show_fd_info via > /proc/.../fdinfo/..) Ah,very wrong example - to be more precise, I suppose that'd be adding a coupl

Re: [PATCH 5/5] Add manpage for fsconfig(2)

2020-08-22 Thread Michael Kerrisk (man-pages)
Hello David, On Fri, 7 Aug 2020 at 16:03, David Howells wrote: > > Add a manual page to document the fsconfig() system call. > > Signed-off-by: David Howells > --- > > man2/fsconfig.2 | 282 > +++ > 1 file changed, 282 insertions(+) > creat

Re: [PATCH v2] memory: brcmstb_dpfe: fix array index out of bounds

2020-08-22 Thread Markus Mayer
On Sat, 22 Aug 2020 at 09:46, Krzysztof Kozlowski wrote: > > On Sat, Aug 22, 2020 at 09:40:59AM -0700, Markus Mayer wrote: > > On Sat, 22 Aug 2020 at 04:56, Krzysztof Kozlowski wrote: > > > > > > On Fri, Aug 21, 2020 at 09:52:21AM -0700, Markus Mayer wrote: > > > > We would overrun the error_text

[PATCH net-next 4/6] MAINTAINERS: GENET: Add UniMAC MDIO controller files

2020-08-22 Thread Florian Fainelli
In preparation for removing myself from the PHYLIB entry, add the UniMAC MDIO controller files (DT binding, driver and platform_data header) to the GENET entry. The UniMAC MDIO controller is essential to the GENET operation, therefore it makes sense to group them together. Signed-off-by: Florian F

  1   2   3   4   >