drivers/pci/controller/pci-v3-semi.c:808:2-9: line 808 is redundant because platform_get_irq() already prints an error (fwd)

2020-07-15 Thread Julia Lawall
aster head: e9919e11e219eaa5e8041b7b1a196839143e9125 commit: ca7ce5a2710ad2a57bf7d0c4c712590bb69a5e1c coccinelle: platform_get_irq: Fix parse error date: 10 months ago :: branch date: 2 days ago :: commit date: 10 months ago config: arm-randconfig-c021-20200715 (attached as .config) compiler: arm-linux-gnueabi-gcc (

Re: KCSAN: data-race in generic_file_buffered_read / generic_file_buffered_read

2020-07-15 Thread Eric Biggers
On Thu, Jul 16, 2020 at 04:24:01PM +1000, Nicholas Piggin wrote: > Excerpts from Eric Biggers's message of July 16, 2020 1:03 pm: > > On Thu, Jul 16, 2020 at 09:42:03AM +1000, Dave Chinner wrote: > >> On Wed, Jul 15, 2020 at 09:32:56AM -0700, Eric Biggers wrote: > >> > [+Cc linux-fsdevel] > >> > >

Re: [PATCH] phy: sun4i-usb: explicitly include gpio/consumer.h

2020-07-15 Thread Chen-Yu Tsai
On Thu, Jul 16, 2020 at 2:24 PM Vinod Koul wrote: > > Driver uses GPIO functions but doesn't include the header explcitly. Add > that to fix build errors when GPIOLIB is disabled. > > drivers/phy/allwinner/phy-sun4i-usb.c:367:11: error: implicit > declaration of function ‘gpiod_get_value_cansleep’

[PATCH] staging: rtl8712: Fixes coding style in several headers

2020-07-15 Thread Qiu Wenbo
This patch fixes warnings in several headers found by the checkpatch.pl tool. Signed-off-by: Qiu Wenbo --- drivers/staging/rtl8712/rtl871x_event.h | 15 ++- drivers/staging/rtl8712/rtl871x_io.h | 3 ++- drivers/staging/rtl8712/rtl871x_pwrctrl.h | 15 ++- drivers/s

Re: [PATCH v1 2/3] dt-bindings: media: imx274: Add optional xclk and supplies

2020-07-15 Thread Luca Ceresoli
Hi Sowjanya, On 15/07/20 06:24, Sowjanya Komatineni wrote: > This patch adds IMX274 optional external clock input and voltage > supplies to device tree bindings. > > Signed-off-by: Sowjanya Komatineni > --- > Documentation/devicetree/bindings/media/i2c/imx274.txt | 5 + > 1 file changed, 5

RE: [EXT] Re: [PATCH v2 net-next 03/10] net: mscc: ocelot: allocated rules to different hardware VCAP TCAMs by chain index

2020-07-15 Thread Xiaoliang Yang
Hi Allan, On 11.06.2002 2:18, Allan W. Nielsen wrote: >> >> Here is my initial suggestion for an alternative chain-schema: >> >> >> >> Chain 0: The default chain - today this is in IS2. If we proceed >> >> with this as is - then this will change. >> >> Chain 1-:

BUG: corrupted list in evict

2020-07-15 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:d31958b3 Add linux-next specific files for 20200710 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=1050b2af10 kernel config: https://syzkaller.appspot.com/x/.config?x=3fe4fccb94cbc1a6 dashboard

KASAN: user-memory-access Read in filp_close (2)

2020-07-15 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:d31958b3 Add linux-next specific files for 20200710 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=11cbc80090 kernel config: https://syzkaller.appspot.com/x/.config?x=3fe4fccb94cbc1a6 dashboard

general protection fault in idr_remove (2)

2020-07-15 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:a581387e Merge tag 'io_uring-5.8-2020-07-10' of git://git... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1135d46310 kernel config: https://syzkaller.appspot.com/x/.config?x=66ad203c2bb6d8b dash

Re: [RFC for Linux v4 1/2] virtio_balloon: Add VIRTIO_BALLOON_F_CONT_PAGES and inflate_cont_vq

2020-07-15 Thread Michael S. Tsirkin
On Thu, Jul 16, 2020 at 10:41:51AM +0800, Hui Zhu wrote: > diff --git a/include/uapi/linux/virtio_balloon.h > b/include/uapi/linux/virtio_balloon.h > index dc3e656..4d0151a 100644 > --- a/include/uapi/linux/virtio_balloon.h > +++ b/include/uapi/linux/virtio_balloon.h > @@ -37,6 +37,7 @@ > #define

[PATCH] usb: gadget: configfs: Fix use-after-free issue with udc_name

2020-07-15 Thread Macpaul Lin
There is a use-after-free issue, if access udc_name in function gadget_dev_desc_UDC_store after another context free udc_name in function unregister_gadget. Contex 1: gadget_dev_desc_UDC_store()->unregister_gadget()-> free udc_name->set udc_name to NULL Contex 2: gadget_dev_desc_UDC_show()-> acce

Re: [RFC for qemu v4 2/2] virtio_balloon: Add dcvq to deflate continuous pages

2020-07-15 Thread Michael S. Tsirkin
On Thu, Jul 16, 2020 at 10:41:55AM +0800, Hui Zhu wrote: > This commit adds a vq dcvq to deflate continuous pages. > When VIRTIO_BALLOON_F_CONT_PAGES is set, try to get continuous pages > from icvq and use madvise MADV_WILLNEED with the pages. > > Signed-off-by: Hui Zhu This is arguably somethin

Re: [PATCH] ath10k: Add interrupt summary based CE processing

2020-07-15 Thread Kalle Valo
Brian Norris writes: > On Fri, Jun 26, 2020 at 2:49 PM Doug Anderson wrote: >> I should also note that, while I'm not terribly familiar with Kalle's >> workflow, I would have expected to see him in the "To:" list. I've >> added him, but it's possible he'll need you to repost the patch with >> h

[PATCH RESEND] lockdep: Move list.h inclusion into lockdep.h

2020-07-15 Thread Herbert Xu
Currently lockdep_types.h includes list.h without actually using any of its macros or functions. All it needs are the type definitions which were moved into types.h long ago. This potentially causes inclusion loops because both are included by many core header files. This patch moves the list.h

Re: [PATCHv2] mm: Fix warning in move_normal_pmd()

2020-07-15 Thread Naresh Kamboju
On Thu, 16 Jul 2020 at 04:49, Linus Torvalds wrote: > > On Wed, Jul 15, 2020 at 4:04 PM Linus Torvalds > wrote: > > > > It *might* be as simple as this incremental thing on top > > No, it needs to be > > + if (*old_addr + *len < old->vm_end) > + return; > > in try_to_align_end

Re: [RFC for Linux v4 0/2] virtio_balloon: Add VIRTIO_BALLOON_F_CONT_PAGES to report continuous pages

2020-07-15 Thread Michael S. Tsirkin
On Thu, Jul 16, 2020 at 10:41:50AM +0800, Hui Zhu wrote: > The first, second and third version are in [1], [2] and [3]. > Code of current version for Linux and qemu is available in [4] and [5]. > Update of this version: > 1. Report continuous pages will increase the speed. So added deflate >co

Re: [PATCH v3 2/2] phy: socionext: Add UniPhier AHCI PHY driver support

2020-07-15 Thread Vinod Koul
On 16-07-20, 11:43, Kunihiko Hayashi wrote: > +static int uniphier_ahciphy_pxs3_init(struct uniphier_ahciphy_priv *priv) > +{ > + int i; > + u32 val; > + > + /* setup port parameter */ > + val = readl(priv->base + TXCTRL0); > + val &= ~TXCTRL0_AMP_G3_MASK; > + val |= FIELD_

Re: KASAN: slab-out-of-bounds Read in __xfrm6_tunnel_spi_lookup

2020-07-15 Thread Steffen Klassert
On Wed, Jul 15, 2020 at 05:18:36PM +0800, Xin Long wrote: > Hi, Steffen, > > I've confirmed the patchset I posted yesterday would fix this: > > [PATCH ipsec-next 0/3] xfrm: not register one xfrm(6)_tunnel object twice Thanks for the confirmation! That patchset is now applied to ipsec-next.

[PATCH v2 2/3] clk: intel: Improve locking in the driver

2020-07-15 Thread Rahul Tanwar
Remove/reduce unnecessary spin locking of the code. Signed-off-by: Rahul Tanwar --- drivers/clk/x86/clk-cgu.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/clk/x86/clk-cgu.c b/drivers/clk/x86/clk-cgu.c index 88ebeb53b109..c379fedfb9f2 100644 --- a

[PATCH v2 3/3] clk: intel: Avoid unnecessary memset by improving code

2020-07-15 Thread Rahul Tanwar
memset can be avoided in a loop if the variables used are declared inside the loop. Move such variables declaration inside the loop to avoid memset. Signed-off-by: Rahul Tanwar --- drivers/clk/x86/clk-cgu.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/clk/x8

[PATCH v2 1/3] clk: intel: Use devm_clk_hw_register() instead of clk_hw_register()

2020-07-15 Thread Rahul Tanwar
To ensure that clks are unregistered in case of any failure, use devm_clk_hw_register() instead of clk_hw_register(). Signed-off-by: Rahul Tanwar --- drivers/clk/x86/clk-cgu-pll.c | 2 +- drivers/clk/x86/clk-cgu.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/d

Re: [PATCH v3 1/2] platform/chrome: cros_ec_uart: Add cros-ec-uart transport layer

2020-07-15 Thread Greg Kroah-Hartman
On Thu, Jul 16, 2020 at 08:28:07AM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 15, 2020 at 10:14:29PM -0700, Bhanu Prakash Maiya wrote: > > From: Bhanu Prakash Maiya > > > > This patch enables uart transport layer for cros_ec framework. > > The cros-ec-uart binds with EC device working on uart

Re: [PATCH v3 1/2] platform/chrome: cros_ec_uart: Add cros-ec-uart transport layer

2020-07-15 Thread Greg Kroah-Hartman
On Wed, Jul 15, 2020 at 10:14:29PM -0700, Bhanu Prakash Maiya wrote: > From: Bhanu Prakash Maiya > > This patch enables uart transport layer for cros_ec framework. > The cros-ec-uart binds with EC device working on uart transport to > send request and receive response. > > Signed-off-by: Bhanu P

[PATCH] phy: sun4i-usb: explicitly include gpio/consumer.h

2020-07-15 Thread Vinod Koul
Driver uses GPIO functions but doesn't include the header explcitly. Add that to fix build errors when GPIOLIB is disabled. drivers/phy/allwinner/phy-sun4i-usb.c:367:11: error: implicit declaration of function ‘gpiod_get_value_cansleep’; did you mean ‘gpio_get_value_cansleep’? [-Werror=implicit-fu

Re: KCSAN: data-race in generic_file_buffered_read / generic_file_buffered_read

2020-07-15 Thread Nicholas Piggin
Excerpts from Eric Biggers's message of July 16, 2020 1:03 pm: > On Thu, Jul 16, 2020 at 09:42:03AM +1000, Dave Chinner wrote: >> On Wed, Jul 15, 2020 at 09:32:56AM -0700, Eric Biggers wrote: >> > [+Cc linux-fsdevel] >> > >> > On Wed, Jul 15, 2020 at 05:29:12PM +0200, 'Marco Elver' via syzkaller-b

Re: linux-next: Tree for Jul 15 (drivers/phy/allwinner/phy-sun4i-usb.c)

2020-07-15 Thread Vinod Koul
On 15-07-20, 08:18, Randy Dunlap wrote: > On 7/15/20 1:05 AM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20200714: > > > > on x86_64: > # CONFIG_GPIOLIB is not set > > ../drivers/phy/allwinner/phy-sun4i-usb.c: In function > ‘sun4i_usb_phy0_get_id_det’: > ../drivers/phy/allwinner

Re: [PATCH] net: smc91x: Fix possible memory leak in smc_drv_probe()

2020-07-15 Thread Markus Elfring
> If try_toggle_control_gpio() failed in smc_drv_probe(), free_netdev(ndev) > should be called to free the ndev created earlier. Otherwise, a memleak > will occur. * Will it be nicer to use the term “memory leak” also in this change description? * Would another imperative wording be preferred fo

next/pending-fixes bisection: baseline.dmesg.crit on qemu_arm-vexpress-a15

2020-07-15 Thread kernelci.org bot
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the problem

Re: [PATCH v2] ASoC: soc-component: Add missed return for calling soc_component_ret

2020-07-15 Thread Kuninori Morimoto
Hi Shengjiu > Add missed return for calling soc_component_ret, otherwise the return > value is wrong. > > Fixes: e2329eeba45f ("ASoC: soc-component: add soc_component_err()") > Signed-off-by: Shengjiu Wang > --- Acked-by: Kuninori Morimoto Thank you for your help !! Best regards --- Kunino

mainline/master bisection: baseline.dmesg.crit on qemu_arm-vexpress-a15

2020-07-15 Thread kernelci.org bot
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the problem

[PATCH 0/2] Fix some build warnings when W=1

2020-07-15 Thread Zong Li
These patches fix some build warnings when W=1, the most of warnings are missing prototype as follows: arch/riscv/mm/init.c:520:13: warning: no previous prototype for 'resource_init' [-Wmissing-prototypes] arch/riscv/mm/pageattr.c:130:5: warning: no previous prototype for 'set_memory_ro' [-Wmiss

Re: [PATCH 2/2] Input: elan_i2c - Modify the IAP related functio n for page sizes 128, 512 bytes.

2020-07-15 Thread jingle.wu
HI Dmitry: Just to confirm, the older devices (I assume that pattern 0 means older) have version command that is numerically higher than the one for the newer (pattern >= 1) devices? >> Yes, Pattern 1, 2 are newer devices. > @@ -324,7 +342,14 @@ static int elan_i2c_get_sm_version(struct i2c_cl

[PATCH 1/2] riscv: Fix build warning for mm/init

2020-07-15 Thread Zong Li
Add static keyword for resource_init, this function is only used in this object file. Signed-off-by: Zong Li --- arch/riscv/mm/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c index 92002952c621..66f5952f39c0 100644 --- a/arch

[PATCH 2/2] riscv: fix build warning of mm/pageattr

2020-07-15 Thread Zong Li
Add hearder for missing prototype. Also, static keyword should be at beginning of declaration. Signed-off-by: Zong Li --- arch/riscv/mm/pageattr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/riscv/mm/pageattr.c b/arch/riscv/mm/pageattr.c index 289a9a5ea5b5..19fecb3

[PATCH] arm64: dts: qcom: sc7180: Add lpass cpu node for I2S driver

2020-07-15 Thread Cheng-Yi Chiang
From: Ajit Pandey Add the I2S controller node to sc7180 dtsi. Add pinmux for pirmary and secondary I2S. Signed-off-by: Ajit Pandey Signed-off-by: Cheng-Yi Chiang --- This patch depends on these patch series so it is not ready to be merged now. - clk: qcom: Support for Low Power Audio Clocks on

Re: [PATCH v5 07/13] pwm: add support for sl28cpld PWM controller

2020-07-15 Thread Uwe Kleine-König
Hello Michael, On Wed, Jul 15, 2020 at 10:41:25PM +0200, Michael Walle wrote: > Am 2020-07-15 20:18, schrieb Uwe Kleine-König: > > On Wed, Jul 15, 2020 at 07:45:10PM +0200, Michael Walle wrote: > > > > > > Am 2020-07-15 18:36, schrieb Uwe Kleine-König: > > > > On Tue, Jul 14, 2020 at 11:09:28PM +

Re: [PATCH v4 3/9] bus: mhi: core: Use helper API to trigger a non-blocking host resume

2020-07-15 Thread Manivannan Sadhasivam
On Wed, Jul 08, 2020 at 01:53:49PM -0700, bbh...@codeaurora.org wrote: > On 2020-07-04 07:47, Manivannan Sadhasivam wrote: > > On Mon, Jun 29, 2020 at 09:39:36AM -0700, Bhaumik Bhatt wrote: > > > Autonomous low power mode support requires the MHI host to resume from > > > multiple places and post a

[PATCH] /dev/mem: Add missing memory barriers for devmem_inode

2020-07-15 Thread Eric Biggers
From: Eric Biggers WRITE_ONCE() isn't the correct way to publish a pointer to a data structure, since it doesn't include a write memory barrier. Therefore other tasks may see that the pointer has been set but not see that the pointed-to memory has finished being initialized yet. Instead a primi

Re: [RFC PATCH 4/7] x86: use exit_lazy_tlb rather than membarrier_mm_sync_core_before_usermode

2020-07-15 Thread Nicholas Piggin
Excerpts from Andy Lutomirski's message of July 16, 2020 3:18 pm: > > >> On Jul 15, 2020, at 9:15 PM, Nicholas Piggin wrote: >> >> Excerpts from Mathieu Desnoyers's message of July 14, 2020 12:13 am: >>> - On Jul 13, 2020, at 9:47 AM, Nicholas Piggin npig...@gmail.com wrote: >>> Exce

Re: [PATCH v8 1/2] phy: qualcomm: add qcom ipq806x dwc usb phy driver

2020-07-15 Thread Vinod Koul
On 13-07-20, 15:23, Ansuel Smith wrote: > +static inline void usb_phy_write_readback(struct usb_phy *phy_dwc3, > + u32 offset, > + const u32 mask, u32 val) > +{ > + u32 write_val, tmp = readl(phy_dwc3->base + offset);

Re: [PATCH v2 bpf-next 2/2] selftests/bpf: add callchain_stackid

2020-07-15 Thread Andrii Nakryiko
On Tue, Jul 14, 2020 at 11:09 PM Song Liu wrote: > > This tests new helper function bpf_get_stackid_pe and bpf_get_stack_pe. > These two helpers have different implementation for perf_event with PEB > entries. > > Signed-off-by: Song Liu > --- > .../bpf/prog_tests/perf_event_stackmap.c | 12

Re: [PATCH v3 04/12] ppc64/kexec_file: avoid stomping memory used by special regions

2020-07-15 Thread Thiago Jung Bauermann
Thiago Jung Bauermann writes: > Hari Bathini writes: > >> diff --git a/arch/powerpc/include/asm/crashdump-ppc64.h >> b/arch/powerpc/include/asm/crashdump-ppc64.h >> new file mode 100644 >> index 000..90deb46 >> --- /dev/null >> +++ b/arch/powerpc/include/asm/crashdump-ppc64.h >> @@ -0,0 +

Re: [PATCH V3 3/3] platform/x86: Intel PMT Telemetry capability driver

2020-07-15 Thread Alexey Budankov
On 16.07.2020 2:59, David E. Box wrote: > On Wed, 2020-07-15 at 10:39 +0300, Alexey Budankov wrote: >> Hi David, >> >> On 14.07.2020 9:23, David E. Box wrote: > > ... > >>> >>> +static int pmt_telem_open(struct inode *inode, struct file *filp) >>> +{ >>> + struct pmt_telem_priv *priv; >>> +

Re: [PATCH v4] phy: samsung: Use readl_poll_timeout function

2020-07-15 Thread Anand Moon
Hi Vinod, On Thu, 16 Jul 2020 at 11:20, Vinod Koul wrote: > > On 13-07-20, 07:42, Anand Moon wrote: > > Instead of a busy waiting while loop using udelay > > use readl_poll_timeout function to check the condition > > is met or timeout occurs in crport_handshake function. > > readl_poll_timeout is

Re: [PATCH v2 bpf-next 1/2] bpf: separate bpf_get_[stack|stackid] for perf events BPF

2020-07-15 Thread Andrii Nakryiko
On Tue, Jul 14, 2020 at 11:08 PM Song Liu wrote: > > Calling get_perf_callchain() on perf_events from PEBS entries may cause > unwinder errors. To fix this issue, the callchain is fetched early. Such > perf_events are marked with __PERF_SAMPLE_CALLCHAIN_EARLY. > > Similarly, calling bpf_get_[stack

Re: [PATCH v4] phy: samsung: Use readl_poll_timeout function

2020-07-15 Thread Vinod Koul
On 13-07-20, 07:42, Anand Moon wrote: > Instead of a busy waiting while loop using udelay > use readl_poll_timeout function to check the condition > is met or timeout occurs in crport_handshake function. > readl_poll_timeout is called in non atomic context so > it safe to sleep until the condition

Re: [PATCH v1] driver core: Fix scheduling while atomic warnings during device link deletion

2020-07-15 Thread Marek Szyprowski
does not have a release() > function, it is broken and must be fixed. > > WARNING: CPU: 0 PID: 1 at drivers/base/core.c:1790 device_release+0x94/0xa4 > Device '53f9c000.gpio:50038000.ethernet' does not have a release() function, > it is broken and must be fixed. &g

[PATCH] remoteproc: qcom: pil-info: Fix shift overflow

2020-07-15 Thread Bjorn Andersson
On platforms with 32-bit phys_addr_t the shift to get the upper word of the base address of the memory region is invalid. Cast the base to 64 bit to resolv this. Fixes: 549b67da660d ("remoteproc: qcom: Introduce helper to store pil info in IMEM") Reported-by: Lee Jones Reported-by: Nathan Chance

[PATCH v2 1/4] dt-bindings: media: venus: Add an optional power domain for perf voting

2020-07-15 Thread Rajendra Nayak
Add an optional power domain which when specified can be used for setting the performance state of Venus. Signed-off-by: Rajendra Nayak --- This is a resend of https://lore.kernel.org/patchwork/patch/1241077/ Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml| 6 +- Document

[PATCH v2 4/4] arm64: dts: sc7180: Add OPP tables and power-domains for venus

2020-07-15 Thread Rajendra Nayak
Add the OPP tables in order to be able to vote on the performance state of a power-domain Signed-off-by: Rajendra Nayak --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 35 +-- 1 file changed, 33 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc718

[PATCH v2 2/4] media: venus: core: Add support for opp tables/perf voting

2020-07-15 Thread Rajendra Nayak
Add support to add OPP tables and perf voting on the OPP powerdomain. This is needed so venus votes on the corresponding performance state for the OPP powerdomain along with setting the core clock rate. Signed-off-by: Rajendra Nayak Reviewed-by: Matthias Kaehlcke --- drivers/media/platform/qcom

[PATCH v2 3/4] arm64: dts: sdm845: Add OPP tables and power-domains for venus

2020-07-15 Thread Rajendra Nayak
Add the OPP tables in order to be able to vote on the performance state of a power-domain. Signed-off-by: Rajendra Nayak --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 40 ++-- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm

[PATCH v2 0/4] DVFS support for Venus

2020-07-15 Thread Rajendra Nayak
v2: Fixed up the labels of OPP nodes in patch 4 Included the bindings update patch as part of this series, a resend of https://lore.kernel.org/patchwork/patch/1241077/ These patches add DVFS support for Venus Patch 1 will need to be picked by Rob. Patch 2 will need to be picked by Stan, P

Re: [PATCH v3 12/12] ppc64/kexec_file: fix kexec load failure with lack of memory hole

2020-07-15 Thread Thiago Jung Bauermann
Hari Bathini writes: > The kexec purgatory has to run in real mode. Only the first memory > block maybe accessible in real mode. And, unlike the case with panic > kernel, no memory is set aside for regular kexec load. Another thing > to note is, the memory for crashkernel is reserved at an offs

RE: [PATCH 16/24] scsi: megaraid: Fix a whole bunch of function header formatting issues

2020-07-15 Thread Chandrakanth Patil
Acked-by: Chandrakanth Patil -Original Message- From: linux-scsi-ow...@vger.kernel.org On Behalf Of Lee Jones Sent: Thursday, July 9, 2020 10:46 AM To: j...@linux.ibm.com; martin.peter...@oracle.com; linux-s...@vger.kernel.org Cc: linux-kernel@vger.kernel.org; Lee Jones ; Kashyap Desai ;

Re: [PATCH RFC don't apply] vdpa_sim: endian-ness for config space

2020-07-15 Thread Michael S. Tsirkin
On Wed, Jul 15, 2020 at 10:02:32PM +0800, Jason Wang wrote: > > On 2020/7/15 下午9:58, Michael S. Tsirkin wrote: > > VDPA sim stores config space as native endian, but that > > is wrong: modern guests expect LE. > > I coded up the following to fix it up, but it is wrong too: > > vdpasim_create is ca

Re: [PATCH 2/2] Input: elan_i2c - Modify the IAP related function for page sizes 128, 512 bytes.

2020-07-15 Thread Dmitry Torokhov
Hi Jingle, On Tue, Jul 14, 2020 at 06:56:41AM -0400, Jingle Wu wrote: > + if (!iap) > + cmd = ETP_I2C_FW_VERSION_CMD; > + else if (pattern_ver == 0) > + cmd = ETP_I2C_IAP_VERSION_CMD_OLD; Just to confirm, the older devices (I assume that pattern 0 means older) have

[PATCH] rtc: pl031: fix alarm support

2020-07-15 Thread Marek Szyprowski
Commit 75a472845196 ("rtc: pl031: switch to rtc_time64_to_tm/rtc_tm_to_time64") adjusted driver to the new API, but during the conversion a call to enable alarm irq in set_alarm() was lost. Restore it, what fixes alarm support in the PL031 RTC driver. Fixes: 75a472845196 ("rtc: pl031: switch to rt

[PATCH] clk: qcom: ipq8074: Add correct index for PCIe clocks

2020-07-15 Thread Sivaprakash Murugesan
The PCIe clocks GCC_PCIE0_AXI_S_BRIDGE_CLK, GCC_PCIE0_RCHNG_CLK_SRC, GCC_PCIE0_RCHNG_CLK are wrongly added to the gcc reset group. Move them to the gcc clock group. Reported-by: kernel test robot Signed-off-by: Sivaprakash Murugesan --- include/dt-bindings/clock/qcom,gcc-ipq8074.h | 6 +++---

Re: [PATCH] drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state

2020-07-15 Thread Matt Roper
On Wed, Jul 15, 2020 at 09:27:42PM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/gpu/drm/i915/display/intel_combo_phy.c:268:3: warning: variable > 'ret' is uninitialized when used here [-Wuninitialized] > ret &= check_phy_reg(dev_priv, phy, ICL_PORT_TX_DW8_LN0(phy), >

Re: [PATCH v1] driver core: Fix scheduling while atomic warnings during device link deletion

2020-07-15 Thread Guenter Roeck
On 7/15/20 10:08 PM, Saravana Kannan wrote: > Marek and Guenter reported that commit 287905e68dd2 ("driver core: > Expose device link details in sysfs") caused sleeping/scheduling while > atomic warnings. > > BUG: sleeping function called from invalid context at > kernel/locking/mutex.c:935 > in_

Re: [PATCH] time/sched_clock: Use raw_read_seqcount_latch()

2020-07-15 Thread Leo Yan
Hi Peter, Ahemd, On Wed, Jul 15, 2020 at 05:58:50PM +0200, Peter Zijlstra wrote: [...] > > > diff --git a/kernel/time/sched_clock.c b/kernel/time/sched_clock.c > > > index fa3f800d7d76..ea007928d681 100644 > > > --- a/kernel/time/sched_clock.c > > > +++ b/kernel/time/sched_clock.c > > > @@ -100,

Re: [RFC PATCH 4/7] x86: use exit_lazy_tlb rather than membarrier_mm_sync_core_before_usermode

2020-07-15 Thread Andy Lutomirski
> On Jul 15, 2020, at 9:15 PM, Nicholas Piggin wrote: > > Excerpts from Mathieu Desnoyers's message of July 14, 2020 12:13 am: >> - On Jul 13, 2020, at 9:47 AM, Nicholas Piggin npig...@gmail.com wrote: >> >>> Excerpts from Nicholas Piggin's message of July 13, 2020 2:45 pm: Excerpts

[PATCH v3 2/2] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart"

2020-07-15 Thread Bhanu Prakash Maiya
From: Bhanu Prakash Maiya Add DT compatible string in Documentation/devicetree/bindings/mfd/cros_ec.txt Signed-off-by: Bhanu Prakash Maiya --- Changes in v3: - Rebased changes on google,cros-ec.yaml Changes in v2: - No change Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 6 +++

[PATCH v3 1/2] platform/chrome: cros_ec_uart: Add cros-ec-uart transport layer

2020-07-15 Thread Bhanu Prakash Maiya
From: Bhanu Prakash Maiya This patch enables uart transport layer for cros_ec framework. The cros-ec-uart binds with EC device working on uart transport to send request and receive response. Signed-off-by: Bhanu Prakash Maiya --- Changes in v3: - checkpatch.pl script warns about char len 80 ev

[PATCH v3 6/7] arm64: perf: Add cap_user_time_short

2020-07-15 Thread Leo Yan
From: Peter Zijlstra This completes the ARM64 cap_user_time support. Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Leo Yan --- arch/arm64/kernel/perf_event.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/ker

[PATCH v3 7/7] tools headers UAPI: Update tools's copy of linux/perf_event.h

2020-07-15 Thread Leo Yan
To get the changes in the commit: "perf: Add perf_event_mmap_page::cap_user_time_short ABI" This update is a prerequisite to add support for short clock counters related ABI extension. Signed-off-by: Leo Yan --- tools/include/uapi/linux/perf_event.h | 23 --- 1 file chang

Re: [PATCH 2/2] debugfs: Add access restriction option

2020-07-15 Thread Randy Dunlap
Hi Peter, Here are a few more comments/corrections. On 7/15/20 9:54 PM, Peter Enderborg wrote: > Since debugfs include sensitive information it need to be treated > carefully. But it also has many very useful debug functions for userspace. > With this option we can have same configuration for sys

[PATCH v3 5/7] perf: Add perf_event_mmap_page::cap_user_time_short ABI

2020-07-15 Thread Leo Yan
From: Peter Zijlstra In order to support short clock counters, provide an ABI extension. As a whole: u64 time, delta, cyc = read_cycle_counter(); + if (cap_user_time_short) + cyc = time_cycle + ((cyc - time_cycle) & time_mask); delta = mul_u64_u32_shr(cyc, time_mult, time_shif

[PATCH v3 4/7] arm64: perf: Only advertise cap_user_time for arch_timer

2020-07-15 Thread Leo Yan
From: Peter Zijlstra When sched_clock is running on anything other than arch_timer, don't advertise cap_user_time*. Requested-by: Will Deacon Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Leo Yan --- arch/arm64/kernel/perf_event.c | 19 +-- 1 file changed, 13 insertion

[PATCH v3 1/7] sched_clock: Expose struct clock_read_data

2020-07-15 Thread Leo Yan
From: Peter Zijlstra In order to support perf_event_mmap_page::cap_time features, an architecture needs, aside from a userspace readable counter register, to expose the exact clock data so that userspace can convert the counter register into a correct timestamp. Provide struct clock_read_data an

[PATCH v3 2/7] time/sched_clock: Use raw_read_seqcount_latch()

2020-07-15 Thread Leo Yan
From: "Ahmed S. Darwish" sched_clock uses seqcount_t latching to switch between two storage places protected by the sequence counter. This allows it to have interruptible, NMI-safe, seqcount_t write side critical sections. Since 7fc26327b756 ("seqlock: Introduce raw_read_seqcount_latch()"), raw_

[PATCH v3 3/7] arm64: perf: Implement correct cap_user_time

2020-07-15 Thread Leo Yan
From: Peter Zijlstra As reported by Leo; the existing implementation is broken when the clock and counter don't intersect at 0. Use the sched_clock's struct clock_read_data information to correctly implement cap_user_time and cap_user_time_zero. Note that the ARM64 counter is architecturally on

[PATCH v2] ASoC: soc-component: Add missed return for calling soc_component_ret

2020-07-15 Thread Shengjiu Wang
Add missed return for calling soc_component_ret, otherwise the return value is wrong. Fixes: e2329eeba45f ("ASoC: soc-component: add soc_component_err()") Signed-off-by: Shengjiu Wang --- changes in v2 - add missed return in snd_soc_pcm_component_sync_stop and - snd_soc_pcm_component_new sound/

[PATCH trivial] spi: Fix SPI NOR and SPI NAND acronyms

2020-07-15 Thread Tudor Ambarus
The industry refers to these flash types as "SPI NOR" and "SPI NAND". Be consistent and use the same acronyms. Signed-off-by: Tudor Ambarus --- drivers/spi/Kconfig| 10 +- drivers/spi/spi-fsl-qspi.c | 2 +- drivers/spi/spi-orion.c| 2 +- 3 files changed, 7 insertions(+), 7

Re: [PATCH v12 2/2] phy: samsung-ufs: add UFS PHY driver for samsung SoC

2020-07-15 Thread Vinod Koul
Hi Alim, On 16-07-20, 06:47, Alim Akhtar wrote: > > > +static int samsung_ufs_phy_symbol_clk_init(struct samsung_ufs_phy > > > +*phy) { > > > + int ret = 0; > > > > superfluous init, am sure I flagged it before as well > > > Yes, you did, but 0-DAY CI kernel test gave warning [1], so I kept thi

[PATCH v3 0/7] arm64: perf: Proper cap_user_time* support

2020-07-15 Thread Leo Yan
This patch set is rebased for Peter's patch set to support cap_user_time/cap_user_time_short ABI for Arm64, and export Arm arch timer counter related parameters from kernel to Perf tool. After get feedback from Ahmed, this patch set contains Ahmed's new patch to refine sched clock data accessing w

RE: [PATCH v2] powercap: Add Power Limit4 support

2020-07-15 Thread Pawnikar, Sumeet R
> -Original Message- > From: Srinivas Pandruvada > Sent: Wednesday, July 15, 2020 5:44 AM > To: Rafael J. Wysocki ; Pawnikar, Sumeet R > > Cc: Rafael J. Wysocki ; Zhang, Rui > ; Linux PM ; Linux Kernel > Mailing List ; Shevchenko, Andriy > > Subject: Re: [PATCH v2] powercap: Add Power L

[PATCH v1] driver core: Fix scheduling while atomic warnings during device link deletion

2020-07-15 Thread Saravana Kannan
Marek and Guenter reported that commit 287905e68dd2 ("driver core: Expose device link details in sysfs") caused sleeping/scheduling while atomic warnings. BUG: sleeping function called from invalid context at kernel/locking/mutex.c:935 in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 12, nam

Re: [External] Re: [PATCH v2] mm: memcg/slab: fix memory leak at non-root kmem_cache destroy

2020-07-15 Thread Muchun Song
On Thu, Jul 16, 2020 at 1:54 AM Roman Gushchin wrote: > > On Thu, Jul 16, 2020 at 12:50:22AM +0800, Muchun Song wrote: > > If the kmem_cache refcount is greater than one, we should not > > mark the root kmem_cache as dying. If we mark the root kmem_cache > > dying incorrectly, the non-root kmem_ca

RE: [PATCH v2] powercap: Add Power Limit4 support

2020-07-15 Thread Pawnikar, Sumeet R
> -Original Message- > From: linux-pm-ow...@vger.kernel.org > On Behalf Of Rafael J. Wysocki > Sent: Tuesday, July 14, 2020 6:51 PM > To: Pawnikar, Sumeet R ; Srinivas > Pandruvada > Cc: Rafael J. Wysocki ; Zhang, Rui > ; Linux PM ; Linux Kernel > Mailing List ; Shevchenko, Andriy > > S

Re: [PATCH v7 2/5] remoteproc: qcom: Introduce helper to store pil info in IMEM

2020-07-15 Thread Nathan Chancellor
On Mon, Jun 22, 2020 at 12:19:39PM -0700, Bjorn Andersson wrote: > A region in IMEM is used to communicate load addresses of remoteproc to > post mortem debug tools. Implement a helper function that can be used to > store this information in order to enable these tools to process > collected ramdum

Re: [PATCH v4 7/9] bus: mhi: core: Introduce debugfs entries and counters for MHI

2020-07-15 Thread Manivannan Sadhasivam
On Thu, Jul 09, 2020 at 12:33:02PM -0700, bbh...@codeaurora.org wrote: > On 2020-07-04 08:41, Manivannan Sadhasivam wrote: > > On Mon, Jun 29, 2020 at 09:39:40AM -0700, Bhaumik Bhatt wrote: > > > Introduce debugfs entries to show state, register, channel, and event > > > ring information. Add MHI s

Re: WARNING in submit_bio_checks

2020-07-15 Thread syzbot
syzbot has bisected this issue to: commit 449325b52b7a6208f65ed67d3484fd7b7184477b Author: Alexei Starovoitov Date: Tue May 22 02:22:29 2018 + umh: introduce fork_usermode_blob() helper bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=10fc4b0090 start commit: 9e50b94

[PATCH 2/2] debugfs: Add access restriction option

2020-07-15 Thread Peter Enderborg
Since debugfs include sensitive information it need to be treated carefully. But it also has many very useful debug functions for userspace. With this option we can have same configuration for system with need of debugfs and a way to turn it off. This gives a extra protection for exposure on system

[PATCH v7 0/2] debugfs: Add access restriction option

2020-07-15 Thread Peter Enderborg
Since debugfs include sensitive information it need to be treated carefully. But it also has many very useful debug functions for userspace. With this option we can have same configuration for system with need of debugfs and a way to turn it off. This gives a extra protection for exposure on system

[PATCH 1/2] tracefs: Remove unnecessary debug_fs checks.

2020-07-15 Thread Peter Enderborg
This is a preparation for debugfs restricted mode. We don't need debugfs to trace, the removed check stop tracefs to work if debugfs is not initialised. We instead tries to automount within debugfs and relay on it's handling. The code path is to create a backward compatibility from when tracefs was

Re: [PATCH v3] powerpc/pseries: detect secure and trusted boot state of the system.

2020-07-15 Thread Michael Ellerman
Daniel Axtens writes: > Hi Nayna, > > Looks good to me. > > Sorry for not noticing this before, but I think >> +#include > is now superfluous (I think it's leftover from the machine_is > version?). Maybe mpe will take pity on you and remove it when he picks > up your patch. Yeah I did that. ch

Re: [PATCH] ASoC: soc-component: Add missed return for snd_soc_pcm_component_mmap

2020-07-15 Thread Shengjiu Wang
On Thu, Jul 16, 2020 at 12:19 PM Kuninori Morimoto wrote: > > > Hi Shengjiu > > > Add missed return for snd_soc_pcm_component_mmap, otherwise it always > > return -EINVAL. > > > > Fixes: e2329eeba45f ("ASoC: soc-component: add soc_component_err()") > > Signed-off-by: Shengjiu Wang > > --- > > Oop

[PATCH] igc: Do not use link uninitialized in igc_check_for_copper_link

2020-07-15 Thread Nathan Chancellor
Clang warns: drivers/net/ethernet/intel/igc/igc_mac.c:374:6: warning: variable 'link' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (!mac->get_link_status) { ^ drivers/net/ethernet/intel/igc/igc_mac.c:424:33: note: unin

RE: [PATCH v2] panic: prevent panic_timeout * 1000 from overflow

2020-07-15 Thread charley.ashbringer
> > Since panic_timeout is an integer passed-in through sysctl, > > the loop boundary panic_timeout * 1000 could overflow and > > result in a zero-delay panic when panic_timeout is greater > > than INT_MAX/1000. > > > > Fix this by moving 1000 to the left, also in case i/1000 > > might never be gre

Re: [RFC PATCH 4/7] x86: use exit_lazy_tlb rather than membarrier_mm_sync_core_before_usermode

2020-07-15 Thread Nicholas Piggin
Excerpts from Nicholas Piggin's message of July 16, 2020 2:15 pm: > Excerpts from Mathieu Desnoyers's message of July 14, 2020 12:13 am: >> - On Jul 13, 2020, at 9:47 AM, Nicholas Piggin npig...@gmail.com wrote: >> >>> Excerpts from Nicholas Piggin's message of July 13, 2020 2:45 pm: Exce

RE: [PATCH 2/9] iommu/ipmmu-vmsa: Hook up R8A774E1 DT matching code

2020-07-15 Thread Yoshihiro Shimoda
Hi Geert-san, > From: Geert Uytterhoeven, Sent: Tuesday, July 14, 2020 9:40 PM > > Hi Shimoda-san, > > On Tue, Jul 14, 2020 at 1:42 PM Yoshihiro Shimoda > wrote: > > > From: Geert Uytterhoeven, Sent: Tuesday, July 14, 2020 5:42 PM > > > On Tue, Jul 14, 2020 at 10:30 AM Lad, Prabhakar > > > wro

[PATCH] riscv: Add SiFive drivers to rv32_defconfig

2020-07-15 Thread Bin Meng
From: Bin Meng This adds SiFive drivers to rv32_defconfig, to keep in sync with the 64-bit config. This is useful when testing 32-bit kernel with QEMU 'sifive_u' 32-bit machine. Signed-off-by: Bin Meng --- arch/riscv/configs/rv32_defconfig | 5 + 1 file changed, 5 insertions(+) diff --gi

[PATCH] spi: atmel-quadspi: Use optimezed memcpy_fromio()/memcpy_toio()

2020-07-15 Thread Tudor Ambarus
Optimezed mem*io operations are defined for LE platforms, use them. The ARM and !ARCH_EBSA110 dependencies for COMPILE_TEST were added only for the _memcpy_fromio()/_memcpy_toio() functions. Drop these dependencies. Tested unaligned accesses on both sama5d2 and sam9x60 QSPI controllers using SPI

[PATCH] drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state

2020-07-15 Thread Nathan Chancellor
Clang warns: drivers/gpu/drm/i915/display/intel_combo_phy.c:268:3: warning: variable 'ret' is uninitialized when used here [-Wuninitialized] ret &= check_phy_reg(dev_priv, phy, ICL_PORT_TX_DW8_LN0(phy), ^~~ drivers/gpu/drm/i915/display/intel_combo_phy.c:261:10: note

[PATCH] can: m_can: Set device to software init mode before closing

2020-07-15 Thread Faiz Abbas
There might be some requests pending in the buffer when the interface close sequence occurs. In some devices, these pending requests might lead to the module not shutting down properly when m_can_clk_stop() is called. Therefore, move the device to init state before potentially powering it down. S

[PATCH v3 3/4] regulator: core: Add basic enable/disable support for sync_state() callbacks

2020-07-15 Thread Saravana Kannan
Consider the following example: - regulator-X is provided by device-X. - regulator-X is a supplier to device-A, device-B and device-C. - device-A is off/inactive from boot. - device-B and device-C are left on/active by the bootloader - regulator-X is left on boot by the bootloader at 2000 mV to sup

[PATCH v3 4/4] regulator: core: Add voltage support for sync_state() callbacks

2020-07-15 Thread Saravana Kannan
Consider the following example: - regulator-X is provided by device-X. - regulator-X is a supplier to device-A, device-B and device-C. - device-A is off/inactive from boot. - device-B and device-C are left on/active by the bootloader - regulator-X is left on boot by the bootloader at 2000 mV to sup

[PATCH v3 1/4] driver core: Add dev_set_drv_sync_state()

2020-07-15 Thread Saravana Kannan
This can be used by frameworks to set the sync_state() helper functions for drivers that don't already have them set. Signed-off-by: Saravana Kannan --- include/linux/device.h | 12 1 file changed, 12 insertions(+) diff --git a/include/linux/device.h b/include/linux/device.h index

  1   2   3   4   5   6   7   8   9   10   >