Re: [PATCH v3 13/15] mm,hwpoison: Refactor soft_offline_huge_page and __soft_offline_page

2020-06-27 Thread Naoya Horiguchi
On Fri, Jun 26, 2020 at 10:23:43PM +0530, Naresh Kamboju wrote: > On Wed, 24 Jun 2020 at 20:32, wrote: > > > > From: Oscar Salvador > > > > Merging soft_offline_huge_page and __soft_offline_page let us get rid of > > quite some duplicated code, and makes the code much easier to follow. > > > > No

RE: [RFC PATCH 1/2] 9p: retrieve fid from file when file instance exist.

2020-06-27 Thread Jianyong Wu
Hi Dominique, > -Original Message- > From: Dominique Martinet > Sent: Sunday, June 28, 2020 2:28 PM > To: Jianyong Wu > Cc: eri...@gmail.com; lu...@ionkov.net; v9fs- > develo...@lists.sourceforge.net; linux-kernel@vger.kernel.org; Steve > Capper ; Kaly Xin ; Justin He > ; Wei Chen > Sub

Re: [PATCH] sched: fix build with GCC_PLUGIN_RANDSTRUCT

2020-06-27 Thread Mike Rapoport
On Sat, Jun 27, 2020 at 06:12:14PM -0400, Steven Rostedt wrote: > On Sat, 20 Jun 2020 13:41:36 +0300 > Mike Rapoport wrote: > > > From: Mike Rapoport > > > > Since the commit a148866489fb ("sched: Replace rq::wake_list") > > task_struct and CSD_TYPE_TTWU objects can be on the same queue and thi

Re: [PATCH] ARM: dts: zx: Align L2 cache-controller nodename with dtschema

2020-06-27 Thread Jun Nie
Krzysztof Kozlowski 于2020年6月26日周五 下午4:05写道: > > Fix dtschema validator warnings like: > l2-cache-controller@c0: $nodename:0: > 'l2-cache-controller@c0' does not match > '^(cache-controller|cpu)(@[0-9a-f,]+)*$' > > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm/boot/dts/

Re: [RFC PATCH 1/2] 9p: retrieve fid from file when file instance exist.

2020-06-27 Thread Dominique Martinet
Jianyong Wu wrote on Sun, Jun 28, 2020: > In the current setattr implementation in 9p, fid will always retrieved from > dentry no matter file instance exist or not when setattr. There will > be some info related to open file instance dropped. so it's better > to retrieve fid from file instance if f

Re: [PATCH v2 2/2] virtio: virtio_has_iommu_quirk -> virtio_has_dma_quirk

2020-06-27 Thread Jason Wang
On 2020/6/25 上午7:21, Michael S. Tsirkin wrote: Now that the corresponding feature bit has been renamed, rename the quirk too - it's about special ways to do DMA, not necessarily about the IOMMU. Signed-off-by: Michael S. Tsirkin --- drivers/gpu/drm/virtio/virtgpu_object.c | 2 +- drivers/g

Re: [PATCH] virtio: VIRTIO_F_IOMMU_PLATFORM -> VIRTIO_F_ACCESS_PLATFORM

2020-06-27 Thread Jason Wang
On 2020/6/25 上午6:25, Michael S. Tsirkin wrote: Rename the bit to match latest virtio spec. Add a compat macro to avoid breaking existing userspace. Signed-off-by: Michael S. Tsirkin --- arch/um/drivers/virtio_uml.c | 2 +- drivers/vdpa/ifcvf/ifcvf_base.h| 2 +- drivers/vdpa/vd

Re: [PATCH] modpost: remove use of non-standard strsep() in HOSTCC code

2020-06-27 Thread H. Nikolaus Schaller
Hi, > Am 28.06.2020 um 07:51 schrieb Masahiro Yamada : > > On Thu, Jun 25, 2020 at 5:47 PM H. Nikolaus Schaller > wrote: >> >> strsep() is neither standard C nor POSIX and used outside >> the kernel code here. Using it here requires that the >> build host supports it out of the box which is e.

Re: [PATCH] riscv: Fixup compile error BUILD_BUG_ON failed

2020-06-27 Thread Guo Ren
On Sun, Jun 28, 2020 at 10:59 AM Masami Hiramatsu wrote: > > On Sat, 27 Jun 2020 16:20:02 + > guo...@kernel.org wrote: > > > From: Guo Ren > > > > Unfortunately, the current code couldn't be compiled, because > > BUILD_BUG_ON needs a static defined value, not a dynamic > > variable with a0 re

[PATCH 4/6] fs/minix: set s_maxbytes correctly

2020-06-27 Thread Eric Biggers
From: Eric Biggers The minix filesystem leaves super_block::s_maxbytes at MAX_NON_LFS rather than setting it to the actual filesystem-specific limit. This is broken because it means userspace doesn't see the standard behavior like getting EFBIG and SIGXFSZ when exceeding the maximum file size.

[PATCH 0/6] fs/minix: fix syzbot bugs and set s_maxbytes

2020-06-27 Thread Eric Biggers
This series fixes all syzbot bugs in the minix filesystem: KASAN: null-ptr-deref Write in get_block KASAN: use-after-free Write in get_block KASAN: use-after-free Read in get_block WARNING in inc_nlink KMSAN: uninit-value in get_block WARNING in drop

[PATCH 3/6] fs/minix: reject too-large maximum file size

2020-06-27 Thread Eric Biggers
From: Eric Biggers If the minix filesystem tries to map a very large logical block number to its on-disk location, block_to_path() can return offsets that are too large, causing out-of-bounds memory accesses when accessing indirect index blocks. This should be prevented by the check against the

[PATCH 2/6] fs/minix: don't allow getting deleted inodes

2020-06-27 Thread Eric Biggers
From: Eric Biggers If an inode has no links, we need to mark it bad rather than allowing it to be accessed. This avoids WARNINGs in inc_nlink() and drop_nlink() when doing directory operations on a fuzzed filesystem. Reported-by: syzbot+a9ac3de1b5de5fb10...@syzkaller.appspotmail.com Reported-by

[PATCH 1/6] fs/minix: check return value of sb_getblk()

2020-06-27 Thread Eric Biggers
From: Eric Biggers sb_getblk() can fail, so check its return value. This fixes a NULL pointer dereference. Reported-by: syzbot+4a88b2b9dc280f47b...@syzkaller.appspotmail.com Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: sta...@vger.kernel.org Originally-from: Qiujun Huang Signed-off-by: Eric Bi

[PATCH 6/6] fs/minix: remove expected error message in block_to_path()

2020-06-27 Thread Eric Biggers
From: Eric Biggers When truncating a file to a size within the last allowed logical block, block_to_path() is called with the *next* block. This exceeds the limit, causing the "block %ld too big" error message to be printed. This case isn't actually an error; there are just no more blocks past

[PATCH 5/6] fs/minix: fix block limit check for V1 filesystems

2020-06-27 Thread Eric Biggers
From: Eric Biggers The minix filesystem reads its maximum file size from its on-disk superblock. This value isn't necessarily a multiple of the block size. When it's not, the V1 block mapping code doesn't allow mapping the last possible block. Commit 6ed6a722f9ab ("minixfs: fix block limit chec

Re: [bpf] will-it-scale.per_thread_ops 2.6% improvement

2020-06-27 Thread Yonghong Song
On 6/27/20 1:22 AM, kernel test robot wrote: Greeting, FYI, we noticed a 2.6% improvement of will-it-scale.per_thread_ops due to commit: Thanks. The improvement is always good although I do not know what will-it-scale.per_thread_ops exactly running. But I think the commit 492e639f0c222

[RFC PATCH linus] drivers: thermal: tsens: tsens_critical_irq_thread() can be static

2020-06-27 Thread kernel test robot
Fixes: a7ff82976122 ("drivers: thermal: tsens: Merge tsens-common.c into tsens.c") Signed-off-by: kernel test robot --- tsens.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c index 8d3e94d2a9ed4..39c4

Re: [PATCH] gcc-plugins: fix gcc-plugins directory path in documentation

2020-06-27 Thread Masahiro Yamada
On Wed, Feb 26, 2020 at 3:58 AM Kees Cook wrote: > > On Thu, Feb 13, 2020 at 09:24:10PM +0900, Masahiro Yamada wrote: > > Fix typos "plgins" -> "plugins". > > > > Signed-off-by: Masahiro Yamada > > Thanks! > > Acked-by: Kees Cook > > Jon, can you take this? I noticed this patch had fallen into

[PATCH] [v3] media: venus: core: Fix runtime PM imbalance in venus_probe

2020-06-27 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. For other error paths after this call, things are the same. Fix this by adding pm_runtime_put_noidle() after

Re: [RFC PATCH 2/2] 9p: remove unused code in 9p

2020-06-27 Thread Dominique Martinet
Jianyong Wu wrote on Sun, Jun 28, 2020: > These code has been commented out since 2007 and lied in kernel > since then. it's time to remove thest no used code. Good point, happy to take this - please resend without RFC separately (the two commits aren't related) after fixing the commit message (li

Re: [PATCH] modpost: remove use of non-standard strsep() in HOSTCC code

2020-06-27 Thread Masahiro Yamada
On Thu, Jun 25, 2020 at 5:47 PM H. Nikolaus Schaller wrote: > > strsep() is neither standard C nor POSIX and used outside > the kernel code here. Using it here requires that the > build host supports it out of the box which is e.g. > not true for a Darwin build host and using a cross-compiler. > T

Re: wait_on_page_bit_common(TASK_KILLABLE, EXCLUSIVE) can miss wakeup?

2020-06-27 Thread Linus Torvalds
On Fri, Jun 26, 2020 at 8:43 AM Peter Zijlstra wrote: > > I ended up with something like the below.. but it is too warm to think > properly. > > I don't particularly like WQ_FLAG_PAGEWAITERS, but I liked open-coding > all that even less. Ugh. I think I have a much simpler approach, actually. So

Re: Re: [PATCH] [v2] media: venus: core: Fix runtime PM imbalance in venus_probe

2020-06-27 Thread dinghao . liu
> > Could you reword this and add it to the patch description. > Fine. I will fix this in the next version of patch. Regards, Dinghao

RE: [PATCH] ath10k: Add history for tracking certain events

2020-06-27 Thread Rakesh Pillai
> -Original Message- > From: Ben Greear > Sent: Saturday, June 27, 2020 8:58 PM > To: Rakesh Pillai ; ath...@lists.infradead.org > Cc: linux-wirel...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] ath10k: Add history for tracking certain events > > > > On 06/26/

RE: [EXT] [PATCH v4 2/2] ARM: imx6plus: enable internal routing of clk_enet_ref where possible

2020-06-27 Thread Andy Duan
From: Sven Van Asbroeck Sent: Thursday, June 25, 2020 10:01 PM > On imx6, the ethernet reference clock (clk_enet_ref) can be generated by > either the imx6, or an external source (e.g. an oscillator or the PHY). When > generated by the imx6, the clock source (from ANATOP) must be routed to the >

[PATCH] staging: media: atomisp: i2c: atomisp-ov2680.c: fixed a brace coding style issue.

2020-06-27 Thread B K Karthik
Fixed a coding style issue. Signed-off-by: B K Karthik --- drivers/staging/media/atomisp/i2c/atomisp-ov2680.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c index 9

[PATCH 5/9] macintosh/via-macii: Handle poll replies correctly

2020-06-27 Thread Finn Thain
Userspace applications may use /dev/adb to send Talk requests. Such requests always have req->reply_expected == 1. The same is true of Talk requests sent by the kernel, except for poll requests queued internally by the via-macii driver. Those requests have req->reply_expected == 0. Consequently, p

[PATCH 0/9] Macintosh II ADB driver fixes

2020-06-27 Thread Finn Thain
Various issues with the via-macii driver have become apparent over the years. Some examples: - A Talk command response can be lost. This can result in phantom devices being probed or an incorrect device handler ID being retrieved. - A reply packet containing a null byte can get truncated. Such

[PATCH 2/9] macintosh/via-macii: Poll the device most likely to respond

2020-06-27 Thread Finn Thain
Poll the most recently polled device by default, rather than the lowest device address that happens to be enabled in autopoll_devs. This improves input latency. Re-use macii_queue_poll() rather than duplicate that logic. This eliminates a static struct and function. Fixes: d95fd5fce88f0 ("m68k: Ma

[PATCH 6/9] macintosh/via-macii: Use bool type for reading_reply variable

2020-06-27 Thread Finn Thain
Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/macintosh/via-macii.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/macintosh/via-macii.c b/drivers/macintosh/via-macii.c index 8d5ef77b4a435..e143ddb81de34 100644 --- a/drivers/macintosh/via-m

[PATCH 4/9] macintosh/via-macii: Remove read_done state

2020-06-27 Thread Finn Thain
The driver state machine may enter the 'read_done' state when leaving the 'idle' or 'reading' state. This transition is pointless, as is the extra interrupt it requires. The interrupt is produced by the transceiver (even when it has no data to send) because an extra EVEN/ODD toggle was signalled by

[PATCH 8/9] macintosh/via-macii: Use the stack for reset request storage

2020-06-27 Thread Finn Thain
The adb_request struct can be stored on the stack because the request is synchronous and is completed before the function returns. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/macintosh/via-macii.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/maci

[PATCH 7/9] macintosh/via-macii: Use unsigned type for autopoll_devs variable

2020-06-27 Thread Finn Thain
Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/macintosh/via-macii.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/macintosh/via-macii.c b/drivers/macintosh/via-macii.c index e143ddb81de34..447273967e1e8 100644 --- a/drivers/macintosh/via-macii.c

[PATCH 9/9] macintosh/via-macii: Clarify definition of macii_init()

2020-06-27 Thread Finn Thain
The function prototype correctly specifies the 'static' storage class. Let the function definition match the declaration for better readability. Signed-off-by: Finn Thain --- drivers/macintosh/via-macii.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/macintosh/via-m

[PATCH 1/9] macintosh/via-macii: Access autopoll_devs when inside lock

2020-06-27 Thread Finn Thain
The interrupt handler should be excluded when accessing the autopoll_devs variable. Fixes: d95fd5fce88f0 ("m68k: Mac II ADB fixes") # v5.0+ Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/macintosh/via-macii.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --

[PATCH 3/9] macintosh/via-macii: Handle /CTLR_IRQ signal correctly

2020-06-27 Thread Finn Thain
I'm told that the /CTLR_IRQ signal from the ADB transceiver gets interpreted by MacOS to mean SRQ, bus timeout or end-of-packet depending on the circumstances, and that Linux's via-macii driver does not correctly interpret this signal. Instead, the via-macii driver interprets certain received byte

Re: [patch] dma-pool: warn when coherent pool is depleted

2020-06-27 Thread David Rientjes
On Sun, 21 Jun 2020, Guenter Roeck wrote: > > When a DMA coherent pool is depleted, allocation failures may or may not > > get reported in the kernel log depending on the allocator. > > > > The admin does have a workaround, however, by using coherent_pool= on the > > kernel command line. > > > >

Re: [mm, slub] c91e241f56: WARNING:at_mm/slub.c:#kmem_cache_open

2020-06-27 Thread David Rientjes
On Sat, 27 Jun 2020, kernel test robot wrote: > Greeting, > > FYI, we noticed the following commit (built with gcc-9): > > commit: c91e241f569e7f9b0e2946841ef884b22a09f624 ("mm, slub: introduce > kmem_cache_debug_flags()-fix") > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git m

RE: [PATCH] vfio/pci: Fix SR-IOV VF handling with MMIO blocking

2020-06-27 Thread Wang, Haiyue
> -Original Message- > From: Alex Williamson > Sent: Sunday, June 28, 2020 12:09 > To: Wang, Haiyue > Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org; > maxime.coque...@redhat.com; David Marchand > ; Kevin Traynor > Subject: Re: [PATCH] vfio/pci: Fix SR-IOV VF handling with MMIO

Re: [PATCH v3] PCI: Lock the pci_cfg_wait queue for the consistency of data

2020-06-27 Thread Xiang Zheng
On 2020/6/26 7:24, Bjorn Helgaas wrote: > On Wed, Jun 24, 2020 at 06:23:09PM -0500, Bjorn Helgaas wrote: >> On Tue, Dec 10, 2019 at 11:15:27AM +0800, Xiang Zheng wrote: >>> 7ea7e98fd8d0 ("PCI: Block on access to temporarily unavailable pci >>> device") suggests that the "pci_lock" is sufficient,

Re: [PATCH v3] PCI: Lock the pci_cfg_wait queue for the consistency of data

2020-06-27 Thread Xiang Zheng
Hi Bjorn, Sorry for the late reply, I had Dragon Boat Festival these days. On 2020/6/25 7:23, Bjorn Helgaas wrote: > On Tue, Dec 10, 2019 at 11:15:27AM +0800, Xiang Zheng wrote: >> 7ea7e98fd8d0 ("PCI: Block on access to temporarily unavailable pci >> device") suggests that the "pci_lock" is suffi

Re: [PATCH] vfio/pci: Fix SR-IOV VF handling with MMIO blocking

2020-06-27 Thread Alex Williamson
On Sun, 28 Jun 2020 03:12:12 + "Wang, Haiyue" wrote: > > -Original Message- > > From: kvm-ow...@vger.kernel.org On Behalf Of > > Alex Williamson > > Sent: Friday, June 26, 2020 00:57 > > To: alex.william...@redhat.com > > Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org; > >

drivers/scsi/vmw_pvscsi.c:212:39: sparse: sparse: incorrect type in argument 2 (different address spaces)

2020-06-27 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 916a3b0fc1206f7e7ae8d00a21a3114b1dc67794 commit: 670d0a4b10704667765f7d18f7592993d02783aa sparse: use identifiers to define address spaces date: 9 days ago config: x86_64-randconfig-s031-20200628 (attached

Re: [PATCH v4] kbuild: buildtar: add dtbs support

2020-06-27 Thread Masahiro Yamada
On Sat, Jun 27, 2020 at 9:25 PM Domenico Andreoli wrote: > > From: Domenico Andreoli > > Make 'make tar-pkg' install dtbs. > > v4: > - Install the dtbs before modules & kernel, not after > - Check for the dtbs_install target before attempting to invoke it > > v3: > - Check for CONFIG_OF_EARLY_

Re: [PATCH v2] kbuild: buildtar: add arm64 dtbs support

2020-06-27 Thread Masahiro Yamada
On Sun, Jun 28, 2020 at 6:21 AM Domenico Andreoli wrote: > > On Sat, Jun 27, 2020 at 09:02:52PM +0900, Masahiro Yamada wrote: > > On Sat, Jun 27, 2020 at 6:40 AM Domenico Andreoli > > wrote: > > > On Fri, Jun 26, 2020 at 03:16:58PM +0900, Masahiro Yamada wrote: > > > > On Fri, Jun 26, 2020 at 5:

Re: possible deadlock in process_measurement (2)

2020-06-27 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:1590a2e1 Merge tag 'acpi-5.8-rc3' of git://git.kernel.org/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=164b959b10 kernel config: https://syzkaller.appspot.com/x/.config?x=20c9076

Re: [1/7] irqchip: Fix potential resource leaks

2020-06-27 Thread Tiezhu Yang
On 06/24/2020 08:08 PM, Markus Elfring wrote: How do you think about to extend source code analysis tools accordingly? I have no good idea, maybe some simple match check tools can do this. Would you like to help with any additional software development resources (besides your current contributi

[PATCH ghak124 v3fix] audit: add gfp parameter to audit_log_nfcfg

2020-06-27 Thread Richard Guy Briggs
Fixed an inconsistent use of GFP flags in nft_obj_notify() that used GFP_KERNEL when a GFP flag was passed in to that function. Given this allocated memory was then used in audit_log_nfcfg() it led to an audit of all other GFP allocations in net/netfilter/nf_tables_api.c and a modification of audi

Re: [PATCH v3 04/14] irqchip/davinci-aintc: Fix potential resource leaks

2020-06-27 Thread Tiezhu Yang
On 06/24/2020 09:12 PM, Markus Elfring wrote: There exists potential resource leaks in the error path, fix them. Would you like to reconsider this change description? https://lore.kernel.org/linux-mips/be3acb13-2963-ddf1-a867-7e30fd23a...@loongson.cn/ https://lkml.org/lkml/2020/6/24/498 … +++

RE: [PATCH] vfio/pci: Fix SR-IOV VF handling with MMIO blocking

2020-06-27 Thread Wang, Haiyue
> -Original Message- > From: kvm-ow...@vger.kernel.org On Behalf Of Alex > Williamson > Sent: Friday, June 26, 2020 00:57 > To: alex.william...@redhat.com > Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org; > maxime.coque...@redhat.com > Subject: [PATCH] vfio/pci: Fix SR-IOV VF han

Hallo

2020-06-27 Thread William Yun
Hallo, ich habe ein Geschäft von 24,5 Mio. USD, das ich mit Ihnen teilen kann. Wenn Sie interessiert sind? Bitte schreibe zurück und ich werde dir mehr Details geben. Grüße, William. -- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

Re: [PATCH] ntfs: Fix ntfs_test_inode and ntfs_init_locked_inode function type

2020-06-27 Thread Nathan Chancellor
Hi Luca, On Sat, Jun 27, 2020 at 09:02:30PM +0200, Luca Stefani wrote: > If the kernel is built with CFI we hit a __cfi_check_fail > while mounting a partition > > Call trace: > __cfi_check_fail+0x1c/0x24 > name_to_dev_t+0x0/0x404 > iget5_locked+0x594/0x5e8 > ntfs_fill_super+0xbfc/0x43ec > mount_

Re: [PATCH] riscv: Fixup compile error BUILD_BUG_ON failed

2020-06-27 Thread Masami Hiramatsu
On Sat, 27 Jun 2020 16:20:02 + guo...@kernel.org wrote: > From: Guo Ren > > Unfortunately, the current code couldn't be compiled, because > BUILD_BUG_ON needs a static defined value, not a dynamic > variable with a0 regs. Just use it inline as a solution. > > CC arch/riscv/kernel/pat

[PATCH v2 5/5] f2fs: show more debug info for per-temperature log

2020-06-27 Thread Chao Yu
- Add to account and show per-log dirty_seg, full_seg and valid_blocks in debugfs. - reformat printed info. TYPEsegnosecno zoneno dirty_seg full_seg valid_blk - COLD data: 1523 1523 1523 1 0399 - WARM data: 769 769

[PATCH v2 1/5] f2fs: fix to wait page writeback before update

2020-06-27 Thread Chao Yu
Filesystem including f2fs should support stable page for special device like software raid, however there is one missing path that page could be updated while it is writeback state as below, fix this. - gc_node_segment - f2fs_move_node_page - __write_node_page - set_page_writeback - do_read

Re: [f2fs-dev] [PATCH] f2fs: remove unnecessary judgments in __insert_free_nid()

2020-06-27 Thread Chao Yu
On 2020/6/26 22:39, Liu Song via Linux-f2fs-devel wrote: > From: Liu Song > > The value of state must be equal to FREE_NID, so the if > condition judgment can be removed. > > Signed-off-by: Liu Song > --- > fs/f2fs/node.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --gi

drivers/tty/serial/8250/8250_omap.c:1044:12: sparse: sparse: context imbalance in 'omap_8250_dma_handle_irq' - different lock contexts for basic block

2020-06-27 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 916a3b0fc1206f7e7ae8d00a21a3114b1dc67794 commit: 8e20fc3917117b42de316e87f073a1ca43d94c9f serial_core: Move sysrq functions from header file date: 6 months ago config: arm64-randconfig-s032-20200628 (attac

Re: [PATCH 3/6] x86/entry/64/compat: Fix Xen PV SYSENTER frame setup

2020-06-27 Thread Boris Ostrovsky
On 6/26/20 1:21 PM, Andy Lutomirski wrote: > The SYSENTER frame setup was nonsense. It worked by accident > because the normal code into which the Xen asm jumped > (entry_SYSENTER_32/compat) threw away SP without touching the stack. > entry_SYSENTER_compat was recently modified such that it relied

KASAN: use-after-free Read in macvlan_dev_get_iflink

2020-06-27 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:1590a2e1 Merge tag 'acpi-5.8-rc3' of git://git.kernel.org/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1070059b10 kernel config: https://syzkaller.appspot.com/x/.config?x=20c907630cbdbe5 dash

Re: [PATCH] scsi: sd: add runtime pm to open / release

2020-06-27 Thread Bart Van Assche
On 2020-06-26 08:44, Alan Stern wrote: > On Fri, Jun 26, 2020 at 08:07:51AM -0700, Bart Van Assche wrote: >> As far as I know runtime power management support in the sd driver is working >> fine and is being used intensively by the UFS driver. The following commit >> was >> submitted to fix a bug

Re: [f2fs-dev] [PATCH] f2fs: fix typo in comment of f2fs_do_add_link

2020-06-27 Thread Chao Yu
On 2020/6/25 20:40, Liu Song via Linux-f2fs-devel wrote: > stakable/stackable > > Signed-off-by: Liu Song Reviewed-by: Chao Yu Thanks,

Re: [f2fs-dev] [PATCH] f2fs: avoid readahead race condition

2020-06-27 Thread Chao Yu
On 2020/6/24 9:21, Jaegeuk Kim wrote: > If two readahead threads having same offset enter in readpages, every read > IOs are split and issued to the disk which giving lower bandwidth. > > This patch tries to avoid redundant readahead calls. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/data.c

Re: [PATCH 01/11] kexec_file: allow archs to handle special regions while locating memory hole

2020-06-27 Thread piliu
Hi Hari, If in [4/11], get_exclude_memory_ranges() turns out to be unnecessary ,then this patch is abundant either. As my understanding, memblock has already helped to achieved the purpose that get_exclude_memory_ranges() wants. Thanks, Pingfan On 06/27/2020 03:04 AM, Hari Bathini wrote: > Some

Re: [PATCH] kconfig: qconf: Fix find on split mode

2020-06-27 Thread Masahiro Yamada
On Thu, Jun 25, 2020 at 11:53 PM Mauro Carvalho Chehab wrote: > > The logic handling find on split mode is currently broken. > Fix it, making it work again as expected. > > Reported-by: Maxim Levitsky > Signed-off-by: Mauro Carvalho Chehab > --- Applied to linux-kbuild. Thanks. > scripts/kc

Re: [PATCH 04/11] ppc64/kexec_file: avoid stomping memory used by special regions

2020-06-27 Thread piliu
Hi Hari, After a quick through for this series, I have a few question/comment on this patch for the time being. Pls see comment inline. On 06/27/2020 03:05 AM, Hari Bathini wrote: > crashkernel region could have an overlap with special memory regions > like opal, rtas, tce-table & such. These re

[RFC PATCH 2/2] 9p: remove unused code in 9p

2020-06-27 Thread Jianyong Wu
These code has been commented out since 2007 and lied in kernel since then. it's time to remove thest no used code. Signed-off-by: Jianyong Wu --- fs/9p/vfs_inode.c | 53 --- 1 file changed, 53 deletions(-) diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_i

[RFC PATCH 1/2] 9p: retrieve fid from file when file instance exist.

2020-06-27 Thread Jianyong Wu
In the current setattr implementation in 9p, fid will always retrieved from dentry no matter file instance exist or not when setattr. There will be some info related to open file instance dropped. so it's better to retrieve fid from file instance if file instance is passed to setattr. for example:

[RFC PATCH 0/2] 9p: retrieve fid from file if it exsits

2020-06-27 Thread Jianyong Wu
in the current implementation in setattr in 9p, fid will always be retrieved from dentry, which may be against the original intension of user and lead to bug. also, remove no used code in 9p. Signed-off-by: Jianyong Wu Jianyong Wu (2): 9p: retrive fid from file when file instance exist. 9p:

RE: [PATCH] scsi: ufs: ufs-exynos: Remove an unnecessary NULL check

2020-06-27 Thread Alim Akhtar
Hi Dan, > -Original Message- > From: Dan Carpenter > On Sat, Jun 27, 2020 at 10:51:44PM +0530, Alim Akhtar wrote: > > Hi Dan > > > > > -Original Message- > > > The "head" pointer can't be NULL because it points to an address in the > > middle > > > of a ufs_hba struct. Looking at

[PATCH] kbuild: introduce ccflags-remove-y and asflags-remove-y

2020-06-27 Thread Masahiro Yamada
CFLAGS_REMOVE_.o works per object, that is, there is no convenient way to filter out flags for every object in a directory. Add ccflags-remove-y and asflags-remove-y to make it easily. Use ccflags-remove-y to clean up some Makefiles. Suggested-by: Sami Tolvanen Signed-off-by: Masahiro Yamada -

Re: [PATCH 1/2] drm: drm_fourcc: add NV20 YUV format【请注意,邮件由linux-rockchip-bounces+sandy.huang=rock-chips....@lists.infradead.org代发】

2020-06-27 Thread Huang Jiachai
Hi Jonas Karlman, 在 2020/6/26 22:19, Jonas Karlman 写道: On 2020-06-17 14:07, Huang Jiachai wrote: Hi Jonas Karlman,     Is there an another yuv 10bit format with 4:4:4 sub-simpling but has no padding?  Maybe we can call it DRM_FORMAT_NV30: { .format = DRM_FORMAT_NV30,.depth =

[PATCH] usb: gadget: function: printer: The device interface is reset and should return error code

2020-06-27 Thread qiang.zhang
From: Zqiang After the device is disconnected from the host side, the interface of the device is reset. If the userspace operates the device again, an error code should be returned. Signed-off-by: Zqiang --- drivers/usb/gadget/function/f_printer.c | 36 + 1 file changed

[iproute2-next] action police: make 'mtu' could be set independently in police action

2020-06-27 Thread Po Liu
Current police action must set 'rate' and 'burst'. 'mtu' parameter set the max frame size and could be set alone without 'rate' and 'burst' in some situation. Offloading to hardware for example, 'mtu' could limit the flow max frame size. Signed-off-by: Po Liu --- tc/m_police.c | 4 ++-- 1 file c

Re: [PATCH 5/5] f2fs: show more debug info for per-temperature log

2020-06-27 Thread Chao Yu
On 2020/6/25 6:31, Jaegeuk Kim wrote: > On 06/18, Chao Yu wrote: >> - Add to account and show per-log dirty_seg, full_seg and valid_blocks >> in debugfs. >> - reformat printed info. >> >> TYPEsegnosecno zoneno dirty_seg full_seg valid_blk >> - COLD data: 1523 1

Re: [PATCH v2 5/5] firmware: QCOM_SCM: Allow qcom_scm driver to be loadable as a permenent module

2020-06-27 Thread kernel test robot
Hi John, I love your patch! Yet something to improve: [auto build test ERROR on pinctrl/devel] [also build test ERROR on linux/master linus/master v5.8-rc2 next-20200626] [cannot apply to tip/irq/core] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting pat

[PATCH] fatfs: switch write_lock to read_lock in fat_ioctl_get_attributes

2020-06-27 Thread fengyubo
From: Yubo Feng There is no necessery to hold write_lock in fat_ioctl_get_attributes. write_lock may make an impact on concurrency of fat_ioctl_get_attributes. Signed-off-by: Yubo Feng --- fs/fat/file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/fat/file.c b/fs/

Re: [PATCH 1/5] f2fs: fix to wait page writeback before update

2020-06-27 Thread Chao Yu
On 2020/6/24 23:55, Jaegeuk Kim wrote: > On 06/22, Chao Yu wrote: >> On 2020/6/22 0:38, Jaegeuk Kim wrote: >>> On 06/20, Chao Yu wrote: On 2020/6/20 6:47, Jaegeuk Kim wrote: > On 06/19, Chao Yu wrote: >> On 2020/6/19 13:49, Jaegeuk Kim wrote: >>> On 06/19, Chao Yu wrote: H

[RESEND PATCH v2] arm: Drop CONFIG_MTD_M25P80 in various defconfig files

2020-06-27 Thread Bin Meng
From: Bin Meng Drop CONFIG_MTD_M25P80 that was removed in commit b35b9a10362d ("mtd: spi-nor: Move m25p80 code in spi-nor.c") Signed-off-by: Bin Meng --- Changes in v2: - add CONFIG_MTD_SPI_NOR=y in axm55xx_defconfig arch/arm/configs/axm55xx_defconfig | 2 +- arch/arm/configs/davinci_al

回复: [PATCH] usb: gadget: function: printer: Add gadget dev interface status judgment

2020-06-27 Thread Zhang, Qiang
发件人: linux-usb-ow...@vger.kernel.org 代表 qiang.zh...@windriver.com 发送时间: 2020年6月15日 17:46 收件人: ba...@kernel.org 抄送: gre...@linuxfoundation.org; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org 主题: [PATCH] usb: gadget: function: printer: Add gadge

<<<>>

2020-06-27 Thread Mr Peter Owen
Good Day, Hope you are doing great Today.I have a proposed business deal that will benefit both parties. This is legitimate,legal and your personality will not be compromised.I am confident that both of us can work out this transaction perfectly well to the benefit of both parties. Reach to me f

drivers/tty/serial/8250/8250_fintek.c:104:9: sparse: sparse: cast removes address space '__iomem' of expression

2020-06-27 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 42afe7d1c6ef77212250af3459e549d1a944cc8a commit: 670d0a4b10704667765f7d18f7592993d02783aa sparse: use identifiers to define address spaces date: 9 days ago config: riscv-randconfig-s031-20200628 (attached

Re: [PATCH] net: ipv4: Fix wrong type conversion from hint to rt in ip_route_use_hint()

2020-06-27 Thread David Miller
From: linmiaohe Date: Sat, 27 Jun 2020 15:47:51 +0800 > From: Miaohe Lin > > We can't cast sk_buff to rtable by (struct rtable *)hint. Use skb_rtable(). > > Fixes: 02b24941619f ("ipv4: use dst hint for ipv4 list receive") > > Signed-off-by: Miaohe Lin Please do not put empty lines between F

Re: [kbuild-all] Re: [RFC PATCH stable] RDMA/qedr: qedr_iw_load_qp() can be static

2020-06-27 Thread Chen, Rong A
On 6/19/2020 8:26 AM, Jason Gunthorpe wrote: On Sat, Jun 13, 2020 at 04:19:03AM +0800, kernel test robot wrote: Fixes: 8a69220b659c ("RDMA/qedr: Fix synchronization methods and memory leaks in qedr") Signed-off-by: kernel test robot --- qedr_iw_cm.c |2 +- 1 file changed, 1 insertion

[PATCH] arm/xen: remove the unused macro GRANT_TABLE_PHYSADDR

2020-06-27 Thread Xiaofei Tan
Fix the following sparse warning: arch/arm64/xen/../../arm/xen/enlighten.c:244: warning: macro "GRANT_TABLE_PHYSADDR" is not used [-Wunused-macros] It is an isolated macro, and should be removed when its last user was deleted in the following commit 3cf4095d7446 ("arm/xen: Use xen_xlate_map_ballo

Re: [PATCH net-next v3 0/5] hinic: add some ethtool ops support

2020-06-27 Thread luobin (L)
On 2020/6/28 8:52, David Miller wrote: > From: Luo bin > Date: Sat, 27 Jun 2020 14:52:37 +0800 > >> patch #1: support to set and get pause params with >> "ethtool -A/a" cmd >> patch #2: support to set and get irq coalesce params with >> "ethtool -C/c" cmd >> patch #3: support

Re: [PATCH 09/10] sh: don't allow non-coherent DMA for NOMMU

2020-06-27 Thread Rob Landley
On 6/26/20 3:07 AM, Christoph Hellwig wrote: > The code handling non-coherent DMA depends on being able to remap code > as non-cached. But that can't be done without an MMU, so using this > option on NOMMU builds is broken. I'm working on a nommu j-core board that's doing DMA behind the OS's back

Re: linux-next: Tree for Jun 24 [build failure on arm64]

2020-06-27 Thread Shaokun Zhang
Hi Will, My apologies for reply later because of a short holiday in China. 在 2020/6/24 18:55, Will Deacon 写道: > On Wed, Jun 24, 2020 at 05:08:56PM +0800, Shaokun Zhang wrote: >> +Will Deacon, >> >> Hi Will, >> >> There's a build failure on arm64: >> >> CALLscripts/atomic/check-atomics.sh >>

Re: [PATCH net-next v3 0/5] hinic: add some ethtool ops support

2020-06-27 Thread David Miller
From: Luo bin Date: Sat, 27 Jun 2020 14:52:37 +0800 > patch #1: support to set and get pause params with > "ethtool -A/a" cmd > patch #2: support to set and get irq coalesce params with > "ethtool -C/c" cmd > patch #3: support to do self test with "ethtool -t" cmd > patch #4:

Re: linux-next boot error: WARNING in kmem_cache_free

2020-06-27 Thread Qian Cai
> On Jun 27, 2020, at 7:10 PM, Eric Biggers wrote: > > This bug also got reported 2 days later by the kernel test robot > (lore.kernel.org/lkml/20200623090213.GW5535@shao2-debian/). > Then it was fixed by commit 437edcaafbe3, so telling syzbot: > > #syz fix: mm, slab/slub: improve error repor

[PATCH 4/4] iommu/vt-d: Add page response ops support

2020-06-27 Thread Lu Baolu
After a page request is handled, software must response the device which raised the page request with the handling result. This is done through the iommu ops.page_response if the request was reported to outside of vendor iommu driver through iommu_report_device_fault(). This adds the VT-d implement

[PATCH 0/4] iommu/vt-d: Add prq report and response support

2020-06-27 Thread Lu Baolu
Hi, This series adds page request event reporting and response support to the Intel IOMMU driver. This is necessary when the page requests must be processed by any component other than the vendor IOMMU driver. For example, when a guest page table was bound to a PASID through the iommu_ops->sva_bin

[PATCH 2/4] iommu/vt-d: Add a helper to get svm and sdev for pasid

2020-06-27 Thread Lu Baolu
There are several places in the code that need to get the pointers of svm and sdev according to a pasid and device. Add a helper to achieve this for code consolidation and readability. Signed-off-by: Lu Baolu --- drivers/iommu/intel/svm.c | 121 +- 1 file chan

[PATCH 1/4] iommu/vt-d: Refactor device_to_iommu() helper

2020-06-27 Thread Lu Baolu
It is refactored in two ways: - Make it global so that it could be used in other files. - Make bus/devfn optional so that callers could ignore these two returned values when they only want to get the coresponding iommu pointer. Signed-off-by: Lu Baolu --- drivers/iommu/intel/iommu.c | 55 +

[PATCH 3/4] iommu/vt-d: Report page request faults for guest SVA

2020-06-27 Thread Lu Baolu
A pasid might be bound to a page table from a VM guest via the iommu ops.sva_bind_gpasid. In this case, when a DMA page fault is detected on the physical IOMMU, we need to inject the page fault request into the guest. After the guest completes handling the page fault, a page response need to be sen

drivers/video/fbdev/mx3fb.c:1336:26: sparse: sparse: incorrect type in assignment (different address spaces)

2020-06-27 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4e99b32169e84b4ece5a1d74eb0b7e4ef07866b3 commit: 670d0a4b10704667765f7d18f7592993d02783aa sparse: use identifiers to define address spaces date: 9 days ago config: arm64-randconfig-s031-20200628 (attached

Re: [PATCH] fbtft-bus.c: Removing that prohibited space before ')'

2020-06-27 Thread kernel test robot
https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/B-K-Karthik/fbtft-bus-c-Removing-that-prohibited-space-before/20200627-125315 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 92cd1b5d65f5c67147c7da39a3c2ad7e6ff81027 config: x86_64

Re: [PATCH v2 11/11] ima: Support additional conditionals in the KEXEC_CMDLINE hook function

2020-06-27 Thread Lakshmi Ramasubramanian
On 6/26/20 3:39 PM, Tyler Hicks wrote: Take the properties of the kexec kernel's inode and the current task ownership into consideration when matching a KEXEC_CMDLINE operation to the rules in the IMA policy. This allows for some uniformity when writing IMA policy rules for KEXEC_KERNEL_CHECK, KE

Dringende Antwort

2020-06-27 Thread William Yun
Hallo, ich habe ein Geschäft von 24,5 Mio. USD, das ich mit Ihnen teilen kann. Wenn Sie interessiert sind? Bitte schreibe zurück und ich werde dir mehr Details geben. Grüße, William. -- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

Re: [PATCH v2 09/11] ima: Move validation of the keyrings conditional into ima_validate_rule()

2020-06-27 Thread Lakshmi Ramasubramanian
On 6/26/20 3:38 PM, Tyler Hicks wrote: Use ima_validate_rule() to ensure that the combination of a hook function and the keyrings conditional is valid and that the keyrings conditional is not specified without an explicit KEY_CHECK func conditional. This is a code cleanup and has no user-facing

  1   2   3   4   5   >