[PATCH] perf list: Fix memleak in print_sdt_events()

2020-06-19 Thread Wei Li
Valgrind check info: ==30629== Command: ./perf list sdt ==30629== ==30629== ==30629== HEAP SUMMARY: ==30629== in use at exit: 12,226 bytes in 195 blocks ==30629== total heap usage: 3,239 allocs, 3,044 frees, 3,546,759 bytes allocated ==30629== ==30629== 8,028 bytes in 115 blocks are definite

Re: RFC - kernel selftest result documentation (KTAP)

2020-06-19 Thread David Gow
On Sat, Jun 20, 2020 at 1:58 AM Frank Rowand wrote: > > On 2020-06-16 07:08, Paolo Bonzini wrote: > > On 15/06/20 21:07, Bird, Tim wrote: > Finally, > - Should a SKIP result be 'ok' (TAP13 spec) or 'not ok' (current > kselftest practice)? > See https://testanything.org/tap-

Re: ERROR: modpost: "__mulsi3" undefined!

2020-06-19 Thread Denis Efremov
e124539fcd7a47445b43fa0d kbuild: fix broken builds > because of GZIP,BZIP2,LZOP variables > date: 8 days ago > config: openrisc-randconfig-c022-20200619 (attached as .config) > compiler: or1k-linux-gcc (GCC) 9.3.0 > > If you fix the issue, kindly add following tag as appropriate

Re: [PATCH 6/6] kernel: add a kernel_wait helper

2020-06-19 Thread Christoph Hellwig
On Fri, Jun 19, 2020 at 09:17:00PM +, Luis Chamberlain wrote: > On Thu, Jun 18, 2020 at 04:46:27PM +0200, Christoph Hellwig wrote: > > --- a/kernel/exit.c > > +++ b/kernel/exit.c > > @@ -1626,6 +1626,22 @@ long kernel_wait4(pid_t upid, int __user *stat_addr, > > int options, > > return ret

Re: [RFC] Bypass filesystems for reading cached pages

2020-06-19 Thread Amir Goldstein
On Fri, Jun 19, 2020 at 6:52 PM Matthew Wilcox wrote: > > > This patch lifts the IOCB_CACHED idea expressed by Andreas to the VFS. > The advantage of this patch is that we can avoid taking any filesystem > lock, as long as the pages being accessed are in the cache (and we don't > need to readahead

Re: [PATCH 4/4] powerpc/pseries/iommu: Remove default DMA window before creating DDW

2020-06-19 Thread kernel test robot
https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Leonardo-Bras/Remove-default-DMA-window-before-creating-DDW/20200619-131022 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-randconfig-r031-20200619 (attached

nds32le-linux-ld: undefined reference to `__trace_hardirqs_off'

2020-06-19 Thread kernel test robot
cacheflush primitives date: 6 months ago config: nds32-randconfig-r035-20200619 (attached as .config) compiler: nds32le-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmo

[PATCH] drm: fix double free for gbo in drm_gem_vram_init and drm_gem_vram_create

2020-06-19 Thread Jia Yang
I got a use-after-free report when doing some fuzz test: If ttm_bo_init() fails, the "gbo" and "gbo->bo.base" will be freed by ttm_buffer_object_destroy() in ttm_bo_init(). But then drm_gem_vram_create() and drm_gem_vram_init() will free "gbo" and "gbo->bo.base" again. BUG: KMSAN: use-after-free

[PATCH] Documentation: kunit: Add naming guidelines

2020-06-19 Thread David Gow
As discussed in [1], KUnit tests have hitherto not had a particularly consistent naming scheme. This adds documentation outlining how tests and test suites should be named, including how those names should be used in Kconfig entries and filenames. [1]: https://lore.kernel.org/linux-kselftest/20200

[tip:x86/cleanups] BUILD SUCCESS eacb0c101a0bdf14de77cc9d107493e2d8d6389c

2020-06-19 Thread kernel test robot
allmodconfig powerpc allnoconfig powerpc defconfig i386 randconfig-a002-20200619 i386 randconfig-a006-20200619 i386 randconfig-a001-20200619 i386 randconfig-a005-20200619 i386

Re: [PATCH 3/3] rcu/trace: Add name of the source for gp_seq to prevent confusion

2020-06-19 Thread Joel Fernandes
On Fri, Jun 19, 2020 at 10:40:01AM -0700, Paul E. McKenney wrote: > On Thu, Jun 18, 2020 at 10:07:18PM -0400, Joel Fernandes wrote: > > On Thu, Jun 18, 2020 at 09:36:41PM -0400, Joel Fernandes (Google) wrote: > > [...] > > > @@ -2019,7 +2019,7 @@ static int __noreturn rcu_gp_kthread(void *unused) >

[tip:master] BUILD SUCCESS 46fd0c81965064aa7a4889f704591253c1724e52

2020-06-19 Thread kernel test robot
ig powerpc allmodconfig powerpc allnoconfig powerpc defconfig i386 randconfig-a011-20200619 i386 randconfig-a015-20200619 i386 randconfig-a014-20200619 i386 randconfig-a013-202

Re: [PATCH v5] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN

2020-06-19 Thread Guenter Roeck
On 6/19/20 9:35 PM, Manikandan Elumalai wrote: > The adm1278 temp attribute need it for openbmc platform . > This feature not enabled by default, so PMON_CONFIG needs to enable it. > > Signed-off-by: Manikandan Elumalai > --- > ---v5 -align commit and change log. > ---v4 -Reported-by: ke

Re: [PATCH 4/4] X86: Use KVM CR pin MSRs

2020-06-19 Thread Andy Lutomirski
On Wed, Jun 17, 2020 at 12:05 PM John Andersen wrote: > Guests using the kexec system call currently do not support > paravirtualized control register pinning. This is due to early boot > code writing known good values to control registers, these values do > not contain the protected bits. This is

Re: Linux-aspeed Digest, Vol 37, Issue 25

2020-06-19 Thread Manikandan
On Sat, Jun 20, 2020 at 04:41:13AM +1000, linux-aspeed-requ...@lists.ozlabs.org wrote: > Send Linux-aspeed mailing list submissions to > linux-asp...@lists.ozlabs.org > > To subscribe or unsubscribe via the World Wide Web, visit > https://lists.ozlabs.org/listinfo/linux-aspeed > or, v

[tip:x86/urgent] BUILD SUCCESS bb5570ad3b54e7930997aec76ab68256d5236d94

2020-06-19 Thread kernel test robot
allnoconfig powerpc defconfig i386 randconfig-a002-20200619 i386 randconfig-a006-20200619 i386 randconfig-a001-20200619 i386 randconfig-a004-20200619 i386 randconfig-a005-20200619 i386

[PATCH v5] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN

2020-06-19 Thread Manikandan Elumalai
The adm1278 temp attribute need it for openbmc platform . This feature not enabled by default, so PMON_CONFIG needs to enable it. Signed-off-by: Manikandan Elumalai --- ---v5 -align commit and change log. ---v4 -Reported-by: kernel test robot ---v3 -fix invalid signed-off. ---

Re: [PATCH] sparse: use the _Generic() version of __unqual_scalar_typeof()

2020-06-19 Thread kernel test robot
in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Luc-Van-Oostenryck/sparse-use-the-_Generic-version-of-__unqual_scalar_typeof/20200619-062703 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

ERROR: modpost: "riscv_time_val" undefined!

2020-06-19 Thread kernel test robot
Hi Christoph, It's probably a bug fix that unveils the link errors. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4333a9b0b67bb4e8bcd91bdd80da80b0ec151162 commit: c3f896dcf1e47959aca4f8e6ac9537b478949126 mm: switch the test_vmalloc module to use __vma

[RFC PATCH] display/drm/bridge: tc358775_parse_dt() can be static

2020-06-19 Thread kernel test robot
Signed-off-by: kernel test robot --- tc358775.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c index 87af3271b63521..88a45e86eae334 100644 --- a/drivers/gpu/drm/bridge/tc358775.c +++ b/drivers/gpu/drm

Re: [PATCH 4.9 000/128] 4.9.228-rc1 review

2020-06-19 Thread Daniel Díaz
Hello! On 6/19/20 9:31 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.9.228 release. There are 128 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should

Re: [PATCH 4.14 000/190] 4.14.185-rc1 review

2020-06-19 Thread Daniel Díaz
Hello! On 6/19/20 9:30 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.14.185 release. There are 190 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses shoul

Re: [PATCH 4.19 000/267] 4.19.129-rc1 review

2020-06-19 Thread Daniel Díaz
Hello! On 6/19/20 9:29 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.19.129 release. There are 267 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses shoul

Re: [PATCH 5.7 000/376] 5.7.5-rc1 review

2020-06-19 Thread Daniel Díaz
Hello! On 6/19/20 9:28 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.7.5 release. There are 376 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should b

Re: [PATCH v5 2/2] phy: bcm63xx-usbh: Add BCM63xx USBH driver

2020-06-19 Thread Florian Fainelli
On 6/19/2020 3:00 AM, Álvaro Fernández Rojas wrote: > Add BCM63xx USBH PHY driver for BMIPS. > > Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Florian Fainelli This looks great, thanks Alvaro! -- Florian

Re: [PATCH] scsi: ufs-mediatek: Make ufs_mtk_wait_link_state as static function

2020-06-19 Thread Martin K. Petersen
On Tue, 16 Jun 2020 17:51:20 +0800, Stanley Chu wrote: > Fix build warning reported by kernel test robot: > Make ufs_mtk_wait_link_state() as static functon. > > Warning: > >> drivers/scsi/ufs/ufs-mediatek.c:181:5: warning: no previous prototype > >> for 'ufs_mtk_wait_link_state' [-Wmissing-proto

[PATCH 2/2] tracing: Fix event trigger to accept redundant spaces

2020-06-19 Thread Masami Hiramatsu
Fix the event trigger to accept redundant spaces in the trigger input. For example, these return -EINVAL echo " traceon" > events/ftrace/print/trigger echo "traceon if common_pid == 0" > events/ftrace/print/trigger echo "disable_event:kmem:kmalloc " > events/ftrace/print/trigger But these are h

Re: [PATCH v8 5/5] dt-bindings: chosen: Document linux,low-memory-range for arm64 kdump

2020-06-19 Thread chenzhou
Hi James, Rob, On 2020/5/30 0:11, James Morse wrote: > Hi guys, > > On 26/05/2020 22:18, Rob Herring wrote: >> On Fri, May 22, 2020 at 11:24:11AM +0800, chenzhou wrote: >>> On 2020/5/21 21:29, Rob Herring wrote: On Thu, May 21, 2020 at 3:35 AM Chen Zhou wrote: > Add documentation for DT

[PATCH 0/2] tracing: Fix config dependency and trigger parser

2020-06-19 Thread Masami Hiramatsu
Hi, These are some fixes which I found recentry on ftrace. - Since the boot-time tracing synthetic event feature is decoupled from trigger recenty, it should use CONFIG_SYNTH_EVENT. - The parser of event trigger seems rejecting some redundant spaces. But it is hard users to find the wrong

Re: [PATCH] MIPS: Do not flush tlb when setting pmd entry

2020-06-19 Thread maobibo
On 06/17/2020 07:14 PM, Thomas Bogendoerfer wrote: > On Tue, Jun 16, 2020 at 06:34:21PM +0800, maobibo wrote: >> >> >> On 06/15/2020 06:14 PM, Thomas Bogendoerfer wrote: >>> On Wed, Jun 03, 2020 at 05:42:13PM +0800, Bibo Mao wrote: Function set_pmd_at is to set pmd entry, if tlb entry need

[PATCH 1/2] tracing/boot: Fix config dependency for synthedic event

2020-06-19 Thread Masami Hiramatsu
Since commit 726721a51838 ("tracing: Move synthetic events to a separate file") decoupled synthetic event from histogram, boot-time tracing also has to check CONFIG_SYNTH_EVENT instead of CONFIG_HIST_TRIGGERS. Fixes: 726721a51838 ("tracing: Move synthetic events to a separate file") Signed-off-by:

Re: [PATCH] serial: sh-sci: fix uninitialized variable warning

2020-06-19 Thread Kees Cook
On Thu, Jun 13, 2019 at 03:08:24PM -0300, Charles wrote: > Avoid following compiler warning on uninitialized variable > > In file included from ./include/linux/rwsem.h:16:0, > from ./include/linux/notifier.h:15, > from ./include/linux/clk.h:17, >

[PATCH v2 05/16] rtlwifi: rtl8192cu: Remove uninitialized_var() usage

2020-06-19 Thread Kees Cook
Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the compiler thinks it is uninitialized, either simply initialize the variable or make compiler changes. As a precursor to removing[2

[PATCH v2 02/16] x86/mm/numa: Remove uninitialized_var() usage

2020-06-19 Thread Kees Cook
Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the compiler thinks it is uninitialized, either simply initialize the variable or make compiler changes. As a precursor to removing[2

[PATCH v2 03/16] drbd: Remove uninitialized_var() usage

2020-06-19 Thread Kees Cook
Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the compiler thinks it is uninitialized, either simply initialize the variable or make compiler changes. As a precursor to removing[2

[PATCH v2 12/16] f2fs: Eliminate usage of uninitialized_var() macro

2020-06-19 Thread Kees Cook
From: Jason Yan This is an effort to eliminate the uninitialized_var() macro[1]. The use of this macro is the wrong solution because it forces off ANY analysis by the compiler for a given variable. It even masks "unused variable" warnings. Quoted from Linus[2]: "It's a horrible thing to use, i

[PATCH v2 07/16] clk: st: Remove uninitialized_var() usage

2020-06-19 Thread Kees Cook
Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the compiler thinks it is uninitialized, either simply initialize the variable or make compiler changes. As a precursor to removing[2

[PATCH v2 06/16] ide: Remove uninitialized_var() usage

2020-06-19 Thread Kees Cook
Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the compiler thinks it is uninitialized, either simply initialize the variable or make compiler changes. As a precursor to removing[2

[PATCH v2 08/16] spi: davinci: Remove uninitialized_var() usage

2020-06-19 Thread Kees Cook
Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the compiler thinks it is uninitialized, either simply initialize the variable or make compiler changes. As a precursor to removing[2

[PATCH v2 09/16] clk: spear: Remove uninitialized_var() usage

2020-06-19 Thread Kees Cook
Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the compiler thinks it is uninitialized, either simply initialize the variable or make compiler changes. As a precursor to removing[2

[PATCH v2 11/16] media: sur40: Remove uninitialized_var() usage

2020-06-19 Thread Kees Cook
Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the compiler thinks it is uninitialized, either simply initialize the variable or make compiler changes. As a precursor to removing[2

[PATCH v2 14/16] checkpatch: Remove awareness of uninitialized_var() macro

2020-06-19 Thread Kees Cook
Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the compiler thinks it is uninitialized, either simply initialize the variable or make compiler changes. In preparation for removing

[PATCH v2 13/16] mm/debug_vm_pgtable: Remove uninitialized_var() usage

2020-06-19 Thread Kees Cook
Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the compiler thinks it is uninitialized, either simply initialize the variable or make compiler changes. As a precursor to removing[2

[PATCH v2 15/16] treewide: Remove uninitialized_var() usage

2020-06-19 Thread Kees Cook
Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the compiler thinks it is uninitialized, either simply initialize the variable or make compiler changes. I preparation for removing[

[PATCH v2 16/16] compiler: Remove uninitialized_var() macro

2020-06-19 Thread Kees Cook
Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the compiler thinks it is uninitialized, either simply initialize the variable or make compiler changes. As recommended[2] by[3] Lin

[PATCH v2 10/16] KVM: PPC: Book3S PR: Remove uninitialized_var() usage

2020-06-19 Thread Kees Cook
Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the compiler thinks it is uninitialized, either simply initialize the variable or make compiler changes. As a precursor to removing[2

[PATCH v2 01/16] docs: deprecated.rst: Add uninitialized_var()

2020-06-19 Thread Kees Cook
Nothing should be using this macro, and the entire idea of tricking the compiler into silencing such warnings is a mistake. Signed-off-by: Kees Cook --- Documentation/process/deprecated.rst | 18 ++ 1 file changed, 18 insertions(+) diff --git a/Documentation/process/deprecated.r

[PATCH v2 00/16] Remove uninitialized_var() macro

2020-06-19 Thread Kees Cook
v2: - more special-cased fixes - add reviews v1: https://lore.kernel.org/lkml/20200603233203.1695403-1-keesc...@chromium.org Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the com

[PATCH v2 04/16] b43: Remove uninitialized_var() usage

2020-06-19 Thread Kees Cook
Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the compiler thinks it is uninitialized, either simply initialize the variable or make compiler changes. As a precursor to removing[2

Re: [PATCH 1/1] Documentation:sysfs-ufs: Add WriteBooster documentation

2020-06-19 Thread Martin K. Petersen
On Tue, 9 Jun 2020 10:17:46 -0700, Asutosh Das wrote: > Adds sysfs documentation for WriteBooster entries. Applied to 5.9/scsi-queue, thanks! [1/1] scsi: ufs: docs: Add WriteBooster documentation https://git.kernel.org/mkp/scsi/c/f51853fc0682 -- Martin K. Petersen Oracle Linux Engin

Re: [PATCH v2 0/2] scsi: remove scsi_sdb_cache

2020-06-19 Thread Martin K. Petersen
On Fri, 19 Jun 2020 17:41:15 +0200, Bean Huo wrote: > Changelog: > v1 -- v2: > 1. split patch > 2. fix more coding errors in the scsi_lib.c > > Bean Huo (2): > scsi: remove scsi_sdb_cache > scsi: fix coding style errors in scsi_lib.c > > [...] Applied to 5.9/scsi-queue, thanks! [1/

[PATCH v2] arch: arm: imx6qdl-icore: Fix OTG_ID pin and sdcard detect

2020-06-19 Thread Suniel Mahesh
From: Michael Trimarchi The current pin muxing scheme muxes GPIO_1 pad for USB_OTG_ID because of which when card is inserted, usb otg is enumerated and the card is never detected. [ 64.492645] cfg80211: failed to load regulatory.db [ 64.492657] imx-sdma 20ec000.sdma: external firmware not fo

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-19 Thread Stephen Boyd
Quoting Aisheng Dong (2020-06-17 18:58:51) > > From: Anson Huang > > > > +obj-$(CONFIG_MXC_CLK_SCU) += mxc-clk-scu.o > > > > > > Like i.MX pinctrl, I'm not sure if it's really necessary to build core > > > libraries as modules. Probably the simplest way is only building > > > platform drivers part

Re: [PATCH][next] scsi: ufs: ufs-exynos: fix spelling mistake "pa_granularty" -> "pa_granularity"

2020-06-19 Thread Martin K. Petersen
On Wed, 17 Jun 2020 09:49:11 +0100, Colin King wrote: > There is a spelling mistake in a dev_warn message. Fix it. Applied to 5.9/scsi-queue, thanks! [1/1] scsi: ufs: ufs-exynos: Fix spelling mistake "pa_granularty" -> "pa_granularity" https://git.kernel.org/mkp/scsi/c/393403efc360 -- M

Re: [PATCH V2 1/9] clk: composite: Export clk_hw_register_composite()

2020-06-19 Thread Stephen Boyd
Quoting Anson Huang (2020-06-09 00:32:05) > Export clk_hw_register_composite() to support user built as module. > > ERROR: modpost: "clk_hw_register_composite" [drivers/clk/imx/mxc-clk.ko] > undefined! Get rid of these messages below. We don't care that make modules failed. > scripts/Makefile.m

Re: [PATCH][next] net/sched: cls_u32: Use struct_size() in kzalloc()

2020-06-19 Thread David Miller
From: "Gustavo A. R. Silva" Date: Thu, 18 Jun 2020 09:53:42 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. > > This code was detected with the help of Coccinelle and, audited and > fixed manually. > > Signed-off-by:

Re: [PATCH v2 2/2] soc: mediatek: devapc: add devapc-mt6873 driver

2020-06-19 Thread Neal Liu
Hi Chun-Kuang, Thanks for your quick feedback. On Sat, 2020-06-20 at 00:25 +0800, Chun-Kuang Hu wrote: > Hi, Neal: > > Neal Liu 於 2020年6月19日 週五 下午6:01寫道: > > > > MT6873 bus frabric provides TrustZone security support and data > > protection to prevent slaves from being accessed by unexpected >

Re: [PATCH][next] taprio: Use struct_size() in kzalloc()

2020-06-19 Thread David Miller
From: "Gustavo A. R. Silva" Date: Thu, 18 Jun 2020 09:46:48 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. Also, remove unnecessary > variable _size_. > > This code was detected with the help of Coccinelle and, audit

Re: [PATCH][next] tipc: Use struct_size() helper

2020-06-19 Thread David Miller
From: "Gustavo A. R. Silva" Date: Thu, 18 Jun 2020 08:35:00 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. > > This code was detected with the help of Coccinelle and, audited and > fixed manually. > > Signed-off-by:

[PATCH net-next 1/2] indirect_call_wrapper: extend indirect wrapper to support up to 4 calls

2020-06-19 Thread Brian Vazquez
There are many places where 2 annotations are not enough. This patch adds INDIRECT_CALL_3 and INDIRECT_CALL_4 to cover such cases. Signed-off-by: Brian Vazquez --- include/linux/indirect_call_wrapper.h | 12 1 file changed, 12 insertions(+) diff --git a/include/linux/indirect_call_

[PATCH net-next 2/2] ipv6: fib6: avoid indirect calls from fib6_rule_lookup

2020-06-19 Thread Brian Vazquez
It was reported that a considerable amount of cycles were spent on the expensive indirect calls on fib6_rule_lookup. This patch introduces an inline helper called pol_route_func that uses the indirect_call_wrappers to avoid the indirect calls. This patch saves around 50ns per call. Performance wa

Re: [PATCH -next] macvlan: Fix memleak in macvlan_changelink_sources

2020-06-19 Thread David Miller
From: Zheng Bin Date: Thu, 18 Jun 2020 21:26:29 +0800 > macvlan_changelink_sources > if (addr) > ret = macvlan_hash_add_source(vlan, addr) > nla_for_each_attr(nla, head, len, rem) > ret = macvlan_hash_add_source(vlan, addr) > -->If fail, need to free previous malloc memory > > Fi

Re: [tip: sched/urgent] sched: Fix RANDSTRUCT build fail

2020-06-19 Thread Kees Cook
On Wed, Jun 10, 2020 at 10:34:16AM -, tip-bot2 for Peter Zijlstra wrote: > The following commit has been merged into the sched/urgent branch of tip: > > Commit-ID: bfb9fbe0f7e70ec5c8e51ee55b6968d4dff14456 > Gitweb: > https://git.kernel.org/tip/bfb9fbe0f7e70ec5c8e51ee55b6968d4dff144

Re: [PATCH] hwmon: (dell-smm) Add Latitude 5480 to fan control whitelist

2020-06-19 Thread Jeffrey Lin
On Fri, 19 Jun 2020 14:18:21 +0200 Pali Rohár wrote: >On Thursday 18 June 2020 21:55:29 Jeffrey Lin wrote: >> This allows manual PWM control without the BIOS fighting back on Dell >> Latitude 5480. >> >> Signed-off-by: Jeffrey Lin > >If it is working fine on your machine, you can add my: Yes

[PATCH] scsi: gdth: remove unnecessary iounmap()

2020-06-19 Thread Jing Xiangfeng
When initialization of ioremap() fails, it is not needed to do iounmap(). Remove this iounmap. Signed-off-by: Jing Xiangfeng --- drivers/scsi/gdth.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index fe03410268e6..8f077d316e8b 100644 --- a/drivers/

Re: [PATCH v2] net: macb: undo operations in case of failure

2020-06-19 Thread David Miller
From: Claudiu Beznea Date: Thu, 18 Jun 2020 11:37:40 +0300 > Undo previously done operation in case macb_phylink_connect() > fails. Since macb_reset_hw() is the 1st undo operation the > napi_exit label was renamed to reset_hw. > > Fixes: 7897b071ac3b ("net: macb: convert to phylink") > Signed-of

Re: [PATCH 7/8] scsi: storvsc: Introduce the per-storvsc_device spinlock

2020-06-19 Thread Martin K. Petersen
Andrea, >> This patch should go via the hyperv tree because a later patch is >> dependent on it. It requires and ack from SCSI maintainers though. Looks OK to me. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH net] bridge: uapi: mrp: Fix MRP_PORT_ROLE

2020-06-19 Thread David Miller
Please send networking patches for review to net...@vger.kernel.org Thank you.

Re: [PATCH net 0/3] rxrpc: Performance drop fix and other fixes

2020-06-19 Thread David Miller
From: David Howells Date: Thu, 18 Jun 2020 08:50:15 +0100 > > Here are three fixes for rxrpc: > > (1) Fix a trace symbol mapping. It doesn't seem to let you map to "". > > (2) Fix the handling of the remote receive window size when it increases > beyond the size we can support for our

[PATCH resend] net: cxgb4: fix return error value in t4_prep_fw

2020-06-19 Thread Li Heng
t4_prep_fw goto bye tag with positive return value when something bad happened and which can not free resource in adap_init0. so fix it to return negative value. Fixes: 16e47624e76b ("cxgb4: Add new scheme to update T4/T5 firmware") Reported-by: Hulk Robot Signed-off-by: Li Heng Signed-off-by: J

Re: [PATCH v2 0/6] kernfs: proposed locking and concurrency improvement

2020-06-19 Thread Rick Lindsley
On 6/19/20 3:23 PM, Tejun Heo wrote: Spending 5 minutes during boot creating sysfs objects doesn't seem like a particularly good solution and I don't know whether anyone else would experience similar issues. Again, not necessarily against improving the scalability of kernfs code but the use case

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-19 Thread Manivannan Sadhasivam
On Thu, Jun 18, 2020 at 02:25:33PM +0530, Manivannan Sadhasivam wrote: > Hi, > > On 0611, Marc Kleine-Budde wrote: > > On 6/10/20 9:44 AM, Manivannan Sadhasivam wrote: > > > Hello, > > > > > > This series adds CAN network driver support for Microchip MCP25XXFD CAN > > > Controller with MCP2517FD

Re: [PATCH v1 4/4] of: platform: Batch fwnode parsing when adding all top level devices

2020-06-19 Thread Saravana Kannan
On Fri, Jun 19, 2020 at 1:07 PM Saravana Kannan wrote: > > I think instead of deferred_probe_work_func() moving the device to the > end of the dpm_list, I think the device probing successfully is what > should move it to the end of the dpm_list. That way, the dpm_list is > actually ordered by when

Re: [PATCH v3 0/3] Add LT9611 DSI to HDMI bridge

2020-06-19 Thread John Stultz
On Wed, Jun 17, 2020 at 4:00 AM Vinod Koul wrote: > > This series adds driver and bindings for Lontium LT9611 bridge chip which > takes MIPI DSI as input and HDMI as output. > > This chip can be found in 96boards RB3 platform [1] commonly called DB845c. > > [1]: https://www.96boards.org/product/rb

Re: [PATCH V7 3/4] clk: qcom: Add DT bindings for ipq6018 apss clock controller

2020-06-19 Thread Stephen Boyd
Quoting Sivaprakash Murugesan (2020-06-06 03:55:06) > Add dt-binding for ipq6018 apss clock controller > > Signed-off-by: Sivaprakash Murugesan > --- Please pick up Rob's tag when resending this.

KINDEST MESSAGE.

2020-06-19 Thread Tofil Bama
Dear, My name is Mr Alif Tomar, I am the Bill and Exchange (assistant) Manager of Bank of Africa Ouagadougou, Burkina Faso. In my department I discovered an abandoned sum of eighteen million three hundred thousand United State of American dollars (18.3MILLION USA DOLLARS) in an account that belong

[PATCH v1 1/2] spi: spi-geni-qcom: Simplify setup_fifo_xfer()

2020-06-19 Thread Stephen Boyd
The definition of SPI_FULL_DUPLEX (3) is really SPI_TX_ONLY (1) ORed with SPI_RX_ONLY (2). Let's drop the define and simplify the code here a bit by collapsing the setting of 'm_cmd' into conditions that are the same. This is a non-functional change, just cleanup to consolidate code. Reviewed-by:

[PATCH v1 0/2] Some small spi geni cleanups

2020-06-19 Thread Stephen Boyd
To follow onto Doug's latest spi geni series[1] this simplifies and reduces the code a little more. [1] https://lore.kernel.org/r/20200618150626.237027-1-diand...@chromium.org Stephen Boyd (2): spi: spi-geni-qcom: Simplify setup_fifo_xfer() spi: spi-geni-qcom: Don't set {tx,rx}_rem_bytes unne

[PATCH v1 2/2] spi: spi-geni-qcom: Don't set {tx,rx}_rem_bytes unnecessarily

2020-06-19 Thread Stephen Boyd
We only need to test for these counters being non-zero when we see the end of a transfer. If we're doing a CS change then they will already be zero. This implies that we don't need to set these to 0 if we're cancelling an in flight transfer too, because we only care to test these counters when the

Re: [PATCH 6/5] spi: spi-geni-qcom: Simplify setup_fifo_xfer()

2020-06-19 Thread Stephen Boyd
Quoting Doug Anderson (2020-06-18 17:40:59) > On Thu, Jun 18, 2020 at 4:40 PM Stephen Boyd wrote: > > @@ -373,12 +366,14 @@ static void setup_fifo_xfer(struct spi_transfer *xfer, > > len &= TRANS_LEN_MSK; > > > > mas->cur_xfer = xfer; > > - if (m_cmd & SPI_TX_ONLY) { > > +

Re: [PATCH] scsi: target: tcmu: Call flush_dcache_page() with proper page struct

2020-06-19 Thread kernel test robot
Hi Henry, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on scsi/for-next v5.8-rc1 next-20200618] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use a

[PATCH V2] drivers/block: Use kobj_to_dev() API

2020-06-19 Thread Wang Qing
Use kobj_to_dev() API instead of container_of(). Signed-off-by: Wang Qing --- drivers/block/virtio_blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 9d21bf0..c808405 --- a/drivers/block/virtio_blk.c +++ b/drive

[PATCH] platform/chrome: cros_ec_typec: Make configure_mux static

2020-06-19 Thread Prashant Malani
Since cros_typec_configure_mux() is only used in cros-ec-typec, it should be marked static. Fixes: 7e7def15fa4b ("platform/chrome: cros_ec_typec: Add USB mux control") Reported-by: kernel test robot Signed-off-by: Prashant Malani --- drivers/platform/chrome/cros_ec_typec.c | 6 +++--- 1 file ch

RE: [PATCH v10 00/10] exynos-ufs: Add support for UFS HCI

2020-06-19 Thread Alim Akhtar
Hi Kishon, > -Original Message- > From: Alim Akhtar > Sent: 11 June 2020 20:49 > To: 'Kishon Vijay Abraham I' ; 'Martin K. Petersen' > > >> > > >> Applied [1,2,3,4,5,9] to 5.9/scsi-queue. The series won't show up > > >> in my > > > public > > >> tree until shortly after -rc1 is released.

Re: [PATCH] i2c: mediatek: Add to support continuous mode

2020-06-19 Thread Qii Wang
On Fri, 2020-06-19 at 16:06 +0800, Qiangming Xia wrote: > From: "qiangming.xia" > > Mediatek i2c controller support for continuous mode, > it allow to transfer once multiple writing messages of equal length. > For example, a slave need write a serial of non-continuous > offset range in ch

Re: [PATCH v2 3/3] mm/shuffle: remove dynamic reconfiguration

2020-06-19 Thread Dan Williams
On Fri, Jun 19, 2020 at 5:59 AM David Hildenbrand wrote: > > Commit e900a918b098 ("mm: shuffle initial free memory to improve > memory-side-cache utilization") promised "autodetection of a > memory-side-cache (to be added in a follow-on patch)" over a year ago. > > The original series included pat

Re: [PATCH 06/26] mm/csky: Use general page fault accounting

2020-06-19 Thread Guo Ren
On Sat, Jun 20, 2020 at 12:05 AM Peter Xu wrote: > > Use the general page fault accounting by passing regs into handle_mm_fault(). > It naturally solve the issue of multiple page fault accounting when page fault > retry happened. > > CC: Guo Ren > CC: linux-c...@vger.kernel.org > Signed-off-by: P

Re: [PATCH v2 2/3] mm/memory_hotplug: document why shuffle_zone() is relevant

2020-06-19 Thread Dan Williams
On Fri, Jun 19, 2020 at 6:00 AM David Hildenbrand wrote: > > It's not completely obvious why we have to shuffle the complete zone, as > some sort of shuffling is already performed when onlining pages via > __free_one_page(), placing MAX_ORDER-1 pages either to the head or the tail > of the freelis

Re: kprobe: __blkdev_put probe is missed

2020-06-19 Thread Masami Hiramatsu
Hi Ming, On Sat, 20 Jun 2020 07:28:20 +0800 Ming Lei wrote: > > > > Ah, after all it is as expected. With your kconfig, the kernel is > > very agressively optimized. > > > > $ objdump -dS vmlinux | less > > ... > > 81256dc3 <__blkdev_put>: > > { > > 81256dc3: e8 98 85 df

Re: [PATCH v2 1/3] mm/shuffle: don't move pages between zones and don't read garbage memmaps

2020-06-19 Thread Williams, Dan J
On Fri, 2020-06-19 at 14:59 +0200, David Hildenbrand wrote: > Especially with memory hotplug, we can have offline sections (with a > garbage memmap) and overlapping zones. We have to make sure to only > touch initialized memmaps (online sections managed by the buddy) and > that > the zone matches,

Re: [PATCH v6 09/19] mm: memcg/slab: charge individual slab objects instead of pages

2020-06-19 Thread Roman Gushchin
On Fri, Jun 19, 2020 at 05:54:24PM -0700, Shakeel Butt wrote: > On Mon, Jun 8, 2020 at 4:07 PM Roman Gushchin wrote: > > > > Switch to per-object accounting of non-root slab objects. > > > > Charging is performed using obj_cgroup API in the pre_alloc hook. > > Obj_cgroup is charged with the size o

drivers/gpu/drm/drm_gem_shmem_helper.c:540:22: error: incompatible types when assigning to type 'pgprot_t' {aka 'struct '} from type 'int'

2020-06-19 Thread kernel test robot
date: 8 months ago config: m68k-randconfig-r016-20200619 (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross

[GIT PULL] tracing: Tracing fixes for 5.8-rc1

2020-06-19 Thread Steven Rostedt
Linus, A few fixes and small cleanups for tracing: - Have recordmcount work with > 64K sections (to support LTO) - kprobe RCU fixes - Correct a kprobe critical section with missing mutex - Remove redundant arch_disarm_kprobe() call - Fix lockup when kretprobe triggers within kprobe_flush_t

Re: [RFC PATCH 0/1] dm-crypt excessive overhead

2020-06-19 Thread Herbert Xu
On Fri, Jun 19, 2020 at 02:39:39PM -0400, Mikulas Patocka wrote: > > I'm looking at this and I'd like to know why does the crypto API fail in > hard-irq context and why does it work in tasklet context. What's the exact > reason behind this? You're not supposed to do any real work in IRQ handlers

Re: [PATCH v6 08/19] mm: memcg/slab: save obj_cgroup for non-root slab objects

2020-06-19 Thread Roman Gushchin
On Fri, Jun 19, 2020 at 05:16:02PM -0700, Shakeel Butt wrote: > On Mon, Jun 8, 2020 at 4:07 PM Roman Gushchin wrote: > > > > Store the obj_cgroup pointer in the corresponding place of > > page->obj_cgroups for each allocated non-root slab object. > > Make sure that each allocated object holds a re

Re: [PATCH v6 11/19] mm: memcg/slab: move memcg_kmem_bypass() to memcontrol.h

2020-06-19 Thread Shakeel Butt
On Mon, Jun 8, 2020 at 4:07 PM Roman Gushchin wrote: > > To make the memcg_kmem_bypass() function available outside of > the memcontrol.c, let's move it to memcontrol.h. The function > is small and nicely fits into static inline sort of functions. > > It will be used from the slab code. > > Signed

RE: [PATCH AUTOSEL 5.4 199/266] misc: xilinx-sdfec: improve get_user_pages_fast() error handling

2020-06-19 Thread Dragan Cvetic
Hi Sasha, Thank you for the patch. > -Original Message- > From: Sasha Levin > Sent: Thursday 18 June 2020 02:15 > To: linux-kernel@vger.kernel.org; sta...@vger.kernel.org > Cc: John Hubbard ; Derek Kiernan ; > Dragan Cvetic ; Arnd > Bergmann ; Greg Kroah-Hartman ; > Michal Simek ; lin

[PATCH][next] sparc64: viohs: Use struct_size() helper

2020-06-19 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. Also, remove unnecessary variable _len_. This code was detected with the help of Coccinelle and, audited and fixed manually. Addresses-KSPP-ID: https://github.com/KSPP/linux/issues

Re: [PATCH V7 1/4] dt-bindings: clock: add ipq6018 a53 pll compatible

2020-06-19 Thread Sivaprakash Murugesan
On 6/20/2020 6:06 AM, Stephen Boyd wrote: Quoting Sivaprakash Murugesan (2020-06-06 03:55:04) cpus on ipq6018 are clocked by a53 pll, add device compatible for a53 pll found on ipq6018 devices. Signed-off-by: Sivaprakash Murugesan --- [V7] * Addressed minor review comment from Rob .../de

Re: kprobe: __blkdev_put probe is missed

2020-06-19 Thread Steven Rostedt
On Sat, 20 Jun 2020 07:28:20 +0800 Ming Lei wrote: > Thanks for your investigation. > > Some trace tools can just trace on function entry, such as bcc, and some > user script always trace on function entry. > > I guess the issue should belong to kprobe implementation: The issue is that kprobes

  1   2   3   4   5   6   7   8   9   10   >