On 9/18/2018 11:41 AM, Jiri Slaby wrote:
On 09/17/2018, 11:33 PM, Matthias Kaehlcke wrote:
sysrq_handle_crash() dereferences a NULL pointer on purpose to force
an exception, the local variable 'killer' is assigned to NULL and
dereferenced later. Clang detects the NULL pointer dereference at comp
From: Nadav Amit
Now that we have a single point, unify the tracing and collecting the
statistics for commands and their failure. While it might somewhat
reduce the control over debugging, it cleans the code a lot.
Reviewed-by: Xavier Deguillard
Signed-off-by: Nadav Amit
---
drivers/misc/vmw_
This patch-set adds the following enhancements to the VMware balloon
driver:
1. Balloon compaction support.
2. Report the number of inflated/deflated ballooned pages through vmstat.
3. Memory shrinker to avoid balloon over-inflation (and OOM).
4. Support VMs with memory limit that is greater than
By inlining the hypercall interface, we can unify several operations
into one central point in the code:
- Updating the target.
- Updating when a reset is needed.
- Update statistics (which will be done later in the patch-set).
- Print debug-messages (although they cannot be enabled as selectively
Splitting the allocations between sleeping and non-sleeping made some
sort of sense as long as rate-limiting was enabled. Now that it is
removed, we need to decide - either we want sleeping allocations or not.
Since no other Linux balloon driver (hv, Xen, virtio) uses sleeping
allocations, use the
In preparation for supporting compaction and OOM notification, this
patch reworks the inflate/deflate loops. The main idea is to separate
the allocation, communication with the hypervisor, and the handling of
errors from each other. Doing will allow us to perform concurrent
inflation and deflation,
The lock and unlock code paths are very similar, so avoid the duplicate
code by merging them together.
Reviewed-by: Xavier Deguillard
Signed-off-by: Nadav Amit
---
drivers/misc/vmw_balloon.c | 62 +-
1 file changed, 21 insertions(+), 41 deletions(-)
diff --g
Introduce interfaces for ballooning enqueueing and dequeueing of a list
of pages. These interfaces reduce the overhead of storing and restoring
IRQs by batching the operations. In addition they do not panic if the
list of pages is empty.
Cc: "Michael S. Tsirkin"
Cc: Jason Wang
Cc: linux...@kvack
From: Nadav Amit
The use of accessors for batch entries complicates the code and makes it
less readable. Remove it an instead use bit-fields.
Reviewed-by: Xavier Deguillard
Signed-off-by: Nadav Amit
---
drivers/misc/vmw_balloon.c | 81 ++
1 file changed, 30
Adding a shrinker to the VMware balloon to prevent out-of-memory events.
We reuse the deflate logic for this matter. Deadlocks should not happen,
as no memory allocation is performed while the locks of the
communication (batch/page) and page-list are taken. In the unlikely
event in which the config
The required change in the balloon size is currently computed in
vmballoon_work(), vmballoon_inflate() and vmballoon_deflate(). Refactor
it to simplify the next patches.
Reviewed-by: Xavier Deguillard
Signed-off-by: Nadav Amit
---
drivers/misc/vmw_balloon.c | 74 ++--
The current abstractions for batch vs single operations seem suboptimal
and complicate the implementation of additional features (OOM,
compaction).
The immediate problem of the current abstractions is that they cause
differences in how operations are handled when batching is on or off.
For example
To allow the balloon statistics to be updated concurrently, we change
the statistics to be held per core and aggregate it when needed.
To avoid the memory overhead of keeping the statistics per core, and
since it is likely not used by most users, we start updating the
statistics only after the fir
As we want to leave as little as possible on the global balloon
structure, to avoid possible future races, we want to get rid sysinfo.
We can actually get the total_ram directly, and simplify the logic of
vmballoon_send_get_target() a little.
While we are doing that, let's return int and avoid mis
Currently, when the hypervisor rejects a page during lock operation, the
VM treats pages differently according to the error-code: in certain
cases the page is immediately freed, and in others it is put on a
rejection list and only freed later.
The behavior does not make too much sense. If the page
The hypervisor might refuse to inflate pages. While the balloon driver
handles this scenario correctly, a refusal to inflate a 2MB pages might
cause the same page to be allocated again later just for its inflation
to be refused again. This wastes energy and time.
To avoid this situation we split t
Add support for compaction for VMware balloon. Since unlike the virtio
balloon, we also support huge-pages, which are not going through
compaction, we keep these pages in vmballoon and handle this list
separately. We use the same lock to protect both lists, as this lock is
not supposed to be conten
Change all the remaining return values to int to avoid mistakes. Reduce
indentation when possible.
Reviewed-by: Xavier Deguillard
Signed-off-by: Nadav Amit
---
drivers/misc/vmw_balloon.c | 39 ++
1 file changed, 23 insertions(+), 16 deletions(-)
diff --git a
It is useful to expose how many times the balloon resets. If it happens
more than very rarely - this is an indication for a problem.
Reviewed-by: Xavier Deguillard
Signed-off-by: Nadav Amit
---
drivers/misc/vmw_balloon.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a
From: Xavier Deguillard
Currently, the balloon driver would fail to run if memory is greater
than 16TB of vRAM. Previous patches have already converted the balloon
target and size to 64-bit, so all that is left to do add is to avoid
asserting memory is smaller than 16TB if the hypervisor supports
* Vincent Guittot wrote:
> > I.e. this needs to be sorted out and done properly, the concerns you voice
> > are simply a side
> > effect of this having been done badly.
>
> Ok. I'm going to prepare a patchset to fix all these points.
Thanks!
Ingo
Rong Chen wrote:
> Attach please find the new kconfig, you could try again.
I tried that again - it still comes to the login prompt and doesn't do
anything that I can tell.
David
Hi Lubomir,
I love your patch! Yet something to improve:
[auto build test ERROR on tip/irq/core]
[also build test ERROR on v4.19-rc4 next-20180913]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commit
The i.MX 6ULZ processor is a high-performance, ultra
cost-efficient consumer Linux processor featuring an
advanced implementation of a single Arm® Cortex®-A7 core,
which operates at speeds up to 900 MHz.
This patch adds basic MSL support for i.MX6ULZ, the
i.MX6ULZ has same soc_id as i.MX6ULL, and
i.MX6ULZ has same CCM IP as i.MX6ULL, and it reuses
i.MX6UL clock driver, this patch adds support for it.
Signed-off-by: Anson Huang
---
drivers/clk/imx/clk-imx6ul.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c
i.MX6ULZ is new SoC of i.MX6 family, compared to i.MX6ULL,
it removes below modules:
- UART5/UART6/UART7/UART8;
- PWM5/PWM6/PWM7/PWM8;
- eCSPI3/eCSPI4;
- CAN1/CAN2;
- FEC1/FEC2;
- I2C3/I2C4;
- EPIT2;
- LCDIF;
- GPT2;
- ADC1;
- TSC;
This patch adds support for i.MX6ULZ and i.MX6ULZ 14x14 EVK
board
This patch adds compatible for i.MX6ULZ 14x14 EVK board.
Signed-off-by: Anson Huang
---
Documentation/devicetree/bindings/arm/fsl.txt | 4
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/fsl.txt
b/Documentation/devicetree/bindings/arm/fsl.txt
index 968f2
This patch set adds i.MX6ULZ SoC support, i.MX6ULZ is a new SoC of
i.MX6 family, compared to i.MX6ULL, it removes below modules:
- UART5/UART6/UART7/UART8;
- PWM5/PWM6/PWM7/PWM8;
- eCSPI3/eCSPI4;
- CAN1/CAN2;
- FEC1/FEC2;
- I2C3/I2C4;
- EPIT2;
- LCDIF;
- GPT2;
On 9/18/2018 4:34 AM, Steven Rostedt wrote:
On Sun, 16 Sep 2018 12:37:52 +0530
Sai Prakash Ranjan wrote:
Hi,
Anyone here?
You also just caught me from coming back from a trip. I'm looking at
your patches now.
-- Steve
Thanks Steve, I just thought you guys might have missed the patch.
-
On 09/17/2018, 11:33 PM, Matthias Kaehlcke wrote:
> sysrq_handle_crash() dereferences a NULL pointer on purpose to force
> an exception, the local variable 'killer' is assigned to NULL and
> dereferenced later. Clang detects the NULL pointer dereference at compile
> time and emits a BRK instruction
On 9/18/2018 3:03 AM, Matthias Kaehlcke wrote:
sysrq_handle_crash() dereferences a NULL pointer on purpose to force
an exception, the local variable 'killer' is assigned to NULL and
dereferenced later. Clang detects the NULL pointer dereference at compile
time and emits a BRK instruction (on arm6
FYI, we noticed the following commit (built with gcc-4.9):
commit: 68ad4275838d223a06a3211fb2f27c8b6f44cd24 ("x86/mm/cpa: Add sanity check
for existing mappings")
https://github.com/0day-ci/linux
UPDATE-20180916-004446/Thomas-Gleixner/x86-mm-cpa-Improve-large-page-preservation-handling/20180915-
These values are inclusive, so a range of 1 requires min == max.
Signed-off-by: Peter Hutterer
---
drivers/input/misc/uinput.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c
index 96a887f33698..eb14ddf69346 100644
---
Fix the following compile warning:
drivers/soc/qcom/cmd-db.c:194:38: warning: ent.addr may be used uninitialized
in this function [-Wmaybe-uninitialized]
return ret < 0 ? 0 : le32_to_cpu(ent.addr);
drivers/soc/qcom/cmd-db.c:247:38: warning: ent.len may be used uninitialized
in this functi
Lfence is preferred than general retpoline on AMD, add this option
in C / inline asm just as the ASM code does.
For x86_64, it still help to have minimal retpoline for kernel even
if gcc doesn't support it, change the inline asm for x86 so that it
could also be used by x86_64.
Add ANNOTATE_NOSPEC
Hi all,
Changes since 20180913:
New tree: csky
Dropped trees: xarray, ida (temporarily)
I still disabled building some samples in the vfs tree.
The net-next tree gained conflicts against the net and jc_docs trees.
The drm-misc tree gained a conflict against the drm tree.
The staging tree gai
On Tue, Sep 11, 2018 at 11:43 AM Lee Jones wrote:
> On Tue, 11 Sep 2018, Nicolas Ferre wrote:
> > Actually it is due to the missing of as Stephen
> > suggested. It is due to the patch ac3167257b9f ("headers: separate
> > linux/mod_devicetable.h from linux/platform_device.h") merged in v4.19-rc1
On Mon, Sep 17, 2018 at 9:18 PM Dmitry Torokhov
wrote:
>
> The generic device properties APIs are very helpful as they allow abstracting
> away details of the platform (whether it is ACPI, device tree, or legacy board
> file), so that individual driver does not need separate code paths to support
Hi Krzysztof and Sebastian,
please forgive me for the delay in working with this patch.
I've been having some personal issues these months, but leaving the
excuses I still intend to send a v2 for this.
Thanks Krzysztof for review and tips I'll work on it.
Best Regards,
Matheus Castello
On 09
Hi Kees,
2018-09-16 3:47 GMT+09:00 Kees Cook :
> On Fri, Aug 3, 2018 at 9:47 PM, Masahiro Yamada
> wrote:
>> Randy Dunlap reports UML occasionally fails to build with -j and
>> O= options.
>
> With v4.19-rc2 I'm still seeing a failure (for any parallelism) under ARCH=um
>
> $ make -j8 ARCH=um O=
Some samples require headers installation, so commit 3fca1700c4c3
("kbuild: make samples really depend on headers_install") added
such dependency in the top Makefile. However, UML fails to build
with CONFIG_SAMPLES=y because UML does not support headers_install.
Fixes: 3fca1700c4c3 ("kbuild: make
On 09/18/18 at 10:48am, Lianbo Jiang wrote:
> e820 reserved ranges is useful in kdump kernel, we have added this in
> kexec-tools code.
>
> One reason is PCI mmconf (extended mode) requires reserved region
> otherwise it falls back to legacy mode.
>
> When AMD SME kdump support, it needs to map d
On 13.09.2018 16:59, Miguel Ojeda wrote:
> The naked attribute is supported by at least gcc >= 4.6 (for ARM,
> which is the only current user), gcc >= 8 (for x86), clang >= 3.1
> and icc >= 13. See https://godbolt.org/z/350Dyc
>
> Therefore, move it out of compiler-gcc.h so that the definition
> i
This patch is to use range list flush function in the
mmu_sync_children(), kvm_mmu_commit_zap_page() and
FNAME(sync_page)().
Signed-off-by: Lan Tianyu
---
arch/x86/kvm/mmu.c | 26 +++---
arch/x86/kvm/paging_tmpl.h | 5 -
2 files changed, 27 insertions(+), 4 delet
PV EPT tlb flush function will accept a list of flush ranges and
use struct kvm_mmu_page as the list entry.
Signed-off-by: Lan Tianyu
---
arch/x86/include/asm/kvm_host.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
index a6
If ept table pointers are mismatched, flushing tlb for each vcpus via
hv flush interface still helps to reduce vmexits which are triggered
by IPI and INEPT emulation.
Signed-off-by: Lan Tianyu
---
arch/x86/kvm/vmx.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --gi
It's necessary to check whether mmu page is last or large page when add
mmu page into flush list. "spte" is needed for such check and so add
spte point in the struct kvm_mmu_page.
Signed-off-by: Lan Tianyu
---
arch/x86/include/asm/kvm_host.h | 1 +
arch/x86/kvm/mmu.c | 5 +
arch
This patch is to register tlb_remote_flush_with_range callback with
hv tlb range flush interface.
Signed-off-by: Lan Tianyu
---
Change since v1:
Pass flush range with new hyper-v tlb flush struct rather
than KVM tlb flush struct.
---
arch/x86/kvm/vmx.c | 58 +++
This patch is to trace log in the hyperv_nested_flush_
guest_mapping_range().
Signed-off-by: Lan Tianyu
---
arch/x86/hyperv/nested.c| 1 +
arch/x86/include/asm/trace/hyperv.h | 14 ++
2 files changed, 15 insertions(+)
diff --git a/arch/x86/hyperv/nested.c b/arch/x86/hyp
This patch is to flush tlb directly in the kvm_handle_hva_range()
when range flush is available.
Signed-off-by: Lan Tianyu
---
arch/x86/kvm/mmu.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index 822e170881a4..dfd2a0710417 100644
--- a/arch/
Quoting Jordan Crouse (2018-09-17 14:14:14)
> On Mon, Sep 17, 2018 at 01:40:07PM -0700, Stephen Boyd wrote:
> > + vals = cmd_db_read_aux_data(id, &len);
> > /*
> >* The data comes back as an array of unsigned shorts so adjust the
> >* count accordingly
> >*/
> > -
Hyper-V provides HvFlushGuestAddressList() hypercall to flush EPT tlb
with specified ranges. This patch is to add the hypercall support.
Signed-off-by: Lan Tianyu
---
Change since v1:
Add hyperv tlb flush struct to avoid use kvm tlb flush struct
in the hyperv file.
---
arch/x86/hyperv/nes
kvm_mmu_zap_collapsible_spte() returns flush request to the
slot_handle_leaf() and the latter does flush on demand. When
range flush is available, make kvm_mmu_zap_collapsible_spte()
to flush tlb with range directly to avoid returning range back
to slot_handle_leaf().
Signed-off-by: Lan Tianyu
--
Add flush range call back in the kvm_x86_ops and platform can use it
to register its associated function. The parameter "kvm_tlb_range"
accepts a single range and flush list which contains a list of ranges.
Signed-off-by: Lan Tianyu
---
Change since v1:
Change "end_gfn" to "pages" to aviod
This patch is to add wrapper functions for tlb_remote_flush_with_range
callback.
Signed-off-by: Lan Tianyu
---
arch/x86/kvm/mmu.c | 48
1 file changed, 48 insertions(+)
diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index c67f09086378..ac3b
Originally, flush tlb is done by slot_handle_level_range(). This patch
is to flush tlb directly in the kvm_zap_gfn_range() when range
flush is available.
Signed-off-by: Lan Tianyu
---
arch/x86/kvm/mmu.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/arch/x8
For nested memory virtualization, Hyper-v doesn't set write-protect
L1 hypervisor EPT page directory and page table node to track changes
while it relies on guest to tell it changes via HvFlushGuestAddressLlist
hypercall. HvFlushGuestAddressLlist hypercall provides a way to flush
EPT page table
This patch is to replace kvm_flush_remote_tlbs() with kvm_flush_
remote_tlbs_with_address() in some functions without logic change.
Signed-off-by: Lan Tianyu
---
arch/x86/kvm/mmu.c | 33 ++---
arch/x86/kvm/paging_tmpl.h | 3 ++-
2 files changed, 24 insertions
On 13.09.2018 16:59, Miguel Ojeda wrote:
> Commit 9c695203a7dd ("compiler-gcc.h: gcc-4.5 needs noclone
> and noinline on __naked functions") added noinline and noclone
> as a workaround for a gcc 4.5 bug, which was resolved in 4.6.0.
>
> Since now the minimum gcc supported version is 4.6,
> we can
Hi all,
Today's linux-next merge of the staging tree got a conflict in:
MAINTAINERS
between commit:
5ae2f1f30197 ("MAINTAINERS: move former ATMEL entries to proper MICROCHIP
locatioat91n")
from the at91 tree and commit:
010de20412fc ("MAINTAINERS: Add entry for mcp3911 ADC driver")
fr
On 17.09.2018 20:06, Masahiro Yamada wrote:
> Hi Stefan,
>
> 2018-09-18 11:31 GMT+09:00 Stefan Agner :
>> When using a GCC cross toolchain which is not in a compiled in
>> Clang search path, Clang reverts to the system assembler and
>> linker. This leads to assembler or linker errors, depending on
Hi Stefan,
2018-09-18 11:31 GMT+09:00 Stefan Agner :
> When using a GCC cross toolchain which is not in a compiled in
> Clang search path, Clang reverts to the system assembler and
> linker. This leads to assembler or linker errors, depending on
> which tool is first used for a given architecture.
On Mon, Sep 17, 2018 11:51 PM Amir Goldstein wrote:
>On Mon, Sep 17, 2018 at 6:05 PM nixiaoming wrote:
>>
>> In order to identify which thread triggered the event in the
>> multi-threaded program, add the FAN_EVENT_INFO_TID tag in fanotify_init
>
>According to code and man page this is a 'flag' n
> > From: Like Xu
> >
> > This patch adds support to KVM to save/restore the lbr stack on vCPU
> > context switching.
> >
> > When the guest sets the ACTIVE bit of MSR_KVM_PV_LBR_CTRL, a perf event
> > is created on the host for the related vCPU. This perf event ensures the
> > LBR stack to be s
On Tue, Sep 18, 2018 at 10:07:34AM +0800, YueHaibing wrote:
> Remove duplicated include xfs_alloc.h
>
> Signed-off-by: YueHaibing
Looks ok,
Reviewed-by: Darrick J. Wong
--D
> ---
> fs/xfs/scrub/alloc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/scrub/alloc.c b/fs/xfs/scr
E820 reserved ranges is useful in kdump kernel, we have added this in
kexec-tools code.
One reason is PCI mmconf (extended mode) requires reserved region otherwise
it falls back to legacy mode.
Furthermore, when AMD SME kdump support, it needs to map dmi table area as
unencrypted. For normal boot
kdump use walk_iomem_res_desc to iterate io resources then add matched
desc to e820 table for 2nd kernel.
But IORES_DESC_NONE resource type includes several different e820 types,
we need add exact e820 type to 2nd kernel e820 table thus need an extra
checking in memmap_entry_callback to match the
e820 reserved ranges is useful in kdump kernel, we have added this in
kexec-tools code.
One reason is PCI mmconf (extended mode) requires reserved region
otherwise it falls back to legacy mode.
When AMD SME kdump support, it needs to map dmi table area as unencrypted.
For normal boot these ranges
When using a GCC cross toolchain which is not in a compiled in
Clang search path, Clang reverts to the system assembler and
linker. This leads to assembler or linker errors, depending on
which tool is first used for a given architecture.
It seems that Clang is not searching $PATH for a matching
as
On 9/17/18 7:20 AM, Christoph Hellwig wrote:
On Fri, Sep 14, 2018 at 02:54:54PM -0700, Atish Patra wrote:
From: Palmer Dabbelt
Someone must have read the device tree specification incorrectly,
because we were putting timebase-frequency in the wrong place. This
corrects the issue, moving it fr
On 9/17/18 7:23 AM, Christoph Hellwig wrote:
On Fri, Sep 14, 2018 at 02:54:55PM -0700, Atish Patra wrote:
Follow the updated DT specs and read the timebase-frequency
from the boot cpu. Keep the old DT reading as well for backward
compatibility. This patch is rework of old patch from Palmer.
Sig
Remove duplicated include linux/swap.h
Signed-off-by: YueHaibing
---
fs/iomap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/iomap.c b/fs/iomap.c
index 9fb78e5..a5613e5 100644
--- a/fs/iomap.c
+++ b/fs/iomap.c
@@ -30,7 +30,6 @@
#include
#include
#include
-#include
#include "in
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8a104f8b5867c682d994ffa7a74093c54469c11f
ahh, guys? ah... i'm going to try *really* hard to follow the advice
that's listed here ok?
http://www.pndc.com/documents/_PDF%20Text-PNDC%20WORKS.pdf it's a
little challenging
Remove duplicated include xfs_alloc.h
Signed-off-by: YueHaibing
---
fs/xfs/scrub/alloc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/xfs/scrub/alloc.c b/fs/xfs/scrub/alloc.c
index 036b5c7..376bcb5 100644
--- a/fs/xfs/scrub/alloc.c
+++ b/fs/xfs/scrub/alloc.c
@@ -17,7 +17,6 @@
#include
On Sun, Sep 16, 2018 at 10:45:26AM +0100, Jonathan Cameron wrote:
> On Sat, 15 Sep 2018 13:42:14 -0400
> ryang wrote:
>
> > Add device tree support for ROHM BH1750 series ambient light sensors.
> >
> > Signed-off-by: ryang
> Just to check, how is it picking up on the enum value which is provide
David Miller wrote on Mon, Sep 17, 2018:
> From: Dominique Martinet
> Date: Wed, 12 Sep 2018 07:36:42 +0200
>
> > Dominique Martinet wrote on Tue, Sep 11, 2018:
> >> Hmm, while trying to benchmark this, I sometimes got hangs in
> >> kcm_wait_data() for the last packet somehow?
> >> The sender pro
Hi all,
After merging the device-mapper tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
drivers/md/dm-mpath.c: In function 'parse_path':
drivers/md/dm-mpath.c:891:24: warning: assignment discards 'const' qualifier
from pointer target type [-Wdiscarded-qualifiers]
On 2018-09-17 23:09, Michael Woods wrote:
The Code of Conflict was perfectly fine. Whomever convinced you to add
the Code of Conduct was convincing you to give control over to a
social justice initiative that has no interest in the kernel's core
function or reason for existence.
Hi Michael,
On Mon, Sep 17, 2018 at 6:11 PM Joel Stanley wrote:
>
> On Fri, 14 Sep 2018 at 13:00, Guenter Roeck wrote:
> >
> > Commit 3e9efc3299dd ("i2c: aspeed: Handle master/slave combined irq events
> > properly") moved interrupt acknowledgment to the end of the interrupt
> > handler. In part this was don
Hi, Stefan
Anson Huang
Best Regards!
> -Original Message-
> From: Anson Huang
> Sent: Wednesday, September 12, 2018 4:30 PM
> To: Stefan Wahren ; shawn...@kernel.org;
> s.ha...@pengutronix.de; ker...@pengutronix.de; Fabio Estevam
> ; robh...@kernel.org; mark.rutl...@arm.com;
> linux-arm-
On Fri, 14 Sep 2018 at 13:00, Guenter Roeck wrote:
>
> Commit 3e9efc3299dd ("i2c: aspeed: Handle master/slave combined irq events
> properly") moved interrupt acknowledgment to the end of the interrupt
> handler. In part this was done because the AST2500 datasheet says:
>
> I2CD10 Interrupt Statu
On 09/17/2018 05:45 PM, Kees Cook wrote:
> On Mon, Sep 17, 2018 at 5:24 PM, Casey Schaufler
> wrote:
>> On 9/17/2018 5:00 PM, Kees Cook wrote:
>>> The legacy per-LSM
>>> enable/disable ordering is the same, but ordering between
>>> lsm.enable/disable and the per-LSM options is NOT ordered. i.e. t
On 09/17/2018 03:43 PM, Peter Zijlstra wrote:
On Mon, Sep 17, 2018 at 02:05:40PM -0700, Subhra Mazumdar wrote:
On 09/07/2018 05:25 AM, Peter Zijlstra wrote:
Why not just busy wait on current->state ? A little something like:
diff --git a/fs/pipe.c b/fs/pipe.c
index bdc5d3c0977d..8d9f1c95ff9
> -Original Message-
> From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On
> Behalf Of Wei Wang
> Sent: Thursday, September 06, 2018 7:31 PM
> To: linux-kernel@vger.kernel.org; k...@vger.kernel.org; pbonz...@redhat.com;
> a...@linux.intel.com
> Cc: kan.li...@intel.com; p
On Mon, Sep 17, 2018 at 5:57 PM, Casey Schaufler wrote:
> If I read you correctly, "first exclusive" would suit my needs just fine.
> I like the notion of build time ordering because I hate using the boot
> command line.
Okay, excellent. I think I have enough for a v2 on this. I'll crank it out..
On 9/17/2018 5:45 PM, Kees Cook wrote:
> On Mon, Sep 17, 2018 at 5:24 PM, Casey Schaufler
> wrote:
>> On 9/17/2018 5:00 PM, Kees Cook wrote:
>>> The legacy per-LSM
>>> enable/disable ordering is the same, but ordering between
>>> lsm.enable/disable and the per-LSM options is NOT ordered. i.e. the
To avoid #ifdef-ing out parts of the code and having conditionals in normal
control flow, let's define "get_id" transport method and move
implementation into respective transport modules.
Signed-off-by: Dmitry Torokhov
---
.../input/joystick/iforce/iforce-packets.c| 64 ---
d
Signalling command completion from iforce_process_packet() does
not make sense, as not all transport use the same data path for
both commands and motion data form the device, that is why USB
code already has to signal command completion iforce_usb_out().
Let's move signalling completion into indiv
According to our coding style case labels in switch statements should
be aligned with the switch keyword.
Signed-off-by: Dmitry Torokhov
---
drivers/input/joystick/iforce/iforce-ff.c | 18 +--
drivers/input/joystick/iforce/iforce-main.c | 70 +--
.../input/joystick/iforce/iforce-
When working with USB devices we need to use DMA-safe buffers,
and iforce->edata is not one. Let's rework the code to allocate
temporary buffer (iforce_get_id() is called only during initialization
so there is no reason to have permanent buffer) and use it. While at it,
let's utilize usb_control_ms
Now that we have moved enough transport details into separate source files
we can change them into transport modules so that they are only loaded when
needed.
Signed-off-by: Dmitry Torokhov
---
drivers/input/joystick/iforce/Kconfig | 8 ++---
drivers/input/joystick/iforce/Makefile
Note that the parent device for the USB-connected controllers is now
USB interface instead of USB device.
Signed-off-by: Dmitry Torokhov
---
drivers/input/joystick/iforce/iforce-main.c | 19 ---
drivers/input/joystick/iforce/iforce-serio.c | 2 +-
drivers/input/joystick/iforce/
Transport initialization code now deals mostly with transport-specific
data, so we can drop couple of temporary variables.
Signed-off-by: Dmitry Torokhov
---
drivers/input/joystick/iforce/iforce-serio.c | 7 ++-
drivers/input/joystick/iforce/iforce-usb.c | 7 ++-
2 files changed, 4 ins
Instead of open-coding conversion from/to little-endian, let's
use proper accessors.
Signed-off-by: Dmitry Torokhov
---
drivers/input/joystick/iforce/iforce-main.c| 7 ---
drivers/input/joystick/iforce/iforce-packets.c | 12
2 files changed, 12 insertions(+), 7 deletions(-)
Currently we credit entropy (via add_input_randomness()) regardless of
where an event comes form, a device itself, or an input handler, such as
evdev (and thus from userspace). While access to event devices is supposed
to be tightly controlled (one does not want random processes to be able to
obser
We want to move buffer handling into transport layers as the properties of
buffers (DMA-safety, alignment, etc) are different for different
transports. To allow this, let's allow caller to specify their own buffers
for the results of iforce_get_id_packet() and let transport drivers to
figure what b
Current code combines packet type and data length into single argument to
iforce_process_packet() and then has to untangle it. It is much clearer to
simply use separate arguments.
Signed-off-by: Dmitry Torokhov
---
drivers/input/joystick/iforce/iforce-packets.c | 9 +
drivers/input/joyst
This makes code clearer a bit.
Signed-off-by: Dmitry Torokhov
---
.../input/joystick/iforce/iforce-packets.c| 101 ++
1 file changed, 57 insertions(+), 44 deletions(-)
diff --git a/drivers/input/joystick/iforce/iforce-packets.c
b/drivers/input/joystick/iforce/iforce-packets
USB transport has to use cache line-aligned buffers for transfers to avoid
DMA issues; serio doe snot have such restrictions. Let's move "data_in"
buffer from main driver structure into transport modules and make sure USB
requirements are respected.
Signed-off-by: Dmitry Torokhov
---
drivers/inp
It is excessive to check if device is fully initialized in
iforce_process_packet(), as for USB-conected devices we do not start
collecting reports until the device is fully initialized.
Let's change serio transport code to not call iforce_process_packet()
until device initialization is done.
Sign
1 - 100 of 1058 matches
Mail list logo
