LTP CVE cve-2017-17053 test failed on x86_64 device

2018-06-19 Thread Naresh Kamboju
LTP CVE cve-2017-17053 test failed on x86_64 device. FAIL on linux-next, mainline, and stable-rc-4.17. PASS on stable-rc 4.16, 4.14, 4.9 and 4.4 kernel. Test FAIL case output, tst_test.c:1015: INFO: Timeout per run is 0h 15m 00s tst_taint.c:88: BROK: Kernel is already tainted: 512 Summary: passed

Re: [PATCH v7 4/4] input/power: Add driver for BD71837/BD71847 PMIC power button

2018-06-19 Thread Matti Vaittinen
Hello Dmitry, First of all - thanks for taking the time to review the patch =) On Tue, Jun 19, 2018 at 10:50:28AM -0700, Dmitry Torokhov wrote: > Hi Matti, > > On Tue, Jun 19, 2018 at 01:57:09PM +0300, Matti Vaittinen wrote: > > ROHM BD71837 PMIC power button driver providing power-key press >

Re: [PATCH 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-06-19 Thread Bjorn Andersson
On Mon 18 Jun 13:52 PDT 2018, Stephen Boyd wrote: > The interrupt controller hardware in this pin controller has two status > enable bits. The first "normal" status enable bit enables or disables > the summary interrupt line being raised when a gpio interrupt triggers > and the "raw" status enable

Re: [PATCH 4.16 161/279] kthread, sched/wait: Fix kthread_parkme() completion issue

2018-06-19 Thread Kohli, Gaurav
Hi Greg, As more patches related to this are coming in 4.17, so it is better if all go together on different branches, plz suggest. Regards Gaurav On 6/18/2018 1:42 PM, Greg Kroah-Hartman wrote: 4.16-stable review patch. If anyone has any objections, please let me know. --

Re: [PATCH V5 00/38] Intel(R) Resource Director Technology Cache Pseudo-Locking enabling

2018-06-19 Thread Reinette Chatre
Hi Thomas, On 6/19/2018 11:21 PM, Thomas Gleixner wrote: > On Tue, 19 Jun 2018, Reinette Chatre wrote: >> I am sorry for adding confusion by keeping the changelog from previous >> versions with each new submission. v3 had 39 patches with the last patch >> depending on Mike's work. I removed that f

Re: [PATCH v2] mdio-mux-gpio: Remove VLA usage

2018-06-19 Thread David Miller
From: Andrew Lunn Date: Wed, 20 Jun 2018 08:32:48 +0200 > Does it cleanly apply to net-next? net-next is closed, so net-next submissions should be sent when it opens back up which should be some time this weekend. Anything not in "Under Review" state in patchwork always must be resubmitted at t

Re: [REGRESSION] 4.17 failed to probe ACPI PnP

2018-06-19 Thread Takashi Iwai
On Tue, 19 Jun 2018 10:38:50 +0200, Takashi Iwai wrote: > > On Tue, 19 Jun 2018 10:28:42 +0200, > Rafael J. Wysocki wrote: > > > > On Tue, Jun 19, 2018 at 8:12 AM, Takashi Iwai wrote: > > > Hi, > > > > > > there seems a regression regarding the probe of ACPI PnP devices. > > > The detailed logs

Re: [PATCH] printk: Make CONSOLE_LOGLEVEL_QUIET configurable

2018-06-19 Thread Sergey Senozhatsky
On (06/19/18 09:31), Steven Rostedt wrote: > > The goal of passing the "quiet" option to the kernel is for the kernel > > to be quiet unless something really is wrong. > > > > Sofar passing quiet has been (mostly) equivalent to passing > > loglevel=4 on the kernel commandline. Which means to show

[PATCH v7 1/3] USB host: Add USB ehci support for nuvoton npcm7xx platform

2018-06-19 Thread avifishman70
From: Avi Fishman This patch adds support for ehci controller for the Nuvoton npcm7xx platform. Most of the code was taken from ehci-spear.c + specific initialization code Signed-off-by: Avi Fishman Acked-by: Alan Stern --- drivers/usb/host/Kconfig| 8 ++ drivers/usb/host/Makefile

Re: [PATCH v2] mdio-mux-gpio: Remove VLA usage

2018-06-19 Thread Andrew Lunn
On Tue, Jun 19, 2018 at 09:44:27PM -0700, Kees Cook wrote: > On Wed, May 30, 2018 at 1:57 PM, Andrew Lunn wrote: > > On Wed, May 30, 2018 at 01:48:30PM -0700, Kees Cook wrote: > >> In the quest to remove all stack VLA usage from the kernel[1], this > >> moves the allocation into struct mdio_mux_gp

Re: [PATCH V5 00/38] Intel(R) Resource Director Technology Cache Pseudo-Locking enabling

2018-06-19 Thread Thomas Gleixner
Reinette, On Tue, 19 Jun 2018, Reinette Chatre wrote: > I am sorry for adding confusion by keeping the changelog from previous > versions with each new submission. v3 had 39 patches with the last patch > depending on Mike's work. I removed that final patch in v4, planning to > resubmit it when Mik

[PATCH] x86/intel_rdt: Fix passing of value to 32-bit register

2018-06-19 Thread Reinette Chatre
0-day kbuild test robot reported the following issue: arch/x86/kernel/cpu/intel_rdt_pseudo_lock.c: In function 'pseudo_lock_fn': >> arch/x86/kernel/cpu/intel_rdt_pseudo_lock.c:363:1: warning: unsupported size >> for integer register } ^ >> arch/x86/kernel/cpu/intel_rdt_pseudo_lock.c:36

Re: [PATCH V2 2/2] PM / Domains: Rename opp_node to np

2018-06-19 Thread Viresh Kumar
On 20-06-18, 11:45, Viresh Kumar wrote: The subject should be "[PATCH V2 1/2] ***" instead. -- viresh

[PATCH v3 4/7] vmw_balloon: fix VMCI use when balloon built into kernel

2018-06-19 Thread Nadav Amit
Currently, when all modules, including VMCI and VMware balloon are built into the kernel, the initialization of the balloon happens before the VMCI is probed. As a result, the balloon fails to initialize the VMCI doorbell, which it uses to get asynchronous requests for balloon size changes. The pr

[PATCH v3 3/7] vmw_balloon: VMCI_DOORBELL_SET does not check status

2018-06-19 Thread Nadav Amit
When vmballoon_vmci_init() sets a doorbell using VMCI_DOORBELL_SET, for some reason it does not consider the status and looks at the result. However, the hypervisor does not update the result - it updates the status. This might cause VMCI doorbell not to be enabled, resulting in degraded performanc

[PATCH v3 7/7] vmw_balloon: update maintainers list

2018-06-19 Thread Nadav Amit
Philip Moltman is no longer a maintainer of the VMware balloon. Setting Nadav Amit as one instead. Reviewed-by: Xavier Deguillard Signed-off-by: Nadav Amit --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 624c3fd11d04..2e95f05f2

[PATCH v3 6/7] vmw_balloon: update copyright message

2018-06-19 Thread Nadav Amit
Removing the GPL wording and replace it with an SPDX tag. The immediate trigger for doing it now is the need to remove the list of maintainers from the source file, as the maintainer list changed. Reviewed-by: Xavier Deguillard Signed-off-by: Nadav Amit --- drivers/misc/vmw_balloon.c | 22 ++---

[PATCH V2 2/2] PM / Domains: Rename opp_node to np

2018-06-19 Thread Viresh Kumar
The DT node passed here isn't necessarily an OPP node, as this routine can also be used for cases where the "required-opps" property is present directly in the device's node. Rename it. This also removes a stale comment. Acked-by: Ulf Hansson Signed-off-by: Viresh Kumar --- V2: - Updated variab

[PATCH v3 0/7] vmw_balloon: addressing bugs and issues

2018-06-19 Thread Nadav Amit
All of these patches are intended for 4.18: - Patches 1-5 are bug fixes. - Patch 6 changes the GPL comment. It is actually required just to remove the maintainers list from the source file (since it has changed). - Patch 7 is an update to the maintainer list. This patch-set addresses minor i

[PATCH v3 5/7] vmw_balloon: remove inflation rate limiting

2018-06-19 Thread Nadav Amit
Since commit 33d268ed0019 ("VMware balloon: Do not limit the amount of frees and allocations in non-sleep mode."), the allocations are not increased, and therefore balloon inflation rate limiting is in practice broken. While we can restore rate limiting, in practice we see that it can result in ad

[PATCH v3 2/7] vmw_balloon: do not use 2MB without batching

2018-06-19 Thread Nadav Amit
If the hypervisor sets 2MB batching is on, while batching is cleared, the balloon code breaks. In this case the legacy mechanism is used with 2MB page. The VM would report a 2MB page is ballooned, and the hypervisor would only take the first 4KB. While the hypervisor should not report such setting

[PATCH v3 1/7] vmw_balloon: fix inflation of 64-bit GFNs

2018-06-19 Thread Nadav Amit
When balloon batching is not supported by the hypervisor, the guest frame number (GFN) must fit in 32-bit. However, due to a bug, this check was mistakenly ignored. In practice, when total RAM is greater than 16TB, the balloon does not work currently, making this bug unlikely to happen. Fixes: ef0

Re: [PATCH] proc: add missing '\0' back to /proc/$pid/cmdline

2018-06-19 Thread Michal Kubecek
On Wed, Jun 20, 2018 at 02:51:23PM +0900, Linus Torvalds wrote: > On Wed, Jun 20, 2018 at 2:08 PM Michal Kubecek wrote: > > > > > > > @@ -254,10 +258,19 @@ static ssize_t get_mm_cmdline(struct mm_struct *mm, > > > char __user *buf, > > > while (count) { > > > int got; > > >

Re: [PATCH 2/2] sched/fair: Advance global expiration when period timer is restarted

2018-06-19 Thread Xunlei Pang
On 6/20/18 1:49 AM, bseg...@google.com wrote: > Xunlei Pang writes: > >> On 6/19/18 2:58 AM, bseg...@google.com wrote: >>> Xunlei Pang writes: >>> I noticed the group frequently got throttled even it consumed low cpu usage, this caused some jitters on the response time to some of

KASAN: stack-out-of-bounds Read in unwind_next_frame

2018-06-19 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:ba4dbdedd3ed Merge tag 'jfs-4.18' of git://github.com/klei.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=17fe8bd840 kernel config: https://syzkaller.appspot.com/x/.config?x=f390986c4f7cd566 da

Re: [PATCH 1/1] arm64: dts: rockchip: correct voltage selector Firefly-RK3399

2018-06-19 Thread Heinrich Schuchardt
On 06/20/2018 01:21 AM, Heiko Stuebner wrote: > Hi Heinrich, > > Am Donnerstag, 14. Juni 2018, 14:55:27 CEST schrieb Heiko Stuebner: >> Am Montag, 4. Juni 2018, 19:15:23 CEST schrieb Heinrich Schuchardt: >>> Without this patch the Firefly-RK3399 board boot process hangs after these >>> lines: >>>

Re: [PATCH v3 1/4] seccomp: add a return code to trap to userspace

2018-06-19 Thread Tobin C . Harding
A few other piddly suggestions. On Thu, May 31, 2018 at 08:49:46AM -0600, Tycho Andersen wrote: > This patch introduces a means for syscalls matched in seccomp to notify > some other task that a particular filter has been triggered. > > The motivation for this is primarily for use with containers

Re: [PATCH 2/3] pinctrl: msm: Mux out gpio function with gpio_request()

2018-06-19 Thread Stephen Boyd
Quoting Doug Anderson (2018-06-19 14:38:57) > On Tue, Jun 19, 2018 at 2:18 PM, Stephen Boyd wrote: > > Quoting Doug Anderson (2018-06-18 16:54:49) > >> > >> Is there a reason why you'd want to return 0 instead of some sort of > >> error code? Wouldn't you want to know that this pin can't be a GPI

4.18.0-rc1-next-20180619 boot failed on beagle board x15

2018-06-19 Thread Naresh Kamboju
Linux next (4.18.0-rc1-next-20180619) boot failed on beagle board x15. Full log of trace please refer this link, https://lkft.validation.linaro.org/scheduler/job/291535#L946 Here is back trace, [3.561640] omap_rng 4809.rng: Random Number Generator ver. 20 [3.611949] brd: module

Re: [PATCH] proc: add missing '\0' back to /proc/$pid/cmdline

2018-06-19 Thread Linus Torvalds
On Wed, Jun 20, 2018 at 2:08 PM Michal Kubecek wrote: > > > > @@ -254,10 +258,19 @@ static ssize_t get_mm_cmdline(struct mm_struct *mm, > > char __user *buf, > > while (count) { > > int got; > > size_t size = min_t(size_t, PAGE_SIZE, count); > > We limit size to

[PATCH] proc: use ktime_get_coarse_boottime64

2018-06-19 Thread Allen Pais
get_monotonic_boottime() has been deprecated and might not be safe to call in every context. Change to use ktime_get_coarse_boottime_ts64. Signed-off-by: Allen Pais --- fs/proc/uptime.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/proc/uptime.c b/fs/proc/uptime.c i

Re: [Customers.Eckelmann] [PATCH] locking/rwsem: Fix up_read_non_owner() warning with DEBUG_RWSEMS

2018-06-19 Thread Schenk, Gavin
Hi, On Wed, 2018-06-20 at 07:09 +0800, Waiman Long wrote: > On 05/24/2018 09:26 PM, Waiman Long wrote: > > It was found that the use of up_read_non_owner() in NFS was causing > > the following warning when DEBUG_RWSEMS was configured. > > > > DEBUG_LOCKS_WARN_ON(sem->owner != ((struct task_stru

[PATCH v3 treewide] headers: separate linux/mod_devicetable.h from linux/platform_device.h

2018-06-19 Thread Randy Dunlap
From: Randy Dunlap At over 4000 #includes, is the 9th most #included header file in the Linux kernel. It does not need , so drop that header and explicitly add to source files that need it. 4146 #include After this patch, there are 225 files that use , for a reduction of around 3900 time

Re: [PATCH] printk: inject caller information into the body of message

2018-06-19 Thread Dmitry Vyukov
On Sat, May 26, 2018 at 8:36 AM, Dmitry Vyukov wrote: > On Thu, May 24, 2018 at 4:14 AM, Sergey Senozhatsky > wrote: >>> First, we should ask what we expect from this feature. >> >> Yeah. Can't really comment on this, it's up to Tetsuo and Dmitry to >> decide. So far I've seen slightly different

Re: [PATCH] net: nixge: Add __packed attribute to DMA descriptor struct

2018-06-19 Thread David Miller
From: Moritz Fischer Date: Tue, 19 Jun 2018 09:54:53 -0700 > @@ -122,7 +122,7 @@ struct nixge_hw_dma_bd { > u32 sw_id_offset; > u32 reserved5; > u32 reserved6; > -}; > +} __packed; As I understand it, based upon your replies to Florian, this bug doesn't even show up with the cu

[PATCH V2] nvme-pci: move nvme_kill_queues to nvme_remove_dead_ctrl

2018-06-19 Thread Jianchao Wang
There is race between nvme_remove and nvme_reset_work that can lead to io hang. nvme_removenvme_reset_work -> nvme_remove_dead_ctrl -> nvme_dev_disable -> quiesce request_queue

Re: [PATCH] Add quick erase format option

2018-06-19 Thread Richard Weinberger
On Mon, Aug 9, 2010 at 10:52 AM, Stefani Seibold wrote: > Am Montag, den 09.08.2010, 09:37 +0100 schrieb David Woodhouse: >> On Mon, 2010-08-09 at 09:25 +0100, stef...@seibold.net wrote: >> > From: Stefani Seibold >> > >> > This patch add a quick format option which skips erasing of already erase

Re: [PATCH] arm: dts: socfpga: denali needs nand_x_clk too

2018-06-19 Thread Richard Weinberger
Marek, Am Mittwoch, 20. Juni 2018, 06:52:09 CEST schrieb Marek Vasut: > On 06/19/2018 02:07 PM, Richard Weinberger wrote: > > The denali NAND flash controller needs at least two clocks to operate, > > nand_clk and nand_x_clk. > > Since 1bb88666775e ("mtd: nand: denali: handle timing parameters by

Re: [PATCH] nvme-pci: not invoke nvme_remove_dead_ctrl when change state fails

2018-06-19 Thread jianchao.wang
Hi Keith On 06/20/2018 12:39 AM, Keith Busch wrote: > On Tue, Jun 19, 2018 at 04:30:50PM +0800, Jianchao Wang wrote: >> There is race between nvme_remove and nvme_reset_work that can >> lead to io hang. >> >> nvme_removenvme_reset_work >> -> change state to DELETING >>

Re: [PATCH v2] kernel/hung_task.c: allow to set checking interval separately from timeout

2018-06-19 Thread Dmitry Vyukov
On Wed, Jun 20, 2018 at 1:03 AM, Andrew Morton wrote: > On Mon, 11 Jun 2018 13:10:04 +0200 Dmitry Vyukov wrote: > >> Currently task hung checking interval is equal to timeout, >> as the result hung is detected anywhere between timeout and 2*timeout. >> This is fine for most interactive environmen

Re: [PATCH V2 5/5] PCI: Unify slot and bus reset API

2018-06-19 Thread kbuild test robot
Hi Sinan, I love your patch! Yet something to improve: [auto build test ERROR on pci/next] [also build test ERROR on v4.18-rc1 next-20180619] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

[PATCH v2 00/10] Split i2c_lock_adapter into i2c_lock_root and i2c_lock_segment

2018-06-19 Thread Peter Rosin
Hi! With the introduction of mux-locked I2C muxes, the concept of locking only a segment of the I2C adapter tree was added. At the time, I did not want to cause a lot of extra churn, so left most users of i2c_lock_adapter alone and apparently didn't think enough about it; they simply continued to

Re: [PATCH v4 0/4] locking,drm: Fix ww mutex naming / algorithm inconsistency

2018-06-19 Thread Thomas Hellstrom
On 06/19/2018 11:45 AM, Peter Zijlstra wrote: I suspect you want this through the DRM tree? Ingo are you OK with that? Yes, I can ask Dave to pull this. Ingo? Thanks, Thomas

Re: [PATCH] proc: add missing '\0' back to /proc/$pid/cmdline

2018-06-19 Thread Michal Kubecek
On Wed, Jun 20, 2018 at 06:56:04AM +0900, Linus Torvalds wrote: > On Wed, Jun 20, 2018 at 1:24 AM Michal Kubecek wrote: > > > > Recent rewrite introduced a regression, /proc/$pid/cmdline is missing the > > trailing null character: > > > > mike@lion:/tmp> cat /proc/self/cmdline | od -t c > > 00

[PATCH v3 0/4] mtd: rawnand: support MT29F1G08ABAFAWP-ITE:F

2018-06-19 Thread Chris Packham
Hi, I'm looking at adding support for the Micron MT29F1G08ABAFAWP-ITE:F chip to one of our boards which uses the Marvell NFCv2 controller. This particular chip is a bit odd in that the datasheet states support for ONFI 1.0 but the revision number field is 00 00. It also is marked ABAFA but report

[PATCH v3 4/4] mtd: rawnand: micron: support 8/512 on-die ECC

2018-06-19 Thread Chris Packham
Micron MT29F1G08ABAFAWP-ITE:F supports an on-die ECC with 8 bits per 512 bytes. Add support for this combination. Signed-off-by: Chris Packham --- Changes in v2: - New Changes in v3: - Handle reporting of corrected errors that don't require a rewrite, expand comment for the ECC status bits. d

[PATCH v3 3/4] mtd: rawnand: micron: add fixup for ONFI revision

2018-06-19 Thread Chris Packham
Some Micron NAND chips (MT29F1G08ABAFAWP-ITE:F) report 00 00 for the revision number field of the ONFI parameter page. Rather than rejecting these outright assume ONFI version 1.0 if the revision number is 00 00. Reviewed-by: Boris Brezillon Signed-off-by: Chris Packham --- This is now qualified

[PATCH v3 2/4] mtd: rawnand: add manufacturer fixup for ONFI parameter page

2018-06-19 Thread Chris Packham
This is called after the ONFI parameter page checksum is verified and allows us to override the contents of the parameter page. Suggested-by: Boris Brezillon Reviewed-by: Boris Brezillon Signed-off-by: Chris Packham --- Changes in v2: - New Changes in v3: - Add doc comment and review from Boris

[PATCH v3 1/4] mtd: rawnand: marvell: Handle on-die ECC

2018-06-19 Thread Chris Packham
>From the controllers point of view this is the same as no or software only ECC. Reviewed-by: Boris Brezillon Signed-off-by: Chris Packham --- Changes in v2: - New Changes in v3: - Add review from Boris drivers/mtd/nand/raw/marvell_nand.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dri

Re: [PATCH v3 1/4] seccomp: add a return code to trap to userspace

2018-06-19 Thread Tobin C . Harding
On Thu, May 31, 2018 at 08:49:46AM -0600, Tycho Andersen wrote: > This patch introduces a means for syscalls matched in seccomp to notify > some other task that a particular filter has been triggered. > > The motivation for this is primarily for use with containers. For example, > if a container d

Re: linux-next: Signed-off-by missing for commit in the scsi-mkp tree

2018-06-19 Thread Stephen Rothwell
Hi Martin, On Tue, 19 Jun 2018 22:03:48 -0400 "Martin K. Petersen" wrote: > > > Commit > > > > 508fbc44bbb7 ("scsi: be2iscsi: Include null char in SET_HOST_DATA") > > > > is missing a Signed-off-by from its author. > > Fixed, thanks! Unfortunately, James had already merged your tree :-( -

Re: [PATCH] arm: dts: socfpga: denali needs nand_x_clk too

2018-06-19 Thread Marek Vasut
On 06/19/2018 02:07 PM, Richard Weinberger wrote: > The denali NAND flash controller needs at least two clocks to operate, > nand_clk and nand_x_clk. > Since 1bb88666775e ("mtd: nand: denali: handle timing parameters by > setup_data_interface()") nand_x_clk is used to derive timing settings. > > S

include/linux/syscalls.h:211:18: error: 'sys_mmap2' alias between functions of incompatible types 'long int(long unsigned int, long unsigned int, long unsigned int, long unsigned int, long unsigne

2018-06-19 Thread kbuild test robot
Hi Al, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: ba4dbdedd3edc2798659bcd8b1a184ea8bdd04dc commit: ee076e81fc14ca79334d02970cea66604f183a14 sparc: trivial conversions to {COMPAT_,}SYSCALL_DEFINE() date: 3 mon

Re: [PATCH v2] mdio-mux-gpio: Remove VLA usage

2018-06-19 Thread Kees Cook
On Wed, May 30, 2018 at 1:57 PM, Andrew Lunn wrote: > On Wed, May 30, 2018 at 01:48:30PM -0700, Kees Cook wrote: >> In the quest to remove all stack VLA usage from the kernel[1], this >> moves the allocation into struct mdio_mux_gpio_state during probe. >> >> [1] >> https://lkml.kernel.org/r/CA+5

linux-next: Tree for Jun 20

2018-06-19 Thread Stephen Rothwell
Hi all, Changes since 20180619: Undropped tree: userns The userns tree gained conflicts against the vfs tree. The akpm-current tree gained a conflict against the scsi tree. Non-merge commits (relative to Linus' tree): 1399 1468 files changed, 45747 insertions(+), 23865 dele

Re: [PATCH V9] powercap/drivers/idle_injection: Add an idle injection framework

2018-06-19 Thread Viresh Kumar
On 19-06-18, 15:23, Daniel Lezcano wrote: > Initially, the cpu_cooling device for ARM was changed by adding a new > policy inserting idle cycles. The intel_powerclamp driver does a > similar action. > > Instead of implementing idle injections privately in the cpu_cooling > device, move the idle in

pci: pci_printk use

2018-06-19 Thread Joe Perches
All the pci_printk uses are at KERN_DEBUG which is always emitted into the kernel logging whenever the console log level is high enough. Are any of these appropriate for conversion to pci_dbg to allow these only to be emitted via dynamic_debug or if necessary via a #define DEBUG during compilation

Re: [PATCH 1/2] staging: android: ashmem: Remove use of unlikely()

2018-06-19 Thread Joel Fernandes
On Tue, Jun 19, 2018 at 05:57:34PM -0700, Alistair Strachan wrote: > There is no speed difference, and it makes the code harder to read. > > Cc: Greg Kroah-Hartman > Cc: Arve Hjønnevåg > Cc: Todd Kjos > Cc: Martijn Coenen > Cc: de...@driverdev.osuosl.org > Cc: linux-kernel@vger.kernel.org > Cc

[PATCH] ARM: mvebu: declare asm symbols as character arrays in pmsu.c

2018-06-19 Thread Ethan Tuttle
With CONFIG_FORTIFY_SOURCE, memcpy uses the declared size of operands to detect buffer overflows. If src or dest is declared as a char, attempts to copy more than byte will result in a fortify_panic(). Address this problem in mvebu_setup_boot_addr_wa() by declaring mvebu_boot_wa_start and mvebu_b

Re: [PATCH 2/2 v2] staging: android: ashmem: Fix mmap size validation

2018-06-19 Thread Joel Fernandes
On Tue, Jun 19, 2018 at 05:57:35PM -0700, Alistair Strachan wrote: > The ashmem driver did not check that the size/offset of the vma passed > to its .mmap() function was not larger than the ashmem object being > mapped. This could cause mmap() to succeed, even though accessing parts > of the mappin

RE: [PATCH v6 6/8] platform/mellanox: Introduce support for Mellanox register access driver

2018-06-19 Thread Vadim Pasternak
> -Original Message- > From: Darren Hart [mailto:dvh...@infradead.org] > Sent: Wednesday, June 20, 2018 3:20 AM > To: Randy Dunlap > Cc: Vadim Pasternak ; andy.shevche...@gmail.com; > gre...@linuxfoundation.org; linux-kernel@vger.kernel.org; platform-driver- > x...@vger.kernel.org; j...

Re: [RFC][PATCH 0/6] Use printk_safe context for TTY and UART port locks

2018-06-19 Thread Sergey Senozhatsky
On (06/20/18 12:38), Linus Torvalds wrote: > On Wed, Jun 20, 2018 at 11:50 AM Sergey Senozhatsky > wrote: > > > > It's not UART on its own that immediately calls into printk(), that would > > be trivial to fix, it's all those subsystems that serial console driver > > can call into. > > We already

[PATCH v8 2/4] random: Return nbytes filled from hw RNG

2018-06-19 Thread Tobin C. Harding
Currently the function get_random_bytes_arch() has return value 'void'. If the hw RNG fails we currently fall back to using get_random_bytes(). This defeats the purpose of requesting random material from the hw RNG in the first place. There are currently no intree users of get_random_bytes_arch().

[PATCH v8 4/4] vsprintf: Add command line option debug_boot_weak_hash

2018-06-19 Thread Tobin C. Harding
Currently printing [hashed] pointers requires enough entropy to be available. Early in the boot sequence this may not be the case resulting in a dummy string '(ptrval)' being printed. This makes debugging the early boot sequence difficult. We can relax the requirement to use cryptographi

[PATCH v8 0/4] enable early printing of hashed pointers

2018-06-19 Thread Tobin C. Harding
Ted, Version 8 changes patch 2 which you previously acked. Change is to remove integer cast as suggested on LKML. I've kept the ACK. Changes made to patch with reviewed-by tag from Steve were acknowledged on LKML, I've also kept Steve's tag. Currently printing pointers early in the boot sequ

[PATCH v8 3/4] vsprintf: Use hw RNG for ptr_key

2018-06-19 Thread Tobin C. Harding
Currently we must wait for enough entropy to become available before hashed pointers can be printed. We can remove this wait by using the hw RNG if available. Use hw RNG to get keying material. Reviewed-by: Steven Rostedt (VMware) Suggested-by: Kees Cook Signed-off-by: Tobin C. Harding --- l

[PATCH v8 1/4] random: Fix whitespace pre random-bytes work

2018-06-19 Thread Tobin C. Harding
There are a couple of whitespace issues around the function get_random_bytes_arch(). In preparation for patching this function let's clean them up. Acked-by: Theodore Ts'o Signed-off-by: Tobin C. Harding --- drivers/char/random.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --

Re: [GIT PULL] HID fixes

2018-06-19 Thread Jiri Kosina
On Wed, 20 Jun 2018, Linus Torvalds wrote: > What is that odd binary blob i2c_hid_desc_override, and where does the > data come from? Not explained anywhere. Fair enough; it's a pretty standard HID descriptor override, but you're right that we're usually replacing it in a bit more verbose way. J

Re: [PATCH 0/2] serial: 8250_omap: Add compatible for AM654 UART

2018-06-19 Thread Tony Lindgren
* Nishanth Menon [180619 20:13]: > Hi, > > This series was previously send out as part of a larger AM654 UART > support series, but was determined to create a bit of merge conflicts > due to interdependence. Both patches look good to me: Acked-by: Tony Lindgren

Re: [PATCH] printk/nmi: Prevent deadlock when serializing NMI backtraces

2018-06-19 Thread Sergey Senozhatsky
On (06/19/18 22:32), Steven Rostedt wrote: > On Wed, 20 Jun 2018 10:58:34 +0900 > Sergey Senozhatsky wrote: > > > Which one of these you'd prefer to see in ftrace_dump(): > > > > - printk_nmi_direct_enter() / printk_nmi_direct_exit() > > The above appears to be the most sane. OK. The original

[PATCH V2 5/5] PCI: Unify slot and bus reset API

2018-06-19 Thread Sinan Kaya
Drivers are expected to call pci_reset_slot() or pci_reset_bus() by querying if a system supports hotplug or not. A survey showed that most drivers don't do this and we are leaking hotplug capability to the user. Hide pci_slot_reset() from drivers and embed into pci_bus_reset(). Change pci_reset_b

[PATCH V2 3/5] PCI: Hide pci_reset_bridge_secondary_bus() from drivers

2018-06-19 Thread Sinan Kaya
Rename pci_reset_bridge_secondary_bus() to pci_bridge_secondary_bus_reset() and move the declartation from linux/pci.h to drivers/pci.h to be used internally in PCI directory only. Signed-off-by: Sinan Kaya --- drivers/pci/hotplug/pciehp_hpc.c | 2 +- drivers/pci/pci.c| 11 +

[PATCH V2 4/5] PCI: Unify try slot and bus reset API

2018-06-19 Thread Sinan Kaya
Drivers are expected to call pci_try_reset_slot() or pci_try_reset_bus() by querying if a system supports hotplug or not. A survey showed that most drivers don't do this and we are leaking hotplug capability to the user. Hide pci_try_slot_reset() from drivers and embed into pci_try_bus_reset(). Ch

[PATCH V2 1/5] PCI: handle error return from pci_reset_bridge_secondary_bus()

2018-06-19 Thread Sinan Kaya
commit 01fd61c0b9bd ("PCI: Add a return type for pci_reset_bridge_secondary_bus()") added a return value to the function to return if a device is accessible following a reset. Callers are not checking the value. Pass error code up high in the stack if device is not accessible. Signed-off-by: Sina

[PATCH V2 2/5] IB/hfi1: use pci_reset_bus() for initiating pci secondary bus reset

2018-06-19 Thread Sinan Kaya
Getting ready to hide pci_reset_bridge_secondary_bus() from the drivers. pci_reset_bridge_secondary_bus() should only be used internally by the PCI code itself. Other drivers should rely on higher level pci_reset_xxx() API. Signed-off-by: Sinan Kaya --- drivers/infiniband/hw/hfi1/pcie.c | 4 +--

Re: [PATCH v10 3/7] i2c: fsi: Add port structures

2018-06-19 Thread Joel Stanley
On 20 June 2018 at 13:04, Benjamin Herrenschmidt wrote: > On Wed, 2018-06-13 at 14:36 -0500, Eddie James wrote: >> } >> >> +static int fsi_i2c_remove(struct device *dev) >> +{ >> + struct fsi_i2c_master *i2c = dev_get_drvdata(dev); >> + struct fsi_i2c_port *port; >> + >> + list_

linux-next: manual merge of the akpm-current tree with the scsi tree

2018-06-19 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the akpm-current tree got a conflict in: lib/percpu_ida.c between commit: acf3ff616ee2 ("scsi: Remove percpu_ida") from the scsi tree and commit: 0c4d6e08c775 ("lib/percpu_ida.c: don't do alloc from per-CPU list if there is none") from the akpm-curr

Re: [RFC][PATCH 0/6] Use printk_safe context for TTY and UART port locks

2018-06-19 Thread Linus Torvalds
On Wed, Jun 20, 2018 at 11:50 AM Sergey Senozhatsky wrote: > > It's not UART on its own that immediately calls into printk(), that would > be trivial to fix, it's all those subsystems that serial console driver > can call into. We already have the whole PRINTK_SAFE_CONTEXT_MASK model that only ad

Re: [PATCH v10 3/7] i2c: fsi: Add port structures

2018-06-19 Thread Benjamin Herrenschmidt
On Wed, 2018-06-13 at 14:36 -0500, Eddie James wrote: > } > > +static int fsi_i2c_remove(struct device *dev) > +{ > + struct fsi_i2c_master *i2c = dev_get_drvdata(dev); > + struct fsi_i2c_port *port; > + > + list_for_each_entry(port, &i2c->ports, list) { > + i2c_d

Re: [PATCH] MIPS: implement smp_cond_load_acquire() for Loongson-3

2018-06-19 Thread 陈华才
Hi, Peter and Paul, Loongson-3's Store Fill Buffer is nearly the same as your "Store Buffer", and it increases the memory ordering weakness. So, smp_cond_load_acquire() only need a __smp_mb() before the loop, not after every READ_ONCE(). In other word, the following code is just OK: #define sm

Re: [PATCH] __poll_t regressions this cycle

2018-06-19 Thread Al Viro
On Wed, Jun 20, 2018 at 10:57:41AM +0900, Linus Torvalds wrote: > On Mon, Jun 18, 2018 at 10:47 PM Al Viro wrote: > > > > Do you prefer it in one commit, or split into per-driver pieces? > > If it's all the exact same issue with the same commit message, then > just one commit. Some EPOLL... miss

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-19 Thread Xie XiuQi
Hi Lorenzo, Punit, On 2018/6/20 0:32, Lorenzo Pieralisi wrote: > On Tue, Jun 19, 2018 at 04:35:40PM +0100, Punit Agrawal wrote: >> Michal Hocko writes: >> >>> On Tue 19-06-18 15:54:26, Punit Agrawal wrote: >>> [...] In terms of $SUBJECT, I wonder if it's worth taking the original patch

Re: linux-next: manual merge of the userns tree with the vfs tree

2018-06-19 Thread Stephen Rothwell
Hi all, On Wed, 20 Jun 2018 11:44:41 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the userns tree got a conflict in: > > fs/proc/internal.h > > between commit: > > 0223e0999be2 ("procfs: Move proc_fill_super() to fs/proc/root.c") > > from the vfs tree and commit: > >

[PATCH v5 2/9] x86: objtool: use asm macro for better compiler decisions

2018-06-19 Thread Nadav Amit
GCC considers the number of statements in inlined assembly blocks, according to new-lines and semicolons, as an indication to the cost of the block in time and space. This data is distorted by the kernel code, which puts information in alternative sections. As a result, the compiler may perform inc

[PATCH v5 4/9] x86: alternatives: macrofy locks for better inlining

2018-06-19 Thread Nadav Amit
GCC considers the number of statements in inlined assembly blocks, according to new-lines and semicolons, as an indication to the cost of the block in time and space. This data is distorted by the kernel code, which puts information in alternative sections. As a result, the compiler may perform inc

[PATCH v5 3/9] x86: refcount: prevent gcc distortions

2018-06-19 Thread Nadav Amit
GCC considers the number of statements in inlined assembly blocks, according to new-lines and semicolons, as an indication to the cost of the block in time and space. This data is distorted by the kernel code, which puts information in alternative sections. As a result, the compiler may perform inc

Re: [PATCH V2] PCI: Enable PASID when End-to-End TLP is supported by all bridges

2018-06-19 Thread Sinan Kaya
On 6/19/2018 11:02 PM, Timur Tabi wrote: > On 6/19/18 9:14 PM, Sinan Kaya wrote: >> +    if (!(cap & PCI_EXP_DEVCAP2_E2ETLP)) >> +    return; >> + >> +    dev->eetlp_prefix = 1; > > How about: > > if (cap & PCI_EXP_DEVCAP2_E2ETLP) >     dev->eetlp_prefix = 1; > Both works. I'll wait

[PATCH v5 5/9] x86: bug: prevent gcc distortions

2018-06-19 Thread Nadav Amit
GCC considers the number of statements in inlined assembly blocks, according to new-lines and semicolons, as an indication to the cost of the block in time and space. This data is distorted by the kernel code, which puts information in alternative sections. As a result, the compiler may perform inc

[PATCH v5 1/9] Makefile: Prepare for using macros for inline asm

2018-06-19 Thread Nadav Amit
Using macros for inline assembly improves both readability and compilation decisions that are distorted by big assembly blocks that use alternative sections. Compile macros.S and use it to assemble all C files. Currently, only x86 will use it. Cc: Sam Ravnborg Cc: Masahiro Yamada Cc: Michal Mare

[PATCH v5 8/9] x86: cpufeature: use macros instead of inline assembly

2018-06-19 Thread Nadav Amit
Use assembly macros for static_cpu_has() and call them from inline assembly. This not only makes the code more readable, but also improves compilation decision, specifically inline decisions which GCC base on the number of new lines in inline assembly. The patch slightly increases the kernel size

[PATCH v5 7/9] x86: extable: use macros instead of inline assembly

2018-06-19 Thread Nadav Amit
Use assembly macros for exception-tables and call them from inline assembly. This not only makes the code more readable and allows to avoid the duplicate implementation, but also improves compilation decision, specifically inline decisions which GCC base on the number of new lines in inline assemb

[PATCH v5 9/9] x86: jump-labels: use macros instead of inline assembly

2018-06-19 Thread Nadav Amit
Use assembly macros for jump-labels and call them from inline assembly. This not only makes the code more readable, but also improves compilation decision, specifically inline decisions which GCC base on the number of new lines in inline assembly. As a result the code size is slightly increased.

Re: [PATCH V2] PCI: Enable PASID when End-to-End TLP is supported by all bridges

2018-06-19 Thread Timur Tabi
On 6/19/18 9:14 PM, Sinan Kaya wrote: + if (!(cap & PCI_EXP_DEVCAP2_E2ETLP)) + return; + + dev->eetlp_prefix = 1; How about: if (cap & PCI_EXP_DEVCAP2_E2ETLP) dev->eetlp_prefix = 1; -- Qualcomm Datacenter Technologies, Inc. as an affiliate of

[PATCH] staging: rtlwifi: Fix a possible sleep-in-atomic-context bug in _is_fw_read_cmd_down()

2018-06-19 Thread Jia-Ju Bai
The driver may sleep with holding a spinlock. The function call path (from bottom to top) in Linux-4.16.7 is: [FUNC] schedule drivers/staging/rtlwifi/halmac/rtl_halmac.c, 884: schedule in _is_fw_read_cmd_down drivers/staging/rtlwifi/halmac/rtl_halmac.c, 912: _is_f

Re: [RFC][PATCH 0/6] Use printk_safe context for TTY and UART port locks

2018-06-19 Thread Sergey Senozhatsky
On (06/19/18 22:34), Steven Rostedt wrote: > > > There is no valid reason why an UART driver should do a printk() of > > any sort inside the critical region where the console is locked. > > > > Just remove those printk's, don't add new crazy locking. > > Perhaps we should do an audit of the cons

RE: [PATCH V3 0/4] clk: new APIs to handle all available clocks

2018-06-19 Thread A.s. Dong
Ping > -Original Message- > From: A.s. Dong > Sent: Friday, May 25, 2018 6:37 PM > To: linux-...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > sb...@kernel.org; mturque...@baylibre.com; shawn...@kernel.org; dl- > linux-imx ; A.s. Dong > Su

Re: [RFC][PATCH 0/6] Use printk_safe context for TTY and UART port locks

2018-06-19 Thread Sergey Senozhatsky
On (06/20/18 11:01), Linus Torvalds wrote: > On Tue, Jun 19, 2018 at 5:30 PM Petr Mladek wrote: > > > > To make it clear. This patch set adds yet another spin_lock API. > > It behaves exactly as spin_lock_irqsafe()/spin_unlock_irqrestore() > > but in addition it sets printk_context. > > > > This p

Re: [RFC][PATCH 0/6] Use printk_safe context for TTY and UART port locks

2018-06-19 Thread Linus Torvalds
On Wed, Jun 20, 2018 at 11:34 AM Steven Rostedt wrote: > > Perhaps we should do an audit of the console drivers and remove all > printk, pr_* , WARN*, BUG* from them. Only the actual _printing_ parts. Just randomly, look at drivers/tty/vt/vt.c that does a lot of printing, and there's a lot of va

Re: [PATCH] drivers: base: initcall_debug logs for driver probe times

2018-06-19 Thread Greg Kroah-Hartman
On Tue, Jun 19, 2018 at 07:39:03PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Add initcall_debug logs for each driver device probe call, for example: > >probe of a380.ramoops returned after 3007 usecs > > This replaces the previous code added to report times for deferred > probes

[PATCH] drivers: base: initcall_debug logs for driver probe times

2018-06-19 Thread Todd Poynor
From: Todd Poynor Add initcall_debug logs for each driver device probe call, for example: probe of a380.ramoops returned after 3007 usecs This replaces the previous code added to report times for deferred probes. It also reports OF platform bus device creates that were formerly lumped t

  1   2   3   4   5   6   7   8   9   >