On 19-06-18, 15:23, Daniel Lezcano wrote: > Initially, the cpu_cooling device for ARM was changed by adding a new > policy inserting idle cycles. The intel_powerclamp driver does a > similar action. > > Instead of implementing idle injections privately in the cpu_cooling > device, move the idle injection code in a dedicated framework and give > the opportunity to other frameworks to make use of it. > > The framework relies on the smpboot kthreads which handles via its > main loop the common code for hotplugging and [un]parking. > > This code was previously tested with the cpu cooling device and went > through several iterations. It results now in split code and API > exported in the header file. It was tested with the cpu cooling device > with success. > > Signed-off-by: Daniel Lezcano <daniel.lezc...@linaro.org> > Cc: Viresh Kumar <viresh.ku...@linaro.org> > Cc: Eduardo Valentin <edubez...@gmail.com> > Cc: Javi Merino <javi.mer...@kernel.org> > Cc: Leo Yan <leo....@linaro.org> > Cc: Kevin Wangtao <kevin.wang...@linaro.org> > Cc: Vincent Guittot <vincent.guit...@linaro.org> > Cc: Rui Zhang <rui.zh...@intel.com> > Cc: Daniel Thompson <daniel.thomp...@linaro.org> > Cc: Peter Zijlstra <pet...@infradead.org> > Cc: Andrea Parri <andrea.pa...@amarulasolutions.com> > --- > > V9: > - Unconditionnally reset the should_run flag for all kthreads > belonging to the cpumask and remove the park() callback (Viresh Kumar) > - Fix up the typos in the comments (Viresh Kumar)
Looks great now. Can't think of any more races :) Reviewed-by: Viresh Kumar <viresh.ku...@linaro.org> -- viresh