Re: ipv6 redefinition build issue with 4.15-rc8

2018-01-16 Thread Daniel Wagner
Hi Neil, On 01/16/2018 07:51 PM, Neil MacLeod wrote: Since this commit in 4.15-rc8: https://github.com/torvalds/linux/commit/6926e041a8920c8ec27e4e155efa760aa01551fd building connman 1.35 with glibc 2.26 now fails as follows: http://ix.io/EbP I'm not sure if this is a kernel issue, a glibc i

linux-next: Tree for Jan 17

2018-01-16 Thread Stephen Rothwell
Hi all, Changes since 20180116: The arm64 tree gained conflicts against Linus' tree. The net-next tree gained conflicts against the net tree. The rdma tree gained a conflict against the rdma-fixes tree. The block tree gained a conflict against the dma-mapping tree. The kvm tree gai

Re: [PATCH v2 12/13] iommu/rockchip: Add runtime PM support

2018-01-16 Thread JeffyChen
Hi Tomasz, On 01/17/2018 03:38 PM, Tomasz Figa wrote: >>Don't we need to check here (and in _shutdown() too) if we have a >>domain attached? > >hmmm, right, the startup might been called by resume, so should check >iommu->domain here. > >but the shutdown would be called at the end of detach or

Re: [BUG 4.15-rc7] IRQ matrix management errors

2018-01-16 Thread Keith Busch
On Wed, Jan 17, 2018 at 08:34:22AM +0100, Thomas Gleixner wrote: > Can you trace the matrix allocations from the very beginning or tell me how > to reproduce. I'd like to figure out why this is happening. Sure, I'll get the irq_matrix events. I reproduce this on a machine with 112 CPUs and 3 NVMe

Re: [PATCH v2 11/13] iommu/rockchip: Use OF_IOMMU to attach devices automatically

2018-01-16 Thread JeffyChen
On 01/17/2018 03:30 PM, Tomasz Figa wrote: >but it's possible the probe failed after calling iommu_device_set_fwnode, so >i'll try to add some checks here, and maybe adjust probe() to prevent it >too. I think iommu_device_set_fwnode() is not enough for of_iommu_xlate() to find the IOMMU. The IOM

Re: [PATCH v2 1/2] nvme: add tracepoint for nvme_setup_cmd

2018-01-16 Thread Johannes Thumshirn
On Tue, Jan 16, 2018 at 05:49:54PM +0100, Christoph Hellwig wrote: > > + trace_seq_printf(p, "slba=%llu, length=%u, control=0x%x, dsmgmt=%u, > > reftag=%u", > > Overly long line. > > > +(unsigned long long)le64_to_cpu(rw.slba), > > u64 now always is an unsigned long long,

Re: [PATCH v2 01/13] iommu/rockchip: Request irqs in rk_iommu_probe()

2018-01-16 Thread JeffyChen
Hi Tomasz, On 01/17/2018 03:16 PM, Tomasz Figa wrote: >> >>This lacks consistency. of_irq_count() is used for counting, but >>platform_get_irq() is used for getting. Either platform_ or of_ API >>should be used for both and I'd lean for platform_, since it's more >>general. > >hmmm, right, i wa

Re: Power domain clock warnings on recent next

2018-01-16 Thread Krzysztof Kozlowski
On Wed, Jan 17, 2018 at 7:25 AM, Marek Szyprowski wrote: > Hi Krzysztof, > > On 2018-01-16 21:07, Krzysztof Kozlowski wrote: >> >> Hi everyone, >> >> Anyone already noticed or started bisecting warnings coming from >> clk_core_disable_lock/exynos_pd_power on recent linux-next? > > > Yes, I've noti

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-16 Thread Changwei Ge
It looks good to me. Reviewed-by: Changwei Ge On 2017/12/14 13:16, Gang He wrote: > As you know, ocfs2 has support trim the underlying disk via > fstrim command. But there is a problem, ocfs2 is a shared disk > cluster file system, if the user configures a scheduled fstrim > job on each file sys

Re: [Ocfs2-devel] [PATCH v2 1/2] ocfs2: add trimfs dlm lock resource

2018-01-16 Thread Changwei Ge
It looks good to me. Reviewed-by: Changwei Ge On 2017/12/14 13:16, Gang He wrote: > Introduce a new dlm lock resource, which will be used to > communicate during fstrim a ocfs2 device from cluster nodes. > > Signed-off-by: Gang He > --- > fs/ocfs2/dlmglue.c | 86 > +

Re: WARNING in can_rcv

2018-01-16 Thread Dmitry Vyukov
On Wed, Jan 17, 2018 at 8:12 AM, Eric Biggers wrote: > On Wed, Jan 17, 2018 at 07:39:24AM +0100, Oliver Hartkopp wrote: >> >> >> On 01/16/2018 07:11 PM, Dmitry Vyukov wrote: >> > On Tue, Jan 16, 2018 at 7:07 PM, Marc Kleine-Budde >> > wrote: >> > > On 01/16/2018 06:58 PM, syzbot wrote: >> > > >

Re: [PATCH v2 12/13] iommu/rockchip: Add runtime PM support

2018-01-16 Thread Tomasz Figa
On Wed, Jan 17, 2018 at 4:26 PM, JeffyChen wrote: > Hi Tomasz, > > Thanks for your reply. > > On 01/17/2018 02:20 PM, Tomasz Figa wrote: >> >> On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen >> [snip] >>> >>> +static int rk_iommu_startup(struct rk_iommu *iommu) >>> { >>> - struct rk_iommu *i

Re: [PATCH v3] retpoline: Add retpoline tag to VERMAGIC

2018-01-16 Thread Thomas Gleixner
On Tue, 16 Jan 2018, Andi Kleen wrote: > On Tue, Jan 16, 2018 at 10:24:53PM +0100, Thomas Gleixner wrote: > > On Tue, 16 Jan 2018, Andi Kleen wrote: > > > > > From: Andi Kleen > > > > > > Add a marker for retpoline to the module VERMAGIC. This catches > > > the case when a non RETPOLINE compile

[PATCH] x86/apic: Replace the redundant macros with an empty stub

2018-01-16 Thread Dou Liyang
The X86_LOCAL_APIC is depended on CONFIG X86_64, that means if CONFIG_X86_64=y, the X86_LOCAL_APIC must be y too. So, using if defined(CONFIG_X86_64) || defined(CONFIG_X86_LOCAL_APIC) ... is redundant. Remove the redundant macros and add an empty stub instead. also add some comments for init_

Re: [PATCH 32/32] aio: implement io_pgetevents

2018-01-16 Thread Christoph Hellwig
On Tue, Jan 16, 2018 at 07:41:24PM -0500, Jeff Moyer wrote: > I'd be willing to bet the issue is in your io_syscall6 implementation. > You pass in arg5 where arg6 should be used. Don't feel bad, it took me > the better part of today to figure that out. :) > > Here's an incremental diff on top of

Re: [PATCH v5 1/2] printk: Add console owner and waiter logic to load balance console writes

2018-01-16 Thread Byungchul Park
On 1/17/2018 11:19 AM, Byungchul Park wrote: On 1/10/2018 10:24 PM, Petr Mladek wrote: From: Steven Rostedt From: Steven Rostedt (VMware) This patch implements what I discussed in Kernel Summit. I added lockdep annotation (hopefully correctly), and it hasn't had any splats (since I fixed som

Re: [BUG 4.15-rc7] IRQ matrix management errors

2018-01-16 Thread Thomas Gleixner
On Tue, 16 Jan 2018, Keith Busch wrote: > On Tue, Jan 16, 2018 at 12:20:18PM +0100, Thomas Gleixner wrote: > > 8<-- > > diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c > > index f8b03bb8e725..3cc471beb50b 100644 > > --- a/arch/x86/kernel/apic/vector.c

Re: [PATCH v2 11/13] iommu/rockchip: Use OF_IOMMU to attach devices automatically

2018-01-16 Thread Tomasz Figa
On Wed, Jan 17, 2018 at 4:20 PM, JeffyChen wrote: > Hi Tomasz, > > Thanks for your reply. > > > On 01/17/2018 01:44 PM, Tomasz Figa wrote: >> >> On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen >> wrote: >>> >>> Converts the rockchip-iommu driver to use the OF_IOMMU infrastructure, >>> which allows a

kexec reboot fails with extra wbinvd introduced for AME SME

2018-01-16 Thread Dave Young
[Modify the subject since this is a new problem, original io vector issue has been fixed with one commit from Thomas] Add more cc according to below old discussion: https://lkml.org/lkml/2017/7/27/574 Tom, I'm not sure why you finally did not dynamically run wbinvd? On 01/04/18 at 11:15am, Dave Y

Re: [PATCH v2 05/13] iommu/rockchip: Fix error handling in init

2018-01-16 Thread Tomasz Figa
On Wed, Jan 17, 2018 at 4:14 PM, JeffyChen wrote: > Hi Tomasz, > > On 01/17/2018 01:26 PM, Tomasz Figa wrote: >> >> On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen >> wrote: >>> >>> It's hard to undo bus_set_iommu() in the error path, so move it to the >>> end of rk_iommu_probe(). >> >> >> Does this

Re: [PATCH v2 01/13] iommu/rockchip: Request irqs in rk_iommu_probe()

2018-01-16 Thread Tomasz Figa
On Wed, Jan 17, 2018 at 4:08 PM, JeffyChen wrote: > Hi Tomasz, > > Thanks for your reply. > > On 01/17/2018 12:21 PM, Tomasz Figa wrote: >> >> Hi Jeffy, >> >> Thanks for the patch. Please see my comments inline. >> >> On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen >> wrote: >> >> Please add patch d

Re: WARNING in can_rcv

2018-01-16 Thread Eric Biggers
On Wed, Jan 17, 2018 at 07:39:24AM +0100, Oliver Hartkopp wrote: > > > On 01/16/2018 07:11 PM, Dmitry Vyukov wrote: > > On Tue, Jan 16, 2018 at 7:07 PM, Marc Kleine-Budde > > wrote: > > > On 01/16/2018 06:58 PM, syzbot wrote: > > > > Hello, > > > > > > > > syzkaller hit the following crash on

Re: [PATCH 32/32] aio: implement io_pgetevents

2018-01-16 Thread Christoph Hellwig
On Wed, Jan 17, 2018 at 04:27:21AM +, Al Viro wrote: > On Tue, Jan 16, 2018 at 07:41:24PM -0500, Jeff Moyer wrote: > > if (sigmask) { > > - if (copy_from_user(&ksigmask, sigmask, sizeof(ksigmask))) > > + if (!access_ok(VERIFY_READ, sigmask, > > +

Re: [PATCH net-next] net: stmmac: Fix reception of Broadcom switches tags

2018-01-16 Thread Giuseppe CAVALLARO
Hi Florian for gmac4.x and gmac3.x series the ACS bit is the Automatic Pad or CRC Stripping, so the core strips the Pad or FCS on frames if the value of the length field is < 1536 bytes. For MAC10-100 there is the Bit 8 (ASTP) of the reg0 that does the same if len is < 46bytes. In your patch I

[PATCH v5 01/17] ASoC: fsl_ssi: Redefine RX and TX macros

2018-01-16 Thread Nicolin Chen
The RX and TX macros were defined implicitly and there was a potential risk if someone changes their values. Since they were defined to index the array ssi->regvals[2], this patch moves these two macros to fsl_ssi.c, closer to its owner ssi->regvals. And it also puts some comments here to limit th

[PATCH v5 04/17] ASoC: fsl_ssi: Maintain a mask of active streams

2018-01-16 Thread Nicolin Chen
Checking TE and RE bits in SCR register doesn't work for AC97 mode which enables SSIEN, TE and RE in the fsl_ssi_setup_ac97() that's called during probe(). So when running into the trigger(), it will always get the result of both TE and RE being enabled already, even if actually there is no active

[PATCH v5 05/17] ASoC: fsl_ssi: Rename fsl_ssi_disable_val macro

2018-01-16 Thread Nicolin Chen
The define of fsl_ssi_disable_val is not so clear as it mixes two steps of calculations together. And those parameter names are also a bit long to read. Since it just tries to exclude the shared bits from the regvals of current stream while the opposite stream is active, it's better to use somethi

[PATCH v5 03/17] ASoC: fsl_ssi: Clean up set_dai_tdm_slot()

2018-01-16 Thread Nicolin Chen
This patch replaces the register read with ssi->i2s_net for simplification. It also removes masking SSIEN from scr value since it's handled later by regmap_update_bits() to set this scr value back. Signed-off-by: Nicolin Chen Tested-by: Caleb Crome --- sound/soc/fsl/fsl_ssi.c | 7 ++- 1 fil

[PATCH v5 06/17] ASoC: fsl_ssi: Clear FIFO directly in fsl_ssi_config()

2018-01-16 Thread Nicolin Chen
The FIFO clear helper function is just one line of code now. So it could be cleaned up by removing it and calling regmap directly. Meanwhile, FIFO clear could be applied to all use cases, not confined to AC97. So this patch also moves FIFO clear in the trigger() to fsl_ssi_config() and removes the

[PATCH v5 08/17] ASoC: fsl_ssi: Add DAIFMT define for AC97

2018-01-16 Thread Nicolin Chen
The _fsl_ssi_set_dai_fmt() bypasses an undefined format for AC97 mode. However, it's not really necessary if AC97 has its complete format defined. So this patch adds a DAIFMT macro of complete format including a clock direction and polarity. Signed-off-by: Nicolin Chen Tested-by: Caleb Crome --

[PATCH v5 02/17] ASoC: fsl_ssi: Keep ssi->i2s_net updated

2018-01-16 Thread Nicolin Chen
The hw_params() overwrites i2s_net settings for special cases like mono-channel support, however, it doesn't update ssi->i2s_net as set_dai_fmt() does. This patch removes the local i2s_net variable and directly updates ssi->i2s_net in the hw_params() so that the driver can simply look up the ssi->

[PATCH v5 10/17] ASoC: fsl_ssi: Set xFEN0 and xFEN1 together

2018-01-16 Thread Nicolin Chen
It'd be safer to enable both FIFOs for TX or RX at the same time. Signed-off-by: Nicolin Chen Tested-by: Caleb Crome --- sound/soc/fsl/fsl_ssi.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index e5efee2..ba06

[PATCH v5 09/17] ASoC: fsl_ssi: Clean up fsl_ssi_setup_regvals()

2018-01-16 Thread Nicolin Chen
This patch cleans fsl_ssi_setup_regvals() by following changes: 1) Moving DBG bits to the first lines. 2) Setting SSIE, RE/TE as default and cleaning it for AC97 Signed-off-by: Nicolin Chen Tested-by: Caleb Crome --- sound/soc/fsl/fsl_ssi.c | 17 ++--- 1 file changed, 6 insertions(+

[PATCH v5 12/17] ASoC: fsl_ssi: Move one-time configurations to probe()

2018-01-16 Thread Nicolin Chen
The probe() could handle some one-time configurations since they will not be changed once being configured. Signed-off-by: Nicolin Chen Tested-by: Caleb Crome --- Changelog v2 * Moved all to fsl_ssi_hw_init() in platform probe() sound/soc/fsl/fsl_ssi.c | 39 ++-

[PATCH v5 07/17] ASoC: fsl_ssi: Clean up helper functions of trigger()

2018-01-16 Thread Nicolin Chen
The trigger() calls fsl_ssi_tx_config() and fsl_ssi_rx_config(), and both of them jump to fsl_ssi_config(). And fsl_ssi_config() later calls another fsl_ssi_rxtx_config(). However, the whole routine, especially fsl_ssi_config() function, is too complicated because of the folowing reasons: 1) It ha

[PATCH v5 13/17] ASoC: fsl_ssi: Setup AC97 in fsl_ssi_hw_init()

2018-01-16 Thread Nicolin Chen
AC97 configures most of registers earlier to start a communication with CODECs in order to successfully initialize CODEC. Currently, _fsl_ssi_set_dai_fmt() and fsl_ssi_setup_ac97() are called to get all SSI registers properly set. Since now the driver has a fsl_ssi_hw_init() to handle all register

[PATCH v5 17/17] ASoC: fsl_ssi: Use ssi->streams instead of reading register

2018-01-16 Thread Nicolin Chen
Since ssi->streams is being updated along with SCR register and its SSIEN bit, it's simpler to use it instead. Signed-off-by: Nicolin Chen Tested-by: Caleb Crome --- sound/soc/fsl/fsl_ssi.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound

[PATCH v5 16/17] ASoC: fsl_ssi: Move DT related code to a separate probe()

2018-01-16 Thread Nicolin Chen
This patch cleans up probe() function by moving all Device Tree related code into a separate function. It allows the probe() to be Device Tree independent. This will be very useful for future integration of imx-ssi driver which has similar functionalities while exists only because it supports non-D

[PATCH v5 14/17] ASoC: fsl_ssi: Clean up _fsl_ssi_set_dai_fmt()

2018-01-16 Thread Nicolin Chen
The _fsl_ssi_set_dai_fmt() is a helper function being called from fsl_ssi_set_dai_fmt() as an ASoC operation and fsl_ssi_hw_init() mainly for AC97 format initialization. This patch cleans the _fsl_ssi_set_dai_fmt() in following ways: * Removing *dev pointer in the parameters as it's included in th

[PATCH v5 11/17] ASoC: fsl_ssi: Use snd_soc_init_dma_data instead

2018-01-16 Thread Nicolin Chen
Since there is a helper function, use it to help readability. Signed-off-by: Nicolin Chen Tested-by: Caleb Crome --- sound/soc/fsl/fsl_ssi.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index ba06e94..e1fe511 100644

[PATCH v5 15/17] ASoC: fsl_ssi: Add bool synchronous to mark synchronous mode

2018-01-16 Thread Nicolin Chen
Using symmetric_rates in the cpu_dai_drv is a bit implicit, so this patch adds a bool synchronous instead. Signed-off-by: Nicolin Chen Tested-by: Caleb Crome --- Changelog v3 * Removed all cpu_dai_drv changes sound/soc/fsl/fsl_ssi.c | 13 - 1 file changed, 8 insertions(+), 5 delet

[PATCH v5 00/17] ASoC: fsl_ssi: Clean up - program flow level

2018-01-16 Thread Nicolin Chen
[ Maciej, could you please send your Tested-by/Reviewed-by for AC97 once you confirm this series? And Caleb, this version does not need a test for non-AC97 cases. Thanks both! ] ==Change log== v5 * Reworked the series by taking suggestions from Maciej for AC97 + Fixed SSI lockup issue

[PATCH] MIPS: use generic GCC library routines from lib/

2018-01-16 Thread Antony Pavlov
The commit b35cd9884fa5 ("lib: Add shared copies of some GCC library routines") makes it possible to share generic GCC library routines by several architectures. This commit removes several generic GCC library routines from arch/mips/lib/ in favour of similar routines from lib/. Signed-off-by: An

Re: [PATCH v3 8/9] x86: use __uaccess_begin_nospec and ASM_IFENCE in get_user paths

2018-01-16 Thread Dan Williams
On Tue, Jan 16, 2018 at 10:28 PM, Al Viro wrote: > On Tue, Jan 16, 2018 at 08:30:17PM -0800, Dan Williams wrote: >> On Tue, Jan 16, 2018 at 2:23 PM, Dan Williams >> wrote: >> > On Sat, Jan 13, 2018 at 11:33 AM, Linus Torvalds >> [..] >> > I'll respin this set along those lines, and drop the ifen

[tip:x86/pti] x86/cpufeature: Move processor tracing out of scattered features

2018-01-16 Thread tip-bot for Paolo Bonzini
Commit-ID: 4fdec2034b7540dda461c6ba33325dfcff345c64 Gitweb: https://git.kernel.org/tip/4fdec2034b7540dda461c6ba33325dfcff345c64 Author: Paolo Bonzini AuthorDate: Tue, 16 Jan 2018 16:42:25 +0100 Committer: Ingo Molnar CommitDate: Wed, 17 Jan 2018 07:38:39 +0100 x86/cpufeature: Move proc

Re: [PATCH 1/2] powerpc: export thread-tidr interfaces

2018-01-16 Thread Frederic Barrat
Hi, diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c index 2010e4c..f20c1ad 100644 --- a/arch/powerpc/kernel/process.c +++ b/arch/powerpc/kernel/process.c @@ -1560,6 +1560,7 @@ void clear_thread_tidr(struct task_struct *t) free_thread_tidr(t->thread.tidr);

Re: WARNING in can_rcv

2018-01-16 Thread Oliver Hartkopp
On 01/16/2018 07:11 PM, Dmitry Vyukov wrote: On Tue, Jan 16, 2018 at 7:07 PM, Marc Kleine-Budde wrote: On 01/16/2018 06:58 PM, syzbot wrote: Hello, syzkaller hit the following crash on a8750ddca918032d6349adbf9a4b6555e7db20da git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/

Re: general protection fault in __crypto_alg_lookup

2018-01-16 Thread Eric Biggers
On Tue, Dec 19, 2017 at 11:49:02PM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 6084b576dca2e898f5c101baef151f7bfdbb606d > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console o

Re: BUG: unable to handle kernel NULL pointer dereference in crypto_alg_tested

2018-01-16 Thread Eric Biggers
On Fri, Dec 22, 2017 at 11:33:02PM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 6084b576dca2e898f5c101baef151f7bfdbb606d > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console o

Re: general protection fault in crypto_remove_spawns

2018-01-16 Thread Eric Biggers
On Mon, Nov 27, 2017 at 10:56:46AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 1ea8d039f9edcfefb20d8ddfe136930f6e551529 > git://git.cmpxchg.org/linux-mmots.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached. > C repro

Re: KASAN: slab-out-of-bounds Write in sha3_update (2)

2018-01-16 Thread Eric Biggers
On Fri, Dec 22, 2017 at 11:22:38AM -0600, Eric Biggers wrote: > [+Cc keyri...@vger.kernel.org] > > On Fri, Dec 22, 2017 at 07:55:01AM -0800, syzbot wrote: > > Hello, > > > > syzkaller hit the following crash on > > 9035a8961b504d0997369509ab8c6b1f0a4ee33d > > git://git.kernel.org/pub/scm/linux/ke

drm: fix vmwgfx boot warning WAS Re: [PATCH] [RESEND] vmwgfx: use monotonic event timestamps

2018-01-16 Thread Thomas Hellstrom
Hi, Woody, On 01/16/2018 10:39 PM, Woody Suwalski wrote: Thomas, the same way my DRM patch has disappeared: Date Tue, 19 Dec 2017 11:50:57 -0800 From Sinclair Yeh <> Subject Re: [PATCH v.2] 4.15 vmgfx boot warning This looks okay to me. Since this is a core DRM patch I think S

Re: [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

2018-01-16 Thread Wang, Haiyue
On 2018-01-17 07:06, Joel Stanley wrote: On Tue, Jan 16, 2018 at 2:59 PM, Corey Minyard wrote: On 01/16/2018 05:43 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band IPMI communication between a server host and its BMC (BaseBoard Management Contro

Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup

2018-01-16 Thread Sergey Senozhatsky
On (01/16/18 11:13), Petr Mladek wrote: [..] > IMHO, it would make sense if flushing the printk buffer behaves > the same when called either from printk() or from any other path. > I mean that it should be aggressive and allow an effective > hand off. > > It should be safe as long as foo_specific_

Re: [PATCH] clk: stm32: add configuration flags for each of the stm32 drivers

2018-01-16 Thread Gabriel FERNANDEZ
Hi Benjamin, Just remove the extra blanck line. Otherwise you can addmy Acked-by: Gabriel Fernandez Best regards Gabriel On 01/15/2018 03:21 PM, Benjamin Gaignard wrote: > Add two configuration flags to be able to not compile all the time > stm32f and stm32h7 drivers when ARCH_STM32 is set. >

Re: [PATCH v3 8/9] x86: use __uaccess_begin_nospec and ASM_IFENCE in get_user paths

2018-01-16 Thread Al Viro
On Tue, Jan 16, 2018 at 08:30:17PM -0800, Dan Williams wrote: > On Tue, Jan 16, 2018 at 2:23 PM, Dan Williams > wrote: > > On Sat, Jan 13, 2018 at 11:33 AM, Linus Torvalds > [..] > > I'll respin this set along those lines, and drop the ifence bits. > > So now I'm not so sure. Yes, get_user_{1,2,

Re: Power domain clock warnings on recent next

2018-01-16 Thread Marek Szyprowski
s/arm-kernel/msg628881.html On next-20180116, Odroid XU3 and HC1 (Exynso5422): [0.882736] EXYNOS5420 PMU initialized [0.891979] [ cut here ] [0.892220] WARNING: CPU: 0 PID: 59 at ../drivers/clk/clk.c:811 clk_core_disable_lock+0x18/0x24 [0.892383] Modules l

[PATCH] Input: synaptics-rmi4 - prevent UAF reported by KASAN

2018-01-16 Thread Nick Desaulniers
KASAN found a UAF due to dangling pointer. As the report below says, rmi_f11_attention() accesses drvdata->attn_data.data, which was freed in rmi_irq_fn. [ 311.424062] BUG: KASAN: use-after-free in rmi_f11_attention+0x526/0x5e0 [rmi_core] [ 311.424067] Read of size 27 at addr 88041fd610db by

Re: [PATCH 2/2] blk-mq: simplify queue mapping & schedule with each possisble CPU

2018-01-16 Thread Ming Lei
Hi Jianchao, On Wed, Jan 17, 2018 at 01:24:23PM +0800, jianchao.wang wrote: > Hi ming > > Thanks for your kindly response. > > On 01/17/2018 11:52 AM, Ming Lei wrote: > >> It is here. > >> __blk_mq_run_hw_queue() > >> > >> WARN_ON(!cpumask_test_cpu(raw_smp_processor_id(), hctx->cpumask)

Re: [PATCH v2 12/13] iommu/rockchip: Add runtime PM support

2018-01-16 Thread Tomasz Figa
On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen wrote: > When the power domain is powered off, the IOMMU cannot be accessed and > register programming must be deferred until the power domain becomes > enabled. > > Add runtime PM support, and use runtime PM device link from IOMMU to > master to startu

Re: [PATCH] scsi: mptsas: remove duplicated assignment to pointer head

2018-01-16 Thread Martin K. Petersen
Colin, > The pointer head is re-assigned the same value twice, so remove the > second redundant assignment. Applied to 4.16/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

[PATCH 3/3] clocksource: Use ATTRIBUTE_GROUPS macro

2018-01-16 Thread Baolin Wang
Convert to use ATTRIBUTE_GROUPS to define one attribute group pointed by 'groups' of the device, which can avoid issuing device_create_file() many times. Signed-off-by: Baolin Wang --- kernel/time/clocksource.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff

[linux-next] kernel Oops when booting powerpc

2018-01-16 Thread Abdul Haleem
Greeting's linux-next kernel booted with kernel Oops on powerpc machine. Machine Type: Power 8 [bare-metal & PowerVM LPAR] kernel version: 4.15.0-rc7-next-20180115 test: Boot config: attached bootlogs: - ses 0:0:3:0: Attached Enclosure device ses 0:0:4:0: Attached Enclosure device Roundi

[PATCH 2/3] clocksource: Use DEVICE_ATTR_RW/RO/WO to define device attributes

2018-01-16 Thread Baolin Wang
Convert DEVICE_ATTR to DEVICE_ATTR_RW/RO/WO to make attributes' definition more clear. Signed-off-by: Baolin Wang --- kernel/time/clocksource.c | 43 +-- 1 file changed, 17 insertions(+), 26 deletions(-) diff --git a/kernel/time/clocksource.c b/kernel/t

Re: [PATCH 00/10] tools lib traceveent: Pull updates from trace-cmd library

2018-01-16 Thread Namhyung Kim
Hi Steve, On Thu, Jan 11, 2018 at 07:47:41PM -0500, Steven Rostedt wrote: > > I went through the commits that were added to event-parse in trace-cmd > and synced them up for what is in tools/lib/traceevent. These are > patches that are missing from the kernel tree. If I'm not too late.. Acked-b

[PATCH 1/3] clocksource: Skip to check the override clocksource if override name is empty

2018-01-16 Thread Baolin Wang
Some platforms will not set the override clocksource name to select, so we can skip to check the override clocksource when selecting one clocksource. Signed-off-by: Baolin Wang --- kernel/time/clocksource.c |4 1 file changed, 4 insertions(+) diff --git a/kernel/time/clocksource.c b/ke

Re: [PATCH][scsi-next] scsi: mpt3sas: make function _get_st_from_smid static

2018-01-16 Thread Martin K. Petersen
Colin, > The function _get_st_from_smid is local to the source and does > not need to be in global scope, so make it static. Applied to 4.16/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3 0/3] tracing: Fix the parser when processing strings w/ or w/o terminated '\0'

2018-01-16 Thread Du, Changbin
On Wed, Jan 17, 2018 at 02:45:24PM +0900, Namhyung Kim wrote: > Hello, > > On Wed, Jan 17, 2018 at 12:54:34PM +0800, Du, Changbin wrote: > > On Tue, Jan 16, 2018 at 12:42:26PM -0500, Steven Rostedt wrote: > > > On Tue, 16 Jan 2018 17:02:27 +0800 > > > changbin...@intel.com wrote: > > > > > > > Fr

Re: [PATCH] scsi: fnic: use kzalloc in fnic_fcoe_process_vlan_resp

2018-01-16 Thread Martin K. Petersen
Rasmus, > This saves a little .text and gets rid of the unmotivated line break and > the sizeof(...) style inconsistency. Applied to 4.16/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

[PATCH] fork: Allow stack to be wiped on fork

2018-01-16 Thread Kees Cook
One of the classes of kernel stack content leaks is exposing the contents of prior heap or stack contents when a new process stack is allocated. Normally, those stacks are not zeroed, and the old contents remain in place. With some types of stack content exposure flaws, those contents can leak to u

Hello

2018-01-16 Thread Merle Butler
Hello, I'm Mr. Merle Butler the mega winner of $218M In Mega Millions Jackpot, I'm donating to 5 random individuals if you get this email then your email was selected after a spin ball.I have spread most of my wealth over a number of charities and organizations. I and my wife Patricia Butler have

Re: [PATCH v3 0/3] tracing: Fix the parser when processing strings w/ or w/o terminated '\0'

2018-01-16 Thread Namhyung Kim
Hello, On Wed, Jan 17, 2018 at 12:54:34PM +0800, Du, Changbin wrote: > On Tue, Jan 16, 2018 at 12:42:26PM -0500, Steven Rostedt wrote: > > On Tue, 16 Jan 2018 17:02:27 +0800 > > changbin...@intel.com wrote: > > > > > From: Changbin Du > > > > > > I found there are some problems in the tracing p

Re: [PATCH v2 11/13] iommu/rockchip: Use OF_IOMMU to attach devices automatically

2018-01-16 Thread Tomasz Figa
On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen wrote: > Converts the rockchip-iommu driver to use the OF_IOMMU infrastructure, > which allows attaching master devices to their IOMMUs automatically > according to DT properties. > > Signed-off-by: Jeffy Chen > --- > > Changes in v2: None > > drivers

Re: [PATCH v6 5/5] kaslr: add kaslr_mem=nn[KMG]!ss[KMG] to avoid memory regions

2018-01-16 Thread Chao Fan
On Tue, Jan 16, 2018 at 11:34:23AM -0500, Luiz Capitulino wrote: >On Tue, 16 Jan 2018 08:43:20 +0800 >Baoquan He wrote: > >> On 01/15/18 at 08:49pm, Chao Fan wrote: >> > Hi Luiz, >> > >> > I don't know if this patch is OK for you. >> > Of coure you can only use kaslr_mem=nn@ss to solve the 1G hug

Re: [PATCH 2/5] perf unwind: Do not look at globals

2018-01-16 Thread Namhyung Kim
Hi Arnaldo, On Tue, Jan 16, 2018 at 05:05:20PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jan 16, 2018 at 08:49:09PM +0100, Jiri Olsa escreveu: > > On Tue, Jan 16, 2018 at 03:26:50PM -0300, Arnaldo Carvalho de Melo wrote: > > > > SNIP > > > > > diff --git a/tools/perf/builtin-c2c.c b/tools

Re: [PATCH v2 10/13] iommu/rockchip: Use IOMMU device for dma mapping operations

2018-01-16 Thread Tomasz Figa
On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen wrote: > Use the first registered IOMMU device for dma mapping operations, and > drop the domain platform device. > > This is similar to exynos iommu driver. > > Signed-off-by: Jeffy Chen > --- > > Changes in v2: None > > drivers/iommu/rockchip-iommu.

Re: [PATCH v2 02/13] iommu/rockchip: Suppress unbinding

2018-01-16 Thread Tomasz Figa
On Wed, Jan 17, 2018 at 1:23 PM, Tomasz Figa wrote: > On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen > wrote: >> It's not safe to unbind rockchip IOMMU driver. > > Might be good to explain why it is not safe and actually add that it > does not make any sense for such low level devices. Actually,

[PATCH v22 2/3] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2018-01-16 Thread Wei Wang
Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_VQ feature indicates the support of reporting hints of guest free pages to host via virtio-balloon. Host requests the guest to report free pages by sending a new cmd id to the guest via the free_page_report_cmd_id configuration register. When the gues

[PATCH v22 3/3] virtio-balloon: don't report free pages when page poisoning is enabled

2018-01-16 Thread Wei Wang
The guest free pages should not be discarded by the live migration thread when page poisoning is enabled with PAGE_POISONING_NO_SANITY=n, because skipping the transfer of such poisoned free pages will trigger false positive when new pages are allocated and checked on the destination. This patch add

[PATCH v22 1/3] mm: support reporting free page blocks

2018-01-16 Thread Wei Wang
This patch adds support to walk through the free page blocks in the system and report them via a callback function. Some page blocks may leave the free list after zone->lock is released, so it is the caller's responsibility to either detect or prevent the use of such pages. One use example of this

[PATCH v22 0/3] Virtio-balloon: support free page reporting

2018-01-16 Thread Wei Wang
This patch series is separated from the previous "Virtio-balloon Enhancement" series. The new feature, VIRTIO_BALLOON_F_FREE_PAGE_VQ, implemented by this series enables the virtio-balloon driver to report hints of guest free pages to the host. It can be used to accelerate live migration of VMs. H

Re: [PATCH v2 05/13] iommu/rockchip: Fix error handling in init

2018-01-16 Thread Tomasz Figa
On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen wrote: > It's hard to undo bus_set_iommu() in the error path, so move it to the > end of rk_iommu_probe(). Does this work fine now? I remember we used to need this called in an early initcall for all the ARM/ARM64 DMA stuff to work. Best regards, Toma

Re: [PATCH 4.14 023/159] mm/sparsemem: Allocate mem_section at runtime for CONFIG_SPARSEMEM_EXTREME=y

2018-01-16 Thread Baoquan He
Hi Kirill, I setup qemu 2.9.0 to test 5-level on kexec/kdump support. While both kexec and kdump reset to BIOS immediately after triggering. I saw your patch adding 5-level paging support for kexec. Wonder if your test succeeded to jump into kexec/kdump kernel, and what else I need to make it. By

Re: [PATCH 2/2] blk-mq: simplify queue mapping & schedule with each possisble CPU

2018-01-16 Thread jianchao.wang
Hi ming Thanks for your kindly response. On 01/17/2018 11:52 AM, Ming Lei wrote: >> It is here. >> __blk_mq_run_hw_queue() >> >> WARN_ON(!cpumask_test_cpu(raw_smp_processor_id(), hctx->cpumask) && >> cpu_online(hctx->next_cpu)); > I think this warning is triggered after the CPU o

Re: [PATCH 1/3] powerpc/32: Fix hugepage allocation on 8xx at hint address

2018-01-16 Thread Aneesh Kumar K.V
Christophe LEROY writes: >> >>> How should I split in separate patches ? Something like ? >>> 1/ Slice support for PPC32 > 2/ Activate slice for 8xx >> >> Yes something like that. Will you  be able to avoid that >>  if (SLICE_NUM_HIGH) from the code? That makes the code ugly. Right now >> i do

Re: [PATCH v2 04/13] iommu/rockchip: Fix error handling in probe

2018-01-16 Thread Tomasz Figa
On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen wrote: > Add missing iommu_device_sysfs_remove in error path. > > Also adjust sequence of deinit functions in the remove. > > Signed-off-by: Jeffy Chen > --- > > Changes in v2: None > > drivers/iommu/rockchip-iommu.c | 12 +++- > 1 file change

Re: [PATCH v2 1/2] phy: brcm-sata: Implement calibrate callback

2018-01-16 Thread Kishon Vijay Abraham I
On Friday 12 January 2018 07:01 AM, Florian Fainelli wrote: > Implement the calibration callback to allow turning on the Clock-Data > Recovery module clamping when necessary, e.g: during failure to identify > a SATA hard drive from ahci_brcm.c::brcm_ahci_read_id. > > Signed-off-by: Florian Faine

Re: [PATCH v3] retpoline: Add retpoline tag to VERMAGIC

2018-01-16 Thread Greg KH
On Tue, Jan 16, 2018 at 12:52:28PM -0800, Andi Kleen wrote: > From: Andi Kleen > > Add a marker for retpoline to the module VERMAGIC. This catches > the case when a non RETPOLINE compiled module gets loaded into > a retpoline kernel, making it insecure. > > It doesn't handle the case when retpol

Re: KVM: Fix stack-out-of-bounds read in write_mmio

2018-01-16 Thread Greg KH
On Tue, Jan 16, 2018 at 10:45:50PM +, Your Real Name wrote: Odd "real name" :( > Commit: e39d200fa5bf5b94a0948db0dae44c1b73b84a56 > Target Stable Tree Branch: 4.9.y Why only this specific branch? Why not all stable branches? You do not want to move from 4.9.y to 4.14.y and have a regressi

Re: [PATCH v3 0/3] tracing: Fix the parser when processing strings w/ or w/o terminated '\0'

2018-01-16 Thread Du, Changbin
On Tue, Jan 16, 2018 at 12:42:26PM -0500, Steven Rostedt wrote: > On Tue, 16 Jan 2018 17:02:27 +0800 > changbin...@intel.com wrote: > > > From: Changbin Du > > > > I found there are some problems in the tracing parser when I investiage the > > root > > cause of issues mentioned in below patch.

[PATCH] irqdomain: provide useful debugging information for irq domain

2018-01-16 Thread Yang Shunyong
With recent hashed kernel pointers change, output with %p will output hashed address. This patch changes %p to %px in irq domain debug information. As unprivileged user has no permission to mount debugfs or set printk level to KERN_DEBUG to access the information, changes in this patch are appropri

[PATCH V4 2/2] nvme-pci: fix the timeout case when reset is ongoing

2018-01-16 Thread Jianchao Wang
There could be request timeout when the reset is ongoing. nvme_timeout will not only meet the admin requests from the initializing procedure, but also the IO and admin requests from previous work before nvme_dev_disable is invoked. These requests should be handled separately. We could distinguish

[PATCH V4 1/2] nvme: add NVME_CTRL_RESET_PREPARE state

2018-01-16 Thread Jianchao Wang
Currently, the ctrl->state will be changed to NVME_CTRL_RESETTING before queue the reset work. This is not so strict. There could be a big gap before the reset_work callback is invoked. In addition, there is some disable work in the reset_work callback, strictly speaking, not part of reset work, an

[PATCH V4 0/2] nvme-pci: fix the timeout case when reset is ongoing

2018-01-16 Thread Jianchao Wang
Hello NVME_CTRL_RESETTING used to indicate the range of nvme initializing strictly in fd634f41(nvme: merge probe_work and reset_work), but it is not now. The NVME_CTRL_RESETTING is set before queue the reset_work, there could be a big gap before the reset work handles the outstanding requests. So

Re: [PATCH v5 1/2] printk: Add console owner and waiter logic to load balance console writes

2018-01-16 Thread Byungchul Park
On 1/17/2018 11:19 AM, Byungchul Park wrote: On 1/10/2018 10:24 PM, Petr Mladek wrote: From: Steven Rostedt From: Steven Rostedt (VMware) This patch implements what I discussed in Kernel Summit. I added lockdep annotation (hopefully correctly), and it hasn't had any splats (since I fixed som

[PATCH] print kdump kernel loaded status in stack dump

2018-01-16 Thread Dave Young
It is useful to print kdump kernel loaded status in dump_stack() especially when panic happens so that we can differenciate kdump kernel early hang and a normal panic in a bug report. Signed-off-by: Dave Young --- kernel/printk/printk.c |3 +++ 1 file changed, 3 insertions(+) --- linux-x

Re: [PATCH v3 8/9] x86: use __uaccess_begin_nospec and ASM_IFENCE in get_user paths

2018-01-16 Thread Dan Williams
On Tue, Jan 16, 2018 at 2:23 PM, Dan Williams wrote: > On Sat, Jan 13, 2018 at 11:33 AM, Linus Torvalds [..] > I'll respin this set along those lines, and drop the ifence bits. So now I'm not so sure. Yes, get_user_{1,2,4,8} can mask the pointer with the address limit result, but this doesn't wor

Re: [PATCH 32/32] aio: implement io_pgetevents

2018-01-16 Thread Al Viro
On Tue, Jan 16, 2018 at 07:41:24PM -0500, Jeff Moyer wrote: > if (sigmask) { > - if (copy_from_user(&ksigmask, sigmask, sizeof(ksigmask))) > + if (!access_ok(VERIFY_READ, sigmask, > +sizeof(void *) + sizeof(size_t)) || > + __

Re: [PATCH v2 02/13] iommu/rockchip: Suppress unbinding

2018-01-16 Thread Tomasz Figa
On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen wrote: > It's not safe to unbind rockchip IOMMU driver. Might be good to explain why it is not safe and actually add that it does not make any sense for such low level devices. Best regards, Tomasz

Re: [PATCH v2 01/13] iommu/rockchip: Request irqs in rk_iommu_probe()

2018-01-16 Thread Tomasz Figa
Hi Jeffy, Thanks for the patch. Please see my comments inline. On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen wrote: Please add patch description. > Suggested-by: Robin Murphy > Signed-off-by: Jeffy Chen > --- [snip] > - for (i = 0; i < iommu->num_irq; i++) { > - iommu->irq

  1   2   3   4   5   6   7   8   9   10   >