Re: [RFC PATCH net-next 0/4] net_cls for sys container

2014-01-05 Thread Libo Chen
On 2014/1/3 13:20, Cong Wang wrote: > On Thu, Jan 2, 2014 at 7:11 PM, Libo Chen wrote: >> Hi guys, >> >> Now, lxc created with veth can not be under control by >> cls_cgroup. >> >> the former discussion: >> http://lkml.indiana.edu/hypermail/linux/kernel/1312.1/00214.html >> >> In short, because cl

Re: [PATCH net 1/2] macvlan: forbid L2 fowarding offload for macvtap

2014-01-05 Thread Jason Wang
On 01/06/2014 03:35 PM, John Fastabend wrote: > On 01/05/2014 07:21 PM, Jason Wang wrote: >> L2 fowarding offload will bypass the rx handler of real device. This >> will make >> the packet could not be forwarded to macvtap device. Another problem >> is the >> dev_hard_start_xmit() called for macvta

Re: [PATCH] Staging: rtl8187se: fix styling issues in r8180_wx.c

2014-01-05 Thread Dan Carpenter
On Sun, Jan 05, 2014 at 02:49:20PM -0800, Joe Perches wrote: > > Needs parentheses > > if ((src->capability & WLAN_CAPABILITY_IBSS) != > (dst->capability & WLAN_CAPABILITY_IBSS)) > Yeah. You are right. regards, dan carpenter -- To unsubscribe from this list: send the line "un

Re: [sched] 23f0d2093c: -12.6% regression on sparse file copy

2014-01-05 Thread Joonsoo Kim
On Mon, Jan 06, 2014 at 03:10:07PM +0800, Fengguang Wu wrote: > Hi Joonsoo, > > On Mon, Jan 06, 2014 at 09:30:52AM +0900, Joonsoo Kim wrote: > > On Sun, Jan 05, 2014 at 05:04:56PM +0800, fengguang...@intel.com wrote: > > > Hi Joonsoo, > > > > > > We noticed the below changes for commit 23f0d2093c

Re: [PATCH] drivers: Remove unused devm_*_put functions

2014-01-05 Thread Alexandre Courbot
On Sat, Jan 4, 2014 at 5:22 AM, Josh Triplett wrote: > On Fri, Jan 03, 2014 at 08:07:22PM +0900, Alexandre Courbot wrote: >> On Thu, Jan 2, 2014 at 10:07 PM, Linus Walleij >> wrote: >> > On Sat, Dec 21, 2013 at 11:49 AM, Rashika Kheria >> > wrote: >> >> -/** >> >> - * devm_gpiod_put - Resource-

Re: [PATCH 01/21] perf tools: Introduce struct add_entry_iter

2014-01-05 Thread Namhyung Kim
On Sun, 5 Jan 2014 16:28:15 +0100, Jiri Olsa wrote: > On Tue, Dec 24, 2013 at 05:22:07PM +0900, Namhyung Kim wrote: >> From: Namhyung Kim >> +iter->rep = rep; >> +ret = perf_evsel__add_entry(evsel, &al, sample, machine, iter); > > you dont need to pass machine pointer, it's already in 'al'

Re: [PATCH 01/21] perf tools: Introduce struct add_entry_iter

2014-01-05 Thread Namhyung Kim
On Sun, 5 Jan 2014 15:55:42 +0100, Jiri Olsa wrote: > On Tue, Dec 24, 2013 at 05:22:07PM +0900, Namhyung Kim wrote: >> From: Namhyung Kim >> +static int >> +iter_finish_branch_entry(struct add_entry_iter *iter, >> + struct addr_location *al __maybe_unused) >> +{ >> +free(it

Re: [PATCH 1/4] tools lib traceevent: Add state member to struct trace_seq

2014-01-05 Thread Namhyung Kim
Hi Jiri, On Fri, 3 Jan 2014 14:24:25 +0100, Jiri Olsa wrote: > On Thu, Dec 19, 2013 at 06:34:23PM +0900, Namhyung Kim wrote: >> From: Namhyung Kim >> >> The trace_seq->state is for tracking errors during the use of >> trace_seq APIs and getting rid of die() in it. >> >> Signed-off-by: Namhyung

RE: [f2fs-dev] [PATCH 2/6] f2fs: convert inline_data for punch_hole

2014-01-05 Thread Jaegeuk Kim
Hi, 2013-12-31 (화), 14:08 +0800, Chao Yu: > Hi, > > One comment as following. > > > -Original Message- > > From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] > > Sent: Friday, December 27, 2013 12:00 PM > > Cc: linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; > > linux-f2fs-

[PATCH] regulator: act8865: Fix build error when !OF

2014-01-05 Thread Axel Lin
Fix below build error when !OF: CC [M] drivers/regulator/act8865-regulator.o drivers/regulator/act8865-regulator.c: In function 'act8865_pmic_probe': drivers/regulator/act8865-regulator.c:306:18: error: 'act8865_matches' undeclared (first use in this function) drivers/regulator/act8865-regulato

RE: [PATCHv8 1/4] pwm: Add Freescale FTM PWM driver support

2014-01-05 Thread li.xi...@freescale.com
Hi Arnd, > > Adding Greg here to make sure we have a common understanding in the future. > > ioread*() was indeed introduced for devices that can be both I/O and memory > space, and is a bit slowed than readl() on architectures that don't have > memory mapped I/O space (i.e. x86). > > However,

Re: [PATCH net 1/2] macvlan: forbid L2 fowarding offload for macvtap

2014-01-05 Thread John Fastabend
On 01/05/2014 07:21 PM, Jason Wang wrote: L2 fowarding offload will bypass the rx handler of real device. This will make the packet could not be forwarded to macvtap device. Another problem is the dev_hard_start_xmit() called for macvtap does not have any synchronization. Fix this by forbidding

Re: [PATCH] fix crash when using XFS on loopback

2014-01-05 Thread Joonsoo Kim
On Sat, Jan 04, 2014 at 12:45:45PM -0500, Mikulas Patocka wrote: > The patch 8456a648cf44f14365f1f44de90a3da2526a4776 causes crash in the > LVM2 testsuite on PA-RISC (the crashing test is fsadm.sh). The testsuite > doesn't crash on 3.12, crashes on 3.13-rc1 and later. > > Bad Address (null pointe

Re: [PATCH v4 0/6] Krait L1/L2 EDAC driver

2014-01-05 Thread Borislav Petkov
On Mon, Dec 30, 2013 at 12:14:11PM -0800, Stephen Boyd wrote: > This patchset adds support for the Krait L1/L2 cache error detection > hardware. The first patch fixes a generic framework bug. The next > two patches lay the groundwork for this driver to be added by > exporting percpu irq functions

Re: linux-next: build failure after merge of the mmc tree

2014-01-05 Thread Stephen Rothwell
Hi Shawn, On Mon, 6 Jan 2014 14:44:08 +0800 Shawn Guo wrote: > > Okay, I missed your point. The resolution needs the additional changes > as below. > > Shawn > > diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > index 91e5dd4..8b05648 100644 > ---

Re: How does a newbie find work?

2014-01-05 Thread Gideon D'souza
So I was thinking of this hideous project (don't laugh!) at tearing out the CFS scheduler and then rewriting a very dumb scheduler in it's place. What do you guys think? This is of course just to understand the scheduler better. I just don't know how large or ridiculous this is though :) On Mo

linux-next: manual merge of the tip tree with the pm tree

2014-01-05 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the tip tree got a conflict in drivers/acpi/acpi_extlog.c between commit 7ede9f8a1805 ("ACPI / extlog: replace open-coded _DSM code with helper functions") from the pm tree and commit 42139eb356e3 ("ACPI, eMCA: Combine eMCA/EDAC event reporting priority") from t

Re: [PATCH v4 2/9] phy: core: Add devm_of_phy_get to phy-core

2014-01-05 Thread Kishon Vijay Abraham I
On Friday 20 December 2013 06:54 PM, Kamil Debski wrote: Adding devm_of_phy_get will allow to get phys by supplying a pointer to the struct device_node instead of struct device. Signed-off-by: Kamil Debski --- drivers/phy/phy-core.c | 31 +++ include/linux/phy/

Re: [PATCH v4 1/9] phy: core: Add an exported of_phy_get function

2014-01-05 Thread Kishon Vijay Abraham I
Hi, On Friday 20 December 2013 06:54 PM, Kamil Debski wrote: Previously the of_phy_get function took a struct device * and was declared static. It was impossible to call it from another driver and thus it was impossible to get phy defined for a given node. The old function was renamed to _of_phy

Re: linux-next: build failure after merge of the spi tree

2014-01-05 Thread Baruch Siach
Hi Stephen, On Mon, Jan 06, 2014 at 06:03:05PM +1100, Stephen Rothwell wrote: > After merging the spi tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > drivers/spi/spi-dw-pci.c: In function 'spi_pci_probe': > drivers/spi/spi-dw-pci.c:50:29: error: 'dev' undeclared (firs

Re: [sched] 23f0d2093c: -12.6% regression on sparse file copy

2014-01-05 Thread Fengguang Wu
Hi Joonsoo, On Mon, Jan 06, 2014 at 09:30:52AM +0900, Joonsoo Kim wrote: > On Sun, Jan 05, 2014 at 05:04:56PM +0800, fengguang...@intel.com wrote: > > Hi Joonsoo, > > > > We noticed the below changes for commit 23f0d2093c ("sched: Factor out > > code to should_we_balance()") in test vm-scalabilit

linux-next: build failure after merge of the spi tree

2014-01-05 Thread Stephen Rothwell
Hi Mark, After merging the spi tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/spi/spi-dw-pci.c: In function 'spi_pci_probe': drivers/spi/spi-dw-pci.c:50:29: error: 'dev' undeclared (first use in this function) dwpci = devm_kzalloc(&pdev-dev, sizeof(struct dw_spi

Re: [PATCH net-next 3/3] r8152: replace the return value of rtl_ops_init

2014-01-05 Thread Joe Perches
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c [] > @@ -2721,18 +2722,20 @@ static bool rtl_ops_init(struct r8152 *tp, const > struct usb_device_id *id) [] > + if (ret) > + netif_err(tp, probe, tp->netdev, "Unknown Device"); This format should have a terminating

Re: linux-next: build failure after merge of the mmc tree

2014-01-05 Thread Dong Aisheng
On Mon, Jan 6, 2014 at 2:46 PM, Shawn Guo wrote: > On Mon, Jan 06, 2014 at 02:30:00PM +0800, Dong Aisheng wrote: >> Hi Shawn, >> >> How do you suggest to fix this issue? >> Can we cook a patch for it directly based on linux-next tree? > > No, we can not. No patch should be targeting linux-next tr

Re: linux-next: build failure after merge of the mmc tree

2014-01-05 Thread Shawn Guo
On Mon, Jan 06, 2014 at 02:30:00PM +0800, Dong Aisheng wrote: > Hi Shawn, > > How do you suggest to fix this issue? > Can we cook a patch for it directly based on linux-next tree? No, we can not. No patch should be targeting linux-next tree. I just gave a resolution to Stephen. Before Chris sh

Re: linux-next: build failure after merge of the mmc tree

2014-01-05 Thread Shawn Guo
On Mon, Jan 06, 2014 at 05:22:43PM +1100, Stephen Rothwell wrote: > Hi all, > > On Tue, 17 Dec 2013 16:06:19 +0800 Dong Aisheng wrote: > > > > I tested that Chris tree does not have problem. > > It's caused by IMX tree updates. > > > > Chris, > > Is the way Shawn suggested OK for you? > > Can w

[PATCH net-next 3/3] r8152: replace the return value of rtl_ops_init

2014-01-05 Thread Hayes Wang
Replace the boolean value with the error code for the return value of the rtl_ops_init(). Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 861568

[PATCH net-next 2/3] r8152: move the actions of saving the information of the device

2014-01-05 Thread Hayes Wang
Some information of the device may be used in other functions. Move the relative code to make sure it would be initialzed correctly before using it. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/usb/r8

[PATCH net-next 0/3] adjust the code of r8152

2014-01-05 Thread Hayes Wang
Replace some tabs and modify the return value of rtl_ops_init(). Hayes Wang (3): r8152: replace some tabs with spaces r8152: move the actions of saving the information of the device r8152: replace the return value of rtl_ops_init drivers/net/usb/r8152.c | 43 +++

[PATCH net-next 1/3] r8152: replace some tabs with spaces

2014-01-05 Thread Hayes Wang
Replace the tabs of the variables declaration with the spaces. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 13fabbb..095f15b 100644 --- a/drivers/

[PATCH] ASoC: simple-card: fix the DAPM routes map parsing

2014-01-05 Thread Xiubo Li
The simple-card's DAPM route maping is optional. For example, the spdif has no need of this. Signed-off-by: Xiubo Li --- sound/soc/generic/simple-card.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c i

linux-next: build failure after merge of the regulator tree

2014-01-05 Thread Stephen Rothwell
Hi all, After merging the regulator tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from /scratch/sfr/next/include/linux/cache.h:4:0, from /scratch/sfr/next/include/linux/time.h:4, from /scratch/sfr/next/include/linux/stat.

Re: linux-next: build failure after merge of the mmc tree

2014-01-05 Thread Shawn Guo
Hi Stephen, On Mon, Jan 06, 2014 at 05:22:43PM +1100, Stephen Rothwell wrote: > Hi all, > > On Tue, 17 Dec 2013 16:06:19 +0800 Dong Aisheng wrote: > > > > I tested that Chris tree does not have problem. > > It's caused by IMX tree updates. > > > > Chris, > > Is the way Shawn suggested OK for yo

Re: linux-next: build failure after merge of the mmc tree

2014-01-05 Thread Dong Aisheng
Hi Shawn, How do you suggest to fix this issue? Can we cook a patch for it directly based on linux-next tree? Regards Dong Aisheng On Mon, Jan 6, 2014 at 2:22 PM, Stephen Rothwell wrote: > Hi all, > > On Tue, 17 Dec 2013 16:06:19 +0800 Dong Aisheng wrote: >> >> I tested that Chris tree does no

Re: [PATCH 1/2] cpufreq: try to resume policies which failed on last resume

2014-01-05 Thread Viresh Kumar
On 3 January 2014 17:25, Bjørn Mork wrote: > Correct. And users not running a lock debugging kernel will of course > not even see the warning. Okay.. >> - It only happens when cpufreq_add_dev() fails during hibernation while >> we enable non-boot CPUs again to save image to disk. So, isn't a pro

[Patch Part1 V3 06/20] iommu/vt-d, trivial: print correct domain id of static identity domain

2014-01-05 Thread Jiang Liu
Field si_domain->id is set by iommu_attach_domain(), so we should only print domain id for static identity domain after calling iommu_attach_domain(si_domain, iommu), otherwise it's always zero. Signed-off-by: Jiang Liu --- drivers/iommu/intel-iommu.c |4 ++-- 1 file changed, 2 insertions(+)

[Patch Part1 V3 05/20] iommu/vt-d, trivial: refine support of 64bit guest address

2014-01-05 Thread Jiang Liu
In Intel IOMMU driver, it calculate page table level from adjusted guest address width as 'level = (agaw - 30) / 9', which assumes (agaw -30) could be divided by 9. On the other hand, 64bit is a valid agaw and (64 - 30) can't be divided by 9, so it needs special handling. This patch enhances Intel

[Patch Part1 V3 08/20] iommu/vt-d, trivial: clean up unused code

2014-01-05 Thread Jiang Liu
Remove dead code from VT-d related files. Signed-off-by: Jiang Liu --- drivers/iommu/dmar.c|2 -- drivers/iommu/intel-iommu.c | 25 - 2 files changed, 27 deletions(-) diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c index 5e7ba3b..f5f7b7d 100644 ---

[Patch Part1 V3 07/20] iommu/vt-d, trivial: check suitable flag in function detect_intel_iommu()

2014-01-05 Thread Jiang Liu
Flag irq_remapping_enabled is only set by intel_enable_irq_remapping(), which is called after detect_intel_iommu(). So moving pr_info() from detect_intel_iommu() to intel_enable_irq_remapping(), which also slightly simplifies implementation. Reviewed-by: Yijing Wang Signed-off-by: Jiang Liu ---

Re: linux-next: build failure after merge of the mmc tree

2014-01-05 Thread Stephen Rothwell
Hi all, On Tue, 17 Dec 2013 16:06:19 +0800 Dong Aisheng wrote: > > I tested that Chris tree does not have problem. > It's caused by IMX tree updates. > > Chris, > Is the way Shawn suggested OK for you? Can we have some resolution of this please? This failed to build again today so I have used

[Patch Part1 V3 04/20] iommu/vt-d: fix resource leakage on error recovery path in iommu_init_domains()

2014-01-05 Thread Jiang Liu
Release allocated resources on error recovery path in function iommu_init_domains(). Also improve printk messages in iommu_init_domains(). Acked-by: Yijing Wang Signed-off-by: Jiang Liu --- drivers/iommu/intel-iommu.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff -

[Patch Part1 V3 10/20] iommu/vt-d, trivial: use defined macro instead of hardcoding

2014-01-05 Thread Jiang Liu
Use defined macro instead of hardcoding in function set_ioapic_sid() for readability. Signed-off-by: Jiang Liu --- drivers/iommu/intel_irq_remapping.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c

[Patch Part1 V3 11/20] iommu/vt-d, trivial: simplify code with existing macros

2014-01-05 Thread Jiang Liu
Simplify vt-d related code with existing macros and introduce a new macro for_each_active_drhd_unit() to enumerate all active DRHD unit. Signed-off-by: Jiang Liu --- drivers/iommu/dmar.c|7 ++--- drivers/iommu/intel-iommu.c | 55 ---

[Patch Part1 V3 13/20] iommu/vt-d: keep shared resources when failed to initialize iommu devices

2014-01-05 Thread Jiang Liu
Data structure drhd->iommu is shared between DMA remapping driver and interrupt remapping driver, so DMA remapping driver shouldn't release drhd->iommu when it failed to initialize IOMMU devices. Otherwise it may cause invalid memory access to the interrupt remapping driver. Sample stack dump: [

[Patch Part1 V3 12/20] iommu/vt-d: fix invalid memory access when freeing DMAR irq

2014-01-05 Thread Jiang Liu
In function free_dmar_iommu(), it sets IRQ handler data to NULL before calling free_irq(), which will cause invalid memory access because free_irq() will access IRQ handler data when calling function dmar_msi_mask(). So only set IRQ handler data to NULL after calling free_irq(). Sample stack dump:

[Patch Part1 V3 16/20] iommu/vt-d: release invalidation queue when destroying IOMMU unit

2014-01-05 Thread Jiang Liu
Release associated invalidation queue when destroying IOMMU unit to avoid memory leak. Signed-off-by: Jiang Liu --- drivers/iommu/dmar.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c index 302e037..bb635fb 100644 --- a/drivers/iommu/dmar

[Patch Part1 V3 17/20] iommu/vt-d: fix wrong return value of dmar_table_init()

2014-01-05 Thread Jiang Liu
If dmar_table_init() fails to detect DMAR table on the first call, it will return wrong result on following calls because it always sets dmar_table_initialized no matter if succeeds or fails to detect DMAR table. Signed-off-by: Jiang Liu --- drivers/iommu/dmar.c | 29 ++

Re: [Patch v2 00/13] Introduce ACPI _DSM helper functions to simplify code

2014-01-05 Thread Jiang Liu
Thanks, Rafael! On 2014/1/6 5:58, Rafael J. Wysocki wrote: > On Thursday, December 19, 2013 08:38:09 PM Jiang Liu wrote: >> There are several drivers making use of ACPI _DSM method to detect >> and invoke device specific methods. Currently every driver has >> implemented its private version to sup

[Patch Part1 V3 15/20] iommu/vt-d: fix access after free issue in function free_dmar_iommu()

2014-01-05 Thread Jiang Liu
Function free_dmar_iommu() may access domain->iommu_lock by spin_unlock_irqrestore(&domain->iommu_lock, flags); after freeing corresponding domain structure. Sample stack dump: [8.912818] = [8.917072] [ BUG: held lock freed! ] [8.921335] 3.13.0-rc1-gerry

[Patch Part1 V3 14/20] iommu/vt-d: avoid double free in error recovery path

2014-01-05 Thread Jiang Liu
The g_iommus array will be freed twice when failed to initialize IOMMU devices, so fix the double free. Signed-off-by: Jiang Liu --- drivers/iommu/intel-iommu.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel

[Patch Part1 V3 18/20] iommu/vt-d, PCI, trivial: use dev_is_pci() instead of hardcoding

2014-01-05 Thread Jiang Liu
Use helper dev_is_pci() instead of hardcoding. Signed-off-by: Jiang Liu --- drivers/iommu/intel-iommu.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c index 03780eb..6fce741 100644 --- a/drivers/iommu/intel-iommu.c

[Patch Part1 V3 09/20] iommu/vt-d: mark internal functions as static

2014-01-05 Thread Jiang Liu
Function detect_intel_iommu()/alloc_iommu()/parse_ioapics_under_ir() are only used internally, so mark them as static. Signed-off-by: Jiang Liu --- drivers/iommu/dmar.c|9 ++--- drivers/iommu/intel_irq_remapping.c |4 +++- include/linux/dmar.h| 12 +-

[Patch Part1 V3 20/20] iommu/vt-d: free all resources if failed to initialize DMARs

2014-01-05 Thread Jiang Liu
Enhance intel_iommu_init() to free all resources if failed to initialize DMAR hardware. Signed-off-by: Jiang Liu --- drivers/iommu/intel-iommu.c | 81 ++- 1 file changed, 49 insertions(+), 32 deletions(-) diff --git a/drivers/iommu/intel-iommu.c b/drive

[Patch Part1 V3 19/20] iommu/vt-d, trivial: clean sparse warnings

2014-01-05 Thread Jiang Liu
Clean up most sparse warnings in Intel DMA and interrupt remapping drivers. Signed-off-by: Jiang Liu --- drivers/iommu/dmar.c|8 drivers/iommu/intel-iommu.c |4 ++-- drivers/iommu/intel_irq_remapping.c |4 ++-- drivers/iommu/irq_remapping.c |

[Patch Part1 V3 03/20] iommu/vt-d: fix a race window in allocating domain ID for virtual machines

2014-01-05 Thread Jiang Liu
Function intel_iommu_domain_init() may be concurrently called by upper layer without serialization, so use atomic_t to protect domain id allocation. Signed-off-by: Jiang Liu Cc: Alex Williamson --- drivers/iommu/intel-iommu.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[Patch Part1 V3 02/20] iommu/vt-d: fix PCI device reference leakage on error recovery path

2014-01-05 Thread Jiang Liu
Function dmar_parse_dev_scope() should release the PCI device reference count gained in function dmar_parse_one_dev_scope() on error recovery, otherwise it will cause PCI device object leakage. This patch also introduces dmar_free_dev_scope(), which will be used to support DMAR device hotplug. Re

[Patch Part1 V3 00/20] Bugfixes and improvements for Intel IOMMU drivers

2014-01-05 Thread Jiang Liu
This patchset includes several bugfixes and code improvements for Intel DMA remapping and interrupt remapping drivers. It's also a preparation for Intel IOMMU device hotplug. It applies to the latest mainstream kernel on top of commit 7e3528c3660a2e8602abc7858b0994d611f74bc3 It has been t

[Patch Part1 V3 01/20] iommu/vt-d: use dedicated bitmap to track remapping entry allocation status

2014-01-05 Thread Jiang Liu
Currently Intel interrupt remapping drivers uses the "present" flag bit in remapping entry to track whether an entry is allocated or not. It works as follow: 1) allocate a remapping entry and set its "present" flag bit to 1 2) compose other fields for the entry 3) update the remapping entry with th

Re: [PATCH] [media] cx18: introduce a helper function to void array overrun

2014-01-05 Thread Ethan Zhao
On Sun, Jan 5, 2014 at 2:09 PM, Dmitry Torokhov wrote: > Hi Ethan, > > On Sun, Jan 05, 2014 at 09:17:39AM +0800, Ethan Zhao wrote: >> cx18_i2c_register() is called in cx18_init_subdevs() with index >> greater than length of hw_bus array, that will cause array overrun, >> introduce a helper cx18_ge

linux-next: manual merge of the block tree with the f2fs tree

2014-01-05 Thread Stephen Rothwell
Hi Jens, Today's linux-next merge of the block tree got a conflict in fs/f2fs/data.c between various commits from the f2fs tree and commits 2c30c71bd653 ("block: Convert various code to bio_for_each_segment()") and 4f024f3797c4 ("block: Abstract out bvec iterator") from the block tree. I fixed it

Re: [PATCH] [media] saa7146: fix a possible NULL pointer reference in saa7146_set_position

2014-01-05 Thread Ethan Zhao
Dmitry, Yup,thank you point out that, need NULL pointer checking in calculate_video_dma_grab_packed() , I am not familiar with saa7146 too. wouldn't paper over it, just a fix to pass code review. Thanks, Ethan On Sun, Jan 5, 2014 at 2:14 PM, Dmitry Torokhov wrote: > On Sun, Jan 05, 2014 at 1

RE: [PATCH v2] ASoC: soc-core: add snd_soc_of_parse_master_clkdir() for dt

2014-01-05 Thread li.xi...@freescale.com
Hi I would like to know the current status of this patch, and there are some other patches that for simple-card are depended on this one. Thanks, -- > This patch adds snd_soc_of_parse_master_clkdir() and supports below > style on dt: > > master-clkdir-out; > > If this property is absent 0 wil

[PATCH V2] Staging: rtl8187se: fix styling issues in r8180_wx.c

2014-01-05 Thread Dan LaManna
This is a patch to the r8180_wx.c which fixes various whitespace issues, brace issues, casting/declaration syntax issues, and increases clarity in multi-line return statement. Signed-off-by: Dan LaManna --- drivers/staging/rtl8187se/r8180_wx.c | 53 +- 1 file ch

[PATCH v2] clk: sirf: re-arch to make the codes support both prima2 and atlas6

2014-01-05 Thread Barry Song
From: Barry Song sirfprima2 and sirfatlas6 are two different SoCs in CSR SiRF series. for prima2 and atlas6, there are many shared clocks but there are still some different register layout and hardware clocks, then result in different clock table. here we re-arch the driver to 1. clk-common.c pr

Re: [PATCH v2] arch: use ASM_NL instead of ';' for assembler new line character in the macro

2014-01-05 Thread Vineet Gupta
Hi Michal, On Friday 03 January 2014 06:08 PM, Michal Marek wrote: > On 2013-11-21 10:58, Vineet Gupta wrote: >> On 11/01/2013 11:15 AM, Vineet Gupta wrote: >>> +CC Sam, Tim, Joe, Michal, David >>> >>> Guys can you please take a look at this patch and suggest the best way to >>> merge. >>> >>> Th

[PATCH] ASoC: simple-card: Fix the sysclk selection.

2014-01-05 Thread Xiubo Li
For spdif there is no need to do the sysclk setting. Signed-off-by: Xiubo Li --- sound/soc/generic/simple-card.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c index 2eb8005..747334c 100644 --- a/sound

RE: [PATCHv8 RFC] pwm: Add Freescale FTM PWM driver support

2014-01-05 Thread li.xi...@freescale.com
> > > > +static inline int fsl_pwm_calculate_default_ps(struct fsl_pwm_chip > > > > *fpc, > > > > + enum fsl_pwm_clk index) > > > > +{ > > > > > > Why do you declare this (and other module-local) function as inline? > > > It is usually better let compil

RE: [PATCH 1/1] MTD: UBI: avoid program operation on NOR flash after erasure interrupted

2014-01-05 Thread qiwang
Attached is my patch modified, and I use git format-patch to generate this file. Please check it. Thanks -Original Message- From: Artem Bityutskiy [mailto:dedeki...@gmail.com] Sent: Thursday, January 02, 2014 11:11 PM To: Qi Wang 王起 (qiwang) Cc: Adrian Hunter; linux-kernel@vger.kernel.o

Latest Linux version known to be working with Fast Model

2014-01-05 Thread Mj Embd
Hi all, Can anyone help on this... Looking for latest linux version working with FastModel (A15x2 or A15x2_A7x2) along with device tree and config file. Many thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org Mor

RE: [PATCH 1/1] MTD: UBI: avoid program operation on NOR flash after erasure interrupted

2014-01-05 Thread qiwang
From: Qi Wang nor_erase_prepare() will be called before erase a NOR flash, it will program '0' into a block to mark this block. But program data into a erasure interrupted block can cause program timtout(several minutes at most) error, could impact other operation on NOR flash. So UBIFS can rea

RE: [PATCH 1/1] MTD: UBI: avoid program operation on NOR flash after erasure interrupted

2014-01-05 Thread qiwang
>Please, remember that I pushed your patch to a temporary branch, only >for you to be able to easily pick it. I do not send it upstream. >As I said, I need to you look at it and confirm that it is all-right. >And if it is not all-right, correct it. >This is because I modified it myself. >So wait

Re: linux-next: build failure after merge of the net-next tree

2014-01-05 Thread Hannes Frederic Sowa
On Mon, Jan 06, 2014 at 03:54:13PM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the net-next tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > In file included from net/core/dev.c:134:0: > include/linux/if_macvlan.h: In function 'macvlan_count_rx': > i

linux-next: build failure after merge of the net-next tree

2014-01-05 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: In file included from net/core/dev.c:134:0: include/linux/if_macvlan.h: In function 'macvlan_count_rx': include/linux/if_macvlan.h:68:3: error: invalid use of undefined type 'struct vlan

linux-next: build warning after merge of the net-next tree

2014-01-05 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c: In function 'qlcnic_send_filter': drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c:349:3: warning: passing argument 2 of 'ether_addr_equal

linux-next: manual merge of the net-next tree with the net tree

2014-01-05 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in net/ipv6/ip6_tunnel.c between commit abb6013cca14 ("ipv6: fix the use of pcpu_tstats in ip6_tunnel") from the net tree and commit 8f84985fec10 ("net: unify the pcpu_tstats and br_cpu_netstats as one") from the net-next tree.

linux-next: manual merge of the net-next tree with the net tree

2014-01-05 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_pf.c between commit f3e3ccf83bab ("qlcnic: Fix resource allocation for TX queues") from the net tree and commit 154d0c810c53 ("qlcnic: VLAN enhancement for 84XX adapters") from t

linux-next: manual merge of the net-next tree with the net tree

2014-01-05 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in net/ipv6/ip6_vti.c between commit 469bdcefdc47 ("ipv6: fix the use of pcpu_tstats in ip6_vti.c") from the net tree and commit 8f84985fec10 ("net: unify the pcpu_tstats and br_cpu_netstats as one") from the net-next tree. I fi

Re: [PATCH 0/9] re-shrink 'struct page' when SLUB is on.

2014-01-05 Thread Joonsoo Kim
On Fri, Jan 03, 2014 at 02:18:16PM -0800, Andrew Morton wrote: > On Fri, 03 Jan 2014 10:01:47 -0800 Dave Hansen wrote: > > > This is a minor update from the last version. The most notable > > thing is that I was able to demonstrate that maintaining the > > cmpxchg16 optimization has _some_ value

[PATCH v3] isdn: Drop big endian cpp checks from telespci and hfc_pci drivers

2014-01-05 Thread Guenter Roeck
With arm:allmodconfig, building the Teles PCI driver fails with telespci.c:294:2: error: #error "not running on big endian machines now" Similar, building the driver for HFC PCI-Bus cards fails with hfc_pci.c:1647:2: error: #error "not running on big endian machines now" Remove the big endian c

Re: [PATCH v2] isdn: Mark build for telespci and hfc_pci as broken for big endian ARM

2014-01-05 Thread Guenter Roeck
On 01/05/2014 05:39 PM, David Miller wrote: From: Guenter Roeck Date: Sun, 5 Jan 2014 11:49:27 -0800 With arm:allmodconfig, building the Teles PCI driver fails with telespci.c:294:2: error: #error "not running on big endian machines now" Similar, building the driver for HFC PCI-Bus cards fa

Re: Confusion about Pinctrl and GPIO

2014-01-05 Thread Rongrong Cao
Hi Linus and Stephen, Can you help on my question? Thanks a lot in advance! 2013/12/26 曹荣荣 : > Hi Linus and Stephen, > > I'm learning the pinctrl subsystem codes these days, and have a > confusion about it, I'm very appreciated if you can help. > > I noticed that Stephen submitted a patch for pinc

[PATCH 0/4] PREEMPT_RT support for sparc64

2014-01-05 Thread Allen Pais
Have tested it on UltraSparc T4 (Niagara4). Allen Pais (4): sparc64: use generic rwsem spinlocks rt sparc64: allow forced irq threading sparc64: convert spinlock_t to raw_spinlock_t in mmu_context_t sparc64: convert ctx_alloc_lock raw_spinlock_t arch/sparc/Kconfig |

[PATCH 2/4] sparc64: allow forced irq threading

2014-01-05 Thread Allen Pais
Forced irq threading is a prerequisite for RT. The following patch enables this on the sparc architecture. Acked-by: David S. Miller Signed-off-by: Allen Pais --- arch/sparc/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig index 554995d..aae

[PATCH 3/4] sparc64: convert spinlock_t to raw_spinlock_t in mmu_context_t

2014-01-05 Thread Allen Pais
In the attempt of get PREEMPT_RT working on sparc64 using linux-stable-rt version 3.10.22-rt19+, the kernel crash with the following trace: [ 1487.027884] I7: [ 1487.027885] Call Trace: [ 1487.027887] [004967dc] rt_mutex_setprio+0x3c/0x2c0 [ 1487.027892] [004afe20] task_blocks_o

[PATCH 4/4] sparc64: convert ctx_alloc_lock raw_spinlock_t

2014-01-05 Thread Allen Pais
This patch fixes the kernel crash faced while trying to attempt linux-stable-rt v3.10.22-rt19 on sparc64. [ 2317.606015] [008072f4] rt_spin_lock_slowlock+0x94/0x300 [ 2317.606020] [00451d74] get_new_mmu_context+0x14/0x160 [ 2317.606026] [00806394] switch_to_pc+0xd4/0x2a0

[PATCH 1/4] sparc64: use generic rwsem spinlocks rt

2014-01-05 Thread Allen Pais
This patch enables the use of generic rwsem spinlocks to support RT on sparc64 Acked-by: David S. Miller Signed-off-by: Allen Pais --- arch/sparc/Kconfig |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig index 6787bd3..554995d 1

[PATCH v2] Staging: comedi: fix spacing/style problem in das1800.c (and das6402.c)

2014-01-05 Thread Chase Southwood
This patch fixes a style issue regarding asterisk placement in das1800.c and das6402.c found by checkpatch.pl. Signed-off-by: Chase Southwood --- 2: Added fix for identical style problem in das6402.c, previous version only changed das1800.c. drivers/staging/comedi/drivers/das1800.c | 2 +- dr

Re: [PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs [v3]

2014-01-05 Thread rui wang
On 1/6/14, Prarit Bhargava wrote: > I tested this by doing a continuous loop of booting a system, downing all > cpus, and then rebooting. Before every reboot I grepped the dmesg log for > the do_IRQ warning to see if there were any additional do_IRQ warnings and > I do not see any after applying

Re: [PATCH 2/3] sparc64: convert spinlock_t to raw_spinlock_t in mmu_context_t

2014-01-05 Thread Allen Pais
> >> I did not think it'd be nice to put the call trace in the commit message. >> But if needed I can re-send them. > > The more information you provide in a commit message, the better. > > Please add those traces to the commit messages, and then you can add > my: > > Acked-by: David S. Miller

[PATCH net 1/2] macvlan: forbid L2 fowarding offload for macvtap

2014-01-05 Thread Jason Wang
L2 fowarding offload will bypass the rx handler of real device. This will make the packet could not be forwarded to macvtap device. Another problem is the dev_hard_start_xmit() called for macvtap does not have any synchronization. Fix this by forbidding L2 forwarding for macvtap. Cc: John Fastabe

[PATCH net 2/2] net: core: explicitly select a txq before doing l2 forwarding

2014-01-05 Thread Jason Wang
Currently, the tx queue were selected implicitly in ndo_dfwd_start_xmit(). The will cause several issues: - NETIF_F_LLTX was forced for macvlan device in this case which lead extra lock contention. - dev_hard_start_xmit() was called with NULL txq which bypasses the net device watchdog - dev_ha

Re: [PATCH 11/11] drivers: acpi: Include header file in debugfs.c and rectify prototype declaration in internal.h

2014-01-05 Thread Josh Triplett
On Mon, Jan 06, 2014 at 12:33:57AM +0100, Rafael J. Wysocki wrote: > On Tuesday, December 17, 2013 03:06:54 PM Rashika Kheria wrote: > > Include header file internal.h in debugfs.c and change the return > > value's type in header file internal.h. > > > > This eliminates the following warning in de

Re: TPM Changes for 3.14

2014-01-05 Thread Peter Hüwe
Hi James, > Please generate this against my next branch. Here it is - note: I cherry-picked the changes that went through the xen tree before applying my changes. The following changes since commit dcf4e392867bf98d50ad108ed7c2bfb941e8c33d: ima: remove unneeded size_limit argument from ima_eve

RE: [PATCH net-next v2 6/6] r8152: support RTL8153

2014-01-05 Thread hayeswang
Bjørn Mork [mailto:bj...@mork.no] [...] > Sorry, but then this makes even less sense. The active USB > configuration is user selectable and you should make any of > them work if > possible. Why can't the drivers figure out this at runtime? Excuse me. I have no idea about how to switch the con

RE: [PATCH net-next] r8152: fix the wrong return value

2014-01-05 Thread hayeswang
David Miller [mailto:da...@davemloft.net] > Sent: Saturday, January 04, 2014 9:38 AM > To: Hayeswang > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-...@vger.kernel.org > Subject: Re: [PATCH net-next] r8152: fix the wrong return value > > From: Hayes Wang > Date: Fri, 3 Jan

Re: [PATCH v2 10/10] IOMMU: Add intel iommu irq-remapping and dmar hotplug support

2014-01-05 Thread Yijing Wang
Hi Yinghai, Maybe we should add some guards to protect from initializing DMAR when we disable Intel IOMMU like append intel_iommu=off to boot command. Thanks! Yijing. On 2014/1/3 8:08, Yinghai Lu wrote: > during hostbridge hotadd/hotremove, we call acpi_pci_iommu_add/remove in > acpi_pci_root

linux-next: manual merge of the thermal tree with the pm tree

2014-01-05 Thread Stephen Rothwell
Hi Zhang, Today's linux-next merge of the thermal tree got a conflict in drivers/cpufreq/Kconfig between commit 109df086e002 ("cpufreq: Select PM_OPP rather than depending on it") from the pm tree and commit 77cff5926a14 ("cpufreq: cpufreq-cpu0: add dt node parsing for cooling device properties")

Re: [PATCH v2 10/10] IOMMU: Add intel iommu irq-remapping and dmar hotplug support

2014-01-05 Thread Yijing Wang
Hi Yinghai, There is a problem, consider that static DMAR table contains the hotplug CPU DMAR info(include drhd and atsr). So, if we enable irq remapping, all DMAR drhd unit and atsr unit will be parsed during boot path. When IOH hub object in DSDT was enumerated, we found device that support

Re: TPM Changes for 3.14

2014-01-05 Thread James Morris
On Sat, 4 Jan 2014, Peter H?we wrote: > Hi James, > > since the next merge window approaches, can you please pull the following TPM > Changes for 3.14? > I'll send the patches as replies to this email. > > > The following changes since commit 802eee95bde72fd0cd0f3a5b2098375a487d1eda: > > Li

Re: [RFC PATCH net-next 3/4] veth: backup classid befor switch net_ns

2014-01-05 Thread Libo Chen
On 2014/1/3 18:45, Sergei Shtylyov wrote: > Hello. > > On 03-01-2014 7:11, Libo Chen wrote: > >> dev_forward_skb will clear skb->sk, so we need save classid >> before that, otherwise the skb can not be under control by >> net_cls. > >> Signed-off-by: Libo Chen >> --- >> drivers/net/veth.c | 7

  1   2   3   >